summaryrefslogtreecommitdiffstats
path: root/chrome_elf
Commit message (Collapse)AuthorAgeFilesLines
* Increase accuracy when determining if the browser blacklist was setup.csharp@chromium.org2014-05-281-3/+3
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/298893004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273377 0039d316-1c4b-4281-b951-d872f2087c98
* Add OWNERS file for browser blacklist.robertshield@chromium.org2014-05-221-0/+3
| | | | | | | | | BUG=NONE TEST=NONE Review URL: https://codereview.chromium.org/292123011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272337 0039d316-1c4b-4281-b951-d872f2087c98
* For Chrome builds, only upload crashes when the build is official.thestig@chromium.org2014-05-211-9/+7
| | | | | | | | BUG=362783 Review URL: https://codereview.chromium.org/292933002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271840 0039d316-1c4b-4281-b951-d872f2087c98
* Fix prefered base addresses on win64jschuh@chromium.org2014-04-121-2/+12
| | | | | | | | | | | | We need a +4GB base so the loader will randomize above 4GB. BUG=361670 R=robertshield@chromium.org,jam@chromium.org NOTRY=TRUE Review URL: https://codereview.chromium.org/233413008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263540 0039d316-1c4b-4281-b951-d872f2087c98
* Use SYZYASAN instead of ADDRESS_SANITIZER.chrisha@google.com2014-03-271-5/+6
| | | | | | | | | | | We've seen different failure related to the fact that we use the same flag without providing the same API and functionality. BUG= TBR=jamesr Review URL: https://codereview.chromium.org/212643015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259855 0039d316-1c4b-4281-b951-d872f2087c98
* Stop chrome_elf from patching already patched functionscsharp@chromium.org2014-03-251-2/+3
| | | | | | | | BUG=353978 Review URL: https://codereview.chromium.org/208273006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259157 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure chrome_elf's breakpad client is actually uploading dumps.caitkp@chromium.org2014-03-241-1/+1
| | | | | | Review URL: https://codereview.chromium.org/206223006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259014 0039d316-1c4b-4281-b951-d872f2087c98
* Make chrome_elf use thunks instead of function pointers.caitkp@chromium.org2014-03-188-139/+264
| | | | | | | | | | | | | | 1. Add functionality to ServiceResolverThunk to copy a thunk without patching. 2. Move chrome_elf thunk-handling code to a common location. 3. Use a thunk instead of a f'n ptr for redirects. BUG=334379 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255151 Review URL: https://codereview.chromium.org/183833004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257749 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure CreateFile call is not inlined, so EMET doesn't get upset.caitkp@chromium.org2014-03-131-8/+29
| | | | | | | | BUG=348383 Review URL: https://codereview.chromium.org/197863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256751 0039d316-1c4b-4281-b951-d872f2087c98
* Use PEImage in ntdll_cache.cccsharp@chromium.org2014-03-122-36/+24
| | | | | | | | | | | Use the exported functions iterator in PEImage instead of writing our own. BUG= Review URL: https://codereview.chromium.org/192933003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256424 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 255151 "Make chrome_elf use thunks instead of function po..."caitkp@chromium.org2014-03-077-229/+133
| | | | | | | | | | | | | | | | | | | (Crashy on today's canary) > Make chrome_elf use thunks instead of function pointers. > > 1. Add functionality to ServiceResolverThunk to copy a thunk without patching. > 2. Move chrome_elf thunk-handling code to a common location. > 3. Use a thunk instead of a f'n ptr for redirects. > > BUG=334379 > > Review URL: https://codereview.chromium.org/183833004 TBR=caitkp@chromium.org Review URL: https://codereview.chromium.org/189803007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255703 0039d316-1c4b-4281-b951-d872f2087c98
* Add version resource to chrome_elf.dllrobertshield@chromium.org2014-03-072-0/+29
| | | | | | | | | BUG=349926 TEST=NONE Review URL: https://codereview.chromium.org/183973039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255570 0039d316-1c4b-4281-b951-d872f2087c98
* Make chrome_elf use thunks instead of function pointers.caitkp@chromium.org2014-03-057-133/+229
| | | | | | | | | | | | 1. Add functionality to ServiceResolverThunk to copy a thunk without patching. 2. Move chrome_elf thunk-handling code to a common location. 3. Use a thunk instead of a f'n ptr for redirects. BUG=334379 Review URL: https://codereview.chromium.org/183833004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255151 0039d316-1c4b-4281-b951-d872f2087c98
* Catch EXCEPTION_GUARD_PAGE in SafeGetImageInfocsharp@chromium.org2014-03-041-0/+1
| | | | | | | | | | SafeGetImageInfo shouldn't raise exceptions. BUG=348693 Review URL: https://codereview.chromium.org/185533008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254870 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Version Check when Determining if Blacklist is Enabledcsharp@chromium.org2014-03-043-30/+0
| | | | | | | | | | | If the registry says the blacklist is enabled, then enable it, even if it was enabled for a different version of Chrome. BUG=329023 Review URL: https://codereview.chromium.org/178543011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254819 0039d316-1c4b-4281-b951-d872f2087c98
* Add UMA stats to record when DLLs are successfully blocked in the Browser.csharp@chromium.org2014-03-0312-14/+210
| | | | | | | | BUG=345287 Review URL: https://codereview.chromium.org/174013007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254480 0039d316-1c4b-4281-b951-d872f2087c98
* Unify browser process type checks in Chrome ELF.robertshield@chromium.org2014-03-014-13/+22
| | | | | | | | | | | Use both IsSandboxed and command line flag. BUG=329023 TEST=chrome_elf_unittests Review URL: https://codereview.chromium.org/181863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254308 0039d316-1c4b-4281-b951-d872f2087c98
* Only add chrome_redirects as a dependency of base.dll in component builds.caitkp@chromium.org2014-02-281-54/+0
| | | | | | | | | This will cover most of the CreateFile calls and save us from death by circular gyp dependencies. Review URL: https://codereview.chromium.org/183773003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254231 0039d316-1c4b-4281-b951-d872f2087c98
* Link chrome_elf.dll instead of statically linking the blacklist codecsharp@chromium.org2014-02-277-29/+60
| | | | | | | | | | | | This ensure that the dll code is referenced, instead of the target making its own copy. TBR=sky@chromium.org BUG=329023 Review URL: https://codereview.chromium.org/181373003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253847 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Link chrome_elf.dll instead of statically linking the blacklist ↵ckocagil@chromium.org2014-02-261-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | code (https://codereview.chromium.org/176873012/) Reason for revert: Broke unit_tests on Win 7 debug: http://build.chromium.org/p/chromium.win/buildstatus?builder=Win7%20Tests%20%28dbg%29%281%29&number=26698 Original issue's description: > Link chrome_elf.dll instead of statically linking the blacklist code > > This ensure that the dll code is referenced, instead of the target > making its own copy. > > > BUG=329023 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253366 TBR=robertshield@chromium.org,sky@chromium.org,csharp@chromium.org NOTREECHECKS=true NOTRY=true BUG=329023 Review URL: https://codereview.chromium.org/181343003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253399 0039d316-1c4b-4281-b951-d872f2087c98
* Link chrome_elf.dll instead of statically linking the blacklist codecsharp@chromium.org2014-02-261-0/+3
| | | | | | | | | | | | This ensure that the dll code is referenced, instead of the target making its own copy. BUG=329023 Review URL: https://codereview.chromium.org/176873012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253366 0039d316-1c4b-4281-b951-d872f2087c98
* Modify fileAtPath stat to track if the call was redirected by chrome_elf.caitkp@chromium.org2014-02-256-0/+37
| | | | | | | | TEST=Manual: Start chrome.exe, wait ~60s and check chrome://histograms, the Stability.FileAtPath metric should have run (at least) once, and the resulting value should be 6, assuming the check succeeded. Review URL: https://codereview.chromium.org/169093007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253251 0039d316-1c4b-4281-b951-d872f2087c98
* Breakpad coverage for chrome_elf start upcaitkp@chromium.org2014-02-2413-40/+724
| | | | | | Review URL: https://codereview.chromium.org/154653002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252870 0039d316-1c4b-4281-b951-d872f2087c98
* Moving version script and gypi file to build\util.mad@chromium.org2014-02-211-1/+1
| | | | | | | | | | | | BUG=343792 OK, it's been almost a week now, with regular pings to OWNERs, so I guess it's OK to TBR... It's only Gyp/script changes anyway... Feel free to uncheck the CQ box if you disagree... TBR=beng@chromium.org, darin@chromium.org Review URL: https://codereview.chromium.org/165893002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252481 0039d316-1c4b-4281-b951-d872f2087c98
* Catch EXCEPTION_IN_PAGE_ERROR errors in SafeGetImageInfocsharp@chromium.org2014-02-191-1/+2
| | | | | | | | | | | It is ok for SafeGetImageInfo to fails to get the image info, so catch exceptions instead of dying. BUG=343925 Review URL: https://codereview.chromium.org/171153003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252062 0039d316-1c4b-4281-b951-d872f2087c98
* Increase Browser Blacklistcsharp@chromium.org2014-02-191-1/+4
| | | | | | | | | | | Begin blacklisting datamngr.dl, lmrn.dll and hk.dll from the browser process. BUG=329023 Review URL: https://codereview.chromium.org/171153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251886 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up redirects for component buildscaitkp@chromium.org2014-02-181-1/+28
| | | | | | | | BUG=334379 Review URL: https://codereview.chromium.org/154463002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251823 0039d316-1c4b-4281-b951-d872f2087c98
* Add a UMA stat to track if the Browser blacklist is Set on the Renderercsharp@chromium.org2014-02-155-1/+21
| | | | | | | | | | | | | This shouldn't be happening, but we got some crash reports suggesting it does. Unable to repo locally so this stat will verify it does occur and then can be used to verify our fixes actually fix it. TBR=asvitkine@chromium.org BUG=329023 Review URL: https://codereview.chromium.org/166953002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251454 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 251134 "Revert 251095 "Revert 250828 "Add a UMA stat to t..."asvitkine@chromium.org2014-02-135-21/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reverting again. Confirmed that this is indeed the CL that broke the Win7 x64 sync tests. > Revert 251095 "Revert 250828 "Add a UMA stat to track if the Bro..." > > Speculative re-land to see if this causes sync tests failures again. > If it does, then we will know if this is the cause. > > > Revert 250828 "Add a UMA stat to track if the Browser blacklist ..." > > > > Speculative revert for failures here: > > > > http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201 > > > > > Add a UMA stat to track if the Browser blacklist is Set on the Renderer > > > > > > This shouldn't be happening, but we got some crash reports suggesting it > > > does. Unable to repo locally so this stat will verify it does occur and > > > then can be used to verify our fixes actually fix it. > > > > > > BUG=329023 > > > > > > Review URL: https://codereview.chromium.org/140763008 > > > > TBR=csharp@chromium.org > > > > Review URL: https://codereview.chromium.org/163633005 > > TBR=asvitkine@chromium.org > > Review URL: https://codereview.chromium.org/164833002 TBR=asvitkine@chromium.org Review URL: https://codereview.chromium.org/164913003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251174 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 251095 "Revert 250828 "Add a UMA stat to track if the Bro..."asvitkine@chromium.org2014-02-135-1/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Speculative re-land to see if this causes sync tests failures again. If it does, then we will know if this is the cause. > Revert 250828 "Add a UMA stat to track if the Browser blacklist ..." > > Speculative revert for failures here: > > http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201 > > > Add a UMA stat to track if the Browser blacklist is Set on the Renderer > > > > This shouldn't be happening, but we got some crash reports suggesting it > > does. Unable to repo locally so this stat will verify it does occur and > > then can be used to verify our fixes actually fix it. > > > > BUG=329023 > > > > Review URL: https://codereview.chromium.org/140763008 > > TBR=csharp@chromium.org > > Review URL: https://codereview.chromium.org/163633005 TBR=asvitkine@chromium.org Review URL: https://codereview.chromium.org/164833002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251134 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 250828 "Add a UMA stat to track if the Browser blacklist ..."asvitkine@chromium.org2014-02-135-21/+1
| | | | | | | | | | | | | | | | | | | | | | Speculative revert for failures here: http://build.chromium.org/p/chromium.win/builders/Win7%20Sync%20x64/builds/11201 > Add a UMA stat to track if the Browser blacklist is Set on the Renderer > > This shouldn't be happening, but we got some crash reports suggesting it > does. Unable to repo locally so this stat will verify it does occur and > then can be used to verify our fixes actually fix it. > > BUG=329023 > > Review URL: https://codereview.chromium.org/140763008 TBR=csharp@chromium.org Review URL: https://codereview.chromium.org/163633005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251095 0039d316-1c4b-4281-b951-d872f2087c98
* Add a UMA stat to track if the Browser blacklist is Set on the Renderercsharp@chromium.org2014-02-125-1/+21
| | | | | | | | | | | | This shouldn't be happening, but we got some crash reports suggesting it does. Unable to repo locally so this stat will verify it does occur and then can be used to verify our fixes actually fix it. BUG=329023 Review URL: https://codereview.chromium.org/140763008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250828 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Revert blacklist part of crrev.com/250682. ↵robertshield@chromium.org2014-02-121-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/160373002/) Reason for revert: As discussed, this shouldn't interfere with the metrics we care about. Original issue's description: > Revert blacklist part of crrev.com/250682. > > Don't want the new check in just yet, it will interfere with metrics. > > BUG=329023 > TBR=csharp > NOTRY=true > NOTREECHECKS=TRUE > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250704 TBR=csharp@chromium.org NOTREECHECKS=true NOTRY=true BUG=329023 Review URL: https://codereview.chromium.org/160643002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250758 0039d316-1c4b-4281-b951-d872f2087c98
* Revert blacklist part of crrev.com/250682.robertshield@chromium.org2014-02-121-8/+2
| | | | | | | | | | | | | Don't want the new check in just yet, it will interfere with metrics. BUG=329023 TBR=csharp NOTRY=true NOTREECHECKS=TRUE Review URL: https://codereview.chromium.org/160373002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250704 0039d316-1c4b-4281-b951-d872f2087c98
* Expose an IsSandboxed() export on chrome.exe.robertshield@chromium.org2014-02-121-2/+8
| | | | | | | | BUG=329023 Review URL: https://codereview.chromium.org/159283004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250682 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure we only redirect in browser processescaitkp@chromium.org2014-02-091-0/+5
| | | | | | | | BUG=334379 Review URL: https://codereview.chromium.org/137103009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249965 0039d316-1c4b-4281-b951-d872f2087c98
* Call SwapImports on x64 builds too.caitkp@chromium.org2014-02-081-7/+1
| | | | | | | | BUG=335173 Review URL: https://codereview.chromium.org/149023008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249859 0039d316-1c4b-4281-b951-d872f2087c98
* Make redirects work on canary by looking in the correct profilecaitkp@chromium.org2014-02-075-6/+30
| | | | | | | | BUG=334379 Review URL: https://codereview.chromium.org/156103004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249806 0039d316-1c4b-4281-b951-d872f2087c98
* Add 64-bit support to browser blacklistingcsharp@chromium.org2014-02-075-18/+71
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/101203010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249755 0039d316-1c4b-4281-b951-d872f2087c98
* Add New Histogram Stats to see where Blacklist Failures are Occuringcsharp@chromium.org2014-02-063-4/+54
| | | | | | | | | | | | | | | | We seem to be seeing more setup failures than expected so add so new UMA stats to try and narrow down where the problem is occuring. (This crashes would occur before breakpad is loaded so we don't have any other way to gather this data for the moment). NOTRY=True TBR=sky@chromium.org, asvitkine@chromium.org BUG=329023 Review URL: https://codereview.chromium.org/156113002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249467 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 248720 "Add New Histogram Stats to see where Blacklist Fa..."csharp@google.com2014-02-053-111/+4
| | | | | | | | | | | | | | | | | | | | | > Add New Histogram Stats to see where Blacklist Failures are Occuring > > We seem to be seeing more setup failures than expected so add so new > UMA stats to try and narrow down where the problem is occuring. > > (This crashes would occur before breakpad is loaded so we don't have > any other way to gather this data for the moment). > > NOTRY=True > BUG=329023 > > Review URL: https://codereview.chromium.org/147143002 TBR=csharp@chromium.org Review URL: https://codereview.chromium.org/156053003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249079 0039d316-1c4b-4281-b951-d872f2087c98
* Add New Histogram Stats to see where Blacklist Failures are Occuringcsharp@chromium.org2014-02-043-4/+111
| | | | | | | | | | | | | | | We seem to be seeing more setup failures than expected so add so new UMA stats to try and narrow down where the problem is occuring. (This crashes would occur before breakpad is loaded so we don't have any other way to gather this data for the moment). NOTRY=True BUG=329023 Review URL: https://codereview.chromium.org/147143002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248720 0039d316-1c4b-4281-b951-d872f2087c98
* Add libsvn_tsvn32.dll to the browser blacklistcsharp@chromium.org2014-02-031-0/+1
| | | | | | | | BUG=329023 Review URL: https://codereview.chromium.org/141683007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248501 0039d316-1c4b-4281-b951-d872f2087c98
* Use an alternate mechanism for CreateFile calls in Chromecaitkp@chromium.org2014-02-028-1/+781
| | | | | | | | | | | | BUG=334379 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245464 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246313 Review URL: https://codereview.chromium.org/138593004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248380 0039d316-1c4b-4281-b951-d872f2087c98
* Add logs to chrome_elf_unittests to ensure the correct target is built.csharp@chromium.org2014-01-241-3/+6
| | | | | | | | | | | | If users just build chrome_elf_unittests.exe, a few tests will fail due to missing dependencies. Tell the user to build chrome_elf_unittests instead if they encounter these failures. BUG= Review URL: https://codereview.chromium.org/145053002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246975 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup browser blacklist codecsharp@chromium.org2014-01-244-26/+57
| | | | | | | | | | | | | | This change also involves some cleanup of how the blacklist is defined in the code. This will make it easier to add new dll names at compile time. The module name check is now also case-insensitive. BUG=329023 Review URL: https://codereview.chromium.org/138903022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246965 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 246313 "Use an alternate mechanism for CreateFile calls i..."kochi@google.com2014-01-238-683/+1
| | | | | | | | | | | | | | | | | | This caused reading profile error on Windows8 platform. > Use an alternate mechanism for CreateFile calls in Chrome > > BUG=334379 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245464 > > Review URL: https://codereview.chromium.org/138593004 TBR=caitkp@chromium.org Review URL: https://codereview.chromium.org/144333003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246541 0039d316-1c4b-4281-b951-d872f2087c98
* Use an alternate mechanism for CreateFile calls in Chromecaitkp@chromium.org2014-01-228-1/+683
| | | | | | | | | | BUG=334379 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245464 Review URL: https://codereview.chromium.org/138593004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246313 0039d316-1c4b-4281-b951-d872f2087c98
* Allows chrome_elf_unittests to be run under SyzyASan.sebmarchand@chromium.org2014-01-212-1/+17
| | | | | | | | | | | | | | This also fix a missing dependency on chrome_elf_unittests, it should have a dependency on chrome_elf.dll and chrome.exe if you want to be able to do: - ninja -C out\Release chrome_elf_unittests - out\Release\chrome_elf_unittests.exe on a fresh checkout... R=robertshield@chromium.org Review URL: https://codereview.chromium.org/132823006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246061 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 245464 "Use an alternate mechanism for CreateFile calls i..."jochen@chromium.org2014-01-178-683/+1
| | | | | | | | | | | | | | | | ChromeCreateFileTest.CheckWriteAndReadParams crashes on Vista > Use an alternate mechanism for CreateFile calls in Chrome > > BUG=334379 > > Review URL: https://codereview.chromium.org/138593004 TBR=caitkp@chromium.org Review URL: https://codereview.chromium.org/140783009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245501 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-10-31 08:23:01 +0000