summaryrefslogtreecommitdiffstats
path: root/chrome_elf
Commit message (Collapse)AuthorAgeFilesLines
* Update chrome_elf_unittests imports list for VS 2015brucedawson2016-03-151-1/+5
| | | | | | | | | | | | | | VS 2015 component builds import more DLLs so chrome_elf_unittests needs updating to reflect that. This change also tightens the restrictions on the import list - the CRT DLLs should only be needed in component builds. BUG=440500,594360 Review URL: https://codereview.chromium.org/1801953003 Cr-Commit-Position: refs/heads/master@{#381145}
* gn/win: Try to get chrome_elf_unittests passing on swarming.thakis2016-02-161-1/+9
| | | | | | | | | | | | | | | It looks like the indirection in chrome/BUILD.gn that does the out/foo/initial/chrome.exe -> out/foo/chrome.exe mananges to confuse data_deps, so add an explicit data dep. Follow-up to https://codereview.chromium.org/1223703002/ BUG=98637,536192 TBR=caitkp Review URL: https://codereview.chromium.org/1701053002 Cr-Commit-Position: refs/heads/master@{#375689}
* Convert chrome_elf_unittests to run exclusively on Swarmingthakis2016-02-162-0/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 0 configs already ran on Swarming 20 used to run locally and were converted: - chromium.fyi.json: Chromium Win 10 - chromium.fyi.json: ClangToTWin tester - chromium.fyi.json: ClangToTWin(dbg) tester - chromium.fyi.json: ClangToTWin(dll) tester - chromium.fyi.json: ClangToTWin64 tester - chromium.fyi.json: ClangToTWin64(dbg) tester - chromium.fyi.json: ClangToTWin64(dll) tester - chromium.fyi.json: CrWinAsan tester - chromium.fyi.json: CrWinAsan(dll) tester - chromium.fyi.json: CrWinAsanCov tester - chromium.fyi.json: CrWinClang tester - chromium.fyi.json: CrWinClang(dbg) tester - chromium.fyi.json: CrWinClang(shared) tester - chromium.fyi.json: CrWinClang64 tester - chromium.fyi.json: CrWinClang64(dbg) tester - chromium.fyi.json: CrWinClang64(dll) tester - chromium.fyi.json: CrWinClangLLD tester - chromium.win.json: Win 7 Tests x64 (1) - chromium.win.json: Win7 Tests (1) - chromium.win.json: Win7 Tests (dbg)(1) Ran: ./manage.py --convert chrome_elf_unittests BUG=98637 TBR=caitkp Review URL: https://codereview.chromium.org/1223703002 Cr-Commit-Position: refs/heads/master@{#375581}
* Add a comment on PRODUCT_STRING_PATH usage in chrome_elf.gab2016-01-261-0/+3
| | | | | | | | BUG=577820 Review URL: https://codereview.chromium.org/1634793002 Cr-Commit-Position: refs/heads/master@{#371446}
* Switch to standard integer types in chrome_elf/.avi2015-12-228-8/+16
| | | | | | | | | BUG=138542 TBR=caitkp@chromium.org Review URL: https://codereview.chromium.org/1537333002 Cr-Commit-Position: refs/heads/master@{#366612}
* clang/win: Let remaining chromium_code targets build with -Wextra.thakis2015-12-102-5/+5
| | | | | | | | | | | | | | | This is a follow-up to https://codereview.chromium.org/1507413003/ and lets all translation units in a release build build if -Wextra is enabled for chromium_code targets. (This CL does not contain the change to actually turn on -Wextra, only cleanups.) BUG=567877 Review URL: https://codereview.chromium.org/1513043002 Cr-Commit-Position: refs/heads/master@{#364425}
* clang/win: Let some chromium_code targets build with -Wextra.thakis2015-12-101-2/+4
| | | | | | | | | | | | | | | | | | | To make warning flags between Windows and non-Windows clang consistent, I'd like to build chromium_code targets with -Wextra enabled. This fixes -Wextra warnings in about 14k of 31k build steps. Most of the warnings were about signed/unsigned mismatches; some were about "const"s that had no effect. (This CL does not contain the change to actually turn on -Wextra, only cleanups.) BUG=567877 TBR=content/common/sandbox Review URL: https://codereview.chromium.org/1507413003 Cr-Commit-Position: refs/heads/master@{#364232}
* Add chrome_elf and cloud_print to "gn check"brettw2015-12-071-2/+14
| | | | | | | | BUG=460828 Review URL: https://codereview.chromium.org/1503483003 Cr-Commit-Position: refs/heads/master@{#363605}
* Run certain chrome_elf_unittests only in Release.brettw2015-12-023-15/+27
| | | | | | | | | | | | | | | | These tests depend on various parts of base not getting included in chrome_elf.dll as described in the comment added to the unit test file. This doesn't work in GN debug build because the GN build uses source sets rather than shared libraries. This change runs the test only in release mode. This replaces the dependencies on base_static with base and removes the comment about not depending on all of base. All of base is getting linked in via the sandbox dependency, so this effort is wasted. The regular base dependency is clearer. Slight iterator improvements in the update unit tests for readability. Independently, this fixes the linking of chrome_child with symbols on Windows. The conditions were messed up. The code meant to force incremental linking off when full symbols are enabled, but actually did the reverse. BUG=505062 Review URL: https://codereview.chromium.org/1485343002 Cr-Commit-Position: refs/heads/master@{#362767}
* Fix "missing source file" errors during gclient runhooks.pkasting2015-11-132-2/+0
| | | | | | | | | | BUG=none TEST=none TBR=kinuko Review URL: https://codereview.chromium.org/1439633003 Cr-Commit-Position: refs/heads/master@{#359652}
* Remove 2 more unused constants from chrome_elfcaitkp2015-11-112-7/+0
| | | | | | | | R=robertshield@chromium.org Review URL: https://codereview.chromium.org/1432273002 Cr-Commit-Position: refs/heads/master@{#359104}
* Remove CreateFile code from Chrome_Elfcaitkp2015-11-1015-1063/+0
| | | | | | | | R=robertshield@chromium.org Review URL: https://codereview.chromium.org/1408403007 Cr-Commit-Position: refs/heads/master@{#358908}
* Cleanup chrome/common/chrome_version.h handlingmdempsky2015-10-215-5/+5
| | | | | | | | | | | | | | | | | | | | Rename "version.h" to "chrome/common/chrome_version.h" Update #include and GYP/GN references Generate on all platforms Remove redundant generated chrome/common/chrome_version.cc.version Fix DEPS include_rules BUG=542807 Committed: https://crrev.com/59647ecac9524d954010d3d10b539ee4a340bf94 Cr-Commit-Position: refs/heads/master@{#355196} Committed: https://crrev.com/31f086c2013853749cac45522eb950b9d0ab0302 Cr-Commit-Position: refs/heads/master@{#355377} Review URL: https://codereview.chromium.org/1405633002 Cr-Commit-Position: refs/heads/master@{#355434}
* Revert of Cleanup chrome/version.h handling (patchset #9 id:160001 of ↵mathp2015-10-215-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1405633002/ ) Reason for revert: Causing failures on the GN build (not gyp) for Mac: http://build.chromium.org/p/chromium.mac/builders/Mac%20GN%20%28dbg%29/builds/23191 Original issue's description: > Cleanup chrome/common/chrome_version.h handling > > Rename "version.h" to "chrome/common/chrome_version.h" > Update #include and GYP/GN references > Generate on all platforms > Remove redundant generated chrome/common/chrome_version.cc.version > Fix DEPS include_rules > > BUG=542807 > > Committed: https://crrev.com/59647ecac9524d954010d3d10b539ee4a340bf94 > Cr-Commit-Position: refs/heads/master@{#355196} > > Committed: https://crrev.com/31f086c2013853749cac45522eb950b9d0ab0302 > Cr-Commit-Position: refs/heads/master@{#355377} TBR=brettw@chromium.org,mdempsky@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=542807 Review URL: https://codereview.chromium.org/1418933002 Cr-Commit-Position: refs/heads/master@{#355393}
* Cleanup chrome/common/chrome_version.h handlingmdempsky2015-10-215-5/+5
| | | | | | | | | | | | | | | | | Rename "version.h" to "chrome/common/chrome_version.h" Update #include and GYP/GN references Generate on all platforms Remove redundant generated chrome/common/chrome_version.cc.version Fix DEPS include_rules BUG=542807 Committed: https://crrev.com/59647ecac9524d954010d3d10b539ee4a340bf94 Cr-Commit-Position: refs/heads/master@{#355196} Review URL: https://codereview.chromium.org/1405633002 Cr-Commit-Position: refs/heads/master@{#355377}
* Fix IsFunctionAService() for Windows 10 WOW64drbasic2015-10-211-1/+3
| | | | | | | | | | | | | | | | | Windows 10 WOW64 has different thunk than Windows 8. Test ServiceResolverTest.PatchesServices from sbox_unittests failed. Library blacklist from src\chrome_elf\blacklist\blacklist.cc does not work. BUG= R=cpu@chromium.org R=jschuh@chromium.org TEST=sbox_unittests on Win 10 Review URL: https://codereview.chromium.org/1407103003 Cr-Commit-Position: refs/heads/master@{#355307}
* Revert of Cleanup chrome/version.h handling (patchset #7 id:120001 of ↵mathp2015-10-215-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1405633002/ ) Reason for revert: Appears to be breaking at least Mac GN build Example failure: http://build.chromium.org/p/chromium.mac/builders/Mac%20GN%20%28dbg%29/builds/23114 Original issue's description: > Cleanup chrome/common/chrome_version.h handling > > Rename "version.h" to "chrome/common/chrome_version.h" > Update #include and GYP/GN references > Generate on all platforms > Remove redundant generated chrome/common/chrome_version.cc.version > Fix DEPS include_rules > > BUG=542807 > > Committed: https://crrev.com/59647ecac9524d954010d3d10b539ee4a340bf94 > Cr-Commit-Position: refs/heads/master@{#355196} TBR=brettw@chromium.org,mdempsky@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=542807 Review URL: https://codereview.chromium.org/1411173003 Cr-Commit-Position: refs/heads/master@{#355231}
* Cleanup chrome/common/chrome_version.h handlingmdempsky2015-10-215-5/+5
| | | | | | | | | | | | | | Rename "version.h" to "chrome/common/chrome_version.h" Update #include and GYP/GN references Generate on all platforms Remove redundant generated chrome/common/chrome_version.cc.version Fix DEPS include_rules BUG=542807 Review URL: https://codereview.chromium.org/1405633002 Cr-Commit-Position: refs/heads/master@{#355196}
* Cleanup: Pass std::string as const reference from chrome_elf/ki.stfu2015-09-202-2/+2
| | | | | | | | | | | | Passing std::string by reference can prevent extra copying of object. BUG=367418 TEST= R=caitkp@chromium.org,robertshield@chromium.org Review URL: https://codereview.chromium.org/1352793003 Cr-Commit-Position: refs/heads/master@{#349887}
* Annotate GN executables and shared_libraries with sanitizer deps.brettw2015-08-311-4/+17
| | | | | | | | | | | | | | | | | These are needed to link in asan/lsan/etc. mode. GYP injects these automatically but GN doesn't have automatic dependency injection. All tests and components (which cover the vast majority of such targets in actual use) are templates which add these dependencies already, so most of the time it never comes up. Only a few of these changes are actually necessary to link all tests run on the asan bot (which is also what engineers will typically build, since almost nobody will build all in asan mode). But to reduce confusion from linker errors in asan mode, I annotated all executables and shared libraries I could find with the sanitizer dependency. I moved a config out of a target in yasm, and sorted a fews deps on other targets. TBR=xhwang@chromium.org (widevine) TBR=achuith@chromium.org (tools/perf, tools/telemetry) Review URL: https://codereview.chromium.org/1318343003 Cr-Commit-Position: refs/heads/master@{#346490}
* Add Linux build packaging targets to GNbrettw2015-08-281-0/+1
| | | | | | | | | | | | | | | | | | | Changes the version processing templates to not implicitly include the chrome version .rc file. This was something I've been meaning to do for a while which was forced by this patch, because it wants to call version.py with no sources or template file. I also had to remove some checks that either a template file or sources were defined (I wasn't aware this was valid to do when I wrote these checks). The above-mentioned change necessitated referencing the version template file from a number of existing calls. The version script now explicitly sets the output file with -o. Previously this was the implicit second argument, but this didn't work if there was no template file. -o is the same and it's better to be more explicit anyway. Added copy rules for xdg-mime related scripts which are required by the installer. Added a meta "installer" target which links to the Linux installers. This will also be a good place to hook up the Windows installer when we write it. BUG=525839 TBR=thestig@chromium.org (linux installer), ddorwin@chromium.org (widevine) Review URL: https://codereview.chromium.org/1311543003 Cr-Commit-Position: refs/heads/master@{#346279}
* Add 949ba8b6a9.dll to Chrome's Browser's blacklistcsharp2015-08-111-0/+1
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/1274273006 Cr-Commit-Position: refs/heads/master@{#342832}
* clang/win: Try to fix build after https://codereview.chromium.org/1261953003.Nico Weber2015-08-081-0/+2
| | | | | | | | | | | Apparently the trybots don't build all targets :-/ BUG=505316 TBR=brettw,robertshield Review URL: https://codereview.chromium.org/1284523002. Cr-Commit-Position: refs/heads/master@{#342537}
* Blocked blacklisted dlls if the module or file name is blacklisted.csharp2015-08-051-14/+19
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/1248863004 Cr-Commit-Position: refs/heads/master@{#341966}
* Misc GN build improvements, mostly Windows.brettw2015-07-231-0/+10
| | | | | | | | | | | | | | Added lots of bug references to TODOs. Added rules for some remoting test files. Added manifests for chrome.dll, chrome_child.dll, and chrome_elf.dll TBR=bradnelson for chrome/test/data/nacl Review URL: https://codereview.chromium.org/1250103002 Cr-Commit-Position: refs/heads/master@{#340009}
* Fixed all unused-variable Clang warnings on Windows.mgiuca2015-07-081-1/+0
| | | | | | | | | | | | | | Usually, fixed by removing the unused variables. Some variables had to be guarded by #ifs. Some variables could be used instead. Also removed unused test file sweep02_16b_mono_16KHz.raw. BUG=505319 TBR=rpaquay@chromium.org Review URL: https://codereview.chromium.org/1220133003 Cr-Commit-Position: refs/heads/master@{#337767}
* Move MatchPattern to its own header and the base namespace.brettw2015-07-061-1/+2
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/1226673003 Cr-Commit-Position: refs/heads/master@{#337488}
* Add offerswizarddll.dll to Chrome's Browser's Blacklistcsharp2015-05-271-0/+1
| | | | | | Review URL: https://codereview.chromium.org/1158003002 Cr-Commit-Position: refs/heads/master@{#331602}
* Reland Issue 1132473003: Cache IsNonBrowserProcesscaitkp2015-05-145-7/+45
| | | | | | | | | | so we only take a loader-lock the first time. BUG=485656, 477137 Review URL: https://codereview.chromium.org/1144433004 Cr-Commit-Position: refs/heads/master@{#329911}
* Revert of Cache IsNonBrowserProcess values, so we only take a loader-lock ↵caitkp2015-05-125-42/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | the first time. (patchset #4 id:60001 of https://codereview.chromium.org/1132473003/) Reason for revert: Possibly causing mysterious fails on the Win DBG bots: https://build.chromium.org/p/chromium.webkit/builders/Win7%20%28dbg%29/builds/16344 http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/37896 Original issue's description: > Cache IsNonBrowserProcess values, so we only take a loader-lock the first time. > > BUG=485656,477137 > > Committed: https://crrev.com/78d41b5d4e59dc7d52d7e7d6530fdd0a78b36d33 > Cr-Commit-Position: refs/heads/master@{#329246} TBR=siggi@chromium.org,grt@chromium.org,csharp@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=485656,477137 Review URL: https://codereview.chromium.org/1134253002 Cr-Commit-Position: refs/heads/master@{#329467}
* Cache IsNonBrowserProcess values, so we only take a loader-lock the first time.caitkp2015-05-115-8/+42
| | | | | | | | BUG=485656,477137 Review URL: https://codereview.chromium.org/1132473003 Cr-Commit-Position: refs/heads/master@{#329246}
* Add dpinterface32.dll to Chrome's browser's blacklistcsharp2015-05-071-0/+1
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/1131943002 Cr-Commit-Position: refs/heads/master@{#328814}
* Add spappsv32.dll to Chrome's Browser's Blacklist.csharp2015-05-041-0/+1
| | | | | | Review URL: https://codereview.chromium.org/1113153003 Cr-Commit-Position: refs/heads/master@{#328162}
* Add a GN flag for the Windows multi-dll build.brettw2015-05-011-1/+0
| | | | | | | | | | | | | The first pass of moving the other Chrome-specific build flags out of the root build config file and into the new one. This requires both ffmpeg and Blink changes to finish landing. Originally landed as https://codereview.chromium.org/1120803003/ TBR=scottmg@chromium.org TBR=ddorwin@chromium.org (widevine) CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Review URL: https://codereview.chromium.org/1123433002 Cr-Commit-Position: refs/heads/master@{#327998}
* Revert of Add a GN flag for the Windows multi-dll build. (patchset #3 ↵rickyz2015-05-011-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | id:40001 of https://codereview.chromium.org/1120803003/) Reason for revert: May have caused some link errors on windows: https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/814 Original issue's description: > Add a GN flag for the Windows multi-dll build. > > The first pass of moving the other Chrome-specific build flags out of the root build config file and into the new one. This requires both ffmpeg and Blink changes to finish landing. > > R=scottmg@chromium.org > TBR=ddorwin@chromium.org (widevine) > > Committed: https://crrev.com/edff53a35780ba2f515c7e8d4f7131c91151e1a3 > Cr-Commit-Position: refs/heads/master@{#327854} TBR=scottmg@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1117063004 Cr-Commit-Position: refs/heads/master@{#327861}
* Add a GN flag for the Windows multi-dll build.brettw2015-05-011-1/+0
| | | | | | | | | | | The first pass of moving the other Chrome-specific build flags out of the root build config file and into the new one. This requires both ffmpeg and Blink changes to finish landing. R=scottmg@chromium.org TBR=ddorwin@chromium.org (widevine) Review URL: https://codereview.chromium.org/1120803003 Cr-Commit-Position: refs/heads/master@{#327854}
* Apply automated fixits for Chrome clang plugin to chrome_elf.dcheng2015-04-291-2/+2
| | | | | | | | | | | Working on trimming down plugin warnings on the Windows clang build. BUG=467287 TBR=caitkp@chromium.org Review URL: https://codereview.chromium.org/1112853003 Cr-Commit-Position: refs/heads/master@{#327585}
* Add bsvc.dll to Chrome's Browser's Blacklistcsharp2015-04-281-0/+1
| | | | | | | | | | Also add two older values to dllhash. BUG= Review URL: https://codereview.chromium.org/1110123002 Cr-Commit-Position: refs/heads/master@{#327295}
* simplify brandinggburanov2015-04-281-11/+1
| | | | | | | | | | | | | Please take look at https://codereview.chromium.org/1090213002/patch/40001/50001 for details BUG= Review URL: https://codereview.chromium.org/1059333004 Cr-Commit-Position: refs/heads/master@{#327270}
* Add minisp32.dll to Chrome's Browser's Blacklistcsharp2015-04-241-0/+1
| | | | | | | | BUG=476648,479710 Review URL: https://codereview.chromium.org/1100413002 Cr-Commit-Position: refs/heads/master@{#326784}
* Update {virtual,override} to follow C++11 style in chrome_elf.nick2015-04-233-3/+3
| | | | | | | | | | | | The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was manually generated using a regex and a text editor. BUG=417463 Review URL: https://codereview.chromium.org/1106533003 Cr-Commit-Position: refs/heads/master@{#326454}
* Add explorerex.dll to Chrome's Browser's Blacklistcsharp2015-04-211-0/+1
| | | | | | | | This has been causing a large number of browser crashes. Review URL: https://codereview.chromium.org/1101563002 Cr-Commit-Position: refs/heads/master@{#326098}
* Fix chrome_elf_unittests to handle dlls being blacklisted before the tests startcsharp2015-03-303-95/+107
| | | | | | | | BUG=463495,463500 Review URL: https://codereview.chromium.org/1024183004 Cr-Commit-Position: refs/heads/master@{#322878}
* Add smdmf.dll to Chromium's Browser's Blacklist.csharp2015-03-241-0/+1
| | | | | | | | | R=cait@chromium.org, jwd@chromium.org BUG= Review URL: https://codereview.chromium.org/1022523003 Cr-Commit-Position: refs/heads/master@{#322005}
* Ensure all troublesome dlls are listed in lower case.csharp2015-03-111-2/+2
| | | | | | Review URL: https://codereview.chromium.org/951463003 Cr-Commit-Position: refs/heads/master@{#320086}
* Add ASan MD RTL to the list of valid importstimurrrr2015-03-031-1/+4
| | | | | | | | BUG=345874 Review URL: https://codereview.chromium.org/974903002 Cr-Commit-Position: refs/heads/master@{#318897}
* Apply gn format with 'sources' sorting to src/scottmg2015-02-281-1/+1
| | | | | | | | | | | | Application of https://codereview.chromium.org/962003002/. TBR=keybuk@chromium.org R=brettw@chromium.org BUG=456014 Review URL: https://codereview.chromium.org/960413003 Cr-Commit-Position: refs/heads/master@{#318574}
* Reland the ULONG -> SIZE_T change from 317177rnk2015-02-261-2/+2
| | | | | | | | | | | Testing shows that this change is correct, but there was no evidence supporting the other change. Will manually run the x64 dbg test try bot for this change. TBR=thakis@chromium.org,jvoung@chromium.org BUG=458690,460563 Review URL: https://codereview.chromium.org/942003008 Cr-Commit-Position: refs/heads/master@{#318160}
* Fix official build in GNbrettw2015-02-251-5/+3
| | | | | | | | | | | | Changes process_version template. In GYP this is used in two ways and the GN version only supported one of these. This change also deletes an unnecessary fork of the template file, and fixes the dependencies for the extra files (previously they were just passed with "-f" and not added to the inputs of the target. Adds a cdm_adapter template which basically matches the GYP version. Uses this for the media clearkey adapter and the widevine one in the official build. Fixes for the crypto targets when compiling with the official build's checked-in sysroots. Review URL: https://codereview.chromium.org/949233003 Cr-Commit-Position: refs/heads/master@{#318083}
* Revert of sandbox: Fix Win64 porting issue by using SIZE_T instead of ULONG ↵jfb2015-02-201-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #3 id:40001 of https://codereview.chromium.org/921353002/) Reason for revert: Speculative revert after discussion on IRC, this seems pretty unlikely but may have caused the failures at: http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/35506 Original issue's description: > sandbox: Fix some nt_internals.h function prototypes for Win64 > > NtQuerySection should use ULONG instead of SIZE_T as it is dealing with PE section sizes. > > NtQueryVirtualMemory should use SIZE_T instead of ULONG as it is dealing with memory sizes. > > DynamoRIO, another project that consumes these native APIs, uses the prototypes introduced by this change. > > R=robertshield@chromium.org,rvargas@chromium.org > BUG=458690 > > Committed: https://crrev.com/4ede4e174a51d08262edfb2e2c05845504bd9b1a > Cr-Commit-Position: refs/heads/master@{#317177} TBR=jschuh@chromium.org,robertshield@chromium.org,thakis@chromium.org,wfh@chromium.org,rvargas@chromium.org,rnk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=458690 Review URL: https://codereview.chromium.org/943043002 Cr-Commit-Position: refs/heads/master@{#317409}
generated by cgit v1.1 at 2024-05-01 20:34:05 +0000