| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
- adds the flag of enabling opt-in IME menu in the about page.
- updates the string "IDS_OPTIONS_SETTINGS_LANGUAGES_ACTIVATE_IME_MENU" in the language page as what UI reviewer suggests.
BUG=570761
TEST=None
Review URL: https://codereview.chromium.org/1818863002
Cr-Commit-Position: refs/heads/master@{#383006}
|
|
|
|
|
|
|
|
|
|
|
|
| |
roaming by default upon system start during OOBE.
This flag is used by Rialto device to obtain device policy and get enrolled automatically since the Rialto device has no display and only connects over cell.
BUG=574932
Review URL: https://codereview.chromium.org/1782143004
Cr-Commit-Position: refs/heads/master@{#382888}
|
|
|
|
|
|
|
|
|
| |
BUG=570761
TEST=None
Review URL: https://codereview.chromium.org/1827683003
Cr-Commit-Position: refs/heads/master@{#382803}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This just adds the boilerplate for five new accessibility features and hides
them behind a flag. All five have been prototyped and are ready for
implementation.
The first three are related, they just provide visual highlighting to
help low-vision users keep track of things on the screen:
* Caret highlight
* Cursor highlight
* Focus highlight
Hold down a key and click or drag to speak any visible text on screen
* Select to speak
Control the whole computer with a single switch (for motor impaired users)
* Switch access
For now, there's no need to put these in the tray. They can graduate to the
tray when they launch.
BUG=314889,593887,593885
Review URL: https://codereview.chromium.org/1785833002
Cr-Commit-Position: refs/heads/master@{#381353}
|
|
|
|
|
|
|
|
|
|
| |
It's under development, so please pass --enable-files-details-panel as an extra argument to activate this feature.
BUG=274045
Review URL: https://codereview.chromium.org/1762623002
Cr-Commit-Position: refs/heads/master@{#379718}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL:
* Adds parentId, layoutType, and offset to options.DisplayInfo
* Sends !Array<!options.DisplayLayout> to chrome.send('setDisplayLayout') instead of a single layout/offset pair.
* Eliminates the fake entries in DisplayLayoutManagerMulti
* Removes --enable-multi-display-layout and adds --disable-multi-display-layout that just disables the UI entirely for >2 displays.
* The previous DisplayLayoutManager code is still used for 2 displays, DisplayLayoutManagerMulti is used for 3+ displays.
BUG=576375
Review URL: https://codereview.chromium.org/1744583003
Cr-Commit-Position: refs/heads/master@{#378316}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed UserCloudPolicyManagerChromeOS to no longer complete profile
initialization if there is an error fetching policy. Instead, we shutdown the
user and force a policy load the next time we try to startup that user.
BUG=532317
TBR=tnagel@chromium.org
Review URL: https://codereview.chromium.org/1735863002
Cr-Commit-Position: refs/heads/master@{#377558}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
policy. (patchset #1 id:1 of https://codereview.chromium.org/1727413002/ )
Reason for revert:
Still causing failures here:
https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/Lumpy%20%28chrome%29/builds/18722
It's possible that the telemetry fixes have not propagated to the builder yet.
Original issue's description:
> Reland: No longer start up profile if there was an error fetching policy.
>
> Changed UserCloudPolicyManagerChromeOS to no longer complete profile
> initialization if there is an error fetching policy. Instead, we shutdown the
> user and force a policy load the next time we try to startup that user.
>
> BUG=532317
> TBR=vitalybuka@chromium.org
>
> Committed: https://crrev.com/01a589c605a9ead2754a51a5ef2c916361c6be0d
> Cr-Commit-Position: refs/heads/master@{#377288}
TBR=vitalybuka@chromium.org,tnagel@google.com,atwilson@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=532317
Review URL: https://codereview.chromium.org/1737453003
Cr-Commit-Position: refs/heads/master@{#377371}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed UserCloudPolicyManagerChromeOS to no longer complete profile
initialization if there is an error fetching policy. Instead, we shutdown the
user and force a policy load the next time we try to startup that user.
BUG=532317
TBR=vitalybuka@chromium.org
Review URL: https://codereview.chromium.org/1727413002
Cr-Commit-Position: refs/heads/master@{#377288}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #13 id:240001 of https://codereview.chromium.org/1608533002/ )
Reason for revert:
Causing login failures in VMTests and HWTests:
https://bugs.chromium.org/p/chromium/issues/detail?id=588739
Original issue's description:
> No longer start up profile if there was an error fetching policy.
>
> Changed UserCloudPolicyManagerChromeOS to no longer complete profile
> initialization if there is an error fetching policy. Instead, we shutdown the
> user and force a policy load the next time we try to startup that user.
>
> BUG=532317
> TBR=vitalybuka
>
> Committed: https://crrev.com/b5eef9438be6954840df6c39f518ff042815ac7f
> Cr-Commit-Position: refs/heads/master@{#376484}
TBR=bartfab@chromium.org,tnagel@chromium.org,dzhioev@chromium.org,vitalybuka@chromium.org,atwilson@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=532317
Review URL: https://codereview.chromium.org/1722653003
Cr-Commit-Position: refs/heads/master@{#376852}
|
|
|
|
|
|
|
|
| |
BUG=576375
Review URL: https://codereview.chromium.org/1717493002
Cr-Commit-Position: refs/heads/master@{#376850}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed UserCloudPolicyManagerChromeOS to no longer complete profile
initialization if there is an error fetching policy. Instead, we shutdown the
user and force a policy load the next time we try to startup that user.
BUG=532317
TBR=vitalybuka
Review URL: https://codereview.chromium.org/1608533002
Cr-Commit-Position: refs/heads/master@{#376484}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Most of the tests do not require GMS Core to be signed in. For this
tests we need simplified workflow without extra UI interaction.
BUG=584316
TEST=Start Chrome without new switch - no change in current workflow.
TEST=Start Chrome with new switch - all UI dialogs are skipped, no
Android Apps section in Chrome::Settings and ARC starts
automatically.
TEST=Tests cheets_ContainerSmokeTest, cheets_PerfBoot,
cheets_SettingsBridge pass with new switch.
Review URL: https://codereview.chromium.org/1670603002
Cr-Commit-Position: refs/heads/master@{#373683}
|
|
|
|
|
|
|
|
|
| |
BUG=462823
TEST=manual
Review URL: https://codereview.chromium.org/1583073002
Cr-Commit-Position: refs/heads/master@{#369519}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A flag "enable-ime-menu" is added to turn on this feature. When building Chrome OS with the command line flag: --enable-ime-menu, the div section 'language-options-ime-menu-template' in language settings page will show. Otherwise, this section will be hidden.
Once the checkbox 'activate-ime-menu' is checked by users, the preference value pref::kLanguageImeMenuActivated will be set to be true.
BUG=570761
TEST=Verified bug not repro on local build.
Review URL: https://codereview.chromium.org/1523593002
Cr-Commit-Position: refs/heads/master@{#368529}
|
|
|
|
|
|
|
|
| |
BUG=564370
Review URL: https://codereview.chromium.org/1492043002
Cr-Commit-Position: refs/heads/master@{#363646}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We have permission to remove the build time flag in favor of a runtime
flag for enabling ARC Bridge Service, conditional on committing to a
more stable and appropriate IPC mechanism for the bridge.
BUG=559654
TEST=components_unittests
Review URL: https://codereview.chromium.org/1466143002
Cr-Commit-Position: refs/heads/master@{#361484}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was useful for debugging and early integration efforts in ChromeOS
and is no longer required.
BUG=549558
TEST=On amd64-generic_freon observe that loading from named .icc file
functions correctly.
Review URL: https://codereview.chromium.org/1428963002
Cr-Commit-Position: refs/heads/master@{#357110}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change variable names so that the wake on WiFi "SSID" feature is
now known as "DarkConnect".
BUG=chromium:431486
TEST=Manually test that wake on WiFi features still work as expected.
Review URL: https://codereview.chromium.org/1412993003
Cr-Commit-Position: refs/heads/master@{#356622}
|
|
|
|
|
|
|
|
|
| |
BUG=chrome-os-partner:34535
TEST=manual
Review URL: https://codereview.chromium.org/1352213002
Cr-Commit-Position: refs/heads/master@{#350124}
|
|
|
|
|
|
|
|
|
|
|
|
| |
The last usage of this switch was removed in this CL:
https://codereview.chromium.org/1188693002/. We don't need to keep it
around.
BUG=501121
Review URL: https://codereview.chromium.org/1269793005
Cr-Commit-Position: refs/heads/master@{#341364}
|
|
|
|
|
|
|
|
|
|
|
| |
Tests can still disable webview signing with "webview_signin_disabled"
preference.
BUG=470893
Review URL: https://codereview.chromium.org/1254283005
Cr-Commit-Position: refs/heads/master@{#340755}
|
|
|
|
|
|
|
|
|
|
| |
And remove associated flag
BUG=439448
Review URL: https://codereview.chromium.org/1219623012
Cr-Commit-Position: refs/heads/master@{#338006}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the --enterprise-enrollment-skip-robot-auth flag in favor
of skipping the robot auth setup step if the server doesn't provide an
auth code. Note that server may still cause enrollment to fail by
returning an error code for the api_authorization request in case it
can't obtain a valid auth code.
BUG=None
TEST=Enrollment and robot auth still works.
TBR=xiyuan@chromium.org
Review URL: https://codereview.chromium.org/1217503002
Cr-Commit-Position: refs/heads/master@{#336562}
|
|
|
|
|
|
|
|
|
|
|
| |
The Metronome DBus service is obsolete and no longer available on the
Chrome OS side. This CL removes the Metronome DBus client binding.
BUG=None
Review URL: https://codereview.chromium.org/1213693002
Cr-Commit-Position: refs/heads/master@{#336423}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a mechanical rename from subdirs into memory/ with _platform
suffixes instead. This avoids having duplicate basenames.
It would probably be better to have only
memory/memory_pressure_monitor.h and then _win.cc, _mac.cc, _chromeos.cc
implementations, but that's a more invasive change because of the
slightly different interfaces/members.
TBR=jam@chromium.org, oshima@chromium.org
R=thakis@chromium.org, chrisha@chromium.org
BUG=490824, gyp:384,472772
Review URL: https://codereview.chromium.org/1149223002
Cr-Commit-Position: refs/heads/master@{#331006}
|
|
|
|
|
|
|
|
|
|
| |
This is cleanup from https://codereview.chromium.org/1122863005/
BUG=472772
Review URL: https://codereview.chromium.org/1124163003
Cr-Commit-Position: refs/heads/master@{#330032}
|
|
|
|
|
|
|
|
|
|
|
| |
Enable firewall hole punching for Chrome Apps by taking this feature out
from behind a flag.
BUG=478231
Review URL: https://codereview.chromium.org/1136843008
Cr-Commit-Position: refs/heads/master@{#329959}
|
|
|
|
|
|
|
|
|
|
| |
TBR=suzhe@chromium.org
BUG=407456
TEST=Verified on linux_chromeos & clapper device.
Review URL: https://codereview.chromium.org/1132333002
Cr-Commit-Position: refs/heads/master@{#329810}
|
|
|
|
|
|
|
|
|
|
|
| |
Default becomes enabled.
BUG=413541
TEST=manually tested
Review URL: https://codereview.chromium.org/1114123005
Cr-Commit-Position: refs/heads/master@{#328715}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the command line switch --internal-display-color-profile-file is provided
load the given ICC file using qcms and extract the VCGT data. Use this VCGT
data to apply a gamma ramp to change the output on the internal display using
drmModeCrtcSetGammaRamp.
Original CL: https://codereview.chromium.org/1028563003/
Reason for reland: Linux ChromiumOS GN (dbg) build broke (missing qcms dep in
ash/BUILD.gn)
BUG=471749
TEST=On a link_freon device add the command line option to load a sample ICC
file (e.g. Bluish.icc to give a blue tint) and observe on startup that the
internal display is blue tinted.
TBR=sievers@chromium.org
Review URL: https://codereview.chromium.org/1119113004
Cr-Commit-Position: refs/heads/master@{#328514}
|
|
|
|
|
|
|
|
|
|
| |
This is the first step of getting rid of InputViewConfig.
BUG=481556
Review URL: https://codereview.chromium.org/1129513003
Cr-Commit-Position: refs/heads/master@{#328352}
|
|
|
|
|
|
|
|
|
|
|
| |
The shelf appear on top of VK if VK is locked and then switch to
lock screen. This CL fixes it. Along with it, an old flag is removed.
BUG=482416
Review URL: https://codereview.chromium.org/1111273005
Cr-Commit-Position: refs/heads/master@{#328331}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
display (patchset #15 id:300001 of https://codereview.chromium.org/1028563003/)
Reason for revert:
breaks compilation
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN%20(dbg)/builds/1084
Original issue's description:
> Load and apply a vcgt table from an ICC file to the internal display
>
> When the command line switch --internal-display-color-profile-file is provided
> load the given ICC file using qcms and extract the VCGT data. Use this VCGT
> data to apply a gamma ramp to change the output on the internal display using
> drmModeCrtcSetGammaRamp.
>
> BUG=471749
> TEST=On a link_freon device add the command line option to load a sample ICC
> file (e.g. Bluish.icc to give a blue tint) and observe on startup that the
> internal display is blue tinted.
>
> Committed: https://crrev.com/46134a86af1eac76e97b062a68afeaa6c8801216
> Cr-Commit-Position: refs/heads/master@{#328318}
TBR=dcheng@chromium.org,dnicoara@chromium.org,noel@chromium.org,oshima@chromium.org,sievers@chromium.org,spang@chromium.org,robert.bradford@intel.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=471749
Review URL: https://codereview.chromium.org/1118373006
Cr-Commit-Position: refs/heads/master@{#328321}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the command line switch --internal-display-color-profile-file is provided
load the given ICC file using qcms and extract the VCGT data. Use this VCGT
data to apply a gamma ramp to change the output on the internal display using
drmModeCrtcSetGammaRamp.
BUG=471749
TEST=On a link_freon device add the command line option to load a sample ICC
file (e.g. Bluish.icc to give a blue tint) and observe on startup that the
internal display is blue tinted.
Review URL: https://codereview.chromium.org/1028563003
Cr-Commit-Position: refs/heads/master@{#328318}
|
|
|
|
|
|
|
|
|
|
| |
It is obsolete now, so can be removed
BUG=
Review URL: https://codereview.chromium.org/827733003
Cr-Commit-Position: refs/heads/master@{#325816}
|
|
|
|
|
|
|
|
| |
BUG=463546
Review URL: https://codereview.chromium.org/1045433002
Cr-Commit-Position: refs/heads/master@{#325253}
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=454959
TEST=Attach to cellular network. A systray notification should appear,
prompting to download Data Saver. Click to go to CWS Data Saver page.
This is a first draft, so folks can try it out. All new functionality is behind the "enable-datasaver-prompt" experimental flag. UMA code and possible UI tweaks still to come.
Review URL: https://codereview.chromium.org/1022333002
Cr-Commit-Position: refs/heads/master@{#324126}
|
|
|
|
|
|
|
|
|
|
|
| |
Use one umbrella command line switch.
BUG=469984,462445
R=nkostylev@chromium.org
Review URL: https://codereview.chromium.org/1066843002
Cr-Commit-Position: refs/heads/master@{#324036}
|
|
|
|
|
|
|
|
|
| |
BUG=413541
TEST=manually tested.
Review URL: https://codereview.chromium.org/1049833004
Cr-Commit-Position: refs/heads/master@{#323671}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The notification differs based on whether there is an extension
that can handle the printer installed and enabled.
If there is one, notification informs the user that the printer is ready;
otherwise, it offers the user to search CWS for an extension that can
handle the printer.
Clicking the latter notification would launch UI with Chrome Web Store
widget listing apps that handle the plugged in printer. This UI is still
not implemented, so for now clicking notification is no-op.
Hide this behind a switch while the feature is being implemented.
BUG=439448
TEST=Manual
Review URL: https://codereview.chromium.org/1022703002
Cr-Commit-Position: refs/heads/master@{#323607}
|
|
|
|
|
|
|
|
|
| |
BUG=456839
TEST=browser_test
Review URL: https://codereview.chromium.org/1048093002
Cr-Commit-Position: refs/heads/master@{#323249}
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=browser_tests
Review URL: https://codereview.chromium.org/1049703003
Cr-Commit-Position: refs/heads/master@{#323106}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Platform verification is disabled in dev mode unless overridden by the flag
--allow-ra-in-dev-mode.
BUG=314782
TEST=Manually tested in dev mode.
Review URL: https://codereview.chromium.org/1046963003
Cr-Commit-Position: refs/heads/master@{#322975}
|
|
|
|
|
|
|
|
|
|
|
| |
--disable-new-md-input-view.
BUG=422869,470405
TBR=asvitkine@chromium.org,bshe@chromium.org
Review URL: https://codereview.chromium.org/1022143003
Cr-Commit-Position: refs/heads/master@{#322124}
|
|
|
|
|
|
|
|
| |
BUG=462445
Review URL: https://codereview.chromium.org/1025663002
Cr-Commit-Position: refs/heads/master@{#322042}
|
|
|
|
|
|
|
|
|
|
|
|
| |
We are not going to use 'EmbeddedSignIn' endpoint for OOBE, so this code
could be safely removed.
BUG=468439
TEST=manually
Review URL: https://codereview.chromium.org/1018133002
Cr-Commit-Position: refs/heads/master@{#321355}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch implements firewall hole punching when a Chrome App uses
the chrome.socket, chrome.sockets.tcpServer or chrome.sockets.udp APIs
to open a socket to receive packets from the network. Sockets that only
listen on the local loopback device do not open a port.
A primitive FirewallHole class is added that could be reused by the
Pepper sockets API as well.
BUG=435404
Review URL: https://codereview.chromium.org/965613002
Cr-Commit-Position: refs/heads/master@{#320552}
|
|
|
|
|
|
|
|
| |
BUG=464644
Review URL: https://codereview.chromium.org/1001813002
Cr-Commit-Position: refs/heads/master@{#320471}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Use EAFE to get auth code for Easy bootstrap;
- BootstrapInitializer to fetch user info for adding a user;
- BootstrapUserFlow to perform Smart lock pairing since no password
is present;
- BootstrapManager to track pending bootstrapping user;
BUG=433133,435202
TEST=BootstrapTest.*
Review URL: https://codereview.chromium.org/825683006
Cr-Commit-Position: refs/heads/master@{#319494}
|