summaryrefslogtreecommitdiffstats
path: root/chromeos/dbus/fake_cros_disks_client.h
Commit message (Collapse)AuthorAgeFilesLines
* Update {virtual,override,final} to follow C++11 style in chromeos/dbus.dcheng2015-01-161-26/+24
| | | | | | | | | | | | | | | | The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with a ChromeOS build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=hashimoto@chromium.org Review URL: https://codereview.chromium.org/817853005 Cr-Commit-Position: refs/heads/master@{#311851}
* Merge CrosDisksClientStubImpl into FakeCrosDisksClientsatorux2014-10-301-1/+9
| | | | | | | | | | | | | | | | | Move the fake mounting logic from CrosDisksClientStubImpl to FakeCrosDsisksClient, with some simplification. The fake behaviors are used in FileManagerBrowserTest's OpenZipFiles test. The test is currently disabled for a performance reason, but I've confirmed that the test passes with --gtest_also_run_disabled_tests. TEST=out/Release/browser_tests --gtest_filter='*OpenZipFiles*' --gtest_also_run_disabled_tests BUG=309506 Review URL: https://codereview.chromium.org/676423004 Cr-Commit-Position: refs/heads/master@{#302053}
* replace OVERRIDE and FINAL with override and final in chromeos/mostynb2014-10-061-10/+10
| | | | | | | | BUG=417463 Review URL: https://codereview.chromium.org/628883002 Cr-Commit-Position: refs/heads/master@{#298229}
* Add EnumerateMountEntries method in CrosDisksClient.kinaba@chromium.org2014-05-161-0/+3
| | | | | | | | | | | | The corresponding dbus level method is already added in https://chromium-review.googlesource.com/#/c/195111/. This CL is for adding the method to the wrapper client class. BUG=356583 Review URL: https://codereview.chromium.org/281063002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270958 0039d316-1c4b-4281-b951-d872f2087c98
* Use cros-disks Format DBus call instead of deprecated FormatDevice.benchan@chromium.org2014-05-061-23/+20
| | | | | | | | | | | | | | | | | | | | | The cros-disks FormatDevice DBus call has been long deprecated (back in 2011). This CL modifies CrosDisksClient and DiskMountManager to use the Format DBus call instead. BUG=369877 TEST=Tested the following: 1. Run chromeos_unittests. 2. Insert a USB drive and format the mounted partition via Files.app. Verify that Files.app notifies the successful completion of the format operation. 3. Insert a write-protected SD card and format the mounted partition via Files.app. Verify that Files.app reports an error. R=stevenjb@chromium.org, tbarzic@chromium.org Review URL: https://codereview.chromium.org/262393002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268623 0039d316-1c4b-4281-b951-d872f2087c98
* Observe cros-disks FormatCompleted signal instead of FormattingFinished.benchan@chromium.org2014-05-061-3/+10
| | | | | | | | | | | | | | | | | | | | | | | The FormattingFinished signal has been long deprecated (back in 2011) and replaced by the FormatCompleted signal, which allows cros-disks to properly notify Chrome the completion of a format operation with an appropriate error code. This CL modifies CrosDisksClient and DiskMountManager to use the FormatCompleted signal. BUG=369877 TEST=Tested the following: 1. Run chromeos_unittests. 2. Insert a USB drive and format the mounted partition via Files.app. Verify that Files.app notifies the successful completion of the format operation. 3. Insert a write-protected SD card and format the mounted partition via Files.app. Verify that Files.app reports an error. R=stevenjb@chromium.org, tbarzic@chromium.org Review URL: https://codereview.chromium.org/266143002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268398 0039d316-1c4b-4281-b951-d872f2087c98
* Split construction and initialization of DBus clients.pneubeck@chromium.org2013-08-271-1/+2
| | | | | | | | | | | | | | | Before, each Client had a Create function which constructed an instance of the client and initialized it (with a dbus::Bus*). To make the Clients separately replaceable in the DBusThreadManager, it's necessary to separate the construction of the Clients from their initialization. This CL, splits each Create function into Create (which only calls the constructor of either the real Impl or the Stub) and Init(dbus::Bus*). This is a pure refactoring. BUG=275286 Review URL: https://chromiumcodereview.appspot.com/23119006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219775 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Remove unused 'type' argument from CrosDisksClient::Mounthashimoto@chromium.org2013-07-121-1/+0
| | | | | | | | | | BUG=None TEST=build R=satorux@chromium.org Review URL: https://codereview.chromium.org/18556006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211358 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Replace base::Callback<void()> typedefs in CrosDisksClient with ↵hashimoto@chromium.org2013-07-041-5/+6
| | | | | | | | | | | | base::Closure BUG=None TEST=chromeos_unittests R=satorux@chromium.org Review URL: https://codereview.chromium.org/18609003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210118 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Change CrosDisksClient::Unmount's callback type to base::Closurehashimoto@chromium.org2013-07-021-2/+2
| | | | | | | | | | | | CrosDisksClient::Unmount() has been just passing the argument to the callback. BUG=None TEST=chromeos_unittests R=satorux@chromium.org Review URL: https://codereview.chromium.org/18472002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209632 0039d316-1c4b-4281-b951-d872f2087c98
* Use MockDBusThreadManagerWithoutGMock for DiskMountManagerTestharuki@chromium.org2013-05-141-0/+59
| | | | | | | | | | | | Adding FakeCrosDisksClient some utilities to inspect methods calls. BUG=223061 TEST=trybots R=satorux@chromium.org Review URL: https://codereview.chromium.org/14565003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199905 0039d316-1c4b-4281-b951-d872f2087c98
* dbus: Add FakeCrosDisksClientharuki@chromium.org2013-04-231-0/+62
BUG=234445 TEST=trybots Review URL: https://chromiumcodereview.appspot.com/13896020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195828 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-05-31 07:59:00 +0000