| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason for revert:
This change broke --disable-arc-opt-in-verification used for
autotests.
> Add ArcEnabled policy implementation
>
> Hide "ARC OptIn" control from Chrome:Settings for enterprise users,
> map ArcEnabled policy to ArcEnabled pref.
>
> BUG=582440
>
> Review URL: https://codereview.chromium.org/1684063002
>
> Cr-Commit-Position: refs/heads/master@{#382266}
TBR=pbond@chromium.org,bartfab@chromium.org,jochen@chromium.org,dbeam@chromium.org,tnagel@chromium.org,hidehiko@chromium.org,hashimoto@chromium.org
BUG=582440
Review URL: https://codereview.chromium.org/1825143003
Cr-Commit-Position: refs/heads/master@{#382819}
|
|
|
|
|
|
|
|
|
|
|
| |
Hide "ARC OptIn" control from Chrome:Settings for enterprise users,
map ArcEnabled policy to ArcEnabled pref.
BUG=582440
Review URL: https://codereview.chromium.org/1684063002
Cr-Commit-Position: refs/heads/master@{#382266}
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds support for using Gaia ID as cryptohome identifier.
BUG=462823
TEST=unit tests
Review URL: https://codereview.chromium.org/1693383003
Cr-Commit-Position: refs/heads/master@{#379262}
|
|
|
|
|
|
|
|
|
| |
BUG=138542
TBR=zelidrag@chromium.org
Review URL: https://codereview.chromium.org/1540803002
Cr-Commit-Position: refs/heads/master@{#366324}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This updates the session_manager D-Bus client to expose the ARC-related
methods that were recently added to Chrome OS.
BUG=b:24339743
CQ-DEPEND=CL:1430493004
Review URL: https://codereview.chromium.org/1432583004
Cr-Commit-Position: refs/heads/master@{#358130}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
string." (patchset #3 id:40001 of https://codereview.chromium.org/1289393002/ )
Reason for revert:
Reverting did not fix lab failure.
Original issue's description:
> Revert "SessionManagerClient::RestartJob: Use argv instead of string."
>
> This speculatively reverts commit fb4a4c60596d52a2f3ab26ab94399d3ebd5a64c1.
>
> For details please see crbug.com/520311
>
> NOTRY=true
> TBR=mnissler
> BUG=chromium:520311, chromium:433172
> TEST=compiles
>
> Committed: https://crrev.com/7458fb3730f7cfc084f310a7cbebde489aa78439
> Cr-Commit-Position: refs/heads/master@{#343536}
TBR=hshi@chromium.org,marcheu@chromium.org,derat@chromium.org,mnissler@chromium.org,stevenjb@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:520311, chromium:433172
Review URL: https://codereview.chromium.org/1300253003
Cr-Commit-Position: refs/heads/master@{#344424}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This speculatively reverts commit fb4a4c60596d52a2f3ab26ab94399d3ebd5a64c1.
For details please see crbug.com/520311
NOTRY=true
TBR=mnissler
BUG=chromium:520311, chromium:433172
TEST=compiles
Review URL: https://codereview.chromium.org/1289393002
Cr-Commit-Position: refs/heads/master@{#343536}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes the interface to session_manager to pass the command line
as an array instead of a string. The previous code path would
(incorrectly) quote arguments and combine them into a string, and then
again parse and unquote them on the session_manager side, which is
unnecessary and error-prone. This changes the code to pass an array of
strings in the DBus call, which simplifies things considerably.
BUG=chromium:433172
TEST=Guest session starts successfully.
Review URL: https://codereview.chromium.org/1268973004
Cr-Commit-Position: refs/heads/master@{#341873}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is everything but the chrome directory
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=zelidrag@chromium.org (chromeos)
TBR=keybuk@chromium.org (device/bluetooth)
Review URL: https://codereview.chromium.org/1162943002
Cr-Commit-Position: refs/heads/master@{#332626}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.
This patch was automatically generated with a ChromeOS build using a
variation of https://codereview.chromium.org/598073004.
BUG=417463
R=hashimoto@chromium.org
Review URL: https://codereview.chromium.org/817853005
Cr-Commit-Position: refs/heads/master@{#311851}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make the Chrome OS implementation of
CheckIdleStateIsLocked() (used by the chrome.idle API) get
the lock state from chromeos::SessionManagerClient instead
of depending on ash::SessionStateDelegate (which reaches
into chrome/browser/chromeos/login/). This makes it possible
for the idle code to be later moved under ui/base/ instead
of living in chrome/browser/, permitting the chrome.idle API
to be moved from chrome/ to extensions/.
As part of this, make SessionManagerClient cache the
most-recently-received-from-session_manager screen-lock
state. Previously it just passed state updates to its
observers, but the idle functions lack a class that can
register itself as an observer.
BUG=446320
Review URL: https://codereview.chromium.org/852453005
Cr-Commit-Position: refs/heads/master@{#311333}
|
|
|
|
|
|
|
|
|
|
| |
supervised user creation is active
BUG=425546
Review URL: https://codereview.chromium.org/705333002
Cr-Commit-Position: refs/heads/master@{#303443}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Updated all clients that wrap HasObserver and expose it to also take a
const pointer. This change avoids further propagation of non-constness
(which was previously required when using HasObserver methods).
BUG=429588
TBR=michaeln@chromium.org,nyquist@chromium.org,pkotwicz@chromium.org,satorux@chromium.org,sky@chromium.org,zea@chromium.org
Review URL: https://codereview.chromium.org/697953002
Cr-Commit-Position: refs/heads/master@{#303428}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 8212232fac77f4f0335ea8d065960777e955d98e. It has
been replaced by a simpler implementation, so this code is no longer
necessary.
BUG=chromium:397354
Review URL: https://codereview.chromium.org/655553002
Cr-Commit-Position: refs/heads/master@{#299490}
|
|
|
|
|
|
|
|
| |
BUG=417463
Review URL: https://codereview.chromium.org/628883002
Cr-Commit-Position: refs/heads/master@{#298229}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It will never return true on a vanilla device anyways and prevents some testing operations.
This is a copy of https://codereview.chromium.org/432093002/ -- Julian is OOO
and has asked me to get it reviewed and landed for him. Since I can't edit his CL, I've created this copy.
The Chromium OS part of this change is at: https://chromium-review.googlesource.com/#/c/210470/
BUG=397354
TEST=unit, manual
Review URL: https://codereview.chromium.org/462513004
Cr-Commit-Position: refs/heads/master@{#290607}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/228703004/)
Reason for revert:
Seems to be breaking user sign in.
See also http://crbug.com/369040
Original issue's description:
> Start session fail causes restart chrome
>
> BUG=244628
> TEST=manual check on Acer C720
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266791
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/268293002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This call is used to request the current server-backed state keys from
session_manager.
BUG=chromium:358213
TEST=None
Review URL: https://codereview.chromium.org/240373003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Note: this is a reland of https://codereview.chromium.org/258743005
This change implements some of the DBus stub methods so that enterprise enrollment works on desktop builds. That will make development of features that depend on enrollment faster for developers that use this workflow (e.g. for kiosk enterprise apps, public accounts, testing some device policies, etc).
- Override some of the directories and files involved with the enrollment state
- Simple stub implementation of the DBus calls involved
- Write a persistent cache of the install attributes
- Cleaned up the stub for user cloud policy and made them persistent too
- Updated some tests
This change doesn't affect production code.
TBR=jochen@chromium.org
BUG=240269, 367674
Review URL: https://codereview.chromium.org/264943011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/258743005/)
Reason for revert:
It seems to have broken the following test from
base_unittests and unit_tests on chromium.webkit Android Tests (dbg) builder:
PathServiceTest.Override
Log: http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/18922
Snippet from log:
C 237s Main [FAIL] PathServiceTest.Override:
C 237s Main ../../base/path_service_unittest.cc:184: Failure
C 237s Main Value of: PathService::OverrideAndCreateIfNeeded(my_special_key,
non_existent, false, false)
C 237s Main Actual: true
C 237s Main Expected: false
Original issue's description:
> Enable Enterprise enrollment on desktop builds.
>
> This change implements some of the DBus stub methods so that enterprise enrollment works on desktop builds. That will make development of features that depend on enrollment faster for developers that use this workflow (e.g. for kiosk enterprise apps, public accounts, testing some device policies, etc).
>
> - Override some of the directories and files involved with the enrollment state
> - Simple stub implementation of the DBus calls involved
> - Write a persistent cache of the install attributes
> - Cleaned up the stub for user cloud policy and made them persistent too
> - Updated some tests
>
> This change doesn't affect production code.
>
> TBR=jochen@chromium.org
> BUG=240269, 367674
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267640
TBR=brettw@chromium.org,nkostylev@chromium.org,pastarmovj@chromium.org,satorux@chromium.org,jochen@chromium.org,joaodasilva@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=240269, 367674
Review URL: https://codereview.chromium.org/265013002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change implements some of the DBus stub methods so that enterprise enrollment works on desktop builds. That will make development of features that depend on enrollment faster for developers that use this workflow (e.g. for kiosk enterprise apps, public accounts, testing some device policies, etc).
- Override some of the directories and files involved with the enrollment state
- Simple stub implementation of the DBus calls involved
- Write a persistent cache of the install attributes
- Cleaned up the stub for user cloud policy and made them persistent too
- Updated some tests
This change doesn't affect production code.
TBR=jochen@chromium.org
BUG=240269, 367674
Review URL: https://codereview.chromium.org/258743005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=244628
TEST=manual check on Acer C720
Review URL: https://codereview.chromium.org/228703004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove code that listened for a LockScreen D-Bus signal,
formerly emitted by the session manager to instruct Chrome
to lock the screen. Chrome now exports a LockScreen method
instead.
BUG=341921
Review URL: https://codereview.chromium.org/167663004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The upstart event emitted by this call is no longer used
for anything and hasn't been for some time. Remove it.
BUG=chromium:324514
TEST=browser_tests
Review URL: https://codereview.chromium.org/138913012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RestartEntd() was deprecated years ago, so calls to this method
can certainly be removed. The UnlockScreen() method has done
nothing but emit a signal that no process listens to for several
releases now.
BUG=chromium:286401
TEST=unit tests, desktopui_ScreenLocker autotest
Review URL: https://chromiumcodereview.appspot.com/23694025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=172070
TEST=browser_tests:WizardControllerBrokenLocalStateTest*
Review URL: https://chromiumcodereview.appspot.com/23461015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before, each Client had a Create function which constructed an instance of the client and initialized it (with a dbus::Bus*).
To make the Clients separately replaceable in the DBusThreadManager, it's necessary to separate the construction of the Clients from their initialization.
This CL, splits each Create function into Create (which only calls the constructor of either the real Impl or the Stub) and Init(dbus::Bus*).
This is a pure refactoring.
BUG=275286
Review URL: https://chromiumcodereview.appspot.com/23119006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Profile can be created both in a synchronous and asynchronous mode. When
asynchronous then the policy subsystems can load policy asynchronously, and the
Profile resumes initialization once the policies are ready; this is the default
on ChromeOS. But the synchronous path must load all the preferences (and thus,
all the policies) during construction of the Profile, and this is used on
ChromeOS when restarting the browser after a crash or after changing the flags.
This CL makes that path load policy synchronously, so that the Profile starts
with the correct managed settings immediately.
Additionally, since the PolicyServiceImpl sends out its initialization and
policy-changed signals in different tasks, this CL makes the PolicyPrefStore
recompute the managed preferences on the initialization signal as well.
BUG=263061
Review URL: https://chromiumcodereview.appspot.com/20053003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After the profile is loaded we verify if the user has specfied any flags
or if there were flags specified per policy that differ from the user
specfied flags and in either case restart Chrome with the desired flags.
This allows non-owners to use the about:flags page and prevents policy
set flags from leaking inside user sessions.
BUG=221352
TEST=unit_tests & Manually by specifying flags in non-owner session and observing them respected.
Review URL: https://chromiumcodereview.appspot.com/16770002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=180903,238998,230464
TEST=Induce browser crash in multi-profile sessions, observe that all user sessions are restored
TEST=CrashRestoreSimpleTest, CrashRestoreComplexTest
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/15929005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Depends on https://codereview.chromium.org/15566003/
BUG=238998
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/15576002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The SessionManagerClient is used to store and retrieve the user policy blobs
to and from the session_manager over DBus. New variants of these calls have been
introduced that have an additional 'username' argument, so that user policy can
be used with multiple profiles.
This CL updates the SessionManagerClient to use the new calls, and it also
makes the SessionManagerClientStub mimic the behavior of session_manager
regarding the user policy key, so that user policy can be validated and loaded
on desktop builds.
BUG=187482,230349
TEST=User policy works as before, all tests green; user policy works with --multi-profiles, and on desktop builds with --login-manager
Review URL: https://chromiumcodereview.appspot.com/14761012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add call_count for FakeSessionManagerClient
and checkes them in ScreenLockerTest
to replace call expectations.
BUG=239333,234457
TEST=trybots
Review URL: https://chromiumcodereview.appspot.com/14944005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introducing a call counter for EmitLoginPromptReady() in FakeSessionManagerClient.
BUG=239333
TEST=trybots
R=satorux@chromium.org
Review URL: https://codereview.chromium.org/14738007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Un-revert 12218078, and check if the device local account policy
is already set before spinning a run loop in
ExistingUserControllerPublicSessionTest#SetUpOnMainThread.
BUG=152933
TBR=satorux
Review URL: https://chromiumcodereview.appspot.com/12457029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Due to flaky tests:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40DEPS%20CrOS%20-%20chromium.org&testType=browser_tests&tests=ExistingUserControllerPublicSessionTest
> Implement a policy to autologin a public account.
>
> This introduces a policy to automatically login a public account on
> Chrome OS after a specified period of time has elapsed at the login
> screen. There are two new policy settings:
> "DeviceLocalAccountAutoLoginUsername", which determines which public
> account will be logged in, and "DeviceLocalAccountAutoLoginTimerMillis",
> which specifies the amount of time that should elapse before autologin
> takes place.
>
> The autologin timer is started in ExistingUserController when either the
> sign-in screen UI is finished loading or the aforementioned policy
> settings are changed.
>
> BUG=152933
>
>
> Review URL: https://chromiumcodereview.appspot.com/12218078
TBR=dconnelly@chromium.org
Review URL: https://codereview.chromium.org/12763004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
This introduces a policy to automatically login a public account on
Chrome OS after a specified period of time has elapsed at the login
screen. There are two new policy settings:
"DeviceLocalAccountAutoLoginUsername", which determines which public
account will be logged in, and "DeviceLocalAccountAutoLoginTimerMillis",
which specifies the amount of time that should elapse before autologin
takes place.
The autologin timer is started in ExistingUserController when either the
sign-in screen UI is finished loading or the aforementioned policy
settings are changed.
BUG=152933
Review URL: https://chromiumcodereview.appspot.com/12218078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188331 0039d316-1c4b-4281-b951-d872f2087c98
|