summaryrefslogtreecommitdiffstats
path: root/chromeos/network
Commit message (Collapse)AuthorAgeFilesLines
* SimpleGeolocation should support sending WiFi AP data.alemate2016-03-231-0/+2
| | | | | | | | | BUG=596690 TEST=unittest Review URL: https://codereview.chromium.org/1819173002 Cr-Commit-Position: refs/heads/master@{#382968}
* Extend vpnProvider to allow reconnectionscernekee2016-03-162-1/+18
| | | | | | | | | | | | | | | | | | Upcoming changes in the Chrome OS networking daemon (shill) will allow third party VPNs to transition "backwards" from Online->Configuring if the default physical connection changes. Add a "reconnect" flag so that VPN apps can signal their compatibility with this new scheme, and add the necessary UI changes so that Chrome can identify reconnections and present them to the user in a sensible way. Also, change the UI so that users can cancel VPN reconnections (and connections) using the "Disconnect" button. BUG=514343 Review URL: https://codereview.chromium.org/1722453002 Cr-Commit-Position: refs/heads/master@{#381566}
* Invoke createNetwork() callback with GUID, not service namecernekee2016-03-158-17/+30
| | | | | | | | | | | | | | The current implementation doesn't match the API spec. Fix this. BUG=593196 TEST=go to chrome://settings/network , ctrl-shift-i, run in console: chrome.networkingPrivate.createNetwork(false, {"Type":"WiFi","WiFi":{"SSID":"GoogleGuest","AutoConnect":true}}, function(x) { console.log(x); }) Review URL: https://codereview.chromium.org/1779633002 Cr-Commit-Position: refs/heads/master@{#381347}
* Allow ${CERT_SAN_EMAIL} and ${CERT_SAN_UPN} in the ONC Identity fieldcernekee2016-03-034-32/+114
| | | | | | | | | | | | | | | | | | | Currently enterprise customers can specify ${LOGIN_ID} or ${LOGIN_EMAIL} to tell Chrome OS to substitute user identity information into an EAP configuration. However, in some installations, the login ID for the Chromebook does not match the login ID for the EAP-TLS wireless network; instead, the EAP-TLS identity is stored in the subjectAltName field in the client certificate. Add code to Chrome to allow this field to be extracted if so configured in CPanel. BUG=549659 TEST=`chromeos_unittests` TEST=manually configure EAP-TLS network in CPanel, then watch the `freeradius -X` logs during connection Review URL: https://codereview.chromium.org/1717123002 Cr-Commit-Position: refs/heads/master@{#379056}
* net: move IsLocalhost() function into url_util.htfarina2016-02-231-1/+0
| | | | | | | | | | | | | | This patch moves the last function in net_util.h into url_util.h. We are moving it there because it also operates on a URL part (host). BUG=488531 TEST=net_unittests --gtest_filter=UrlUtilTest.IsLocalhost R=eroman@chromium.org TBR=darin@chromium.org Review URL: https://codereview.chromium.org/1726693002 Cr-Commit-Position: refs/heads/master@{#377115}
* net: move GetHostName() function into network_interfaces.htfarina2016-02-121-1/+1
| | | | | | | | | | | | | | | | This patch moves it from net_util to network_interfaces because the hostname is a name for one of the machine's addresses. There could be multiple names based on the multiple addresses for the various interfaces, so this seems like a reasonable place. BUG=488531 TEST=net_unittests --gtest_filter=NetworkInterfacesTest.* R=eroman@chromium.org TBR=darin@chromium.org # for changes outside of net Review URL: https://codereview.chromium.org/1696533002 Cr-Commit-Position: refs/heads/master@{#375102}
* Add BSSID + Frequency to NetworkState/getNetworksstevenjb2016-01-202-20/+20
| | | | | | | | BUG=575412 Review URL: https://codereview.chromium.org/1583423002 Cr-Commit-Position: refs/heads/master@{#370513}
* Remove debug logoshima2016-01-091-6/+0
| | | | | | | | | BUG=None TBR=stevenjb@chromium.org Review URL: https://codereview.chromium.org/1573443003 Cr-Commit-Position: refs/heads/master@{#368505}
* Fix potential crashes in NetworkHandler codestevenjb2016-01-0714-27/+53
| | | | | | | | | | | | | | | | | | | This CL: * Properly removes NetworkConnectionHandler observer in ~AutoConnectHandler. * Checks observer lists in NetworkHandler classes on shutdown (to catch any future regressions). * Destroys ProxyConfigServiceImpl owned by IOThread before NetworkHandler is destroyed to remove the NetworkStateHandler observer. BUG=572914 For chrome/browser/extensions/api/vpn_provider/vpn_provider_apitest.cc: TBR=rdevlin.cronin@chromium.org Review URL: https://codereview.chromium.org/1562593002 Cr-Commit-Position: refs/heads/master@{#368118}
* Convert Pass()→std::move() in //chromeosdcheng2015-12-3122-56/+70
| | | | | | | | | | | | (╯^□^)╯︵ ❄☃❄ BUG=557422 R=avi@chromium.org TBR=stevenjb@chromium.org Review URL: https://codereview.chromium.org/1556773002 Cr-Commit-Position: refs/heads/master@{#367230}
* Switch to standard integer types in chromeos/.avi2015-12-2181-69/+147
| | | | | | | | | BUG=138542 TBR=zelidrag@chromium.org Review URL: https://codereview.chromium.org/1540803002 Cr-Commit-Position: refs/heads/master@{#366324}
* Convert vector_as_array to vector::data in //chrome{,cast,os}.davidben2015-11-301-2/+1
| | | | | | | | | BUG=556678 TBR=zelidrag@chromium.org Review URL: https://codereview.chromium.org/1452853002 Cr-Commit-Position: refs/heads/master@{#362264}
* Play better with C++11 library features from /chromeoslimasdf2015-11-252-5/+5
| | | | | | | | | | | | | - Get rid of ScopedPtrMap - Get rid of linked_ptr - Replace Pass() with std::move() BUG=554291, 557422, 556939 TBR=cschuet@chromium.org Review URL: https://codereview.chromium.org/1454773002 Cr-Commit-Position: refs/heads/master@{#361509}
* only forbid unmanaged WiFi on AllowOnlyPolicyNetworksToConnectfqj2015-11-232-3/+8
| | | | | | | | BUG=208378 Review URL: https://codereview.chromium.org/1465133002 Cr-Commit-Position: refs/heads/master@{#361144}
* Handle device ONC AllowOnlyPolicyNetworksToConnectfqj2015-11-195-1/+97
| | | | | | | | BUG=208378 Review URL: https://codereview.chromium.org/1461823002 Cr-Commit-Position: refs/heads/master@{#360474}
* UI changes to disable button for prohibted technologiesfqj2015-11-174-1/+13
| | | | | | | | | | | | | | | | This commit grays out the buttons for some specific technologies, and modifies the hint text of system tray for user session if they are prohibited. It also removes the corresponding elements in chrome://settings page. Depends on: https://codereview.chromium.org/1431563005/ BUG=426390 Review URL: https://codereview.chromium.org/1434443002 Cr-Commit-Position: refs/heads/master@{#360186}
* Execute ClientCertResolver on network disconnection.emaxx2015-11-173-24/+103
| | | | | | | | | | | | | | | | | | | | | The previous behavior was that the certificate resolver was executed only in a few circumstances: directly after login, when a certificate is installed/removed, when the network list changes. This means that if a certificate expired and none of the above happened before a next network connection is initiated, then the network configuration in Network Manager would still contain the certificate. This, in turn, means that the managed users won't see the "Get new certificate" dialog (the Wi-Fi profile setup dialog will appear instead). So the solution is to trigger the certificate resolver when the network disconnection happens, so that the expired certificate is removed before the next connect attempt. BUG=551380 Review URL: https://codereview.chromium.org/1443043002 Cr-Commit-Position: refs/heads/master@{#360110}
* Handle prohibited technologies in device policy ONCfqj2015-11-1319-26/+517
| | | | | | | | | | | | | | | This commit changes prohibited technologies from user policy ONC to device policy ONC, and then handles it. The device policy ONC will only take effect after user session starts. After use has logged in, the prohibited technologies in ONC will take effect and disable and prohibit specific technologies. BUG=426390 Review URL: https://codereview.chromium.org/1431563005 Cr-Commit-Position: refs/heads/master@{#359602}
* ONC: AllowOnlyPolicyNetworksToConnectfqj2015-11-133-0/+18
| | | | | | | | | | | This CL maps AllowOnlyPolicyNetworksToConnect to only allowing users to connect to managed networks. BUG=208378 Review URL: https://codereview.chromium.org/1433423003 Cr-Commit-Position: refs/heads/master@{#359542}
* Let AutoConnectHandler wait for user policy before disconnectingfqj2015-11-103-5/+15
| | | | | | | | | | | | | | | AutoConnectHandler didn't wait for user policy before disconnecting from unmanaged network. This will lead to user policy not downloaded or applied. This commit make AutoConnectHandler to wait for user policy first before disconnecting from unmanaged network if device policy requires to do so. BUG=553497 Review URL: https://codereview.chromium.org/1415683013 Cr-Commit-Position: refs/heads/master@{#358730}
* Add Dynamic WEP support to wifi config UIstevenjb2015-11-064-8/+13
| | | | | | | | BUG=551666 Review URL: https://codereview.chromium.org/1406933005 Cr-Commit-Position: refs/heads/master@{#358233}
* Translate 802.1x WEP ("Enterprise WEP")pstew2015-11-044-2/+30
| | | | | | | | | | | | | This CL adds translation of "Enterprise WEP": 802.1x authentication with WEP encryption. BUG=551085 TEST=New unit tests R=stevenjb@chromium.org Review URL: https://codereview.chromium.org/1412283006 Cr-Commit-Position: refs/heads/master@{#357867}
* Fix some internet settings error loggingstevenjb2015-10-281-1/+1
| | | | | | | | | | | | | This works around a known bug with logging JS errors: http://crbug.com/365427 It also removes a bit of logging spam. BUG=none Review URL: https://codereview.chromium.org/1423043003 Cr-Commit-Position: refs/heads/master@{#356626}
* Add IPv6 Address to status traystevenjb2015-10-262-0/+24
| | | | | | | | BUG=526975 Review URL: https://codereview.chromium.org/1417853002 Cr-Commit-Position: refs/heads/master@{#356084}
* Make ValueDeserializer::Deserialize return scoped_ptrolli.raula2015-10-162-11/+12
| | | | | | | | | | | | Make ValueDeserializer::Deserialize return scoped_ptr as almost all consumers already use scoped_ptr and it is also better way to do it. TBR=jam@chromium.org Review URL: https://codereview.chromium.org/1394993004 Cr-Commit-Position: refs/heads/master@{#354458}
* ONC: Remove Delete-Certificate functionality.pneubeck2015-10-094-100/+14
| | | | | | | | BUG=538136 Review URL: https://codereview.chromium.org/1371253005 Cr-Commit-Position: refs/heads/master@{#353278}
* Removing pneubeck@ from OWNERS.pneubeck2015-10-071-1/+1
| | | | | | | | Also adding some other overdue owners. Review URL: https://codereview.chromium.org/1384443003 Cr-Commit-Position: refs/heads/master@{#352825}
* Ignore a missing issuer certificate for certificate matching.pneubeck2015-09-302-43/+110
| | | | | | | | BUG=506185 Review URL: https://codereview.chromium.org/1212433006 Cr-Commit-Position: refs/heads/master@{#351579}
* Introduce namespace network_portal_detector.achuith2015-09-282-75/+79
| | | | | | | | | | | | | | | | | | | | | * This houses previously static methods of NetworkPortalDetector, such as Get (now GetInstance), IsInitialized, InitializeForTesting, etc. * InitializeNetworkPortalDetector moved to cbmc * Number of renames of NetworkPortalDetector:: to network_portal_detector:: Files with non-trivial changes: network_portal_detector_impl.{cc|h} network_portal_detector.{cc|h} chrome_browser_main_chromeos.cc Everything else is a mechanical search/replace BUG=530485 TEST=unit tests and browser tests. TBR=kalman@chromium.org Review URL: https://codereview.chromium.org/1358343003 Cr-Commit-Position: refs/heads/master@{#351153}
* Cleanup: IWYU for base/gtest_prod_util.h.thestig2015-09-251-1/+0
| | | | | | | | | | CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=pneubeck@chromium.org Review URL: https://codereview.chromium.org/1366123002 Cr-Commit-Position: refs/heads/master@{#350770}
* Refactor NetworkPortalDetector and NetworkPortalNotificationController.achuith2015-09-224-76/+88
| | | | | | | | | | | | | | | * NetworkPortalNotificationController directly observes network and portal changes. * conditionally create NetworkPortalNotificationController * move NetworkPortalDetectorStubImpl to stub files. * make interface implementations private * initialize data members in header BUG=530485 TEST=unit tests and browser tests. Review URL: https://codereview.chromium.org/1346843003 Cr-Commit-Position: refs/heads/master@{#350202}
* Cleanup: Pass std::string as const reference from chromeos/ki.stfu2015-09-224-4/+9
| | | | | | | | | | | | Passing std::string by reference can prevent extra copying of object. BUG=367418 TEST= R=zelidrag@chromium.org,derat@chromium.org,gauravsh@chromium.org Review URL: https://codereview.chromium.org/1353323002 Cr-Commit-Position: refs/heads/master@{#350078}
* This CL adds ConnectionType to the MaxBandwidthObserver notification as a ↵jkarlin2015-09-182-5/+11
| | | | | | | | | | | | | | convenience for its only client (in the downstream CL), NetInfo. This CL also ensures that MaxBandwidthObserver is called on every platform when the network type changes. Upstream of https://codereview.chromium.org/1306423004/ BUG=412741 Review URL: https://codereview.chromium.org/1306653003 Cr-Commit-Position: refs/heads/master@{#349673}
* Remove SupportsWeakPtr in NetworkPortalNotificationController.achuith2015-09-163-7/+5
| | | | | | | | | | | | Additional owners for NetworkPortalDetector Other minor fixes. BUG=530485 Review URL: https://codereview.chromium.org/1346763002 Cr-Commit-Position: refs/heads/master@{#349077}
* Ramove use of JSONReader::DeprecatedRead from chromeos/olli.raula2015-09-105-22/+22
| | | | | | | | | | Remove use of deprecated function DeprecatedRead from chromeos/ BUG=523194 Review URL: https://codereview.chromium.org/1328233002 Cr-Commit-Position: refs/heads/master@{#348103}
* net/dns: Remove unneeded net_util.h includes from header files.tfarina2015-09-081-0/+1
| | | | | | | | | | | | | | Usually it is only needed in source files because net_util.h is a collection of free functions. BUG=None TEST=net_unittests R=mmenke@chromium.org TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/1311353009 Cr-Commit-Position: refs/heads/master@{#347764}
* Add an ONC property for disabling net technologiescschuet2015-09-074-12/+89
| | | | | | | | | | This CL maps an ONC property for disabling network technologies. BUG=426390 Review URL: https://codereview.chromium.org/1306813008 Cr-Commit-Position: refs/heads/master@{#347638}
* Clean up OWNER files + histograms ownersdpolukhin2015-08-281-1/+0
| | | | | | | | | | | TBR=blundell@chromium.org BUG=none TEST=none Review URL: https://codereview.chromium.org/1322543002 Cr-Commit-Position: refs/heads/master@{#346083}
* Provide ONC Source in MNCH::GetNetworks, Priority in GetStatestevenjb2015-08-216-15/+36
| | | | | | | | | | | | | | Ths CL: * Correctly sets the Source ONC property in GetNetworks * Provides Priorty for networkingPrivate.getState and getNetworks BUG=521037 For missing owner in wifi_config_delegate_chromeos_unittest.cc TBR=stevenjb Review URL: https://codereview.chromium.org/1304683004 Cr-Commit-Position: refs/heads/master@{#344630}
* Elim unused Chrome OS networking UI codestevenjb2015-08-182-14/+3
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/1285373004 Cr-Commit-Position: refs/heads/master@{#343852}
* Make Type an unmanaged ONC propertystevenjb2015-08-132-16/+25
| | | | | | | | | | | This will simplify some of the new Settings UI, allowing us to read onc.Type directly without parsing a managed dictionary. BUG=none Review URL: https://codereview.chromium.org/1284963002 Cr-Commit-Position: refs/heads/master@{#343146}
* Remove remaining legacy SplitString calls.brettw2015-08-121-6/+9
| | | | | | | | TBR=zelidrag@chromium.org (chromeos) Review URL: https://codereview.chromium.org/1284833004 Cr-Commit-Position: refs/heads/master@{#342983}
* Remove useless use of StringPrintf("%s", ...)ricea2015-08-101-2/+1
| | | | | | | | | | | | | It is not necessary to use StringPrintf() to convert a C string to a std::string, as std::string has a constructor which will perform the conversion implicitly. BUG= TEST=compiled Review URL: https://codereview.chromium.org/1280333002 Cr-Commit-Position: refs/heads/master@{#342624}
* Implement networkingPrivate.unlockCellularSim and setCelluarSimStatestevenjb2015-07-313-41/+26
| | | | | | | | | | | | This adds Cellular SIM functionality to the networkingPrivate API. It also adds some functionality to the fake implementation to better support testing. BUG=277890 Review URL: https://codereview.chromium.org/1265513004 Cr-Commit-Position: refs/heads/master@{#341415}
* Reduce LOG(ERROR) spam on linux with chromeos=1stevenjb2015-07-301-2/+1
| | | | | | | | | | | | LOG(ERROR) Spam makes failing tests more difficult to debug and obscures actual errors. This cleans up some spam that always shows up when running on Linux with chromeos=1. BUG=none Review URL: https://codereview.chromium.org/1254013002 Cr-Commit-Position: refs/heads/master@{#341145}
* Move JoinString to the base namespace.brettw2015-07-152-5/+4
| | | | | | | | | | | | | | | | | | | | | Change "Separator" from string to StringPIece (most are constants). Remove char versions for symmetry with SplitString. Update callers who pass empty separators to use a base::StringPiece() Change chromecast/base/metrics/cast_metrics_helper.cc to not use JoinString at all and just append to the output (code is simpler and faster). TBR=zelidrag@chromium.org for chromeos Committed: https://crrev.com/0eabfa001ba06d3c66992b95b69a988ef0633992 Cr-Commit-Position: refs/heads/master@{#338762} patch from issue 1223153003 at patchset 160001 (http://crrev.com/1223153003#ps160001) BUG= Review URL: https://codereview.chromium.org/1230243005 Cr-Commit-Position: refs/heads/master@{#338819}
* Revert of Move JoinString to the base namespace (patchset #9 id:160001 of ↵hongchan2015-07-142-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1223153003/) Reason for revert: The compilation failure with the following error message: FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/chrome/common/common.chrome_content_client.o.d -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DGOOGLE_CHROME_BUILD -DCR_CLANG_REVISION=241602-3 -DENABLE_RLZ -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DIMAGE_LOADER_EXTENSION=1 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DENABLE_TOPCHROME_MD=1 -DUSE_UDEV -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_PROD_WALLET_SERVICE=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_HANGOUT_SERVICES_EXTENSION=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DSAFE_BROWSING_SERVICE -DGL_GLEXT_PROTOTYPES -DMOJO_USE_SYSTEM_IMPL -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DSK_SUPPORT_GPU=1 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_LEGACY_SKPOINT3_CTORS -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DLIBXML_STATIC -DUSE_LIBPCI=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DOS_CHROMEOS=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNO_UNWIND_TABLES -DOFFICIAL_BUILD -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -Igen -I../.. -I../../skia/config -I../../third_party/khronos -I../../gpu -I../../third_party/WebKit/Source -Igen/protoc_out -I../../third_party/protobuf -I../../third_party/protobuf/src -Igen/chrome -I../../third_party/WebKit -I../../third_party/mojo/src -Igen/third_party/mojo/src -I../../net/third_party/nss/ssl -I../../skia/ext -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -I../../third_party/libxml/linux/include -I../../third_party/libxml/src/include -Igen/ui/resources -Igen/extensions -Igen/extensions/strings -I../../third_party/re2 -Igen/policy -Werror -pthread -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -Wno-reserved-user-defined-literal -Xclang -load -Xclang /b/build/slave/google-chrome-rel-chromeos/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -fcolor-diagnostics -g -B/b/build/slave/google-chrome-rel-chromeos/build/src/third_party/binutils/Linux_x64/Release/bin -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -Wno-inconsistent-missing-override -Wexit-time-destructors -Wno-shift-negative-value -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/nss -I/usr/include/nspr -Wno-header-guard -m64 -march=x86-64 -O2 -fno-ident -fdata-sections -ffunction-sections -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-exceptions -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -std=gnu++11 -c ../../chrome/common/chrome_content_client.cc -o obj/chrome/common/common.chrome_content_client.o ../../chrome/common/chrome_content_client.cc:193:34: error: no matching function for call to 'JoinString' std::string codec_string = base::JoinString( ^~~~~~~~~~~~~~~~ Original issue's description: > Move JoinString to the base namespace. > > Change "Separator" from string to StringPIece (most are constants). Remove char versions for symmetry with SplitString. > > Update callers who pass empty separators to use a base::StringPiece() > > Change chromecast/base/metrics/cast_metrics_helper.cc to not use JoinString at all and just append to the output (code is simpler and faster). > > TBR=zelidrag@chromium.org for chromeos > > Committed: https://crrev.com/0eabfa001ba06d3c66992b95b69a988ef0633992 > Cr-Commit-Position: refs/heads/master@{#338762} TBR=jam@chromium.org,zelidrag@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1237873004 Cr-Commit-Position: refs/heads/master@{#338770}
* Move JoinString to the base namespace.brettw2015-07-142-5/+4
| | | | | | | | | | | | | | Change "Separator" from string to StringPIece (most are constants). Remove char versions for symmetry with SplitString. Update callers who pass empty separators to use a base::StringPiece() Change chromecast/base/metrics/cast_metrics_helper.cc to not use JoinString at all and just append to the output (code is simpler and faster). TBR=zelidrag@chromium.org for chromeos Review URL: https://codereview.chromium.org/1223153003 Cr-Commit-Position: refs/heads/master@{#338762}
* Translate ONC ProxySettings <-> Shill ProxyConfigstevenjb2015-07-108-3/+380
| | | | | | | | | | | This CL adds translation of the ProxySettings property in an ONC dictionary to the ProxyConfig property of a Shill dictionary (which previously was not being handled). BUG=470445 TBR=abarth@chromium.org for DEPS change (+url) Review URL: https://codereview.chromium.org/1228543002 Cr-Commit-Position: refs/heads/master@{#338352}
* Allow suppression of expected wake-on-wifi error messagestevenjb2015-07-091-9/+20
| | | | | | | | | | | | This includes a bit of code cleanup too: * Transition to device_event_log.h * Clang formatting BUG=467232 Review URL: https://codereview.chromium.org/1227193002 Cr-Commit-Position: refs/heads/master@{#338111}
generated by cgit v1.1 at 2024-05-15 00:04:05 +0000