| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
This CL maps AllowOnlyPolicyNetworksToConnect to only allowing users
to connect to managed networks.
BUG=208378
Review URL: https://codereview.chromium.org/1433423003
Cr-Commit-Position: refs/heads/master@{#359542}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds translation of "Enterprise WEP": 802.1x authentication
with WEP encryption.
BUG=551085
TEST=New unit tests
R=stevenjb@chromium.org
Review URL: https://codereview.chromium.org/1412283006
Cr-Commit-Position: refs/heads/master@{#357867}
|
|
|
|
|
|
|
|
|
|
| |
This CL maps an ONC property for disabling network technologies.
BUG=426390
Review URL: https://codereview.chromium.org/1306813008
Cr-Commit-Position: refs/heads/master@{#347638}
|
|
|
|
|
|
|
|
|
|
|
| |
This will simplify some of the new Settings UI, allowing us
to read onc.Type directly without parsing a managed dictionary.
BUG=none
Review URL: https://codereview.chromium.org/1284963002
Cr-Commit-Position: refs/heads/master@{#343146}
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds translation of the ProxySettings property in an ONC dictionary to the ProxyConfig property of a Shill dictionary (which previously was not being handled).
BUG=470445
TBR=abarth@chromium.org for DEPS change (+url)
Review URL: https://codereview.chromium.org/1228543002
Cr-Commit-Position: refs/heads/master@{#338352}
|
|
|
|
|
|
|
|
|
| |
BUG=475699
TEST=None
Review URL: https://codereview.chromium.org/1085703002
Cr-Commit-Position: refs/heads/master@{#326738}
|
|
|
|
|
|
|
|
|
|
|
| |
This CL maps an ONC property for setting per-network roam threshold.
BUG=chrome-os-partner:38681
TEST=Expanded test ONC and JSON test sets
Review URL: https://codereview.chromium.org/1087353002
Cr-Commit-Position: refs/heads/master@{#325515}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This uses the recent networkingPrivate changes to support setting
Cellular.Carrier in setProperties and adding startActivate in
internet_details.js.
BUG=430115
Review URL: https://codereview.chromium.org/1046593003
Cr-Commit-Position: refs/heads/master@{#324490}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL maps an ONC property for disabling L2TP connection
monitoring via PPP LCP frames.
BUG=463602
TEST=Expanded test ONC and JSON test sets
Review URL: https://codereview.chromium.org/1058973002
Cr-Commit-Position: refs/heads/master@{#323943}
|
|
|
|
|
|
|
|
|
|
| |
This also adds the network technology 1x badge to cr_network_icon
BUG=470282
Review URL: https://codereview.chromium.org/1033843003
Cr-Commit-Position: refs/heads/master@{#322409}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL maps the third-party VPN provider extension ID (which is
stored in shill's |Provider.Host| field) to an ONC property.
BUG=460428
TEST=Extended unit tests and API test
Review URL: https://codereview.chromium.org/1019033002
Cr-Commit-Position: refs/heads/master@{#321238}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently type WiMAX fails ONC validation so any property
changes from Settings are ignored.
This also fixes the Cellular translation and adds both Cellular and WiMAX to the validation tests.
BUG=460829
Review URL: https://codereview.chromium.org/949783003
Cr-Commit-Position: refs/heads/master@{#318162}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Comparison of a network policy with network will use HexSSID now.
- Translation from ONC to Shill now copies the HexSSID instead of translating SSID.
- Fix ONC validation of HexSSID/SSID to be case insensitive.
- When setting an ONC: SSID will be ignored if HexSSID is present
- Reading network properties reports a HexSSID in ONC.
BUG=432546
Review URL: https://codereview.chromium.org/823633004
Cr-Commit-Position: refs/heads/master@{#311281}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adopt shill's kSecurityClassProperty, in place of shill's
kSecurityProperty. This eliminates the need for Chrome to understand
the equivalence of WPA and RSN networks.
This CL introduces only one functional change. Namely,
NetworkState::GetSpecifier will now collapse WPA and RSN networks into
one class (by virtue of using kSecurityClassProperty). The previous
behavior is considered a bug.
After this CL, only WifiAccessPointInfoProviderChromeOs still uses
kSecurityProperty. In that one case, we want to break out WPA and RSN
networks, to understand what fraction of systems are connecting
through older APs.
While there: remove a couple of unused files in chromeos/test/data/network/policy/.
BUG=chromium:440032
TEST=ManagedNetworkConfigurationHandlerTest.*
TEST=ONC*
Review URL: https://codereview.chromium.org/788633003
Cr-Commit-Position: refs/heads/master@{#310840}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL introdcues IPAddressConfigType and NameServersConfigType
If either of these is set to 'Static', a 'StaticIPConfig' object must
be provided and must specify any non-default configuration. If neither
is set to 'Static', the StaticIPConfig object will be ignored.
Originally uploaded as https://codereview.chromium.org/750313003/
BUG=411289
Review URL: https://codereview.chromium.org/749013003
Cr-Commit-Position: refs/heads/master@{#310325}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ONC currently uses strings to represent SSIDs. Since JSON-Schema strings are restricted to Unicode and ONC is encoding these as UTF-8, this means that ONC cannot be used to represent SSIDs that include non-UTF-8 strings.
This change adds a separate HexSSID field to the WiFi section of the ONC that expects an SSID byte sequence encoded in hex.
At least one of the fields HexSSID or SSID must be present. If both HexSSID and SSID are set, the values must be consistent.
BUG=432546
Review URL: https://codereview.chromium.org/759663004
Cr-Commit-Position: refs/heads/master@{#306838}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before a recent Shill change, Static and Saved IP config properties were stored in toplevel properties with prefixed keys like kStaticIPAddressProperty.
This change makes use of Shill now exposing these properties nested under a StaticIPConfig and SavedIPConfig dictionary.
This also makes the translation between a list of nameservers and a comma-separated string obsolete.
Original Review URL: https://codereview.chromium.org/762243002
BUG=411289
TBR=pneubeck@chromium.org
Review URL: https://codereview.chromium.org/778693004
Cr-Commit-Position: refs/heads/master@{#306669}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/762243002/)
Reason for revert:
Breaks the build: http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/7051
Original issue's description:
> Change to Shill's IPConfig objects.
>
> Before a recent Shill change, Static and Saved IP config properties were stored in toplevel properties with prefixed keys like kStaticIPAddressProperty.
> This change makes use of Shill now exposing these properties nested under a StaticIPConfig and SavedIPConfig dictionary.
>
> This also makes the translation between a list of nameservers and a comma-separated string obsolete.
>
> BUG=411289
>
> Committed: https://crrev.com/ac2d359b101e4c97455125958db4a999bf26135f
> Cr-Commit-Position: refs/heads/master@{#306400}
TBR=stevenjb@chromium.org,pneubeck@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=411289
Review URL: https://codereview.chromium.org/776603002
Cr-Commit-Position: refs/heads/master@{#306412}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before a recent Shill change, Static and Saved IP config properties were stored in toplevel properties with prefixed keys like kStaticIPAddressProperty.
This change makes use of Shill now exposing these properties nested under a StaticIPConfig and SavedIPConfig dictionary.
This also makes the translation between a list of nameservers and a comma-separated string obsolete.
BUG=411289
Review URL: https://codereview.chromium.org/762243002
Cr-Commit-Position: refs/heads/master@{#306400}
|
|
|
|
|
|
|
|
|
|
| |
Also document more clearly that a wrong type of 'Recommended' doesn't cause an error or crash.
BUG=430113
Review URL: https://codereview.chromium.org/723153002
Cr-Commit-Position: refs/heads/master@{#304128}
|
|
|
|
|
|
|
|
|
|
| |
This allows autoconnect to policy pushed networks without the user having to manually trigger a successful connect once.
BUG=424036
Review URL: https://codereview.chromium.org/647783005
Cr-Commit-Position: refs/heads/master@{#302433}
|
|
|
|
|
|
|
|
|
|
|
| |
Before, it was hard or impossible to track whether a policy application is currently running.
Now a notification (PoliciesApplied) and the current status (AnyPolicyApplicationRunning) are exposed.
BUG=425049
Review URL: https://codereview.chromium.org/661803005
Cr-Commit-Position: refs/heads/master@{#301817}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reland of https://codereview.chromium.org/560863002/ which the CQ failed to commit correctly.
This does not adapt the UI to respect the policy's UserAuthenticationType, yet.
BUG=347916
TBR=stevenjb@chromium.org
TEST=Ensured that a previously working policy pushed OpenVPN network still works.
Review URL: https://codereview.chromium.org/632223002
Cr-Commit-Position: refs/heads/master@{#298431}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a follow up CL for 414417 that includes the ONC translation
necessary for the Wimax UI and fixes the JS to use the new WiMAX
capitalization. It also adds a WiMAX entry to the HTML doc.
BUG=414417
Review URL: https://codereview.chromium.org/581213003
Cr-Commit-Position: refs/heads/master@{#295774}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds the object "WiMAX" to ONC, which contains the basic properties
AutoConnect (read/write)
EAP (write-only)
SignalStrength (read-only).
Also all general network properties like Name or ConnectionState are supported.
BUG=414417
Review URL: https://codereview.chromium.org/578823003
Cr-Commit-Position: refs/heads/master@{#295467}
|
|
|
|
|
|
|
|
|
|
| |
Also, cleanup internet_options_handler.cc 'showViewAccountButton' code.
BUG=279351
Review URL: https://codereview.chromium.org/561073002
Cr-Commit-Position: refs/heads/master@{#294951}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Fixed AutoConnect, which is stored in each network type's subdictionary.
- Added a Cellular.AutoConnect property to ONC.
- Fixed VPN username for L2TP-IPsec, which is stored in 'L2TP'.
- Removed reading Wimax properties from ONC, as these are not yet supported.
BUG=412807
Review URL: https://codereview.chromium.org/571123002
Cr-Commit-Position: refs/heads/master@{#294897}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also includes a bit of JS cleanup to use ONC properties directly
where possible.
BUG=279351
R=pneubeck@chromium.org
Review URL: https://codereview.chromium.org/552113002
Cr-Commit-Position: refs/heads/master@{#294462}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before read-only properties which cannot be set by the user or policy, were explicitly marked as 'unmanaged' in the augmented dictionary returned by getManagedProperties.
Now, instead these properties are returned as plain values, which simplifies the consumer side, especially of Array typed properties like IPConfigs (compare this with SavedIPConfig).
BUG=410877
Review URL: https://codereview.chromium.org/551753002
Cr-Commit-Position: refs/heads/master@{#293931}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before commit 41ec57e48ebd467c7a3b169a5598fb8038f54232,
IPConfigs was the field in ONC meant for configuring ip configuration of a network.
This was changed to:
- IPConfigs is the set of currently active ip configurations (it can be more than one if IPv4 and IPv6 are coexisting in parallel) reported by ChromeOS
- StaticIPConfig (note that it's a single configuration, not multiple as before) is the writable field that the user or policy can set
- SavedIPConfig is the configuration received via DHCP and reported by ChromeOS.
This change updates the different ONC functions to these new field definitions.
Effectively this also allows setting the IPConfig of a network through ONC import, the networkingPrivate API, and through policy (there's no server support though).
BUG=410877
Review URL: https://codereview.chromium.org/540333002
Cr-Commit-Position: refs/heads/master@{#293915}
|
|
|
|
|
|
|
|
| |
BUG=279351
Review URL: https://codereview.chromium.org/535283002
Cr-Commit-Position: refs/heads/master@{#293621}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of providing a 'Translated' value in managed ONC dictionaries,
use a well understood naming convention.
This also moves the onc helper methods to their own JS module.
BUG=279351
For proxy_settings.html:
TBR=xiyuan@chromium.org
Review URL: https://codereview.chromium.org/539573002
Cr-Commit-Position: refs/heads/master@{#293412}
|
|
|
|
|
|
|
|
| |
BUG=279351
Review URL: https://codereview.chromium.org/540613002
Cr-Commit-Position: refs/heads/master@{#293331}
|
|
|
|
|
|
|
|
| |
BUG=279351
Review URL: https://codereview.chromium.org/510123004
Cr-Commit-Position: refs/heads/master@{#293091}
|
|
|
|
|
|
|
|
|
|
| |
BUG=279351
For chrome/browser/ui/webui/chromeos/network_config_message_handler.cc:
TBR=xiyuan@chromium.org
Review URL: https://codereview.chromium.org/492383002
Cr-Commit-Position: refs/heads/master@{#292245}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This includes some necessary ONC translation fixes.
BUG=279351
R=armansito@chromium.org, pneubeck@chromium.org
Review URL: https://codereview.chromium.org/482243002
Cr-Commit-Position: refs/heads/master@{#291085}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enables OTA activation using the old Wifi flow except it connects to the cellular network instead of requiring a Wifi connection.
BUG=chromium:384185
TEST=Unit tests, manually activate SIM on CDMA and LTE
Review URL: https://codereview.chromium.org/406473002
Cr-Commit-Position: refs/heads/master@{#288854}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes how we translate the Device properties to ONC instead of
just copying the Shill properties.
BUG=279351
Review URL: https://codereview.chromium.org/402953004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
As client certificate information is now retrieved from policy, most of NetworkUIData can be removed except ONCSource to indicate whether a network was managed after the policy got removed.
BUG=391292
R=stevenjb@chromium.org
Review URL: https://codereview.chromium.org/370623002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The ONC validator threw an error if both the Certificates or NetworkConfigurations sections were missing in an ONC policy.
Now, we ignore that fact because we have to expect policies that only contain the new GlobalNetworkConfiguration section.
BUG=386182
Review URL: https://codereview.chromium.org/350443004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The policy application code didn't respect the fact that VPN properties are written differently than being read.
BUG=365392
Review URL: https://codereview.chromium.org/319693002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The GUID property is used to pick user settings, policies and active settings for the same network. Thus it's more an identifier than a property and should not be exposed with additional meta information as it is the case for other properties.
BUG=372337
Review URL: https://codereview.chromium.org/291553006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=374003
Review URL: https://codereview.chromium.org/291553002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On browser startup, in particular after each logout, device network policy is reapplied.
If the network is still connected it could have happened that Shill reports the actual Security type (distinguishing WPA1 vs. WPA2) that deviates from what the policy configures (ONC doesn't distinguish WPA1/WPA2).
This commit fixes this issue by normalizing the Security type during network identification in the same way as Shill does.
BUG=241006
Review URL: https://codereview.chromium.org/280793003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
So far, the ONC IPConfig object was only validated but not translated to or from Shill.
This adds the one direction, from Shill to ONC.
This allows exposing the current IP config state of Shill through ONC, e.g. with in the networkingPrivate API.
BUG=288288
Review URL: https://codereview.chromium.org/249193003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The patch identifies network configurations and certificates with duplicate GUIDs and repairs the ONC such that the first occurrence is retained as a unique network configuration or certificate.
BUG=211421
Review URL: https://codereview.chromium.org/166903002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add Xauth L2TP credentials to the ONC configuration language.
BUG=267647
R=pneubeck@chromium.org
Review URL: https://codereview.chromium.org/141583002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
So far only a single CA certificate was supported for EAP/IPsec/OpenVPN. Instead, we now support multiple CA certs. These are provided as a list of GUID references to CA certificates in the toplevel "Certificates" section.
BUG=276291
R=armansito@chromium.org, davidroche@chromium.org
Review URL: https://codereview.chromium.org/68343010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Looking at IpsecManager::Initialize in platform/vpn-manager/ipsec_manager.cc, then a CA certificate for server verification is rejected if a PSK is set.
However, in ONC, the ServerCARef was silently ignored if PSK was used. This might unintentionally reduce security.
Note: ServerCARef from ONC maps to server_ca_file in IpsecManager::Initialize.
PSK from ONC maps to psk_file in IpsecManager::Initialize.
BUG=276291
R=bartfab@chromium.org
Review URL: https://codereview.chromium.org/62173002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Support the --verify-hash and --verify-x509-name options of OpenVPN via ONC.
Note that the ONC validator restricts the possible types passable to --verify-x509-name to "name", "name-prefix" and "subject". See also https://community.openvpn.net/openvpn/wiki/Openvpn23ManPage .
BUG=276291
R=armansito@chromium.org, bartfab@chromium.org, pstew@chromium.org
Review URL: https://codereview.chromium.org/61903002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234495 0039d316-1c4b-4281-b951-d872f2087c98
|