summaryrefslogtreecommitdiffstats
path: root/components/history
Commit message (Collapse)AuthorAgeFilesLines
* components: Add out-of-line copy ctors for complex classes.vmpstr2016-02-256-0/+29
| | | | | | | | | | | | | | This patch adds out of line copy constructors for classes that our clang-plugin considers heavy. This is an effort to enable copy constructor checks by default. BUG=436357 R=jochen@chromium.org, dcheng@chromium.org, thakis@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1728033002 Cr-Commit-Position: refs/heads/master@{#377717}
* net: move IsLocalhost() function into url_util.htfarina2016-02-231-1/+1
| | | | | | | | | | | | | | This patch moves the last function in net_util.h into url_util.h. We are moving it there because it also operates on a URL part (host). BUG=488531 TEST=net_unittests --gtest_filter=UrlUtilTest.IsLocalhost R=eroman@chromium.org TBR=darin@chromium.org Review URL: https://codereview.chromium.org/1726693002 Cr-Commit-Position: refs/heads/master@{#377115}
* [Downloads] Do not store error responses during resumption.asanka2016-02-201-25/+26
| | | | | | | | | | | | | | | | | | | | | | | If a server or an intermediary sends a redirect, error, or other unexpected response during resumption, don't store it or discard the partial download state. Instead the download item will flag itself as interrupted again and will require an externally initiated Resume() call to try again. Such responses are common where captive portals or other middle boxes are present. If such cases aren't explicitly handled, an untimely resumption attempt could discard partial state. As a side-effect of this patch, downloads will also not discard partial state due to other server errors during resumption (e.g. 500). BUG=7648 R=svaldez@chromium.org, davidben@chromium.org, rdevlin.cronin@chromium.org TBR=sky@chromium.org Review URL: https://codereview.chromium.org/1544603003 Cr-Commit-Position: refs/heads/master@{#376625}
* Remove some dead code: HistoryService/Backend::QueryFilteredURLstreib2016-02-1911-1165/+0
| | | | | | | | | | It looks like this was used in some previous iteration of the New Tab page, but it's unused now. BUG=none Review URL: https://codereview.chromium.org/1717613002 Cr-Commit-Position: refs/heads/master@{#376458}
* Remove Profile dependency from some ProfileSyncService unittestsvabr2016-02-191-1/+1
| | | | | | | | | | More precisely, this removes the //chrome dependencies from TestProfileSyncService, AbstractProfileSyncServiceTest, ProfileSyncServiceTypedUrlTest and ProfileSyncServiceAutofillTest. BUG=581640 Review URL: https://codereview.chromium.org/1646553002 Cr-Commit-Position: refs/heads/master@{#376446}
* Revert of Release unused web views when under memory pressure. (patchset #5 ↵markusheintz2016-02-191-7/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:100001 of https://codereview.chromium.org/1708643002/ ) Reason for revert: TypedUrlSyncableServiceTest.DeleteUrlAndVisits fails on Win and CROS ASAN: Win: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/46063/steps/components_unittests/logs/TypedUrlSyncableServiceTest.DeleteUrlAndVisits https://build.chromium.org/p/chromium.win/buildstatus?builder=Win7%20Tests%20%28dbg%29%281%29&number=46064 https://build.chromium.org/p/chromium.win/buildstatus?builder=Win7%20Tests%20%28dbg%29%281%29&number=46063 CROS ASAN: https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/9861/steps/components_unittests/logs/TypedUrlSyncableServiceTest.DeleteUrlAndVisits https://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29&number=9861 Original issue's description: > Release unused web views when under memory pressure. > > AccountConsistencyService and GaiaAuthFetcherIOS both use web views > internally to manipulate cookies. Once allocated, those web views were > never released to avoid having to re-allocate them later (which is > expensive). > > Those web views are now released when they are unused and the app is > under memory pressure. > > BUG=587487 > > Committed: https://crrev.com/8a730bd4d690e5c9f9b3639cbedec5b5dc2bbe12 > Cr-Commit-Position: refs/heads/master@{#376431} TBR=msarda@chromium.org,zea@chromium.org,bzanotti@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=587487 Review URL: https://codereview.chromium.org/1713973003 Cr-Commit-Position: refs/heads/master@{#376445}
* Release unused web views when under memory pressure.bzanotti2016-02-191-0/+7
| | | | | | | | | | | | | | | | AccountConsistencyService and GaiaAuthFetcherIOS both use web views internally to manipulate cookies. Once allocated, those web views were never released to avoid having to re-allocate them later (which is expensive). Those web views are now released when they are unused and the app is under memory pressure. BUG=587487 Review URL: https://codereview.chromium.org/1708643002 Cr-Commit-Position: refs/heads/master@{#376431}
* Convert C++ files to Objective-C++ files to remove hack.sdefresne2016-02-162-1/+1
| | | | | | | | | | | | | | In order to remove hack using __OBJC__ to forward-declare an Objective-C class as a C++ class when the file is included from a C++ file, instead convert the clients to be Objective-C++ files. This fixes all clients of ios/web/public/navigation_item.h. BUG=298181 Review URL: https://codereview.chromium.org/1704443002 Cr-Commit-Position: refs/heads/master@{#375587}
* [sql] Remove misleading AutoRecoverTable() parameter.shess2016-02-042-6/+5
| | | | | | | | | | | | | | | | | |extend_columns| was intended to be used in the case where the target schema differed slightly from the schema of the table being recovered. Unfortunately, it actually implemented part of the solution for when the target has fewer columns and described it as the solution for when the target has more columns. Remove the unnecessary code and parameter. [In general, table schema only add new columns, removing is more infrequent.] BUG=none Review URL: https://codereview.chromium.org/1666473003 Cr-Commit-Position: refs/heads/master@{#373586}
* Componentize WebHistoryService unittestblundell2016-02-042-0/+395
| | | | | | | | | | This CL cleans the WebHistoryService unittest of //chrome and //content dependencies and moves it to live next to the production code that it is testing. Review URL: https://codereview.chromium.org/1667043002 Cr-Commit-Position: refs/heads/master@{#373488}
* Delete base/prefs and update callers to use components.brettw2016-02-037-10/+11
| | | | | | | | | | | | | | | | | | | | | | | Deletes the forwarding headers in base/prefs. Updates the remaining users of base/prefs includes to use components/prefs. Sort headers in updated files. Move PrefServiceFactory out of the base namespace. Update users. Update all preprocessor stuff in components/prefs to change BASE_PREFS_ to COMPONENTS_PREFS_. Add components/prefs to DEPS file of directories where checkdeps fails after the update. BUG=583034 Reland of http://crrev.com/1662523004#ps40001 with fix. TBR=estade@chromium.org Review URL: https://codereview.chromium.org/1668463002 Cr-Commit-Position: refs/heads/master@{#373197}
* Revert of Delete base/prefs and update callers to use components. (patchset ↵msw2016-02-037-11/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | #3 id:40001 of https://codereview.chromium.org/1662523004/ ) Reason for revert: Broke Win Builder compile: https://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/19463/steps/compile/logs/stdio Original issue's description: > Delete base/prefs and update callers to use components. > > Deletes the forwarding headers in base/prefs. > > Updates the remaining users of base/prefs includes to use components/prefs. > Sort headers in updated files. > > Move PrefServiceFactory out of the base namespace. Update users. > > Update all preprocessor stuff in components/prefs to change BASE_PREFS_ to > COMPONENTS_PREFS_. > > Add components/prefs to DEPS file of directories where checkdeps fails after > the update. > > BUG=583034 > > Committed: https://crrev.com/1f5feb7e317e3c257090858e950273b64a2e31ef > Cr-Commit-Position: refs/heads/master@{#373105} TBR=estade@chromium.org,brettw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=583034 Review URL: https://codereview.chromium.org/1662843002 Cr-Commit-Position: refs/heads/master@{#373115}
* Delete base/prefs and update callers to use components.brettw2016-02-037-10/+11
| | | | | | | | | | | | | | | | | | | | | Deletes the forwarding headers in base/prefs. Updates the remaining users of base/prefs includes to use components/prefs. Sort headers in updated files. Move PrefServiceFactory out of the base namespace. Update users. Update all preprocessor stuff in components/prefs to change BASE_PREFS_ to COMPONENTS_PREFS_. Add components/prefs to DEPS file of directories where checkdeps fails after the update. BUG=583034 Review URL: https://codereview.chromium.org/1662523004 Cr-Commit-Position: refs/heads/master@{#373105}
* TypedUrlSyncableService has a in memory synced URLs cachegangwu2016-02-012-1/+27
| | | | | | | | | | | synced_typed_urls_ to remember which URLs were synced, but did not update it when receive update from server. BUG=570296 Review URL: https://codereview.chromium.org/1650893002 Cr-Commit-Position: refs/heads/master@{#372771}
* Moves shared history test helpers into util classes.rohitrao2016-02-014-1/+118
| | | | | | | | BUG=None Review URL: https://codereview.chromium.org/1646893003 Cr-Commit-Position: refs/heads/master@{#372681}
* Update GN build files for new prefs location.brettw2016-01-301-2/+2
| | | | | | | | | | Updates references from //base:prefs to //components/prefs/ TBR=jam@chromium.org Review URL: https://codereview.chromium.org/1652573002 Cr-Commit-Position: refs/heads/master@{#372540}
* Sync DB entry deleted twice.gangwu2016-01-225-10/+35
| | | | | | | | | | | | | | | The problem is, when sync receive a update from server, it will delete the entry, and then call history backend to delete entry from history DB, and then history backend will notify sync DB to delete the entry, so crash here. So the fix is removing observer temporarily when Sync DB send update to history DB. BUG=577903 Review URL: https://codereview.chromium.org/1589333003 Cr-Commit-Position: refs/heads/master@{#370864}
* Use a max update interval of 5 minutes on mobile to reduce battery usage.sdefresne2016-01-192-3/+3
| | | | | | | | BUG=575709,576510 Review URL: https://codereview.chromium.org/1582263006 Cr-Commit-Position: refs/heads/master@{#370154}
* Use the same interval to save TopSites database on mobile.sdefresne2016-01-112-17/+17
| | | | | | | | | | | | | It is unlikely that the app is running uninterrupted for a full hour on Android, so use the same logic as iOS and save the TopSites db every minute instead. The goal is better reflect user navigation on the NTP. BUG=575709 Review URL: https://codereview.chromium.org/1571593003 Cr-Commit-Position: refs/heads/master@{#368603}
* Restrict GetRedirectToVisit to just redirects.nparker2016-01-051-1/+3
| | | | | | | | | | | This avoids the 10K+ "redirect chain" messages sent to Safe Browsing. BUG=566140 Review URL: https://codereview.chromium.org/1537173002 Cr-Commit-Position: refs/heads/master@{#367447}
* Prepare for -Wall for third-party code, -Wextra for chromium_codethakis2015-12-311-1/+1
| | | | | | | | | | | | | | | | This lands patch set 16 of https://codereview.chromium.org/1551753002/ (reviewed there), except for the changes to build/common.gypi and build/config/compiler/BUILD.gn. The changes to these two files are likely to break some bot I don't know about, and I don't want to keep reverting and relanding all these files. So this lands the parts that are hopefully harmless separately. BUG=573250 TBR=thestig Review URL: https://codereview.chromium.org/1557733002 Cr-Commit-Position: refs/heads/master@{#367252}
* Convert Pass()→std::move() in //components/[a-m]*dcheng2015-12-2612-39/+49
| | | | | | | | | | BUG=557422 R=avi@chromium.org TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/1548193002 Cr-Commit-Position: refs/heads/master@{#366906}
* Switch to standard integer types in components/, part 2 of 4.avi2015-12-2691-170/+325
| | | | | | | | | BUG=138542 TBR=blundell@chromium.org Review URL: https://codereview.chromium.org/1548113002 Cr-Commit-Position: refs/heads/master@{#366877}
* Move FakeWebHistoryService to components/historymsramek2015-12-183-0/+248
| | | | | | | | | | | | | | 1. split to declaration and definition to .cc and .h 2. since we moved to components/, the constructor can no longer derive the needed keyed services from Profile; instead, the caller must do so and pass them to FakeWebHistoryService constructor; the constructor signature now maches that of WebHistoryService 3. added support for the "num" query parameter, i.e. the limit of returned entries TBD: Add tests BUG=553421 Review URL: https://codereview.chromium.org/1454413002 Cr-Commit-Position: refs/heads/master@{#366071}
* Using TypedUrlSyncableService instead ofgangwu2015-12-1513-2120/+90
| | | | | | | | | | | | | | TypedUrlModelAssociator and TypedUrlChangeProcessor. And also fix some test issues because of this changes. BUG=77819,543722 Committed: https://crrev.com/0295776af08f6f03850492a70b60d52855a112dd Cr-Commit-Position: refs/heads/master@{#365199} Review URL: https://codereview.chromium.org/1454503002 Cr-Commit-Position: refs/heads/master@{#365368}
* Revert of [Sync] Use TypedUrlSyncableService instead of ModelAssociator ↵henrika2015-12-1513-90/+2120
| | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #9 id:440001 of https://codereview.chromium.org/1454503002/ ) Reason for revert: Speculative revert suspecting that it causes https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/43996 Original issue's description: > Using TypedUrlSyncableService instead of > TypedUrlModelAssociator and TypedUrlChangeProcessor. > And also fix some test issues because of this changes. > > BUG=77819,543722 > > Committed: https://crrev.com/0295776af08f6f03850492a70b60d52855a112dd > Cr-Commit-Position: refs/heads/master@{#365199} TBR=sdefresne@chromium.org,zea@chromium.org,gangwu@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=77819,543722 Review URL: https://codereview.chromium.org/1524093002 Cr-Commit-Position: refs/heads/master@{#365216}
* Using TypedUrlSyncableService instead ofgangwu2015-12-1513-2120/+90
| | | | | | | | | | | TypedUrlModelAssociator and TypedUrlChangeProcessor. And also fix some test issues because of this changes. BUG=77819,543722 Review URL: https://codereview.chromium.org/1454503002 Cr-Commit-Position: refs/heads/master@{#365199}
* Make TopHosts take a size_t, avoiding a saturated_cast.vmpstr2015-12-126-9/+9
| | | | | | | | | | | This patch cleans up usage in TopHosts by removing a saturated cast, and making the function argument be a size_t. R=sky@chromium.org, bengr@chromium.org Review URL: https://codereview.chromium.org/1510903006 Cr-Commit-Position: refs/heads/master@{#364851}
* Use ScopedTempDir to create test folder instead ofgangwu2015-11-251-5/+6
| | | | | | | | | | "TypedUrlSyncableServiceTest". BUG=561083 Review URL: https://codereview.chromium.org/1475823002 Cr-Commit-Position: refs/heads/master@{#361687}
* Cleanup: Correctly spell success(ful).thestig2015-11-231-1/+1
| | | | | | | | | TBR=brettw@chromium.org NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1469783002 Cr-Commit-Position: refs/heads/master@{#361166}
* Add gn implementation for //components/history/ios/browser.sdefresne2015-11-171-0/+19
| | | | | | | | BUG=459705 Review URL: https://codereview.chromium.org/1437683008 Cr-Commit-Position: refs/heads/master@{#360063}
* Use concrete types instead of auto in history_backend_unittest.cccalamity2015-11-161-10/+10
| | | | | | | | | | | This is a cleanup CL which replaces auto in history_backend_unittest.cc with the actual types for clarity. BUG=None Review URL: https://codereview.chromium.org/1446113002 Cr-Commit-Position: refs/heads/master@{#359816}
* Implement a finer grained deletion for Site Engagement data on History deletion.calamity2015-11-166-1/+82
| | | | | | | | | | | | | | This CL makes the Site Engagement data deletion query the HistoryService to see if History has any other URLs that fall beneath the origin. This means that data will only get deleted if all URLs beneath the origin are deleted rather than the original behavior of deleting origin data every time any URL beneath it is deleted. BUG=553728 Review URL: https://codereview.chromium.org/1423253003 Cr-Commit-Position: refs/heads/master@{#359795}
* Revert of Delay history db preload as a LightSpeed experiment. (patchset #13 ↵gab2015-11-095-70/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | id:520001 of https://codereview.chromium.org/1255913002/ ) Reason for revert: Experiment is over, gains weren't big enough to justify this feature as-is. I/O on startup as a whole is being investigated as part of a bigger effort tracked by issue 553459. Original issue's description: > Delay history db preload as a LightSpeed experiment. > > This is a LightSpeed experiment that delays history db preload by queuing all > tasks posted in history_service to a DeferredSequencedTaskRunner for users in > the experiment group. The task runner is started after startup is complete. > > BUG=515132 > > Committed: https://crrev.com/5f35aff10c3c3d24a34fde11547ba72fe6ae54b2 > Cr-Commit-Position: refs/heads/master@{#342430} TBR=sky@chromium.org,pkasting@chromium.org,brettw@chromium.org,tiany@google.com BUG=515132 Review URL: https://codereview.chromium.org/1420203010 Cr-Commit-Position: refs/heads/master@{#358676}
* Optimized getting of all visits during typed url association.aseren2015-11-062-2/+8
| | | | | | | | | | | | Previous implementation had O^N2 complexity. Changes are tested at tests: - ProfileSyncServiceTypedUrlTest.IgnoreLocalhostURL - ProfileSyncServiceTypedUrlTest.IgnoreLocalFileURL R=sdefresne@chromium.org Review URL: https://codereview.chromium.org/1410973009 Cr-Commit-Position: refs/heads/master@{#358301}
* Apply following CLs which are applied for recent 2 years togangwu2015-11-024-66/+254
| | | | | | | | | | | | | | | | | | | | | | | typed_url_change_processor.cc. And also port unittests from typed_url_model_associator_unittest.cc. https://codereview.chromium.org/1087773002 https://codereview.chromium.org/631253002 https://codereview.chromium.org/1126633005 https://codereview.chromium.org/1156583006 https://codereview.chromium.org/300843004 https://codereview.chromium.org/1304423002 https://codereview.chromium.org/1127353004 https://codereview.chromium.org/773103004 https://codereview.chromium.org/1231723004 https://chromiumcodereview.appspot.com/16770005 https://chromiumcodereview.appspot.com/694843002/ BUG=77819 Review URL: https://codereview.chromium.org/1410243006 Cr-Commit-Position: refs/heads/master@{#357386}
* Removing and updating TODO for TODO fix-it.sdefresne2015-10-261-9/+0
| | | | | | | | | | | Use the new format TODO(crbug.com/#) for TODO that are still valid while removing the one that are obsolete or can now be fixed. BUG=525079,520070,513344 Review URL: https://codereview.chromium.org/1420843002 Cr-Commit-Position: refs/heads/master@{#356045}
* [sync] Componentize TypedUrl{ChangeProcessor, DataTypeController}blundell2015-10-265-0/+710
| | | | | | | | | | | The componentization follows in the same vein as previous datatype controller componentizations, passing in the needed dependencies in constructors. BUG=512546,512451 Review URL: https://codereview.chromium.org/1413913003 Cr-Commit-Position: refs/heads/master@{#356036}
* [sync] Componentize TypedUrlModelAssociator unittestblundell2015-10-262-0/+434
| | | | | | | | | | | content::TestBrowserThreadBundle dependency is removed by manually spinning up a base::Thread instance instead. BUG=544975 Review URL: https://codereview.chromium.org/1416623002 Cr-Commit-Position: refs/heads/master@{#356020}
* [Sync] Componentize HistoryDeleteDirectivesDataTypeController.maxbogue2015-10-243-0/+116
| | | | | | | | BUG=512038 Review URL: https://codereview.chromium.org/1402003003 Cr-Commit-Position: refs/heads/master@{#355938}
* [Sync] Remove history and favicon deps from sync_driver.maxbogue2015-10-226-0/+1265
| | | | | | | | | | All datatype specific code is being moved out of sync_driver. BUG=543199, 512038 Review URL: https://codereview.chromium.org/1402153003 Cr-Commit-Position: refs/heads/master@{#355672}
* [sql] Track uploads of diagnostic data to prevent duplication.shess2015-10-221-162/+16
| | | | | | | | | | | | | | | | | | The ThumbnailDatabase error handler attempts to capture generic data about the error, which is then uploaded for diagnostics with DumpWithoutCrashing(). Database with errors which are not repaired upload new dumps repeatedly. This change adds a tracking file alongside the database file, which has the dual purpose of recording whether a previous dump was attempted, and also verifying that files can be created in the profile directory. If the profile directory is too broken to create files, then diagnostic data is unlikely to inform a fix. BUG=543321,362505,526614,240396 Review URL: https://codereview.chromium.org/1393393007 Cr-Commit-Position: refs/heads/master@{#355632}
* Implement ProcessSyncChanges function.gangwu2015-10-214-167/+590
| | | | | | | | | | | | This implements the equivalent of ApplyChangesFromSyncModel in the TypedUrlChangeProcessor. The equivalent unit tests (and more!) have been added as well. BUG=77819 Review URL: https://codereview.chromium.org/1399593002 Cr-Commit-Position: refs/heads/master@{#355360}
* Fix the incorrectly named time points in VisitDatabaseTest.GetHistoryCount.msramek2015-10-151-11/+14
| | | | | | | | | | Previously, |yesterday| corresponded to two days ago, and |two_days_ago| corresponded to four days ago. This didn't matter for the correctness of the test, but should be fixed for consistency. BUG=510028 Review URL: https://codereview.chromium.org/1389923004 Cr-Commit-Position: refs/heads/master@{#354242}
* Don't use base::MessageLoop::{Quit,QuitClosure} in components/ki.stfu2015-10-134-12/+17
| | | | | | | | | | | | This patch renames base::MessageLoop::{Quit,QuitClosure} to base::MessageLoop::{QuitWhenIdle,QuitWhenIdleClosure}. BUG=131220 R=blundell@chromium.org Review URL: https://codereview.chromium.org/1402553002 Cr-Commit-Position: refs/heads/master@{#353726}
* [Sync] Don't dcheck for history delete directives with weird timeszea2015-10-012-7/+2
| | | | | | | | | | | | | | | History delete directives originate on other, possibly older clients that may have skewed clocks or bugs that have since been fixed. The receiving client should gracefully handle (and validate) the data. In this case, the times are used to identify URLs to delete within the range. If one is found, we should still delete it. If none is found, ignore it. BUG=357224 Review URL: https://codereview.chromium.org/1377593004 Cr-Commit-Position: refs/heads/master@{#351834}
* Enable history counting for time ranges.msramek2015-09-297-23/+212
| | | | | | | | | | GetHistoryCount() previously counted all of browsing history. This can be now achieved by calling GetHistoryCount(base::Time(), base::Time::Max()). However, it's also possible to specify a narrower time interval. BUG=510028 Review URL: https://codereview.chromium.org/1370493002 Cr-Commit-Position: refs/heads/master@{#351298}
* Cleanup: IWYU for base/gtest_prod_util.h.thestig2015-09-251-1/+0
| | | | | | | | | | CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=pneubeck@chromium.org Review URL: https://codereview.chromium.org/1366123002 Cr-Commit-Position: refs/heads/master@{#350770}
* Use the appropriate variant of IntToString in //componentsricea2015-09-241-1/+1
| | | | | | | | | | | | | | | Using the wrong variant of IntToString() can lead to unexpected behaviour and bugs. Use the appropriate variant for the type being converted. No behaviour change intended. BUG=505479 TEST=compiled Review URL: https://codereview.chromium.org/1354253002 Cr-Commit-Position: refs/heads/master@{#350545}
* base: Template methods on Timer classes instead of the classes themselves.danakj2015-09-241-1/+1
| | | | | | | | | | | | | | | | | | | The base class for OneShotTimer and DelayedTimer is templated but only the Start method needs to be (which has a TODO to make it go away entirely too). The DelayedTimer class is also templated but only its constructor needs to be, and the type can be inferred at the callsite, so less typing all around. R=thakis@chromium.org TBR=sky,brettw BUG=148832 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1355063004 Cr-Commit-Position: refs/heads/master@{#350496}
generated by cgit v1.1 at 2025-02-15 07:26:43 +0000