summaryrefslogtreecommitdiffstats
path: root/components/infobars.gypi
Commit message (Collapse)AuthorAgeFilesLines
* Componentize SimpleAlertInfoBarDelegatesdefresne2014-12-301-0/+2
| | | | | | | | | | | | | | | Move SimpleAlertInfoBarDelegate into //components/infobar/core since it only depends on //base and //components/infobar/core and we want to share the code with iOS. BUG=438238 TBR=bauerb@chromium.org TBR=felt@chromium.org TBR=dtseng@chromium.org Review URL: https://codereview.chromium.org/824033002 Cr-Commit-Position: refs/heads/master@{#309734}
* Remove dependency of infobars component on the embeddersdefresne2014-12-221-16/+0
| | | | | | | | | | | | | | | | | | Add a virtual method InfoBarManager::CreateConfirmInfoBar that allow the embedder to use UI specific implementation of ConfirmInfoBar. Port all client code to use this virtual method instead of the static method ConfirmInfoBarDelegate::CreateInfoBar. Implements the InfoBarService::CreateConfirmInfoBar method for the different UI (views, android, cocoa) and for TestInfoBarManager. BUG=386171 TBR=jam@chromium.org TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/812823002 Cr-Commit-Position: refs/heads/master@{#309437}
* Move infobar constants and the code that uses them from components/ to chrome/.pkasting2014-12-121-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | Both the infobar and the infobar container were making use of various infobar constants that were declared in components/ but (usually) defined in chrome/. This was a symptom of having put code in the component that really probably belonged in the embedder. This CL hoists the relevant logic to a new cross-platform InfoBarContainerDelegate class defined on the chrome side, which implements some of the methods of InfoBarContainer::Delegate. Platforms then subclass this to implement the remaining, platform-specific bits. This means that the constants in question now live solely in chrome/, avoiding a bunch of link-time nastiness when trying to build the components code separately. BUG=382924 TEST=none TBR=finnur Review URL: https://codereview.chromium.org/793783003 Cr-Commit-Position: refs/heads/master@{#308046}
* Add more components unit tests to GN build.brettw2014-11-251-0/+1
| | | | | | | | | | This adds a lot of missing dependencies. Some of these are required to link, most of the rest are a result of running "gn check" over the affected directories. Review URL: https://codereview.chromium.org/746783002 Cr-Commit-Position: refs/heads/master@{#305687}
* Export the dependency of infobars on skia in gypdroger2014-10-131-0/+3
| | | | | | | | | | | | | | | This dependency is already exported in BUILD.gn, but not in infobars.gypi. Infobar code transitively includes skia headers. An example of this is infobars.h including SkColor.h. These skia headers need skia to be added in the include path in order to compile. Because of this, any target depending on infobars must also add skia include dirs. Review URL: https://codereview.chromium.org/650203002 Cr-Commit-Position: refs/heads/master@{#299330}
* Add more components to the GN build.brettw@chromium.org2014-07-161-1/+5
| | | | | | | | | | | | | | | | | | google infobars invalidation navigation_intercaption network_time password_manager plugins search_provider_logos sessions R=viettrungluu@chromium.org Review URL: https://codereview.chromium.org/397953005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283521 0039d316-1c4b-4281-b951-d872f2087c98
* [Variations] Bring variations_http_header_provider to variations componentmathp@chromium.org2014-07-091-0/+14
| | | | | | | | | | | | | | Without this, the class can hardly be used within a component (unless we work around it). Adds a workaround for link failure of components_tests due to infobar component bug (crbug.com/386171). BUG=387751,382865,386171 TBR=jam TEST=Variations* Review URL: https://codereview.chromium.org/366373002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282072 0039d316-1c4b-4281-b951-d872f2087c98
* Move TranslateInfoBarDelegate and OptionsMenuModel to the Translate component.droger@chromium.org2014-06-021-0/+1
| | | | | | | | | | | | | | | | | To solve the dependency on chrome_command_ids, this CL removes the IDC_OPTIONS_TRANSLATE_* constants and instead defines the command IDs locally in the file, which is an approach already used at several other places in the code. To solve the dependency on themes, the icon ID for the translate infobar is no longer hardcoded, but fetched from the translate client instead. BUG=371845 TBR=estade, joaodasilva Review URL: https://codereview.chromium.org/284313008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274252 0039d316-1c4b-4281-b951-d872f2087c98
* infobars: Componentize ConfirmInfoBarDelegate.tfarina@chromium.org2014-05-221-0/+3
| | | | | | | | | | | | | | | | | | Changes: 1- Change it to use ui_strings.h 2- Use IDS_APP_OK and IDS_APP_CANCEL from ui_strings. 3- Move to components/infobars/core from chrome/browser/infobars (done with tools/git/move_source_file.py). BUG=373234 TEST=chrome still links and run fine. R=droger@chromium.org, pkasting@chromium.org TBR=ben # for trivial chrome/ changes Review URL: https://codereview.chromium.org/289083004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272036 0039d316-1c4b-4281-b951-d872f2087c98
* Move Infobars core files to the Infobars componentdroger@chromium.org2014-04-181-0/+32
This CL sets up the directory structure for the Infobars component and the infobars_core target. It also does a simple code move to the compoonent. This CL does not move ConfirmInfoBarDelegate because it still has a dependency on chrome/ (for strings). BUG=354379 TBR=sky, reed Review URL: https://codereview.chromium.org/240193003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264792 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-08-30 18:27:10 +0000