| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
All leveldb uses now set the reuse_logs option to trigger a new fast open path.
For db's with prior changes (i.e. non-empty logs) this avoids three fsync calls
(on average) for every open as well as the need to compact (rewrite) the db.
More info at:
https://github.com/google/leveldb/commit/251ebf5dc70129ad3c38193fe6c99a5b0ec6b9fa
BUG=468810
Review URL: https://codereview.chromium.org/1025433003
Cr-Commit-Position: refs/heads/master@{#322433}
|
| |
|
|
|
|
|
|
|
|
|
|
| |
When Init fails, further Save/Load calls should just fail (and not
crash). This makes the underlying LevelDB properly handle the Init failed case
and adds tests for that.
Adds LevelDB::InitWithOptions to make it easy to have the Init fail in tests.
Review URL: https://codereview.chromium.org/735823004
Cr-Commit-Position: refs/heads/master@{#304944}
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Google C++ style guide states:
Explicitly annotate overrides of virtual functions or virtual
destructors with an override or (less frequently) final specifier.
Older (pre-C++11) code will use the virtual keyword as an inferior
alternative annotation. For clarity, use exactly one of override,
final, or virtual when declaring an override.
To better conform to these guidelines, the following constructs have
been rewritten:
- if a base class has a virtual destructor, then:
virtual ~Foo(); -> ~Foo() override;
- virtual void Foo() override; -> void Foo() override;
- virtual void Foo() override final; -> void Foo() final;
This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.
BUG=417463
R=caitkp@chromium.org
Review URL: https://codereview.chromium.org/684513002
Cr-Commit-Position: refs/heads/master@{#301931}
|
| |
|
|
|
|
|
|
| |
BUG=417463
Review URL: https://codereview.chromium.org/623133002
Cr-Commit-Position: refs/heads/master@{#298237}
|
| |
|
|
|
|
|
|
|
|
|
| |
Reusing the "base::StringPairs" insted of "std::vector<std::pair<std::string, std::string> >"
same is defined in base/strings/string_split.h.
BUG=412250
Review URL: https://codereview.chromium.org/593113002
Cr-Commit-Position: refs/heads/master@{#297387}
|
| |
|
|
|
|
|
|
|
|
|
| |
typedef std::vector<std::pair<std::string, std::string> > StringPairs;
And use iterator to iterate stl::vector element.
BUG=412250
Review URL: https://codereview.chromium.org/545193008
Cr-Commit-Position: refs/heads/master@{#294832}
|
| |
|
|
|
|
|
|
|
|
| |
and components/
Also fix the formatting of chrome_elf/OWNERS
Review URL: https://codereview.chromium.org/546733002
Cr-Commit-Position: refs/heads/master@{#294245}
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds BUILD files for:
- enhanced_bookmarks
- leveldb_proto
- omaha_query_params
BUG=None
TEST=gn gen out/Debug_gn && ninja -C out/Debug_gn
R=brettw@chromium.org
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/391603002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
Code extracted from components/dom_distiller/core/dom_distiller_database.*
Slight API change: callers to UpdateEntries now have to pass a vector of (string, proto) as key and value, instead of just a vector of protos where key is derived.
Ran clang-format on the files I touched so you may see some diffs.
Note: Implementations are in proto_database_impl.h and fake_db.h for proper linking.
BUG=385747
TBR=jochen,dgrogan
TEST=DomDistiller*,ProtoDatabaseImplTest
Review URL: https://codereview.chromium.org/330833002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278096 0039d316-1c4b-4281-b951-d872f2087c98
|
