summaryrefslogtreecommitdiffstats
path: root/components/leveldb_proto
Commit message (Collapse)AuthorAgeFilesLines
* Make more components pass GN check.brettw2015-11-261-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | Adds: gcm_driver gpu guest_view handoff infobars invalidation json_schema keyed_service language_usage_metrics leveldb_proto login memory_pressure message_port metrics metrics_services_manager mime_util Review URL: https://codereview.chromium.org/1472053004 Cr-Commit-Position: refs/heads/master@{#361804}
* clang/win: Fix -Wunused-function warnings after ↵Nico Weber2015-10-281-3/+5
| | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1420003004/ Fixes: ..\..\components/leveldb_proto/proto_database_impl.h(102,6) : error: unused function 'InitFromTaskRunner' [-Werror,-Wunused-function] void InitFromTaskRunner(LevelDB* database, const base::FilePath& database_dir, ^ ..\..\components/leveldb_proto/proto_database_impl.h(110,6) : error: unused function 'DestroyFromTaskRunner' [-Werror,-Wunused-function] void DestroyFromTaskRunner(const base::FilePath& database_dir, bool* success) { ^ Defining non-inline functions in a .h file generally can't work, so the warning pointed at bad code here. BUG=82385 TBR=jianli Review URL: https://codereview.chromium.org/1422313003 . Cr-Commit-Position: refs/heads/master@{#356509}
* Wipe out offline page data on clearing cookie and site datajianli2015-10-275-0/+50
| | | | | | | | BUG=491352 Review URL: https://codereview.chromium.org/1420003004 Cr-Commit-Position: refs/heads/master@{#356442}
* Added UMA stats reporting to LevelDB proto.cmumford2015-10-136-14/+44
| | | | | | | | | | Adding stats to report usage (and detect potential corruption). BUG=508330 Review URL: https://codereview.chromium.org/1228143002 Cr-Commit-Position: refs/heads/master@{#353773}
* Update OWNERS file now that Chris has left the project.yfriedman2015-09-111-1/+1
| | | | | | | | TBR=sgurun Review URL: https://codereview.chromium.org/1315443013 Cr-Commit-Position: refs/heads/master@{#348427}
* Add more components_unittests to GN buildBrett Wilson2015-08-221-1/+13
| | | | | | | | | | | | | | This adds tests for: url matcher, precache, sync driver, serialization, proxy config, leveldb proto, error page, storage monitor, search provider logos, translate, json schema, guest view, dom distiller, network hints. CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel TBR=dpranke@chromium.org Reland of issue 1303703004. TBR=dpranke@chromium.org Review URL: https://codereview.chromium.org/1311623002 . Cr-Commit-Position: refs/heads/master@{#344987}
* Revert of Add more components_unittests to GN build (patchset #5 id:80001 of ↵yosin2015-08-221-13/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1303703004/ ) Reason for revert: Compilation error in storage_monitor_win_unittest.cc. GYP build may not compile this file. FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64/cl.exe" /nologo /showIncludes /FC @obj/components/storage_monitor/unit_tests/storage_monitor_win_unittest.obj.rsp /c ../../components/storage_monitor/storage_monitor_win_unittest.cc /Foobj/components/storage_monitor/unit_tests/storage_monitor_win_unittest.obj /Fdobj/components/storage_monitor/unit_tests_cc.pdb e:\b\build\slave\win_x64_gn__dbg_\build\src\components\storage_monitor\storage_monitor_win_unittest.cc(218) : error C2220: warning treated as error - no 'object' file generated e:\b\build\slave\win_x64_gn__dbg_\build\src\components\storage_monitor\storage_monitor_win_unittest.cc(218) : warning C4267: '=' : conversion from 'size_t' to 'DWORD', possible loss of data e:\b\build\slave\win_x64_gn__dbg_\build\src\components\storage_monitor\storage_monitor_win_unittest.cc(298) : warning C4267: 'initializing' : conversion from 'size_t' to 'int', possible loss of data ninja: build stopped: subcommand failed. Original issue's description: > Add more components_unittests to GN build > > This adds tests for: url matcher, precache, sync driver, serialization, proxy config, leveldb proto, error page, storage monitor, search provider logos, translate, json schema, guest view, dom distiller, network hints. > > CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel > > Committed: https://crrev.com/c76a816074e6504b0b4b3420529928057d11b50b > Cr-Commit-Position: refs/heads/master@{#344974} TBR=dpranke@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1313463002 Cr-Commit-Position: refs/heads/master@{#344976}
* Add more components_unittests to GN buildbrettw2015-08-221-1/+13
| | | | | | | | | | This adds tests for: url matcher, precache, sync driver, serialization, proxy config, leveldb proto, error page, storage monitor, search provider logos, translate, json schema, guest view, dom distiller, network hints. CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel Review URL: https://codereview.chromium.org/1303703004 Cr-Commit-Position: refs/heads/master@{#344974}
* Clean-ups in the leveldb_proto component.peter2015-07-305-112/+124
| | | | | | | | | | | | | | | The main intention of this change is to trim down on reference churn by passing callbacks and scoped_refptrs as constant references. While in the area, however, I also updated a bunch of other old habits in favor of better C++11-y habits. R=cjhopman BUG= Review URL: https://codereview.chromium.org/1262713004 Cr-Commit-Position: refs/heads/master@{#341110}
* Support in-memory databases in leveldb_protopeter2015-07-233-0/+33
| | | | | | | | | | | | | | | | There is no requirement for LevelDB databases to live on disk - by creating a memory environment they can live in memory (but are, of course, ephemeral and entirely scoped to the instance). This is useful for databases which might have to be created for browser tests where mocking the database is undesirable. R=cjhopman BUG= Review URL: https://codereview.chromium.org/1245703003 Cr-Commit-Position: refs/heads/master@{#340090}
* components: Remove use of MessageLoopProxy and deprecated MessageLoop APIsskyostil2015-06-021-5/+5
| | | | | | | | | | | This patch was mostly autogenerated with https://codereview.chromium.org/1010073002/. BUG=465354 Review URL: https://codereview.chromium.org/1144153004 Cr-Commit-Position: refs/heads/master@{#332440}
* Update {virtual,override} to follow C++11 style in components.nick2015-04-282-13/+10
| | | | | | | | | | | | The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was manually generated using a regex and a text editor. BUG=417463 Review URL: https://codereview.chromium.org/1056633004 Cr-Commit-Position: refs/heads/master@{#327312}
* leveldb: Reuse manifest (AKA logs) during open.cmumford2015-03-262-1/+3
| | | | | | | | | | | | | | | | All leveldb uses now set the reuse_logs option to trigger a new fast open path. For db's with prior changes (i.e. non-empty logs) this avoids three fsync calls (on average) for every open as well as the need to compact (rewrite) the db. More info at: https://github.com/google/leveldb/commit/251ebf5dc70129ad3c38193fe6c99a5b0ec6b9fa BUG=468810 Review URL: https://codereview.chromium.org/1025433003 Cr-Commit-Position: refs/heads/master@{#322433}
* Make ProtoDatabase properly handle failed Initcjhopman2014-11-203-6/+39
| | | | | | | | | | | | When Init fails, further Save/Load calls should just fail (and not crash). This makes the underlying LevelDB properly handle the Init failed case and adds tests for that. Adds LevelDB::InitWithOptions to make it easy to have the Init fail in tests. Review URL: https://codereview.chromium.org/735823004 Cr-Commit-Position: refs/heads/master@{#304944}
* Standardize usage of virtual/override/final specifiers.dcheng2014-10-291-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=caitkp@chromium.org Review URL: https://codereview.chromium.org/684513002 Cr-Commit-Position: refs/heads/master@{#301931}
* replace OVERRIDE and FINAL with override and final in components/mostynb2014-10-062-6/+6
| | | | | | | | BUG=417463 Review URL: https://codereview.chromium.org/623133002 Cr-Commit-Position: refs/heads/master@{#298237}
* Reusing the base::StringPairs in src/components/*kulkarni.a2014-09-301-1/+2
| | | | | | | | | | | Reusing the "base::StringPairs" insted of "std::vector<std::pair<std::string, std::string> >" same is defined in base/strings/string_split.h. BUG=412250 Review URL: https://codereview.chromium.org/593113002 Cr-Commit-Position: refs/heads/master@{#297387}
* Becuase base/strings/string_split.h defines:limasdf2014-09-152-9/+9
| | | | | | | | | | | typedef std::vector<std::pair<std::string, std::string> > StringPairs; And use iterator to iterate stl::vector element. BUG=412250 Review URL: https://codereview.chromium.org/545193008 Cr-Commit-Position: refs/heads/master@{#294832}
* Change base/file_utils.h includes to base/files/file_utils.h in chrome_elf/ ↵thestig2014-09-102-2/+2
| | | | | | | | | | and components/ Also fix the formatting of chrome_elf/OWNERS Review URL: https://codereview.chromium.org/546733002 Cr-Commit-Position: refs/heads/master@{#294245}
* components: Add GN build files for three more components.tfarina@chromium.org2014-07-152-0/+39
| | | | | | | | | | | | | | | | | This patch adds BUILD files for: - enhanced_bookmarks - leveldb_proto - omaha_query_params BUG=None TEST=gn gen out/Debug_gn && ninja -C out/Debug_gn R=brettw@chromium.org TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/391603002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283234 0039d316-1c4b-4281-b951-d872f2087c98
* Extract protobuf database into a new 'leveldb_proto' componentmathp@chromium.org2014-06-1810-0/+965
Code extracted from components/dom_distiller/core/dom_distiller_database.* Slight API change: callers to UpdateEntries now have to pass a vector of (string, proto) as key and value, instead of just a vector of protos where key is derived. Ran clang-format on the files I touched so you may see some diffs. Note: Implementations are in proto_database_impl.h and fake_db.h for proper linking. BUG=385747 TBR=jochen,dgrogan TEST=DomDistiller*,ProtoDatabaseImplTest Review URL: https://codereview.chromium.org/330833002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278096 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-05-07 22:48:53 +0000