| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently enterprise customers can specify ${LOGIN_ID} or ${LOGIN_EMAIL}
to tell Chrome OS to substitute user identity information into an EAP
configuration. However, in some installations, the login ID for the
Chromebook does not match the login ID for the EAP-TLS wireless network;
instead, the EAP-TLS identity is stored in the subjectAltName field
in the client certificate. Add code to Chrome to allow this
field to be extracted if so configured in CPanel.
BUG=549659
TEST=`chromeos_unittests`
TEST=manually configure EAP-TLS network in CPanel, then watch
the `freeradius -X` logs during connection
Review URL: https://codereview.chromium.org/1717123002
Cr-Commit-Position: refs/heads/master@{#379056}
|
|
|
|
|
|
|
|
|
|
|
| |
This CL maps AllowOnlyPolicyNetworksToConnect to only allowing users
to connect to managed networks.
BUG=208378
Review URL: https://codereview.chromium.org/1433423003
Cr-Commit-Position: refs/heads/master@{#359542}
|
|
|
|
|
|
|
|
| |
Also adding some other overdue owners.
Review URL: https://codereview.chromium.org/1384443003
Cr-Commit-Position: refs/heads/master@{#352825}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds types for neworkingPrivate.getManagedProperties.
It also updates settings/internet_page to use getManagedProperties
and the correct types.
BUG=535270
For third_party/closure_compiler/externs/networking_private.js:
TBR=dbeam@chromium.org
Review URL: https://codereview.chromium.org/1376523003
Cr-Commit-Position: refs/heads/master@{#351890}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL:
* Adds NetworkProperties to networking_private.idl for
the getProperties callback.
* Updates networking_private.js externs.
* Updates cr_onc_types.js:
** CrOnc.getProperty is removed (properties.foo.bar is used instead)
** CrOnc.getActiveValue(state, key) is removed and
CrOnc.getActivePropertyValue is renamed to getActiveValue. Calls
to CrOnc.getActiveValue(state, key) become
CrOnc.getActiveValue(state.key) (except for dictionary properties
which can not be managed, in which case state.key is used
directly).
* Updates md-settings/internet JS to use NetworkProperties for
getNetworks() instead of the NetworkStateProperties subset.
** All references to networkState that are actually
NetworkProperties are renamed to networkProperties to make it
easier to distinguish between "state" property dictionaries and
full property dictionaries.
** (Apologies for the additional renaming diffs that generates)
BUG=535270
For third_party/closure_compiler/externs/networking_private.js:
TBR=jlklein@chromium.org
Review URL: https://codereview.chromium.org/1366243002
Cr-Commit-Position: refs/heads/master@{#351232}
|
|
|
|
|
|
|
|
| |
Removing onc::kNetworkConfiguration (not to be mixed up with kNetworkConfigurations (trailing 's')).
Review URL: https://codereview.chromium.org/1360003003
Cr-Commit-Position: refs/heads/master@{#350794}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL:
* Populates ThirdPartyVPN.Name property for all
networkingPrivate get* methods, including getState and
getNetworks so that the VPN network names can be displayed
correctly.
* Updates the existing and new Settings UI to use this
property.
BUG=516796
Review URL: https://codereview.chromium.org/1295583003
Cr-Commit-Position: refs/heads/master@{#349305}
|
|
|
|
|
|
|
|
|
|
| |
This CL maps an ONC property for disabling network technologies.
BUG=426390
Review URL: https://codereview.chromium.org/1306813008
Cr-Commit-Position: refs/heads/master@{#347638}
|
|
|
|
|
|
|
|
|
| |
BUG=486738
R=stevenjb@chromium.org, pneubeck@chromium.org
Review URL: https://codereview.chromium.org/1137633003
Cr-Commit-Position: refs/heads/master@{#329291}
|
|
|
|
|
|
|
|
|
| |
BUG=475699
TEST=None
Review URL: https://codereview.chromium.org/1085703002
Cr-Commit-Position: refs/heads/master@{#326738}
|
|
|
|
|
|
|
|
|
|
|
| |
This CL maps an ONC property for setting per-network roam threshold.
BUG=chrome-os-partner:38681
TEST=Expanded test ONC and JSON test sets
Review URL: https://codereview.chromium.org/1087353002
Cr-Commit-Position: refs/heads/master@{#325515}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds checks for unconfigured or non-activated networks to internet_details.js since it no longer uses the checks in network_connect.cc.
It also moves some notification handling from network_connect.cc to network_state_notifier.cc so that it does not rely on network_connect.cc.
Original CL (reverted for unrelated failure):
https://codereview.chromium.org/1043343002/
BUG=430115
TBR=michaelpg, pneubeck, mpearson@chromium.org
Review URL: https://codereview.chromium.org/1091043002
Cr-Commit-Position: refs/heads/master@{#325484}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1043343002/)
Reason for revert:
Causes browser_test failure on Win7 bot.
https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20(1)
[ RUN ] WebNavigationApiTest.Failures
[4444:4508:0414/144708:WARNING:data_reduction_proxy_config.cc(319)] SPDY proxy OFF at startup
[4444:2028:0414/144708:ERROR:bluetooth_adapter_win.cc(102)] NOT IMPLEMENTED
[180:3848:0414/144709:WARNING:raw_channel_win.cc(473)] WriteFile: Error (0x5) while retrieving error. (0xE8)
[180:3848:0414/144709:WARNING:channel.cc(549)] Failed to send message to ack remove remote endpoint (local ID 2147483650, remote ID 3)
[180:3848:0414/144709:WARNING:channel.cc(315)] RawChannel write error
[180:3848:0414/144709:WARNING:raw_channel_win.cc(473)] WriteFile: Error (0x3B01) while retrieving error. (0xE8)
[180:3848:0414/144709:WARNING:channel.cc(549)] Failed to send message to ack remove remote endpoint (local ID 1, remote ID 1)
[180:3848:0414/144709:WARNING:channel.cc(315)] RawChannel write error
[4444:2028:0414/144709:INFO:CONSOLE(0)] "[SUCCESS] nonExistentIframe", source: chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/test_failures.html (0)
[4444:2028:0414/144710:INFO:CONSOLE(0)] "[SUCCESS] nonExistentIframeNavigation", source: chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/test_failures.html (0)
[4444:2028:0414/144710:INFO:CONSOLE(0)] "[FAIL] cancel: Received unexpected event 'onCompleted':{"frameId":0,"processId":0,"tabId":0,"timeStamp":0,"url":"chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/e.html"}
Error
at captureEvent (chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/framework.js:194:17)
at chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/framework.js:219:5
at EventImpl.dispatchToListener (extensions::event_bindings:395:22)
at Event.publicClass.(anonymous function) [as dispatchToListener] (extensions::utils:94:26)
at EventImpl.dispatch_ (extensions::event_bindings:379:35)
at dispatchArgs (extensions::event_bindings:247:26)
at dispatchEvent (extensions::event_bindings:256:7)", source: chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/test_failures.html (0)
[4444:2028:0414/144710:INFO:CONSOLE(0)] "[SUCCESS] nonExistent", source: chrome-extension://ollhgkgdokpphndfogkepkmblokamlkf/test_failures.html (0)
c:\b\build\slave\win_x64_builder\build\src\chrome\browser\extensions\api\web_navigation\web_navigation_apitest.cc(468): error: Value of: RunExtensionTest("webnavigation/failures")
Actual: false
Expected: true
Failed 1 of 4 tests
[4444:2028:0414/144710:ERROR:browser_thread.h(263)] DeleteSoon failed on thread 0
[ FAILED ] WebNavigationApiTest.Failures, where TypeParam = and GetParam() = (2465 ms)
Original issue's description:
> Use networkingPrivate.startConnect
>
> This adds checks for unconfigured or non-activated networks to internet_details.js since it no longer uses the checks in network_connect.cc.
> It also moves some notification handling from network_connect.cc to network_state_notifier.cc so that it does not rely on network_connect.cc.
>
> BUG=430115
>
> Committed: https://crrev.com/e22e5bcbad2cea941993b32e6cc3b082822a42fc
> Cr-Commit-Position: refs/heads/master@{#325108}
TBR=armansito@chromium.org,michaelpg@chromium.org,pneubeck@chromium.org,stevenjb@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=430115
Review URL: https://codereview.chromium.org/1085993002
Cr-Commit-Position: refs/heads/master@{#325145}
|
|
|
|
|
|
|
|
|
|
|
| |
This adds checks for unconfigured or non-activated networks to internet_details.js since it no longer uses the checks in network_connect.cc.
It also moves some notification handling from network_connect.cc to network_state_notifier.cc so that it does not rely on network_connect.cc.
BUG=430115
Review URL: https://codereview.chromium.org/1043343002
Cr-Commit-Position: refs/heads/master@{#325108}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is needed for the internet Settings UI to replace the following
properites passed using chrome.send(). It will also be used in the new
Settings UI to improve the UI for uninitalized and enabling
technologies.
cellularAvailable
cellularEnabled
wifiAvailable
wifiEnabled
wimaxAvailable
wimaxEnabled
BUG=465418
For chrome_browser_main_extra_parts_profiles.cc:
TBR=skuhne@chromium.org
Review URL: https://codereview.chromium.org/1059033002
Cr-Commit-Position: refs/heads/master@{#324643}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This uses the recent networkingPrivate changes to support setting
Cellular.Carrier in setProperties and adding startActivate in
internet_details.js.
BUG=430115
Review URL: https://codereview.chromium.org/1046593003
Cr-Commit-Position: refs/heads/master@{#324490}
|
|
|
|
|
|
|
|
|
|
|
| |
Add documentation for the "LcpEchoDisabled" ONC property.
BUG=463602
TEST=None
Review URL: https://codereview.chromium.org/1060333003
Cr-Commit-Position: refs/heads/master@{#324256}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL maps an ONC property for disabling L2TP connection
monitoring via PPP LCP frames.
BUG=463602
TEST=Expanded test ONC and JSON test sets
Review URL: https://codereview.chromium.org/1058973002
Cr-Commit-Position: refs/heads/master@{#323943}
|
|
|
|
|
|
|
|
|
|
| |
BUG=464036
For minor change to .idl:
TBR=asargent@chromium.org
Review URL: https://codereview.chromium.org/1028243007
Cr-Commit-Position: refs/heads/master@{#322951}
|
|
|
|
|
|
|
|
|
|
| |
This also adds the network technology 1x badge to cr_network_icon
BUG=470282
Review URL: https://codereview.chromium.org/1033843003
Cr-Commit-Position: refs/heads/master@{#322409}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL maps the third-party VPN provider extension ID (which is
stored in shill's |Provider.Host| field) to an ONC property.
BUG=460428
TEST=Extended unit tests and API test
Review URL: https://codereview.chromium.org/1019033002
Cr-Commit-Position: refs/heads/master@{#321238}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL does the following:
* Eliminates "ProviderRequiresRoaming" from ONC
* Adds a "required" state to "RoamingState" in ONC when ProviderRequiresRoaming is true
* Adds "ONC State" to chrome://network for testing networkingPrivate.getState()
* Adds support for shill_stub=roaming=[home|roaming|required] to facilitate testing on Linux
BUG=461163
Review URL: https://codereview.chromium.org/948943003
Cr-Commit-Position: refs/heads/master@{#318113}
|
|
|
|
|
|
|
|
| |
BUG=455872
Review URL: https://codereview.chromium.org/917553002
Cr-Commit-Position: refs/heads/master@{#316005}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Comparison of a network policy with network will use HexSSID now.
- Translation from ONC to Shill now copies the HexSSID instead of translating SSID.
- Fix ONC validation of HexSSID/SSID to be case insensitive.
- When setting an ONC: SSID will be ignored if HexSSID is present
- Reading network properties reports a HexSSID in ONC.
BUG=432546
Review URL: https://codereview.chromium.org/823633004
Cr-Commit-Position: refs/heads/master@{#311281}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL introdcues IPAddressConfigType and NameServersConfigType
If either of these is set to 'Static', a 'StaticIPConfig' object must
be provided and must specify any non-default configuration. If neither
is set to 'Static', the StaticIPConfig object will be ignored.
Originally uploaded as https://codereview.chromium.org/750313003/
BUG=411289
Review URL: https://codereview.chromium.org/749013003
Cr-Commit-Position: refs/heads/master@{#310325}
|
|
|
|
|
|
|
|
|
|
|
| |
These were unused and unsupported and conflict upcoming changes.
Also clean up some IPConfig documentation and adapt the validation.
BUG=411289
Review URL: https://codereview.chromium.org/830133003
Cr-Commit-Position: refs/heads/master@{#309942}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ONC currently uses strings to represent SSIDs. Since JSON-Schema strings are restricted to Unicode and ONC is encoding these as UTF-8, this means that ONC cannot be used to represent SSIDs that include non-UTF-8 strings.
This change adds a separate HexSSID field to the WiFi section of the ONC that expects an SSID byte sequence encoded in hex.
At least one of the fields HexSSID or SSID must be present. If both HexSSID and SSID are set, the values must be consistent.
BUG=432546
Review URL: https://codereview.chromium.org/759663004
Cr-Commit-Position: refs/heads/master@{#306838}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ONC does not understand thirdpartyvpn. This results in VPN host
being set to undefined during disconnect, rendering third party VPN
configurations unusable after disconnect. This CL adds
partial support in ONC layer for third party VPN to solve this problem.
BUG=407541
Review URL: https://codereview.chromium.org/762113005
Cr-Commit-Position: refs/heads/master@{#306413}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reland of https://codereview.chromium.org/560863002/ which the CQ failed to commit correctly.
This does not adapt the UI to respect the policy's UserAuthenticationType, yet.
BUG=347916
TBR=stevenjb@chromium.org
TEST=Ensured that a previously working policy pushed OpenVPN network still works.
Review URL: https://codereview.chromium.org/632223002
Cr-Commit-Position: refs/heads/master@{#298431}
|
|
|
|
|
|
|
|
|
|
|
|
| |
By default, link monitor is enabled for WiFi network. When it is
enabled, it will send ARP request to default gateway periodically.
This CL adds an ONC configuration option to disable the link monitor.
BUG=chromium:415367
Review URL: https://codereview.chromium.org/598173002
Cr-Commit-Position: refs/heads/master@{#298327}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a follow up CL for 414417 that includes the ONC translation
necessary for the Wimax UI and fixes the JS to use the new WiMAX
capitalization. It also adds a WiMAX entry to the HTML doc.
BUG=414417
Review URL: https://codereview.chromium.org/581213003
Cr-Commit-Position: refs/heads/master@{#295774}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds the object "WiMAX" to ONC, which contains the basic properties
AutoConnect (read/write)
EAP (write-only)
SignalStrength (read-only).
Also all general network properties like Name or ConnectionState are supported.
BUG=414417
Review URL: https://codereview.chromium.org/578823003
Cr-Commit-Position: refs/heads/master@{#295467}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Fixed AutoConnect, which is stored in each network type's subdictionary.
- Added a Cellular.AutoConnect property to ONC.
- Fixed VPN username for L2TP-IPsec, which is stored in 'L2TP'.
- Removed reading Wimax properties from ONC, as these are not yet supported.
BUG=412807
Review URL: https://codereview.chromium.org/571123002
Cr-Commit-Position: refs/heads/master@{#294897}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently the Cellular properties are not documented in onc_spec.html
at all. This provides rudimentary documentation based on the Shill
documentaiton.
It also removes 'SelectedNetwork' which is undocumented in Shill and
unused in Chrome.
BUG=None
Review URL: https://codereview.chromium.org/563643002
Cr-Commit-Position: refs/heads/master@{#294516}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also includes a bit of JS cleanup to use ONC properties directly
where possible.
BUG=279351
R=pneubeck@chromium.org
Review URL: https://codereview.chromium.org/552113002
Cr-Commit-Position: refs/heads/master@{#294462}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before read-only properties which cannot be set by the user or policy, were explicitly marked as 'unmanaged' in the augmented dictionary returned by getManagedProperties.
Now, instead these properties are returned as plain values, which simplifies the consumer side, especially of Array typed properties like IPConfigs (compare this with SavedIPConfig).
BUG=410877
Review URL: https://codereview.chromium.org/551753002
Cr-Commit-Position: refs/heads/master@{#293931}
|
|
|
|
|
|
|
|
| |
BUG=279351
Review URL: https://codereview.chromium.org/535283002
Cr-Commit-Position: refs/heads/master@{#293621}
|
|
|
|
|
|
|
|
| |
BUG=279351
Review URL: https://codereview.chromium.org/540613002
Cr-Commit-Position: refs/heads/master@{#293331}
|
|
|
|
|
|
|
|
|
|
| |
BUG=279351
For chrome/browser/ui/webui/chromeos/network_config_message_handler.cc:
TBR=xiyuan@chromium.org
Review URL: https://codereview.chromium.org/492383002
Cr-Commit-Position: refs/heads/master@{#292245}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This includes some necessary ONC translation fixes.
BUG=279351
R=armansito@chromium.org, pneubeck@chromium.org
Review URL: https://codereview.chromium.org/482243002
Cr-Commit-Position: refs/heads/master@{#291085}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enables OTA activation using the old Wifi flow except it connects to the cellular network instead of requiring a Wifi connection.
BUG=chromium:384185
TEST=Unit tests, manually activate SIM on CDMA and LTE
Review URL: https://codereview.chromium.org/406473002
Cr-Commit-Position: refs/heads/master@{#288854}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes how we translate the Device properties to ONC instead of
just copying the Shill properties.
BUG=279351
Review URL: https://codereview.chromium.org/402953004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Original review: https://codereview.chromium.org/383083010
R=jamesr@chromium.org
TBR=jamesr@chromium.org
Review URL: https://codereview.chromium.org/395633002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Add browser_extensions to GN build.
>
> BUG=
> R=jamesr@chromium.org
>
> Review URL: https://codereview.chromium.org/383083010
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/396493003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
R=jamesr@chromium.org
Review URL: https://codereview.chromium.org/383083010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
onc_validator had some deviations from the onc_spec.
This updates the onc_spec.
BUG=386182
R=davidroche@chromium.org, pastarmovj@chromium.org
Review URL: https://codereview.chromium.org/366273002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before, each network type had its own constants for ClientCert{Type,Pattern,Ref} which lead to duplicate implementations.
These constants are now unified into the namespace onc::client_cert together with the other client certificate related constants.
This leads to a clearer separation from the Certificate ONC object (has namespace onc::certificate)
and simplifies some code (see network_ui_data.cc and onc_validator.cc).
BUG=391292
(For trivial constant renaming:)
TBR=mef@chromium.org,vitalybuka@chromium.org
Review URL: https://codereview.chromium.org/368233004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The ONC validator threw an error if both the Certificates or NetworkConfigurations sections were missing in an ONC policy.
Now, we ignore that fact because we have to expect policies that only contain the new GlobalNetworkConfiguration section.
BUG=386182
Review URL: https://codereview.chromium.org/350443004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=374003
Review URL: https://codereview.chromium.org/291553002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=373965
For fake_wifi_service.cc
R=armansito@chromium.org, pneubeck@chromium.org
TBR=mef@chromium.org
Review URL: https://codereview.chromium.org/285233008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271679 0039d316-1c4b-4281-b951-d872f2087c98
|