summaryrefslogtreecommitdiffstats
path: root/components/os_crypt
Commit message (Collapse)AuthorAgeFilesLines
* Switch to standard integer types in components/, part 3 of 4.avi2015-12-258-4/+14
| | | | | | | | | BUG=138542 TBR=blundell@chromium.org Review URL: https://codereview.chromium.org/1551433002 Cr-Commit-Position: refs/heads/master@{#366874}
* Switch to standard integer types in base/strings/.avi2015-12-251-0/+1
| | | | | | | | | | BUG=138542 TBR=mark@chromium.org NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1548993002 Cr-Commit-Position: refs/heads/master@{#366860}
* Fix //components/os_crypt to build for iOS with gn.sdefresne2015-11-131-1/+3
| | | | | | | | | | | | Use set_sources_assignment_filter to correctly select the correct implementation of KeychainPassword and OsCrypt to use on iOS (the same as on Mac). BUG=459705 Review URL: https://codereview.chromium.org/1439203003 Cr-Commit-Position: refs/heads/master@{#359558}
* Move `gn check` into the `generate_build_files` step.dpranke2015-09-181-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The dedicated GN bots run a script test step called `gn_check` that (unsurprisingly) runs `gn check` to validate that we haven't introduced any bad build dependencies. When we enabled GN on the regular Linux bots, we forgot to add that step. It turns out that we can't easily add it, because the Linux bots use a builder/tester split, and the script would run on the tester, where we don't have a build directory and don't know what GN args to check against. This patch changes the MB/generate_build_files step to add the --check flag to the normal `gn gen` invocation. This slows down the generate_build_files step, but the time would be spent somewhere anyway when we ran the gn check step, later. This patch also removes the explicit gn_check test step from all of the bots. This patch will have the side effect of starting to run `gn check` on *every* GN configuration (GN check was only being run on some of the configurations before). R=jam@chromium.org, brettw@chromium.org BUG=532230 CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg;tryserver.chromium.win:win8_chromium_gn_dbg,win_chromium_gn_x64_rel Review URL: https://codereview.chromium.org/1342293002 Cr-Commit-Position: refs/heads/master@{#349731}
* Sync remaining components_unittests with GNbrettw2015-08-261-0/+14
| | | | | | | | | | | | | | This syncs all remaining non-blocked tests from GYP to GN. This does not include NaCl related ones (nacl isn't completely hooked up) nor web_modal (blocked on bug 522654) nor constrained_window (blocked 0on web_modal). CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Review URL: https://codereview.chromium.org/1307763004 Cr-Commit-Position: refs/heads/master@{#345500}
* Replace ToLower calls to the new formatbrettw2015-08-101-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replaces base::StringToLowerASCII(string) with base::ToLowerASCII(string) This form is 1:1 search and replace. A bunch of places did something like this: std::string foo(something_else); base::StringToLowerASCII(&foo); which became: foo = base::ToLowerASCII(something_else); A couple places really wanted in-place changing and they became: foo = base::ToLowerASCII(foo); There was pretty trivial cleanup in chrome_main_delegate.cc chrome/test/chromedriver/server/http_handler.cc (fix indenting). There was more cleanup in: chrome/installer/util/language_selector.cc and components/plugins/renderer/mobile_youtube_plugin.cc In components/history/core/browser/url_utils.cc I removed the call since it was calling ToLower on the host name out of a GURL, which is already guaranteed to be lower-case. NOPRESUBMIT=true (due to touching code with wstrings) Review URL: https://codereview.chromium.org/1279123004 Cr-Commit-Position: refs/heads/master@{#342659}
* win: Fix all plugin warnings in components/.thakis2015-05-012-0/+9
| | | | | | | | | BUG=467287 TBR=jochen Review URL: https://codereview.chromium.org/1119033002 Cr-Commit-Position: refs/heads/master@{#327950}
* mac: Expose keychain access frequency to Telemetry.erikchen2015-01-151-1/+3
| | | | | | | | | | | | | | | | | | | | | Accessing the keychain is really slow. Telemetry tests use a mock keychain, which is abnormally fast. This CL exposes the number of times the mock keychain is accessed via a local histogram, and 4 telemetry measurements record that number as a metric. Those tests are: - speedometer - page_cycler - startup - tab_switching Once this metric is collected, alerts will be added to the Telemetry dashboard to help catch regressions to the number of times the keychain gets accessed. BUG= Review URL: https://codereview.chromium.org/714273004 Cr-Commit-Position: refs/heads/master@{#311744}
* Prefix CommandLine usage with base namespace (Part 9: components)kkosztyo.u-szeged2014-12-041-1/+1
| | | | | | | | | | | | Prefix all CommandLine usage in the components/ directory's following subdirectories: feedback, gcm_driver, google, infobars, invalidation, keyed_service, metrics, nacl, omnibox and os_crypt with the base:: namespace BUG=422426 Review URL: https://codereview.chromium.org/774933004 Cr-Commit-Position: refs/heads/master@{#306790}
* gn format //componentsscottmg2014-12-031-0/+1
| | | | | | | | | | | No intended functionality change. R=brettw@chromium.org BUG=348474 Review URL: https://codereview.chromium.org/780633002 Cr-Commit-Position: refs/heads/master@{#306640}
* Add crypto/wincrypt_shim.h wrapper header to resolve BoringSSL conflicts.davidben2014-10-302-2/+2
| | | | | | | | | | | | | wincrypt.h defines macros that conflict with BoringSSL. Introduce a crypto/wincrypt_shim.h wrapper header which #undefs those macros and instead #defines replacement ones. All Chromium headers should use this wrapper header. BUG=338884 Review URL: https://codereview.chromium.org/686883002 Cr-Commit-Position: refs/heads/master@{#301994}
* Standardize usage of virtual/override/final specifiers.dcheng2014-10-291-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=caitkp@chromium.org Review URL: https://codereview.chromium.org/684513002 Cr-Commit-Position: refs/heads/master@{#301931}
* replace OVERRIDE and FINAL with override and final in components/mostynb2014-10-061-1/+1
| | | | | | | | BUG=417463 Review URL: https://codereview.chromium.org/623133002 Cr-Commit-Position: refs/heads/master@{#298237}
* Move StringToLowerASCII to base namespacebrettw@chromium.org2014-08-071-2/+2
| | | | | | | | TBR=sky Review URL: https://codereview.chromium.org/448853002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288085 0039d316-1c4b-4281-b951-d872f2087c98
* mac: Cache the encryption key.erikchen@chromium.org2014-07-301-16/+30
| | | | | | | | | | | | | | | Failing to do so causes Chromium to hit the Mac Keychain hundreds of times on startup. This presents 2 problems. 1. Performance. ~40% of CPU usage during startup is spent accessing the keychain. 2. Keychain prompts. Each attempt to access the Keychain causes a prompt if the Keychain is locked. BUG=397308 Review URL: https://codereview.chromium.org/424833004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286585 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust the structure of DEPS within //components.blundell@chromium.org2014-05-061-1/+0
| | | | | | | | | | | | | | As the majority of components are now shared by iOS, it no longer makes sense to have a blanket allowance of IPC and //content/public/common in //components. Instead, individual components should have to add these dependencies explicitly, lessening the chance that bad dependencies creep in (e.g., a //content/public/common dependency in code that iOS shares). TBR=darin Review URL: https://codereview.chromium.org/266923008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268513 0039d316-1c4b-4281-b951-d872f2087c98
* Add BUILD.gn file for os_crypt so we can build this target with GN.tfarina@chromium.org2014-04-181-0/+36
| | | | | | | | | | | | | | | | | | | | | | | Add os_crypt to GN build. Debug: $ gn gen out/Debug_gn --args=is_debug=true $ ninja -C out/Debug_gn os_crypt Release: $ gn gen out/Release_gn --args=is_debug=false $ ninja -C out/Release_gn os_crypt BUG=None TEST=see above, it LINKS. R=brettw@chromium.org, dpranke@chromium.org TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/240483005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264688 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Chromium builds shouldn't ask for access to Chrome's own secure data.mark@chromium.org2014-04-031-0/+5
| | | | | | | | | | | | | | | | The message that this presents is: Chromium wants to use your confidential information stored in “Chrome Safe Storage” in your keychain. Do you want to allow access to this item? Chromium shouldn't ask for access to Google Chrome's data, it should have its own Chromium Safe Storage item in the keychain. R=isherman@chromium.org Review URL: https://codereview.chromium.org/200623002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261515 0039d316-1c4b-4281-b951-d872f2087c98
* components: Rename encryptor directory to os_crypt.tfarina@chromium.org2014-03-1816-0/+1091
Joi suggested doing this rename in a follow up CL ( https://codereview.chromium.org/183953005/diff/20001/components/encryptor/encryptor_password_mac.h#newcode16). So here it is. BUG=341293 TEST=None, no functional changes. R=joi@chromium.org,thestig@chromium.org,bcwhite@chromium.org Review URL: https://codereview.chromium.org/200713005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257573 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-05-19 06:13:21 +0000