| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=543161
Review URL: https://codereview.chromium.org/1727033003
Cr-Commit-Position: refs/heads/master@{#383433}
|
|
|
|
|
|
|
|
| |
BUG=543161
Review URL: https://codereview.chromium.org/1703413002
Cr-Commit-Position: refs/heads/master@{#376921}
|
|
|
|
|
|
|
|
|
|
|
| |
The new V4 protocol managers will be spli into a gethash one and an
updates one.
BUG=561867,543161
Review URL: https://codereview.chromium.org/1701893002
Cr-Commit-Position: refs/heads/master@{#375725}
|
|
|
|
|
|
|
|
| |
BUG=561867,543161
Review URL: https://codereview.chromium.org/1658913003
Cr-Commit-Position: refs/heads/master@{#373183}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 2b17e4a37d9c71a1cafdb77688fe344a5034341c.
Original CL: https://codereview.chromium.org/1579403002/
Revert CL: https://codereview.chromium.org/1620813005/
TBR=jochen@chromium.org,blundell@chromium.org
BUG=543161
Review URL: https://codereview.chromium.org/1624723002
Cr-Commit-Position: refs/heads/master@{#373073}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #17 id:300001 of https://codereview.chromium.org/1579403002/ )
Reason for revert:
"buildbot failure in Chromium on Win"
components\safe_browsing_db\safe_browsing_api_handler_util.cc(138) : error C2220: warning treated as error - no 'object' file generated
components\safe_browsing_db\safe_browsing_api_handler_util.cc(138) : warning C4701: potentially uninitialized local variable 'matches' used
components\safe_browsing_db\safe_browsing_api_handler_util.cc(138) : warning C4703: potentially uninitialized local pointer variable 'matches' used
Original issue's description:
> Move remote_db_manager into the safe_browsing_db component.
>
> BUG=543161
>
> Committed: https://crrev.com/bdd302affda19c5b2051d1e868c7045f5614c955
> Cr-Commit-Position: refs/heads/master@{#371034}
TBR=jochen@chromium.org,blundell@chromium.org,nparker@chromium.org,vakh@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=543161
Review URL: https://codereview.chromium.org/1620813005
Cr-Commit-Position: refs/heads/master@{#371050}
|
|
|
|
|
|
|
|
| |
BUG=543161
Review URL: https://codereview.chromium.org/1579403002
Cr-Commit-Position: refs/heads/master@{#371034}
|
|
|
|
|
|
|
|
|
|
|
| |
Also move hit_report into safe_browsing_db since db_manager depends on it.
BUG=543161
R=holte@chromium.org, nasko@chromium.org, nparker@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/1566913002 .
Cr-Commit-Position: refs/heads/master@{#369269}
|
|
|
|
|
|
|
|
| |
BUG=561867
Review URL: https://codereview.chromium.org/1543153002
Cr-Commit-Position: refs/heads/master@{#367732}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=561867
Committed: https://crrev.com/8daf927f2180e209567ea037ed089ac8b319726e
Cr-Commit-Position: refs/heads/master@{#365731}
Committed: https://crrev.com/a5ebe13b7296e79e4724d2c7e54e6fa203ec798a
Cr-Commit-Position: refs/heads/master@{#366340}
Review URL: https://codereview.chromium.org/1526483002
Cr-Commit-Position: refs/heads/master@{#366537}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
#4 id:80001 of https://codereview.chromium.org/1526483002/ )
Reason for revert:
Build failure on Windows. https://build.chromium.org/p/chromium/builders/Win/builds/38538/steps/compile/logs/stdio
Original issue's description:
> Add the Safe Browsing pver4 protocol buffers to Chrome.
>
> BUG=561867
>
> Committed: https://crrev.com/8daf927f2180e209567ea037ed089ac8b319726e
> Cr-Commit-Position: refs/heads/master@{#365731}
>
> Committed: https://crrev.com/a5ebe13b7296e79e4724d2c7e54e6fa203ec798a
> Cr-Commit-Position: refs/heads/master@{#366340}
TBR=vakh@google.com,nparker@chromium.org,awoz@google.com,kcarattini@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=561867
Review URL: https://codereview.chromium.org/1540223002
Cr-Commit-Position: refs/heads/master@{#366347}
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=561867
Committed: https://crrev.com/8daf927f2180e209567ea037ed089ac8b319726e
Cr-Commit-Position: refs/heads/master@{#365731}
Review URL: https://codereview.chromium.org/1526483002
Cr-Commit-Position: refs/heads/master@{#366340}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
#3 id:40001 of https://codereview.chromium.org/1526483002/ )
Reason for revert:
Broke compile on Win and Mac (possibly for different reasons)
https://build.chromium.org/p/chromium/builders/Win/builds/38420
https://build.chromium.org/p/chromium.mac/builders/Mac%20Builder/builds/33499
Original issue's description:
> Add the Safe Browsing pver4 protocol buffers to Chrome.
>
> BUG=561867
>
> Committed: https://crrev.com/8daf927f2180e209567ea037ed089ac8b319726e
> Cr-Commit-Position: refs/heads/master@{#365731}
TBR=vakh@google.com,nparker@chromium.org,awoz@google.com,kcarattini@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=561867
Review URL: https://codereview.chromium.org/1537563003
Cr-Commit-Position: refs/heads/master@{#365744}
|
|
|
|
|
|
|
|
| |
BUG=561867
Review URL: https://codereview.chromium.org/1526483002
Cr-Commit-Position: refs/heads/master@{#365731}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Attempt 2:
1. Pull all code unrelated to chunking from chrome/browser/safe_browsing/safe_browsing_util.h
into components/safe_browsing_db.
2. All code that was formerly under the safe_browsing_util namespace is now under safe_browsing.
That's the only namespace we plan to use going forward.
3. Chunking related code will stay in the old location and removed once we switch to PVER4.
Attempt 1: https://codereview.chromium.org/1420123003/
Reverted as: https://codereview.chromium.org/1410343012/
Reason: There was a compile error on Win64Dbg with the following message:
e:\b\build\slave\win_x64_gn__dbg_\build\src\components\safe_browsing_db\util.cc(225): warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data
Resolution: Updating the BUILD.gn file to ignore that warning for Windows.
BUG=543161
Review URL: https://codereview.chromium.org/1423033009
Cr-Commit-Position: refs/heads/master@{#358168}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #9 id:160001 of https://codereview.chromium.org/1420123003/ )
Reason for revert:
Suspected to break the win compile:
FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64/cl.exe" /nologo /showIncludes /FC @obj/components/safe_browsing_db/util/util.obj.rsp /c ../../components/safe_browsing_db/util.cc /Foobj/components/safe_browsing_db/util/util.obj /Fdobj/components/safe_browsing_db/util_cc.pdb
e:\b\build\slave\win_x64_gn__dbg_\build\src\components\safe_browsing_db\util.cc(225) :error C2220: warning treated as error - no 'object' file generated
Original issue's description:
> 1. Pull all code unrelated to chunking from chrome/browser/safe_browsing/safe_brwsing_util.h into components/safe_browsing_db.
> 2. All code that was formerly under the safe_browsing_util namespace is now under safe_browsing. That's the only namespace we plan to use going forward.
> 3. Chunking related code will stay in the old location and removed once we switch to PVER4.
>
> The next CL in this series will move the structures/enums currently under the global namespace in safe_browsing_db_util.h into safe_browsing. I did not do that as part of this CL to keep it smaller and easier to review.
>
> BUG=543161
>
> Committed: https://crrev.com/154455e8186ad19a8b54ca23e344ade0d92c34cf
> Cr-Commit-Position: refs/heads/master@{#357763}
TBR=mattm@chromium.org,nparker@chromium.org,blundell@chromium.org,thestig@chromium.org,vakh@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=543161
Review URL: https://codereview.chromium.org/1410343012
Cr-Commit-Position: refs/heads/master@{#357804}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/browser/safe_browsing/safe_brwsing_util.h into components/safe_browsing_db.
2. All code that was formerly under the safe_browsing_util namespace is now under safe_browsing. That's the only namespace we plan to use going forward.
3. Chunking related code will stay in the old location and removed once we switch to PVER4.
The next CL in this series will move the structures/enums currently under the global namespace in safe_browsing_db_util.h into safe_browsing. I did not do that as part of this CL to keep it smaller and easier to review.
BUG=543161
Review URL: https://codereview.chromium.org/1420123003
Cr-Commit-Position: refs/heads/master@{#357763}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move prefix_set and parts of safe_browsing_util into a new component
safe_browsing_db.
This component will hold the new implementation for the
next version (pver4) of the update protocol and DB.
BUG=543161
Review URL: https://codereview.chromium.org/1415923004
Cr-Commit-Position: refs/heads/master@{#356943}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
safe_browsing_db. (patchset #7 id:120001 of https://codereview.chromium.org/1399843003/ )
Reason for revert:
Broke the Windows x64 GN builders:
http://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20x64%20GN&number=7560
Original issue's description:
> Move prefix_set and parts of safe_browsing_util into a new component safe_browsing_db.
>
> This component will hold the new implementation for the
> next version (pver4) of the update protocol and DB.
>
> BUG=543161
>
> Committed: https://crrev.com/607ee298239a88fa0823c3aea10bcee83eff855a
> Cr-Commit-Position: refs/heads/master@{#355654}
TBR=nparker@chromium.org,noelutz@chromium.org,droger@chromium.org,thestig@chromium.org,blundell@chromium.org,rsleevi@chromium.org,vakh@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=543161
Review URL: https://codereview.chromium.org/1420143002
Cr-Commit-Position: refs/heads/master@{#355659}
|
|
safe_browsing_db.
This component will hold the new implementation for the
next version (pver4) of the update protocol and DB.
BUG=543161
Review URL: https://codereview.chromium.org/1399843003
Cr-Commit-Position: refs/heads/master@{#355654}
|