summaryrefslogtreecommitdiffstats
path: root/components/suggestions.gypi
Commit message (Collapse)AuthorAgeFilesLines
* SuggestionsService: implement SyncServiceObservertreib2016-03-111-2/+1
| | | | | | | | | | | | so that its clients don't have to. Also remove a bunch of null checks on SuggestionsService - SuggestionsServiceFactory::GetForProfile will never return null. BUG=591973 Review URL: https://codereview.chromium.org/1770843002 Cr-Commit-Position: refs/heads/master@{#380603}
* Refactor VariationsHttpHeaderProvider.asvitkine2015-12-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | The goal is to move the bulk of its implementation to the main variations component, so that it can be used by this CL from JNI: https://codereview.chromium.org/1528543003/ Creates variations_http_headers.cc in net that still needs to depend on net, which uses the http header provider internally. Updates callers of the previous API to use the new simpler API that doesn't require going through the singleton by clients. Additionally, also adds variations/synthetic_trials.h and moves the synthetic trials structs from metrics_service.h to the new file. This works around an otherwise circular dependency between metrics and variations, since variations_http_header_provider.cc depends on synthetic trials. TBRs below are for owners of downstream users of the API which is being updated. BUG=530223 TBR=caitkp@chromium.org,thestig@chromium.org Review URL: https://codereview.chromium.org/1530133005 Cr-Commit-Position: refs/heads/master@{#365991}
* Support needed to measure user and service traffic in Chrome.amohammadkhan2015-09-111-0/+1
| | | | | | | | | | | | | | | | | | | | | | | Some of the traffic of Chrome is not coming from direct request of user and it comes from services running on it such as Sync, Suggestion, or Complete. To understand their contribution to total amount of Chrome traffic, it is necessary to record services traffic use besides the user traffic use. To be able to get more useful data, it is also necessary to record the condition in which the request is made and the response is received. Two important aspects are the connection type (Cellular or Wifi) and application state (Foreground or Background). Also it is helpful to have the distribution of exchanged message size for different directions (Upload or Download). Besides the needed support for measuring, the suggestion service code is instrumented to record its data use. This instrumentation is done as an example and if this CL lands other target services will be instrumented too. BUG=516434 Review URL: https://codereview.chromium.org/1279543002 Cr-Commit-Position: refs/heads/master@{#348490}
* [Suggestions] Headers cleanup for iOS image encodermathp2014-10-101-2/+1
| | | | | | | | BUG=None Review URL: https://codereview.chromium.org/649793002 Cr-Commit-Position: refs/heads/master@{#299188}
* [Suggestions] Introduce a different image encoder/decoder for iOSmathp2014-10-101-0/+13
| | | | | | | | | | | This introduces the new files and dependencies (not used yet). A further improvement will be to switch to use gfx::Image. TBR=senorblanco BUG=409156 Review URL: https://codereview.chromium.org/641513003 Cr-Commit-Position: refs/heads/master@{#299158}
* Revert of [Suggestions] Create ImageEncoder, to abstract away image ↵mathp2014-10-081-19/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | encode/decode. (patchset #4 id:170001 of https://codereview.chromium.org/630073002/) Reason for revert: It is no longer needed, we decided on a different approach. Original issue's description: > [Suggestions] Create ImageEncoder, to abstract away image encode/decode. > > iOS can't depend on JPEG encoder. > > TBR=jam > BUG=387751,409156 > > Committed: https://crrev.com/f5e2e2fa7303d699027095cd9b7cfb9462b585f6 > Cr-Commit-Position: refs/heads/master@{#298510} TBR=huangs@chromium.org,blundell@chromium.org,jam@chromium.org NOTREECHECKS=true NOTRY=true BUG=387751,409156 Review URL: https://codereview.chromium.org/634273002 Cr-Commit-Position: refs/heads/master@{#298706}
* [Suggestions] Create ImageEncoder, to abstract away image encode/decode.mathp2014-10-071-1/+19
| | | | | | | | | | | iOS can't depend on JPEG encoder. TBR=jam BUG=387751,409156 Review URL: https://codereview.chromium.org/630073002 Cr-Commit-Position: refs/heads/master@{#298510}
* [Fixed] [Suggestions] Move ImageManager to the componentmathp2014-09-291-0/+4
| | | | | | | | | | | | | | One (1!) line fix to remove Valgrind issue. Original review https://codereview.chromium.org/543753002/ Keeps the fetcher functionality as ImageFetcherImpl in chrome/browser/search/suggestions. BUG=387751 TBR=blundell TEST=ImageManagerTest,ImageFetcherBrowserTest Review URL: https://codereview.chromium.org/607183002 Cr-Commit-Position: refs/heads/master@{#297177}
* Revert of [Suggestions] Move ImageManager to the component (patchset #6 ↵thestig2014-09-241-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | id:220001 of https://codereview.chromium.org/543753002/) Reason for revert: One of the new unit tests failed with uninit memory access: http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%282%29/builds/43137/ Original issue's description: > [Suggestions] Move ImageManager to the component > > Keeps the fetcher functionality as ImageFetcherImpl in chrome/browser/search/suggestions. > > BUG=387751 > TBR=blundell > TEST=ImageManagerTest,ImageFetcherBrowserTest > > Committed: https://crrev.com/5a25f30080dd57d200679546c970d70f2247def9 > Cr-Commit-Position: refs/heads/master@{#296503} TBR=huangs@chromium.org,blundell@chromium.org,mathp@chromium.org NOTREECHECKS=true NOTRY=true BUG=387751 Review URL: https://codereview.chromium.org/600203002 Cr-Commit-Position: refs/heads/master@{#296553}
* [Suggestions] Move ImageManager to the componentmathp2014-09-241-0/+4
| | | | | | | | | | | | Keeps the fetcher functionality as ImageFetcherImpl in chrome/browser/search/suggestions. BUG=387751 TBR=blundell TEST=ImageManagerTest,ImageFetcherBrowserTest Review URL: https://codereview.chromium.org/543753002 Cr-Commit-Position: refs/heads/master@{#296503}
* [Most Visited] Check for Sync state when using SuggestionsService.mathp@chromium.org2014-08-211-0/+2
| | | | | | | | | | | | BUG=386454 R=manzagop@chromium.org, newt@chromium.org TBR=erikwright TEST=SuggestionsServiceTest Review URL: https://codereview.chromium.org/473123002 Cr-Commit-Position: refs/heads/master@{#291116} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291116 0039d316-1c4b-4281-b951-d872f2087c98
* [Suggestions] Moving suggestions code to a new componentmathp@chromium.org2014-07-251-0/+42
Adding base::StatisticsRecorder::Initialize() to run_all_unittests to mirror another change we had made to the content test suite in https://codereview.chromium.org/330473003/ BUG=387751 TEST=Suggestions*,Blacklist* Review URL: https://codereview.chromium.org/410673002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285598 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-05-19 03:52:28 +0000