| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
TBR=waffles
Review URL: https://codereview.chromium.org/1291223003
Cr-Commit-Position: refs/heads/master@{#344012}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove StringToLowerASCII. This removes the template and makes a consistent call that can take a string piece.
http_response_headers.cc in HttpResponseHeaders::RemoveHeaderLine there seemed to be a bug where it did
std::string old_header_name_lowercase(name);
where it actually meant
std::string old_header_name_lowercase(old_header_name);
I fixed this.
There were a number of cases where url.host() or url.scheme() was passed to ToLowerASCII. These are already guaranteed lower-case, so I removed the call.
There were a number of cases in net that did return ToLowerASCII().c_str() when the return type is a std::string, which is unnecessary and wasteful. I removed the c_str() call.
NOPRESUBMIT=true
(for touching code with wstrings)
Review URL: https://codereview.chromium.org/1282363003
Cr-Commit-Position: refs/heads/master@{#342869}
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were using the same logic with two different implementations
in both extensions/ and components/update_client, so this lets us
share the same code.
BUG=490418
Review URL: https://codereview.chromium.org/1235593007
Cr-Commit-Position: refs/heads/master@{#340566}
|
|
|
|
|
|
|
|
| |
BUG=510561
Review URL: https://codereview.chromium.org/1225413006
Cr-Commit-Position: refs/heads/master@{#338991}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clang warns if there are missing braces around a subobject
initializer. The most common idiom that triggers this is:
STRUCT s = {0};
if the first field of STRUCT is itself a struct. This can
be more simply written as:
STRUCT s = {};
which also prevents the warning from firing.
BUG=505297
Review URL: https://codereview.chromium.org/1210153013
Cr-Commit-Position: refs/heads/master@{#337433}
|
|
|
|
|
|
|
|
| |
BUG=498054
Review URL: https://codereview.chromium.org/1171683003
Cr-Commit-Position: refs/heads/master@{#333509}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since UpdateChecker gets its url configuration from the TestConfigurator,
some of its unit tests will fail is the TestConfigurator is misconfigured
to return an empty list of urls.
Returning no update urls is still an invalid configuration. Whether to allow this case or not is still an open question at this moment.
BUG=497332
Review URL: https://codereview.chromium.org/1166243002
Cr-Commit-Position: refs/heads/master@{#333408}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is everything but the chrome directory
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=zelidrag@chromium.org (chromeos)
TBR=keybuk@chromium.org (device/bluetooth)
Review URL: https://codereview.chromium.org/1162943002
Cr-Commit-Position: refs/heads/master@{#332626}
|
|
|
|
|
|
|
|
|
|
|
| |
We changed the way download callbacks are called and how the instance
of the CRX downloader is owned.
BUG=495426
Review URL: https://codereview.chromium.org/1156893007
Cr-Commit-Position: refs/heads/master@{#332505}
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was mostly autogenerated with
https://codereview.chromium.org/1010073002/.
BUG=465354
Review URL: https://codereview.chromium.org/1144153004
Cr-Commit-Position: refs/heads/master@{#332440}
|
|
|
|
|
|
|
|
| |
BUG=493393
Review URL: https://codereview.chromium.org/1159923009
Cr-Commit-Position: refs/heads/master@{#331884}
|
|
|
|
|
|
|
|
|
|
| |
a memory leak in some cases (see https://code.google.com/p/chromium/issues/detail?id=273800).
BUG=492450,450337
Review URL: https://codereview.chromium.org/1162433002
Cr-Commit-Position: refs/heads/master@{#331627}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The goal of this change is to re-implement the component updater by
reusing the common code in components/update_client while keeping
the its public interface the same as before, in order to minimize
changes in its existing clients.
BUG=450337
Review URL: https://codereview.chromium.org/1133443002
Cr-Commit-Position: refs/heads/master@{#331412}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Most interfaces were storing the object in a scoped_ptr already. This
adjusts the API so that it is a little clearer of the ownership
transfer.
A number of clients put the URLFetcher in a table and do memory
management on it themselves; this is likely templatable code
for a future CL. The scope of this CL was to change the API but
no control flow changes. Making this change found one memory leak;
(http://crbug.com/482459) has been addressed separately.
BUG=371201
TESTS=net_unittests google_api_unittests
TBR=jochen@chromium.org, thakis@chromium.org, oshima@chromium.org, armansito@chromium.org, reillyg@chromium.org, rogerta@chromium.org, stuartmorgan@chromium.org, wez@chromium.org, pavely@chromium.org, rouslan@chromium.org
Review URL: https://codereview.chromium.org/1117703002
Cr-Commit-Position: refs/heads/master@{#327901}
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.
This patch was manually generated using a regex and a text editor.
BUG=417463
Review URL: https://codereview.chromium.org/1056633004
Cr-Commit-Position: refs/heads/master@{#327312}
|
|
|
|
|
|
|
|
| |
BUG=479904
Review URL: https://codereview.chromium.org/1112623002
Cr-Commit-Position: refs/heads/master@{#327311}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a mechanical change.
The idea here is that we want to simplify the directory tree of
the component updater files and easily see what compilation unit has
tests and which one does not.
This change includes some whitespace changes due to running git cl format.
BUG=479904
Review URL: https://codereview.chromium.org/1102103002
Cr-Commit-Position: refs/heads/master@{#327054}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The changes not under update_client are mechanical.
This change creates a working UpdateClient updater client, which can be reused by both component and extension updaters.
This code is not hooked up yet with any of the updaters above.
Those changes will be committed in the near future by other CLs.
R=waffles,erikwright,agl,dgarrett,jhawkins,brettw
BUG=450337
Committed: https://crrev.com/ba6742df55de47568e3aa438378d844a7439c391
Cr-Commit-Position: refs/heads/master@{#325006}
Review URL: https://codereview.chromium.org/1055903003
Cr-Commit-Position: refs/heads/master@{#325658}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #3 id:40001 of https://codereview.chromium.org/1055903003/)
Reason for revert:
Performance regression: chrome-si/initializers (14.29%)
http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/1504/steps/sizes/logs/stdio
# Static initializers in src/out/Release/chrome:
# HINT: To get this list, run tools/linux/dump-static-initializers.py
# HINT: diff against the log from the last run to see what changed
# atomicops_internals_x86.cc .L.str
# atomicops_internals_x86.cc _GLOBAL__sub_I_atomicops_internals_x86.cc+0x78
# atomicops_internals_x86.cc _GLOBAL__sub_I_atomicops_internals_x86.cc+0xed
# atomicops_internals_x86.cc (anonymous namespace)::google_initializer_module_atomicops_x86
# atomicops_internals_x86.cc GoogleInitializer::~GoogleInitializer()
# atomicops_internals_x86.cc __cxa_atexit@plt [registers a dtor to run at exit]
# atomicops_internals_x86.cc __init_array_end+0x3250
# atomicops_internals_x86.cc __init_array_end+0x34f0
# atomicops_internals_x86.cc __stack_chk_fail@plt
# atomicops_internals_x86.cc strcmp@plt
# atomicops_internals_x86_gcc.cc .L.str
# atomicops_internals_x86_gcc.cc _GLOBAL__sub_I_atomicops_internals_x86_gcc.cc+0x69
# atomicops_internals_x86_gcc.cc _GLOBAL__sub_I_atomicops_internals_x86_gcc.cc+0xb5
# atomicops_internals_x86_gcc.cc google::protobuf::internal::AtomicOps_Internalx86CPUFeatures
# atomicops_internals_x86_gcc.cc google::protobuf::internal::AtomicOps_Internalx86CPUFeatures+0x1
# atomicops_internals_x86_gcc.cc __stack_chk_fail@plt
# atomicops_internals_x86_gcc.cc strcmp@plt
# atomicops_internals_x86_gcc.cc .L.str
# atomicops_internals_x86_gcc.cc _GLOBAL__sub_I_atomicops_internals_x86_gcc.cc+0x62
# atomicops_internals_x86_gcc.cc _GLOBAL__sub_I_atomicops_internals_x86_gcc.cc+0x9e
# atomicops_internals_x86_gcc.cc v8::base::AtomicOps_Internalx86CPUFeatures
# atomicops_internals_x86_gcc.cc __stack_chk_fail@plt
# atomicops_internals_x86_gcc.cc strcmp@plt
# component_updater_service.cc std::ios_base::Init::Init()@plt
# component_updater_service.cc std::__ioinit [#includes <iostream>, use <ostream> instead]
# component_updater_service.cc __cxa_atexit@plt [registers a dtor to run at exit]
# component_updater_service.cc __init_array_end+0x34f0
# component_updater_service.cc __init_array_end+0x4608
# debugallocation_shim.cc module_enter_exit_hook
# debugallocation_shim.cc (anonymous namespace)::large_alloc_threshold
# debugallocation_shim.cc TCMallocGuard::TCMallocGuard()
# debugallocation_shim.cc __cxa_atexit@plt [registers a dtor to run at exit]
# debugallocation_shim.cc __init_array_end+0x34e8
# debugallocation_shim.cc __init_array_end+0x34f0
# debugallocation_shim.cc __init_array_end+0x34f8
# memory_region_map.cc libpthread_initialized
# spinlock.cc _GLOBAL__sub_I_spinlock.cc+0x12
# spinlock.cc NumCPUs()
# spinlock.cc adaptive_spin_count
# spinlock_internal.cc _GLOBAL__sub_I_spinlock_internal.cc+0x79
# spinlock_internal.cc have_futex
# spinlock_internal.cc futex_private_flag
# spinlock_internal.cc syscall@plt
# Found 43 static initializers in 8 files.
Original issue's description:
> Implement common code for component and extension updaters.
>
> The changes not under update_client are mechanical.
>
> This change creates a working UpdateClient updater client, which can be reused by both component and extension updaters.
>
> This code is not hooked up yet with any of the updaters above.
> Those changes will be committed in the near future by other CLs.
>
> R=waffles,erikwright,agl,dgarrett,jhawkins,brettw
>
> BUG=450337
>
> Committed: https://crrev.com/ba6742df55de47568e3aa438378d844a7439c391
> Cr-Commit-Position: refs/heads/master@{#325006}
TBR=agl@chromium.org,dgarrett@chromium.org,erikwright@chromium.org,waffles@chromium.org,dgarrett@google.com,jhawkins@chromium.org,brettw@chromium.org,wfh@chromium.org,sorin@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=450337
Review URL: https://codereview.chromium.org/1085643003
Cr-Commit-Position: refs/heads/master@{#325015}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The changes not under update_client are mechanical.
This change creates a working UpdateClient updater client, which can be reused by both component and extension updaters.
This code is not hooked up yet with any of the updaters above.
Those changes will be committed in the near future by other CLs.
R=waffles,erikwright,agl,dgarrett,jhawkins,brettw
BUG=450337
Review URL: https://codereview.chromium.org/1055903003
Cr-Commit-Position: refs/heads/master@{#325006}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The existing code was leading to a crash:
- NTPResourceCache has a callback subscription on PromoResourceService
- PromoResourceService was deleted before NTPResourceCache
- When the NTPResourceCache was destroyed, it tried to remove itself
from the callback list, which no longer exists and crashes.
The bug was introduced by
https://codereview.chromium.org/926633002
This CL changes the destruction order so that the PromoResourceService
is deleted after NTPResourceCache (which is a keyed service and thus is
tied to the profile).
BUG=464391
Review URL: https://codereview.chromium.org/988433002
Cr-Commit-Position: refs/heads/master@{#319491}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL removes the Deserializer functionality from ValueSerializer,
and puts into separate class ValueDeserializer, so that class responsibility
is maintained.
BUG=455453
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/925783002
Cr-Commit-Position: refs/heads/master@{#319239}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Followup to
https://codereview.chromium.org/658383003 (constrained_window)
https://codereview.chromium.org/808773005 (component_updater and
update_client)
This fixes warnings in gyp's msvs-ninja generator.
R=blundell@chromium.org,oshima@chromium.org,sorin@chromium.org
BUG=459058,410499
Review URL: https://codereview.chromium.org/952543002
Cr-Commit-Position: refs/heads/master@{#317589}
|
|
|
|
|
|
|
|
|
|
|
|
| |
For tools/sort_sources.py to be useful, existing GN files
should be sorted.
BUG=456014
TEST=everything should build as before
Review URL: https://codereview.chromium.org/934483002
Cr-Commit-Position: refs/heads/master@{#316447}
|
|
|
|
|
|
|
|
|
|
|
|
| |
SupervisedUserWhitelistInstaller.
TBR=agl@chromium.org
BUG=436459
Review URL: https://codereview.chromium.org/879993005
Cr-Commit-Position: refs/heads/master@{#315246}
|
|
|
|
|
|
|
|
|
|
| |
Before this CL, component installers were leaked in almost all cases. If we allow uninstalling components (see https://codereview.chromium.org/879993005/), we need to fix those leaks.
BUG=436459
Review URL: https://codereview.chromium.org/897873002
Cr-Commit-Position: refs/heads/master@{#314701}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
jam: please review the changes under //src/chrome/browser
blundell: please review the changes under //src/components
waffles: please review the component updater and the update client changes.
The intention here is to move most of the component updater dependencies to update_client, with the goal of creating an update_client Chrome component that encapsulates the details of talking with the update servers, downloading, and invoking installers of CRXs for both extensions and components.
The dependencies should be: component_updater->update_client.
This change just lays down some of the code that will be further used by update_client. No functionality is provided in this change. Also consider the overall goal as WIP; therefore, some of the naming and dependencies are not final. We want to have most of the code in place for future work, but want to minimize the changes to the existing production code and keep the refactoring mechanical for this change.
BUG=450337
Review URL: https://codereview.chromium.org/808773005
Cr-Commit-Position: refs/heads/master@{#312986}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/852643003
Cr-Commit-Position: refs/heads/master@{#311395}
|
|
This is a mechanical change.
The idea here is to refactor the common code involved in installing
components and extensions in a common module. In the future, we want
more update-related Chrome stuff to go in this module.
Therefore, it is desirable that this module have a name that describes
its purpose.
BUG=445949
Review URL: https://codereview.chromium.org/803313003
Cr-Commit-Position: refs/heads/master@{#310022}
|