| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=586596
Review URL: https://codereview.chromium.org/1703173002
Cr-Commit-Position: refs/heads/master@{#377370}
|
|
|
|
|
|
|
|
|
|
| |
Tests are not added, since it's not final version yet.
BUG=444283
Review URL: https://codereview.chromium.org/1643203002
Cr-Commit-Position: refs/heads/master@{#373804}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a search-and-replace update for includes with "base/prefs" ->
"components/prefs" and the headers re-sorted.
DEPS files were updated to allow the components in question to depend on
components/prefs.
This should be a no-op from a build perspective.
BUG=583034
Review URL: https://codereview.chromium.org/1651203002
Cr-Commit-Position: refs/heads/master@{#372780}
|
|
|
|
|
|
|
|
|
|
| |
Updates references from //base:prefs to //components/prefs/
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/1652573002
Cr-Commit-Position: refs/heads/master@{#372540}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
scoped_ptr is more convertible to bool than std::unique_ptr.
bool x = scoped_ptr<int>(); // compiles
bool y = std::unique_ptr<int>(); // explodes
std::unique_ptr is not streamable:
LOG(ERROR) << scoped_ptr<int>(); // compiles
LOG(ERROR) << std::unique_ptr<int>(); // explodes
BUG=579269,579270
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1609923002
Cr-Commit-Position: refs/heads/master@{#370266}
|
|
|
|
|
|
|
|
|
|
| |
BUG=557422
R=avi@chromium.org
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/1548203002
Cr-Commit-Position: refs/heads/master@{#366914}
|
|
|
|
|
|
|
|
|
| |
BUG=138542
TBR=blundell@chromium.org
Review URL: https://codereview.chromium.org/1549993003
Cr-Commit-Position: refs/heads/master@{#366870}
|
|
|
|
|
|
|
|
|
|
| |
them effectively and efficiently.
BUG=568998
Review URL: https://codereview.chromium.org/1519043002
Cr-Commit-Position: refs/heads/master@{#365465}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The recent formatter alphebetizing change is causing a lot of noise in
code reviews. Figured it'd be worth a clean-up CL.
Exact command I ran:
find . -name "*.gn*" -exec gn format --in-place "{}" \;
TBR=ddorwin@chromium.org
BUG=554928
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1464873002
Cr-Commit-Position: refs/heads/master@{#360891}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Passing std::string by reference can prevent extra copying of object.
BUG=367418
TEST=
R=blundell@chromium.org,jochen@chromium.org,sdefresne@chromium.org
Review URL: https://codereview.chromium.org/1355983002
Cr-Commit-Position: refs/heads/master@{#351023}
|
|
|
|
|
|
|
|
|
| |
BUG=None
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/1303183004
Cr-Commit-Position: refs/heads/master@{#345632}
|
|
|
|
|
|
|
|
|
| |
BUG=500085
TBR=bauerb@chromium.org
Review URL: https://codereview.chromium.org/1294593003
Cr-Commit-Position: refs/heads/master@{#343972}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replaces
base::StringToLowerASCII(string)
with
base::ToLowerASCII(string)
This form is 1:1 search and replace.
A bunch of places did something like this:
std::string foo(something_else);
base::StringToLowerASCII(&foo);
which became:
foo = base::ToLowerASCII(something_else);
A couple places really wanted in-place changing and they became:
foo = base::ToLowerASCII(foo);
There was pretty trivial cleanup in chrome_main_delegate.cc chrome/test/chromedriver/server/http_handler.cc (fix indenting).
There was more cleanup in:
chrome/installer/util/language_selector.cc and components/plugins/renderer/mobile_youtube_plugin.cc
In components/history/core/browser/url_utils.cc I removed the call since it was calling ToLower on the host name out of a GURL, which is already guaranteed to be lower-case.
NOPRESUBMIT=true
(due to touching code with wstrings)
Review URL: https://codereview.chromium.org/1279123004
Cr-Commit-Position: refs/heads/master@{#342659}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Componentize //chrome/browser/prefs/tracked and
updated corresponding .gypi files for same.
Moved the files from //chrome/browser/prefs/tracked
to //components/user_prefs/tracked.
Also added new //components/user_prefs/pref_names.* file and added BUILD.gn for same
BUG=507660
Review URL: https://codereview.chromium.org/1227973003
Cr-Commit-Position: refs/heads/master@{#342588}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1258653002/)
Reason for revert:
Try to fix UserPrefs::Get() crashes.
Original issue's description:
> components: Make user_prefs a source_set.
>
> This is a tiny component, it does not need to be a shared libray in the
> component build.
>
> BUG=None
> R=brettw@chromium.org
>
> Committed: https://crrev.com/f8a72db8313967a512ea94c05b3951c255a4b796
> Cr-Commit-Position: refs/heads/master@{#340349}
TBR=brettw@chromium.org,tfarina@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None
Review URL: https://codereview.chromium.org/1254123002
Cr-Commit-Position: refs/heads/master@{#340401}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a tiny component, it does not need to be a shared libray in the
component build.
BUG=None
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/1258653002
Cr-Commit-Position: refs/heads/master@{#340349}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tested on Linux with the following command lines:
$ gn gen out-gn/Debug
$ gn check out-gn/Debug //components/os_crypt/*
$ gn check out-gn/Debug //components/user_prefs/*
BUG=367595, 376000
TEST=see above
R=brettw@chromium.org,mnissler@chromium.org
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/1213713002
Cr-Commit-Position: refs/heads/master@{#336414}
|
|
|
|
|
|
|
|
|
|
|
| |
As part of this CL, the dependency of //components/user_prefs
on //content is removed.
TBR=rlp, estade
Review URL: https://codereview.chromium.org/1062083003
Cr-Commit-Position: refs/heads/master@{#325401}
|
|
|
|
|
|
|
|
|
| |
BUG=417463
TBR=blundell@chromium.org
Review URL: https://codereview.chromium.org/666133002
Cr-Commit-Position: refs/heads/master@{#300456}
|
|
|
|
|
|
|
|
|
|
|
| |
This doesn't hook up visitedlink_renderer since it depends on blink.
BUG=
R=jamesr@chromium.org
Review URL: https://codereview.chromium.org/340953004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The reason for doing this is that user_prefs depends on content_browser,
which brings a lot of extra dependencies that takes a lot of time to build
(yeah, I'm looking at you Blink and V8) and bookmarks is one of the targets
that should not depend on content.
BUG=359565
TEST=green trybots
R=blundell@chromium.org, sky@chromium.org, yoz@chromium.org
Review URL: https://codereview.chromium.org/271793003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
NOTRY=True
Review URL: https://codereview.chromium.org/157673002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
use the base:: namespace.
BUG=88666
TEST=no change
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/108603005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Written from https://codereview.chromium.org/12092021
The entire source code was surveyed for existing list/dict prefs for which this change could be problematic, it doesn't look like anything is relying on this internal detail of the API, see this for details: https://docs.google.com/a/chromium.org/spreadsheet/ccc?key=0AtwXJ4IPPZBAdG9rX3RTc3k5Z1pyN3U4b3d4Tkota3c#gid=0
TBR=joth (for minor android_webview side-effects)
BUG=323346
Review URL: https://codereview.chromium.org/81183005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=245050
R=joth@chromium.org,thestig@chromium.org,joi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16625004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=180785
R=joi@chromium.org
TBR=darin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/14622003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
instead of Profile. This will help move it out of chrome.
BUG=227219
Review URL: https://codereview.chromium.org/14141006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/13973004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Priority preferences are similar to normal preferences but are never encrypted and are synced ahead of other datatypes. Because they're never encrypted, on first sync, they can be synced immediately after login, before the user is prompted for a passphrase.
Expected uses of priority preferences include hardware setting (eg. trackpad speed, scroll direction, etc.) as well as settings that could be 2-way synced with existing Google Account settings (eg. language).
BUG=168648
Review URL: https://chromiumcodereview.appspot.com/12033093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to COMDAT folding.
BUG=none
Review URL: https://codereview.chromium.org/12529029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Fix typo: s/tof/to
- Single-argument constructors should be marked explicit.
- Remove unused scoped_ptr.h include from user_prefs.h
- Reorder ctor/dtor implementations in the source file to match with the order
declared in the header file.
BUG=138280
TBR=joi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12638007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
The user_prefs component provides:
a) The UserPrefs class, used to map PrefService objects to BrowserContext. This addresses a TODO to get rid of PrefServiceFromBrowserContext from base/prefs/pref_service.h, where clearly a mention of a content class did not belong.
b) A place for PrefRegistrySyncable to live, where it can be used by components that need to register prefs.
We also use (b) in this change to eliminate Autofill's dependency on chrome/browser/prefs. Work is ongoing to move Autofill to //components/autofill.
TBR=ben@chromium.org
BUG=155525,140037
Review URL: https://chromiumcodereview.appspot.com/12340111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186301 0039d316-1c4b-4281-b951-d872f2087c98
|