| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
The components test setup needs to register browserJNI calls but this is not part of the content API. This makes a new content test wrapper API for doing this.
This change fixes the components tests "gn check" failures so these targets can now be added to the whitelist.
Cleans up the components/test DEPS file. The dependency allowances for this directory are quite wide so whitelisting every header file, as was done before, was needlessly complicated.
Review URL: https://codereview.chromium.org/1485893003
Cr-Commit-Position: refs/heads/master@{#362476}
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=138542
Committed: https://crrev.com/0d94fda8c494d7a6c27d065d782f42e99d834f46
Cr-Commit-Position: refs/heads/master@{#362431}
Review URL: https://codereview.chromium.org/1475803002
Cr-Commit-Position: refs/heads/master@{#362472}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Without this I readily hit the timeout in a debug build on windows.
BUG=none
TEST=none
R=sadrul@chromium.org
Review URL: https://codereview.chromium.org/1490843002
Cr-Commit-Position: refs/heads/master@{#362466}
|
|
|
|
|
|
|
|
| |
BUG=543405
Review URL: https://codereview.chromium.org/1484073003
Cr-Commit-Position: refs/heads/master@{#362461}
|
|
|
|
|
|
|
|
|
|
|
|
| |
We don't know for sure whether sync will succeed at starting up at
initialization time, but we can inspect and report on the state of
various flags.
BUG=555113
Review URL: https://codereview.chromium.org/1463583008
Cr-Commit-Position: refs/heads/master@{#362455}
|
|
|
|
|
|
|
|
| |
BUG=524269
Review URL: https://codereview.chromium.org/1490833002
Cr-Commit-Position: refs/heads/master@{#362451}
|
|
|
|
|
|
|
|
|
|
| |
ownership tweak, and adding a few stub methods.
BUG=543405
Review URL: https://codereview.chromium.org/1478593002
Cr-Commit-Position: refs/heads/master@{#362450}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1475803002/ )
Reason for revert:
missed one :(
Original issue's description:
> Remove kuint16max.
>
> BUG=138542
>
> Committed: https://crrev.com/0d94fda8c494d7a6c27d065d782f42e99d834f46
> Cr-Commit-Position: refs/heads/master@{#362431}
TBR=treib@chromium.org,mark@chromium.org,sergeyu@chromium.org,bartfab@chromium.org,rsleevi@chromium.org,sky@chromium.org,cpu@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=138542
Review URL: https://codereview.chromium.org/1485853003
Cr-Commit-Position: refs/heads/master@{#362444}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before this change, the renderer process leaks a file descriptor every
time a PNaCl translator process is launched or a (P)NaCl process runs
without calling the ppapi_start() API.
There was no leak on Windows, because client-side IPC::ChannelHandles
fill out the "name" field rather than the "pipe.handle" field.
BUG=302078
TEST=Run an invalid pexe repeatedly and manually inspect /proc/PID/fd
of the renderer process.
Review URL: https://codereview.chromium.org/1473513005
Cr-Commit-Position: refs/heads/master@{#362440}
|
|
|
|
|
|
|
|
|
|
| |
from the installer as well as chrome, and set them on installer startup.
BUG=558552
Review URL: https://codereview.chromium.org/1481933002
Cr-Commit-Position: refs/heads/master@{#362437}
|
|
|
|
|
|
|
|
|
|
| |
This is not a fatal error and it's causing an unclean shutdown in mustash.
BUG=none
Review URL: https://codereview.chromium.org/1480363004
Cr-Commit-Position: refs/heads/master@{#362436}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed MimeUtil::media_map_ by using media_format_map_ instead.
Removed common_media_types/proprietary_media_types, since they are duplicated in format_codec_mappings.
Added a new COMMON/PROPRIETARY flag to each media format mapping instead.
BUG=461012
Review URL: https://codereview.chromium.org/1472443003
Cr-Commit-Position: refs/heads/master@{#362434}
|
|
|
|
|
|
|
|
|
|
|
| |
apk_deps has been causing some unneccesary confusion.
BUG=558193
R=tfarina@chromium.org,brettw@chromium.org
Review URL: https://codereview.chromium.org/1465923002
Cr-Commit-Position: refs/heads/master@{#362432}
|
|
|
|
|
|
|
|
| |
BUG=138542
Review URL: https://codereview.chromium.org/1475803002
Cr-Commit-Position: refs/heads/master@{#362431}
|
|
|
|
|
|
|
|
|
|
|
|
| |
The client crashes if the deletion fails
BUG=none
TEST=none
R=ben@chromium.org
Review URL: https://codereview.chromium.org/1485713003
Cr-Commit-Position: refs/heads/master@{#362420}
|
|
|
|
|
|
|
|
|
|
|
| |
To make grepping mentioned in http://crbug.com/561749#c4 easier.
BUG=562554
R=vasilii@chromium.org
Review URL: https://codereview.chromium.org/1488003002
Cr-Commit-Position: refs/heads/master@{#362400}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
By default the timer task queue for background pages is throttled with
tasks aligned to run once per second. If chrome is run with the
--disable-background-timer-throttling command line flag then this
throttling is disabled. This should be useful when using chrome to
test javascript.
BUG=485425
Review URL: https://codereview.chromium.org/1478313002
Cr-Commit-Position: refs/heads/master@{#362399}
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to share the registration of prefs::kEnabledLabsExperiments,
move it to flags_ui component, in PrefServiceFlagsStorage which happens
to be the sole user of that preference.
BUG=551954
Review URL: https://codereview.chromium.org/1482963002
Cr-Commit-Position: refs/heads/master@{#362398}
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome allows the use of C++11 features now, so just use rvalue
references directly.
BUG=543901
Review URL: https://codereview.chromium.org/1407443002
Cr-Commit-Position: refs/heads/master@{#362394}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL updates the Web Push encryption implementation to track PR5
or the HTTP Encryption coding draft:
https://goo.gl/MEajcj
A 12-byte random number has been added as a symmetric secret shared
by the user agent and the application server. The IKM used for
deriving the content encryption key and the nonce will be an HKDF
of the raw key and this number when used.
Web Push will always require this authentication to be used.
BUG=486040
Review URL: https://codereview.chromium.org/1456983004
Cr-Commit-Position: refs/heads/master@{#362386}
|
|
|
|
|
|
|
|
|
|
|
| |
This is so it matches the interface name and fixes the vabr's TODO.
BUG=515108
R=vabr@chromium.org
Review URL: https://codereview.chromium.org/1485493003
Cr-Commit-Position: refs/heads/master@{#362384}
|
|
|
|
|
|
|
|
|
|
| |
Checks the happy path of subscribing to push, receiving a push message, and showing a notification. More scenarios to be added later.
BUG=558402
Review URL: https://codereview.chromium.org/1471193006
Cr-Commit-Position: refs/heads/master@{#362371}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
#1 id:1 of https://codereview.chromium.org/1490713002/ )
Reason for revert:
Speculative revert did not help. Relanding.
Original issue's description:
> Revert of Convert enable_pre_sync_backup flag to new flags system. (patchset #2 id:20001 of https://codereview.chromium.org/1487873003/ )
>
> Reason for revert:
> Speculative revert, CrOS compile broken, more info on the bug.
> BUG=563927
>
> Original issue's description:
> > Convert enable_pre_sync_backup flag to new flags system.
> >
> > This flag's usage is very isolated so is a good candidate for the new system. There is now a generated header for the #define rather than a global define.
> >
> > Reland of http://crrev.com/1478623004#ps60001
> > TBR=zea@chromium.org
> >
> > Committed: https://crrev.com/db7f9756dc6e236589b90c76d6fa0f1244601e78
> > Cr-Commit-Position: refs/heads/master@{#362365}
>
> TBR=zea@chromium.org,brettw@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/3c201fa28b53246177fed8d6b9454da4b0625df2
> Cr-Commit-Position: refs/heads/master@{#362368}
TBR=zea@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=563927
Review URL: https://codereview.chromium.org/1490723002
Cr-Commit-Position: refs/heads/master@{#362369}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
#2 id:20001 of https://codereview.chromium.org/1487873003/ )
Reason for revert:
Speculative revert, CrOS compile broken, more info on the bug.
BUG=563927
Original issue's description:
> Convert enable_pre_sync_backup flag to new flags system.
>
> This flag's usage is very isolated so is a good candidate for the new system. There is now a generated header for the #define rather than a global define.
>
> Reland of http://crrev.com/1478623004#ps60001
> TBR=zea@chromium.org
>
> Committed: https://crrev.com/db7f9756dc6e236589b90c76d6fa0f1244601e78
> Cr-Commit-Position: refs/heads/master@{#362365}
TBR=zea@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1490713002
Cr-Commit-Position: refs/heads/master@{#362368}
|
|
|
|
|
|
|
|
|
|
|
| |
This flag's usage is very isolated so is a good candidate for the new system. There is now a generated header for the #define rather than a global define.
Reland of http://crrev.com/1478623004#ps60001
TBR=zea@chromium.org
Review URL: https://codereview.chromium.org/1487873003
Cr-Commit-Position: refs/heads/master@{#362365}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously I bundled two changes ("bug fixes") into one experiment.
The results of that experiment are murky; it's likely that one
change or the other is working cross-purposes. i.e., one of those
things I called bugs might be good for users. This change separates
the bundled bug fix into two separate experiments to tease out their
individual effects.
Tested using --force-fieldtrial-params=
BUG=369989
Review URL: https://codereview.chromium.org/1485583003
Cr-Commit-Position: refs/heads/master@{#362361}
|
|
|
|
|
|
|
|
|
|
| |
name starts with Enabled.
BUG=563806
Review URL: https://codereview.chromium.org/1485673004
Cr-Commit-Position: refs/heads/master@{#362347}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TaskGraphWorkQueue.
There are two new classes:
SynchronousTaskGraphRunner - used in some tests and by LayerTreeHostImpl
SingleThreadTaskGraphRunner - used in a number of tests (wrapped by TestTaskGraphRunner) and by GpuProcessTransportFactory and CompositorImplAndroid.
Additionally RasterWorkerPool has been re-worked to use the new helper.
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1449133002
Cr-Commit-Position: refs/heads/master@{#362338}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
C++ 11 enables containers that contain move-only type, scoped_ptr.
So, Use std::map<key, scoped_ptr<Foo>> instead of ScopedPtrMap.
Also, address below C++11 features.
* .Pass() -> std::move for scoped_ptr instances
* typedef -> type alias (using)
BUG=554291, 557422
Review URL: https://codereview.chromium.org/1477393002
Cr-Commit-Position: refs/heads/master@{#362307}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If an event comes in before the ack for a previously sent event arrives, then
queue the event. Once the ack comes back for the previous event, dispatch the
queued event as usual (i.e. the targeting happens after the ack comes back).
Some notes:
. There is a limit to how long mus will wait for the event to be acked. It
currently waits 100ms, but we will want different timeouts for the different
types of events (e.g. touch events should have smaller timeouts).
. If the ack does not arrive within the timeout period, then the next queued
event (if any) is dispatched anyway. We would want to change this though, e.g.
penalize the client, and if a client misses the timeout too often, stop
sending it events.
. Queued events are currently not coalesced.
BUG=533161
Review URL: https://codereview.chromium.org/1480083002
Cr-Commit-Position: refs/heads/master@{#362305}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
#4 id:60001 of https://codereview.chromium.org/1478623004/ )
Reason for revert:
Busted iOS http://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/30182/steps/compile/logs/stdio
Original issue's description:
> Convert enable_pre_sync_backup flag to new flags system.
>
> This flag's usage is very isolated so is a good candidate for the new system. There is now a generated header for the #define rather than a global define.
>
> Committed: https://crrev.com/bc4bccdacc16ccdf314870049033e03c463e478e
> Cr-Commit-Position: refs/heads/master@{#362284}
TBR=zea@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1485933002
Cr-Commit-Position: refs/heads/master@{#362297}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes how widgets are created for shell surfaces. By creating
the widget when the surface takes a specific role, hints about size
can be communicated to the client to ensure that the initial frame
being displayed when the widget is shown is perfect. This is also
a prerequisite to interactive window resize.
This also allows top-level shell surfaces to be automatically managed
by Ash.
BUG=549781
TEST=exo_unittests --gtest_filter=ShellSurfaceTest.*
Review URL: https://codereview.chromium.org/1484133002
Cr-Commit-Position: refs/heads/master@{#362296}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
issue. (patchset #4 id:80001 of https://codereview.chromium.org/1432143002/ )
Reason for revert:
Reverting Patch Set 4, since it was meant to be temporary anyways.
Original issue's description:
> Track where WebContents are created in order to better understand issue.
>
> This is a temporary change to track down a beta blocking crash.
> This CL doesn't fix the crash, but will give us more information.
>
> The crash is happening when we attempt to show a modal dialog on some
> unknown WebContents that doesn't have a WebModalDialogManager. Not all
> WebContents are expecting to show modal dialogs and the creator of the
> WebModalDialog doesn't control what WebContents they will get at
> runtime. So, because of this loose coupling, we don't know which
> WebContents is triggering the crash.
>
> By adding this trace we expect to learn where the WebContents are
> created in order to make sure they have a WebModalDialogManager.
>
> BUG=538612
>
> Committed: https://crrev.com/e1158d6a42903de1664c12bc91ba056ecb716bb6
> Cr-Commit-Position: refs/heads/master@{#360112}
TBR=nick@chromium.org,wittman@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=538612
Review URL: https://codereview.chromium.org/1486863002
Cr-Commit-Position: refs/heads/master@{#362292}
|
|
|
|
|
|
|
|
| |
BUG=519012
Review URL: https://codereview.chromium.org/1436633002
Cr-Commit-Position: refs/heads/master@{#362289}
|
|
|
|
|
|
|
|
| |
This flag's usage is very isolated so is a good candidate for the new system. There is now a generated header for the #define rather than a global define.
Review URL: https://codereview.chromium.org/1478623004
Cr-Commit-Position: refs/heads/master@{#362284}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RenderWidget::CreateOutputSurface is called prior to the availability of a
RenderWidgetMusConnection, and prior to notification of embedding in
Mus (RenderWidgetMusConnection::OnEmbed). This CL provides a
mechanism to create a WindowSurface prior to the availability of a
Window. When creating a WindowSurface, a sibling object,
WindowSurfaceBinding is also created that can be passed into
Window::AttachSurface once a mus::Window is available.
BUG=551250
Review URL: https://codereview.chromium.org/1484533002
Cr-Commit-Position: refs/heads/master@{#362273}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tweaks the logic from https://codereview.chromium.org/1005173006/ so
that the Subzero translator is always used for O0 translation on x86-32,
regardless of the --enable-pnacl-subzero flag.
Updates validation cache testing to reflect the use of the Subzero
translator nexe.
Disables the error handling test under Windows due to
http://crbug.com/499878 because the O0 manifest tests now use Subzero.
The flag is retained so that it can be used in the future to phase in
Subzero for other targets, such as x86-64, arm32, and mips32, in the
same way as was done for x86-32.
This is a retry of https://codereview.chromium.org/1457183002/ .
BUG=532718
TEST= git cl try -b linux_chromium_dbg_32_ng
TEST= git cl try -b win_chromium_xp_rel_ng
Review URL: https://codereview.chromium.org/1488543004
Cr-Commit-Position: refs/heads/master@{#362272}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes since https://codereview.chromium.org/1416133003 are ps1 -> ps2.
- Includes build fix to for debug component GN build.
- Includes Crashpad roll to pull in clang compile fixes and a limit on
the number of locks saved to the crash dump.
- Increase timeout on tab crash telemetry test for debug builds.
Original CL:
Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows
Crashpad is always compiled into chrome and its handler is always
enabled. It only uploads in Official builds.
On Windows, the crash handler is chrome.exe run with a
--crashpad-handler argument. This is due to concern about
incompatibilities of shipping an additional new different binary for AV,
firewalls, etc.
Sample renderer crash/1aed2bc785e28995
Sample browser: crash/66c822815474a5d8
See also http://crbug.com/427611 .
R=mark@chromium.org
TBR=cpu@chromium.org
BUG=447073, 546288, 456193
Review URL: https://codereview.chromium.org/1479283002
Cr-Commit-Position: refs/heads/master@{#362258}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL implements the changes introduced in the following pull request
to the IETF HTTP Encrypted Encoding draft:
https://goo.gl/f9ktM0
A reference test is also introduced to verify our implementation against
an example given in the specification.
BUG=486040
Review URL: https://codereview.chromium.org/1457463002
Cr-Commit-Position: refs/heads/master@{#362250}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
New code that will reside in base will need access to
these methods. (cl/1471073007)
Depends on
https://codereview.chromium.org/1471073010
BUG=546019
Review URL: https://codereview.chromium.org/1476633003
Cr-Commit-Position: refs/heads/master@{#362244}
|
|
|
|
|
|
|
|
| |
BUG=462737
Review URL: https://codereview.chromium.org/1474423002
Cr-Commit-Position: refs/heads/master@{#362243}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added components are:
bitmap_uploader
browser_sync
dom_distiller
exp
proxy_config
query_parser
rappor
renderer_context_menu
resource_provider
resources
rlz
safe_browsing_db
safe_json
scheduler
search
The dom distiller GN build was a little messed up. The JNI registrar files were in core but referenced files in content. I moved the registrar files to content/browser which is where they're needed and matches some other components. There were also some other duplicated java targets, and I split out the content build file into separate subdirectories and renamed the targets to match.
TBR=dpranke@chromium.org
BUG=562773
Review URL: https://codereview.chromium.org/1487433002
Cr-Commit-Position: refs/heads/master@{#362234}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#362231}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows a client to show a shell surface as maximized
and simplifies the shell surface implemenatation by always
requiring client side decorations.
BUG=549781
TEST=exo_unittests --gtest_filter=ShellSurfaceTest.SetMaximized
Review URL: https://codereview.chromium.org/1481773002
Cr-Commit-Position: refs/heads/master@{#362213}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some crashes have been seen in the wild on Android devices. We now guard against initialization error, and track the failures in a histogram, which allow for locale slicing.
According to the web it is not unseen to have ICU Locales return bogus values, but hopefully we can track it down further.
BUG=548365
Review URL: https://codereview.chromium.org/1457393003
Cr-Commit-Position: refs/heads/master@{#362212}
|
|
|
|
|
|
|
|
|
| |
BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1469863003
Cr-Commit-Position: refs/heads/master@{#362203}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The sys_byteorder methods no longer use htonl() and friends
and so the include in not necessary. Several files, however,
expect those system methods to be available after including
sys_byteorder.h so they have been changed to use the methods
defined within sys_byteorder.h instead.
TBR=jam
BUG=
Review URL: https://codereview.chromium.org/1471073010
Cr-Commit-Position: refs/heads/master@{#362179}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Use monotonic timestamp for generated events (drag, mousemove, etc.).
- Plumb platform timestamp for Wheel event in all platforms.
- Use monotonic time for generated mouse events.
- Make platform timestamp required for all mouse, drag, and wheel events.
- Fix event_sender bug where timestamp had second precision (int instead of double!).
This also includes few clean ups:
- Move setting platform timestamp to |Event| ctor instead of |setPlatformTimeStamp|.
- More consistent naming and arg position for timestamp in
constructors and factory methods.
BUG=555781
TESTS=fast/events/hr-timestamp/input-events.html, fast/events/hr-timestamp/generated-events.html
Review URL: https://codereview.chromium.org/1475153002
Cr-Commit-Position: refs/heads/master@{#362177}
|
|
|
|
|
|
|
|
|
|
|
| |
Comments from https://codereview.chromium.org/1479373002/ and
https://codereview.chromium.org/1479093002/
TBR=dpranke@chromium.org
Review URL: https://codereview.chromium.org/1487683003
Cr-Commit-Position: refs/heads/master@{#362170}
|
|
|
|
|
|
|
|
|
|
|
|
| |
tests.
Now that we'll be using the broker for non-sandbox communication, all processes need to share state. This is better anyways to exercise the production code in tests.
BUG=561803
Review URL: https://codereview.chromium.org/1485573002
Cr-Commit-Position: refs/heads/master@{#362157}
|