summaryrefslogtreecommitdiffstats
path: root/content
Commit message (Collapse)AuthorAgeFilesLines
* Only record GPU process exit code histogram if it is valid.apatrick@chromium.org2011-09-141-3/+7
| | | | | | Review URL: http://codereview.chromium.org/7888027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101132 0039d316-1c4b-4281-b951-d872f2087c98
* chrome.experimental.downloads.onCreated, onErasedbenjhayden@chromium.org2011-09-141-0/+2
| | | | | | | | | | | | | | Manually tested. No apitest yet because that's in 7647028. If this CL goes in before that one, then I'll add tests for these events in that CL, otherwise in this CL at that time. Who owns what: Randy: DownloadItem Mihai: chrome/browser/extensions/... Randy, Asanka, I also appreciate having your eyes on extensions/... if you have the time to make sure that I'm using the downloads/ interfaces correctly and matching the doc. Review URL: http://codereview.chromium.org/7645029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101121 0039d316-1c4b-4281-b951-d872f2087c98
* Added ability to set ChromeDownloadManagerDelegate for testing.rdsmith@chromium.org2011-09-141-0/+3
| | | | | | Review URL: http://codereview.chromium.org/7859001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101114 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 101063 - Removing singleton property of MediaStreamManager and ↵mad@chromium.org2011-09-1413-195/+91
| | | | | | | | | | | | | | | | creating thread first when needed. Most likely cause of new Flakiness in PrerenderBrowserTest.PrerenderUnload... BUG=92125 TEST= Review URL: http://codereview.chromium.org/7649016 TBR=mflodman@chromium.org Review URL: http://codereview.chromium.org/7885034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101107 0039d316-1c4b-4281-b951-d872f2087c98
* Can't detect if decoder is being destructed.backer@chromium.org2011-09-141-5/+0
| | | | | | | | | | | The ImageTransportHelper::Destroy was for symmetry. It was a NO-OP. BUG=none TEST=open a new tab on TOUCH_UI; go to google.com; close the tab on TOUCH_UI; should no longer crash GPU process. Review URL: http://codereview.chromium.org/7892017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101071 0039d316-1c4b-4281-b951-d872f2087c98
* Removing singleton property of MediaStreamManager and creating thread first ↵mflodman@chromium.org2011-09-1413-91/+195
| | | | | | | | | | | when needed. BUG=92125 TEST= Review URL: http://codereview.chromium.org/7649016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101063 0039d316-1c4b-4281-b951-d872f2087c98
* Suppression for failing test on Linuxjeremy@chromium.org2011-09-144-85/+0
| | | | | | | | | BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/7885024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101049 0039d316-1c4b-4281-b951-d872f2087c98
* Add ChromeRenderViewHostTestHarness to get rid of the dependency from RVHTH ↵jochen@chromium.org2011-09-146-35/+52
| | | | | | | | | | | to profile BUG=90443 TEST=everything still works Review URL: http://codereview.chromium.org/7892007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101037 0039d316-1c4b-4281-b951-d872f2087c98
* Fix speech input keystroke crash.dmazzoni@chromium.org2011-09-141-11/+10
| | | | | | | | | | | | | It was trying to cast a WebElement to WebInputElement if it was a text form control, but this broke for <textarea>. Now checking for the "input" tag. BUG=96058 TEST=manual testing Review URL: http://codereview.chromium.org/7754029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101035 0039d316-1c4b-4281-b951-d872f2087c98
* Delay sending OnResponseCompleted and OnDataDownloaded until we are donedarin@chromium.org2011-09-142-6/+22
| | | | | | | | | | | | | writing to disk. The approach for delaying OnResponseCompleted mimics code from CrossSiteResourceHandler, which has similar needs. R=michaeln BUG=95570 Review URL: http://codereview.chromium.org/7879005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101022 0039d316-1c4b-4281-b951-d872f2087c98
* re-land r100988 (gpy refactoring for content dll).dpranke@chromium.org2011-09-1411-97/+199
| | | | | | | | | | TBR=darin BUG= TEST= Review URL: http://codereview.chromium.org/7889027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101011 0039d316-1c4b-4281-b951-d872f2087c98
* Bring back safe browsing binary digest checking. I accidentally removed that ↵jam@chromium.org2011-09-145-5/+13
| | | | | | | | | code because I thought it didn't do anything (since the callback did nothing). BUG=96511 Review URL: http://codereview.chromium.org/7888029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101003 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r100988 (gpy refactoring for content dll).dpranke@chromium.org2011-09-1411-199/+97
| | | | | | | | | | TBR=darin BUG= TEST= Review URL: http://codereview.chromium.org/7892021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100996 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 100733 (caused more crashes) - Cancel plugin channel requests when ↵willchan@chromium.org2011-09-137-200/+53
| | | | | | | | | | | | | | | | | | | | | | the renderer goes away. Logic: - Profile shutdown kills all renderer processes - When the RMF detects the channel closing, it kills off any plugin channel requests from: * PluginService (which needs to check the PluginServiceFilter on the FILE thread) * PluginProcessHost (which may need to wait for the channel to get established) - RMF uses the new OnPluginProcessHostFound() to cancel at the PluginService or PluginProcessHost BUG=94704 TEST=New PluginService test, no known manual test Review URL: http://codereview.chromium.org/7867031 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/7889023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100989 0039d316-1c4b-4281-b951-d872f2087c98
* This change merges all of the content code into a single library; the ↵dpranke@chromium.org2011-09-1311-97/+199
| | | | | | | | | | | | | | | | | | | contents of the library are pulled from individual gypis that are now just collections of settings. There are three changes here ... 1) Move omx_video_decode_unittest into content_tests.gypi, and move a couple of other definitions into the top level content.gyp 2) Change all of the dependencies in the chrome gypi's from content_browser et al. to just "content" 3) Remove the "targets", "target_name", and "target_type" keys from the content_* gypis This change depends on http://codereview.chromium.org/7697008/ landing first to ensure we have the right dependencies set for content. BUG=90442 TEST=everything still compiles and links Review URL: http://codereview.chromium.org/7618029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100988 0039d316-1c4b-4281-b951-d872f2087c98
* fix const decl in content_main.dpranke@chromium.org2011-09-131-1/+1
| | | | | | | | | | TBR=jam@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7889019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100979 0039d316-1c4b-4281-b951-d872f2087c98
* Annotate all of the functions in content that need to be exported, in ↵dpranke@chromium.org2011-09-13141-352/+566
| | | | | | | | | | | | preparation for creating a content shared library. R=darin@chromium.org, jam@chromium.org, willchan@chromium.org BUG=90442 TEST=everything still compiles Review URL: http://codereview.chromium.org/7800015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100975 0039d316-1c4b-4281-b951-d872f2087c98
* Bug=Nonemmocny@chromium.org2011-09-131-1/+3
| | | | | | | | Test=None Review URL: http://codereview.chromium.org/7795054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100968 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Demuxer from the Filter class hierarchy.acolwell@chromium.org2011-09-131-0/+1
| | | | | | | | | BUG=92254 TEST=Covered by existing tests. Review URL: http://codereview.chromium.org/7839035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100959 0039d316-1c4b-4281-b951-d872f2087c98
* Retry 3 to split WebGraphicsContext3DCommandBufferImpl::initialize() into ↵nduca@chromium.org2011-09-138-70/+124
| | | | | | | | | | | | | | | | | | | two stages. This CL splits out creation of the context from channel creation. The WebGraphicsContext3D will not be fully initialized until MakeCurrent is called on it, at which point it is tied to the calling thread. As compared to previous land attempts, this has: - Protection against isContextLost being called on a dead context - WebKit-side protection to ensure that GraphicsContext3Ds get made current - Pepper modified to makeCurrent new contexts Original review URL: http://codereview.chromium.org/7713015 Review URL: http://codereview.chromium.org/7860028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100955 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor AudioDevice to remove race conditions in the Start() and Stop().xians@chromium.org2011-09-136-50/+74
| | | | | | | | | | It also ensures that the AudioDevice can be destroyed during an active audio session without crashing. This CL is derived from http://codereview.chromium.org/7661017/ , but on the output side. Review URL: http://codereview.chromium.org/7782031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100954 0039d316-1c4b-4281-b951-d872f2087c98
* s patch tries to remove most of the manual registration for Pepper ↵brettw@chromium.org2011-09-131-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | interfaces, and replaces it with a list of macros. When files want to know which Pepper interface names and structs there are, they define what they want to do with the macros, and then include the relevant files for the classes of interfaces they want (stable, private, dev). This re-lands my previous change. Original Review URL: http://codereview.chromium.org/7874002 This does not convert all the dev interfaces. I just did a few to keep the patch smaller. So there is still a lot of manual registration. This fixes the previous design problem where we assumed one *_Proxy object == one interface. We have been hacking around this lately with duplicate GetInfo calls, but this doesn't work for PPP interfaces. Now, a _Proxy object is just there to help keep things organized. One proxy can handle zero, one, or many interfaces, and this mapping is controlled by just one line in the interfaces file. So for example, to add a new function to a new version of an interface with backward compatibility, you would add that function to the _api.h file, and write a thunk for the new interface. Then you only need to add one line to the interfaces_ppb_public_stable.h file and that will be hooked up with the proxy and the implementation. This removes some _proxy objects/files that were used only to declare that the interfaces existed, since they're no longer necessary. I folded Console into the Instance API which removed a bunch of code. I removed FileChooser 0.4. I think everybody has converted to the new one, and I think parts of it weren't even hooked up properly anymore. Review URL: http://codereview.chromium.org/7887001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100936 0039d316-1c4b-4281-b951-d872f2087c98
* Move the handling of the ViewMsg_CustomContextMenuAction and ↵ananta@chromium.org2011-09-132-0/+6
| | | | | | | | | | | | | | ViewMsg_Navigate out of chrome and replace the intended handling with notifications on the RenderViewObserver interface. Continuing changes to get rid of the pattern of IPC messages going across content and chrome. BUG=87335 TEST=no change in functionality. Blocked plugins and about handler should continue to work. Review URL: http://codereview.chromium.org/7880006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100933 0039d316-1c4b-4281-b951-d872f2087c98
* Third try at committing this.erikwright@chromium.org2011-09-131-3/+4
| | | | | | | | | | | | | | | | | | Patchset 1 is the original patch ( http://codereview.chromium.org/7833042/ ). Patchset 2 is the original patch plus a fix to a memory leak from the initial commit ( http://codereview.chromium.org/7831056/ ) On the first try there was a memory leak in a test. I fixed that, but made a mistake in the commit (the committed code did not correspond to the reviewed code). Both commits were reverted. I then landed a new CL ( http://codereview.chromium.org/7860039/ ) that contained the correct changes combining the first two CLs. This caused an error in heapchecker for which a suppression has subsequently been defined ( http://codereview.chromium.org/7780010 ). In summary, all of this is reviewed, minus some lint fixes. BUG=68657 TEST=net_unittests / DeferredCookieTaskTest.* and CookieMonsterTest.* TBR=estade Review URL: http://codereview.chromium.org/7891008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100932 0039d316-1c4b-4281-b951-d872f2087c98
* Make TraceSubscriberStdio reusable (currently can only run trace once)jbates@chromium.org2011-09-132-9/+29
| | | | | | Review URL: http://codereview.chromium.org/7863022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100929 0039d316-1c4b-4281-b951-d872f2087c98
* WorkerTest.MultipleSharedWorkers is flakey on XPdhollowa@chromium.org2011-09-131-1/+7
| | | | | | | | | | | | Adds flakey designation to WorkerTest.MultipleSharedWorkers. BUG=96435 TEST=WorkerTest.MultipleSharedWorkers on XP TBR=dglazkov@chromium.org Review URL: http://codereview.chromium.org/7889009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100928 0039d316-1c4b-4281-b951-d872f2087c98
* Summary of changesyosin@chromium.org2011-09-133-9/+38
| | | | | | | | | | | | | | | | | | | | | | == chrome/browser/profiles/off_the_record_profile.cc == == chrome/browser/profiles/off_the_record_profile.h == * Change GetHostZoomMap for populating from parent's host zoom map. * Install observer in off the record profile to observe original HZM changes * Move object initialization code to Init method for two phase initialization. == content/browser/host_zoom_map.* == * Populating newly created HostZoomMap(HZM) for off the record profile with zoom level settings from original profile. == content/browser/renderer_host/render_view_host.cc == Propagate zoom level change to related hosts to update page rendering. BUG=88355 TEST=Manual test on Linux/Mac/Win and unit test Review URL: http://codereview.chromium.org/7624013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100920 0039d316-1c4b-4281-b951-d872f2087c98
* Move TestNotificationTracker to content as it has no dependencies to chrome ↵jochen@chromium.org2011-09-135-2/+162
| | | | | | | | | | | but is used in content/ BUG=90443 TEST=nothing breaks Review URL: http://codereview.chromium.org/7870002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100914 0039d316-1c4b-4281-b951-d872f2087c98
* Allow gpu features for about:blank (unlike other about: schemes)jamesr@chromium.org2011-09-131-1/+2
| | | | | | | | | | TEST=run with --force-compositing-mode and --show-fps-counter, verify that the counter shows up on about:blank and not on other about: pages BUG=95107 Review URL: http://codereview.chromium.org/7779022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100879 0039d316-1c4b-4281-b951-d872f2087c98
* Fix URLFetcherTest.CancelAll.willchan@chromium.org2011-09-131-29/+22
| | | | | | | | | | | | | I don't know what I was smoking before when I wrote this test. It was obviously racy. Fix it by moving the EXPECTs and CancelAll call to the IO thread. The last EXPECT is fine on the main test thread since it should be guaranteed to be 0. BUG=89863,88221 TEST=manual Review URL: http://codereview.chromium.org/7881001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100861 0039d316-1c4b-4281-b951-d872f2087c98
* Move URLFetcher from content/common to content/common/net.willchan@chromium.org2011-09-139-11/+14
| | | | | | | | | | | | | Add a OWNERS for content/common/net BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100828 Review URL: http://codereview.chromium.org/7875006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100857 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r100853, 100851. Win_shared build is broken.brettw@chromium.org2011-09-131-2/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100854 0039d316-1c4b-4281-b951-d872f2087c98
* This patch tries to remove most of the manual registration for Pepper ↵brettw@chromium.org2011-09-131-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | interfaces, and replaces it with a list of macros. When files want to know which Pepper interface names and structs there are, they define what they want to do with the macros, and then include the relevant files for the classes of interfaces they want (stable, private, dev). This re-lands my previous change. Original Review URL: http://codereview.chromium.org/7740038 This does not convert all the dev interfaces. I just did a few to keep the patch smaller. So there is still a lot of manual registration. This fixes the previous design problem where we assumed one *_Proxy object == one interface. We have been hacking around this lately with duplicate GetInfo calls, but this doesn't work for PPP interfaces. Now, a _Proxy object is just there to help keep things organized. One proxy can handle zero, one, or many interfaces, and this mapping is controlled by just one line in the interfaces file. So for example, to add a new function to a new version of an interface with backward compatibility, you would add that function to the _api.h file, and write a thunk for the new interface. Then you only need to add one line to the interfaces_ppb_public_stable.h file and that will be hooked up with the proxy and the implementation. This removes some _proxy objects/files that were used only to declare that the interfaces existed, since they're no longer necessary. I folded Console into the Instance API which removed a bunch of code. I removed FileChooser 0.4. I think everybody has converted to the new one, and I think parts of it weren't even hooked up properly anymore. Review URL: http://codereview.chromium.org/7874002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100851 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Linux Views build breakage.willchan@chromium.org2011-09-139-14/+11
| | | | | | | | | | | | | | | | Revert 100828 - Move URLFetcher from content/common to content/common/net. Add a OWNERS for content/common/net BUG=none TEST=none Review URL: http://codereview.chromium.org/7875006 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/7884003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100829 0039d316-1c4b-4281-b951-d872f2087c98
* Move URLFetcher from content/common to content/common/net.willchan@chromium.org2011-09-139-11/+14
| | | | | | | | | | | Add a OWNERS for content/common/net BUG=none TEST=none Review URL: http://codereview.chromium.org/7875006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100828 0039d316-1c4b-4281-b951-d872f2087c98
* extract out removal of the g_log_bug53991 global.dpranke@chromium.org2011-09-132-11/+0
| | | | | | | | | | | | | | | This global is referenced across content and chrome, and would need to be exported for the content.dll build. It appears to be off by default and was added for a bug last touched a year ago, so I'm thinking it's safe to remove it and it can be readded back in as necessary. R=mpcomplete@chromium.org BUG=53991,90442 TEST=none Review URL: http://codereview.chromium.org/7833004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100817 0039d316-1c4b-4281-b951-d872f2087c98
* export RendererMain from content so that it will get picked up properly by ↵dpranke@chromium.org2011-09-134-3/+22
| | | | | | | | | | | chrome_main. R=jam@chromium.org BUG=90442 Review URL: http://codereview.chromium.org/7841009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100809 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 100801 - Ensure that compositor does not block the renderer process ↵apatrick@chromium.org2011-09-121-3/+1
| | | | | | | | | | | | | | by issuing too many SwapBuffers. This might have regressed with r84372. It caused there to be one additional token queued in the swap buffers token queue than before. BUG=95649 Review URL: http://codereview.chromium.org/7867053 TBR=apatrick@chromium.org Review URL: http://codereview.chromium.org/7880009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100803 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that compositor does not block the renderer process by issuing too ↵apatrick@chromium.org2011-09-121-1/+3
| | | | | | | | | | | many SwapBuffers. This might have regressed with r84372. It caused there to be one additional token queued in the swap buffers token queue than before. BUG=95649 Review URL: http://codereview.chromium.org/7867053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100801 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore messages at ListenerHook after ChildProcessHost's destructor starts.willchan@chromium.org2011-09-122-0/+17
| | | | | | | | | | | ChildProcessHost's pure virtuals get called by ListenerHook. This prevents that. BUG=96239 TEST=none Review URL: http://codereview.chromium.org/7870005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100799 0039d316-1c4b-4281-b951-d872f2087c98
* fix checkdepsjam@chromium.org2011-09-121-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100779 0039d316-1c4b-4281-b951-d872f2087c98
* Basic scaffolding for a "content shell", i.e. test browser over the content ↵jam@chromium.org2011-09-1227-18/+1031
| | | | | | | | | | | module. Once it's working, this will allow developers working on the core chrome code/web platform/networking etc to test their changes on a much smaller and hence faster to build/run/debug browser. This doesn't do anything yet because it's blocked on having TabContentsView implementations in content. BUG=90445 Review URL: http://codereview.chromium.org/7857019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100778 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for filtering traces by categories. The TraceLog API is updated ↵jbates@chromium.org2011-09-127-26/+108
| | | | | | | | | | | to support included and excluded categories. This API is then plumbed through to the TraceController so that it can be used across all processes. BUG=96122 TEST=base_unittests Review URL: http://codereview.chromium.org/7867013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100777 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize member variables.jhawkins@chromium.org2011-09-121-1/+1
| | | | | | | | | | | | | CID_COUNT=23 CID=100941,100986,100987,101015,101016,101017,101227,101229,101230,101332,101333,101334,101335,101336,101337,101355,101356,101359,101362,101363,101381,101389,101417 BUG=none TEST=none R=kmadhusu@chromium.org Review URL: http://codereview.chromium.org/7780013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100774 0039d316-1c4b-4281-b951-d872f2087c98
* Make the NaCl windows 64 bit binaries not depend on chrome targets. These ↵jam@chromium.org2011-09-1213-191/+110
| | | | | | | | | | | | | targets are very simple and used little code from chrome targets. However their dependency on chrome targets was problematic because a lot of code wasn't being built for 64 bit on Windows, and so there were a lot of "dummy" files being added with stub functions and code was also being compiled out in random places for NACL_WIN64. I've made the NaCl 64 bit windows targets self contained. They do use a few files from common, but those files are self-contained. In the future, we could move these to be in the same 64 bit target as the constants from common. However that won't make a maintenance difference since someone could still introduce link dependencies to other files in common. Additionally, since we're not using chrome code anymore, we can avoid having both nacl.exe and nacl.dll. nacl.exe is sufficient, and this saves 1.4MB of uncompresed binaries in the installer. BUG=86322 Review URL: http://codereview.chromium.org/7863024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100767 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a race where Init gets called right after FastShutdownIfPossible before ↵achuith@chromium.org2011-09-122-0/+8
| | | | | | | | | | channel_ has been reset by OnChannelError after a round-trip. BUG=chromium-os:18390 TEST=Open a new tab on cros. Close all other tabs. Navigate to google.com. Close the tab. Should no longer see the sad tab. Review URL: http://codereview.chromium.org/7864019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100765 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 100748 - This patch tries to remove most of the manual registration ↵dmazzoni@chromium.org2011-09-121-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | for Pepper interfaces, and replaces it with a list of macros. When files want to know which Pepper interface names and structs there are, they define what they want to do with the macros, and then include the relevant files for the classes of interfaces they want (stable, private, dev). This does not convert all the dev interfaces. I just did a few to keep the patch smaller. So there is still a lot of manual registration. This fixes the previous design problem where we assumed one *_Proxy object == one interface. We have been hacking around this lately with duplicate GetInfo calls, but this doesn't work for PPP interfaces. Now, a _Proxy object is just there to help keep things organized. One proxy can handle zero, one, or many interfaces, and this mapping is controlled by just one line in the interfaces file. So for example, to add a new function to a new version of an interface with backward compatibility, you would add that function to the _api.h file, and write a thunk for the new interface. Then you only need to add one line to the interfaces_ppb_public_stable.h file and that will be hooked up with the proxy and the implementation. This removes some _proxy objects/files that were used only to declare that the interfaces existed, since they're no longer necessary. I folded Console into the Instance API which removed a bunch of code. I removed FileChooser 0.4. I think everybody has converted to the new one, and I think parts of it weren't even hooked up properly anymore. Review URL: http://codereview.chromium.org/7740038 TBR=brettw@chromium.org Review URL: http://codereview.chromium.org/7844018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100754 0039d316-1c4b-4281-b951-d872f2087c98
* This patch tries to remove most of the manual registration for Pepper ↵brettw@chromium.org2011-09-121-1/+2
| | | | | | | | | | | | | | | | | | | | | | interfaces, and replaces it with a list of macros. When files want to know which Pepper interface names and structs there are, they define what they want to do with the macros, and then include the relevant files for the classes of interfaces they want (stable, private, dev). This does not convert all the dev interfaces. I just did a few to keep the patch smaller. So there is still a lot of manual registration. This fixes the previous design problem where we assumed one *_Proxy object == one interface. We have been hacking around this lately with duplicate GetInfo calls, but this doesn't work for PPP interfaces. Now, a _Proxy object is just there to help keep things organized. One proxy can handle zero, one, or many interfaces, and this mapping is controlled by just one line in the interfaces file. So for example, to add a new function to a new version of an interface with backward compatibility, you would add that function to the _api.h file, and write a thunk for the new interface. Then you only need to add one line to the interfaces_ppb_public_stable.h file and that will be hooked up with the proxy and the implementation. This removes some _proxy objects/files that were used only to declare that the interfaces existed, since they're no longer necessary. I folded Console into the Instance API which removed a bunch of code. I removed FileChooser 0.4. I think everybody has converted to the new one, and I think parts of it weren't even hooked up properly anymore. Review URL: http://codereview.chromium.org/7740038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100748 0039d316-1c4b-4281-b951-d872f2087c98
* Cancel plugin channel requests when the renderer goes away.willchan@chromium.org2011-09-127-53/+200
| | | | | | | | | | | | | | | | | Logic: - Profile shutdown kills all renderer processes - When the RMF detects the channel closing, it kills off any plugin channel requests from: * PluginService (which needs to check the PluginServiceFilter on the FILE thread) * PluginProcessHost (which may need to wait for the channel to get established) - RMF uses the new OnPluginProcessHostFound() to cancel at the PluginService or PluginProcessHost BUG=94704 TEST=New PluginService test, no known manual test Review URL: http://codereview.chromium.org/7867031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100733 0039d316-1c4b-4281-b951-d872f2087c98
* Reset RPH's channel.willchan@chromium.org2011-09-123-10/+14
| | | | | | | | | | | This is important for shutdown ordering to make sure the objects hanging off the channel get deleted before objects they reference (like data in ResourceContext) go away. BUG=91398 TEST=none Review URL: http://codereview.chromium.org/7796029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100730 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-04 12:05:34 +0000