| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This relands commit 92d0fffc36695c099005bf05862145a89d918f28. The test
failure is fixed in https://chromiumcodereview.appspot.com/1837673002/.
Original Description:
Enables Mojo Media on Android to support EME in the unified media
pipeline. This introduces MojoCdm, MojoAudioDecoder and encrytped
stream support in AndroidVideoDecodeAccelerator.
This CL also enables MSE in the unified media pipeline. The fallback
logic for MSE (IsUnifiedMediaPipelineEnabledForMse()) is removed.
Also partially reverts f92f4e5c849c028db73fbe06912685a77b978ee4 which
added "LoadType" in createMediaPlayer() to implement the fallback
logic for MSE.
TBR=dalecurtis@chromium.org,ddorwin@chromium.org,pfeldman@chromium.org,wolenetz@chromium.org
BUG=455905,521731
TEST=Encrypted audio/video plays in default Chrome for Android build
with and without unified media pipeline.
Review URL: https://codereview.chromium.org/1838703002
Cr-Commit-Position: refs/heads/master@{#383450}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Download GUID is introduced by
http://crrev.com/eef62b0282ec19ebc040785d0b7ac36de398cbc1
Unlike download Id, the GUID can live across browser sessions and will
not be reused.
This change switches the java class to also use the
GUID.
Chrome will temporarily use the old download Id as the notification Id.
This is because the android notification requires an int to identify it,
rather than a string.
In the future, we will generate the notification Id from java side.
The download Ids generated by the Android DownloadManager are not
affected by this CL.
However, they are only used in OMA downloads and when we call
addCompletedDownload().
BUG=593020
Review URL: https://codereview.chromium.org/1809203006
Cr-Commit-Position: refs/heads/master@{#383443}
|
|
|
|
|
|
|
|
|
|
| |
This is not a feature we have/need in PPAPI
BUG=493212
Review URL: https://codereview.chromium.org/1829293002
Cr-Commit-Position: refs/heads/master@{#383437}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds window activity detector for mac which enables the following
features to be enabled on tab mirroring:
- Low latency interactive mode will be turned on when user is
interactive with non-animating content
- Frame subscriber will enable frame capture in response to mouse
events resulting in smooth rendering of mouse while mirroring
BUG=567735
Review URL: https://codereview.chromium.org/1835493002
Cr-Commit-Position: refs/heads/master@{#383431}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first in a series of changes to solve the problems related
to VideoCaptureDevices that can pause (i.e., basically, screen capture
devices). This introduces new optional-to-implement methods to the
media::VideoCaptureDevice interface, and the supporting functionality in
content::VideoCaptureBufferPool.
This change should not result in any end-user-visible differences, as it
is just laying the groundwork for future changes. For more details on
the overall plan, please see the crbug.
BUG=486274
Review URL: https://codereview.chromium.org/1826643003
Cr-Commit-Position: refs/heads/master@{#383426}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds a series of RequstFrame() calls propagated from
MediaStreamVideoTrack when a new sink is added.
MediaStreamVideoTrack
-> MediaStreamVideoCapturerSource which is a MediaStreamVideoSource
-> media::VideoCapturerSource
This addresses the issues when a new sink is added but doesn't
receive a frame because it wasn't added on time.
BUG=597876, 587789, 486274
Review URL: https://codereview.chromium.org/1829193003
Cr-Commit-Position: refs/heads/master@{#383421}
|
|
|
|
|
|
|
|
|
|
| |
Final blocker to wholly deleting base/memory/scoped_ptr.h.
BUG=554298
Review URL: https://codereview.chromium.org/1837483003
Cr-Commit-Position: refs/heads/master@{#383417}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #3 id:40001 of https://chromiumcodereview.appspot.com/1825763002/ )
Reason for revert:
Android tests on many bots started failing right after this; these are the most obvious:
https://build.chromium.org/p/chromium.android/builders/Lollipop%20Phone%20Tester/builds/3714
* RenderFrameImplTest.LoFiNotUpdatedOnSubframeCommits
* RenderViewImplTest.OnSetAccessibilityMode
I reverted locally multiple times to make sure, but RenderFrameImplTest.LoFiNotUpdatedOnSubframeCommits only starts failing when this CL is committed, AFAICT.
Original issue's description:
> media: Enable Unified Media Pipeline for MSE and EME on Android
>
> Enables Mojo Media on Android to support EME in the unified media
> pipeline. This introduces MojoCdm, MojoAudioDecoder and encrytped
> stream support in AndroidVideoDecodeAccelerator.
>
> This CL also enables MSE in the unified media pipeline. The fallback
> logic for MSE (IsUnifiedMediaPipelineEnabledForMse()) is removed.
>
> Also partially reverts f92f4e5c849c028db73fbe06912685a77b978ee4 which
> added "LoadType" in createMediaPlayer() to implement the fallback
> logic for MSE.
>
> BUG=455905,521731
> TEST=Encrypted audio/video plays in default Chrome for Android build
> with and without unified media pipeline.
>
> Committed: https://crrev.com/92d0fffc36695c099005bf05862145a89d918f28
> Cr-Commit-Position: refs/heads/master@{#383331}
TBR=dalecurtis@chromium.org,ddorwin@chromium.org,timav@chromium.org,wolenetz@chromium.org,pfeldman@chromium.org,xhwang@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=455905,521731
Review URL: https://codereview.chromium.org/1840563002
Cr-Commit-Position: refs/heads/master@{#383409}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The CreateRenderFrameFlags enum currently has only one value, which can
easily be replaced by a boolean. This CL is removing this enum in favor
of a bool value.
BUG=357747
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review URL: https://codereview.chromium.org/1833243002
Cr-Commit-Position: refs/heads/master@{#383401}
|
|
|
|
|
|
|
|
|
|
|
| |
Since swapped out state on RenderFrameHost has been removed, there is
no longer usage of kSwappedOutURL and the code can safely be removed.
BUG=357747
Review URL: https://codereview.chromium.org/1833933002
Cr-Commit-Position: refs/heads/master@{#383398}
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=GPU FYI linux bots
TBR=kbr@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/1834023002
Cr-Commit-Position: refs/heads/master@{#383397}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since swapped out state on RenderFrameHost has been removed, there is
no longer usage of RenderFrameProxyHost transfering ownership and the
code can safely be removed.
BUG=357747
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review URL: https://codereview.chromium.org/1831233004
Cr-Commit-Position: refs/heads/master@{#383383}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PepperWebPluginImpl seems to be double-destroyed in some renderer
crashes. However, I have not been able to track it down, since the
destruction occurs in a DeleteSoon queue.
This adds an explicit boolean to the destroy() method that should
trigger a CHECK if it is indeed double-destroyed.
BUG=588624
Review URL: https://codereview.chromium.org/1838613002
Cr-Commit-Position: refs/heads/master@{#383377}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously the code would only force restart the timer in some cases,
this change causes the timer to be restarted in all cases where a
DoIOTask() is manually invoked.
It also changes ManageTimer() to ensure it's not basing the idle
timeout on a null/uninitialized |most_recent_work_| value.
BUG=594246
TEST=no more playback failures.
Review URL: https://codereview.chromium.org/1834683003
Cr-Commit-Position: refs/heads/master@{#383376}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows a caller to extend the lifetime of a blob until the
downloads / resource loader subsystems take over. Without this, an
unfortunately timed revokeObjectURL() call from the originating page may
invalidate the URL before the download has a chance to start the
associated download request.
BUG=595305
Review URL: https://codereview.chromium.org/1829413002
Cr-Commit-Position: refs/heads/master@{#383370}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that we are nearing the home stretch, switch to default again. It
was disabled so that we can control it via a server side experiment. But
now we are switching it back so that we get waterfall coverage.
BUG=7648
Review URL: https://codereview.chromium.org/1833153003
Cr-Commit-Position: refs/heads/master@{#383369}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make content/gpu and content/plugin pass GN check. Significant work for most of content/test
Makes most of content/shell and content/test pass check. These are not all enabled yet pending a few remaining issues that are more difficult to solve.
The private content targets now allow content/test to include headers from them for non-component builds. Checking is disabled for content/test in component builds as described in the comment at the top of //content/BUILD.gn
Renames the ui/events/ipc according to GN style.
Annotates all content and gpu visibility declarations with why the're there, and fixes some incorrect ones that people added without understanding.
Reland of https://codereview.chromium.org/1828483002/ with significant changes.
TBR=jschuh (non-security-sensitive ipc build changes)
Review URL: https://codereview.chromium.org/1833193002
Cr-Commit-Position: refs/heads/master@{#383358}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move the LoadNavigationErrorPage call from DidFinishDocumentLoad to
RunScriptsAtDocumentReady, because the former is in a
ScriptForbiddenScope and caused an assertion to be triggered in
blink::beforeCallEnteredCallback when the beforeunload listeners were
ran as a part of the navigation.
BUG=590634
Review URL: https://codereview.chromium.org/1837483002
Cr-Commit-Position: refs/heads/master@{#383355}
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=595097
TEST=linux gpu fyi bots
TBR=kbr@chromium.org,xidachen@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/1840433002
Cr-Commit-Position: refs/heads/master@{#383342}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes it match the module style convention for mojom structs and leads to
less confusion about skia::Bitmap vs. SkBitmap.
BUG=none
TEST=compiles
Review URL: https://codereview.chromium.org/1834993002
Cr-Commit-Position: refs/heads/master@{#383335}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enables Mojo Media on Android to support EME in the unified media
pipeline. This introduces MojoCdm, MojoAudioDecoder and encrytped
stream support in AndroidVideoDecodeAccelerator.
This CL also enables MSE in the unified media pipeline. The fallback
logic for MSE (IsUnifiedMediaPipelineEnabledForMse()) is removed.
Also partially reverts f92f4e5c849c028db73fbe06912685a77b978ee4 which
added "LoadType" in createMediaPlayer() to implement the fallback
logic for MSE.
BUG=455905,521731
TEST=Encrypted audio/video plays in default Chrome for Android build
with and without unified media pipeline.
Review URL: https://codereview.chromium.org/1825763002
Cr-Commit-Position: refs/heads/master@{#383331}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL fixes several WebContentsImplTests when run with PlzNavigate by making
sure they call the appropriate helper functions and having a definition of
CrossSiteNavigationPending that matches the one in the current navigation
codepath.
BUG=439423
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review URL: https://codereview.chromium.org/1832443002
Cr-Commit-Position: refs/heads/master@{#383313}
|
|
|
|
|
|
|
|
|
|
|
| |
This will make the component build happy after a source file was added in
this target in https://codereview.chromium.org/1745903002
TBR=posciak
Review URL: https://codereview.chromium.org/1836523003
Cr-Commit-Position: refs/heads/master@{#383308}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To make Win8 Rel, Win8 Debug, Win7 NVidia GeForce GT 730 bots on GPU FYI waterfall
green.
BUG=
TEST=above mentioned bots
TBR=kbr@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/1833163002
Cr-Commit-Position: refs/heads/master@{#383306}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL disables ResourceDispatcherHostTest.CancelRequestsForContextTransferred
when Plznavigate is enabled. This test is testing something specific to
transfer navigations, which don't exist with PlzNavigate.
BUG=439423
Review URL: https://codereview.chromium.org/1833873003
Cr-Commit-Position: refs/heads/master@{#383304}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:600001 of https://codereview.chromium.org/1745903002/ )
Reason for revert:
Too many problems: Android, Win64 linking, component linking (duplicate code die to incorrect visibility)
Original issue's description:
> Introduce GpuVideoDecodeAcceleratorFactory.
>
> - Move platform-specific code from GpuVideoDecodeAccelerator to
> GpuVideoDecodeAcceleratorFactory.
>
> - Make GVDAFactory a content/public interface, to provide the ability to
> instantiate VDAs from outside content/.
>
> - Unify how we obtain access to various GL functionality/classes from VDAs
> by introducing a set of callbacks provided by the client.
>
> - Replace VDA::CanDecodeOnIOThread() with
> VDA::TryInitializeDecodeOnSeparateThread(). This allows us to remove
> additional client/taskrunner arguments from VDA constructors, and give client
> the option to use a separate thread to decode, instead of having to make this
> decision in the factory, and enforcing these arguments in the constructors.
>
> - Deduplicate VDA creation code across users (currently GVDA and vdaunittest).
>
> BUG=b/27687678
> TEST=compile/run various VDA impls
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/6977e5243786901a766a38c2c291464875dffbd6
> Cr-Commit-Position: refs/heads/master@{#383256}
TBR=jochen@chromium.org,ananta@chromium.org,fsamuel@chromium.org,kcwu@chromium.org,liberato@chromium.org,owenlin@chromium.org,sandersd@chromium.org,jam@chromium.org,boliu@chromium.org,posciak@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=b/27687678
Review URL: https://codereview.chromium.org/1832123002
Cr-Commit-Position: refs/heads/master@{#383300}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1828483002/ )
Reason for revert:
Broke https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/19740/steps/compile/logs/stdio
Original issue's description:
> Content "gn check" work.
>
> Make content/gpu and content/plugin pass GN check.
>
> Makes most of content/shell and content/test pass check. These are not all enabled yet pending a few remaining issues that are more difficult to solve.
>
> The private content targets now allow content/test to include headers from them for non-component builds. Checking is disabled for content/test in component builds as described in the comment at the top of //content/BUILD.gn
>
> Renames the ui/events/ipc according to GN style
>
> BUG=
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
> TBR=jschuh (IPC build tweak)
>
> Committed: https://crrev.com/f510be61306f5e4986eceb1f8686bfcc934cd400
> Cr-Commit-Position: refs/heads/master@{#383208}
TBR=jam@chromium.org,jschuh@chromium.org,dcheng@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/1836533002
Cr-Commit-Position: refs/heads/master@{#383289}
|
|
|
|
|
|
|
|
| |
BUG=496258
Review URL: https://codereview.chromium.org/1833523002
Cr-Commit-Position: refs/heads/master@{#383287}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL fixes WebContentsImplTest.FindOpenerRVHWhenPending when run with
PlzNavigate enabled by ensuring that a RenderFrameProxy will be created if
there's a speculative RenderFrameHost with the appropriate SiteInstance.
BUG=439423
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review URL: https://codereview.chromium.org/1829043002
Cr-Commit-Position: refs/heads/master@{#383275}
|
|
|
|
|
|
|
|
|
|
| |
In image decoding benchmarks these have provided 3x-12x (!) speedup to the swizzle step with SSSE3 support (~15% speedup to the entire image decode), and a more modest 5%-20% with NEON.
BUG=543755
Review URL: https://codereview.chromium.org/1821393004
Cr-Commit-Position: refs/heads/master@{#383274}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Move platform-specific code from GpuVideoDecodeAccelerator to
GpuVideoDecodeAcceleratorFactory.
- Make GVDAFactory a content/public interface, to provide the ability to
instantiate VDAs from outside content/.
- Unify how we obtain access to various GL functionality/classes from VDAs
by introducing a set of callbacks provided by the client.
- Replace VDA::CanDecodeOnIOThread() with
VDA::TryInitializeDecodeOnSeparateThread(). This allows us to remove
additional client/taskrunner arguments from VDA constructors, and give client
the option to use a separate thread to decode, instead of having to make this
decision in the factory, and enforcing these arguments in the constructors.
- Deduplicate VDA creation code across users (currently GVDA and vdaunittest).
BUG=b/27687678
TEST=compile/run various VDA impls
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
Review URL: https://codereview.chromium.org/1745903002
Cr-Commit-Position: refs/heads/master@{#383256}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL should not induce any behavior changes.
IOSurfaces expect a format of GL_BGRA, and an internal format of GL_RGBA.
Callers of CreateGpuMemoryBufferImageCHROMIUM were incorrectly passing in
GL_BGRA as |internalformat|, and the implementation of
CreateGpuMemoryBufferImageCHROMIUM was incorrectly allowing this. This CL
updates callsites to pass in GL_RGBA, and updates the implementation of
CreateGpuMemoryBufferImageCHROMIUM to not accept GL_BGRA.
BUG=595948
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
Review URL: https://codereview.chromium.org/1832923002
Cr-Commit-Position: refs/heads/master@{#383243}
|
|
|
|
|
|
|
|
|
|
| |
Attempt #2. First one made http/tests/inspector/resource-tree/resource-tree-reload.html flaky.
BUG=597572
Review URL: https://codereview.chromium.org/1819243002
Cr-Commit-Position: refs/heads/master@{#383238}
|
|
|
|
|
|
|
|
|
|
| |
I want to add |is_installed| for UMA purposes, but the function is already
taking too many params. Making it a struct also cleans up
the pause_on_download default param.
Review URL: https://codereview.chromium.org/1831463003
Cr-Commit-Position: refs/heads/master@{#383234}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes the WebGraphicsContext3DProvider have a method to set a lost
context callback, and has that method take a SameThreadClosure, wrapped
inside a WebClosure.
The SameThreadClosure is converted to a base::Closure and passed thru
by the WebGraphicsContext3DProviderImpl (which lives in content/) to
the actual ContextProvider::SetLostContextCallback() method. This skips
going through WebGraphicsContext3D in blink for the callback, though
internally the provider does call the same method on
WebGraphicsContext3DImpl, which blink used to hijack from it later.
This removes the setter method from the WebGraphicsContext3D public API
exposed to blink.
It introduces a new public/platform/callback/ directory for the
WebClosure in order to make separate DEPS rules for this class. It
makes use of base::Bind/Callback which has previously not been allowed
in blink, though only to wrap a WTF::SameThreadClosure.
It also makes use of base/logging.h directly (previously we were unable
to use DCHECK in public/platform since the files there build both
with and without BLINK_IMPLEMENTATION and in the without case wtf/ is
not available to be included.
It also uses scoped_ptr since that is nicer than raw pointers and
base::Callback understands it but doesn't understand OwnPtr.
R=kbr@chromium.org, kinuko@chromium.org, piman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
Review URL: https://codereview.chromium.org/1830033003
Cr-Commit-Position: refs/heads/master@{#383233}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebContentsObserver::DidGetUserInteraction
crbug.com/568183 implements GestureScrollBegin for mouse wheel events.
Once this has landed, the mouse event coalescing currently performed by
WebContentsObserver::DidGetUserInteraction will be redundant.
This CL removes the mouse event coalescing, and changes
DidGetUserInteraction to fire on GestureScrollBegin events. The event
type used to signal scrolls in the method is changed from MouseWheel to
GestureScrollBegin, as scroll events will now be fired on mobile scrolls
as well as wheel scrolls. Finally, in clients of DidGetUserInteraction,
MouseWheel is replaced with GestureScrollBegin, and references to
'wheel' are replaced with 'scroll'.
BUG=590612
Review URL: https://codereview.chromium.org/1748553002
Cr-Commit-Position: refs/heads/master@{#383231}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make content/gpu and content/plugin pass GN check.
Makes most of content/shell and content/test pass check. These are not all enabled yet pending a few remaining issues that are more difficult to solve.
The private content targets now allow content/test to include headers from them for non-component builds. Checking is disabled for content/test in component builds as described in the comment at the top of //content/BUILD.gn
Renames the ui/events/ipc according to GN style
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jschuh (IPC build tweak)
Review URL: https://codereview.chromium.org/1828483002
Cr-Commit-Position: refs/heads/master@{#383208}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mac uses ExternalPopupMenus which involve different IPCs than popup
menus on Aura. This CL adds coordinate transformation to the bounds for
popup menus being created to position them correctly on screen.
It also fixes an issue in the surface-based transformation code itself,
which was not previously accounting for scale factor.
BUG=554119
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review URL: https://codereview.chromium.org/1829843005
Cr-Commit-Position: refs/heads/master@{#383202}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Beta channel shows 0.1% of users have a disabled service worker, which still
seems too aggressive. This feature isn't ready for Stable. I intend to merge
this patch to M50.
It's now looking like a simple timeout is not a good heuristic for a broken
service worker, since even main frame navigation without SW can take over
10 seconds to begin a URLRequestJob (crbug.com/448722).
The mechanism to force creating a renderer process remains, to help service
worker escape stuck renderer processes.
BUG=559001
TBR=jwd
Review URL: https://codereview.chromium.org/1829623002
Cr-Commit-Position: refs/heads/master@{#383188}
|
|
|
|
|
|
|
|
|
|
|
| |
Update MediaResourceGetter.isLoopbackAddress to closely match
net::IsLocalHostname in the native code.
BUG=583546
Review URL: https://codereview.chromium.org/1831833004
Cr-Commit-Position: refs/heads/master@{#383185}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Virtualized GL contexts were being disabled for
some non-full screen video due to the attribute
|alpha| used for context creation requests made in
RenderWidget/RenderThreadImp was true.
This CL check the surface type (on/off) to disable
virtualized GL only for onscreen surfaces whose
format doesn't match the default.
BUG=594083, 591100
Review URL: https://codereview.chromium.org/1818303002
Cr-Commit-Position: refs/heads/master@{#383179}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
10.11. (patchset #9 id:160001 of https://codereview.chromium.org/1814163003/ )
Reason for revert:
Broke mac asan as pasted below. Use mac asan locally or the try bots if you want to test a speculative fix.
Original issue's description:
> Fixes typing and deleting text in simple text fields on Mac OS X 10.11.
>
> BUG=530826
> TESTED=VoiceOver on Mac OS X 10.11
> R=dmazzoni@chromium.org, avi@chromium.org, mark@chromium.org
>
> Committed: https://crrev.com/5ca8b4fa7b1f9d53be5f5f1a30b4cecf1c1c4fa5
> Cr-Commit-Position: refs/heads/master@{#383141}
TBR=avi@chromium.org,dmazzoni@chromium.org,mark@chromium.org,nektar@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=530826
Review URL: https://codereview.chromium.org/1831923002
Cr-Commit-Position: refs/heads/master@{#383170}
|
|
|
|
|
|
|
|
|
|
|
| |
With crrev.com/1826673002, this should no longer be flaky.
Reverting the expectation added in crrev.com/1818293002.
BUG=596730
Review URL: https://codereview.chromium.org/1827203002
Cr-Commit-Position: refs/heads/master@{#383164}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As pointed out in https://crbug.com/594219#c29 the local variable
|bytes_so_far| is not initialized at the point of declaration. This is
okay in the current code (this variable *does* get intialized in all the
possible code flows), but the lack of initialization violates the style
guide [1] and is an unnecessary refactoring risk.
[1] https://google.github.io/styleguide/cppguide.html#Local_Variables says:
Place a function's variables in the narrowest scope possible, and
initialize variables in the declaration.
BUG=594219
Review URL: https://codereview.chromium.org/1833723002
Cr-Commit-Position: refs/heads/master@{#383163}
|
|
|
|
|
|
|
|
|
|
| |
BUG=530826
TESTED=VoiceOver on Mac OS X 10.11
R=dmazzoni@chromium.org, avi@chromium.org, mark@chromium.org
Review URL: https://codereview.chromium.org/1814163003
Cr-Commit-Position: refs/heads/master@{#383141}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is an IPC struct used by gpu_host_messages.h so
it doesn't really belong to content/common/gpu and later
gpu/ipc/common
BUG=596290
Review URL: https://codereview.chromium.org/1830193002
Cr-Commit-Position: refs/heads/master@{#383135}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds the remaining copy constructors for complex classes.
After this patch, it should be possible to enable the heavy class copy
constructor checks by default.
R=thakis@chromium.org, dcheng@chromium.org
TBR=jam@chromium.org
BUG=436357
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1825273002
Cr-Commit-Position: refs/heads/master@{#383131}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduce a base class device_sensor_message_filter.{h,cc} and make the
other sensor-related message filters derive from it. This removes
duplicate code and saves a few lines and bytes.
BUG=
TBR=avi@chromium.org
Review URL: https://codereview.chromium.org/1813223002
Cr-Commit-Position: refs/heads/master@{#383125}
|
|
|
|
|
|
|
|
|
|
|
|
| |
The short audio/video duration in MediaSessionTest was too short. Their
playback state in the DOM is very flaky. This CL make them longer to
reduce the flakiness.
BUG=597694
Review URL: https://codereview.chromium.org/1833703002
Cr-Commit-Position: refs/heads/master@{#383123}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Smart revert version of auto revert in https://crrev.com/1127343003/
Original description -------------------------------------------------
Revert of media: Add MediaOzonePlatform support (patchset #7 id:110001 of https://codereview.chromium.org/269673005/)
Reason for revert:
Not used at the moment.
Agreed with kalyan.kondapally@intel.com,
tiago.vignatti@intel.com and
joone.hur@intel.com.
Original issue's description:
> media: Add MediaOzonePlatform support
>
> This CL adds MediaOzonePlatform, a new Ozone component for abstracting media
> and related. In particular it adds CreateVideoDecodeAccelerator method so Ozone
> implementations can use that for abstracting video decoding acceleration (i.e.
> GPU based video decoding). Eventually MediaOzonePlatform will be used as well
> for many windowing systems abstractions related to media, e.g. video encode,
> audio, etc. We will add support for these others as needed.
>
> Media platform is called and created on demand whenever a video playback is set
> to play. Different than ui::OzonePlatform methods, the one added in here is
> non-pure virtual so the implementations can decide themselves whether a video
> implementation is actually wanted, based on its hardware capabilities.
>
> This work is aimed at internal implementations like Ozone-DRI, Ozone-test but
> also for externals like Ozone-Wayland. Different targets like Chromium Browser,
> Chrome OS, ChromeCast and others can now take advantage of it.
>
> BUG=380884
> TEST=manually on Ozone-Wayland, using:
>
> $ export GYP_DEFINES='chromeos=0 use_ozone=1 proprietary_codecs=1 ffmpeg_branding=Chrome'
> $ ninja -j16 -C out/Release content
>
> and to run:
>
> ~/git/chromium/src/out/Debug$ ./chrome --no-sandbox --user-data-dir=/tmp/chrome --ignore-gpu-blacklist ../../third_party/WebKit/PerformanceTests/resources/bear-1280x720.mp4 --vmodule=*/ozone/ui*=3 --v=0
>
> additionally, in Release builds you can start chrome with --disable-accelerated-video-decode to compare the results.
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276552
TBR= rjkroege@chromium.org,dnicoara@chromium.org,spang@chromium.org,dongseong.hwang@intel.com,xhwang@chromium.org,tiago.vignatti@intel.com
BUG=380884
Review URL: https://codereview.chromium.org/1832743002
Cr-Commit-Position: refs/heads/master@{#383120}
|