summaryrefslogtreecommitdiffstats
path: root/dbus
Commit message (Collapse)AuthorAgeFilesLines
...
* dbus: Missing signals racedtapuska2015-01-231-11/+14
| | | | | | | | | | | | | | | | | It was possible when running the dbus in single thread mode that dbus signals could get lost. This was occurring due to a race in connecting to the signal vs when the signal was posted. Since the ConnectToSignal would fire on a PostTask but the processing of signals would happen directly this could cause a situation where a signal was in the task queue but the ConnectToSignalInternal call was after it. BUG=451098 Review URL: https://codereview.chromium.org/868753003 Cr-Commit-Position: refs/heads/master@{#312843}
* Move the test template to //testing/test.gni (part 2)qsr2015-01-211-0/+1
| | | | | | | | | | | | This CL move the test target from build/config/BUILDCONFIG.gn to testing/test.gni It also update the test template to automatically build an apk on Android. R=cjhopman@chromium.org,brettw@chromium.org Review URL: https://codereview.chromium.org/824263004 Cr-Commit-Position: refs/heads/master@{#312396}
* Add content unittests to the GN build.brettw2015-01-131-1/+3
| | | | | | | | | | Note that the binary does not appear to run correctly. TBR=dpranke Review URL: https://codereview.chromium.org/850523002 Cr-Commit-Position: refs/heads/master@{#311213}
* Standardize usage of virtual/override/final specifiers in dbus/.dcheng2014-12-2910-40/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. Several formatting edits by clang-format were manually reverted, due to mangling of some of the more complicate IPC macros. BUG=417463 Review URL: https://codereview.chromium.org/802213003 Cr-Commit-Position: refs/heads/master@{#309710}
* Make callers of CommandLine use it via the base:: namespace.avi2014-12-221-1/+1
| | | | | | | | | | | | Covers courgette/, dbus/, device/, extensions/, gin/, google_apis/, and gpu/. BUG=422426 TEST=none TBR=ben@chromium.org Review URL: https://codereview.chromium.org/819193002 Cr-Commit-Position: refs/heads/master@{#309490}
* Fix some override usage in dbus/dmichael2014-12-191-3/+3
| | | | | | | | | | | | Currently, the Clang style checker ignores templates. In order to turn it on, we first must fix latent style violations. This CL covers dbus/ BUG=441916 TBR=stevenjb@chromium.org Review URL: https://codereview.chromium.org/813403002 Cr-Commit-Position: refs/heads/master@{#309253}
* Exit chrome when dbus-daemon crasheshashimoto2014-12-093-51/+4
| | | | | | | | BUG=432980 Review URL: https://codereview.chromium.org/746373003 Cr-Commit-Position: refs/heads/master@{#307419}
* Remove dbus::ObjectProxy::filter_added_hashimoto2014-12-046-73/+18
| | | | | | | | | | Bus::Add/RemoveFilterFunction is already performing duplication check. BUG=None Review URL: https://codereview.chromium.org/747903004 Cr-Commit-Position: refs/heads/master@{#306781}
* gn format // (the rest, except mojo)scottmg2014-12-031-16/+8
| | | | | | | | | | | | | | Excluded mojo because I think that needs to happen on the other side. At gn --version = 306668 for which roll is in CQ. R=brettw@chromium.org TBR=scherkus@chromium.org BUG=348474 Review URL: https://codereview.chromium.org/774353003 Cr-Commit-Position: refs/heads/master@{#306708}
* change OVERRIDE to override in dbus/object_manager.h in commentmostynb2014-10-161-1/+1
| | | | | | | | | TBR=keybuk@chromium.org BUG=417463 Review URL: https://codereview.chromium.org/652663002 Cr-Commit-Position: refs/heads/master@{#299962}
* Add missing member initialization to dbus::TestService.earthdok2014-10-081-1/+5
| | | | | | | | | | | Fix a bug detected by MemorySanitizer. BUG=421109 R=stevenjb@chromium.org Review URL: https://codereview.chromium.org/632363003 Cr-Commit-Position: refs/heads/master@{#298691}
* Replacing the OVERRIDE with override and FINAL with final in /src/dbusanujk.sharma2014-10-076-12/+12
| | | | | | | | | | | This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Review URL: https://codereview.chromium.org/629883003 Cr-Commit-Position: refs/heads/master@{#298415}
* Move inline som functions ScopedDBusError into a .cc fileavakulenko2014-09-244-9/+31
| | | | | | | | | | | | | | | | dbus::ScopedDBusError has inline constructor/destructor and is_set() method that call into libdbus-1. By placing these function calls in a header file, we add implicit link dependency on components that need to use ScopedDBusError. If we move them out to a .cc file, the dependency will be localized to libchrome. BUG=chromium:416628 TEST=dbus_unittests pass Review URL: https://codereview.chromium.org/592793004 Cr-Commit-Position: refs/heads/master@{#296478}
* Replace forward_dependent_configs with public_depsBrett Wilson2014-09-231-1/+1
| | | | | | | | | | | | This is the new name. It has the same meaning but additionally with a "you can use the headers" permission. Rename direct_dependent_configs to public_configs. This is the new name with identical meaning. TBR=jamesr Review URL: https://codereview.chromium.org/595073002 Cr-Commit-Position: refs/heads/master@{#296302}
* Add ObjectProxy::CallMethodAndBlockWithErrorDetails methodsavakulenko2014-09-174-11/+70
| | | | | | | | | | | | | | | | | Currently, ObjectProxy::CallMethodAndBlock() returns NULL on failure but the D-Bus error details are not passed to the caller. Added a method that would return the D-Bus error information to the caller and switched ObjectProxy::CallMethodAndBlock() to use the new method instead. BUG=chromium:414838 TEST=Build Chrome TEST=ninja -C out/Debug dbus_unittests && out/Debug/dbus_unittests Review URL: https://codereview.chromium.org/563763004 Cr-Commit-Position: refs/heads/master@{#295212}
* dbus: Introduce util_unittest.ccarmansito2014-09-083-0/+18
| | | | | | | | | | | This CL introduces util_unittest.cc, which acts as a place for current and future functions in util.h. BUG=411108 Review URL: https://codereview.chromium.org/552433002 Cr-Commit-Position: refs/heads/master@{#293793}
* Add lots of testonly annotations to the GN build.Brett Wilson2014-09-081-0/+2
| | | | | | | | | BUG= R=hclam@chromium.org Review URL: https://codereview.chromium.org/547793002 Cr-Commit-Position: refs/heads/master@{#293774}
* dbus::ObjectManager: Add a match rule for properties before GetManagedObjects.armansito2014-09-0513-53/+453
| | | | | | | | | | | | | | | | | | | There is a race condition in the way that match rules get set up for object proxies created in response to GetManagedObjects that may cause us the miss PropertiesChanged signals if they're received before the match rule and filter function get added by ObjectProxy. This patch changes this to work the "intended" way: ObjectManager now adds a single match rule for its corresponding service name, and specifically for the org.freedesktop.DBus.Properties.PropertiesChanged signal. Once it receives the signal, ObjectManager dispatches the signal to the corresponding PropertySet. BUG=407109,400768 TEST=dbus_unittests Review URL: https://codereview.chromium.org/510863002 Cr-Commit-Position: refs/heads/master@{#293551}
* Plug some of the leaks in dbus_unittests.earthdok2014-09-035-56/+103
| | | | | | | | | | | | Also, remove the deprecated base::MessageLoop::Run() calls everywhere in dbus unittests. BUG=365669 R=armansito@chromium.org Review URL: https://codereview.chromium.org/523623003 Cr-Commit-Position: refs/heads/master@{#293113}
* Disable slow SignalSenderVerificationTest.TestSignalRejectedPaweł Hajdan, Jr2014-08-251-1/+2
| | | | | | | | | | TBR=haruki BUG=407063 Review URL: https://codereview.chromium.org/501953002 Cr-Commit-Position: refs/heads/master@{#291664}
* Undo a rename of dbus::Message::GetSignature.benchan2014-08-252-3/+3
| | | | | | | | | | | | | dbus::Message::GetSignature() was incorrectly renamed to dbus::Message::GetDataSigature() in https://codereview.chromium.org/502793002. This CL undoes that. BUG=None TEST=dbus_unittests Review URL: https://codereview.chromium.org/494263003 Cr-Commit-Position: refs/heads/master@{#291660}
* Add a GetSignature() method to dbus::MessageReader.benchan2014-08-253-3/+55
| | | | | | | | | | | | | The new MessageReader::GetSignature() method returns the DBus signature of the value at the current iterator position, which is needed for implementing automatic de-serialization of complex DBus messages. BUG=None TEST=dbus_unittests Review URL: https://codereview.chromium.org/502793002 Cr-Commit-Position: refs/heads/master@{#291643}
* Reduce DBus ObjectUnknown ERROR to WARNINGstevenjb@chromium.org2014-08-082-6/+16
| | | | | | | | | BUG=401571 Review URL: https://codereview.chromium.org/455533002 Cr-Commit-Position: refs/heads/master@{#288446} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288446 0039d316-1c4b-4281-b951-d872f2087c98
* don't pretend to support dbus on windows in dbus_export.hmostynb@opera.com2014-08-071-10/+3
| | | | | | | | | | Since dbus is only used on linux, don't bother with windows specific symbol exporting. BUG=398644 Review URL: https://codereview.chromium.org/429043003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288034 0039d316-1c4b-4281-b951-d872f2087c98
* dbus: don't add attributes in extern template class specializationmostynb@opera.com2014-07-301-14/+14
| | | | | | | | | | | | | | | | This previous CL added attributes to some template specializations: https://codereview.chromium.org/408143012 This breaks gcc 4.8, which gives the following warning: ../../dbus/property.h:412:62: error: type attributes ignored after type is already defined [-Werror=attributes] Since the template class already has the attribute, I suspect that the additional attribute specifications are redundant. ie I think we can remove them. Review URL: https://codereview.chromium.org/423233003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286567 0039d316-1c4b-4281-b951-d872f2087c98
* [DBus] Explicitly instantiate dbusProperty varianttzik@chromium.org2014-07-252-0/+29
| | | | | | | | | dbus::Property<std::vector<uint8> > isn't instantiated in libdbus in non-ChromeOS build + latest clang. That causes instantiation of the template in dbus_unittests, and causes link failure. Review URL: https://codereview.chromium.org/408143012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285475 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup test_support target names.tfarina@chromium.org2014-07-221-4/+4
| | | | | | | | | | | | | | | | | | | In GN it is redundat to include the parent directory name, as in ui/gfx:gfx_test_support. Instead we can write it as ui/gfx:test_support which is shorter and nicer to read. Targets found with the following command line: $ for f in $(g ls-files | grep BUILD); do grep _test_support $f; echo $f; done BUG=None TEST=None R=brettw@chromium.org TBR=darin@chromium.org Review URL: https://codereview.chromium.org/409493002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284800 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up Chrome OS WARNING spamstevenjb@chromium.org2014-07-171-2/+3
| | | | | | | | | | BUG=393266 For log only change to profile_io_data.cc (reviewed by mattm) TBR=mmenke@chromium.org Review URL: https://codereview.chromium.org/385993004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283648 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of [DBus] Explicitly instantiate dbus::Property variants ↵tzik@chromium.org2014-06-271-15/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/354553002/) Reason for revert: This causes link error: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/48613/steps/compile/logs/stdio Original issue's description: > [DBus] Explicitly instantiate dbus::Property variants > > dbus::Property<std::vector<uint8> > isn't instantiated in libdbus in non-ChromeOS build + latest clang. > That causes instantiation of the template in dbus_unittests, and causes link failure. > > BUG= > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280264 TBR=keybuk@chromium.org NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/353063007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280267 0039d316-1c4b-4281-b951-d872f2087c98
* [DBus] Explicitly instantiate dbus::Property variantstzik@chromium.org2014-06-271-1/+15
| | | | | | | | | | | dbus::Property<std::vector<uint8> > isn't instantiated in libdbus in non-ChromeOS build + latest clang. That causes instantiation of the template in dbus_unittests, and causes link failure. BUG= Review URL: https://codereview.chromium.org/354553002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280264 0039d316-1c4b-4281-b951-d872f2087c98
* More work on content/browser GN build.brettw@chromium.org2014-06-121-1/+1
| | | | | | | | | | | Still not hooked up and not quite everything compiles but this should be the bulk of the functionality. BUG= R=scottmg@chromium.org Review URL: https://codereview.chromium.org/328313003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276774 0039d316-1c4b-4281-b951-d872f2087c98
* Remove PlatformFile from dbus/file_descriptorrvargas@chromium.org2014-06-071-4/+6
| | | | | | | | BUG=322664 Review URL: https://codereview.chromium.org/307423005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275563 0039d316-1c4b-4281-b951-d872f2087c98
* Add GN build file for dbus.tfarina@chromium.org2014-06-031-0/+127
| | | | | | | | | | | | BUG=None TEST=None R=scottmg@chromium.org TBR=satorux@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/301233007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274491 0039d316-1c4b-4281-b951-d872f2087c98
* dbus/values_util.h: Add functions to append collection type values to message.armansito@chromium.org2014-05-223-2/+313
| | | | | | | | | | | | | | Added functions AppendValueData and AppendValueDataAsVariant to values_util.h. These functions are useful for writing both basic types and variant lists and dictionaries to a message writer. Lists and dictionaries are written with type "av" and "a{sv}", respectively. BUG=359413 TEST=dbus_unittests,chromeos_unittests Review URL: https://codereview.chromium.org/221393004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272167 0039d316-1c4b-4281-b951-d872f2087c98
* Move IsStringUTF8/ASCII to base namespacebrettw@chromium.org2014-05-071-1/+1
| | | | | | | | TBR=sky@chromium.org Review URL: https://codereview.chromium.org/270183002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268754 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 257524 "Move IsStringASCII/UTF8 to base namespace."brettw@chromium.org2014-03-171-1/+1
| | | | | | | | | | | | | | | | > Move IsStringASCII/UTF8 to base namespace. > > Use StringPiece for IsStringUTF8. > > TBR=sky > > Review URL: https://codereview.chromium.org/196793010 TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/198163004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257533 0039d316-1c4b-4281-b951-d872f2087c98
* Move IsStringASCII/UTF8 to base namespace.brettw@chromium.org2014-03-171-1/+1
| | | | | | | | | | Use StringPiece for IsStringUTF8. TBR=sky Review URL: https://codereview.chromium.org/196793010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257524 0039d316-1c4b-4281-b951-d872f2087c98
* dbus: Add template specialization for Property<vector<uint8> >.armansito@chromium.org2014-03-154-1/+81
| | | | | | | | | BUG=351229 TEST=dbus_unittests Review URL: https://codereview.chromium.org/199573003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257315 0039d316-1c4b-4281-b951-d872f2087c98
* dbus: Handle NameOwnerChanged in ObjectManagerkeybuk@chromium.org2014-03-075-0/+133
| | | | | | | | | | | | | | | | Since the ObjectManager class managers the set of object proxies and properties structures for remote service it needs to handle the NameOwnerChanged signal, deleting the current set of objects when a previously owned name changes to a new owner (or is released) and re-requesting the set of managed objects when a name is claimed by a new owner. BUG=346975 TEST=dbus_unittests Review URL: https://codereview.chromium.org/177703006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255495 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Make dbus::MessageReader memory ownership explicitderat@chromium.org2014-02-243-14/+20
| | | | | | | | | | | | | | | | Make memory returned by MessageReader::PopArrayOfBytes() const to make it clearer that ownership remains with the MessageReader. Also update PopArrayOfStrings() and PopArrayOfObjectPaths() to clear the passed-in vectors before appending to them. BUG=none TBR=isherman@chromium.org,mvanouwerkerk@chromium.org Review URL: https://codereview.chromium.org/176693003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252922 0039d316-1c4b-4281-b951-d872f2087c98
* dbus: Add comments about the right way to expose methodssatorux@chromium.org2014-01-094-12/+27
| | | | | | | | | | | Along the way, fix the order in the test service used in unit tests. BUG=332120 TEST=dbus_unittests pass as before Review URL: https://codereview.chromium.org/125673003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243770 0039d316-1c4b-4281-b951-d872f2087c98
* dbus: Always return "not yet handled" for signalshashimoto@chromium.org2013-12-171-1/+3
| | | | | | | | BUG=327172 Review URL: https://codereview.chromium.org/115173002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241222 0039d316-1c4b-4281-b951-d872f2087c98
* Run dbus_unittests serially.phajdan.jr@chromium.org2013-12-062-1/+31
| | | | | | | | | | | Also fix a bug that prevented that from actually working. BUG=236893 R=stevenjb@chromium.org Review URL: https://codereview.chromium.org/108563003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239269 0039d316-1c4b-4281-b951-d872f2087c98
* Move RemoveChars, ReplaceChars, TrimString, and TruncateUTF8ToByteSize to ↵brettw@chromium.org2013-12-031-1/+1
| | | | | | | | | | | base namespace. BUG= R=viettrungluu@chromium.org Review URL: https://codereview.chromium.org/102843002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238465 0039d316-1c4b-4281-b951-d872f2087c98
* Track active references in ShillClientHelper (Take 3)stevenjb@chromium.org2013-10-072-3/+5
| | | | | | | | | | | | | | To prevent Shill Service DBus ObjectProxy instances from accumulating, remove them when the service becomes inactive. Hopefully includes ASAN fixes. BUG=223483 TBR=hashimoto@chromium.org Review URL: https://codereview.chromium.org/26289002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227371 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 227100 "Track active references in ShillClientHelper (Tak..."stevenjb@chromium.org2013-10-041-2/+0
| | | | | | | | | | | | | | | | | | | | | | > Track active references in ShillClientHelper (Take 2) > To prevent Shill Service DBus ObjectProxy instances from accumulating, > remove them when the service becomes inactive. > > Original CL: https://codereview.chromium.org/23658053/ > > BUG=223483 > TBR=hashimoto@chromium.org > > Review URL: https://codereview.chromium.org/24558004 Failure: http://build.chromium.org/p/chromium.memory/builders/Chromium%20OS%20%28amd64%29%20ASAN/builds/6931 TBR=stevenjb@chromium.org Review URL: https://codereview.chromium.org/26075002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227139 0039d316-1c4b-4281-b951-d872f2087c98
* Track active references in ShillClientHelper (Take 2)stevenjb@chromium.org2013-10-041-0/+2
| | | | | | | | | | | | | | To prevent Shill Service DBus ObjectProxy instances from accumulating, remove them when the service becomes inactive. Original CL: https://codereview.chromium.org/23658053/ BUG=223483 TBR=hashimoto@chromium.org Review URL: https://codereview.chromium.org/24558004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227100 0039d316-1c4b-4281-b951-d872f2087c98
* dbus: Add ObjectProxy::WaitForServiceToBeAvailable()hashimoto@chromium.org2013-10-024-14/+170
| | | | | | | | | | | | | | Split ConnectToNameOwnerChangedSignal() from ConnectToSignalInternal(). Add WaitForServiceToBeAvailable() Add test. BUG=141009 TEST=dbus_unittests R=satorux@chromium.org Review URL: https://codereview.chromium.org/25488002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226428 0039d316-1c4b-4281-b951-d872f2087c98
* dbus: Stop accessing ObjectProxy::name_owner_changed_callback_ on the D-Bus ↵hashimoto@chromium.org2013-09-273-27/+32
| | | | | | | | | | | | | | | thread Accessing the callback on the D-Bus thread while changing its value may result in a race condition. Change the type of SetNameOwnerChangedCallback's argument from Signal to strings to stop worrying about on which thread the Signal gets released. BUG=298747 TEST=dbus_unittests R=satorux@chromium.org Review URL: https://codereview.chromium.org/24673006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225675 0039d316-1c4b-4281-b951-d872f2087c98
* dbus: Rewrite ObjectProxy::ConnectToSignal with PostTaskAndReplyWithResulthashimoto@chromium.org2013-09-262-76/+51
| | | | | | | | | | BUG=None TEST=dbus_unittests R=satorux@chromium.org Review URL: https://codereview.chromium.org/24557002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225362 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-05-10 13:09:31 +0000