summaryrefslogtreecommitdiffstats
path: root/dbus
Commit message (Collapse)AuthorAgeFilesLines
* Remove logging::LogAtLevel and rewrite its sole caller.jbroman2016-01-221-7/+9
| | | | | | | | | | | | This method causes log statements attributed to logging.h (inside the LogAtLevel function) to be written, which is less than useful. It only has one caller, which can easily be adjusted to use the ordinary LOG(...) macro with a small adjustment. After this change, the log output is correctly attributed to object_proxy.cc. Review URL: https://codereview.chromium.org/1609563002 Cr-Commit-Position: refs/heads/master@{#370905}
* dbus: Run dbus_unittests parallellyhashimoto2016-01-053-16/+2
| | | | | | | | | | | After http://crrev.com/367499, it should be safe to run dbus_unittests parallelly. BUG=571274 TEST=dbus_unittests Review URL: https://codereview.chromium.org/1554403002 Cr-Commit-Position: refs/heads/master@{#367559}
* dbus: Use randomly generated string as a TestService's service namehashimoto2016-01-058-32/+49
| | | | | | | | | | | To run tests parallelly. BUG=571274 TEST=dbus_unittests Review URL: https://codereview.chromium.org/1559873005 Cr-Commit-Position: refs/heads/master@{#367499}
* Global conversion of Pass()→std::move() on OS==linuxdcheng2015-12-284-20/+22
| | | | | | | | | | | | ❆(੭ु ◜◡‾)੭ु⁾☃❆ BUG=557422 R=avi@chromium.org TBR=jam@chromium.org Review URL: https://codereview.chromium.org/1550693002 Cr-Commit-Position: refs/heads/master@{#366956}
* Switch to standard integer types in dbus/.avi2015-12-2225-281/+320
| | | | | | | | | BUG=138542 TBR=hashimoto@chromium.org Review URL: https://codereview.chromium.org/1541193002 Cr-Commit-Position: refs/heads/master@{#366617}
* Run dbus_unittests serially.thestig2015-12-211-1/+1
| | | | | | | | | | | | Otherwise, they will conflict with each other over the ownership of the test DBus service. BUG=571274 TBR=hashimoto@chromium.org Review URL: https://codereview.chromium.org/1547503002 Cr-Commit-Position: refs/heads/master@{#366466}
* Remove the NoAtExitBaseTestSuite anti-pattern.jam2015-12-111-20/+4
| | | | | | | | A bunch of unit tests were deriving from base::TestSuite and telling it to not create an AtExitManager, while at the same time they were creating an AtExitManager. Just use the base::TestSuite directly which creates the AtExitManager. This follows similar cleanup I did in r362157. Review URL: https://codereview.chromium.org/1512053002 Cr-Commit-Position: refs/heads/master@{#364590}
* Remove old C++03 move emulation code.dcheng2015-12-012-10/+7
| | | | | | | | | | | Chrome allows the use of C++11 features now, so just use rvalue references directly. BUG=543901 Review URL: https://codereview.chromium.org/1407443002 Cr-Commit-Position: refs/heads/master@{#362394}
* Fix documentation for ObjectProxy::ConnectToSignal()quiche2015-10-231-2/+6
| | | | | | | | | | | | | | The documentation for ObjectProxy::ConnectToSignal() differs from the method's actual behavior. Fix this, by updating the documentation. BUG=545139 R=hashimoto@chromium.org TEST=compile Review URL: https://codereview.chromium.org/1406923005 Cr-Commit-Position: refs/heads/master@{#355785}
* dbus: add support for synchronous PropertySet::Getnywang2015-09-282-4/+46
| | | | | | | | | | | | | | | | The existing PropertySet::Get function is asynchronous. This CL adds the synchronous version of PropertySet::Get. It is defined as PropertySet::GetAndBlock. Also fix some typos and indent problems in previous introduced SetAndBlock(). BUG=https://b.corp.google.com/u/0/issues/24131409 TEST=manually tested Review URL: https://codereview.chromium.org/1368713002 Cr-Commit-Position: refs/heads/master@{#351185}
* libchrome: add support for synchronous PropertySet::Set to dbusnywang2015-09-232-0/+24
| | | | | | | | | | | | | The existing PropertySet::Set function is asynchrounous. This CL adds the synchrounous version of PropertySet::Set. It is defined as PropertySet::SetAndBlock. BUG=https://b.corp.google.com/u/0/issues/24131409 TEST=manually tested Review URL: https://codereview.chromium.org/1361503003 Cr-Commit-Position: refs/heads/master@{#350268}
* IntToString() signedness fixes for //dbusricea2015-09-181-11/+10
| | | | | | | | | | | | | | | | | | Use UintToString() rather than IntToString() for unsigned types, to improve correctness. Also replace some trivial usages of StringPrintf() with the appropriate IntToString() variants, to improve performance, code size and type safety. No behavioural changes are intended. BUG=505479 TEST=dbus_unittests Review URL: https://codereview.chromium.org/1349493004 Cr-Commit-Position: refs/heads/master@{#349785}
* Export various dbus::Property template specializations.dcheng2015-09-181-87/+154
| | | | | | | | | | | BUG=409111 R=stevenjb@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/40855d43fa71c215829b53a1034b1b653b4b8557 Review URL: https://codereview.chromium.org/1339763003 Cr-Commit-Position: refs/heads/master@{#349717}
* Revert of Export various dbus::Property template specializations. (patchset ↵spang2015-09-141-143/+87
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | #2 id:20001 of https://codereview.chromium.org/1339763003/ ) Reason for revert: Does not compile with component=shared_library with CrOS compiler ../../dbus/property.h:437:42: error: type attributes ignored after type is already defined [-Werror=attributes] extern template class CHROME_DBUS_EXPORT Property<uint8>; ^ ../../dbus/property.h:447:42: error: type attributes ignored after type is already defined [-Werror=attributes] extern template class CHROME_DBUS_EXPORT Property<bool>; Repro steps: cros chrome-sdk --board=amd64-generic --component gclient runhooks ninja -C out_amd64-generic/Release dbus Original issue's description: > Export various dbus::Property template specializations. > > BUG=409111 > R=stevenjb@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/40855d43fa71c215829b53a1034b1b653b4b8557 TBR=stevenjb@chromium.org,thakis@chromium.org,dcheng@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=409111 Review URL: https://codereview.chromium.org/1337113005 Cr-Commit-Position: refs/heads/master@{#348651}
* Export various dbus::Property template specializations.Daniel Cheng2015-09-131-87/+143
| | | | | | | | | BUG=409111 R=stevenjb@chromium.org Review URL: https://codereview.chromium.org/1339763003 . Cr-Commit-Position: refs/heads/master@{#348536}
* Annotate GN executables and shared_libraries with sanitizer deps.brettw2015-08-311-0/+1
| | | | | | | | | | | | | | | | | These are needed to link in asan/lsan/etc. mode. GYP injects these automatically but GN doesn't have automatic dependency injection. All tests and components (which cover the vast majority of such targets in actual use) are templates which add these dependencies already, so most of the time it never comes up. Only a few of these changes are actually necessary to link all tests run on the asan bot (which is also what engineers will typically build, since almost nobody will build all in asan mode). But to reduce confusion from linker errors in asan mode, I annotated all executables and shared libraries I could find with the sanitizer dependency. I moved a config out of a target in yasm, and sorted a fews deps on other targets. TBR=xhwang@chromium.org (widevine) TBR=achuith@chromium.org (tools/perf, tools/telemetry) Review URL: https://codereview.chromium.org/1318343003 Cr-Commit-Position: refs/heads/master@{#346490}
* Explicitly set test_proto.proto's syntax.thakis2015-08-271-1/+3
| | | | | | | | | | | No behavior change, but new protobuf versions warn about the absence of this line and all other our .proto files have it. BUG=525255 Review URL: https://codereview.chromium.org/1318083004 Cr-Commit-Position: refs/heads/master@{#346007}
* dbus: Suppress "Rejecting a message from a wrong sender" error from ↵satorux2015-08-171-6/+13
| | | | | | | | | | | | | | | | | | | | | ObjectManager The error message was a false alarm that was polluting the log file. ObjectManager::HandleMessage() is called for *every instance of ObjectManager* whenever a message is delivered. It's the right thing for an ObjectManager instance to ignore a signal that the instance is not interested in. Note that the service owner name change is handled via ObjectManager::NameOwnerChanged(), that's set up in the ObjectManager's constructor hence ObjectManager can handle name owner changes. BUG=507206 TEST=enable/disable Bluetooth and confirm that the error message is no longer emitted in the log file. Review URL: https://codereview.chromium.org/1297903002 Cr-Commit-Position: refs/heads/master@{#343656}
* Remove some legacy versions of StartsWith and EndsWith.brettw2015-07-161-6/+4
| | | | | | | | | | | | | | | | | | | This just replaces true -> base::CompareCase::SENSITIVE false -> base::CompareCase::INSENSITIVE_ASCII I checked the insensitive cases to make sure they're not doing anything suspicious. The old version is a sometimes-correct Unicode comparison so converting to INSENSTITIVE_ASCII isn't a no-op. However, generally the prefix/suffix checking is done against a hardcoded string so there were very few cases to actually look at. extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc has a not-quite search-and-replace change where I changed the type of a class variable. BUG=506255 TBR=jam Reland of http://crrev.com/1239493005 Review URL: https://codereview.chromium.org/1233043003 Cr-Commit-Position: refs/heads/master@{#339071}
* dbus: Add missing destructors to Property and PropertyBase.derat2015-07-162-2/+8
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/1237343003 Cr-Commit-Position: refs/heads/master@{#339031}
* Revert of Remove some legacy versions of StartsWith and EndsWith. (patchset ↵yosin2015-07-161-4/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | #6 id:100001 of https://codereview.chromium.org/1239493005/) Reason for revert: Compilation error on Windows: FAILED: ninja -t msvc -e environment.x86 -- C:\b\build\goma/gomacc "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\chrome\installer\gcapi\gcapi_lib.gcapi.obj.rsp /c ..\..\chrome\installer\gcapi\gcapi.cc /Foobj\chrome\installer\gcapi\gcapi_lib.gcapi.obj /Fdobj\chrome\gcapi_lib.cc.pdb c:\b\build\slave\win-latest-rel\build\src\chrome\installer\gcapi\gcapi.cc(365) : error C3083: 'StartsWith': the symbol to the left of a '::' must be a type c:\b\build\slave\win-latest-rel\build\src\chrome\installer\gcapi\gcapi.cc(365) : error C2039: 'INSENSITIVE_ASCII' : is not a member of 'base' c:\b\build\slave\win-latest-rel\build\src\chrome\installer\gcapi\gcapi.cc(365) : error C2065: 'INSENSITIVE_ASCII' : undeclared identifier ninja: build stopped: subcommand failed. Original issue's description: > Remove some legacy versions of StartsWith and EndsWith. > > This just replaces > true -> base::CompareCase::SENSITIVE > false -> base::CompareCase::INSENSITIVE_ASCII > > I checked the insensitive cases to make sure they're not doing anything suspicious. The old version is a sometimes-correct Unicode comparison so converting to INSENSTITIVE_ASCII isn't a no-op. However, generally the prefix/suffix checking is done against a hardcoded string so there were very few cases to actually look at. > > extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc has a not-quite search-and-replace change where I changed the type of a class variable. > > BUG=506255 > TBR=jam > > Committed: https://crrev.com/edce9a33027cc5f73c4866d70e34f690f6720a56 > Cr-Commit-Position: refs/heads/master@{#338996} TBR=jam@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=506255 Review URL: https://codereview.chromium.org/1233453011 Cr-Commit-Position: refs/heads/master@{#338998}
* Remove some legacy versions of StartsWith and EndsWith.brettw2015-07-161-6/+4
| | | | | | | | | | | | | | | | | This just replaces true -> base::CompareCase::SENSITIVE false -> base::CompareCase::INSENSITIVE_ASCII I checked the insensitive cases to make sure they're not doing anything suspicious. The old version is a sometimes-correct Unicode comparison so converting to INSENSTITIVE_ASCII isn't a no-op. However, generally the prefix/suffix checking is done against a hardcoded string so there were very few cases to actually look at. extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc has a not-quite search-and-replace change where I changed the type of a class variable. BUG=506255 TBR=jam Review URL: https://codereview.chromium.org/1239493005 Cr-Commit-Position: refs/heads/master@{#338996}
* dbus: expose bus connection unique namezqiu2015-07-083-0/+30
| | | | | | | | | | | | | Add an API to Bus class to expose the unique name of the bus connection. The function will return an empty string if bus connection is not established. BUG=chromium:507718 TEST=unittest Review URL: https://codereview.chromium.org/1222073003 Cr-Commit-Position: refs/heads/master@{#337732}
* Replace StringPrintf("%d", ...) with IntToString()ricea2015-07-011-5/+6
| | | | | | | | | | | | | | | | | | | | | | | | IntToString() is faster, more compact and clearer than StringPrintf("%d", ...). This CL reduces the size of the text segment of a Linux "Official" build by 1001 bytes. This CL also adds a perftest to verify that IntToString() is faster than StringPrintf("%d", ...). Notes for reviewers: * courgette/memory_monitor.cc contains LOG(INFO) statements. I bypassed presubmit rather than remove them. * components/browser_watcher/watcher_client_win_unittest.cc passed a HANDLE through an int. I don't know why that worked on Win64. I have tried to make it 64-bit safe. BUG=504372 TEST=compile, selected unit tests TBR=stevenjb@chromium.org NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1213443002 Cr-Commit-Position: refs/heads/master@{#337027}
* Don't attempt to validate invalid DBus-passed file descriptors.reillyg2015-06-251-0/+5
| | | | | | | | | | | | | | | | | If an invalid file descriptor (i.e. -1) is passed over DBus then it is impossible to determine if it is valid because the value() accessor requires CheckValidity() to be called first and this will trigger a DCHECK in base::File::GetInfo() because the file descriptor is invalid. The solution is to abort the validity check if file.IsValid() is false. This way after calling CheckValidity() is_valid() will indicate either that the file descriptor was unsafe (i.e. a directory) or invalid (i.e. -1). BUG=496469 Review URL: https://codereview.chromium.org/1211093002 Cr-Commit-Position: refs/heads/master@{#336276}
* Remove unnecessary message_loop_proxy.h includesskyostil2015-06-171-1/+0
| | | | | | | | | BUG=465354 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1165333003 Cr-Commit-Position: refs/heads/master@{#334844}
* Migrate callers of message_loop_proxy() to task_runner()skyostil2015-06-177-15/+15
| | | | | | | | | | | | | Migrate callers of {MessageLoop,Thread}::message_loop_proxy() to {MessageLoop,Thread}::task_runner(). Since the types at the call sites have already been updated, this is just a bulk rename. BUG=465354 TBR=armansito@chromium.org Review URL: https://codereview.chromium.org/1179163002 Cr-Commit-Position: refs/heads/master@{#334840}
* Move EndsWith to base namespace.brettw2015-06-121-1/+1
| | | | | | | | TBR=jschuh@chromium.org Review URL: https://codereview.chromium.org/1182183003 Cr-Commit-Position: refs/heads/master@{#334284}
* Move StartsWith[ASCII] to base namespace.brettw2015-06-121-1/+1
| | | | | | | | | NOPRESUBMIT=true (no presubmit due to removing base:: from a ScopedAllowIO) Review URL: https://codereview.chromium.org/1172183002 Cr-Commit-Position: refs/heads/master@{#334108}
* Make dbus::FileDescriptor a Pass()-movable type.reillyg2015-06-112-2/+31
| | | | | | | | | | | | | | This will make it possible to return a dbus::FileDescriptor from a function and bind it to a callback without wrapping it in a dbus::ScopedFileDescriptor. This will allow us to fix the generated DBus bindings to support methods that have file descriptors as output parameters. BUG=496469 Review URL: https://codereview.chromium.org/1170283005 Cr-Commit-Position: refs/heads/master@{#333901}
* Convert JsonWriter::Write to taking a const ref for the in-paramestade2015-05-162-6/+4
| | | | | | | | | | | | Clearer API; flushes out a lot of unnecessary heap allocations. depends on https://codereview.chromium.org/1129083003/ BUG=none Review URL: https://codereview.chromium.org/1131113004 Cr-Commit-Position: refs/heads/master@{#330255}
* Implement invalidation of Dbus propertiesjpawlowski2015-05-115-9/+142
| | | | | | | | | BUG=481247 R=armansito@chromium.org Review URL: https://codereview.chromium.org/1086363004 Cr-Commit-Position: refs/heads/master@{#329142}
* Add hashimoto@ to dbus/OWNERSsatorux2015-05-111-0/+1
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/1139683002 Cr-Commit-Position: refs/heads/master@{#329098}
* Re-land Move ScopedFileDescriptor to dbus/file_descriptor.hcmasone2015-04-272-0/+19
| | | | | | | | | | | | | | | | | | | | ScopedFileDescriptor was initially introduced to facilitate the management of a 'lifeline' FD used when asking permission_broker to open a port in the device's firewall on CrOS. It's actually a scoped wrapper around DBus::FileDescriptor, not a platform file descriptor. I would like to use it to facilitate some other similar functionality in which I create a pipe and pass one end over DBus, so it seems like a good idea to move ScopedFileDescriptor into the dbus library directly. This reverts commit ee9dc849ffa2df2820381c31d5ba8200774d287a. BUG=chromium:481340 TEST=FirewallHole unit tests still pass TBR=stevenjb, reillyg, keybuk Review URL: https://codereview.chromium.org/1108083003 Cr-Commit-Position: refs/heads/master@{#327141}
* Revert of Move ScopedFileDescriptor to dbus/file_descriptor.h (patchset #1 ↵spang2015-04-272-19/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:1 of https://codereview.chromium.org/1090243003/) Reason for revert: Breaks shared_library build with broken exports: ./../dbus/dbus_export.h:20:65: error: ignoring attributes applied to class type 'scoped_ptr<dbus::FileDescriptor, dbus::FileDescriptor::Deleter>' outside of definition [-Werror=attributes] #define CHROME_DBUS_EXPORT __attribute__((visibility("default"))) ^ ../../dbus/file_descriptor.h:81:57: note: in expansion of macro 'CHROME_DBUS_EXPORT' scoped_ptr<FileDescriptor, FileDescriptor::Deleter> CHROME_DBUS_EXPORT; Original issue's description: > Move ScopedFileDescriptor to dbus/file_descriptor.h > > ScopedFileDescriptor was initially introduced to facilitate the > management of a 'lifeline' FD used when asking permission_broker to > open a port in the device's firewall on CrOS. It's actually a scoped > wrapper around DBus::FileDescriptor, not a platform file descriptor. I > would like to use it to facilitate some other similar functionality in > which I create a pipe and pass one end over DBus, so it seems like a > good idea to move ScopedFileDescriptor into the dbus library directly. > > BUG=chromium:481340 > TEST=FirewallHole unit tests still pass > STATUS=Fixed > R=keybuk, reillyg, stevenjb > > Committed: https://crrev.com/b44fbaabbe9f91e63ad8aa164609a6b31e0de57e > Cr-Commit-Position: refs/heads/master@{#327089} TBR=keybuk@chromium.org,reillyg@chromium.org,stevenjb@chromium.org,cmasone@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:481340 Review URL: https://codereview.chromium.org/1108893003 Cr-Commit-Position: refs/heads/master@{#327103}
* Move ScopedFileDescriptor to dbus/file_descriptor.hcmasone2015-04-272-0/+19
| | | | | | | | | | | | | | | | | | | ScopedFileDescriptor was initially introduced to facilitate the management of a 'lifeline' FD used when asking permission_broker to open a port in the device's firewall on CrOS. It's actually a scoped wrapper around DBus::FileDescriptor, not a platform file descriptor. I would like to use it to facilitate some other similar functionality in which I create a pipe and pass one end over DBus, so it seems like a good idea to move ScopedFileDescriptor into the dbus library directly. BUG=chromium:481340 TEST=FirewallHole unit tests still pass STATUS=Fixed R=keybuk, reillyg, stevenjb Review URL: https://codereview.chromium.org/1090243003 Cr-Commit-Position: refs/heads/master@{#327089}
* dbus/values_util_unittest.cc: use sqrt from cmathHans Wennborg2015-04-241-1/+2
| | | | | | | | | | | | | | | | This should fix the following error on an ASan Linux builder: ../../dbus/values_util_unittest.cc:360:15: error: use of undeclared identifier 'sqrt' keys[i] = sqrt(values[i]); ^ BUG=none R=thakis@chromium.org TBR=satorux Review URL: https://codereview.chromium.org/1083323005 Cr-Commit-Position: refs/heads/master@{#326882}
* Removed obsolete float_util.h as VS2013 supports standards well enough.mateuszs2015-04-241-1/+0
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/1076443002 Cr-Commit-Position: refs/heads/master@{#326781}
* Update {virtual,override} to follow C++11 style in dbus.nick2015-04-231-4/+4
| | | | | | | | | | | | The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was manually generated using a regex and a text editor. BUG=417463 Review URL: https://codereview.chromium.org/1055053003 Cr-Commit-Position: refs/heads/master@{#326451}
* dbus: Use INT64_C macro from stdint.h.tfarina2015-04-201-2/+4
| | | | | | | | | | | | | Looks like GG_(U)INTn_C macros are deprecated (see base/port.h TODO), so we updated this to use the version from the standard library instead. BUG=None TEST=dbus_unittests R=keybuk@chromium.org Review URL: https://codereview.chromium.org/1077203003 Cr-Commit-Position: refs/heads/master@{#325903}
* Send DBus signals synchronously if called from the DBusTaskRunnerchirantan2015-04-092-7/+17
| | | | | | | | | | | | | | | | | | | | The Chrome OS power manager (powerd) does not use a dedicated task runner for handling DBus messages and defaults to using the same MessageLoop as the one on which the dbus::Bus object was created. An unfortunate effect of this is that if powerd calls ExportedObject::SendSignal and then ObjectProxy::CallMethodAndBlock without returning to the top level of the MessageLoop, the method call will actually go out before the signal since SendSignal is asynchronous. To deal with this, make ExportedObject::SendSignal synchronous when it is called from the same thread that hosts the DBusTaskRunner. BUG=472361 Review URL: https://codereview.chromium.org/1066193002 Cr-Commit-Position: refs/heads/master@{#324485}
* Fix memory leak in dbus::ObjectManager::RemoveInterfaceavakulenko2015-04-021-0/+1
| | | | | | | | | | | | | D-Bus Object Manager proxy class was leaking PropertySet object instances stored in properties_map when an interface was removed. Make sure we delete the PropertySet before we remove the map entry. BUG=472654 Review URL: https://codereview.chromium.org/1055713002 Cr-Commit-Position: refs/heads/master@{#323544}
* dbus: Cancel pending calls when destroying ObjectProxyhashimoto2015-03-303-5/+44
| | | | | | | | | | | | After this change, it is guaranteed that no callback is called for method calls after RemoveObjectProxy() is called. BUG=471175 TEST=dbus_unittests Review URL: https://codereview.chromium.org/1040683002 Cr-Commit-Position: refs/heads/master@{#322747}
* Stop deleting ObjectProxy::OnPendingCallIsCompleteData manuallyhashimoto2015-03-302-2/+8
| | | | | | | | | | | Instead, let libdbus handle it. This also makes it easier to implement method call cancellation. BUG=471175 Review URL: https://codereview.chromium.org/1032263002 Cr-Commit-Position: refs/heads/master@{#322746}
* Add more targets to GN check.brettw2015-02-201-1/+3
| | | | | | | | | | | | | Fix errors. Most of the problems were in net. Moves CreateAndConnectStreamForTesting's declaration to the header corresponding to the file it's implemented in. Adds the other directories that don't pass yet to the list commented out so it's easier to see what's still left. TBR=armansito@chromium.org Review URL: https://codereview.chromium.org/936953004 Cr-Commit-Position: refs/heads/master@{#317425}
* Revert of Add more targets to "gn check" (patchset #3 id:40001 of ↵rdevlin.cronin2015-02-201-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/940613002/) Reason for revert: This broken win8 gn bots because of an illegal include. ERROR at //device/usb/usb_service_impl.cc:21:11: Include not allowed. #include "device/core/device_monitor_win.h" e.g. https://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/4896/steps/gn%20check/logs/stdio Original issue's description: > Add more targets to "gn check" > > R=dpranke > TBR=armansito@chromium.org (bluetooth) > > Committed: https://crrev.com/8cac5f9d9c3847657b57783d30f861adb6c29cac > Cr-Commit-Position: refs/heads/master@{#317160} TBR=dpranke@chromium.org,armansito@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/941893002 Cr-Commit-Position: refs/heads/master@{#317204}
* Add more targets to "gn check"brettw2015-02-191-0/+1
| | | | | | | | | R=dpranke TBR=armansito@chromium.org (bluetooth) Review URL: https://codereview.chromium.org/940613002 Cr-Commit-Position: refs/heads/master@{#317160}
* Sort GN files under dbussatorux2015-02-131-2/+2
| | | | | | | | | BUG=456014 TEST=everything should build as before Review URL: https://codereview.chromium.org/920903003 Cr-Commit-Position: refs/heads/master@{#316177}
* chromeos::dbus lint errors.dtapuska2015-02-091-1/+4
| | | | | | | | | | Fix lint issues. BUG=453873 Review URL: https://codereview.chromium.org/900793007 Cr-Commit-Position: refs/heads/master@{#315421}
* Enhance the DBus interface for peerddtapuska2015-02-093-3/+230
| | | | | | | | | | | | | | Add ability to query properties of - Manager - Peer - Service Add Observer to peerd so we are told when things change. BUG=453873 Review URL: https://codereview.chromium.org/893663002 Cr-Commit-Position: refs/heads/master@{#315311}
generated by cgit v1.1 at 2024-04-27 17:34:21 +0000