summaryrefslogtreecommitdiffstats
path: root/dbus
diff options
context:
space:
mode:
authorderat <derat@chromium.org>2015-07-16 08:06:44 -0700
committerCommit bot <commit-bot@chromium.org>2015-07-16 15:08:02 +0000
commitdce1abec3dfcb2ee54545d2438368168308b3a92 (patch)
treed6b434bdf1ae91a0c8bcbc4722f7cee9dcd8bdff /dbus
parent30477b017a1c19797b16fec2474aebb350f7eda2 (diff)
downloadchromium_src-dce1abec3dfcb2ee54545d2438368168308b3a92.zip
chromium_src-dce1abec3dfcb2ee54545d2438368168308b3a92.tar.gz
chromium_src-dce1abec3dfcb2ee54545d2438368168308b3a92.tar.bz2
dbus: Add missing destructors to Property and PropertyBase.
BUG=none Review URL: https://codereview.chromium.org/1237343003 Cr-Commit-Position: refs/heads/master@{#339031}
Diffstat (limited to 'dbus')
-rw-r--r--dbus/property.cc4
-rw-r--r--dbus/property.h6
2 files changed, 8 insertions, 2 deletions
diff --git a/dbus/property.cc b/dbus/property.cc
index 66b86c0..dde0611 100644
--- a/dbus/property.cc
+++ b/dbus/property.cc
@@ -18,6 +18,10 @@ namespace dbus {
// PropertyBase implementation.
//
+PropertyBase::PropertyBase() : property_set_(nullptr), is_valid_(false) {}
+
+PropertyBase::~PropertyBase() {}
+
void PropertyBase::Init(PropertySet* property_set, const std::string& name) {
DCHECK(!property_set_);
property_set_ = property_set;
diff --git a/dbus/property.h b/dbus/property.h
index 321f4dbd..5f36d69 100644
--- a/dbus/property.h
+++ b/dbus/property.h
@@ -132,9 +132,10 @@ class PropertySet;
// the Property<> template that are not type-specific, such as the
// associated PropertySet, property name, and the type-unsafe parts
// used by PropertySet.
-class PropertyBase {
+class CHROME_DBUS_EXPORT PropertyBase {
public:
- PropertyBase() : property_set_(nullptr), is_valid_(false) {}
+ PropertyBase();
+ virtual ~PropertyBase();
// Initializes the |property_set| and property |name| so that method
// calls may be made from this class. This method is called by
@@ -367,6 +368,7 @@ template <class T>
class CHROME_DBUS_EXPORT Property : public PropertyBase {
public:
Property() {}
+ ~Property() override {}
// Retrieves the cached value.
const T& value() const { return value_; }