| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The preferencesPrivate, location, and principalsPrivate APIs have been
reduced/removed. Update the histogram values in one CL with nothing else since
presubmit complains about modifying values.
BUG=595168
BUG=593166
BUG=586560
NOTRY=true
(NOTRY because editing existing histogram entries in valid ways)
Review URL: https://codereview.chromium.org/1810583003
Cr-Commit-Position: refs/heads/master@{#381766}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Three public APIs are available on ChromeOS to make IME extensions work with the input items on the system status tray:
input.ime.setMenuItems
input.ime.updateMenuItems
input.ime.onMenuItemActivated
As we are now building a new IME menu with the IME extension, we need new private API to notify the extension which creates the IME menu with the three public APIs calling. Thus, these two private APIs are added in this cl:
inputMethodPrivate.notifyImeMenuItemActivated: Fires the input.ime.onMenuItemActivated event.
inputMethodPrivate.onImeMenuItemsChanged: Fired when the input.ime.setMenuItems or input.ime.updateMenuItems API is called.
BUG=570761
TEST=Verified these two private APIs working on local build.
Review URL: https://codereview.chromium.org/1750913003
Cr-Commit-Position: refs/heads/master@{#378779}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This API is used for new IME menu in Chrome OS. The event will be fired when the current input method or the list of active input method IDs is changed. Thus, the IME menu could be notified to update the menu list, with the other two private APIs: chrome.inputMethodPrivate.getCurrentInputMethod & chrome.inputMethodPrivate.getInputMethods.
Currently, the new IME menu relies on the chrome.input.ime.onActivate API, which will only notifies the current input method. When changing to other IME extensions that don't create IME menu, our menu will not get the changing event. So, we need this new added API to make sure the IME menu will get the list changing event every time.
BUG=517773
TEST=None
Review URL: https://codereview.chromium.org/1649293002
Cr-Commit-Position: refs/heads/master@{#377202}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
fired when the checkbox in language settings about IME menu is checked or unchecked.
Modify chrome.inputMethodPrivate.getInputMethodConfig() API to get the initial state of the activation of IME menu.
These APIs will be used for IME extensions to opt-in the IME menu on shelf.
BUG=570761
TEST=Verified the API is available on Chrome OS.
Review URL: https://codereview.chromium.org/1552743003
Cr-Commit-Position: refs/heads/master@{#373479}
|
|
|
|
|
|
|
|
|
| |
BUG=517773
TEST=None
Review URL: https://codereview.chromium.org/1614273004
Cr-Commit-Position: refs/heads/master@{#372888}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch introduces the 'chrome.displaySource' API including the idl file and the permission string and feature.
The patch also provides bindings code and the implementation delegate interface for the 'getAvailableSinks', 'requestAuthentication' methods and for the 'onSinksUpdated' event.
The API tests are included.
The API proposal doc: https://docs.google.com/document/d/1svs0p_b6KAIiBrKjaORsA2D8Pd84u8ksnTCfubYVVWA
BUG=242107
Review URL: https://codereview.chromium.org/1410093008
Cr-Commit-Position: refs/heads/master@{#360299}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The connection manager observe the connection events and dispatches them
to the JS API. The BLE connections are managed using the ApiResourceManager.
The EasyUnlockPrivateConnection is a wrapper for a
proximity_auth::Connection, and its lifetime is managed by the
ApiResourceManager.
BUG=528274
Review URL: https://codereview.chromium.org/1333343002
Cr-Commit-Position: refs/heads/master@{#349650}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This prevents hitting NOTREACHED() when calling .addListener on those
events.
BUG=528853
Test=Hangouts app should work in debug chromium. See bug for details.
Review URL: https://codereview.chromium.org/1315713010
Cr-Commit-Position: refs/heads/master@{#348211}
|
|
|
|
|
|
|
|
| |
BUG=514575
Review URL: https://codereview.chromium.org/1232553003
Cr-Commit-Position: refs/heads/master@{#347916}
|
|
|
|
|
|
|
|
|
|
| |
This is a combination of two code review's which have circular dependencies:
- crrev.com/1291113002
- crrev.com/1291703010
Review URL: https://codereview.chromium.org/1288073005 .
Cr-Commit-Position: refs/heads/master@{#344675}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
While implementing this API, I've come across some API changes I'd like to
make before submitting the actual implementation.
This also introduces the stub event router delegate and brings the stubs
closer to what the implementation looks like.
The implementation CL will be posted after this one:
https://codereview.chromium.org/1283603002/
BUG=479043
Review URL: https://codereview.chromium.org/1274753006
Cr-Commit-Position: refs/heads/master@{#343474}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These didn't make it into my last 5 patches because they needed to be hand
written. Now, everything is plumbed through to the UMA_HISTOGRAM_ENUMERATION
calls - which I will add in a follow-up - so this should be the last of it.
BUG=503402
R=rdevlin.cronin@chromium.org, asvitkine@chromium.org
Review URL: https://codereview.chromium.org/1272373003
Cr-Commit-Position: refs/heads/master@{#342749}
|
|
|
|
|
|
|
|
|
| |
BUG=503402
R=rdevlin.cronin@chromium.org, asvitkine@chromium.org
Review URL: https://codereview.chromium.org/1236493004
Cr-Commit-Position: refs/heads/master@{#339905}
|
|
|
|
|
|
|
|
|
|
| |
BUG=503402
R=rdevlin.cronin@chromium.org,asvitkine@chromium.org
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1245113005
Cr-Commit-Position: refs/heads/master@{#339725}
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=503402
R=rdevlin.cronin@chromium.org
TBR=isherman@chromium.org
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1250433002
Cr-Commit-Position: refs/heads/master@{#339552}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the last batch of trivial replacements of the form
DispatchEvent(kFooEvent) --> DispatchEvent(events::FOO_EVENT, kFooEvent).
The remaining 15 or so files are less trivial, but there are only 15.
BUG=503402
R=rdevlin.cronin@chromium.org, isherman@chromium.org
Review URL: https://codereview.chromium.org/1240913002
Cr-Commit-Position: refs/heads/master@{#339209}
|
|
|
|
|
|
|
|
|
| |
BUG=503402
R=rdevlin.cronin@chromium.org, isherman@chromium.org
Review URL: https://codereview.chromium.org/1233583005
Cr-Commit-Position: refs/heads/master@{#338972}
|
|
|
|
|
|
|
|
|
|
| |
BUG=503402
R=rdevlin.cronin@chromium.org, isherman@chromium.org
TBR=stevenjb@chromium.org,dmazzoni@chromium.org,ckehoe@chromium.org
Review URL: https://codereview.chromium.org/1221643019
Cr-Commit-Position: refs/heads/master@{#337495}
|
|
|
|
|
|
|
|
|
|
| |
BUG=503402
R=dmazzoni@chromium.org, isherman@chromium.org, rdevlin.cronin@chromium.org
TBR=mtomasz@chromium.org
Review URL: https://codereview.chromium.org/1203773006.
Cr-Commit-Position: refs/heads/master@{#336289}
|
|
This patch adds extension_event_histogram_value.h with a value for every
Extension event (scraped using the Docserver), changes the Event struct
constructor to require one, then makes every caller pass in UNKNOWN.
These are steps 1 and 2 in the bug.
Next I will be submitting bite-sized changes to use the real histogram values.
BUG=503402
R=rdevlin.cronin@chromium.org, isherman@chromium.org
TBR=achuith@chromium.org, rkc@chromium.org, dewittj@chromium.org, tommi@chromium.org, msw@chromium.org
Review URL: https://codereview.chromium.org/1201063002
Cr-Commit-Position: refs/heads/master@{#336003}
|