| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
This eliminates source list duplication between GYP
and GN builds by merging all source lists into
unified gypis.
BUG=457404
Review URL: https://codereview.chromium.org/908333004
Cr-Commit-Position: refs/heads/master@{#315871}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
injection System" [browser side] (patchset #2 id:270001 of https://codereview.chromium.org/899983002/)
Reason for revert:
It turns out that the crash wasn't caused by this CL.
Original issue's description:
> Revert of Introduce HostID and de-couple Extensions from "script injection System" [browser side] (patchset #20 id:760001 of https://codereview.chromium.org/822453002/)
>
> Reason for revert:
> It might cause the crash https://code.google.com/p/chromium/issues/detail?id=454917.
>
> Original issue's description:
> > Introduce HostID and de-couple Extensions from "script injection System" [browser side]
> >
> > The major refactor includes:
> > - Introduce HostID (a pair of |id, type|) to replace extension_id in browser
> > side.
> > - Abstract UserScriptLoader to be a base class, and introduces
> > a derived class ExtensionUserScriptLoader which is
> > responsible for loading user scripts for extensions.
> > - In DeclarativeUserScriptManager, a master is created per
> > extension/webUI.
> > - DeclarativeUserScriptManager becomes an
> > ExtensionRegistryObserver and is responsible for clearing scripts
> > for master objects when receive OnExensionUnloaded event.
> >
> > BUG=437566
> >
> > Committed: https://crrev.com/b88fe3dc1072501bdd105fd95a8b3bc453fd2aa7
> > Cr-Commit-Position: refs/heads/master@{#313402}
>
> TBR=fsamuel@chromium.org,rdevlin.cronin@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=437566
>
> Committed: https://crrev.com/5eb894ea21637241e9a78fb9c2737d40d6dbf575
> Cr-Commit-Position: refs/heads/master@{#314631}
TBR=fsamuel@chromium.org,rdevlin.cronin@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=437566
Review URL: https://codereview.chromium.org/903743002
Cr-Commit-Position: refs/heads/master@{#314807}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
System" [browser side] (patchset #20 id:760001 of https://codereview.chromium.org/822453002/)
Reason for revert:
It might cause the crash https://code.google.com/p/chromium/issues/detail?id=454917.
Original issue's description:
> Introduce HostID and de-couple Extensions from "script injection System" [browser side]
>
> The major refactor includes:
> - Introduce HostID (a pair of |id, type|) to replace extension_id in browser
> side.
> - Abstract UserScriptLoader to be a base class, and introduces
> a derived class ExtensionUserScriptLoader which is
> responsible for loading user scripts for extensions.
> - In DeclarativeUserScriptManager, a master is created per
> extension/webUI.
> - DeclarativeUserScriptManager becomes an
> ExtensionRegistryObserver and is responsible for clearing scripts
> for master objects when receive OnExensionUnloaded event.
>
> BUG=437566
>
> Committed: https://crrev.com/b88fe3dc1072501bdd105fd95a8b3bc453fd2aa7
> Cr-Commit-Position: refs/heads/master@{#313402}
TBR=fsamuel@chromium.org,rdevlin.cronin@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=437566
Review URL: https://codereview.chromium.org/899983002
Cr-Commit-Position: refs/heads/master@{#314631}
|
|
|
|
|
|
|
|
| |
BUG=444869
Review URL: https://codereview.chromium.org/892923002
Cr-Commit-Position: refs/heads/master@{#314233}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[browser side]
The major refactor includes:
- Introduce HostID (a pair of |id, type|) to replace extension_id in browser
side.
- Abstract UserScriptLoader to be a base class, and introduces
a derived class ExtensionUserScriptLoader which is
responsible for loading user scripts for extensions.
- In DeclarativeUserScriptManager, a master is created per
extension/webUI.
- DeclarativeUserScriptManager becomes an
ExtensionRegistryObserver and is responsible for clearing scripts
for master objects when receive OnExensionUnloaded event.
BUG=437566
Review URL: https://codereview.chromium.org/822453002
Cr-Commit-Position: refs/heads/master@{#313402}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds the mimeHandler extension API, which is a simplified version
of the streamsPrivateApi. Unlike the streamsPrivateApi, mimeHandler only
allows access to streams from RenderFrames within MimeHandlerViewGuests,
and in particular only allows access to the stream being handled by that
MimeHandlerViewGuest instance. This removes the need for an event to be
dispatched to the background page and a user-exposed view_id.
BUG=439867
Review URL: https://codereview.chromium.org/797183005
Cr-Commit-Position: refs/heads/master@{#312728}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/792353002/
Second attempt is here:
https://codereview.chromium.org/854693002/
The latest build failure affected only linux_chromium_gn_dbg configuration, and was caused by crypto_verify_impl.cc being incorrectly included into the build on Linux.
Patch Set 2 moves the offending crypto_verify_impl.h/cc files into the right fileset that is chromeos-specific.
Original CL description follows:
Refactoring of Cast-related crypto code to use the same certificate validation logic in chrome.networkingPrivate API and Cast Channel authentication.
Here's what's being done here:
* Code from cast_auth_util_nss/openssl formed the basis a common Cast device validation component in /src/extensions/common/cast/cast_cert_validator*, and is now being extensively cleaned up in response to rsleevi's comments in this CL.
* Both networking_private_crypto* and cast_auth_util* have been updated to use the new common code.
* The current D-Bus-based implementation of VerifyDestination is going away per discussion with ChromeOS team, and is replaced with in-Chrome code in networking_private crypto*.
BUG=442650
TBR=rockot@chromium.org,brettw@chromium.org
Review URL: https://codereview.chromium.org/863023002
Cr-Commit-Position: refs/heads/master@{#312715}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/854693002/)
Reason for revert:
Speculative revert. I suppose that now it is breaking Linux GN:
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/20625/steps/compile/logs/stdio
Original issue's description:
> The purpose of this CL is to re-land issue 792353002 (https://codereview.chromium.org/792353002/), which landed, but was reverted due to a ChromiumOS GN build failure. The failure was caused by a double inclusion of networking_private_credentials_getter_chromeos.cc.cc file in chrome_browser_extensions.gypi. This CL includes the original patch and the fix of the build failure.
>
> Original CL description follows:
>
> Refactoring of Cast-related crypto code to use the same certificate validation logic in chrome.networkingPrivate API and Cast Channel authentication.
>
> Here's what's being done here:
> * Code from cast_auth_util_nss/openssl formed the basis a common Cast device validation component in /src/extensions/common/cast/cast_cert_validator*, and is now being extensively cleaned up in response to rsleevi's comments in this CL.
> * Both networking_private_crypto* and cast_auth_util* have been updated to use the new common code.
> * The current D-Bus-based implementation of VerifyDestination is going away per discussion with ChromeOS team, and is replaced with in-Chrome code in networking_private crypto*.
>
> BUG=442650
>
> Committed: https://crrev.com/57988d1f46e6ce2a2d65aa87c01b29b2732a110f
> Cr-Commit-Position: refs/heads/master@{#312369}
TBR=rockot@chromium.org,stevenjb@chromium.org,brettw@chromium.org,mfoltz@chromium.org,vadimgo@chromium.org,mef@chromium.org,kmarshall@chromium.org,rsleevi@chromium.org,sheretov@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=442650
Review URL: https://codereview.chromium.org/865583003
Cr-Commit-Position: refs/heads/master@{#312391}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/792353002/), which landed, but was reverted due to a ChromiumOS GN build failure. The failure was caused by a double inclusion of networking_private_credentials_getter_chromeos.cc.cc file in chrome_browser_extensions.gypi. This CL includes the original patch and the fix of the build failure.
Original CL description follows:
Refactoring of Cast-related crypto code to use the same certificate validation logic in chrome.networkingPrivate API and Cast Channel authentication.
Here's what's being done here:
* Code from cast_auth_util_nss/openssl formed the basis a common Cast device validation component in /src/extensions/common/cast/cast_cert_validator*, and is now being extensively cleaned up in response to rsleevi's comments in this CL.
* Both networking_private_crypto* and cast_auth_util* have been updated to use the new common code.
* The current D-Bus-based implementation of VerifyDestination is going away per discussion with ChromeOS team, and is replaced with in-Chrome code in networking_private crypto*.
BUG=442650
Review URL: https://codereview.chromium.org/854693002
Cr-Commit-Position: refs/heads/master@{#312369}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL move //mojo/public and //mojo/edk to live in the following locations:
- //third_party/mojo/src/mojo/public
- //third_party/mojo/src/mojo/edk
It moves the related gypfiles from //mojo to //third_party/mojo and updates
them as necessary to account for the file moves. It also updates clients of the
mojo SDK and EDK targets in both GYP and GN. (Note that for GN, the mojo SDK
and EDK build systems are maintained in the Mojo repo and designed to be
flexible wrt the location of the SDK/EDK in a client repo, so no changes are
needed.
This CL does not update include paths to the code being moved to limit the
number of moving parts, instead relying on the include_dirs that the SDK and
EDK targets supply to their direct dependents to ensure that include paths
continue to resolve correctly.
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/814543006
Cr-Commit-Position: refs/heads/master@{#312129}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/792353002/)
Reason for revert:
fails to compile on Linux ChromiumOS GN https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN/builds/6146/steps/compile/logs/stdio
Original issue's description:
> Refactoring of Cast-related crypto code to use the same certificate validation logic in chrome.networkingPrivate API and Cast Channel authentication.
>
> Here's what's being done here:
> * Code from cast_auth_util_nss/openssl formed the basis a common Cast device validation component in /src/extensions/common/cast/cast_cert_validator*, and is now being extensively cleaned up in response to rsleevi's comments in this CL.
> * Both networking_private_crypto* and cast_auth_util* have been updated to use the new common code.
> * The current D-Bus-based implementation of VerifyDestination is going away per discussion with ChromeOS team, and is replaced with in-Chrome code in networking_private crypto*.
>
> BUG=442650
>
> Committed: https://crrev.com/ed1e90f4f980709cef6a8a9c7e0f64cfe5578cdd
> Cr-Commit-Position: refs/heads/master@{#311460}
TBR=stevenjb@chromium.org,mef@chromium.org,rsleevi@chromium.org,vadimgo@chromium.org,mfoltz@chromium.org,kmarshall@chromium.org,rockot@chromium.org,brettw@chromium.org,sheretov@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=442650
Review URL: https://codereview.chromium.org/853663003
Cr-Commit-Position: refs/heads/master@{#311461}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
validation logic in chrome.networkingPrivate API and Cast Channel authentication.
Here's what's being done here:
* Code from cast_auth_util_nss/openssl formed the basis a common Cast device validation component in /src/extensions/common/cast/cast_cert_validator*, and is now being extensively cleaned up in response to rsleevi's comments in this CL.
* Both networking_private_crypto* and cast_auth_util* have been updated to use the new common code.
* The current D-Bus-based implementation of VerifyDestination is going away per discussion with ChromeOS team, and is replaced with in-Chrome code in networking_private crypto*.
BUG=442650
Review URL: https://codereview.chromium.org/792353002
Cr-Commit-Position: refs/heads/master@{#311460}
|
|
|
|
|
|
|
|
|
|
|
|
| |
_behavior_features.json. Arbitrarily use it to implement the allow-in-incognito
whitelist.
BUG=440194
R=rockot@chromium.org
Review URL: https://codereview.chromium.org/789383002
Cr-Commit-Position: refs/heads/master@{#308311}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change does a few things. Firstly, it stops bookmark apps from
using downloaded favicons / manifest icons. Secondly, it syncs the
color it uses to generate icons. Thirdly, machines that bookmark apps
are synced onto will now generate icons using the synced color.
This means bookmark apps will always have nice icons (although not the
ones downloaded) and they will always be consistent across machines.
Once blob sync is available the downloaded icons will be kept and
synced.
BUG=439347
Review URL: https://codereview.chromium.org/782693002
Cr-Commit-Position: refs/heads/master@{#307889}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds basic manifest data parsing support for the
content_capabilities feature, which is - for now -
constrained to a whitelist.
BUG=409269
Review URL: https://codereview.chromium.org/780703003
Cr-Commit-Position: refs/heads/master@{#307407}
|
|
|
|
|
|
|
|
|
|
|
| |
No intended functionality change.
R=brettw@chromium.org
BUG=348474
Review URL: https://codereview.chromium.org/774283002
Cr-Commit-Position: refs/heads/master@{#306641}
|
|
|
|
|
|
|
|
|
| |
BUG=398671
TBR=kalman@chromium.org,jochen@chromium.org for various #include updates
Review URL: https://codereview.chromium.org/719243002
Cr-Commit-Position: refs/heads/master@{#303934}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/638273004
Cr-Commit-Position: refs/heads/master@{#301024}
|
|
|
|
|
|
|
|
| |
BUG=424746
Review URL: https://codereview.chromium.org/673663004
Cr-Commit-Position: refs/heads/master@{#300958}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will allow apps and extensions APIs implemented on mojo services to
match the existing behavior of keeping background pages alive while API
calls are in progress.
BUG=389016
Review URL: https://codereview.chromium.org/673623004
Cr-Commit-Position: refs/heads/master@{#300853}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
app_shell needs the client ID and oauth2 scopes for its identity API.
Just a refactor, no functional changes.
BUG=424653
TEST=extensions_unittests
TBR=xiyuan@chromium.org for header file rename touching chrome/browser/signin/easy_unlock_toggle_flow.cc
Review URL: https://codereview.chromium.org/671553002
Cr-Commit-Position: refs/heads/master@{#300380}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
own extensions_common_constants target.
The extensions constants are used in too many places and very hard to
get rid of. Making it into its own target so it can be included in all
builds, even when extensions are not enabled.
BUG=424746
Review URL: https://codereview.chromium.org/652623003
Cr-Commit-Position: refs/heads/master@{#300335}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves extensions manifest URL handlers into //extensions
and renames the source files more appropriately to
"manifest_url_handlers"
Mechanical change, so all this noise is only header updates.
TBRs are for header changes only.
BUG=398671
TBR=derat@chromium.org for app_mode change
TBR=pkotwicz@chromium.org for themes change
TBR=msw@chromium.org for ui changes
Review URL: https://codereview.chromium.org/651353002
Cr-Commit-Position: refs/heads/master@{#299598}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will allow apps and extensions to stash their persistent mojo
services (e.g. persistent serial connections) in the browser when
suspended and retrieve them when relaunched.
BUG=389016
Review URL: https://codereview.chromium.org/598133003
Cr-Commit-Position: refs/heads/master@{#298374}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Update _api_features.json and _permissions.json to allow the following features in extensions:
- declarativeWebrequest,
- events
- webRequest
- webViewRequest
- Move web_view_request_custom_bindings.js and web_view_request.json to extensions.
- Remove ExtensionsAPIClient::GetRuleRegistry() since RuleRegisteryService has been moved to extension.
- Clean up extensions/extensions.gyp.
TBR=sky@chromium.org
BUG=352293
Committed: https://crrev.com/4499156f5a5784eee9e0dc021f13b4ea0fd7d0d2
Cr-Commit-Position: refs/heads/master@{#297413}
Review URL: https://codereview.chromium.org/596003002
Cr-Commit-Position: refs/heads/master@{#297532}
|
|
|
|
|
|
|
|
| |
BUG=305852
Review URL: https://codereview.chromium.org/586623002
Cr-Commit-Position: refs/heads/master@{#296067}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL renames ChromeBrowserPluginDelegate to GuestViewContainer and moves it to extensions
This CL moves guest_view_constants to extensions/common/*
This CL also attaches a GuestViewContainer to all GuestViews.
BUG=330264, 352290
Review URL: https://codereview.chromium.org/577453002
Cr-Commit-Position: refs/heads/master@{#295034}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move embedded extension options guest view files from
chrome/browser/guest_view/extension_options/ to
extensions/browser/guest_view/extension_options. Also add a
ExtensionOptionsGuestDelegate in chrome/ to handle certain tasks, like
opening tabs and handling context menus, which cannot be run from
within extensions/.
This move makes the extension_options codebase more consistent with the
other guest views, which are organized similarly.
BUG=409316
Review URL: https://codereview.chromium.org/556563003
Cr-Commit-Position: refs/heads/master@{#294326}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add an options_ui field to allows extension developers to configure how
their options pages are displayed. Example:
"options_ui": {
"page": "options.html",
"chrome_style": false,
"open_in_tab": false
}
"page" is equivalent to using the "options_page" field.
"chrome_styles" enables the WebUI user agent stylesheet for the
options page.
"open_in_tab" opens the options page in a tab instead of embedding it in
chrome://extensions.
"page" is a required field. "chrome_style" and "open_in_tab" default to
false.
Both "options_ui" and "options_page" can specify the URL of an extension
options page. If both are present in the manifest, "options_ui.page"
will be used instead of "options_page".
Additionally, both entries "options_ui" and "options_page" are now
managed by the same ManifestHandler and stored in the same ManifestData
object (OptionsPageManifestHandler and OptionsPageInfo respectively).
BUG=408256
Review URL: https://codereview.chromium.org/518653002
Cr-Commit-Position: refs/heads/master@{#294019}
|
|
|
|
|
|
|
|
|
|
| |
This fixes all non-RTC-related linker errors for Chrome.
R=jamesr@chromium.org
Review URL: https://codereview.chromium.org/533743004
Cr-Commit-Position: refs/heads/master@{#292978}
|
|
|
|
|
|
|
|
|
| |
BUG=395240
TBR=keybuk@chromium.org
Review URL: https://codereview.chromium.org/420663003
Cr-Commit-Position: refs/heads/master@{#292719}
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes the rest of the non-rtc and non-vpx linker errors for the chrome target.
BUG=
R=ajwong@chromium.org
Review URL: https://codereview.chromium.org/505853003
Cr-Commit-Position: refs/heads/master@{#291952}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Consolidates id_util functions of extension/app/component ids in the crx_file component.
It belongs there because these types of ids are not exclusive to extensions, but rather, for anything that comes in a crx file.
BUG=371463
TBR=blundell@chromium.org
Review URL: https://codereview.chromium.org/481433005
Cr-Commit-Position: refs/heads/master@{#290971}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CRX file code currently lives under extensions/. However,
component_updater also uses them to package components. The
CRX code should therefore live as its own component.
BUG=371463
TBR=blundell@chromium.org
Review URL: https://codereview.chromium.org/474633005
Cr-Commit-Position: refs/heads/master@{#289966}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a first, very small step towards making NaCl work in app_shell.
BUG=400577
TEST=compiles
TBR=brettw@chromium.org for moving a few lines out of chrome/common/BUILD.gn into extensions/common/BUILD.gn
Review URL: https://codereview.chromium.org/435343002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
BUG=None
TEST=gn gen out/Debug_gn && ninja -C out/Debug_gn extensions/common
R=brettw@chromium.org
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/411783003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284911 0039d316-1c4b-4281-b951-d872f2087c98
|