summaryrefslogtreecommitdiffstats
path: root/extensions/shell
Commit message (Collapse)AuthorAgeFilesLines
* Extensions: Using common ValueStoreFactory for all value stores.cmumford2016-03-242-1/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | 1. Introduce new ValueStoreFactory interface used for the creation of ValueStore's in all namespaces (local, sync, and managed), and for all types (extension and application). 2. Delete SettingsStorageFactory/LeveldbSettingsStorageFactory, and switched to ValueStoreFactory. 3. Created a new TestValueStoreFactory (for testing). This combines settings_sync_unittest.cc:TestingValueStoreFactory and ScopedSettingsStorageFactory. 4. ValueStoreFrontend::Backend always lazilily initializes using the ValueStoreFactory. This makes unnecessary StateStore's deferred initialization mechanism - which will be removed in an upcoming CL. 5. A new ValueStoreFactoryImpl to mint new ValueStore's for Chrome. This currently delegates to a new LegacyValueStoreFactory which creates new LeveldbValueStore. An upcoming CL will add a second delegated factory (currently called ProfileValueStoreFactory) to support a unified (per-profile) extensions database. 6. Removed memcheck suppression for SettingsStorageFactory as this class is now deleted (crbug.com/163922). BUG=453946,163922 Review URL: https://codereview.chromium.org/1803193002 Cr-Commit-Position: refs/heads/master@{#383137}
* Add RetainedRef uses where needed.vmpstr2016-03-211-5/+5
| | | | | | | | | | | | | | | This patch adds RetainedRef uses where they are required. These changes will be required when we remove automatic unwrapping of scoped_refptrs in Bind. Please see the bug for more context. R=tzik@chromium.org, thakis@chromium.org, danakj@chromium.org BUG=589048 Review URL: https://codereview.chromium.org/1815363002 Cr-Commit-Position: refs/heads/master@{#382371}
* Deal with frame removal by content scriptsrob2016-03-192-0/+12
| | | | | | | | | | | | | | | | | | | | | | | Blink and the RenderFrame implementations are currently not prepared to deal with frame detachments in their callbacks. Consequently, extension code (content scripts, chrome.app.window.create) that run arbitrary code in the "document element created" and "document loaded" notifications may result in unexpected invalidation of memory, resulting in a UAF. This patch fixes the bug by moving all code that runs untrusted code from observers to dedicated callbacks, which are only run at a safe point. All document parsers in Blink have been modified to make sure that they still work even when the document creation is interrupted by frame removal. An extensive set of tests for all different kinds of documents, frame removal methods (e.g. synchronously / in mutation events / ...) and injection points (document start/end) have been added to avoid regressions. BUG=582008 Review URL: https://codereview.chromium.org/1642283002 Cr-Commit-Position: refs/heads/master@{#382162}
* Remove Mojo bindings environment.Yuzhu Shen2016-03-082-2/+0
| | | | | | | | | BUG=585942 R=ben@chromium.org Review URL: https://codereview.chromium.org/1765243002 . Cr-Commit-Position: refs/heads/master@{#379839}
* Persist the user's active audio device choice across chromeos session and ↵jennyz2016-03-021-2/+4
| | | | | | | | | | | | | | | | reboots. This cl added a new attribute to device's active state settings to describe if the device is made active by user's selection or by automatic priority selection. The device made active by user has a higher priority than the device made active by priority. With the stable device id, the active device selection rule is different than before, which only select the active device by its priority. Please see the details in the following document. https://docs.google.com/a/google.com/document/d/1zmSeM956Njh_9ZdLqyld-NTOpJyXVIfzv8DvQ1Xcksw/edit?usp=sharing BUG=308143 TBR=stevenjb,rkc,derat Review URL: https://codereview.chromium.org/1746843002 Cr-Commit-Position: refs/heads/master@{#378812}
* Make extensions::DictionaryBuilder and extensions::ListValue unmovable.dcheng2016-02-272-12/+16
| | | | | | | | | | | | | | | | | | | There's no reason for these classes to be movable. std::move() is just being used as a synonym for Build(). In addition: - Build() is fewer characters than std::move(). - clang-format works better when builder syntax is consistently used, which makes it easier for readers to visually match up deeply nested builders. - It's surprising to see std::move() used with what looks like a temporary. BUG=none Review URL: https://codereview.chromium.org/1739183003 Cr-Commit-Position: refs/heads/master@{#378107}
* Add some missing std::move()s following a previous refactoringskyostil2016-02-261-2/+2
| | | | | | | | | | | | This patch adds some std::move() calls as a follow-up to https://codereview.chromium.org/1730533002/. No functional changes. BUG=546953 TBR=rsleevi@chromium.org Review URL: https://codereview.chromium.org/1736273002 Cr-Commit-Position: refs/heads/master@{#377898}
* Remove some usages of BrowserThread::UnsafeGetMessageLoopForThreadskyostil2016-02-253-8/+8
| | | | | | | | | | No functional changes. BUG=546953 Review URL: https://codereview.chromium.org/1730533002 Cr-Commit-Position: refs/heads/master@{#377549}
* Add Bluez initialize call to startup.drustsmith2016-02-232-1/+10
| | | | | | | | | | | | Solution copied from similar fix in content shell: https://crrev.com/1487183002 (fix for issue 552488) in file: /content/shell/browser/shell_browser_main_parts.cc BUG=585586 Review URL: https://codereview.chromium.org/1692723002 Cr-Commit-Position: refs/heads/master@{#376863}
* Android: Add support for android-app scheme in a referrer.lizeb2016-02-192-0/+2
| | | | | | | | | | | | | | Following android's documentation, native apps can set a referrer with the format android-app://com.foo.bar. This is supported by the Java side, but not the native code. TBR=alokp@chromium.org,asargent@chromium.org # Adding a parameter in chromecast/ and extensions/ TESTED=adb shell am start -n com.google.android.apps.chrome/.Main -a "android.intent.action.VIEW" -d 'http://www.whatismyreferer.com/' --eu "android.intent.extra.REFERRER" "android-app://com.foo.bar" BUG=537863 Review URL: https://codereview.chromium.org/1416863004 Cr-Commit-Position: refs/heads/master@{#376423}
* [mojo] Delete third_party/mojorockot2016-02-102-2/+2
| | | | | | | | | | | All users are on the new EDK now. This wipes out third_party/mojo, updates all dependencies, and removes the use-new-edk flag. BUG=None Review URL: https://codereview.chromium.org/1676913002 Cr-Commit-Position: refs/heads/master@{#374631}
* NaCl cleanup: Remove the need to register PPB_NACL_PRIVATE_INTERFACEmseaborn2016-02-052-12/+0
| | | | | | | | | | | | | | | | | | This PPAPI interface is left over from when the NaCl trusted plugin was built as a separate DSO/DLL (which is no longer the case). We can simplify the code by getting it directly from nacl::GetNaClPrivateInterface() rather than from GetBrowserInterface(). This means we can remove the CreatePPAPIInterface() method and utility.cc. BUG=none TEST=e.g. NaClBrowserTestPnacl.PPAPICore Review URL: https://codereview.chromium.org/1669563002 Cr-Commit-Position: refs/heads/master@{#373876}
* Move gn _run target generation into test(). (RELAND)jbudorick2016-02-031-9/+0
| | | | | | | | | | | | | | This is a reland of https://codereview.chromium.org/1653003006/ Consolidating the _run targets into the test template should make them easier to maintain (and, eventually, remove). BUG=583694 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1662053002 Cr-Commit-Position: refs/heads/master@{#373385}
* Revert of Move gn _run target generation into test(). (patchset #1 id:1 of ↵dpranke2016-02-031-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1653003006/ ) Reason for revert: Broke angle_unittests_run, which doesn't follow the template: https://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Linux%20Builder/builds/53646/steps/compile/logs/stdio Original issue's description: > Move gn _run target generation into test(). > > TBR=brettw@chromium.org > BUG= > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/6b1b03783b81ea27bb521c02aa84b74f06d6f71a > Cr-Commit-Position: refs/heads/master@{#373232} TBR=phosek@chromium.org,brettw@chromium.org,jbudorick@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1664653003 Cr-Commit-Position: refs/heads/master@{#373257}
* Move gn _run target generation into test().jbudorick2016-02-031-9/+0
| | | | | | | | | | TBR=brettw@chromium.org BUG= CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1653003006 Cr-Commit-Position: refs/heads/master@{#373232}
* Delete base/prefs and update callers to use components.brettw2016-02-033-9/+9
| | | | | | | | | | | | | | | | | | | | | | | Deletes the forwarding headers in base/prefs. Updates the remaining users of base/prefs includes to use components/prefs. Sort headers in updated files. Move PrefServiceFactory out of the base namespace. Update users. Update all preprocessor stuff in components/prefs to change BASE_PREFS_ to COMPONENTS_PREFS_. Add components/prefs to DEPS file of directories where checkdeps fails after the update. BUG=583034 Reland of http://crrev.com/1662523004#ps40001 with fix. TBR=estade@chromium.org Review URL: https://codereview.chromium.org/1668463002 Cr-Commit-Position: refs/heads/master@{#373197}
* Revert of Delete base/prefs and update callers to use components. (patchset ↵msw2016-02-033-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | #3 id:40001 of https://codereview.chromium.org/1662523004/ ) Reason for revert: Broke Win Builder compile: https://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/19463/steps/compile/logs/stdio Original issue's description: > Delete base/prefs and update callers to use components. > > Deletes the forwarding headers in base/prefs. > > Updates the remaining users of base/prefs includes to use components/prefs. > Sort headers in updated files. > > Move PrefServiceFactory out of the base namespace. Update users. > > Update all preprocessor stuff in components/prefs to change BASE_PREFS_ to > COMPONENTS_PREFS_. > > Add components/prefs to DEPS file of directories where checkdeps fails after > the update. > > BUG=583034 > > Committed: https://crrev.com/1f5feb7e317e3c257090858e950273b64a2e31ef > Cr-Commit-Position: refs/heads/master@{#373105} TBR=estade@chromium.org,brettw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=583034 Review URL: https://codereview.chromium.org/1662843002 Cr-Commit-Position: refs/heads/master@{#373115}
* Delete base/prefs and update callers to use components.brettw2016-02-033-9/+9
| | | | | | | | | | | | | | | | | | | | | Deletes the forwarding headers in base/prefs. Updates the remaining users of base/prefs includes to use components/prefs. Sort headers in updated files. Move PrefServiceFactory out of the base namespace. Update users. Update all preprocessor stuff in components/prefs to change BASE_PREFS_ to COMPONENTS_PREFS_. Add components/prefs to DEPS file of directories where checkdeps fails after the update. BUG=583034 Review URL: https://codereview.chromium.org/1662523004 Cr-Commit-Position: refs/heads/master@{#373105}
* Update GN build files for new prefs location.brettw2016-01-301-1/+1
| | | | | | | | | | Updates references from //base:prefs to //components/prefs/ TBR=jam@chromium.org Review URL: https://codereview.chromium.org/1652573002 Cr-Commit-Position: refs/heads/master@{#372540}
* Move base/prefs to components/prefsbrettw2016-01-301-1/+1
| | | | | | | | | | | | | | | | | This change is the minimal move change. It does not update namespaces or includes. Forwarding headers and targets exist to map to the new location. The namespaces, include guards, and references to these files will be updated in follow-ups. The GYP build has been updated to point to the new location because the forwarding headers generated a .gyp file cycle. Avoiding a cycle with libaddressinput is why prefs is a separate .gyp from most of the rest of the components. The GN build uses forwarding targets to keep the change smaller. The json pref store unit tests had to be updated because of the way that they used histograms conflicted with the hsitogram setup of the components unittests. Fortunately, there's a HistogramTester helper for this case, so this patch uses it in for the moved test in place of manually checking histogram counts. json_pref_store_unittests.cc also depended on the files il base/test/data/prefs. Rather than worry about updating all the isolates and such, this just adds the data inline and avoids having separate test files. Reland of http://crrev.com/1648403002 with iOS fix TBR=jam@chromium.org Review URL: https://codereview.chromium.org/1653693002 Cr-Commit-Position: refs/heads/master@{#372536}
* Revert of Move base/prefs to components/prefs (patchset #7 id:120001 of ↵joedow2016-01-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1648403002/ ) Reason for revert: Reverting due to failure on iOS builder: https://build.chromium.org/p/chromium.mac/builders/iOS_Device_%28ninja%29/builds/38425/steps/steps/logs/stdio Original issue's description: > Move base/prefs to components/prefs > > This change is the minimal move change. It does not update namespaces or includes. Forwarding headers and targets exist to map to the new location. The namespaces, include guards, and references to these files will be updated in follow-ups. > > The GYP build has been updated to point to the new location because the forwarding headers generated a .gyp file cycle. Avoiding a cycle with libaddressinput is why prefs is a separate .gyp from most of the rest of the components. The GN build uses forwarding targets to keep the change smaller. > > The json pref store unit tests had to be updated because of the way that they used histograms conflicted with the hsitogram setup of the components unittests. Fortunately, there's a HistogramTester helper for this case, so this patch uses it in for the moved test in place of manually checking histogram counts. > > json_pref_store_unittests.cc also depended on the files il base/test/data/prefs. Rather than worry about updating all the isolates and such, this just adds the data inline and avoids having separate test files. > > BUG= > > Committed: https://crrev.com/deb824cd36c02a93854537d70e1853cb9f1c55b9 > Cr-Commit-Position: refs/heads/master@{#372494} TBR=jam@chromium.org,brettw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1645073005 Cr-Commit-Position: refs/heads/master@{#372499}
* Move base/prefs to components/prefsbrettw2016-01-301-1/+1
| | | | | | | | | | | | | | | | This change is the minimal move change. It does not update namespaces or includes. Forwarding headers and targets exist to map to the new location. The namespaces, include guards, and references to these files will be updated in follow-ups. The GYP build has been updated to point to the new location because the forwarding headers generated a .gyp file cycle. Avoiding a cycle with libaddressinput is why prefs is a separate .gyp from most of the rest of the components. The GN build uses forwarding targets to keep the change smaller. The json pref store unit tests had to be updated because of the way that they used histograms conflicted with the hsitogram setup of the components unittests. Fortunately, there's a HistogramTester helper for this case, so this patch uses it in for the moved test in place of manually checking histogram counts. json_pref_store_unittests.cc also depended on the files il base/test/data/prefs. Rather than worry about updating all the isolates and such, this just adds the data inline and avoids having separate test files. BUG= Review URL: https://codereview.chromium.org/1648403002 Cr-Commit-Position: refs/heads/master@{#372494}
* allocator cleanup: remove dependencies on allocator from all targetsprimiano2016-01-282-15/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Overview of the cleanup: ------------------------ - In the context of the discussion in https://goo.gl/K2m649 our illustrious base/ owners suggested that having base being the only target depending on allocator (and having the other targets inherit that recursively) would be a more scalable solution, as opposite to having to remember to add an exec -> allocator to each target. - This base -> allocator dep landed in crrev.com/1616793003. - After that CL, until this point, many targets got two paths that lead to allocator: 1. The indirect one via base (content_shell -> base -> allocator) which is what we want to preserve. 2. The direct one (content_shell -> allocator) which is the inconsistent one we want to drop. This CL gets rid of all the instances of 2. The nice property of this sequencing of CLs is that the effect of this large change on the final .ninja files is minimal. See details below. Effect on the produced ninja files: ----------------------------------- GYP, Linux, static build: https://paste.ee/p/RaJLj Just some small reordering of include paths. Dropping --rdynamic (as expected) in keyboard_unittests GN, Linux, static build: https://paste.ee/p/zYtrQ Various targets lose the dependency on allocator.stamp (expected, the order is enforced by depending on base which depends on allocator.stamp) GN, Android (both component and static are similar): https://paste.ee/p/Iq6DD As above. GN, Linux, component build: https://paste.ee/p/jHUmv This is the most juicy change. As expected all the ODR goes away and random targets stop re-linking tcmalloc .o files. GYP, Win, static: https://paste.ee/p/j0IjL Extremely minimal changes: All.ninja stops depending on libcmt.lib. Sounds fine as base (which depends on that) is definitely depending on libcmt. GN, Win, static: https://paste.ee/p/Q6zTo Minimal change, like Linux GN, dropping dependencies on the .stamp files. BUG=564618 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1647453002 Cr-Commit-Position: refs/heads/master@{#372167}
* Remove now-unnecessary wrappers around gfx::Screen::GetScreen()scottmg2016-01-272-5/+0
| | | | | | | | | | | | | | - ash::Shell::GetScreen() - DisplayInfoProvider::GetActiveScreen() Followup to https://codereview.chromium.org/1608733002/. R=oshima@chromium.org, sky@chromium.org BUG=558054 Review URL: https://codereview.chromium.org/1608053002 Cr-Commit-Position: refs/heads/master@{#371733}
* Remove ui/gfx/screen_type_delegate.hscottmg2016-01-272-4/+3
| | | | | | | | | | | | | | This removes gfx::SCREEN_TYPE_NATIVE/SCREEN_TYPE_ALTERNATE, and there is now only one Screen instance. It's still a runtime-installed thing for test purposes. TBR=various owners for trivial changes R=oshima@chromium.org, sky@chromium.org BUG=558054 Review URL: https://codereview.chromium.org/1608733002 Cr-Commit-Position: refs/heads/master@{#371676}
* Make major tests target build without unused data members on Linux.mlamouri2016-01-161-1/+1
| | | | | | | | | | | | | The test targets have been picked from a linux builder. This allows these targets to build with the following CL applied: https://codereview.chromium.org/1222403002 BUG=447445 Review URL: https://codereview.chromium.org/1578653002 Cr-Commit-Position: refs/heads/master@{#369953}
* Reland of GN: Properly mark all NaCl test depencies as data_depsphosek2016-01-121-1/+4
| | | | | | | | | | | | NaCl tests and helpers are build as standalone executables and hence need to be marked as data_deps to be copied over to shards. BUG=462791 CQ_EXTRA_TRYBOTS=tryserver.chromium.win:win8_chromium_gn_dbg,win_chromium_gn_x64_rel Review URL: https://codereview.chromium.org/1563093003 Cr-Commit-Position: refs/heads/master@{#368833}
* Revert of GN: Properly mark all NaCl test depencies as data_deps (patchset ↵dbeam2016-01-041-4/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | #2 id:20001 of https://codereview.chromium.org/1547463004/ ) Reason for revert: broke windows GN build: https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/9754/steps/generate_build_files/logs/stdio E:\b\build\slave\Win_x64_GN\build\src\buildtools\win\gn gen //out/Release_x64 "--args=is_debug=false is_component_build=false use_goma=true goma_dir=\"E:\b\build\goma\" symbol_level=1" --check -> returned 1 ERROR Input to target not generated by a dependency. The file: //out/Release_x64/nacl_irt_x86_64.nexe is listed as an input or source for the target: //chrome/installer/mini_installer:archive(//build/toolchain/win:x64) but this file was not generated by any dependencies of the target. The target that generates the file is: //ppapi/native_client:nacl_irt_debuglink(//build/toolchain/nacl:irt_x64) Original issue's description: > GN: Properly mark all NaCl test depencies as data_deps > > NaCl tests and helpers are build as standalone executables and > hence need to be marked as data_deps to be copied over to shards. > > BUG=462791 > > Committed: https://crrev.com/21255d8b9b0ace0629fd941ee128cf9adf356b31 > Cr-Commit-Position: refs/heads/master@{#367367} TBR=brettw@chromium.org,bradnelson@chromium.org,phosek@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=462791 Review URL: https://codereview.chromium.org/1555223002 Cr-Commit-Position: refs/heads/master@{#367396}
* GN: Properly mark all NaCl test depencies as data_depsphosek2016-01-041-1/+4
| | | | | | | | | | | NaCl tests and helpers are build as standalone executables and hence need to be marked as data_deps to be copied over to shards. BUG=462791 Review URL: https://codereview.chromium.org/1547463004 Cr-Commit-Position: refs/heads/master@{#367367}
* Cleanup: Remove double semicolons.thestig2016-01-041-1/+1
| | | | | | | | Found with: git grep -l ';;$' | egrep '\.(cc|h)$' | grep -v third_party Review URL: https://codereview.chromium.org/1558633002 Cr-Commit-Position: refs/heads/master@{#367361}
* Switch to standard integer types in extensions/.avi2015-12-2336-6/+49
| | | | | | | | | BUG=138542 TBR=benwells@chromium.org Review URL: https://codereview.chromium.org/1543053002 Cr-Commit-Position: refs/heads/master@{#366716}
* Use rvalue reference instead of extensions::DictionaryBuilder::pass()limasdf2015-12-192-14/+13
| | | | | | | | | | | C++ 11 enables rvalue reference with std::move() so that removing DictionaryBuilder::Pass(). BUG=563649 TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/1532193003 Cr-Commit-Position: refs/heads/master@{#366280}
* Convert Pass()→std::move() in //extensionsdcheng2015-12-186-25/+28
| | | | | | | | BUG=557422 Review URL: https://codereview.chromium.org/1537893002 Cr-Commit-Position: refs/heads/master@{#366120}
* Move nacl targets to subdirectories.brettw2015-12-161-28/+5
| | | | | | | | | | | | | | | This clarifies the structure a bit and is the format recommended by GN style. Adds annotations to the GYP files for the corresponding GN targets. Removes some dead code in extensions/shell. R=dpranke@chromium.org TBR=thestig@chromium.org (chrome/linux/installer) Reland of https://codereview.chromium.org/1523503002 Review URL: https://codereview.chromium.org/1530663002 Cr-Commit-Position: refs/heads/master@{#365406}
* Revert of Move nacl targets to subdirectories. (patchset #6 id:100001 of ↵yoichio2015-12-151-5/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1523503002/ ) Reason for revert: This might cause errors in the generate_build_files step. https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/6471 Original issue's description: > Move nacl targets to subdirectories. > > This clarifies the structure a bit and is the format recommended by GN style. > > Adds annotations to the GYP files for the corresponding GN targets. Removes some dead code in extensions/shell. > > R=dpranke@chromium.org > > Committed: https://crrev.com/263435ba08cd291d9a0534719a599ad11098090a > Cr-Commit-Position: refs/heads/master@{#365139} TBR=dpranke@chromium.org,mcgrathr@chromium.org,phosek@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1522173003 Cr-Commit-Position: refs/heads/master@{#365146}
* Move nacl targets to subdirectories.brettw2015-12-151-28/+5
| | | | | | | | | | | | This clarifies the structure a bit and is the format recommended by GN style. Adds annotations to the GYP files for the corresponding GN targets. Removes some dead code in extensions/shell. R=dpranke@chromium.org Review URL: https://codereview.chromium.org/1523503002 Cr-Commit-Position: refs/heads/master@{#365139}
* Replace ScopedVector<ScopedFD> with std::vector<ScopedFD>mdempsky2015-12-091-0/+1
| | | | | | | | TBR=mseaborn@chromium.org,piman@chromium.org,derat@chromium.org Review URL: https://codereview.chromium.org/1508213002 Cr-Commit-Position: refs/heads/master@{#364189}
* Use rvalue reference instead of extensions::ListBuilder::Pass()limasdf2015-12-091-12/+13
| | | | | | | | | | | | C++ 11 enables rvalue reference with std::move() so that removing legacy ListBuilder::Pass() stuff. TEST=unit_tests BUG=563649 TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/1497753002 Cr-Commit-Position: refs/heads/master@{#363970}
* Run gn --format over all .gn filesagrieve2015-11-201-4/+4
| | | | | | | | | | | | | | | | The recent formatter alphebetizing change is causing a lot of noise in code reviews. Figured it'd be worth a clean-up CL. Exact command I ran: find . -name "*.gn*" -exec gn format --in-place "{}" \; TBR=ddorwin@chromium.org BUG=554928 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1464873002 Cr-Commit-Position: refs/heads/master@{#360891}
* Kill NOTIFICATION_EXTENSION_WILL_BE_INSTALLED_DEPRECATEDlimasdf2015-11-201-1/+1
| | | | | | | | | | | | | | Removing code where using it. - WaitForExtensionInstall() from c/b/e/extension_browsertest.h which having unclear behavior. (we're not able to expect when starting observing) - from extension_service.h where notify ..._INSTALLED_DEPRECATED TEST=browser_tests BUG=411568 Review URL: https://codereview.chromium.org/1403373020 Cr-Commit-Position: refs/heads/master@{#360840}
* Separate RenderViewHost from RenderWidgetHost, part 4: delegateavi2015-10-271-1/+1
| | | | | | | | | | | | | This makes a delegate interface between the RenderViewHost and the RenderWidgetHost, which will eventually be used for their communication. This also allows the removal of the horrible terrible no-good RenderWidgetHost::IsRenderView(). BUG=542477 TEST=all green Review URL: https://codereview.chromium.org/1411203010 Cr-Commit-Position: refs/heads/master@{#356286}
* Make chrome and other targets compile on Mac GNbrettw2015-10-232-1/+25
| | | | | | | | | | The other targets include browser_tests, interactive_ui_tests, sync_integration_tests, extensions_browsertests, content_shell, app_shell. These targets don't actually run because bundles aren't supported yet. Review URL: https://codereview.chromium.org/1413783003 Cr-Commit-Position: refs/heads/master@{#355917}
* Adding error handlers to setup.exe.pmonette2015-10-161-1/+1
| | | | | | | | | | | | | The handlers make setup crash cleanly when we run out of memory, on heap corruption and on invalid parameters in the CRT. Moved 2 functions from startup_helper_win to base target. Renamed startup_helper_win to sandbox_helper_win now that it contains only a function related to the sandbox. BUG=530624 Review URL: https://codereview.chromium.org/1387963006 Cr-Commit-Position: refs/heads/master@{#354591}
* Add extensions code to use common updater in components/update_client/asargent2015-10-155-22/+8
| | | | | | | | | | | | | | | | | | | This is another piece of work towards implementing differential extensions update and share autoupdate code with the chrome components system. It adds code to the extensions/browser directory that makes use of the common autoupdate code via the update_client::UpdateClient class to send update checks to the server, download a full .crx or differential update, and hand back an unpacked directory with the contents of the new extension version. This CL does not yet add any code in chrome/ that actually uses these new capabilities; that will be in a forthcoming CL. BUG=490418 Review URL: https://codereview.chromium.org/1362043005 Cr-Commit-Position: refs/heads/master@{#354370}
* Don't use base::MessageLoop::{Quit,QuitClosure} in extensions/, ipc/ki.stfu2015-10-121-2/+2
| | | | | | | | | | | | | This patch renames base::MessageLoop::{Quit,QuitClosure} to base::MessageLoop::{QuitWhenIdle,QuitWhenIdleClosure}. BUG=131220 TEST= R=finnur@chromium.org,agl@chromium.org Review URL: https://codereview.chromium.org/1389163008 Cr-Commit-Position: refs/heads/master@{#353545}
* Removing pneubeck@ from OWNERS.pneubeck2015-10-071-1/+1
| | | | | | | | Also adding some other overdue owners. Review URL: https://codereview.chromium.org/1384443003 Cr-Commit-Position: refs/heads/master@{#352825}
* Add public session launch flagkelvinp2015-10-012-0/+5
| | | | | | | | | | | This CL adds a flag to the launchData in chrome.runtime.app.onLaunched to indicate whether the app is being launched in a public session. BUG=508608 Review URL: https://codereview.chromium.org/1375353002 Cr-Commit-Position: refs/heads/master@{#351696}
* [Extensions] Make const PermissionSet* const PermissionSet& where possiblerdevlin.cronin2015-09-301-3/+3
| | | | | | | | | | | | | | Replace a bunch of pointers with const&. TBR=pkotwicz@chromium.org (themes) TBR=atwilson@chromium.org (background) TBR=rogerta@chromium.org (ui/sync) BUG=455414 Review URL: https://codereview.chromium.org/1365443003 Cr-Commit-Position: refs/heads/master@{#351631}
* base: Template methods on Timer classes instead of the classes themselves.danakj2015-09-241-1/+1
| | | | | | | | | | | | | | | | | | | The base class for OneShotTimer and DelayedTimer is templated but only the Start method needs to be (which has a TODO to make it go away entirely too). The DelayedTimer class is also templated but only its constructor needs to be, and the type can be inferred at the callsite, so less typing all around. R=thakis@chromium.org TBR=sky,brettw BUG=148832 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1355063004 Cr-Commit-Position: refs/heads/master@{#350496}
* Delete dead code related to the removed helper apps.kerrnel2015-09-211-32/+0
| | | | | | | | | | | | It is no longer clear if we will be adding more helper variants in the near future. This change removes any additional dead code related to the helper apps. BUG=520680 Review URL: https://codereview.chromium.org/1354703002 Cr-Commit-Position: refs/heads/master@{#349970}
generated by cgit v1.1 at 2025-01-06 21:11:49 +0000