| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=138542
TBR=aa@chromium.org
Switch to standard integer types in gin/.
BUG=138542
TBR=aa@chromium.org
Review URL: https://codereview.chromium.org/1541743002
Cr-Commit-Position: refs/heads/master@{#366345}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous CL was reverted because it broke layout tests.
Cause:
GetKeyModifiersFromV8() in test_runner/event_sender.cc passes
NULL as v8::Isolate*, which is cleary wrong. Pass
blink::mainThreadIsolate() as the other callsites do.
BUG=479439
Review URL: https://codereview.chromium.org/1152653004
Cr-Commit-Position: refs/heads/master@{#332312}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1106393002/)
Reason for revert:
Broke layout tests
Original issue's description:
> gin: Use V8 Maybe APIs
>
> TEST=gin_unittests
> BUG=479439
>
> Committed: https://crrev.com/7a6acf6c7d45e24f07781c69249d90967013bbe4
> Cr-Commit-Position: refs/heads/master@{#331923}
TBR=jochen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=479439
Review URL: https://codereview.chromium.org/1161053002
Cr-Commit-Position: refs/heads/master@{#331930}
|
|
|
|
|
|
|
|
|
| |
TEST=gin_unittests
BUG=479439
Review URL: https://codereview.chromium.org/1106393002
Cr-Commit-Position: refs/heads/master@{#331923}
|
|
|
|
|
|
|
|
|
|
| |
Handle is an alias for Local
BUG=424445
Review URL: https://codereview.chromium.org/1112923003
Cr-Commit-Position: refs/heads/master@{#327672}
|
|
|
|
|
|
|
|
|
|
| |
R=jochen@chromium.org
TBR=kalman@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1085733006
Cr-Commit-Position: refs/heads/master@{#326766}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Google C++ style guide states:
Explicitly annotate overrides of virtual functions or virtual
destructors with an override or (less frequently) final specifier.
Older (pre-C++11) code will use the virtual keyword as an inferior
alternative annotation. For clarity, use exactly one of override,
final, or virtual when declaring an override.
To better conform to these guidelines, the following constructs have
been rewritten:
- if a base class has a virtual destructor, then:
virtual ~Foo(); -> ~Foo() override;
- virtual void Foo() override; -> void Foo() override;
- virtual void Foo() override final; -> void Foo() final;
This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.
BUG=417463
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/645853012
Cr-Commit-Position: refs/heads/master@{#300925}
|
|
|
|
|
|
|
|
|
|
|
| |
This step is a giant search and replace for OVERRIDE and FINAL to
replace them with their lowercase versions.
BUG=417463
Review URL: https://codereview.chromium.org/629153002
Cr-Commit-Position: refs/heads/master@{#298220}
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=InterceptorTest.BypassInterceptor*
R=abarth@chromium.org,raymes@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/467243002
Cr-Commit-Position: refs/heads/master@{#289325}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The unittest also serves as an example how to use the interceptor API.
BUG=none
R=abarth@chromium.org,raymes@chromium.org
Review URL: https://codereview.chromium.org/352223008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
This will allow for using gin as a drop-in replacement for NPObject.
BUG=347565
R=abarth@chromium.org,dcarney@chromium.org,aa@chromium.org
Review URL: https://codereview.chromium.org/194603003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256431 0039d316-1c4b-4281-b951-d872f2087c98
|