summaryrefslogtreecommitdiffstats
path: root/ios/chrome/browser/translate/never_translate_infobar_controller.mm
Commit message (Collapse)AuthorAgeFilesLines
* Access generated resources through full path for better DEPS.sdefresne2016-02-051-1/+1
| | | | | | | | | TBR=oshima@chromium.org BUG=None Review URL: https://codereview.chromium.org/1672663002 Cr-Commit-Position: refs/heads/master@{#373785}
* Fix placeholder numbering in iOS specific strings.sdefresne2016-01-151-3/+5
| | | | | | | | | | | | | | | | The string IDS_TRANSLATE_INFOBAR_NEVER_MESSAGE_IOS only used a single placeholder but used "$2" instead of "$1" causing a DCHECK. Use the correct value. Rename the constant IDS_IOS_TRANSLATE_INFOBAR_NEVER_MESSAGE and move the string to ios/chrome/app/ios_${branding}_strings.grd as it is only used on iOS. BUG=None Review URL: https://codereview.chromium.org/1585923007 Cr-Commit-Position: refs/heads/master@{#369751}
* Convert IDS_TRANSLATE_INFOBAR_NEVER_MESSAGE_IOS to branded string.sdefresne2016-01-131-2/+0
| | | | | | | | | | | | Avoid using string interpolation to insert product name into string IDS_TRANSLATE_INFOBAR_NEVER_MESSAGE_IOS instead provide two branded variants of the strings. BUG=568486 Review URL: https://codereview.chromium.org/1579213004 Cr-Commit-Position: refs/heads/master@{#369147}
* Add scoped helper to install a custom ChromeBrowserProvider.sdefresne2015-12-171-2/+1
| | | | | | | | BUG=None Review URL: https://codereview.chromium.org/1532863002 Cr-Commit-Position: refs/heads/master@{#365817}
* Use language codes instead of array indices to set translate languagesmiguelg2015-12-091-2/+2
| | | | | | | | | | | | | | | | | | | BUG=555124 The translate infobar delegate now only accepts setting the original and target language by code. Android and Mac (the two active translate implementations using infobars) have been upgraded so their language spinners/menus keep the language code as associated data for every element. Some operations that were constant are now linear (on a list of ~100 elements). Nothing is in the critical path and it seems legit to the API less bug prone. I will investigate in a second step if we can change the translate bubbles as well at which point we could change the underlying data structure and make things constant again. Review URL: https://codereview.chromium.org/1473213002 Cr-Commit-Position: refs/heads/master@{#364081}
* Fixit: Cleanup of InfoBarController.noyau2015-06-011-23/+24
| | | | | | | | | | | | | | Removed instance variables from the header file, and cleaned up subclasses initializing ivars directly. Changed the way the InfobarView is created to avoid passing around an allocated but uninitialized object. BUG=None Review URL: https://codereview.chromium.org/1161243002 Cr-Commit-Position: refs/heads/master@{#332181}
* Remove the distinction between informational and warning infobarsdefresne2015-03-031-5/+1
| | | | | | | | | | | The need to make the distinction between the two types of infobars has disappeared with the new design of the infobars. BUG=None Review URL: https://codereview.chromium.org/975663002 Cr-Commit-Position: refs/heads/master@{#318896}
* Upstream //ios/chrome/browser/translatedroger2015-01-081-0/+93
This CL upstreams the iOS translate client code, and the iOS resources infrastructure. TBR=asvitkine Review URL: https://codereview.chromium.org/809333003 Cr-Commit-Position: refs/heads/master@{#310513}
generated by cgit v1.1 at 2025-03-23 12:33:20 +0000