summaryrefslogtreecommitdiffstats
path: root/ipc/ipc_message_macros.h
Commit message (Collapse)AuthorAgeFilesLines
* Revert of Clang plugin to check that unstable types are not used in IPC. ↵thakis2016-03-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #22 id:420001 of https://codereview.chromium.org/1665363002/ ) Reason for revert: IPC plugin tests are failing on the clang/tot win bots, even after the fix attempt. Original issue's description: > Clang plugin to check that unstable types are not used in IPC. > > We want IPC messages to be stable so that 32-bit and 64-bit processes > can talk to each other. This plugin blacklists the following types that > are known to be unstable: > > 1. Types: long / unsigned long (but not typedefs to) > 2. Typedefs: intmax_t, uintmax_t, intptr_t, uintptr_t, wint_t, > size_t, rsize_t, ssize_t, ptrdiff_t, dev_t, off_t, clock_t, > time_t, suseconds_t (including typedefs to) > > Blacklisted types are not allowed in IPC::WriteParam() invocations or > IPC::CheckedTuple<> specializations. > > BUG=581409 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/a817c371a7a33cdf9282b711dafbdcee83b788e4 > Cr-Commit-Position: refs/heads/master@{#380151} TBR=dcheng@chromium.org,jam@chromium.org,vmpstr@chromium.org,hans@chromium.org,dskiba@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=581409 Review URL: https://codereview.chromium.org/1783803002 Cr-Commit-Position: refs/heads/master@{#380408}
* Clang plugin to check that unstable types are not used in IPC.dskiba2016-03-091-1/+1
| | | | | | | | | | | | | | | | | | | | | We want IPC messages to be stable so that 32-bit and 64-bit processes can talk to each other. This plugin blacklists the following types that are known to be unstable: 1. Types: long / unsigned long (but not typedefs to) 2. Typedefs: intmax_t, uintmax_t, intptr_t, uintptr_t, wint_t, size_t, rsize_t, ssize_t, ptrdiff_t, dev_t, off_t, clock_t, time_t, suseconds_t (including typedefs to) Blacklisted types are not allowed in IPC::WriteParam() invocations or IPC::CheckedTuple<> specializations. BUG=581409 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel Review URL: https://codereview.chromium.org/1665363002 Cr-Commit-Position: refs/heads/master@{#380151}
* Replace base::Tuple in //ipc with std::tupletzik2016-03-081-2/+3
| | | | | | | | BUG=554987 Review URL: https://codereview.chromium.org/1770013002 Cr-Commit-Position: refs/heads/master@{#379759}
* Propagate window coordinates to out-of-process iframes renderers.lfg2016-03-041-2/+1
| | | | | | | | | | | | | This change also adds a Page message IPC class, which can be used by an interface in WebContentsImpl::SendPageMessage(IPC::Message*) to send an IPC message to every renderer in the FrameTree. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review URL: https://codereview.chromium.org/1685213002 Cr-Commit-Position: refs/heads/master@{#379384}
* use variadic macros/templates in IPC message implementationmdempsky2016-02-091-644/+205
| | | | | | | | TBR=jam@chromium.org, mseaborn@chromium.org Review URL: https://codereview.chromium.org/1532053002 Cr-Commit-Position: refs/heads/master@{#374316}
* Add message sizing to basic IPC traits and struct macros.rockot2016-02-051-0/+5
| | | | | | | | BUG=577685 Review URL: https://codereview.chromium.org/1655333002 Cr-Commit-Position: refs/heads/master@{#373720}
* ipc: Fix unused variable error when using IPC_HANDLER_GENERIC.sunnyps2016-02-051-0/+1
| | | | | | | | | | | | If we use only IPC_HANDLER_GENERIC inside an IPC_BEGIN_MESSAGE_MAP block we get an unused variable compile error for the extra param that's used in IPC_BEGIN_MESSAGE_MAP_WITH_PARAM. This CL suppresses that error. BUG=NONE Review URL: https://codereview.chromium.org/1667353002 Cr-Commit-Position: refs/heads/master@{#373714}
* Call base::DispatchToMethod by the fully qualified nametzik2015-11-191-1/+1
| | | | | | | | | | | | DispatchToMethod in IPC is looked up in ADL rule for base::Tuple. That is going to unavailable when we start using std::tuple. This CL removes the ADL application to avoid the lookup error in advance. BUG=554987 Review URL: https://codereview.chromium.org/1461813002 Cr-Commit-Position: refs/heads/master@{#360687}
* ipc: Convert int types from basictypes.h to the ones from stdint.htfarina2015-09-041-6/+8
| | | | | | | | | | | | | | Now that the supported toolchain has stdint.h, use the integer types from this standard header file. BUG=138542 TEST=ipc_tests R=tsepez@chromium.org TBR=sadrul@chromium.org # for ui/ Review URL: https://codereview.chromium.org/1322253003 Cr-Commit-Position: refs/heads/master@{#347457}
* Fix a few typos in the IPC message macros documentationphilipj2015-08-121-6/+6
| | | | | | | | | BUG=none R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1284593004 Cr-Commit-Position: refs/heads/master@{#342990}
* Move Tuple to base namespace.brettw2015-05-291-41/+50
| | | | | | | | | | | | | | Namespace change only, no functionality change. The only non-search-and-replace change is in generate_gmock_mutant.py which changes some line wrapping logic for the generated gmock_mutant header. NOPRESUBMIT=true (No presubmit due to long lines in the generated gmock_mutant.h header). R=sky Review URL: https://codereview.chromium.org/1159553007 Cr-Commit-Position: refs/heads/master@{#332058}
* undo zturner visualc compiler workaroundcpu2015-01-271-7/+0
| | | | | | | | | | | | | | An optimization on the compiler. https://connect.microsoft.com/VisualStudio/feedback/details/800200/preprocessing-broken-in-vs2013 also see comment #56 on the bug below BUG=288948 Review URL: https://codereview.chromium.org/878763003 Cr-Commit-Position: refs/heads/master@{#313304}
* Revert of Revert "Update legacy Tuple-using code." (patchset #1 id:1 of ↵avi2014-12-231-17/+18
| | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/826573002/) Reason for revert: The tests should have failed with this. Undoing the revert. Original issue's description: > Revert "Update legacy Tuple-using code." > > This reverts commit 12f4b98357b9dedc93cb546aac0aece2c8d9e850 > > BUG=440675, 444827 > > Committed: https://chromium.googlesource.com/chromium/src/+/85748694f2a119a057088f77f70b97f11607473c TBR= NOTREECHECKS=true NOTRY=true BUG=440675, 444827 Review URL: https://codereview.chromium.org/794073003 Cr-Commit-Position: refs/heads/master@{#309586}
* Revert "Update legacy Tuple-using code."Avi Drissman2014-12-231-18/+17
| | | | | | | | | | This reverts commit 12f4b98357b9dedc93cb546aac0aece2c8d9e850 BUG=440675, 444827 Review URL: https://codereview.chromium.org/826573002 Cr-Commit-Position: refs/heads/master@{#309583}
* Update legacy Tuple-using code.Avi Drissman2014-12-221-17/+18
| | | | | | | | | | | BUG=440675 TEST=no change R=mdempsky@chromium.org, nasko@chromium.org TBR=ben@chromium.org Review URL: https://codereview.chromium.org/814403003 Cr-Commit-Position: refs/heads/master@{#309432}
* Remove last non-third_party typeofs on Mac.thakis2014-10-291-9/+1
| | | | | | | | BUG=427584 Review URL: https://codereview.chromium.org/684273002 Cr-Commit-Position: refs/heads/master@{#301948}
* Standardize usage of virtual/override/final in ipc/dcheng2014-10-221-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. Several formatting edits by clang-format were manually reverted, due to mangling of some of the more complicate IPC macros. BUG=417463 R=agl@chromium.org Review URL: https://codereview.chromium.org/666493005 Cr-Commit-Position: refs/heads/master@{#300623}
* Revert of Standardize usage of virtual/override/final in ipc/ (patchset #1 ↵dcheng2014-10-211-48/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | id:1 of https://codereview.chromium.org/645623006/) Reason for revert: Addressing reviewer comments in a followup patch. Original issue's description: > Standardize usage of virtual/override/final in ipc/ > > This patch was automatically generated by applying clang fixit hints > generated by the plugin to the source tree. > > BUG=417463 > TBR=agl@chromium.org > > Committed: https://crrev.com/39be52ebbd6681c7d79ad63e2a0ab028075af0c2 > Cr-Commit-Position: refs/heads/master@{#300481} TBR=agl@chromium.org NOTREECHECKS=true NOTRY=true BUG=417463 Review URL: https://codereview.chromium.org/669953003 Cr-Commit-Position: refs/heads/master@{#300521}
* Standardize usage of virtual/override/final in ipc/dcheng2014-10-211-51/+48
| | | | | | | | | | | | This patch was automatically generated by applying clang fixit hints generated by the plugin to the source tree. BUG=417463 TBR=agl@chromium.org Review URL: https://codereview.chromium.org/645623006 Cr-Commit-Position: refs/heads/master@{#300481}
* Modify ALLOW_UNUSED to allow enabling unused local warnings on MSVC.pkasting2014-10-161-6/+6
| | | | | | | | | | | | | | | | | | | | | | This splits the macro into two: int a = 1; ALLOW_UNUSED_LOCAL(a); and typedef Foo Bar ALLOW_UNUSED_TYPE; void foo() ALLOW_UNUSED_TYPE; // ALLOW_UNUSED_TYPE_OR_FUNC seemed too verbose This matches changes that have already been made in Blink. BUG=81439 TEST=none TBR=ben Review URL: https://codereview.chromium.org/650393002 Cr-Commit-Position: refs/heads/master@{#300014}
* Adding tracking to verify the theory that jankiness of ↵vadimt2014-09-251-4/+4
| | | | | | | | | | ExtensionMessageFilter::OnExtensionAddListener is because of the observer invocation. BUG=401560, 417106 Review URL: https://codereview.chromium.org/600213002 Cr-Commit-Position: refs/heads/master@{#296804}
* Make IPC macros work with -Wunused-local-typedefs.thakis@chromium.org2014-07-291-6/+6
| | | | | | | | | | | | | | | The typedef can be used by the IPC_MESSAGE_HANDLER macro, but that macro isn't always used when IPC_BEGIN_MESSAGE_MAP is used. The alternatives are to either pass ClassName::HanderFunction to IPC_MESSAGE_HANDLER (like what one has to do to use IPC_MESSAGE_FORWARD), or to mark the typedef in IPC_BEGIN_MESSAGE_MAP as ALLOW_UNUSED so that it isn't warned on. BUG=321833 TBR=brettw Review URL: https://codereview.chromium.org/422083002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286115 0039d316-1c4b-4281-b951-d872f2087c98
* Fix "inlcude" typo in comments.tsepez@chromium.org2014-06-181-2/+2
| | | | | | | | NOTRY=true Review URL: https://codereview.chromium.org/343473006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278113 0039d316-1c4b-4281-b951-d872f2087c98
* Remove IPC_BEGIN_MESSAGE_MAP_EX macro since r270839 made all bad IPCs kill ↵jam@chromium.org2014-05-161-31/+8
| | | | | | | | | | their child processes. R=avi@chromium.org Review URL: https://codereview.chromium.org/292443004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271096 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that any IPC sent from a child process that couldn't be deserialized ↵jam@chromium.org2014-05-151-0/+4
| | | | | | | | | | | | causes that process to be killed. Today we do this only for a subset of IPCs and not all process types. R=jar@chromium.org, tsepez@chromium.org Review URL: https://codereview.chromium.org/283313002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270839 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify IPC_BEGIN_MESSAGE_MAP_WITH_PARAM macro by using decltype keyword.jam@chromium.org2014-05-141-9/+19
| | | | | | | | | BUG=304341 R=avi@chromium.org Review URL: https://codereview.chromium.org/286863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270479 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for passing an arbitrary parameter to an IPC message handler. ↵jam@chromium.org2014-05-131-76/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The motivation is for WebContentsObserver to pass RenderFrameHost* to message handlers easily. As an example, an observer would look like this: bool FooWebContentsObserver::OnMessageReceived( const IPC::Message& message, RenderFrameHost* render_frame_host) { IPC_BEGIN_MESSAGE_MAP_WITH_PARAM(FooWebContentsObserver, message, RenderFrameHost, render_frame_host) IPC_MESSAGE_HANDLER(FooHostMsg_Bar, OnBar) . . . void FooWebContentsObserver::OnBar(RenderFrameHost* render_frame_host, ... You can of course still have dispatchers without the extra parameter as before. This is generalizing the existing code that allows an IPC message handler to have a "const IPC::Message& message) first parameter to get access to the IPC. Sync IPCs don't support this yet. It's a lot more work because for them we conveniently reuse tuple's DispatchToMethod. This isn't urgent yet, since sync IPCs aren't dispatched on the UI thread for the most part because of NPAPI and Windows, so punting on this for now. BUG=304341 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/283623002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270237 0039d316-1c4b-4281-b951-d872f2087c98
* more spell checkingthakis@chromium.org2013-11-051-1/+1
| | | | | | | | | BUG=none NOTRY=true Review URL: https://codereview.chromium.org/57463003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232902 0039d316-1c4b-4281-b951-d872f2087c98
* Revert https://src.chromium.org/viewvc/chrome?view=rev&revision=231330bbudge@chromium.org2013-11-041-6/+6
| | | | | | | | | | This is a speculative revert to see if it's the cause of hanging renderers. BUG=313112 Review URL: https://codereview.chromium.org/57783006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232819 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused IPC::Message priority.bbudge@chromium.org2013-10-281-6/+6
| | | | | | | | | | | | | | | | | Removes the PriorityValue enum and field from IPC::Message. This doesn't appear to be used anywhere. Changes the data message ctor to take a size_t data_len parameter. This works around an ambiguity problem with the main ctor, which has a similar signature and would require lots of futzing with our test code to fix. To make this work, the matching Pickle constructor is also changed to take a size_t data_len parameter. BUG=194304 Review URL: https://codereview.chromium.org/35643005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231330 0039d316-1c4b-4281-b951-d872f2087c98
* IPC_END_MESSAGE_MAP: Made unreachable DCHECK reachable.mgiuca@chromium.org2013-10-231-1/+1
| | | | | | | | BUG=309505 Review URL: https://codereview.chromium.org/31623002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230555 0039d316-1c4b-4281-b951-d872f2087c98
* Add newline at end of file.thakis@chromium.org2013-10-121-1/+1
| | | | | | | | | BUG=290204 TBR=hans@chromium.org Review URL: https://codereview.chromium.org/27094002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228321 0039d316-1c4b-4281-b951-d872f2087c98
* Workaround for VS2013 compiler bug in ipc_message_macros.hzturner@chromium.org2013-10-121-0/+7
| | | | | | | | BUG=288948 Review URL: https://codereview.chromium.org/23455048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228298 0039d316-1c4b-4281-b951-d872f2087c98
* Implement off-the-wire validation scheme for emum types.tsepez@chromium.org2013-06-041-4/+17
| | | | | | | | | | | | | This CL adds explicit IPC macros that can be used to ensure that the values being read off the wire are legitimate for the enum type. BUG=176110 R=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/15841011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203892 0039d316-1c4b-4281-b951-d872f2087c98
* Split IPC logging between content and chrome.jochen@chromium.org2012-10-301-14/+4
| | | | | | | | | | | | | I add a new content API to register IPC message loggers, and modify the IPC message macros to not directly create the g_log_function_mapping. That allows for multiple files generating IPC loggers. Also, it gets rid of the ctor/dtor for the g_log_function_mapping. BUG=101600,111316,155765 Review URL: https://codereview.chromium.org/11347012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164861 0039d316-1c4b-4281-b951-d872f2087c98
* Move IPCMessageStart enum into it own file with security team OWNERS, so ↵tsepez@chromium.org2012-10-231-1/+1
| | | | | | | | that new message files can't be added to chromium without triggering a security review. Review URL: https://chromiumcodereview.appspot.com/11048038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163713 0039d316-1c4b-4281-b951-d872f2087c98
* Make Sync Messages with lots of parameters and no return workfsamuel@chromium.org2012-08-011-2/+2
| | | | | | | | | | | There are a couple of broken macros that will be used by the browser plugin. BUG=none TEST=compiles (+ local testing with browser plugin) Review URL: https://chromiumcodereview.appspot.com/10829084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149466 0039d316-1c4b-4281-b951-d872f2087c98
* Remove IPC macros for "5_4" messages.brettw@chromium.org2012-07-131-6/+0
| | | | | | | | | | | Nobody uses these. Since we don't have tuples for 9 elements, attempts to use them will fail. TEST=it compiles BUG=none Review URL: https://chromiumcodereview.appspot.com/10735092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146609 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the rest of #pragma once in one big CL.ajwong@chromium.org2012-07-111-1/+1
| | | | | | | | | For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for default values of IPC_STRUCT_MEMBER.jbates@chromium.org2012-04-161-1/+3
| | | | | | Review URL: http://codereview.chromium.org/10067023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132435 0039d316-1c4b-4281-b951-d872f2087c98
* Make IPC_MESSAGE_EXPORT more robust.thakis@chromium.org2012-02-211-6/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, files that want to export ipc messages currently do #undef IPC_MESSAGE_EXPORT #define IPC_MESSAGE_EXPORT CONTENT_EXPORT at the top, and files that don't want to export ipc messages just do nothing. This is problematic if a cc file does #include "exported_messages.h" #include "not_exported_messages.h" because the second header file picks up the #define from the first file and declares all its messages as exported. In other translation units, where not_exported_messages.h is #included without another header above it, the messages will get default visibility – so the same class ends up with different visibilities in different translation units. Instead, let ipc_message_macros.h #undef IPC_MESSAGE_EXPORT outside of the include guard, so that all files that don't set the define see it as defined to nothing. (Idea from jam@) Also disable about:ipc in the component build, since ipc logging adds a dependency from chrome on all ipc message classes, so they would all have to be exported. BUG=90078 TEST=No linker errors about IPC messages when doing components build on mac. (Other linker errors remain for now.) TBR=brettw Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122689 Review URL: http://codereview.chromium.org/9425006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122828 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting in an attempt to fix Win Builder 2010 (dbg).jhawkins@chromium.org2012-02-181-9/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Revert 122689 - Make IPC_MESSAGE_EXPORT more robust. Currently, files that want to export ipc messages currently do #undef IPC_MESSAGE_EXPORT #define IPC_MESSAGE_EXPORT CONTENT_EXPORT at the top, and files that don't want to export ipc messages just do nothing. This is problematic if a cc file does #include "exported_messages.h" #include "not_exported_messages.h" because the second header file picks up the #define from the first file and declares all its messages as exported. In other translation units, where not_exported_messages.h is #included without another header above it, the messages will get default visibility – so the same class ends up with different visibilities in different translation units. Instead, let ipc_message_macros.h #undef IPC_MESSAGE_EXPORT outside of the include guard, so that all files that don't set the define see it as defined to nothing. (Idea from jam@) BUG=90078 TEST=No linker errors about IPC messages when doing components build on mac. (Other linker errors remain for now.) TBR=brettw Review URL: http://codereview.chromium.org/9425006 TBR=thakis@chromium.org Review URL: https://chromiumcodereview.appspot.com/9355029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122698 0039d316-1c4b-4281-b951-d872f2087c98
* Make IPC_MESSAGE_EXPORT more robust.thakis@chromium.org2012-02-181-6/+9
| | | | | | | | | | | | | | | | | | | | | | | | Currently, files that want to export ipc messages currently do #undef IPC_MESSAGE_EXPORT #define IPC_MESSAGE_EXPORT CONTENT_EXPORT at the top, and files that don't want to export ipc messages just do nothing. This is problematic if a cc file does #include "exported_messages.h" #include "not_exported_messages.h" because the second header file picks up the #define from the first file and declares all its messages as exported. In other translation units, where not_exported_messages.h is #included without another header above it, the messages will get default visibility – so the same class ends up with different visibilities in different translation units. Instead, let ipc_message_macros.h #undef IPC_MESSAGE_EXPORT outside of the include guard, so that all files that don't set the define see it as defined to nothing. (Idea from jam@) BUG=90078 TEST=No linker errors about IPC messages when doing components build on mac. (Other linker errors remain for now.) TBR=brettw Review URL: http://codereview.chromium.org/9425006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122689 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of a bunch of view_messages.h includes from chrome by making the ↵jam@chromium.org2011-11-211-1/+3
| | | | | | | | | TabContentsObserver interface not use a struct from it. Instead, the interface uses a new struct, content::FrameNavigateParams, that's in the public directory. The IPC message's struct derives from it. BUG=98716 Review URL: http://codereview.chromium.org/8603015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110963 0039d316-1c4b-4281-b951-d872f2087c98
* Uncomment a different third IPC hook for about:profilerjar@chromium.org2011-11-151-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | If this causes ASAN problems with browser tests, then I'll revert it. Tests to watch out for (on ASAN bot) are: IncognitoSplitMode TwoExtensionsCrashBothAtOnce TwoExtensionsOneByOne AutoUpdate CognitoNoFile IncognitoNoFile OnChangedNotificationsBetweenBackgroundPages SplitModeIncognito So far, I've uncommented two hooks, with no problems ;-). One of these hooks will illuminate the problems. r=rtenneti BUG=103830 Review URL: http://codereview.chromium.org/8463033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110114 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 109760 - Uncomment third IPC hook for about:profilerjar@chromium.org2011-11-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If this causes ASAN problems with browser tests, then I'll revert it. Tests to watch out for (on ASAN bot) are: IncognitoSplitMode TwoExtensionsCrashBothAtOnce TwoExtensionsOneByOne AutoUpdate CognitoNoFile IncognitoNoFile OnChangedNotificationsBetweenBackgroundPages SplitModeIncognito So far, I've uncommented two hooks, with no problems ;-). One of these hooks will illuminate the problems. r=rtenneti BUG=103830 Review URL: http://codereview.chromium.org/8491065 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/8538035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109762 0039d316-1c4b-4281-b951-d872f2087c98
* Uncomment third IPC hook for about:profilerjar@chromium.org2011-11-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | If this causes ASAN problems with browser tests, then I'll revert it. Tests to watch out for (on ASAN bot) are: IncognitoSplitMode TwoExtensionsCrashBothAtOnce TwoExtensionsOneByOne AutoUpdate CognitoNoFile IncognitoNoFile OnChangedNotificationsBetweenBackgroundPages SplitModeIncognito So far, I've uncommented two hooks, with no problems ;-). One of these hooks will illuminate the problems. r=rtenneti BUG=103830 Review URL: http://codereview.chromium.org/8491065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109760 0039d316-1c4b-4281-b951-d872f2087c98
* Uncomment second IPC hook for about:profilerjar@chromium.org2011-11-111-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | If this causes ASAN problems with browser tests, then I'll revert it. Tests to watch out for (on ASAN bot) are: IncognitoSplitMode TwoExtensionsCrashBothAtOnce TwoExtensionsOneByOne AutoUpdate CognitoNoFile IncognitoNoFile OnChangedNotificationsBetweenBackgroundPages SplitModeIncognito r=rtenneti BUG=103830 Review URL: http://codereview.chromium.org/8540015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109721 0039d316-1c4b-4281-b951-d872f2087c98
* Uncomment first (major) IPC hook for about:profilerjar@chromium.org2011-11-111-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | If this causes ASAN problems with browser tests, then I'll revert it. Tests to watch out for (on ASAN bot) are: IncognitoSplitMode TwoExtensionsCrashBothAtOnce TwoExtensionsOneByOne AutoUpdate CognitoNoFile IncognitoNoFile OnChangedNotificationsBetweenBackgroundPages SplitModeIncognito r=rtenneti BUG=103830 Review URL: http://codereview.chromium.org/8515022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109553 0039d316-1c4b-4281-b951-d872f2087c98
* Land commented out IPC hooks for profilingjar@chromium.org2011-11-111-31/+42
| | | | | | | | | | | | | When I uncomment them all, then browser tests timeout under ASAN for no apparent reason. This landing will make it easier for me to uncomment them one at a time. (without going back to square one). r=rtenneti BUG/103830 Review URL: http://codereview.chromium.org/8526016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109542 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-05-19 14:45:41 +0000