summaryrefslogtreecommitdiffstats
path: root/jingle
Commit message (Collapse)AuthorAgeFilesLines
* Replacing the OVERRIDE with override and FINAL with final in jinglemohan.reddy2014-10-0730-176/+176
| | | | | | | | | | | This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Review URL: https://codereview.chromium.org/628123002 Cr-Commit-Position: refs/heads/master@{#298335}
* Replace forward_dependent_configs with public_depsBrett Wilson2014-09-231-6/+10
| | | | | | | | | | | | This is the new name. It has the same meaning but additionally with a "you can use the headers" permission. Rename direct_dependent_configs to public_configs. This is the new name with identical meaning. TBR=jamesr Review URL: https://codereview.chromium.org/595073002 Cr-Commit-Position: refs/heads/master@{#296302}
* Use SafeWrapCurrent to make sure JingleThreadWrapper ctor does not fail.jiayl2014-09-221-1/+1
| | | | | | | | BUG=413853 Review URL: https://codereview.chromium.org/585133002 Cr-Commit-Position: refs/heads/master@{#295997}
* Fail early if rtc::Thread::WrapCurrent failed to get more information for ↵jiayl2014-09-161-1/+1
| | | | | | | | | | debugging. BUG=413853 Review URL: https://codereview.chromium.org/574153002 Cr-Commit-Position: refs/heads/master@{#295170}
* Cleanup: Use base/files/file_util.h instead of base/file_util.h in [c-n]*/thestig2014-09-131-1/+1
| | | | | | | | | TBR=cpu@chromium.org,jochen@chromium.org,piman@chromium.org,rockot@chromium.org,rsleevi@chromium.org,vrk@chromium.org ,zea@chromium.org Review URL: https://codereview.chromium.org/563173002 Cr-Commit-Position: refs/heads/master@{#294712}
* Mark gtest and gmock as testonly in GN.Brett Wilson2014-09-081-0/+1
| | | | | | | | | | | This updates the targets that depend on these to also be test-only. BUG=http://crbug.com/412064 R=jamesr@chromium.org, tfarina@chromium.org Review URL: https://codereview.chromium.org/551933002 Cr-Commit-Position: refs/heads/master@{#293808}
* Add lots of testonly annotations to the GN build.Brett Wilson2014-09-081-0/+1
| | | | | | | | | BUG= R=hclam@chromium.org Review URL: https://codereview.chromium.org/547793002 Cr-Commit-Position: refs/heads/master@{#293774}
* Roll WebRTC 7011:7046 libjingle: 7007:7045niklase2014-09-0812-19/+21
| | | | | | | | | | | | | Original review here: https://codereview.chromium.org/543433002 This CL includes path fixes that are required due to directory structure changes in the new revision(s) TBR=tommi@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/545003004 Cr-Commit-Position: refs/heads/master@{#293761}
* Handles proxy authentication request in ProxyResolvingClientSocket.jiayl2014-08-281-0/+11
| | | | | | | | | | This will make the WebRTC connection work under NTLM/Kerberos using the default credential without prompting the user. BUG=395614 Review URL: https://codereview.chromium.org/414523005 Cr-Commit-Position: refs/heads/master@{#292428}
* Port parts of //third_pary/libjingle build to GNajwong2014-08-231-19/+6
| | | | | | | | | | | | | | | | | | | | | | | Reimplements parts of //third_party/libjingle's build in GN. The new build is much less flexible than the original. No configuration variables have been ported. Some windows-specific configs have been left out and annotated with TODOs. Most signifcantly, the entirety of the 'if (enable_webrtc)' block has been omitted, because the GN build for webrtc isn't working yet. Despite these limitations, it is an adequate replacement for the 'stub' libjingle target in most situations. Note, this CL is a near direct copy of rlarocque's work at https://codereview.chromium.org/455583002/ BUG=none TBR=sky,pavely,rlarocque Review URL: https://codereview.chromium.org/498603002 Cr-Commit-Position: refs/heads/master@{#291587}
* Keep track of network error in ProxyRetryInfo.kundaji@chromium.org2014-08-151-1/+1
| | | | | | | | | | | | Use it to log error type in BypassOneNetworkError UMA. This fixes DataReductionProxy.BypassOnNetworkError UMA recording bug. BUG=395769 Review URL: https://codereview.chromium.org/473513002 Cr-Commit-Position: refs/heads/master@{#290054} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290054 0039d316-1c4b-4281-b951-d872f2087c98
* Update presubmit files to send windows tryjobs to swarming bots, now that ↵jam@chromium.org2014-08-131-1/+1
| | | | | | | | | | | the CQ has switched over. R=avi@chromium.org Review URL: https://codereview.chromium.org/461313002 Cr-Commit-Position: refs/heads/master@{#289157} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289157 0039d316-1c4b-4281-b951-d872f2087c98
* GN: Make content_shell and webkit_unit_tests work in component buildjamesr@chromium.org2014-08-121-5/+5
| | | | | | | | | | | | Except for webrtc, this produces content_shell and webkit_unit_tests binaries that link and run successfully on linux. R=brettw@chromium.org Review URL: https://codereview.chromium.org/462983002 Cr-Commit-Position: refs/heads/master@{#289007} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289007 0039d316-1c4b-4281-b951-d872f2087c98
* Update manually triggered try jobs to use swarming for ChromeOS and Mac ↵jam@chromium.org2014-08-071-1/+1
| | | | | | | | | | since they're switched by CQ already. TBR=ben Review URL: https://codereview.chromium.org/450583002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288050 0039d316-1c4b-4281-b951-d872f2087c98
* Update webrtc&libjingle 6774:6825.ronghuawu@chromium.org2014-08-0634-213/+215
| | | | | | | | | | | | | BUG=N/A R=hellner@chromium.org TBR=darin@chromium.org, hclam@chromium.org, jochen@chromium.org, palmer@chromium.org, wez@chromium.org Commit on behalf of hellner@. Original CL tried and approved in https://codereview.chromium.org/429113002/ Review URL: https://codereview.chromium.org/450463002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287788 0039d316-1c4b-4281-b951-d872f2087c98
* GN support for //jingle directoryrlarocque@chromium.org2014-08-052-0/+207
| | | | | | | | | | | | Supports GN build of //jingle, though its targets won't be linkable until its dependency //third_party/libjingle is properly supported. TBR=ajwong BUG= Review URL: https://codereview.chromium.org/431423002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287425 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Update webrtc&libjingle 6774:6799."erikchen@chromium.org2014-07-3134-215/+213
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit bf45dff0ca703e5ad3bb6c6754ebdcb0c1b1296a. (https://codereview.chromium.org/429253003) Broke sizes on Linux http://build.chromium.org/p/chromium/builders/Linux/builds/51786 https://code.google.com/p/webrtc/source/browse/trunk/webrtc/base/linux.cc defines static std::string lsb_release_string; among other things It's guarded in WEBRTC_CHROMIUM_BUILDs. Maybe it should be WEBRTC_CHROMIUM_BUILD. BUG=NONE TBR=darin@chromium.org, hclam@chromium.org, jochen@chromium.org, palmer@chromium.org, sergeyu@chromium.org, wez@chromium.org, ronghuawu@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/435823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286914 0039d316-1c4b-4281-b951-d872f2087c98
* Update webrtc&libjingle 6774:6799.ronghuawu@chromium.org2014-07-3134-213/+215
| | | | | | | | | | | | | BUG=N/A R=hellner@chromium.org TBR=darin@chromium.org, hclam@chromium.org, jochen@chromium.org, palmer@chromium.org, sergeyu@chromium.org, wez@chromium.org Commit on behalf of hellner@. Original CL tried and approved in https://codereview.chromium.org/429113002/ Review URL: https://codereview.chromium.org/429253003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286902 0039d316-1c4b-4281-b951-d872f2087c98
* Update masters after the tryserver split.sergeyberezin@chromium.org2014-07-261-2/+6
| | | | | | | | | | | Also replace deprecated linux_chromium_rel with linux_chromium_rel_swarming, while I'm at it. R=agable@chromium.org, maruel@chromium.org BUG=395196 Review URL: https://codereview.chromium.org/415323002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285752 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ServerBoundCert => ChannelID to reflect the current namerch@chromium.org2014-07-252-4/+4
| | | | | | | | | | of this feature. TBR=darin Review URL: https://codereview.chromium.org/356713005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285432 0039d316-1c4b-4281-b951-d872f2087c98
* Remove jingle_glue_test_util targetsergeyu@chromium.org2014-07-215-431/+0
| | | | | | | | | | jingle_glue_test_util was added long time ago for P2P API in Pepper. The API was removed long time ago and we no longer need jingle_glue_test_util. Review URL: https://codereview.chromium.org/400093002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284514 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes for re-enabling more MSVC level 4 warnings: misc edition #2pkasting@chromium.org2014-07-182-4/+4
| | | | | | | | | | | | | | | | | | This contains fixes for the following sorts of issues: * Assignment inside conditional * Taking the address of a temporary * Octal escape sequence terminated by decimal number * Signedness mismatch * Possibly-uninitialized local variable This also contains a small number of cleanups to nearby code (e.g. no else after return). BUG=81439 TEST=none Review URL: https://codereview.chromium.org/382673002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283967 0039d316-1c4b-4281-b951-d872f2087c98
* Add Finch experiment for selectively bypassing proxies.rcs@chromium.org2014-07-091-2/+5
| | | | | | | | | | | | | | | Add option to bypass the data compression proxy if the request resource type (as inferred by the renderer process) is not an image. For background, see this design doc: https://docs.google.com/a/google.com/document/d/1Kz92Fmw3lv_R-2aNvLp8jW9lkfKOZciTZtni2qQ_Adc/edit BUG=391836 Review URL: https://codereview.chromium.org/332313003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281951 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Revert "[Mac] Reland r276808 Use a native MessagePump instead of a ↵jeremy@chromium.org2014-06-252-48/+62
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | MessagePumpDefault" (https://codereview.chromium.org/354673005/) Reason for revert: Original revert was due to a perf regression, which turned out to be nothing - see crbug.com/388360 for details. Original issue's description: > Revert "[Mac] Reland r276808 Use a native MessagePump instead of a MessagePumpDefault" > > This reverts commit e82339d44d0dde725295785b9fea8c448d382621. > > See if this fixes the perf regression. > > BUG=388360 > TBR=jeremy@chromium.org > NOTRY=true > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279474 TBR=miletus@chromium.org NOTREECHECKS=true NOTRY=true BUG=388360 Review URL: https://codereview.chromium.org/349933004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279749 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "[Mac] Reland r276808 Use a native MessagePump instead of a ↵miletus@chromium.org2014-06-242-62/+48
| | | | | | | | | | | | | | | | MessagePumpDefault" This reverts commit e82339d44d0dde725295785b9fea8c448d382621. See if this fixes the perf regression. BUG=388360 TBR=jeremy@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/354673005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279474 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Reland r276808 Use a native MessagePump instead of a MessagePumpDefaultjeremy@chromium.org2014-06-232-48/+62
| | | | | | | | | | | | | Original CL: https://codereview.chromium.org/331513002/ Relanding after fixing XmppConnectionTest.MultipleConnect test. BUG=356804,385604 TBR=mark@chromium.org,ajwong@chromium.org Review URL: https://codereview.chromium.org/348283002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279089 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of [Mac] Reland r276808 Use a native MessagePump instead of a ↵ckocagil@chromium.org2014-06-221-48/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | MessagePumpDefault (https://coderevie… (https://codereview.chromium.org/331983002/) Reason for revert: Breaks XmppConnectionTest.MultipleConnect on Mac: http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/50525 Original issue's description: > Reland change to use a native MessagePump instead of a MessagePumpDefault. > Original CL: https://codereview.chromium.org/331513002/ > > The previous CL caused a bunch of LibJingle unit tests to fail because the tests > were using a gtest death test which runs in the context of a fork()ed but not > execu()ed process. > > A CF Message loop can't live in this environment. Explicitly construct a > MessagePumpDefault for these tests. > > BUG=356804,385604 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279013 TBR=mark@chromium.org,ajwong@chromium.org,jeremy@chromium.org NOTREECHECKS=true NOTRY=true BUG=356804,385604 Review URL: https://codereview.chromium.org/332333004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279019 0039d316-1c4b-4281-b951-d872f2087c98
* Reland change to use a native MessagePump instead of a MessagePumpDefault.jeremy@chromium.org2014-06-221-39/+48
| | | | | | | | | | | | | | | | | Original CL: https://codereview.chromium.org/331513002/ The previous CL caused a bunch of LibJingle unit tests to fail because the tests were using a gtest death test which runs in the context of a fork()ed but not execu()ed process. A CF Message loop can't live in this environment. Explicitly construct a MessagePumpDefault for these tests. BUG=356804,385604 Review URL: https://codereview.chromium.org/331983002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279013 0039d316-1c4b-4281-b951-d872f2087c98
* Update UMA to track bypasses due to 4xx responses that are missing the ↵bengr@chromium.org2014-05-301-1/+1
| | | | | | | | | | proxy's via header and bypasses due to network errors. BUG=376148 Review URL: https://codereview.chromium.org/298883011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273839 0039d316-1c4b-4281-b951-d872f2087c98
* Remove HTTP pipelining support.mmenke@chromium.org2014-05-271-2/+0
| | | | | | | | | | | | | | | | It's been a couple years since anyone worked on it, and there are no plans to enable it by default. Cached pipelining-related server information will automatically be cleared when server information is next saved, so there are no issues on that front. BUG=364557 R=asvitkine@chromium.org, eroman@chromium.org, grt@chromium.org, sky@chromium.org, willchan@chromium.org, zea@chromium.org Review URL: https://codereview.chromium.org/275953002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272903 0039d316-1c4b-4281-b951-d872f2087c98
* Remove HttpStreamFactory's NPN/SPDY globals, except for spdy_enabled.mmenke@chromium.org2014-05-241-0/+9
| | | | | | | | | | | | | | | | | | | Instead, each HttpNetworkSession is given its own immutable copies on construction. Other than spdy_enabled, none of the globals were changed before this CL, anyways. Also, setting spdy_enabled back to true after setting it to false no longer clears the NPN list. spdy_enabled is still a global because group policy can set it to false at runtime. BUG=372533 R=joaodasilva@chromium.org, rch@chromium.org, sergeyu@chromium.org, sgurun@chromium.org, sky@chromium.org, ttuttle@chromium.org Review URL: https://codereview.chromium.org/284423002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272698 0039d316-1c4b-4281-b951-d872f2087c98
* Remove sanjeevr@ from src/jingle OWNERSsergeyu@chromium.org2014-05-241-1/+0
| | | | | | | | sanjeevr@ hasn't been active on the project for long time. Review URL: https://codereview.chromium.org/299923003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272683 0039d316-1c4b-4281-b951-d872f2087c98
* Build remoting for PNaClsergeyu@chromium.org2014-05-191-0/+5
| | | | | | | | | BUG=276739 R=jamiewalch@chromium.org, rsleevi@chromium.org Review URL: https://codereview.chromium.org/234023003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271351 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 271343 "Build remoting for PNaCl"sergeyu@chromium.org2014-05-191-5/+0
| | | | | | | | | | | | | | | > Build remoting for PNaCl > > BUG=276739 > R=jamiewalch@chromium.org, rsleevi@chromium.org > > Review URL: https://codereview.chromium.org/234023003 TBR=sergeyu@chromium.org Review URL: https://codereview.chromium.org/285243003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271344 0039d316-1c4b-4281-b951-d872f2087c98
* Build remoting for PNaClsergeyu@chromium.org2014-05-191-0/+5
| | | | | | | | | BUG=276739 R=jamiewalch@chromium.org, rsleevi@chromium.org Review URL: https://codereview.chromium.org/234023003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271343 0039d316-1c4b-4281-b951-d872f2087c98
* Libjingle's dependent settings: Include path to chromium's trunk should be ↵mallinath@chromium.org2014-05-131-1/+1
| | | | | | | | | | | | | | before webrtc when building libjingle (otherwise e.g. webrtc's base could be picked up when trunk/base is intended). Alphabetize dependencies (needed to insure libjingles expected include order). Original CL https://codereview.chromium.org/280853003 TBR=hellner@chromium.org,sergeyu@chromium.org Review URL: https://codereview.chromium.org/288613002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270196 0039d316-1c4b-4281-b951-d872f2087c98
* Move IsStringUTF8/ASCII to base namespacebrettw@chromium.org2014-05-071-1/+1
| | | | | | | | TBR=sky@chromium.org Review URL: https://codereview.chromium.org/270183002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268754 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 267030 "Build remoting for PNaCl"sergeyu@chromium.org2014-04-301-5/+0
| | | | | | | | | | | | | | | > Build remoting for PNaCl > > BUG=276739 > R=jamiewalch@chromium.org > > Review URL: https://codereview.chromium.org/234023003 TBR=sergeyu@chromium.org Review URL: https://codereview.chromium.org/254243002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267064 0039d316-1c4b-4281-b951-d872f2087c98
* Build remoting for PNaClsergeyu@chromium.org2014-04-301-0/+5
| | | | | | | | | BUG=276739 R=jamiewalch@chromium.org Review URL: https://codereview.chromium.org/234023003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267030 0039d316-1c4b-4281-b951-d872f2087c98
* Remove all uses of toolkit_use_gtk in the gyp files.erg@chromium.org2014-04-171-7/+0
| | | | | | | | | BUG=297026 R=ben@chromium.org, brettw@chromium.org Review URL: https://codereview.chromium.org/238633004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264609 0039d316-1c4b-4281-b951-d872f2087c98
* Sync PRESUBMIT files with latest CQ changesphajdan.jr@chromium.org2014-04-151-1/+1
| | | | | | | | | BUG=none R=maruel@chromium.org Review URL: https://codereview.chromium.org/237383002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263810 0039d316-1c4b-4281-b951-d872f2087c98
* make SetReceiveBufferSize and SetSendBufferSize return net error codes ↵jar@chromium.org2014-04-0910-28/+30
| | | | | | | | | | | | | | (instead of bools) Previously committed as https://src.chromium.org/viewvc/chrome?view=rev&revision=261966 but then reverted when it broke the Mac 10.6 build. TBR=sergeyu,yzshen,yurys,zea R=wtc BUG=355222 Review URL: https://codereview.chromium.org/227473008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262652 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 261966 "make SetReceiveBufferSize and SetSendBufferSize r..."jschuh@chromium.org2014-04-0510-30/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Appears to have broken the following gcm_unit_tests on Mac: DeviceCredentials AckOnLogin AckWhenLimitReachedWithHeartbeat ExpiredTTLOnRestart InitializeExisting SendMessageRMQAckOnReconnect SendMessageRMQOnRestart SendMessageRMQPartialAckOnReconnect SendMessageRMQWithStreamAck http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%284%29/builds/39860 > make SetReceiveBufferSize and SetSendBufferSize return net error codes (instead of bools) > > TBR=sergeyu,yzshen > R=wtc > BUG=355222 > > Review URL: https://codereview.chromium.org/217573002 TBR=jar@chromium.org Review URL: https://codereview.chromium.org/227083002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262002 0039d316-1c4b-4281-b951-d872f2087c98
* make SetReceiveBufferSize and SetSendBufferSize return net error codes ↵jar@chromium.org2014-04-0510-28/+30
| | | | | | | | | | | | (instead of bools) TBR=sergeyu,yzshen R=wtc BUG=355222 Review URL: https://codereview.chromium.org/217573002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261966 0039d316-1c4b-4281-b951-d872f2087c98
* Rename PrivateMode enum values:rch@chromium.org2014-04-011-1/+1
| | | | | | | | | | | | | | | | | | kPrivacyModeDisabled => PRIVACY_MODE_DISABLED kPrivacyModeEnabled => PRIVACY_MODE_ENABLED To match the chromium style guide: Though the Google C++ Style Guide now says to use kConstantNaming for enums, Chromium was written using MACRO_STYLE naming. Continue to use this style for consistency. R=mef@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260281 Review URL: https://codereview.chromium.org/215023002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260729 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Rename PrivateMode enum values: ↵rch@chromium.org2014-03-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/215023002/) Reason for revert: Broke build. http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29/builds/71042/steps/compile/logs/stdio#error1 Original issue's description: > Rename PrivateMode enum values: > > kPrivacyModeDisabled => PRIVACY_MODE_DISABLED > kPrivacyModeEnabled => PRIVACY_MODE_ENABLED > > To match the chromium style guide: > > Though the Google C++ Style Guide now says to use kConstantNaming for enums, > Chromium was written using MACRO_STYLE naming. Continue to use this style for consistency. > > R=mef@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260281 TBR=mef@chromium.org,zea@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/217053010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260296 0039d316-1c4b-4281-b951-d872f2087c98
* Rename PrivateMode enum values:rch@chromium.org2014-03-281-1/+1
| | | | | | | | | | | | | | | | kPrivacyModeDisabled => PRIVACY_MODE_DISABLED kPrivacyModeEnabled => PRIVACY_MODE_ENABLED To match the chromium style guide: Though the Google C++ Style Guide now says to use kConstantNaming for enums, Chromium was written using MACRO_STYLE naming. Continue to use this style for consistency. R=mef@chromium.org Review URL: https://codereview.chromium.org/215023002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260281 0039d316-1c4b-4281-b951-d872f2087c98
* Compile jingle_glue for PNaClsergeyu@chromium.org2014-03-253-19/+71
| | | | | | | | | | The new target jingle_glue_nacl compiles jingle/glue for PNaCl BUG=276739 Review URL: https://codereview.chromium.org/208333011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259138 0039d316-1c4b-4281-b951-d872f2087c98
* Remove akalin and szym from OWNERS files.mmenke@chromium.org2014-03-181-1/+0
| | | | | | | | | | They no longer work on Chrome. R=cbentzel@chromium.org, pauljensen@chromium.org, tim@chromium.org, zea@chromium.org Review URL: https://codereview.chromium.org/197853006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257639 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 257524 "Move IsStringASCII/UTF8 to base namespace."brettw@chromium.org2014-03-171-1/+1
| | | | | | | | | | | | | | | | > Move IsStringASCII/UTF8 to base namespace. > > Use StringPiece for IsStringUTF8. > > TBR=sky > > Review URL: https://codereview.chromium.org/196793010 TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/198163004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257533 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-12-26 14:43:58 +0000