summaryrefslogtreecommitdiffstats
path: root/jingle
Commit message (Collapse)AuthorAgeFilesLines
* Migrate content/*/p2p/* code to net::IPAddress.martijn2016-03-255-17/+17
| | | | | | | | BUG=496258 Review URL: https://codereview.chromium.org/1833523002 Cr-Commit-Position: refs/heads/master@{#383287}
* net: remove UsingTCPFastOpen() method from StreamSocket classtfarina2016-03-224-13/+0
| | | | | | | | | | | | | | | Commit c4699f6 ("net: add IsUsingTCPFastOpen() method to SequencedSocketData test class") removed the usage of UsingTCPFastOpen(), so now it can be removed safely. BUG=488598 TEST=net_unittests R=mmenke@chromium.org TBR=dgozman@chromium.org,sergeyu@chromium.org Review URL: https://codereview.chromium.org/1821633003 Cr-Commit-Position: refs/heads/master@{#382604}
* Remove NetworkDelegate pointer from HttpNetworkSession.mmenke2016-03-181-1/+0
| | | | | | | | | | | | | Nothing is currently using it, and currently HttpNetworkSessions can be shared by URLRequestContexts with different NetworkDelegates, so best to remove the field. TBR=zea@chromium.org, mkwst@chromium.org BUG=none Review URL: https://codereview.chromium.org/1811283004 Cr-Commit-Position: refs/heads/master@{#382031}
* Bypass the DataReductionProxy for all POST requestsryansturm2016-03-031-1/+3
| | | | | | | | | | POST requests are non-dempotent, so clients using the Data Reduction Proxy (DRP) can often end up at an error page due to the fact that if the DRP has any problems connecting to the origin, DRP and the client will not be safely able to determine if the post successfully made it to the server. The impact of this change on data compression should be very limited, and it will improve the client's experience. BUG=581750 Review URL: https://codereview.chromium.org/1684123004 Cr-Commit-Position: refs/heads/master@{#379137}
* jingle: Add out-of-line copy ctors for complex classes.vmpstr2016-02-266-0/+9
| | | | | | | | | | | | | This patch adds out of line copy constructors for classes that our clang-plugin considers heavy. This is an effort to enable copy constructor checks by default. BUG=436357 R=zea@chromium.org, dcheng@chromium.org, thakis@chromium.org Review URL: https://codereview.chromium.org/1729823003 Cr-Commit-Position: refs/heads/master@{#377992}
* net: move IsLocalhost() function into url_util.htfarina2016-02-233-3/+0
| | | | | | | | | | | | | | This patch moves the last function in net_util.h into url_util.h. We are moving it there because it also operates on a URL part (host). BUG=488531 TEST=net_unittests --gtest_filter=UrlUtilTest.IsLocalhost R=eroman@chromium.org TBR=darin@chromium.org Review URL: https://codereview.chromium.org/1726693002 Cr-Commit-Position: refs/heads/master@{#377115}
* Replace --use-spdy by --disable-http2.bnc2016-02-091-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | Introduce --disable-http2 command line flag that does the exact same thing as the broken --use-spdy one: disable SPDY/3.1 and HTTP/2. This will be accurately named once SPDY/3.1 is deprecated. Remove broken --use-spdy command line flag, which only did one thing: disable SPDY/3.1 and HTTP/2. Also remove related IOThread::Globals and IOSChromeIOThread::Globals members. This makes some flags only used in tests, which are removed as follows: Remove |forced_spdy_exclusions| from HttpNetworkSession::Params and SpdySessionDependencies. Also remove HttpNetworkSession::HasSpdyExclusion(). Remove |initial_max_spdy_concurrent_streams| from HttpNetworkSession::Params and SpdySessionDependencies. Also remove SpdySessionPool constructor argument, member, and SpdySession constructor argument. BUG=547781 Review URL: https://codereview.chromium.org/1668433002 Cr-Commit-Position: refs/heads/master@{#374374}
* Set trusted SPDY proxy dynamically on per-profile basistbansal2016-02-041-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | Set trusted SPDY proxy on per-profile basis if the profile has DRP enabled, and if Chrome is part of the field trial. Prior to this CL, it was possible to set the trusted SPDY proxy only from command line switch. Setting it on per-profile ensures that it is set only if DRP is enabled (which is per-profile). Setting it dynamically ensures that if there is a change in DataReductionProxy config (e.g., the API tells Chrome to connect to a different DRP server), then the SPDY session to the different server has the trusted SPDY proxy set correctly to the new server. Prior to this CL, trusted SPDY proxy was set once at the time of Chrome start, and it was not possible to change it. Link to design doc: https://code.google.com/p/chromium/issues/detail?id=558682#c11 BUG=558682 Review URL: https://codereview.chromium.org/1547273003 Cr-Commit-Position: refs/heads/master@{#373442}
* Move gn _run target generation into test(). (RELAND)jbudorick2016-02-031-9/+0
| | | | | | | | | | | | | | This is a reland of https://codereview.chromium.org/1653003006/ Consolidating the _run targets into the test template should make them easier to maintain (and, eventually, remove). BUG=583694 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1662053002 Cr-Commit-Position: refs/heads/master@{#373385}
* Revert of Move gn _run target generation into test(). (patchset #1 id:1 of ↵dpranke2016-02-031-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1653003006/ ) Reason for revert: Broke angle_unittests_run, which doesn't follow the template: https://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Linux%20Builder/builds/53646/steps/compile/logs/stdio Original issue's description: > Move gn _run target generation into test(). > > TBR=brettw@chromium.org > BUG= > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/6b1b03783b81ea27bb521c02aa84b74f06d6f71a > Cr-Commit-Position: refs/heads/master@{#373232} TBR=phosek@chromium.org,brettw@chromium.org,jbudorick@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1664653003 Cr-Commit-Position: refs/heads/master@{#373257}
* Move gn _run target generation into test().jbudorick2016-02-031-9/+0
| | | | | | | | | | TBR=brettw@chromium.org BUG= CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1653003006 Cr-Commit-Position: refs/heads/master@{#373232}
* Use Boolean members to control HTTP/2 and SPDY/3.1.bnc2016-02-022-1/+3
| | | | | | | | | | | | | | | | Add Boolean members to IOThread::Globals and HttpNetworkSession::Params to toggle HTTP/2 and SPDY/3.1 support instead of a NextProtoVector. This way clients do not have to have a notion of NextProto, "next_proto.h" includes can be removed from lots of files, and NextProto helper functions can be removed. Also default values are easier to define. This CL intends to preserve behavior and default values. BUG=329681 Review URL: https://codereview.chromium.org/1651123002 Cr-Commit-Position: refs/heads/master@{#372951}
* Add Alternative Service field trial.bnc2016-01-291-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | Before this CL: * If "use_alternative_service" QUIC trial param was set, both same host and different host Alt-Svc headers were parsed and used. If this param was not set, no Alt-Svc headers were parsed, and in-memory entries (from Alternate-protocol headers or loaded from disk) were only used if they referred to the same host. After this CL: * AltSvc field trial controls whether Alt-Svc headers are parsed. * "enable_alternative_service_with_different_host" QUIC trial param control whether in-memory Alt-Svc entries with different host (parsed in current session or loaded from disk) are used. Default values are not changed by this CL. This CL allows testing of same-host Alt-Svc header behavior. If no issues are encountered, parsing Alt-Svc headers and using same-host entries can be enabled by default, and Alternate-Protocols removed. BUG=581331 Review URL: https://codereview.chromium.org/1639913002 Cr-Commit-Position: refs/heads/master@{#372348}
* Global conversion of Pass()→std::move() on OS==linuxdcheng2015-12-287-19/+21
| | | | | | | | | | | | ❆(੭ु ◜◡‾)੭ु⁾☃❆ BUG=557422 R=avi@chromium.org TBR=jam@chromium.org Review URL: https://codereview.chromium.org/1550693002 Cr-Commit-Position: refs/heads/master@{#366956}
* Switch to standard integer types in jingle/.avi2015-12-2241-94/+149
| | | | | | | | | BUG=138542 TBR=zea@chromium.org Review URL: https://codereview.chromium.org/1544473003 Cr-Commit-Position: refs/heads/master@{#366518}
* Remove kuint16max.avi2015-12-011-4/+6
| | | | | | | | | | | BUG=138542 Committed: https://crrev.com/0d94fda8c494d7a6c27d065d782f42e99d834f46 Cr-Commit-Position: refs/heads/master@{#362431} Review URL: https://codereview.chromium.org/1475803002 Cr-Commit-Position: refs/heads/master@{#362472}
* Revert of Remove kuint16max. (patchset #7 id:120001 of ↵avi2015-12-011-6/+4
| | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1475803002/ ) Reason for revert: missed one :( Original issue's description: > Remove kuint16max. > > BUG=138542 > > Committed: https://crrev.com/0d94fda8c494d7a6c27d065d782f42e99d834f46 > Cr-Commit-Position: refs/heads/master@{#362431} TBR=treib@chromium.org,mark@chromium.org,sergeyu@chromium.org,bartfab@chromium.org,rsleevi@chromium.org,sky@chromium.org,cpu@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=138542 Review URL: https://codereview.chromium.org/1485853003 Cr-Commit-Position: refs/heads/master@{#362444}
* Remove kuint16max.avi2015-12-011-4/+6
| | | | | | | | BUG=138542 Review URL: https://codereview.chromium.org/1475803002 Cr-Commit-Position: refs/heads/master@{#362431}
* Run gn --format over all .gn filesagrieve2015-11-201-1/+1
| | | | | | | | | | | | | | | | The recent formatter alphebetizing change is causing a lot of noise in code reviews. Figured it'd be worth a clean-up CL. Exact command I ran: find . -name "*.gn*" -exec gn format --in-place "{}" \; TBR=ddorwin@chromium.org BUG=554928 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1464873002 Cr-Commit-Position: refs/heads/master@{#360891}
* Properly handle IPv6 literals in CONNECT requestsrsleevi2015-11-121-1/+1
| | | | | | | | | | | | | | | When issuing a CONNECT, ensure that the Host header sent to the proxy sends the IPv6 literal in host-form (square brackets). Further, as the CONNECT details omit scheme data with respect to the proxy server's view of things, ensure that the port is included in the Host header as well (even for port 443). BUG=550011 Review URL: https://codereview.chromium.org/1413593011 Cr-Commit-Position: refs/heads/master@{#359438}
* Add support for default local address in IpcNetworkManagerguoweis2015-11-122-0/+22
| | | | | | | | | | | | | | | | One of the modes of ip handling policy is to allow the associated default local address to be exposed along with the public interface. This requires Connect() to a public server (using the same ones from WebRTC) and GetLocalAddress() from a UDP socket. (Similar to https://code.google.com/p/chromium/codesearch#chromium/src/net/dns/host_resolver_impl.cc&rcl=1446089237&l=195) This mode will also be in effect when permission check on mic/camera fails or not involved (like a data channel). Default local address is really a global property of a network configuration, instead of individual network. They are most likely changed when interface changes. (Yes, people with admin right could change the routing table which changes the default local interface without network configuration change but I consider it is rare and not a supported scenario) This depends on the ongoing CL: https://codereview.webrtc.org/1411253008 BUG=webrtc:5061 Review URL: https://codereview.chromium.org/1405963021 Cr-Commit-Position: refs/heads/master@{#359360}
* Remove base::MessageLoop::{Quit,QuitClosure} functionski.stfu2015-10-231-4/+2
| | | | | | | | | | | | | This patch removes aliases for base::MessageLoop::QuitWhenIdle & base::MessageLoop::QuitWhenIdleClosure, and includes minor formatting changes made by using git cl-format. BUG=131220 TEST= R=danakj@chromium.org,brettw@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1390513002 Cr-Commit-Position: refs/heads/master@{#355763}
* Implement GetTotalReceivedBytes() for StreamSockettbansal2015-10-145-0/+17
| | | | | | | | | | | | | | | | | | GetTotalReceivedBytes() returns the number of bytes read from the network. Currently, only TCPClientSocket implements GetTotalReceivedBytes(). Tests are in ssl_client_socket_unittest.cc. Right now GetTotalReceivedBytes() is not plumbed to the higher layers. Once that's done, this will help us in precisely computing the network bytes used by a request. BUG=537754 Review URL: https://codereview.chromium.org/1343563002 Cr-Commit-Position: refs/heads/master@{#354092}
* Reland remove reference counting from HttpNetworkSession.mmenke2015-10-132-2/+2
| | | | | | | | | | | | | | | This was originally landed in https://crrev.com/468be2ff331c13b1a081d10a3c17e5366d26e577 and reverted in https://crrev.com/6b3af6e07d19ebb3f86df612ee5a08c8dc8f78ab, due to a new leak in a test causing bots to crash in a fun and exciting manner. BUG=515947 TBR=sgurun@chromium.org,davidben@chromium.org,droger@chromium.org,zea@chromium.org Review URL: https://codereview.chromium.org/1389743003 Cr-Commit-Position: refs/heads/master@{#353774}
* Update to use third_party/webrtc_overrides instead of ↵grunell2015-09-302-2/+3
| | | | | | | | | | | | | | third_party/webrtc/overrides. This is one step in moving the overrides files from WebRTC to Chromium. See bug comment #65 for all steps. Depends on https://codereview.chromium.org/1345873004/ and a WebRTC roll (specifically https://codereview.webrtc.org/1345313004/). BUG=468375 Review URL: https://codereview.chromium.org/1357913002 Cr-Commit-Position: refs/heads/master@{#351554}
* Use FRIEND_TEST_ALL_PREFIXES instead of FRIEND_TEST.thestig2015-09-251-7/+8
| | | | | | | | Also remove a custom FRIEND_TEST_ALL_PREFIXES #define from 6 years ago. Review URL: https://codereview.chromium.org/1370563002 Cr-Commit-Position: refs/heads/master@{#350719}
* base: Template methods on Timer classes instead of the classes themselves.danakj2015-09-241-1/+1
| | | | | | | | | | | | | | | | | | | The base class for OneShotTimer and DelayedTimer is templated but only the Start method needs to be (which has a TODO to make it go away entirely too). The DelayedTimer class is also templated but only its constructor needs to be, and the type can be inferred at the callsite, so less typing all around. R=thakis@chromium.org TBR=sky,brettw BUG=148832 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1355063004 Cr-Commit-Position: refs/heads/master@{#350496}
* Added some missing includes, removed one include and removed an undef.grunell2015-09-182-0/+2
| | | | | | | | | | | | | Found this when working on removing WebRTC's dependency on Chromium. These updates makes the WebRTC Chromium FYI bots green. BUG=468375 TBR=sergeyu@chromium.org,nick@chromium.org Review URL: https://codereview.chromium.org/1346883003 Cr-Commit-Position: refs/heads/master@{#349631}
* Compile remoting client plugin with GNsergeyu2015-09-141-0/+8
| | | | | | | | BUG=512899 Review URL: https://codereview.chromium.org/1312463005 Cr-Commit-Position: refs/heads/master@{#348752}
* Revert of Remove reference counting from HttpNetworkSession. (patchset #11 ↵mmenke2015-09-122-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:430001 of https://codereview.chromium.org/1298253002/ ) Reason for revert: Causing net tests to fail on a couple memory FYI bots with a stack that makes no sense, as there should be SpdySessionPool created until after SetUp has completed: [----------] 488 tests from NextProto/HttpNetworkTransactionTest [ RUN ] NextProto/HttpNetworkTransactionTest.Basic/0 [4832:3079:0911/175605:3116231085741:FATAL:weak_ptr.h(211)] Check failed: get() != NULL. 0 net_unittests 0x0000000100e4e4a3 base::debug::StackTrace::StackTrace() + 19 1 net_unittests 0x0000000100e4e4c9 base::debug::StackTrace::StackTrace() + 9 2 net_unittests 0x0000000100e66ad3 logging::LogMessage::~LogMessage() + 67 3 net_unittests 0x0000000100e662d9 logging::LogMessage::~LogMessage() + 9 4 net_unittests 0x00000001004a8d3a base::WeakPtr<net::HttpServerProperties>::operator->() const + 90 5 net_unittests 0x0000000101257267 net::SpdySessionPool::OnIPAddressChanged() + 439 6 net_unittests 0x00000001010422a7 _ZN4base20DispatchToMethodImplIN3net21NetworkChangeNotifier17IPAddressObserverEMS3_FvvEJEJEEEvPT_T0_RKNS_5TupleIJDpT1_EEENS_13IndexSequenceIJXspT2_EEEE + 23 7 net_unittests 0x0000000101042289 _ZN4base16DispatchToMethodIN3net21NetworkChangeNotifier17IPAddressObserverEMS3_FvvEJEEEvPT_T0_RKNS_5TupleIJDpT1_EEE + 9 8 net_unittests 0x00000001010420ea _ZNK4base8internal13UnboundMethodIN3net21NetworkChangeNotifier17IPAddressObserverEMS4_FvvENS_5TupleIJEEEE3RunEPS4_ + 26 9 net_unittests 0x0000000101041b3b _ZN4base22ObserverListThreadSafeIN3net21NetworkChangeNotifier17IPAddressObserverEE13NotifyWrapperIMS3_FvvENS_5TupleIJEEEEEvPNS4_19ObserverListContextERKNS_8internal13UnboundMethodIS3_T_T0_EE + 203 10 net_unittests 0x0000000101041fb5 _ZN4base8internal15RunnableAdapterIMNS_22ObserverListThreadSafeIN3net21NetworkChangeNotifier17IPAddressObserverEEEFvPNS6_19ObserverListContextERKNS0_13UnboundMethodIS5_MS5_FvvENS_5TupleIJEEEEEEE3RunEPS6_RKS8_SG_ + 69 11 net_unittests 0x0000000101041efb _ZN4base8internal12InvokeHelperILb0EvNS0_15RunnableAdapterIMNS_22ObserverListThreadSafeIN3net21NetworkChangeNotifier17IPAddressObserverEEEFvPNS7_19ObserverListContextERKNS0_13UnboundMethodIS6_MS6_FvvENS_5TupleIJEEEEEEEENS0_8TypeListIJRKPS7_RKS9_SH_EEEE8MakeItSoESK_SO_SQ_SH_ + 75 12 net_unittests 0x0000000101041e99 _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0ELm1ELm2EEEENS0_9BindStateINS0_15RunnableAdapterIMNS_22ObserverListThreadSafeIN3net21NetworkChangeNotifier17IPAddressObserverEEEFvPNSA_19ObserverListContextERKNS0_13UnboundMethodIS9_MS9_FvvENS_5TupleIJEEEEEEEEFvPSA_SC_SK_ENS0_8TypeListIJSO_SC_SI_EEEEENSQ_IJNS0_12UnwrapTraitsISO_EENST_ISC_EENST_ISI_EEEEENS0_12InvokeHelperILb0EvSN_NSQ_IJRKSO_RKSC_SK_EEEEEFvvEE3RunEPNS0_13BindStateBaseE + 105 13 net_unittests 0x00000001000d31b4 base::Callback<void ()()>::Run() const + 20 14 net_unittests 0x0000000100e4eea5 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask const&) + 165 15 net_unittests 0x0000000100e751fa base::MessageLoop::RunTask(base::PendingTask const&) + 282 16 net_unittests 0x0000000100e7538c base::MessageLoop::DeferOrRunPendingTask(base::PendingTask const&) + 28 17 net_unittests 0x0000000100e75462 base::MessageLoop::DoWork() + 146 18 net_unittests 0x0000000100e3f42a base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) + 106 19 net_unittests 0x0000000100e74f5e base::MessageLoop::RunHandler() + 158 20 net_unittests 0x0000000100e953b3 base::RunLoop::Run() + 51 21 net_unittests 0x0000000100e954bd base::RunLoop::RunUntilIdle() + 13 22 net_unittests 0x0000000100e74711 base::MessageLoop::RunUntilIdle() + 113 23 net_unittests 0x00000001004ad776 net::HttpNetworkTransactionTest::SetUp() + 22 24 net_unittests 0x0000000100f2d837 void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) + 23 25 net_unittests 0x0000000100f278e9 void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) + 57 26 net_unittests 0x0000000100f20566 testing::Test::Run() + 70 27 net_unittests 0x0000000100f20ab3 testing::TestInfo::Run() + 163 28 net_unittests 0x0000000100f20e52 testing::TestCase::Run() + 178 29 net_unittests 0x0000000100f24733 testing::internal::UnitTestImpl::RunAllTests() + 499 30 net_unittests 0x0000000100f2e897 bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) + 23 31 net_unittests 0x0000000100f28619 bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) + 57 32 net_unittests 0x0000000100f24523 testing::UnitTest::Run() + 115 33 net_unittests 0x0000000101649281 RUN_ALL_TESTS() + 17 34 net_unittests 0x0000000101648852 base::TestSuite::Run() + 98 35 net_unittests 0x0000000100c9509c base::internal::RunnableAdapter<int (base::TestSuite::*)()>::Run(base::TestSuite*) + 28 36 net_unittests 0x0000000100c95049 _ZN4base8internal12InvokeHelperILb0EiNS0_15RunnableAdapterIMNS_9TestSuiteEFivEEENS0_8TypeListIJP12NetTestSuiteEEEE8MakeItSoES6_S9_ + 41 37 net_unittests 0x0000000100c9500e _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0EEEENS0_9BindStateINS0_15RunnableAdapterIMNS_9TestSuiteEFivEEEFiPS6_ENS0_8TypeListIJNS0_17UnretainedWrapperI12NetTestSuiteEEEEEEENSC_IJNS0_12UnwrapTraitsISF_EEEEENS0_12InvokeHelperILb0EiS9_NSC_IJPSE_EEEEEFivEE3RunEPNS0_13BindStateBaseE + 46 38 net_unittests 0x00000001010e4fb4 base::Callback<int ()()>::Run() const + 20 39 net_unittests 0x0000000101640c78 base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int ()()> const&, int, bool, base::Callback<void ()()> const&) + 264 40 net_unittests 0x0000000101640b53 base::LaunchUnitTests(int, char**, base::Callback<int ()()> const&) + 83 41 net_unittests 0x0000000100c94d6b main + 123 42 net_unittests 0x0000000100001674 start + 52 43 ??? 0x0000000000000005 0x0 + 5 Original issue's description: > Remove reference counting from HttpNetworkSession. > > This makes lifetime cleaner, and helps us avoid the case > where an HttpNetworkSession outlives the components it points > to. > > Also remove some weird uses a null NetLog in GCM. > > TBR=sgurun@chromium.org,davidben@chromium.org,droger@chromium.org > BUG=515947 > > Committed: https://crrev.com/468be2ff331c13b1a081d10a3c17e5366d26e577 > Cr-Commit-Position: refs/heads/master@{#348483} TBR=pauljensen@chromium.org,zea@chromium.org,sgurun@chromium.org,davidben@chromium.org,droger@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=515947 Review URL: https://codereview.chromium.org/1342613002 Cr-Commit-Position: refs/heads/master@{#348518}
* Remove reference counting from HttpNetworkSession.mmenke2015-09-112-2/+2
| | | | | | | | | | | | | | | This makes lifetime cleaner, and helps us avoid the case where an HttpNetworkSession outlives the components it points to. Also remove some weird uses a null NetLog in GCM. TBR=sgurun@chromium.org,davidben@chromium.org,droger@chromium.org BUG=515947 Review URL: https://codereview.chromium.org/1298253002 Cr-Commit-Position: refs/heads/master@{#348483}
* Fix sbox_validation_tests & Make isolate_driver.py include the executable itselfmaruel2015-09-091-1/+0
| | | | | | | | | | | | | | | | | | | | | | This is a redo of https://codereview.chromium.org/1245873002 c6649f2e014a24a909 with fix for Official build. Further reduce the boilerplate in .isolate files and is necessary to add debug symbols, to be done in a follow up. Slightly accelerate ninja file parsing by blacklisting more extensions. sbox_validation_tests wasn't run on Windows since https://codereview.chromium.org/1212003003/ (~2 months ago). Thankfully this CL uncovered this copy-paste error. TBR=jam@chromium.org BUG=98637 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1320793004 Cr-Commit-Position: refs/heads/master@{#347912}
* Revert of Fix sbox_validation_tests & Make isolate_driver.py include the ↵stgao2015-09-031-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | executable itself (patchset #3 id:90001 of https://codereview.chromium.org/1245873002/ ) Reason for revert: This CL seems to break compile http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/3900/. If the revert doesn't fix it, I will re-land this CL. Original issue's description: > Fix sbox_validation_tests & Make isolate_driver.py include the executable itself > > Further reduce the boilerplate in .isolate files and is necessary to add debug > symbols, to be done in a follow up. > > Slightly accelerate ninja file parsing by blacklisting more extensions. > > sbox_validation_tests wasn't run on Windows since > https://codereview.chromium.org/1212003003/ (~2 months ago). Thankfully this CL > uncovered this copy-paste error. > > TBR=jam@chromium.org > BUG=98637 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/c6649f2e014a24a9093140a06fcadcaf2a06513c > Cr-Commit-Position: refs/heads/master@{#347027} TBR=jam@chromium.org,maruel@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=98637 Review URL: https://codereview.chromium.org/1329783003 Cr-Commit-Position: refs/heads/master@{#347071}
* Fix sbox_validation_tests & Make isolate_driver.py include the executable itselfmaruel2015-09-021-1/+0
| | | | | | | | | | | | | | | | | | | Further reduce the boilerplate in .isolate files and is necessary to add debug symbols, to be done in a follow up. Slightly accelerate ninja file parsing by blacklisting more extensions. sbox_validation_tests wasn't run on Windows since https://codereview.chromium.org/1212003003/ (~2 months ago). Thankfully this CL uncovered this copy-paste error. TBR=jam@chromium.org BUG=98637 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1245873002 Cr-Commit-Position: refs/heads/master@{#347027}
* Sync more GN unit tests with GYP.brettw2015-08-211-1/+4
| | | | | | | | | | | | | | | This adds about 600 more tests. Tests added: invalidation, navigation interception, feedback, search, sync driver, enhanced bookmarks, search engines, sessions, data reduction proxy, favicon, constrained window, autofill, metrics, keyed service, bookmarks, suggestions, audio modem I renamed ui_zoom to "zoom" according to GN style. I tweaked some jingle public dependencies so the right include directories get forwarded along with the corresponding uses in the headers. Reland of http://crrev.com/1301743003 TBR=dpranke@chromium.org Review URL: https://codereview.chromium.org/1304163005 Cr-Commit-Position: refs/heads/master@{#344874}
* Revert of Sync more GN unit tests with GYP. (patchset #3 id:40001 of ↵nasko2015-08-211-4/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1301743003/ ) Reason for revert: This has broken the GN builds. Windows is failing compilation and Mac is failing generate_build_files. http://build.chromium.org/p/chromium.mac/builders/Mac%20GN/builds/15185/steps/generate_build_files/logs/stdio http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/5562/steps/compile/logs/stdio Original issue's description: > Sync more GN unit tests with GYP. > > This adds about 600 more tests. > > Tests added: invalidation, navigation interception, feedback, search, sync driver, enhanced bookmarks, search engines, sessions, data reduction proxy, favicon, constrained window, autofill, metrics, keyed service, bookmarks, suggestions, audio modem > > I renamed ui_zoom to "zoom" according to GN style. I tweaked some jingle public dependencies so the right include directories get forwarded along with the corresponding uses in the headers. > > BUG= > R=dpranke@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/a7cde4bd39dc814952d885e54eee33ffdac1a881 TBR=dpranke@chromium.org,thestig@chromium.org,msramek@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1306153002 Cr-Commit-Position: refs/heads/master@{#344760}
* Sync more GN unit tests with GYP.Brett Wilson2015-08-201-1/+4
| | | | | | | | | | | | | | | This adds about 600 more tests. Tests added: invalidation, navigation interception, feedback, search, sync driver, enhanced bookmarks, search engines, sessions, data reduction proxy, favicon, constrained window, autofill, metrics, keyed service, bookmarks, suggestions, audio modem I renamed ui_zoom to "zoom" according to GN style. I tweaked some jingle public dependencies so the right include directories get forwarded along with the corresponding uses in the headers. BUG= R=dpranke@chromium.org Review URL: https://codereview.chromium.org/1301743003 . Cr-Commit-Position: refs/heads/master@{#344577}
* s/use_alternate_protocols/use_alternative_services/gbnc2015-08-191-2/+2
| | | | | | | | | | | | | | Rename HttpNetworkSession::Params::use_alternate_protocols, SpdySessionDependencies::use_alternate_protocols, and IOThread::Globals::use_alternate_protocols to use_alternative_services. Also reformat some test-level comments, and remove some obsolete comments. BUG=392575 Review URL: https://codereview.chromium.org/1268313004 Cr-Commit-Position: refs/heads/master@{#344284}
* Remove remaining legacy SplitString calls.brettw2015-08-121-2/+2
| | | | | | | | TBR=zelidrag@chromium.org (chromeos) Review URL: https://codereview.chromium.org/1284833004 Cr-Commit-Position: refs/heads/master@{#342983}
* Add yet more GN isolates ...dpranke2015-07-311-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This should be almost everything left that is currently running on the Linux GN bot. - events_unittests - extensions_browsertests - extensions_unittests - gcm_unit_tests - gfx_unittests - gpu_unittests - jingle_unittests - media_unittests - mojo_common_unittests - mojo_public_bindings_unittests - mojo_public_environment_unittests - nacl_loader_unittests - net_unittests - printing_unittests - remoting_unittests - sql_unittests (isolate existed, just swarmed) - sync_integration_tests - sync_unit_tests - unit_tests There are still more test steps that need isolates that are not run on the GN bot, most notably browser_tests and interactive_ui_tests (which is partially done in this CL but doesn't quite work right). I'll get to those in upcoming CLs. R=brettw@chromium.org BUG=504079 CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel Review URL: https://codereview.chromium.org/1258753002 Cr-Commit-Position: refs/heads/master@{#341392}
* Move remoting-specific adapters from jingle/glue to remoting/protocolsergeyu2015-07-069-1579/+0
| | | | | | | | | | | | | PseudoTcpAdapter and ChannelSocketAdapter are used only in remoting, so remoting/protocol is a better place for them. This change also includes two very minor cleanups in the moved code: 1. scoped_ptr<> is used to pass socket ownership in PseudoTcpAdapter 2. base::ThreadCheker is now used to check threads in ChannelSocketAdapter instead of base::MessageLoop::current(). Review URL: https://codereview.chromium.org/1177983009 Cr-Commit-Position: refs/heads/master@{#337432}
* Convert jingle_unittests to run exclusively on Swarmingmaruel2015-06-302-0/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 0 configs already ran on Swarming 29 used to run locally and were converted: - chromium.chromiumos.json: Linux ChromiumOS Ozone Tests (1) - chromium.chromiumos.json: Linux ChromiumOS Tests (1) - chromium.chromiumos.json: Linux ChromiumOS Tests (dbg)(1) - chromium.fyi.json: CrWinAsan tester - chromium.fyi.json: CrWinAsan(dll) tester - chromium.fyi.json: Linux Trusty - chromium.fyi.json: Linux Trusty (dbg) - chromium.linux.json: Cast Linux - chromium.linux.json: Linux Tests - chromium.linux.json: Linux Tests (dbg)(1) - chromium.linux.json: Linux Tests (dbg)(1)(32) - chromium.mac.json: Mac10.10 Tests - chromium.mac.json: Mac10.6 Tests - chromium.mac.json: Mac10.8 Tests - chromium.mac.json: Mac10.9 Tests - chromium.mac.json: Mac10.9 Tests (dbg) - chromium.memory.fyi.json: Linux ChromeOS MSan Tests - chromium.memory.fyi.json: Linux MSan Tests - chromium.memory.fyi.json: Linux TSan Tests - chromium.memory.json: Linux ASan LSan Tests (1) - chromium.memory.json: Linux Chromium OS ASan LSan Tests (1) - chromium.memory.json: Mac ASan 64 Tests (1) - chromium.webkit.json: Linux ChromiumOS Tests (1) - chromium.webkit.json: Linux ChromiumOS Tests (dbg)(1) - chromium.win.json: Vista Tests (1) - chromium.win.json: Win 7 Tests x64 (1) - chromium.win.json: Win7 Tests (1) - chromium.win.json: Win7 Tests (dbg)(1) - chromium.win.json: XP Tests (1) Ran: ./manage.py --convert jingle_unittests R=sergeyu@chromium.org,dpranke@chromium.org TBR= BUG=98637 Review URL: https://codereview.chromium.org/1221843002 Cr-Commit-Position: refs/heads/master@{#336858}
* Migrate callers of message_loop_proxy() to task_runner()skyostil2015-06-173-3/+3
| | | | | | | | | | | | | Migrate callers of {MessageLoop,Thread}::message_loop_proxy() to {MessageLoop,Thread}::task_runner(). Since the types at the call sites have already been updated, this is just a bulk rename. BUG=465354 TBR=armansito@chromium.org Review URL: https://codereview.chromium.org/1179163002 Cr-Commit-Position: refs/heads/master@{#334840}
* Replace more ObserverList with base::ObserverList.brettw2015-06-033-3/+3
| | | | | | | | | | | | This is everything but the chrome directory CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=zelidrag@chromium.org (chromeos) TBR=keybuk@chromium.org (device/bluetooth) Review URL: https://codereview.chromium.org/1162943002 Cr-Commit-Position: refs/heads/master@{#332626}
* [jingle] Replace MessageLoopProxy usage with ThreadTaskRunnerHandleashlin.j2015-05-205-6/+8
| | | | | | | | | | | | | | | | | Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in jingle module. MessageLoopProxy is deprecated. This basically does a search and replace of: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). MessageLoopProxy -> SingleThreadTaskRunner BUG=391045 Review URL: https://codereview.chromium.org/1128793002 Cr-Commit-Position: refs/heads/master@{#330740}
* Convert JsonWriter::Write to taking a const ref for the in-paramestade2015-05-161-1/+1
| | | | | | | | | | | | Clearer API; flushes out a lot of unnecessary heap allocations. depends on https://codereview.chromium.org/1129083003/ BUG=none Review URL: https://codereview.chromium.org/1131113004 Cr-Commit-Position: refs/heads/master@{#330255}
* Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProviderrch2015-05-151-0/+8
| | | | | | | | | | | | | | | | | | | | so that all provider subclasses can have their state verified. Committed: https://crrev.com/bce10d97d6fc5233071427cf622aaad7abde9e19 Cr-Commit-Position: refs/heads/master@{#328154} Committed: https://crrev.com/269875cf0d23881a7ad119bae730ff54fdd4dd0b Cr-Commit-Position: refs/heads/master@{#328351} Committed: https://crrev.com/d833a674a5e4f3b4e47f229b3d5411a8d509c2c0 Cr-Commit-Position: refs/heads/master@{#328909} Committed: https://crrev.com/1d6f67fe72b4a9ae94fcb0a6e051d803a180bde1 Cr-Commit-Position: refs/heads/master@{#329003} Review URL: https://codereview.chromium.org/1114383003 Cr-Commit-Position: refs/heads/master@{#330139}
* Collect all ConnectionAttempts from both sockets in TransportConnectJob.ttuttle2015-05-157-0/+31
| | | | | | | | | | | | | | | | | Before, the TransportConnectJob simply inferred that, if the main socket failed to connect, the address it was using was the last address in the list. With this change, the TCPClientSocket actually tracks all of the connection attempts made (as it tries each address in the list), and the TransportConnectJob copies the attempts from both the main and fallback sockets and records all of them in the ClientSocketHandle in GetAdditionalErrorState. BUG=480565 TBR=jam Review URL: https://codereview.chromium.org/1096203006 Cr-Commit-Position: refs/heads/master@{#330012}
* Roll WebRTC 9187:9189tommi2015-05-141-7/+6
| | | | | | | | | | | WebRTC 9187:9189 Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/65d8695..872cf25 TBR=sergeyu@chromium.org Review URL: https://codereview.chromium.org/1136483003 Cr-Commit-Position: refs/heads/master@{#329839}
* Revert of Add AllReadDataConsumed and AllWriteDataConsumed methods to ↵rch2015-05-081-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | SocketDataProvider (patchset #6 id:100001 of https://codereview.chromium.org/1114383003/) Reason for revert: Even adding methods which are not called breaks this bot. How in the hell is this possible? http://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/builds/26579 http://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/builds/26579/steps/net_unittests%20%28iPhone%205%20iOS%208.1%29/logs/stdio Original issue's description: > Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider > so that all provider subclasses can have their state verified. > > Committed: https://crrev.com/bce10d97d6fc5233071427cf622aaad7abde9e19 > Cr-Commit-Position: refs/heads/master@{#328154} > > Committed: https://crrev.com/269875cf0d23881a7ad119bae730ff54fdd4dd0b > Cr-Commit-Position: refs/heads/master@{#328351} > > Committed: https://crrev.com/d833a674a5e4f3b4e47f229b3d5411a8d509c2c0 > Cr-Commit-Position: refs/heads/master@{#328909} > > Committed: https://crrev.com/1d6f67fe72b4a9ae94fcb0a6e051d803a180bde1 > Cr-Commit-Position: refs/heads/master@{#329003} TBR=rtenneti@chromium.org,sergeyu@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1126113003 Cr-Commit-Position: refs/heads/master@{#329015}
generated by cgit v1.1 at 2024-05-03 13:39:01 +0000