| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
| |
incoming message.
BUG=None
Review URL: https://codereview.chromium.org/1802443002
Cr-Commit-Position: refs/heads/master@{#381100}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1791663002
Cr-Commit-Position: refs/heads/master@{#381099}
|
|
|
|
|
|
|
|
|
|
| |
The generator now supports a "--for_blink" flag. When it is specified, the generator will map mojo string to WTF::String.
BUG=583738
Review URL: https://codereview.chromium.org/1751563002
Cr-Commit-Position: refs/heads/master@{#381091}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sometimes it's desirable to fuse two pipes together. This is
particularly useful when a service provides some kind of interface
pipe later than its consumers would like to have such a pipe
available. Rather than require the service to be rewritten to
accommodate such cases, a consumer could create its own
disconnected pipe and fuse it lazily with a service endpoint.
BUG=591742
Review URL: https://codereview.chromium.org/1785843002
Cr-Commit-Position: refs/heads/master@{#380964}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NodeController::AcceptIncomingMessages().
std::queue is a std::deque by default, which always does an allocation
on construction in libstdc++. This makes it the primary cause of unnecessary
allocations in the EDK on Linux.
BUG=None
Review URL: https://codereview.chromium.org/1801463002
Cr-Commit-Position: refs/heads/master@{#380945}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, if a handle is closed while a Watcher is watching it, its
callback will notify it that the watch has been cancelled. However, if
the Watcher is explicitly cancelled after the handle is closed but
before the callback is called, it will attempt to call MojoCancelWatch()
on the closed handle and DCHECK that it succeeds. This changes the
DCHECK to also accept MOJO_ERROR_INVALID_ARGUMENT.
Review URL: https://codereview.chromium.org/1795193005
Cr-Commit-Position: refs/heads/master@{#380936}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moves chrome_manifest.json out of chrome/app/mash
and into content/browser. Changes Shell to use the
resolver when connecting to exe:chrome even when
embedded in the browser.
This brings embedded and external shell behavior
closer together as the manifest will now be used
for the browser app both in and out of mash.
As such, it fixes the fact that the browser cannot
currently connect to exe:chrome_renderer due to
recent changes around capability classes and client
process connections.
BUG=None
Review URL: https://codereview.chromium.org/1787083003
Cr-Commit-Position: refs/heads/master@{#380913}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes ShellClient::Initialize to expect a
response with an optional Connector request rather
than a ConnectorPtr being passed in with the call.
This allows clients to create their own Connector
pipe and lazily connect it to the shell thus
avoiding any practical need to wait for an
Initialize message.
Additionally:
- Client instances no longer die on the first
Connector pipe error: instead an Instance is
kept alive by the shell as long as either the
ShellClient pipe is connected OR any Connector
pipes are connected.
- ShellClientFactory endpoints are now strongly
typed instead of being raw message pipe
handles.
- Some uses of MessagePumpMojo near other changes
in this CL have been opportunistically removed.
BUG=591742
Review URL: https://codereview.chromium.org/1793793002
Cr-Commit-Position: refs/heads/master@{#380909}
|
|
|
|
|
|
|
|
|
|
| |
its own process.
BUG=
Review URL: https://codereview.chromium.org/1786683004
Cr-Commit-Position: refs/heads/master@{#380811}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds capability classes for:
- connecting as a user other than your own or root
- passing client process info
- passing another instance name
& a bunch of unit tests, & fixing the existing unit tests which failed with this enhanced enforcement.
R=sky@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1782903004
Cr-Commit-Position: refs/heads/master@{#380784}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Subtle: It's not OK to take the address of client_handle_ before
delegating to the other ctor impl, because that ctor will implicitly
reinitialize client_handle_'s memory.
Not sure if this new code is the behavior we actually want
InterfaceRegistry to have, but it seems reasonable and nobody's
using it just yet.
BUG=None
R=ben@chromium.org
Review URL: https://codereview.chromium.org/1783183002
Cr-Commit-Position: refs/heads/master@{#380652}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- instantiate the catalog shell client directly in the shell
- remove some obsolete comments
- move userid inheritance handling into the instance
R=sky@chromium.org
Committed: https://crrev.com/ecae0ae5f672a04579ab563462531889f6c0fab9
Cr-Commit-Position: refs/heads/master@{#380575}
Review URL: https://codereview.chromium.org/1785743002
Cr-Commit-Position: refs/heads/master@{#380645}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- pass the union of the interfaces in the "interfaces" list of the capability request and the interfaces implied by all classes present in the request
- pass the class names so they can be used for non-interface capability granting
R=sky@chromium.org
BUG=
Committed: https://crrev.com/191b85068b4db3a79ff4853edef91857e98c68ea
Cr-Commit-Position: refs/heads/master@{#380552}
Review URL: https://codereview.chromium.org/1781913003
Cr-Commit-Position: refs/heads/master@{#380644}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1781913003/ )
Reason for revert:
Broke mojo_shell_unittests on Linux Tests (https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/38823/steps/mojo_shell_unittests/logs/stdio)
[ RUN ] ConnectTest.CapabilityClasses
[0311/005040:WARNING:interface_registry.cc(53)] Connection CapabilityFilter prevented binding to interface: mojo::shell::test::mojom::BlockedInterface connection_name:mojo:connect_test_app remote_name:mojo:connect_unittests
[0311/005040:WARNING:interface_registry.cc(53)] Connection CapabilityFilter prevented binding to interface: mojo::shell::test::mojom::ConnectTestService connection_name:mojo:connect_test_class_app remote_name:mojo:connect_test_app
[0311/005040:WARNING:interface_registry.cc(53)] Connection CapabilityFilter prevented binding to interface: mojo::shell::test::mojom::ClassInterface connection_name:mojo:connect_test_class_app remote_name:mojo:connect_test_app
[ERROR:child_process_base.cc(212)] Connection error to the shell.
[ERROR:child_process_base.cc(212)] Connection error to the shell.
[37/37] ConnectTest.CapabilityClasses (TIMED OUT)
Original issue's description:
> Implement capability classes:
>
> - pass the union of the interfaces in the "interfaces" list of the capability request and the interfaces implied by all classes present in the request
> - pass the class names so they can be used for non-interface capability granting
>
> R=sky@chromium.org
> BUG=
>
> Committed: https://crrev.com/191b85068b4db3a79ff4853edef91857e98c68ea
> Cr-Commit-Position: refs/heads/master@{#380552}
TBR=sky@chromium.org,ben@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/1783303002
Cr-Commit-Position: refs/heads/master@{#380595}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:60001 of https://codereview.chromium.org/1785743002/ )
Reason for revert:
Based on https://codereview.chromium.org/1781913003 which broke mojo_shell_unittests on Linux.
Original issue's description:
> Remove loader for catalog & some other cleanup:
>
> - instantiate the catalog shell client directly in the shell
> - remove some obsolete comments
> - move userid inheritance handling into the instance
>
> R=sky@chromium.org
>
> Committed: https://crrev.com/ecae0ae5f672a04579ab563462531889f6c0fab9
> Cr-Commit-Position: refs/heads/master@{#380575}
TBR=sky@chromium.org,ben@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1783123006
Cr-Commit-Position: refs/heads/master@{#380594}
|
|
|
|
|
|
|
|
|
|
|
|
| |
- instantiate the catalog shell client directly in the shell
- remove some obsolete comments
- move userid inheritance handling into the instance
R=sky@chromium.org
Review URL: https://codereview.chromium.org/1785743002
Cr-Commit-Position: refs/heads/master@{#380575}
|
|
|
|
|
|
|
|
|
|
|
|
| |
internal code.
The one macro remaining in macros.h is only used by generated C++ code.
BUG=534695
Review URL: https://codereview.chromium.org/1784743003
Cr-Commit-Position: refs/heads/master@{#380556}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This ensures that dependents on mojo_shell.gyp targets (which all
expose shell mojom in their headers) also depend on shell bindings.
Fixes gyp build flake.
BUG=None
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/1779403002
Cr-Commit-Position: refs/heads/master@{#380554}
|
|
|
|
|
|
|
|
|
|
|
|
| |
- pass the union of the interfaces in the "interfaces" list of the capability request and the interfaces implied by all classes present in the request
- pass the class names so they can be used for non-interface capability granting
R=sky@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1781913003
Cr-Commit-Position: refs/heads/master@{#380552}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This test has been running on the mojo linux bot for a while now and
is stable:
https://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Linux/
BUG=577274
TEST=bot only change
R=dpranke@chromium.org, ben@chromium.org
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/1773343002
Cr-Commit-Position: refs/heads/master@{#380550}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
name. (patchset #2 id:20001 of https://codereview.chromium.org/1782543004/ )
Reason for revert:
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/33342
Original issue's description:
> Reland: Mojo C++ bindings: replace '::' with '.' in the interface name.
>
> Previously the |foo::Bar::Name_| field was "foo::Bar". With this change it
> becomes "foo.Bar".
>
> Using C++-style namespace in the name doesn't makes too much sense because the
> name should remain the same across different languages.
>
> The original CL was https://codereview.chromium.org/1778793004/
>
> BUG=None
> TBR=ben@chromium.org
>
> Committed: https://crrev.com/a061a917ebc0d16fb67d2644d93bfdca7eec92d3
> Cr-Commit-Position: refs/heads/master@{#380459}
TBR=ben@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None
Review URL: https://codereview.chromium.org/1785803003
Cr-Commit-Position: refs/heads/master@{#380503}
|
|
|
|
|
|
|
|
| |
BUG=570102
Review URL: https://codereview.chromium.org/1784643002
Cr-Commit-Position: refs/heads/master@{#380472}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously the |foo::Bar::Name_| field was "foo::Bar". With this change it
becomes "foo.Bar".
Using C++-style namespace in the name doesn't makes too much sense because the
name should remain the same across different languages.
The original CL was https://codereview.chromium.org/1778793004/
BUG=None
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/1782543004
Cr-Commit-Position: refs/heads/master@{#380459}
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=sky@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1782983002
Cr-Commit-Position: refs/heads/master@{#380452}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This ChannelMojo to:
- take a ScopedMessagePipeHandle instead of a string token so an
in-process renderer can be passed the message pipe directly;
- send brokered attachments as mojo handles; and
- offer messages to AttachmentBroker.
This also fixes and re-enables ipc_channel_mojo_unittest.cc.
BUG=579813
Committed: https://crrev.com/013cfed7ecf91b0700bec7147631d4fbedb6b64e
Cr-Commit-Position: refs/heads/master@{#380294}
Review URL: https://codereview.chromium.org/1768903002
Cr-Commit-Position: refs/heads/master@{#380360}
|
|
|
|
|
|
|
|
| |
BUG=None
Review URL: https://codereview.chromium.org/1773403006
Cr-Commit-Position: refs/heads/master@{#380357}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Otherwise they aren't picked up as runtime dependencies and isolates
won't work.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: https://codereview.chromium.org/1783533003
Cr-Commit-Position: refs/heads/master@{#380347}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #3 id:40001 of https://codereview.chromium.org/1778793004/ )
Reason for revert:
I think this broke the harness-tests/mojo-helpers.html layout test:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=harness-tests%2Fmojo-helpers.html
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/61800
Original issue's description:
> Mojo C++ bindings: replace '::' with '.' in the interface name.
>
> Previously the |foo::Bar::Name_| field was "foo::Bar". With this change it
> becomes "foo.Bar".
>
> Using C++-style namespace in the name doesn't makes too much sense because the
> name should remain the same across different languages.
>
> BUG=None
>
> Committed: https://crrev.com/026e10b3842af957773aee40dc3736eecb7faa0c
> Cr-Commit-Position: refs/heads/master@{#380301}
TBR=ben@chromium.org,yzshen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None
Review URL: https://codereview.chromium.org/1771353009
Cr-Commit-Position: refs/heads/master@{#380328}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of https://codereview.chromium.org/1768903002/ )
Reason for revert:
This CL is causing failures in ipc_mojo_unittests.
See:
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/52715
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/26588
Original issue's description:
> Fix failing tests with ChannelMojo enabled.
>
> This ChannelMojo to:
> - take a ScopedMessagePipeHandle instead of a string token so an
> in-process renderer can be passed the message pipe directly;
> - send brokered attachments as mojo handles; and
> - offer messages to AttachmentBroker.
>
> This also fixes and re-enables ipc_channel_mojo_unittest.cc.
>
> BUG=579813
>
> Committed: https://crrev.com/013cfed7ecf91b0700bec7147631d4fbedb6b64e
> Cr-Commit-Position: refs/heads/master@{#380294}
TBR=rockot@chromium.org,tsepez@chromium.org,ben@chromium.org,sammc@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=579813
Review URL: https://codereview.chromium.org/1784773002
Cr-Commit-Position: refs/heads/master@{#380325}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously the |foo::Bar::Name_| field was "foo::Bar". With this change it
becomes "foo.Bar".
Using C++-style namespace in the name doesn't makes too much sense because the
name should remain the same across different languages.
BUG=None
Review URL: https://codereview.chromium.org/1778793004
Cr-Commit-Position: refs/heads/master@{#380301}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This ChannelMojo to:
- take a ScopedMessagePipeHandle instead of a string token so an
in-process renderer can be passed the message pipe directly;
- send brokered attachments as mojo handles; and
- offer messages to AttachmentBroker.
This also fixes and re-enables ipc_channel_mojo_unittest.cc.
BUG=579813
Review URL: https://codereview.chromium.org/1768903002
Cr-Commit-Position: refs/heads/master@{#380294}
|
|
|
|
|
|
|
|
|
|
|
| |
classes (yet unimplemented).
R=sky@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1775113003
Cr-Commit-Position: refs/heads/master@{#380285}
|
|
|
|
|
|
|
|
|
|
| |
This is a preparation of removing the mojo/public/cpp/utility folder.
BUG=570102
Review URL: https://codereview.chromium.org/1779993002
Cr-Commit-Position: refs/heads/master@{#380273}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL changes the behavior to:
- connection error handler doesn't reenter ongoing sync calls.
- connection error handler is delayed until all queued asynchronous
messages are processed.
BUG=577699
Review URL: https://codereview.chromium.org/1781573004
Cr-Commit-Position: refs/heads/master@{#380259}
|
|
|
|
|
|
|
|
|
|
|
| |
This CL fixes uninitialized pointerTypes for WebTouchPoint.
Also fixes a few missing pointerType=mouse.
BUG=557817
Review URL: https://codereview.chromium.org/1760183002
Cr-Commit-Position: refs/heads/master@{#380238}
|
|
|
|
|
|
|
|
|
|
|
| |
This reworks some shelltest boilerplate to be more easily
consumable and converts all mus apptests to shelltests.
BUG=592313
Review URL: https://codereview.chromium.org/1771393002
Cr-Commit-Position: refs/heads/master@{#380148}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Build flake:
https://build.chromium.org/p/chromium/builders/Linux/builds/72756/steps/compile/logs/stdio
If targets depend on //foo and include //foo/foo.h, and //foo depends on //bar and
//foo/foo.h includes //bar/bar.h, then //bar must be in //foo's public_deps. If
bar.h is a generated header, getting this wrong = build flake when building //foo's
dependent targets.
TBR=ben@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1777933002
Cr-Commit-Position: refs/heads/master@{#380146}
|
|
|
|
|
|
|
|
|
|
|
| |
- Decompose the catalog into various files.
TBR=sky@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1779683002
Cr-Commit-Position: refs/heads/master@{#380093}
|
|
|
|
|
|
|
|
| |
BUG=592183
Review URL: https://codereview.chromium.org/1777673003
Cr-Commit-Position: refs/heads/master@{#380092}
|
|
|
|
|
|
|
|
| |
BUG=None
Review URL: https://codereview.chromium.org/1775693002
Cr-Commit-Position: refs/heads/master@{#380091}
|
|
|
|
|
|
|
|
|
|
| |
TBR=sky@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1775243002
Cr-Commit-Position: refs/heads/master@{#380062}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows applications to start processes themselves and have the shell use them instead of starting its own.
Allows us to eliminate Shell::CreateInstance().
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Review URL: https://codereview.chromium.org/1776513003
Cr-Commit-Position: refs/heads/master@{#380030}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, if a variant Foo1 was generated for mojom interface Foo. Foo1::GenericInterface was defined as a typedef of the non-variant version Foo.
This required the non-variant version to be generated and depended on by all variants.
The purpose was to make different variants use the same [Associated]Interface{PtrInfo,Request} types.
In fact, this is not very useful in real-world use cases. It should be very rare that users need to deal with multiple variants of the same mojom interface in a single same app.
This change removes GenericInterface and makes [Associated]Interface{PtrInfo, Request} directly use Foo1 instead of Foo1::GenericInterface.
BUG=590329
Review URL: https://codereview.chromium.org/1775613003
Cr-Commit-Position: refs/heads/master@{#379970}
|
|
|
|
|
|
|
|
|
|
| |
from the associated manifest.
BUG=
Review URL: https://codereview.chromium.org/1775813002
Cr-Commit-Position: refs/heads/master@{#379853}
|
|
|
|
|
|
|
|
|
|
|
| |
We were uniquifying their URLs, but this breaks manifest loading. So use instance names instead.
This will allow us to move the capability filter spec for the renderers into a manifest.
BUG=
Review URL: https://codereview.chromium.org/1778443002
Cr-Commit-Position: refs/heads/master@{#379850}
|
|
|
|
|
|
|
|
|
| |
BUG=585942
R=ben@chromium.org
Review URL: https://codereview.chromium.org/1765243002 .
Cr-Commit-Position: refs/heads/master@{#379839}
|
|
|
|
|
|
|
|
|
|
|
| |
Reduce the number of cases in which the resolved_qualifier is used. It should only be used in lieu of the one provided via params when it differs from the default qualifier for the resolved name.
TBR=sky@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1775793002
Cr-Commit-Position: refs/heads/master@{#379834}
|
|
|
|
|
|
|
|
| |
BUG=None
Review URL: https://codereview.chromium.org/1776583002
Cr-Commit-Position: refs/heads/master@{#379804}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change adds explicit padding to dispatcher header structs
while enforcing that the structs remain 8-byte aligned.
The padding is zeroed when writing headers into a buffer.
BUG=585804
R=amistry@chromium.org
Review URL: https://codereview.chromium.org/1771273002
Cr-Commit-Position: refs/heads/master@{#379790}
|
|
|
|
|
|
|
|
| |
BUG=592883
Review URL: https://codereview.chromium.org/1768373003
Cr-Commit-Position: refs/heads/master@{#379789}
|