| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The service will now get time updates from sync's http bridge (with
time data from the sync server).
Original codereview by haitaol@chromium.org at
https://codereview.chromium.org/12211117/
BUG=177072
TBR=akalin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12833011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> With this CL we can catch OnResume, OnPause, OnDestroy and OnStop notifications in SimpleCache, so we save our index before we get killed.
>
> OnPause means the app lost focus (went to the background).
>
> The idea is that we can write the index file to disk on every OnPause, and while the app is in the background we can aggressively increase the frequency we write the index file to disk.
>
> BUG=233536
>
> Review URL: https://chromiumcodereview.appspot.com/14362009
BUG=235180
TBR=felipeg@chromium.org
Review URL: https://codereview.chromium.org/14081031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
QUIC: step 8, server certificate support.
Merge internal change: 44460951
Returning early from framer callbacks on error.
Merge internal change: 44428665
Rename QUIC_VERSION_NOT_SUPPORTED to QUIC_CRYPTO_VERSION_NOT_SUPPORTED.
Merge internal change: 44422561
QUIC: split the server config into its own file.
This change moves QuicCryptoServerConfig into a separate file so that Chromium
need only link it into tests.
Merge internal change: 44397707
QUIC: remove ifs around error_details
They were never needed and clutter up the code.
Merge internal change: 44275147
QUIC: add tests for 0-RTT handshaking using strike-register.
This change fixes a couple of issues and adds a test that performs a 0-RTT
handshake.
Merge internal change: 44272981
R=rch@chromium.org
Review URL: https://codereview.chromium.org/14411004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
notifications in SimpleCache, so we save our index before we get killed.
OnPause means the app lost focus (went to the background).
The idea is that we can write the index file to disk on every OnPause, and while the app is in the background we can aggressively increase the frequency we write the index file to disk.
BUG=233536
Review URL: https://chromiumcodereview.appspot.com/14362009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
SSL 3.0 fallback for Google properties can be enabled again with --enable-unrestricted-ssl3-fallback.
Delete the obsolete SSL 3.0 fallback on TLS decompression failure.
BUG=230171
Review URL: https://chromiumcodereview.appspot.com/14125003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL focuses on cookie parser, CanonicalCookie, and making callers pass PRIORITY_DEFAULT where applicable.
What's NOT included in this CL:
- TODO(rogerm): Persistence in SQL database.
- TODO(huangs): Using cookie priority to affect cookie eviction.
- TODO(huangs): Make priorities available for extension API (right now default value is used to set).
- TODO(lower priority): Cookie viewer update.
- TODO(lower priority): WebCookie update in webkit/glue.
BUG=232693
Review URL: https://codereview.chromium.org/14113014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=157187
TEST=net_unittests --gtest_filter="FlashCacheTest.*" --gtest_repeat=10 --shuffle
Review URL: https://chromiumcodereview.appspot.com/14265009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
QUIC crypto: move config objects.
Currently the client and server configs are setup and torn-down for each
connection. Since they are supposed to be per-client and per-server objects,
this change makes them parameters that are passed into the connection
Merge internal change: 44269387
QUIC crypto steps 6 and 7: per-server strike register.
This change adds a per-server strike-register that allows the server to
complete 0-RTT connections if the client has enough information cached.
Due to the fact that the per-server and per-client objects
(QuicCryptoServerConfig and QuicCryptoClientConfig) are currently setup and
torn down for each connection, there's no tests in this change for a 0-RTT
handshake because we can't do one yet. The next change will move these objects
into the right place so that 0-RTT handshakes can be tested.
This change also reminded me why I had a server nonce: without it the server
cannot terminate any connections if the strike-register fails. So the server
nonce is firmly back.
Merge internal change: 44228897
R=rch@chromium.org
Review URL: https://codereview.chromium.org/13976007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use SpdyBuffer for both SPDY reads and writes. A future
CL will add hooks to SpdyBuffer so that we keep track of
flow control windows properly.
Replace SpdyFrameProducer with SpdyBufferProducer.
Also introduce new SpdyReadQueue class for delegates
of SpdyStream to use.
BUG=176592
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194560
Review URL: https://codereview.chromium.org/13990005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> [SPDY] Replace SpdyIOBuffer with new SpdyBuffer class
>
> Use SpdyBuffer for both SPDY reads and writes. A future
> CL will add hooks to SpdyBuffer so that we keep track of
> flow control windows properly.
>
> Replace SpdyFrameProducer with SpdyBufferProducer.
>
> Also introduce new SpdyReadQueue class for delegates
> of SpdyStream to use.
>
> BUG=176592
>
> Review URL: https://codereview.chromium.org/13990005
TBR=akalin@chromium.org
Review URL: https://codereview.chromium.org/13996009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use SpdyBuffer for both SPDY reads and writes. A future
CL will add hooks to SpdyBuffer so that we keep track of
flow control windows properly.
Replace SpdyFrameProducer with SpdyBufferProducer.
Also introduce new SpdyReadQueue class for delegates
of SpdyStream to use.
BUG=176592
Review URL: https://codereview.chromium.org/13990005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added Unit test to close the socket during spdy_session's
read and verifying that getting new URLs from the same
network session don't result in a failure.
Modified mock socket code to close the connection if
mock_read closes the connection (because of ERR_CONNECTION_CLOSED error).
Implement greedy approach to read all the data and process
it from the ClientSocket until we block.
Implemented the greedy approach to improves the network
stack performance on the mobile.
spdy_session_test_util.* files have the common code between
SpdySessionSpd2Test and SpdySessionSpd3Test. Created this
file to reduce errors and to avoid duplicating of code.
Review URL: https://chromiumcodereview.appspot.com/11644088
The change adds a scoped_refptr to SpdySession in DoLoop
to clean up the state and to finish pending reads, in case
SpdyFramer receives GOAway and closes all streams.
DoReadComplete was holding the last reference before and
DoLoop was accessing the object after DoReadComplete deleted
the object at the end of the function.
Review URL: https://codereview.chromium.org/12212102
Added unit tests for use after free of SpdySession
and unit test to test yielding + async during Read.
A test that crashes when scoped_refptr to SpdySession
deleted from DoLoop.
Added the following test per rch@ to test interactions of
yielding + async during Read.
Do the following MockReads and verify all the data is
consumed and SpdySession has yielded during Read.
SYNCHRONOUS 8K
SYNCHRONOUS 8K
SYNCHRONOUS 8K
SYNCHRONOUS 2K
ASYNC 8K
SYNCHRONOUS 8K
SYNCHRONOUS 8K
SYNCHRONOUS 8K
SYNCHRONOUS 2K
Review URL: https://chromiumcodereview.appspot.com/12207122
Reverted URL: https://chromiumcodereview.appspot.com/13608003/
BUG=175574, 166958, 224701, 175069
R=rch@chromium.org, jar@chromium.org
TEST=network unit tests
Review URL: https://codereview.chromium.org/13834009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of the previously buggy way of writing uninitialized structs and ints into the file.
BUG=230772
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194347
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194387
Review URL: https://codereview.chromium.org/14263005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It broke linux compile
http://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chrome%20Linux&number=29552
> Refactor our SimpleIndex file format and serialization to use Pickle instead of the previously buggy way of writing uninitialized structs and ints into the file.
>
> BUG=230772
>
> Review URL: https://codereview.chromium.org/14263005
TBR=felipeg@chromium.org
Review URL: https://codereview.chromium.org/14295012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
of the previously buggy way of writing uninitialized structs and ints into the file.
BUG=230772
Review URL: https://codereview.chromium.org/14263005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Partial creates, malformed entries, etc... should just be removed from disk. They're not going to get better with age. This CL adds a nonstatic Doom() method to SimpleSynchronousEntry, called on failures.
R=rvargas@chromium.org,pasko@chromium.org,felipeg@chromium.org
BUG=173394
Review URL: https://codereview.chromium.org/13639008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added a build flag to link with the tracing backend, tests may use it without a
flag. Recording the actual event trace is TBD. Added a test that runs on both
BackendImpl and SimpleBackendImpl.
BUG=173384
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193652
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193958
Review URL: https://codereview.chromium.org/13731002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The XP bots are still red, and it's still whining about URL.DLL
> Lets try this again.
>
> Revert 193983 "Revert 193968 "Roll the DEPS for google-url.""
>
> > Revert 193968 "Roll the DEPS for google-url."
> >
> > > Roll the DEPS for google-url.
> > >
> > > And update all the references from build/temp_gyp/googleurl.gyp to url/url.gyp.
> > >
> > > This also changes googleurl.gyp to reference the files under url/, so that we
> > > don't break the Blink tree.
> > >
> > > BUG=229660
> > > R=brettw@chromium.org
> > > TBR=brettw@chromium.org
> > >
> > > Review URL: https://chromiumcodereview.appspot.com/14089011
> >
> > TBR=tfarina@chromium.org
> > Review URL: https://codereview.chromium.org/14028012
>
> TBR=michaeln@google.com
> Review URL: https://codereview.chromium.org/14109014
TBR=michaeln@google.com
Review URL: https://codereview.chromium.org/14263002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is in preparation for replacing the various IOBuffers used for reads/writes
with a single SpdyBuffer class.
Replace the priority queue of SpdyIOBufferProducers with a SpdyWriteQueue object,
which is an an array of FIFO queues binned by priority.
The priority queue was looking only at priority and so was not guaranteeing
FIFO behavior among producers with the same priority.
Remove the frame queue in SpdyStream and instead have it use the session's
write queue directly.
Remove unused fields from SpdyIOBuffer and clean it up.
Propagate and handle errors from SpdyCredentialBuilder::Build.
Rename SpdyIOBufferProducer to SpdyFrameProducer, have it return a SpdyFrame,
clean up its interface, and move the stream-activating logic out of it.
Replace uses of std::list with std::deque.
Steamline logic in SpdySession that deals with the write queue.
Convert some raw pointers to scoped_ptr<>.
Convert a use of Unretained() in SpdySession to use the weak pointer factory.
BUG=176582
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192975
Review URL: https://chromiumcodereview.appspot.com/13009012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 193983 "Revert 193968 "Roll the DEPS for google-url.""
> Revert 193968 "Roll the DEPS for google-url."
>
> > Roll the DEPS for google-url.
> >
> > And update all the references from build/temp_gyp/googleurl.gyp to url/url.gyp.
> >
> > This also changes googleurl.gyp to reference the files under url/, so that we
> > don't break the Blink tree.
> >
> > BUG=229660
> > R=brettw@chromium.org
> > TBR=brettw@chromium.org
> >
> > Review URL: https://chromiumcodereview.appspot.com/14089011
>
> TBR=tfarina@chromium.org
> Review URL: https://codereview.chromium.org/14028012
TBR=michaeln@google.com
Review URL: https://codereview.chromium.org/14109014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change still fails with uninits on the valgrind bots. Please get a
green valgrind try run before recommitting.
BUG=230454
> Cache Backend Proxy to intercept all cache events from the IO thread.
>
> Added a build flag to link with the tracing backend, tests may use it without a
> flag. Recording the actual event trace is TBD. Added a test that runs on both
> BackendImpl and SimpleBackendImpl.
>
> BUG=173384
>
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193652
>
> Review URL: https://chromiumcodereview.appspot.com/13731002
TBR=pasko@google.com
Review URL: https://codereview.chromium.org/14121013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Roll the DEPS for google-url.
>
> And update all the references from build/temp_gyp/googleurl.gyp to url/url.gyp.
>
> This also changes googleurl.gyp to reference the files under url/, so that we
> don't break the Blink tree.
>
> BUG=229660
> R=brettw@chromium.org
> TBR=brettw@chromium.org
>
> Review URL: https://chromiumcodereview.appspot.com/14089011
TBR=tfarina@chromium.org
Review URL: https://codereview.chromium.org/14028012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
And update all the references from build/temp_gyp/googleurl.gyp to url/url.gyp.
This also changes googleurl.gyp to reference the files under url/, so that we
don't break the Blink tree.
BUG=229660
R=brettw@chromium.org
TBR=brettw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/14089011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added a build flag to link with the tracing backend, tests may use it without a
flag. Recording the actual event trace is TBD. Added a test that runs on both
BackendImpl and SimpleBackendImpl.
BUG=173384
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193652
Review URL: https://chromiumcodereview.appspot.com/13731002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://chromiumcodereview.appspot.com/13800010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Memcheck bots found uninitialized reads in this code.
TBR=pasko@chromium.org
BUG=230454
> Cache Backend Proxy to intercept all cache events from the IO thread.
>
> Added a build flag to link with the tracing backend, tests may use it without a
> flag. Recording the actual event trace is TBD. Added a test that runs on both
> BackendImpl and SimpleBackendImpl.
>
> BUG=173384
>
>
> Review URL: https://chromiumcodereview.appspot.com/13731002
TBR=pasko@google.com
Review URL: https://codereview.chromium.org/13911004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added a build flag to link with the tracing backend, tests may use it without a
flag. Recording the actual event trace is TBD. Added a test that runs on both
BackendImpl and SimpleBackendImpl.
BUG=173384
Review URL: https://chromiumcodereview.appspot.com/13731002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Looks like this caused use after free on Chromium OS (amd64) ASAN bot.
BUG=230259
> [SPDY] Refactor SpdySession's write queue
>
> This is in preparation for replacing the various IOBuffers used for reads/writes
> with a single SpdyBuffer class.
>
> Replace the priority queue of SpdyIOBufferProducers with a SpdyWriteQueue object,
> which is an an array of FIFO queues binned by priority.
> The priority queue was looking only at priority and so was not guaranteeing
> FIFO behavior among producers with the same priority.
>
> Remove the frame queue in SpdyStream and instead have it use the session's
> write queue directly.
>
> Remove unused fields from SpdyIOBuffer and clean it up.
>
> Propagate and handle errors from SpdyCredentialBuilder::Build.
>
> Rename SpdyIOBufferProducer to SpdyFrameProducer, have it return a SpdyFrame,
> clean up its interface, and move the stream-activating logic out of it.
>
> Replace uses of std::list with std::deque.
>
> Steamline logic in SpdySession that deals with the write queue.
>
> Convert some raw pointers to scoped_ptr<>.
>
> BUG=176582
>
> Review URL: https://codereview.chromium.org/13009012
TBR=akalin@chromium.org
Review URL: https://codereview.chromium.org/13880004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/13660002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=sky
BUG=70818
Review URL: https://chromiumcodereview.appspot.com/13818025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=70818
Review URL: https://codereview.chromium.org/13812005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is in preparation for replacing the various IOBuffers used for reads/writes
with a single SpdyBuffer class.
Replace the priority queue of SpdyIOBufferProducers with a SpdyWriteQueue object,
which is an an array of FIFO queues binned by priority.
The priority queue was looking only at priority and so was not guaranteeing
FIFO behavior among producers with the same priority.
Remove the frame queue in SpdyStream and instead have it use the session's
write queue directly.
Remove unused fields from SpdyIOBuffer and clean it up.
Propagate and handle errors from SpdyCredentialBuilder::Build.
Rename SpdyIOBufferProducer to SpdyFrameProducer, have it return a SpdyFrame,
clean up its interface, and move the stream-activating logic out of it.
Replace uses of std::list with std::deque.
Steamline logic in SpdySession that deals with the write queue.
Convert some raw pointers to scoped_ptr<>.
BUG=176582
Review URL: https://codereview.chromium.org/13009012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=rch@chromium.org, jar@chromium.org
Review URL: https://codereview.chromium.org/13520010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This lands server change 44685956.
Review URL: https://codereview.chromium.org/13601029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=157187
TEST=net_unittests --gtest_filter="FlashCacheTest.*" --gtest_repeat=10 --shuffle
Review URL: https://chromiumcodereview.appspot.com/12847012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 181637 "SPDY - Small bug fix for user after free. Will ..."
Revert 182012 "SPDY - Added unit tests for use after free of ..."
> SPDY - implement greedy approach to read all the data and process it
> from the ClientSocket until we block.
>
> This is more of a first cut at the greedy approach to see if it
> improves the performance on the mobile.
>
> spdy_session_test_util.* files have the common code between
> SpdySessionSpd2Test and SpdySessionSpd3Test. Will move other common
> code in a separate CL. Created this file to reduce errors and
> to avoid duplicating of code.
>
> R=willchan
> BUG=166958
> TEST=network unittests
>
> Review URL: https://chromiumcodereview.appspot.com/11644088
> SPDY - Small bug fix for user after free. Will revert the
> change asap.
>
> The change adds a scoped_refptr to SpdySession in DoLoop
> to clean up the state and to finish pending reads, in case
> SpdyFramer receives GOAway and closes all streams.
>
> DoReadComplete was holding the last reference before and
> DoLoop was accessing the object after DoReadComplete deleted
> the object at the end of the function.
>
> R=willchan@chromium.org
> BUG=175069
> TEST=network unit tests
> Review URL: https://codereview.chromium.org/12212102
> SPDY - Added unit tests for use after free of SpdySession
> and unit test to test yielding + async during Read.
>
> A test that crashes when scoped_refptr to SpdySession deleted
> from DoLoop.
>
> Added the following test per rch to test interactions of
> yielding + async during Read.
>
> Do the following MockReads and verify all the data is consumed
> and SpdySession has yielded during Read.
> SYNCHRONOUS 8K
> SYNCHRONOUS 8K
> SYNCHRONOUS 8K
> SYNCHRONOUS 2K
> ASYNC 8K
> SYNCHRONOUS 8K
> SYNCHRONOUS 8K
> SYNCHRONOUS 8K
> SYNCHRONOUS 2K
>
> R=rch@chromium.org
> BUG=175574,166958
> TEST=net unit tests
>
> Review URL: https://chromiumcodereview.appspot.com/12207122
TBR=rtenneti@chromium.org, rch@chromium.org
Review URL: https://chromiumcodereview.appspot.com/13608003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is a follow-up to https://codereview.chromium.org/13006020/
BUG=70818
Review URL: https://codereview.chromium.org/13351006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We will need to choose the backend at runtime for A/B testing. This change is
the first step towards backend comparisons: it moves the logic of choosing among
cache backends to a single point (cache_creator.cc) and makes it logically
separate from BackendImpl. Next step would be to inject performance-analyzer
backend into this cache backend choice logic. The analyzer is going to be under
a compile-time flag.
With this change the Simple Cache Backend operation gets enabled when the
"SimpleCacheTrial" experiment is set.
Cache Initialization.
The Simple Cache Backend now shares the common initialization/cleanup code. So
it can delete inconsistent cache, cache of a different version etc
asynchronously. It is just a positive side-effect of moving the backend choice
to a single point.
The CacheCreator with almost no change.
To see the difference:
shell> out/Debug/chrome --enable-logging=stderr --v=1 \
--user-data-dir=/tmp/unique --use-simple-cache-backend=on \
http://url 2>&1 | grep "Simple Cache"
BUG=173390, 173384
TBR=maruel
Review URL: https://chromiumcodereview.appspot.com/12794003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Merge internal change: 44173744
Add default return to avoid crashing when we get an unknown
error code from the peer.
Merge internal change: 44160057
Fix incorrect DCHECK while serializing version negotiation
packet.
Merge internal change: 44156166
Reorder the addends in GetPacketHeaderSize to match the order
of the public header fields.
Merge internal change: 44153020
Changing retransmission and retransmittable data boolean flags
to enums.
Merge internal change: 44071662
Remove methods from QuicTime for converting to/from
microseconds and milliseconds since the epoch for QuicTime is
unspecified. (It wraps TimeTicks in Chromium).
Merge internal change: 44069965
Change InterArrival feedback message to traffic in delta since
the "start" of the connection instead of a delta since the epoch.
One step closer to being able to remove QuicTime::To/FromMicroseconds
since those methods don't "do the right thing".
Merge internal change: 44037996
Changing kForce into an enum.
Merge internal change: 44024887
Cleanups from landing P-256 key exchange in Chromium.
Merge internal change: 44023801
Fix for std::vector in QuicPacketPublicHeader's memory
corruption by memset.
Merge internal change: 44022862
Merging cleanup changes from chromium.
Merge internal change: 44009665
Plug in the new decrypter and encrypter after the new keys have
been derived.
This is a first cut, as some details on changing the encryption
keys still need to be worked out. Our interim solution is
permissive trial decryption, which allows the peer to encrypt
with the wrong key, either using the new key too early or using
the null key for too long. The latter will leak confidential
information, so we err on the side of using the new key too early.
WARNING: the interim solution protects against eavesdroppers, but
is vulberable to active attackers.
Merge internal change: 44006658
Start tracking server and client stream resets and export them
via varz.
Merge internal change: 43971847
Pull out RstStreamFrame error code from QuicErrorCode so that
they don't appear in the tracked ConnectionClose error map.
This will also help in tracking RstStream error codes separately.
Merge internal change: 43968620
Adding Client/Server logging to all LOGS/DLOGs Not bothering
with VLOGs/DVLOGS unless it's requested.
Merge internal change: 43948596
crypto: step 5.
This change implements source-address tokens at the server and has the client
echo them. Source address tokens are opaque (to the client) bytestrings that
prove ownership of an IP address. In order to prevent amplification attacks,
the server demands that the client have a valid source address token for the IP
address that it's claiming to come from and that the token is reasonably
recent.
Since we already have it implemented, this code uses AES-GCM to encrypt and
authenticate the tokens with a fixed, dummy secret (for now). In the future,
the secret will be derived from the primary, private key in the same way that
SessionTicket keys used to be.
The QuicEncrypter/Decrypter code was written to be quite specific to the task
of encrypting and decrypting packets and, as part of this, it exposed only 64
bits of the AEAD nonce.
Since all GFEs will share the same token secret, and they'll all create tokens
with random nonces, that runs an unacceptably high risk of an attacker
obtaining two tokens with the same nonce.
Thus this change also reworks the QuicEncrypter/Decrypter so that the full
nonce is exposed and thus we can use 96-bit nonces. That's still not completely
wonderful but, at 10Mpps an attacker would still take a year to obtain a pair
of nonces, so it's good enough for a while at least.
Merge internal change: 43893806
R=rch@chromium.org
Review URL: https://chromiumcodereview.appspot.com/13282004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/13004022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
local data.
BUG=147383
TEST=none
Review URL: https://chromiumcodereview.appspot.com/13000003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Performance gains are probably neglible, though it does
prevent locking.
Review URL: https://codereview.chromium.org/12209100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This introduces the following dependency of net/base on things outside:
net/base/openssl_client_key_store.cc:#include "net/cert/x509_certificate.h"
BUG=70818
Review URL: https://codereview.chromium.org/13006020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://chromiumcodereview.appspot.com/13120002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://chromiumcodereview.appspot.com/13047003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Porting tests in the next cl.
BUG=
Review URL: https://chromiumcodereview.appspot.com/12893018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=156058
Review URL: https://chromiumcodereview.appspot.com/12987011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This provider can return a list of additional certificates to trust when
a trust chain is being built to verify trust in a certain certificate.
This enables the chrome layer to pass in certificates from the ONC policy that
should be trusted only for the user session, without having to import them into
the user's NSS database.
BUG=216495
Review URL: https://chromiumcodereview.appspot.com/12553012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use the mock class during crypto handshake in
quic_network_transaction, quic_http_stream and quic_stream_factory
classes. Deleted sending of shlo and chlo messages from
the unit tests of these classes.
This code deletes the following methods from quic_test_utils.cc.
We will share the cryto testing code with the server.
CreateChloMessage
ConstructClientHelloPacket
CreateShloMessage
ConstructServerHelloPacket
R=rch
TEST=net unittests
Review URL: https://codereview.chromium.org/12729017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is in preparation for propagating priority changes from
ResourceScheduler all the way to HostResolver and ClientSocketPool.
Add some NetLog events and parameters for priority.
BUG=166689
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189829
Review URL: https://codereview.chromium.org/12701011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189894 0039d316-1c4b-4281-b951-d872f2087c98
|