summaryrefslogtreecommitdiffstats
path: root/net/url_request
Commit message (Collapse)AuthorAgeFilesLines
* Remove implicit conversions from scoped_refptr to T* in net/url_request/dcheng2014-08-277-16/+16
| | | | | | | | | | | This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Review URL: https://codereview.chromium.org/495093005 Cr-Commit-Position: refs/heads/master@{#292051}
* Rework UMAHistogramHelper and StatisticsDeltaReader into ↵mlerman@chromium.org2014-08-211-13/+7
| | | | | | | | | | | | | | | [Chrome]HistogramTester. Design Doc (Googlers Only): https://docs.google.com/a/google.com/document/d/1RUY0BcxBppdkwFP3T8qbQmQStBRFGsLmuR4WuIXhiCA/edit BUG=384011 TBR=timsteele@chromium.org Review URL: https://codereview.chromium.org/379283002 Cr-Commit-Position: refs/heads/master@{#291207} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291207 0039d316-1c4b-4281-b951-d872f2087c98
* Allow URLRequests from one context to have different NetworkDelegates.mmenke@chromium.org2014-08-2115-1537/+1372
| | | | | | | | | | | | | | | | | | | This is a prerequisite to allowing a URLRequestJob to transparently wrap a URLRequest, so AppCache can override the response for failing and redirected requests without the NetworkDelegate or URLRequest::Delegate being aware of the underlying request. Also consolidate the URLRequest constructors, and make most code create URLRequests through the URLRequestContext's CreateRequest function, rather than through its constructor. TBR=battre@chromium.org BUG=161547 Review URL: https://codereview.chromium.org/407093011 Cr-Commit-Position: refs/heads/master@{#291090} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291090 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 291007 "Set response headers for data URL."tyoshino@chromium.org2014-08-213-137/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | > Set response headers for data URL. > > Resources represented by a data URL will stay being considered to be > unique origin resource but are changed to allow cross origin access by > the Access-Control-Allow-Origin header. > > We take this approach mainly because we want scripts in an iframe with > a data URL specified to its src attribute to be executed as a script on > a unique origin resource, not on the parent frame. > > We can choose to treat "loading" of data URL specially as same origin > while execution as different origin. But such an approach complicates > security policy checking algorithm. > > Grammar checking code is added to ensure we emit a valid content-type. > > Blink side CL https://codereview.chromium.org/54173002/ will be landed > first to temporarily disable layout tests that will break, and then > this CL will be landed. > > BUG=308768 > > Review URL: https://codereview.chromium.org/294193002 TBR=tyoshino@chromium.org Review URL: https://codereview.chromium.org/497443002 Cr-Commit-Position: refs/heads/master@{#291015} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291015 0039d316-1c4b-4281-b951-d872f2087c98
* Set response headers for data URL.tyoshino@chromium.org2014-08-213-2/+137
| | | | | | | | | | | | | | | | | | | | | | | | | | | Resources represented by a data URL will stay being considered to be unique origin resource but are changed to allow cross origin access by the Access-Control-Allow-Origin header. We take this approach mainly because we want scripts in an iframe with a data URL specified to its src attribute to be executed as a script on a unique origin resource, not on the parent frame. We can choose to treat "loading" of data URL specially as same origin while execution as different origin. But such an approach complicates security policy checking algorithm. Grammar checking code is added to ensure we emit a valid content-type. Blink side CL https://codereview.chromium.org/54173002/ will be landed first to temporarily disable layout tests that will break, and then this CL will be landed. BUG=308768 Review URL: https://codereview.chromium.org/294193002 Cr-Commit-Position: refs/heads/master@{#291007} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291007 0039d316-1c4b-4281-b951-d872f2087c98
* Replace usages of MessageLoopProxy with SequencedTaskRunner in the disk cachersleevi@chromium.org2014-08-211-1/+1
| | | | | | | | | | | | | This replaces most places where a MessageLoopProxy is passed around in the disk cache to instead pass a SequencedTaskRunner. As a knock-on effect, users of the disk cache have also been updated. BUG=391045 Review URL: https://codereview.chromium.org/406753002 Cr-Commit-Position: refs/heads/master@{#290990} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290990 0039d316-1c4b-4281-b951-d872f2087c98
* Improve testing for SDCH.rdsmith@chromium.org2014-08-194-0/+64
| | | | | | | | | | | | | | | | | | Added some end-to-end browser tests, and added a bit of extra checking for the filter. The extra files for encoding dictionaries from sdch/open-vcdiff were added so that the tests could create an SDCH dictionary when run. IMO, this is more flexible for future tests and clearer to read and maintain than just hard-coding a dictionary inline in the tests. BUG=None R=mef@chromium.org Review URL: https://codereview.chromium.org/380003002 Cr-Commit-Position: refs/heads/master@{#290638} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290638 0039d316-1c4b-4281-b951-d872f2087c98
* Enable and fix CRLSet and remoting tests on non-Android OpenSSL.davidben@chromium.org2014-08-181-1/+1
| | | | | | | | | | | | We need CRLSets to work on Mac and the remoting tests can run now that SSLServerSocketOpenSSL is implemented. BUG=338885 Review URL: https://codereview.chromium.org/418173004 Cr-Commit-Position: refs/heads/master@{#290346} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290346 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb redirect info out of net, through content, and into child processes.davidben@chromium.org2014-08-1511-119/+285
| | | | | | | | | | | | | This saves the logic in PluginURLFetcher and WebURLLoader that has to replicate the method-munging, referrer-munging, and first-party-URL-munging logic that is already done in net/. BUG=384609 Review URL: https://codereview.chromium.org/398903002 Cr-Commit-Position: refs/heads/master@{#290005} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290005 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 289312 "Move StringToUpperASCII and LowerCaseEqualsASCII ..."brettw@chromium.org2014-08-132-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | > Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace > > Convert LowerCaseEqualsASCII to take StringPiece. In the current patch this is > generally a NOP but will allow me to delete the other 4 variants in a followup > (wanted to do that separately since that will require more review, since > callsites will be changed in nontrivial ways). > > In some cases, LowerCaseEqualsASCII is called with a WebString, which no > longer is implicitly converted. I added base::string16(...) around such > calls to force the right conversion. It happened in these files: > window_container_type.cc > savable_resources.cc > render_view_impl.cc > blink_ax_tree_source.cc > password_form_conversion_utils.cc > translate_helper.cc > chrome_render_view_observer.cc > dom_serializer_browsertest.cc > > R=jamesr@chromium.org > > Review URL: https://codereview.chromium.org/448143008 TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/474483002 Cr-Commit-Position: refs/heads/master@{#289320} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289320 0039d316-1c4b-4281-b951-d872f2087c98
* Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespacebrettw@chromium.org2014-08-132-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | Convert LowerCaseEqualsASCII to take StringPiece. In the current patch this is generally a NOP but will allow me to delete the other 4 variants in a followup (wanted to do that separately since that will require more review, since callsites will be changed in nontrivial ways). In some cases, LowerCaseEqualsASCII is called with a WebString, which no longer is implicitly converted. I added base::string16(...) around such calls to force the right conversion. It happened in these files: window_container_type.cc savable_resources.cc render_view_impl.cc blink_ax_tree_source.cc password_form_conversion_utils.cc translate_helper.cc chrome_render_view_observer.cc dom_serializer_browsertest.cc R=jamesr@chromium.org Review URL: https://codereview.chromium.org/448143008 Cr-Commit-Position: refs/heads/master@{#289312} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289312 0039d316-1c4b-4281-b951-d872f2087c98
* Export URLRequestContextBuilder::SchemeFactoryhans@chromium.org2014-08-121-1/+1
| | | | | | | | | | | | | | | | The inner class needs to be exported in case any uses in inline methods or vtable of the outer class causes it to potentially be referenced across a shared library boundary. On non-Windows, the visibility attribute is already inherited by nested classes, but on Windows, they must be marked explicitly. BUG=82385 Review URL: https://codereview.chromium.org/464563004 Cr-Commit-Position: refs/heads/master@{#289093} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289093 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete comment.ricea@chromium.org2014-08-071-2/+0
| | | | | | | | | | | | | | url_request_http_job.cc contains a TODO comment for WebSocket throttling. Since this was landed in https://codereview.chromium.org/240873003 the comment is no longer needed. Remove it. BUG=343107 TEST=net_unittests Review URL: https://codereview.chromium.org/445373002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288155 0039d316-1c4b-4281-b951-d872f2087c98
* Move StringToLowerASCII to base namespacebrettw@chromium.org2014-08-071-1/+1
| | | | | | | | TBR=sky Review URL: https://codereview.chromium.org/448853002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288085 0039d316-1c4b-4281-b951-d872f2087c98
* Add fake headers to URLRequestRedirectJobs.mmenke@chromium.org2014-08-063-26/+117
| | | | | | | | | | | Plugin logic expects redirects to have headers, and gets very confused when they're missing. BUG=345160 Review URL: https://codereview.chromium.org/422233006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287901 0039d316-1c4b-4281-b951-d872f2087c98
* Switched calculation of decode/holdback info to avoid confusion if the requestrdsmith@chromium.org2014-07-301-4/+5
| | | | | | | | | | | has gone away or the value was cached. BUG=None R=jar@chromium.org Review URL: https://codereview.chromium.org/413563003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286515 0039d316-1c4b-4281-b951-d872f2087c98
* Move the test data that's used by net_unittests to net\data to simplify the ↵jam@chromium.org2014-07-291-1/+1
| | | | | | | | | | | | | | isolate files. The background is that url_fetcher was moved from chrome to content to net, but its test data didn't move along. R=davidben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286024 Review URL: https://codereview.chromium.org/420313003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286094 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 286024 "Move the test data that's used by net_unittests t..."mpearson@chromium.org2014-07-291-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Likely cause of failure on tree: http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/32682 net_unittests net_unittests net_unittests 127 disabled 6 flaky failed 5 ( 4 mins, 19 secs ) stdio Basic LargeGet LargeGetToTempFile ServerUnavailable ServerUnavailablePropagateResponse e.g., [ RUN ] URLFetcherDownloadProgressTest.Basic HTTP server started on http://127.0.0.1:54345... sending server_data: {"host": "127.0.0.1", "port": 54345} (36 bytes) File not found animate1.gif full path:/mnt/data/b/build/slave/Linux_Tests__dbg__1_/build/src/chrome/test/data/animate1.gif localhost - - [28/Jul/2014 16:51:57] code 404, message Not Found ../../net/url_request/url_fetcher_impl_unittest.cc:601: Failure Expected: (total) >= (progress), actual: -1 vs 190 ../../net/url_request/url_fetcher_impl_unittest.cc:603: Failure Value of: total Actual: -1 Expected: expected_total_ Which is: 19021 ../../net/url_request/url_fetcher_impl_unittest.cc:170: Failure Value of: source->GetResponseCode() Actual: 404 Expected: 200 [ FAILED ] URLFetcherDownloadProgressTest.Basic (205 ms) > Move the test data that's used by net_unittests to net\data to simplify the isolate files. > > The background is that url_fetcher was moved from chrome to content to net, but its test data didn't move along. > > R=davidben@chromium.org > > Review URL: https://codereview.chromium.org/420313003 TBR=jam@chromium.org Review URL: https://codereview.chromium.org/422063008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286036 0039d316-1c4b-4281-b951-d872f2087c98
* Move the test data that's used by net_unittests to net\data to simplify the ↵jam@chromium.org2014-07-281-1/+1
| | | | | | | | | | | | isolate files. The background is that url_fetcher was moved from chrome to content to net, but its test data didn't move along. R=davidben@chromium.org Review URL: https://codereview.chromium.org/420313003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286024 0039d316-1c4b-4281-b951-d872f2087c98
* Implement TLS_FALLBACK_SCSV for SSLClientSocketOpenSSL.davidben@chromium.org2014-07-261-8/+0
| | | | | | | | | | | | | | In doing so, fix a bug in tlslite's TLS_FALLBACK_SCSV support; the fallback alert should be sent with the client's version. Otherwise OpenSSL reports SSL_R_UNSUPPORTED_PROTOCOL and doesn't report the alert. This behavior is probably not wrong as, if the server responds with a TLS version higher than what is supported, we can't really be sure of the parse. BUG=388425 Review URL: https://codereview.chromium.org/418553003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285764 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ServerBoundCert => ChannelID to reflect the current namerch@chromium.org2014-07-256-33/+33
| | | | | | | | | | of this feature. TBR=darin Review URL: https://codereview.chromium.org/356713005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285432 0039d316-1c4b-4281-b951-d872f2087c98
* Add AssertNoURLRequests() to URLRequestContext subclass destructors.jgraettinger@chromium.org2014-07-224-2/+11
| | | | | | | | BUG=377852 Review URL: https://codereview.chromium.org/379293002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284556 0039d316-1c4b-4281-b951-d872f2087c98
* Preserve transport errors for OpenSSL sockets.davidben@chromium.org2014-07-141-3/+3
| | | | | | | | | | | | | | | | | | | This makes the OpenSSL BIO pair behave like nss_memio with respect to errors, eliminating many discrepancies between the two backends in ssl_client_socket_unittest.cc. (While adding one as it exposes a difference in how OpenSSL and NSS behave internally.) This also makes our fallback behavior on TCP reset match; in NSS we take care to only fall back to TLS 1, but our OpenSSL code falls back all the way to SSL3. We save transport errors and install a BIO callback to return those errors through the OpenSSL error queue when OpenSSL's SSL implementation attempts to read or write to the transport BIO. BUG=372849, 341178 Review URL: https://codereview.chromium.org/367963007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283013 0039d316-1c4b-4281-b951-d872f2087c98
* Add Finch experiment for selectively bypassing proxies.rcs@chromium.org2014-07-091-0/+2
| | | | | | | | | | | | | | | Add option to bypass the data compression proxy if the request resource type (as inferred by the renderer process) is not an image. For background, see this design doc: https://docs.google.com/a/google.com/document/d/1Kz92Fmw3lv_R-2aNvLp8jW9lkfKOZciTZtni2qQ_Adc/edit BUG=391836 Review URL: https://codereview.chromium.org/332313003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281951 0039d316-1c4b-4281-b951-d872f2087c98
* Fix uninitialized member of URLRequestBuilder.mmenke@chromium.org2014-07-081-1/+2
| | | | | | | | | | This landed in revision 281638 (https://codereview.chromium.org/354693004/) BUG=388836 Review URL: https://codereview.chromium.org/372163007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281741 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to using URLRequestContextBuilder to create some contexts.mmenke@chromium.org2014-07-082-40/+112
| | | | | | | | | | | | | Also add missing functionality to URLRequestContextBuilder to fit their needs. This is intended to simplify code to initialize the network stack, and make it easier to refactor network stack initialization. BUG=388836 Review URL: https://codereview.chromium.org/354693004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281638 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a use-after-free bug of the failure message.ricea@chromium.org2014-07-031-4/+0
| | | | | | | | | | | | | | | | If the WebSocket connection fails, it is possible for WebSocketHandshakeStreamCreateHelper to have a pointer to a WebSocketBasicHandshakeStream that has been deleted. So it is not safe to store the failure message in WebSocketBasicHandshakeStream. Instead, store it in StreamRequestImpl where it is guaranteed to stay alive until the handshake completes. BUG=379645 Review URL: https://codereview.chromium.org/368533002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281239 0039d316-1c4b-4281-b951-d872f2087c98
* Move SSLClientSocketNSS fallback logic to HttpNetworkTransaction.davidben@chromium.org2014-07-021-1/+27
| | | | | | | | | | | | | | | | | | | | | In preparation for it to be shared with the OpenSSL logic once it reports transport errors during handshaking. This does result in a slight behavior change: if a handshake gives ERR_CONNECTION_CLOSED, we now report that after the fallback chain ends (either via TLS_FALLBACK_SCSV or hitting SSLv3). Before, we would always turn it into ERR_SSL_PROTOCOL_ERROR. This is probably desirable and consistent with Firefox's behavior. Add a test, FallbackSCSVClosed, to test this new behavior. To that end, we should probably expect metrics to show some fraction of ERR_SSL_PROTOCOL_ERROR turn into ERR_CONNECTION_CLOSED and ERR_CONNECTION_RESET after this change. BUG=372849 Review URL: https://codereview.chromium.org/353183005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280938 0039d316-1c4b-4281-b951-d872f2087c98
* Add header pointer to BeforeProxyHeadersSentCallbackbengr@chromium.org2014-07-012-3/+8
| | | | | | | | | | | | | | This is needed because the higher layers, e.g., UrlRequestHttpJob do not always have a pointer to the request headers that the HttpNetworkTransaction will actually send. Note that the old code could also pass the wrong headers if redirects resulted in no longer going through the proxy. BUG=345907 Review URL: https://codereview.chromium.org/360113004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280885 0039d316-1c4b-4281-b951-d872f2087c98
* Add tests for TLS fallback on connection reset and close.davidben@chromium.org2014-06-271-105/+142
| | | | | | | | | | | The reset tests currently fail on OpenSSL and do not work on Android. But otherwise this gives us slightly better test coverage here. BUG=372849 Review URL: https://codereview.chromium.org/342793003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280188 0039d316-1c4b-4281-b951-d872f2087c98
* Move data reduction proxy to Chrome-Proxy header for authenticationbengr@chromium.org2014-06-265-0/+58
| | | | | | | | BUG=345907, 367268 Review URL: https://codereview.chromium.org/333113002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279957 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Net.URLRequest_SetReferrer_IsEmptyOrValid histogram.asvitkine@chromium.org2014-06-251-3/+0
| | | | | | | | | | | | | | | | | According to internal stats, this was the top 5 histogram that's taking up space in UMA and it was never documented in histograms.xml, which means no one has ever looked at its data. Delete it so that it stop taking resources without providing value. Document it in histograms.xml so that previous data can still be viewed on the dashboard, if needed. BUG=387734 Review URL: https://codereview.chromium.org/331343003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279639 0039d316-1c4b-4281-b951-d872f2087c98
* Mojo: Load document data through WebURLLoader.darin@chromium.org2014-06-242-4/+4
| | | | | | | | | | | | Implemented by setting the DataPipeConsumerHandle and URLResponse object as "extra data" on the WebURLRequest passed to WebFrame::loadRequest. This enables Blink to think that it is doing a normal navigation request. It also allows us to stream the data to the HTML parser rather than buffering it all in memory up front. It was necessary to plumb a few more response fields through from the network stack, in particular the mime type. This is expected by Blink's DocumentLoader. R=jamesr@chromium.org Review URL: https://codereview.chromium.org/344413002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279272 0039d316-1c4b-4281-b951-d872f2087c98
* net: FileStream cleanuprvargas@chromium.org2014-06-201-1/+2
| | | | | | | | | | | | | | | | Remove old "Async" prefix from a time when FileStream could perform sync operations, and use base::File methods instead of reimplement them. Remove a TODO from native_message_process_host given that we decided it is not worth moving that functionality to FileStream ATM. BUG=322664 TBR=sergeyu@chromium.org, kinuko@chromium.org R=hashimoto@chromium.org Review URL: https://codereview.chromium.org/323683002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278857 0039d316-1c4b-4281-b951-d872f2087c98
* net: Make URLRequestJobFactories mandatory.mmenke@chromium.org2014-06-182-24/+10
| | | | | | | | | | | The URLRequestJobManager will now crash if there is not one. This is part of the work aimed at eliminating the JobManager. BUG=142945 Review URL: https://codereview.chromium.org/332833003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278192 0039d316-1c4b-4281-b951-d872f2087c98
* Added Cronet HttpUrlRequestFactoryConfig.mef@chromium.org2014-06-172-2/+12
| | | | | | | | BUG=354143 Review URL: https://codereview.chromium.org/260553002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277587 0039d316-1c4b-4281-b951-d872f2087c98
* Make SdchManager per-profile.rdsmith@chromium.org2014-06-154-28/+31
| | | | | | | | | | | | | | | | This will both allow SDCH dictionaries to be cached (as they can use the cache associated with the profile) and will provide privacy protection between different profiles (the existing of a dictionary in one profile will not be leaked to another profile). BUG=374914 R=jar@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277160 Review URL: https://codereview.chromium.org/298063006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277322 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 277160 "Make SdchManager per-profile."viettrungluu@chromium.org2014-06-144-31/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On LSan, SdchManagerTest.CanUseMultipleDictionaries fails (leaks): http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/3073/steps/net_unittests/logs/stdio E.g.: Indirect leak of 34 byte(s) in 1 object(s) allocated from: #0 0x512b7b in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:55 #1 0x7f4730122739 in __gnu_cxx::new_allocator<char>::allocate(unsigned long, void const*) /build/buildd/gcc-4.6-4.6.3/build/x86_64-linux-gnu/libstdc++-v3/include/ext/new_allocator.h:92 #2 0x7f4730121d2c in std::string::_Rep::_S_create(unsigned long, unsigned long, std::allocator<char> const&) /build/buildd/gcc-4.6-4.6.3/build/x86_64-linux-gnu/libstdc++-v3/include/bits/basic_string.tcc:609 #3 0x7f4730121f04 in std::string::_Rep::_M_clone(std::allocator<char> const&, unsigned long) /build/buildd/gcc-4.6-4.6.3/build/x86_64-linux-gnu/libstdc++-v3/include/bits/basic_string.tcc:631 #4 0x7f473011ec48 in std::string::reserve(unsigned long) /build/buildd/gcc-4.6-4.6.3/build/x86_64-linux-gnu/libstdc++-v3/include/bits/basic_string.tcc:512 #5 0x7f473011f391 in std::string::append(unsigned long, char) /build/buildd/gcc-4.6-4.6.3/build/x86_64-linux-gnu/libstdc++-v3/include/bits/basic_string.tcc:290 #6 0x7f473011eaeb in std::string::resize(unsigned long, char) /build/buildd/gcc-4.6-4.6.3/build/x86_64-linux-gnu/libstdc++-v3/include/bits/basic_string.tcc:647 #7 0x31d6642 in resize /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/basic_string.h:749 #8 0x31d6642 in base::Base64Encode(base::BasicStringPiece<std::string> const&, std::string*) base/base64.cc:13 #9 0x34a1d05 in net::SdchManager::UrlSafeBase64Encode(std::string const&, std::string*) net/base/sdch_manager.cc:541 #10 0x34a1124 in net::SdchManager::GenerateHash(std::string const&, std::string*, std::string*) net/base/sdch_manager.cc:508 #11 0x349facb in net::SdchManager::AddSdchDictionary(std::string const&, GURL const&) net/base/sdch_manager.cc:363 #12 0x803e06 in net::SdchManagerTest_CanUseMultipleDictionaries_Test::TestBody() net/base/sdch_manager_unittest.cc:403 [...] > Make SdchManager per-profile. > > This will both allow SDCH dictionaries to be cached (as they can use the > cache associated with the profile) and will provide privacy protection > between different profiles (the existing of a dictionary in one profile > will not be leaked to another profile). > > BUG=374914 > R=jar@chromium.org > > Review URL: https://codereview.chromium.org/298063006 TBR=rdsmith@chromium.org Review URL: https://codereview.chromium.org/331023002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277185 0039d316-1c4b-4281-b951-d872f2087c98
* Make SdchManager per-profile.rdsmith@chromium.org2014-06-144-28/+31
| | | | | | | | | | | | | | This will both allow SDCH dictionaries to be cached (as they can use the cache associated with the profile) and will provide privacy protection between different profiles (the existing of a dictionary in one profile will not be leaked to another profile). BUG=374914 R=jar@chromium.org Review URL: https://codereview.chromium.org/298063006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277160 0039d316-1c4b-4281-b951-d872f2087c98
* Moved data reduction proxy bypass logic to a NetworkDelegatebengr@chromium.org2014-06-137-0/+42
| | | | | | | | BUG=367221 Review URL: https://codereview.chromium.org/286903018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277009 0039d316-1c4b-4281-b951-d872f2087c98
* Remove UrlRequestJobManager's global URLRequest::ProtocolFactory map.mmenke@chromium.org2014-06-139-224/+133
| | | | | | | | | | | | | | | | Also makes the only two classes that were still using them no longer do so. One unit test now creates it own URLRequestJobFactory, and URLRequestFilter now sets a global used by URLRequestJobFactoryImpl. There are still globals ProtocolFactories for http/https/ws/wss, which will need to be removed in a subsequent CL. BUG=81979 Review URL: https://codereview.chromium.org/313533002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276970 0039d316-1c4b-4281-b951-d872f2087c98
* Don't advertise SDCH for post requests.rdsmith@chromium.org2014-06-111-0/+5
| | | | | | | | | BUG=382626 R=jar@chromium.org Review URL: https://codereview.chromium.org/321863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276253 0039d316-1c4b-4281-b951-d872f2087c98
* Make URLRequestFilter use URLRequestInterceptors.mmenke@chromium.org2014-06-063-91/+88
| | | | | | | | | | | It was using ProtocolHandlers, but it makes more sense for it to use the new URLRequestInterceptor class. BUG=146600 Review URL: https://codereview.chromium.org/300693005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275470 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ProtocolFactory use from appcache_url_request_job_unittest.mmenke@chromium.org2014-06-061-19/+0
| | | | | | | | | | | | | | | The test now uses its own URLRequestJobFactory instead. This is being done to remove use of a deprecated API in net/ Also remove most friend classes outside net/ from URLRequest::Deprecated, as none of them are needed any more, except for AppCacheInterceptor. BUG=81979 Review URL: https://codereview.chromium.org/311263011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275298 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of websocket_over_spdy_enabled global.mmenke@chromium.org2014-06-022-0/+13
| | | | | | | | | | | It's now called enable_websocket_over_spdy and is a member of HttpNetworkSession::Params. BUG=372528 Review URL: https://codereview.chromium.org/295383007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274351 0039d316-1c4b-4281-b951-d872f2087c98
* Add the ability for DevTools to wrap network transactions.eustas@chromium.org2014-06-021-1/+2
| | | | | | | | | | | | | | | | The eventual goal is to allow it to simulate flaky network connections. Docs: https://docs.google.com/a/google.com/document/d/1SkuWqLYIUpMDI05n7vgx8zdkunyUsxGs9tvUPDOqEJY/edit https://docs.google.com/a/google.com/document/d/19O_UeUfCFZg5cEnH5jkkZ6_tqsfaLQLYUEIGyXw3oTo/edit BUG=245436 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273584 Review URL: https://codereview.chromium.org/182993003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274253 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ProtocolInterceptJobFactory and make it not use ProtocolHandlers.mmenke@chromium.org2014-05-306-100/+159
| | | | | | | | | | | | | | | | | ProtocolHandlers are intended to handle all requests for a particular scheme, while UrlRequestInterceptors are intended to sit in front of ProtocolHandlers, and optionally take over handling of any request, regardless of scheme. Separating the classes removes some ambiguity and weirdness, particularly when passing a bunch of interceptors all over the place from content/ to chrome/ during initialization. BUG=373800 Review URL: https://codereview.chromium.org/282103004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273874 0039d316-1c4b-4281-b951-d872f2087c98
* Enable SPDY 3.1 and 3.0 in UrlRequestContextBuilder by defaultmmenke@chromium.org2014-05-302-1/+10
| | | | | | | | BUG=372528 Review URL: https://codereview.chromium.org/302893003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273856 0039d316-1c4b-4281-b951-d872f2087c98
* Remove HttpStream::GetResponseInfo, which is not currently used.mmenke@chromium.org2014-05-291-4/+0
| | | | | | | | | | | | | | | HttpStream::GetResponseInfo returned a pointer to an object not owned by the HttpStream, so could result in returning freed memory, in the case the stream outlives its client. This happens in the case an HttpResponseBodyDrainer is used. As the method isn't used anywhere, seems a good idea to get rid of it. BUG=none Review URL: https://codereview.chromium.org/303443009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273629 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 273584 "Add the ability for DevTools to wrap network tran..."mattm@chromium.org2014-05-291-2/+1
| | | | | | | | | | | | | | | | | | | | | | Seems to have caused leaks in devtoolstests on asan bots. > Add the ability for DevTools to wrap network transactions. > > The eventual goal is to allow it to simulate flaky network connections. > > Docs: > https://docs.google.com/a/google.com/document/d/1SkuWqLYIUpMDI05n7vgx8zdkunyUsxGs9tvUPDOqEJY/edit > https://docs.google.com/a/google.com/document/d/19O_UeUfCFZg5cEnH5jkkZ6_tqsfaLQLYUEIGyXw3oTo/edit > > BUG=245436 > > Review URL: https://codereview.chromium.org/182993003 TBR=eustas@chromium.org Review URL: https://codereview.chromium.org/309483007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273615 0039d316-1c4b-4281-b951-d872f2087c98