summaryrefslogtreecommitdiffstats
path: root/net/url_request
Commit message (Collapse)AuthorAgeFilesLines
* Change name for API that returns RTT estimate at HTTP layertbansal2016-03-251-44/+0
| | | | | | | | | | | | This CL renames the existing API to GetURLRTTEstimate(). In the next CL, another API GetTransportRTTEstimate() will be added that computes RTT at the transport layer. BUG=502428 Review URL: https://codereview.chromium.org/1815503002 Cr-Commit-Position: refs/heads/master@{#383320}
* Fix crash in URLRequestHttpJob::OnStartCompletednharper2016-03-251-2/+4
| | | | | | | | BUG=548423 Review URL: https://codereview.chromium.org/1833803002 Cr-Commit-Position: refs/heads/master@{#383207}
* [net/http auth] Support channel bindings for HTTP authentication.asanka2016-03-231-8/+12
| | | | | | | | | | | | | | Start using tls-server-end-point channel bindings for HTTP authentication if a certificate is available. The current implementation should work on Windows and Posix. Currently only SHA-256, SHA-384, and SHA-512 are supported for generating channel bindings. BUG=270219 R=rsleevi@chromium.org,davidben@chromium.org Review URL: https://codereview.chromium.org/1408433006 Cr-Commit-Position: refs/heads/master@{#382858}
* Restrict logging of channel id mismatches to requests made to ↵nharper2016-03-221-3/+4
| | | | | | | | | | accounts.google.com BUG=548423 Review URL: https://codereview.chromium.org/1818023003 Cr-Commit-Position: refs/heads/master@{#382665}
* SameSite: Strict/Lax behavior.mkwst2016-03-212-42/+99
| | | | | | | | | | | | | | This patch brings our "SameSite" implementation into line with https://tools.ietf.org/html/draft-west-first-party-cookies-06 by teaching CookieOptions about strict and lax request modes, and teaching URLRequestHttpJob about the registrable-domain behaviors of both. BUG=459154 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review URL: https://codereview.chromium.org/1783813002 Cr-Commit-Position: refs/heads/master@{#382277}
* Make net pass "gn check"brettw2016-03-183-4/+5
| | | | | | | | | | | | | | Move quic_process_packet_interface.h from epoll_quic_tools to simple_quic_tools. This abstract interface is used in both places, and the dependency goes in the opposite direction as it was used before. Added some "nogncheck" annotations on headers conditionally included where the conditional dependencies correctly match the conditional includes. Add some websockets headers to the shared net sources target. As explained in the comment I added there, the these headers are used but there are no link-time dependencies so the websockets implementation can still be conditionally excluded. I prefer this method rather than a nogncheck annotation when there's no clear conditional include. Removed an unused FTP include from url_request_context_storage.cc Review URL: https://codereview.chromium.org/1812243002 Cr-Commit-Position: refs/heads/master@{#382119}
* Add an option to disable net::BidirectionalStreamQuicImplxunjieli2016-03-182-0/+9
| | | | | | | | | | | | | This CL adds an option to disable net::BidirectionalStreamQuicImpl in net::HttpNetworkSession. When the flag is set to true, alternative service job will not be negotiated. BUG=584338 Review URL: https://codereview.chromium.org/1796253002 Cr-Commit-Position: refs/heads/master@{#382084}
* Adding macro to enable changing SSL library (Part 1)svaldez2016-03-182-7/+7
| | | | | | | | | | | This changes the macro used to be USE_NSS_VERIFIER and modifies build files to no longer assume iOS is using NSS. BUG=591545 Review URL: https://codereview.chromium.org/1808963004 Cr-Commit-Position: refs/heads/master@{#382077}
* Remove NetworkDelegate pointer from HttpNetworkSession.mmenke2016-03-183-3/+0
| | | | | | | | | | | | | Nothing is currently using it, and currently HttpNetworkSessions can be shared by URLRequestContexts with different NetworkDelegates, so best to remove the field. TBR=zea@chromium.org, mkwst@chromium.org BUG=none Review URL: https://codereview.chromium.org/1811283004 Cr-Commit-Position: refs/heads/master@{#382031}
* SameSite: Implement 'Strict'/'Lax' attribute parsing.mkwst2016-03-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | | https://tools.ietf.org/html/draft-west-first-party-cookies-06 introduced the notion of "Strict" or "Lax" enforcement of the "SameSite" attribute. This patch implements the infrastructure changes necessary to support that distinction, but does not yet implement the behavioral change (that is, after this patch, `SameSite` will be rejected, while `SameSite=Strict` and `SameSite=Lax` will have the same behavior that `SameSite` alone has today). Most of this patch is occupied with the fairly mechanical process of swapping out a new 'CookieSameSite' enum for the existing boolean in various constructors and setters. The most interesting piece is the change to the storage backend, which now stores 0, 1, or 2 in the database to represent the possible values, rather than 0 or 1 to represent the boolean. BUG=459154 Review URL: https://codereview.chromium.org/1773133002 Cr-Commit-Position: refs/heads/master@{#381201}
* Let LSan know we know that URLRequestContextGetters sometimes leak.reillyg2016-03-121-0/+3
| | | | | | | | | | | This annotation will silence warnings from LSan. BUG=594130 TBR=cbentzel@chromium.org Review URL: https://codereview.chromium.org/1792563003 Cr-Commit-Position: refs/heads/master@{#380856}
* Another attempt to properly initialize ↵thestig2016-03-101-8/+2
| | | | | | | | | | | | net::TestURLRequestContext::ct_policy_enforcer_. r380368 was not enough, as there are two ctors. TBR=estark@chromium.org Review URL: https://codereview.chromium.org/1772343006 Cr-Commit-Position: refs/heads/master@{#380396}
* Initialize net::TestURLRequestContext::ct_policy_enforcer_.thestig2016-03-101-0/+1
| | | | | | | | | | This got left out of r380322. TBR=estark@chromium.org Review URL: https://codereview.chromium.org/1781663005 Cr-Commit-Position: refs/heads/master@{#380368}
* Implement a skeleton version of Expect CT reportsestark2016-03-105-0/+161
| | | | | | | | | | | | | | | | | This CL implements the skeleton of Expect CT reporting, which will eventually send reports when an opted-in site fails to conform to CT policy as determined by CertPolicyEnforcer. Introduces a new TransportSecurityState interface called ExpectCTReporter for observing CT policy violations that pass through URLRequestHTTPJob. There is a skeleton implementation called ChromeExpectCTReporter in chrome/browser/ssl which will eventually use a net::CertificateReportSender to send reports. BUG=568806 Review URL: https://codereview.chromium.org/1579063002 Cr-Commit-Position: refs/heads/master@{#380322}
* Add atomic sequence number to ChannelIDService and check that in ↵nharper2016-03-101-4/+18
| | | | | | | | | | URLRequestHttpJob logging BUG=548423 Review URL: https://codereview.chromium.org/1770983002 Cr-Commit-Position: refs/heads/master@{#380299}
* Log whether the ephemerality of the ChannelIDStore and CookieStore are the samenharper2016-03-093-1/+60
| | | | | | | | BUG=548423 Review URL: https://codereview.chromium.org/1745373002 Cr-Commit-Position: refs/heads/master@{#380165}
* Add support for Link rel=serviceworker in HTTP headers.mek2016-03-092-2/+4
| | | | | | | | | | | | | | | | | | This adds a new LinkHeaderResourceThrottle resource throttle which inspects responses for Link headers, and tries to install a service worker when a header with rel=serviceworker is encountered. This implements the HTTP header part of the spec change discussed at https://github.com/slightlyoff/ServiceWorker/issues/685 Even though this code doesn't live in blink, the feature is still guarded by the experimental web platform features flag. BUG=582310 Review URL: https://codereview.chromium.org/1736143002 Cr-Commit-Position: refs/heads/master@{#380035}
* CookieStore: Remove reference counting.mmenke2016-03-0710-25/+31
| | | | | | | | | | | | | This has caused a number of issues in the past, and having defined lifecycles for objects makes code easier to reason about and maintain. BUG=472744 TBR=alexclarke@chromium.org, creis@chromium.org Review URL: https://codereview.chromium.org/1701063002 Cr-Commit-Position: refs/heads/master@{#379588}
* Remove Pass() helper from base/move.h.dcheng2016-03-041-4/+4
| | | | | | | | | | | Also fix some comments that refer to the old Pass() helper. BUG=557422 TBR=darin@chromium.org Review URL: https://codereview.chromium.org/1759223002 Cr-Commit-Position: refs/heads/master@{#379162}
* Bypass the DataReductionProxy for all POST requestsryansturm2016-03-031-6/+2
| | | | | | | | | | POST requests are non-dempotent, so clients using the Data Reduction Proxy (DRP) can often end up at an error page due to the fact that if the DRP has any problems connecting to the origin, DRP and the client will not be safely able to determine if the post successfully made it to the server. The impact of this change on data compression should be very limited, and it will improve the client's experience. BUG=581750 Review URL: https://codereview.chromium.org/1684123004 Cr-Commit-Position: refs/heads/master@{#379137}
* [Blimp Engine] Use URLRequestContextBuilder to properly create ↵haibinlu2016-03-032-0/+26
| | | | | | | | | | URLRequestContext. BUG=590251 Review URL: https://codereview.chromium.org/1764493002 Cr-Commit-Position: refs/heads/master@{#379112}
* Passing in a Data Reduction Proxy Delegate from Cronet with Data Reduction ↵ryansturm2016-03-014-0/+21
| | | | | | | | | | | | | | | | | | | | | | Proxy Enabled The Cronet test, CronetUrlRequestContextTest#testDataReductionProxyEnabled started to fail as a result of https://codereview.chromium.org/1680893002 This fix creates a DataReductionProxyDelegate for Cronet when built with the data_reduction build flag. The test relied on having DataReductionProxyNetworkDelegate handle the proxy resolution before, but that work is now handled by DataReductionProxyDelegate. BUG=589600 Review URL: https://codereview.chromium.org/1725123005 Cr-Commit-Position: refs/heads/master@{#378337}
* Revert of Change ProxyResolver::GetProxyForURL() to take a ↵eroman2016-02-291-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | scoped_ptr<Request>* rather than a RequestHandle* (patchset #11 id:200001 of https://codereview.chromium.org/1439053002/ ) Reason for revert: Top crasher on Canary has PAC script cancellation on callstack. Very likely a bug or interaction with this CL. Reverting until I have a chance to fully investigate. Original issue's description: > Change ProxyResolver::GetProxyForURL() to take a scoped_ptr<Request>* rather than a RequestHandle* > > * ProxyResolver::GetProxyForURL() fills a |scoped_pointer<Request>*| > rather than a |void*| > * ProxyResolver::CancelRequest(void*) has been removed. Requests > are instead cancelled by resetting the scoped_ptr<Request>. > > This makes for less error prone code as cancellation of > requests is automatic when the > scoped_ptr<Request> goes out of scope. > ProxyResolver::GetLoadState() is removed and replaced > by Request::GetLoadState(). > > Also made some renaming, as there were similar class > named Job or Request. Now they are all Job and this new thing > is Request. > > Referencing by address to object in vector was not wise in net/proxy/mojo_proxy_resolver_impl_unittest.cc which is now fixed by using scoped_ptrs in that vector. > > BUG=478934 > > Committed: https://crrev.com/a750e126346aa42df1b0cbc2ae6a58abbe7a5069 > Cr-Commit-Position: refs/heads/master@{#377856} TBR=davidben@chromium.org,olli.raula@intel.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=478934 Review URL: https://codereview.chromium.org/1745133002 Cr-Commit-Position: refs/heads/master@{#378274}
* net: Add out-of-line copy ctors for complex classes.vmpstr2016-02-262-0/+3
| | | | | | | | | | | | | This patch adds out of line copy constructors for classes that our clang-plugin considers heavy. This is an effort to enable copy constructor checks by default. BUG=436357 R=agl@chromium.org, dcheng@chromium.org, thakis@chromium.org Review URL: https://codereview.chromium.org/1728333003 Cr-Commit-Position: refs/heads/master@{#377976}
* Change ProxyResolver::GetProxyForURL() to take a scoped_ptr<Request>* rather ↵olli.raula2016-02-261-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | than a RequestHandle* * ProxyResolver::GetProxyForURL() fills a |scoped_pointer<Request>*| rather than a |void*| * ProxyResolver::CancelRequest(void*) has been removed. Requests are instead cancelled by resetting the scoped_ptr<Request>. This makes for less error prone code as cancellation of requests is automatic when the scoped_ptr<Request> goes out of scope. ProxyResolver::GetLoadState() is removed and replaced by Request::GetLoadState(). Also made some renaming, as there were similar class named Job or Request. Now they are all Job and this new thing is Request. Referencing by address to object in vector was not wise in net/proxy/mojo_proxy_resolver_impl_unittest.cc which is now fixed by using scoped_ptrs in that vector. BUG=478934 Review URL: https://codereview.chromium.org/1439053002 Cr-Commit-Position: refs/heads/master@{#377856}
* Make URLRequestFileDirJob::FillReadBuffer() return an int indicating the resultshahriar.rostami2016-02-253-26/+134
| | | | | | | | | | | BUG=586393 URLRequestFileDirJob::FillReadBuffer() to return bytes reads if it really reads data. If list_complete, returns list_complete_result_, and otherwise ERR_IO_PENDING. Review URL: https://codereview.chromium.org/1702713004 Cr-Commit-Position: refs/heads/master@{#377689}
* Disable the TLS version fallback.davidben2016-02-241-15/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This sets the default minimum TLS fallback version to TLS 1.2. The code is retained for now to support a resurrected SSLVersionFallbackMin admin policy. The policy is set to expire in Chrome 53, matching the timeline for the previous fallback removal. As an escape hatch (but I don't expect to need it), it's also connected to a field trial. This also tweaks the fallback code. The TLS 1.0 fallback leg is now completely gone (the admin policy expired) and ERR_SSL_FALLBACK_BEYOND_MINIMUM_VERSION hits have leveled off (see Net.ErrorCodesForMainFrame3), cap the fallback code to TLS 1.1. We will no longer even try TLS 1.0 ClientHellos for the purposes of showing the error code. This will decrease the amount of time it takes to show an error page in some cases. The ssl_version_fallback_min toggle is also tweaked to reject all values below TLS 1.1, so that the resurrected admin policy cannot be used to set the value at TLS 1.0 again. (Though it would be moot due to the above change.) We'll also want to add a link to some to-be-written Help Center article on the error page, but that'll be done separately after chatting with UI folks. BUG=536200,583787 Review URL: https://codereview.chromium.org/1682623002 Cr-Commit-Position: refs/heads/master@{#377352}
* net: move IsLocalhost() function into url_util.htfarina2016-02-233-3/+1
| | | | | | | | | | | | | | This patch moves the last function in net_util.h into url_util.h. We are moving it there because it also operates on a URL part (host). BUG=488531 TEST=net_unittests --gtest_filter=UrlUtilTest.IsLocalhost R=eroman@chromium.org TBR=darin@chromium.org Review URL: https://codereview.chromium.org/1726693002 Cr-Commit-Position: refs/heads/master@{#377115}
* Load cookies once per HTTP request.mkwst2016-02-232-43/+27
| | | | | | | | | | | | | | This refactors URLRequestHttpJob's cookie retrieval code to grab cookies once for a request, rather than requesting it once, checking cookie permissions, then throwing the data away and requesting it again. BUG=581650 R=mmenke@chromium.org,rdsmith@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review URL: https://codereview.chromium.org/1638343002 Cr-Commit-Position: refs/heads/master@{#377015}
* Moving proxy resolution logic out of NetworkDelegate and into ProxyDelegate ↵ryansturm2016-02-232-4/+16
| | | | | | | | | | | | | | for DataReductionProxy This involves removing two methods off the NetworkDelegate interface (and four off LayeredNetworkDelegate). DataReductionProxy's logic for these two methods will be moved to the DataReductionProxyDelegate from the DataReductionProxyNetworkDelegate. This also involved cleaning up some unit tests and moving calls to use ProxyDelegate instead of NetworkDelegate where relevant. Refactoring proxy related calls from NetworkDelegate to ProxyDelegate BUG=583369 Review URL: https://codereview.chromium.org/1680893002 Cr-Commit-Position: refs/heads/master@{#376860}
* Update some comments of URLFetcher.liushouqun2016-02-201-12/+11
| | | | | | | | | | Update comments according to changes in URLFetcher, no behavior change. BUG=none Review URL: https://codereview.chromium.org/1697053002 Cr-Commit-Position: refs/heads/master@{#376657}
* Android: Add support for android-app scheme in a referrer.lizeb2016-02-191-0/+14
| | | | | | | | | | | | | | Following android's documentation, native apps can set a referrer with the format android-app://com.foo.bar. This is supported by the Java side, but not the native code. TBR=alokp@chromium.org,asargent@chromium.org # Adding a parameter in chromecast/ and extensions/ TESTED=adb shell am start -n com.google.android.apps.chrome/.Main -a "android.intent.action.VIEW" -d 'http://www.whatismyreferer.com/' --eu "android.intent.extra.REFERRER" "android-app://com.foo.bar" BUG=537863 Review URL: https://codereview.chromium.org/1416863004 Cr-Commit-Position: refs/heads/master@{#376423}
* Support for client certs in ssl_server_socket.ryanchung2016-02-191-1/+2
| | | | | | | | | | | Allows SSL server sockets (openssl only) to support requesting and receiving/verifying client auth certificates. BUG=415663 Review URL: https://codereview.chromium.org/1474983003 Cr-Commit-Position: refs/heads/master@{#376292}
* URLRequestHttpJob: No longer wait for setting a cookie to complete.mmenke2016-02-162-100/+17
| | | | | | | | | | | The new code is simpler, and results in fewer roundtrips if the CookieStore often completes tasks asynchronously. BUG=587127 Review URL: https://codereview.chromium.org/1704583002 Cr-Commit-Position: refs/heads/master@{#375697}
* Exposes QUIC's migrate_sessions_early flag to cronet users.jri2016-02-122-1/+10
| | | | | | | | | R=mef@chromium.org, pauljensen@chromium.org BUG=576998 Review URL: https://codereview.chromium.org/1685473002 Cr-Commit-Position: refs/heads/master@{#375268}
* Fixed resuming URLRequestFileDirJob in the OOPIF mode.shahriar.rostami2016-02-123-22/+178
| | | | | | | | | | | BUG=574997 We defer all requests in the OOPIF-enabled modes. There was a conditional check which makes resuming not working properly in the URLRequestFileDirJob. Review URL: https://codereview.chromium.org/1580503007 Cr-Commit-Position: refs/heads/master@{#375050}
* [Cronet] Expose quic_user_agent_id and quic_prefer_aes config options.mef2016-02-092-0/+15
| | | | | | | | | | | | - QUIC will soon require that user agent id field is non-empty, but normal User-Agent request header is too rich and verbose to be used for this purpose. The app can override default value using 'user_agent_id' quic experimental option. - prefer_aes experimental option is needed to experiment with performance of using AES instead of ChaCha20. BUG=575771 Review URL: https://codereview.chromium.org/1665503002 Cr-Commit-Position: refs/heads/master@{#374438}
* Disable experimental alternative services in URLRequestContextBuilder.bnc2016-02-091-2/+2
| | | | | | | | | | | | use_alternative_services| was split into two flags in https://crrev.com/1639913002. It was incorrectly set to true before, and since that CL aimed to preserving default behavior, the two new flags are still incorrectly set to true. Right now, Alternative Services is still an experimental feature, therefore it should be disabled by default. Review URL: https://codereview.chromium.org/1676113002 Cr-Commit-Position: refs/heads/master@{#374367}
* Log what filter causes a decoding error.rdsmith2016-02-041-0/+2
| | | | | | | | | BUG=584326 R=xunjieli@chromium.org Review URL: https://codereview.chromium.org/1670643003 Cr-Commit-Position: refs/heads/master@{#373651}
* Exposes QUIC's close_sessions_on_ip_change and ↵jri2016-02-042-1/+21
| | | | | | | | | | | migrate_sessions_on_network_change flags to cronet users. R=pauljensen@chromium.org, rch@chromium.org BUG= Review URL: https://codereview.chromium.org/1661443002 Cr-Commit-Position: refs/heads/master@{#373614}
* Set URLRequest::status_ to ERR_IO_PENDING in URLRequest::Read()mmenke2016-02-041-1/+0
| | | | | | | | | | | | | | | | | We were doing this at the end of URLReqestJob::Read. The problem with that is that we could end up synchronously calling into code that expects to only to be called when the status is ERR_IO_PENDING, which resulted in a DCHECK failure. The failure was fairly benign, though it did allow external observers to notice some weirdness around URLRequest::Status if they really wanted to, in some uncommon cases. The DCHECK itself was added in https://codereview.chromium.org/1563633002/. BUG=582623 Review URL: https://codereview.chromium.org/1651253004 Cr-Commit-Position: refs/heads/master@{#373583}
* Set trusted SPDY proxy dynamically on per-profile basistbansal2016-02-042-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | Set trusted SPDY proxy on per-profile basis if the profile has DRP enabled, and if Chrome is part of the field trial. Prior to this CL, it was possible to set the trusted SPDY proxy only from command line switch. Setting it on per-profile ensures that it is set only if DRP is enabled (which is per-profile). Setting it dynamically ensures that if there is a change in DataReductionProxy config (e.g., the API tells Chrome to connect to a different DRP server), then the SPDY session to the different server has the trusted SPDY proxy set correctly to the new server. Prior to this CL, trusted SPDY proxy was set once at the time of Chrome start, and it was not possible to change it. Link to design doc: https://code.google.com/p/chromium/issues/detail?id=558682#c11 BUG=558682 Review URL: https://codereview.chromium.org/1547273003 Cr-Commit-Position: refs/heads/master@{#373442}
* Use Boolean members to control HTTP/2 and SPDY/3.1.bnc2016-02-022-8/+12
| | | | | | | | | | | | | | | | Add Boolean members to IOThread::Globals and HttpNetworkSession::Params to toggle HTTP/2 and SPDY/3.1 support instead of a NextProtoVector. This way clients do not have to have a notion of NextProto, "next_proto.h" includes can be removed from lots of files, and NextProto helper functions can be removed. Also default values are easier to define. This CL intends to preserve behavior and default values. BUG=329681 Review URL: https://codereview.chromium.org/1651123002 Cr-Commit-Position: refs/heads/master@{#372951}
* Rename first-party-only cookies to same-site cookies.mkwst2016-02-012-30/+28
| | | | | | | | | | | As per https://tools.ietf.org/html/draft-west-first-party-cookies-05 and https://lists.w3.org/Archives/Public/ietf-http-wg/2016JanMar/0134.html. BUG=459154 Review URL: https://codereview.chromium.org/1615773005 Cr-Commit-Position: refs/heads/master@{#372630}
* Add Alternative Service field trial.bnc2016-01-292-4/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | Before this CL: * If "use_alternative_service" QUIC trial param was set, both same host and different host Alt-Svc headers were parsed and used. If this param was not set, no Alt-Svc headers were parsed, and in-memory entries (from Alternate-protocol headers or loaded from disk) were only used if they referred to the same host. After this CL: * AltSvc field trial controls whether Alt-Svc headers are parsed. * "enable_alternative_service_with_different_host" QUIC trial param control whether in-memory Alt-Svc entries with different host (parsed in current session or loaded from disk) are used. Default values are not changed by this CL. This CL allows testing of same-host Alt-Svc header behavior. If no issues are encountered, parsing Alt-Svc headers and using same-host entries can be enabled by default, and Alternate-Protocols removed. BUG=581331 Review URL: https://codereview.chromium.org/1639913002 Cr-Commit-Position: refs/heads/master@{#372348}
* When URLRequestHttpJob processing cached response with GetDictionary header ↵Bacek2016-01-282-1/+79
| | | | | | | | | | we already have seen the header in SdchOwner. So just ignore it. R=rdsmith@chromium.org Review URL: https://codereview.chromium.org/1563163002 Cr-Commit-Position: refs/heads/master@{#372192}
* Remove simulated crash in URLRequest::DoCancelcsharrison2016-01-271-20/+0
| | | | | | | | | | This patch removes a DumpWithoutCrashing call in DoCancel that wasn't particularly useful. BUG=557430 Review URL: https://codereview.chromium.org/1645513003 Cr-Commit-Position: refs/heads/master@{#371887}
* Set Token-Binding HTTP headernharper2016-01-253-70/+143
| | | | | | | | | | | | Adds a new method to SSLClientSocket to get the Token Binding from an SSL connection where Token Binding was negotiated, and uses that to add the Set-Token-Binding HTTP header (only when Token Binding was negotiated). BUG=467312 Review URL: https://codereview.chromium.org/1378613004 Cr-Commit-Position: refs/heads/master@{#371347}
* Remove use of void** from HttpResponseHeaders::EnumerateHeaderolli.raula2016-01-252-6/+6
| | | | | | | | | | | Remove use of of obaque void** and use instead size_t* parameter. Logic inside is untouched. TBR=jam@chromium.org Review URL: https://codereview.chromium.org/1607773005 Cr-Commit-Position: refs/heads/master@{#371204}
* Make URLRequestJob::SetStatus private.mmenke2016-01-228-112/+144
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Recent CLs have already made it so URLRequestJob itself calls the method itself whenever necessary, except when URLRequestJob::Start is being called, where subclasses were still expected to invoke it. Most of them were failing to do so, but since nothing cares about the state after start, and little distinguished between ERR_IO_PENDING and SUCCESS, everything was still working. URLRequest now sets its status itself before it starts a URLRequestJob. This CL also makes the URLRequest consistently have a status of ERR_IO_PENDING when it's doing something - there were a number of paths where this wasn't previously the case. The state machine changes also coincidentally fix issue 575213, which regressed in https://codereview.chromium.org/1467603002, so this CL includes a test for that fix. In the future, I'd really like to get rid of URLRequestJob::SetStatus, and have URLRequests manage their own status. BUG=564250,575213 TBR=jianli@chromium.org, phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/1563633002 Cr-Commit-Position: refs/heads/master@{#371072}
generated by cgit v1.1 at 2025-05-11 17:26:51 +0000