| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=455409
TEST=run content_browsertests --gtest_filter=OutOfProcessPPAPITest.VideoEncoder
Review URL: https://codereview.chromium.org/956893002
Cr-Commit-Position: refs/heads/master@{#321790}
|
|
|
|
|
|
|
|
|
| |
BUG=417589
TEST=run ppapi/examples/video_encode/video_encode.html
Review URL: https://codereview.chromium.org/937643006
Cr-Commit-Position: refs/heads/master@{#318785}
|
|
|
|
|
|
|
|
|
|
|
|
| |
For tools/sort_sources.py to be useful, existing GYP and GN files
should be sorted.
BUG=456014
TEST=everything should build as before
Review URL: https://codereview.chromium.org/930753002
Cr-Commit-Position: refs/heads/master@{#316434}
|
|
|
|
|
|
|
|
| |
This adds the "threading" example which was unreferenced in the GYP build, despite existing and compiling OK.
Review URL: https://codereview.chromium.org/921993002
Cr-Commit-Position: refs/heads/master@{#316379}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This puts BUILD files in the corresponding directories without duplicate names.
Adds a template for ppapi examples and writes the build for one example. I only did one at this point to test the infrastructure without making this patch too large.
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/921953002
Cr-Commit-Position: refs/heads/master@{#316352}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also removed a few extra "-Wpedantic" warnings in ppapi_cpp. I don't see a good justification why this should be different than the rest of the project.
Fix GN error in media.
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/915403003
Cr-Commit-Position: refs/heads/master@{#316289}
|
|
|
|
|
|
|
|
|
|
| |
Thank you for your contributions!
TBR=vrk@chromium.org,bemasc@chromium.org
Review URL: https://codereview.chromium.org/895143002
Cr-Commit-Position: refs/heads/master@{#314620}
|
|
|
|
|
|
|
|
|
| |
BUG=81439
TEST=none
Review URL: https://codereview.chromium.org/758123004
Cr-Commit-Position: refs/heads/master@{#305757}
|
|
|
|
|
|
|
|
|
|
|
| |
Add 'Initialize' method that takes an enum value to specify hardware
acceleration policy. Policies are always, with fallback and only software.
BUG=406194
Review URL: https://codereview.chromium.org/496203002
Cr-Commit-Position: refs/heads/master@{#291606}
|
|
|
|
|
|
|
|
|
| |
BUG=403504
Review URL: https://codereview.chromium.org/475123003
Cr-Commit-Position: refs/heads/master@{#290016}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
VP8 and VP9 do not take profile into account. Using PROFILE_MAIN is confusing.
This patch uses PROFILE_ANY for these codecs.
TBR=noelallen@chromium.org
BUG=361676
Review URL: https://codereview.chromium.org/418193003
Cr-Commit-Position: refs/heads/master@{#289765}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
textures.
Reset now will allow plugin to call RecyclePicture. The plugin must recycle any
texture it receives now. This makes plugin code simpler, since it can treat all
textures it receives in the same way (no special Reset handling).
Also fix a bug where Reset didn't return textures to the hardware decoder, which
already has this behavior.
BUG=281689
Review URL: https://codereview.chromium.org/390213002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and example.
GL_TEXTURE_2D is used by x86 non-OSX platforms and by software fallback.
GL_TEXTURE_RECTANGLE_ARB will be used on OSX hardware.
GL_TEXTURE_EXTERNAL_OES is used on ARM ChromeOS.
BUG=281689
Review URL: https://codereview.chromium.org/354763003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This contains fixes for the following sorts of issues:
* Assignment inside conditional
* Possibly-uninitialized local variable
* Signedness mismatch
This also contains a small number of other cleanups/simplifications to nearby
code.
BUG=81439
TEST=none
R=teravest@chromium.org
Review URL: https://codereview.chromium.org/375133003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
And fix a bug found with the tests.
BindGraphics() does not work for a device which is in the same type with the current bound device.
BUG=374383
R=piman@chromium.org, raymes@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278728
Review URL: https://codereview.chromium.org/324983005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> [PPAPI] Add browser tests for compositor API
>
> And fix a bug found with the tests.
> BindGraphics() does not work for a device which is in the same type with the current bound device.
>
> BUG=374383
> R=piman@chromium.org, raymes@chromium.org
>
> Review URL: https://codereview.chromium.org/324983005
TBR=penghuang@chromium.org
Review URL: https://codereview.chromium.org/342323006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
And fix a bug found with the tests.
BindGraphics() does not work for a device which is in the same type with the current bound device.
BUG=374383
R=piman@chromium.org, raymes@chromium.org
Review URL: https://codereview.chromium.org/324983005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also, flip picture vertically (it was upside down).
BUG=281689
Review URL: https://codereview.chromium.org/340163002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the compositor API example gcc 4.9 reports a possible
type narrowing when using fabs call. To fix this use fabsf instead.
BUG=385988
R=dmichael
Review URL: https://codereview.chromium.org/335383003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Improve documentation for Reset and Flush.
Use VpxVideoDecoder in implementation code.
BUG=281689
Review URL: https://codereview.chromium.org/336833003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Use a hash_set to track available textures. This prevents weird behavior
if the plugin recycles a texture twice.
- Fix Reset, so all textures are made available on completion.
- Fix the plugin, which had a bug that allowed pictures to jump the queue
and didn't behave correctly on Reset.
BUG=281689
Review URL: https://codereview.chromium.org/337743003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement the compositor API which allows a plugin to combine different sources of visual data efficiently, such as PPB_ImageData and OpengGL texture.
API Proposal http://goo.gl/V7xcu3
BUG=374383
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277208
Review URL: https://codereview.chromium.org/298023004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL seems to cause perf bot failure.
The log said nacl_helper-data size gained exceeds expectation.
http://build.chromium.org/p/chromium/builders/Linux/builds/50560
https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux&tests=sizes%2Fnacl_helper-data&rev=277212&checked=core
> [PPAPI] Compositor API implementation.
>
> Implement the compositor API which allows a plugin to combine different sources of visual data efficiently, such as PPB_ImageData and OpengGL texture.
>
> API Proposal http://goo.gl/V7xcu3
>
> BUG=374383
>
> Review URL: https://codereview.chromium.org/298023004
TBR=penghuang@chromium.org
Review URL: https://codereview.chromium.org/331123003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement the compositor API which allows a plugin to combine different sources of visual data efficiently, such as PPB_ImageData and OpengGL texture.
API Proposal http://goo.gl/V7xcu3
BUG=374383
Review URL: https://codereview.chromium.org/298023004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/337683002/)
Reason for revert:
Revert of revert, which apparently wasn't a full revert.
Original issue's description:
> Revert of Implement software fallback for PPB_VideoDecoder. (https://codereview.chromium.org/311853005/)
>
> Reason for revert:
> Broke blink Linux tests compile.http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/37259
>
> Original issue's description:
> > Implement software fallback for PPB_VideoDecoder.
> > This modifies the proxy to implement software fallback mode.
> > The main change is to the host, which now can work with
> > media::VideoDecoders.
> >
> > media::VideoDecoder works differently from media::VideoDecodeAccelerator
> > so an adapter object, content::VideoDecoderShim is defined. It lives on the main thread and drives the actual decoder on the media thread via a child DecoderImpl class, which sends back frames of video. VideoDecoderShim receives those and converts frames to GL textures.
> >
> > gpu::Mailboxes are used so the host can create textures that are aliased
> > to the plugin's textures.
> >
> > The test plugin has been changed to include bitstream data for VP8 in order to
> > test the software decoder. The data is in ppapi/examples/video_decode/testdata.h
> > alongside the H264 data. The file diff is too large for this site but is structured
> > something like this:
> >
> > const unsigned char kData[] = {
> > #if defined USE_VP8_TESTDATA_INSTEAD_OF_H264
> > ... lots of VP8 data
> >
> > #else // !USE_VP8_TESTDATA_INSTEAD_OF_H264
> > ... lots of H264 data
> >
> > #endif // USE_VP8_TESTDATA_INSTEAD_OF_H264
> > };
> >
> >
> > There is a TODO to convert the example to load a file. I'm not sure how to go
> > about that but am willing to do the work if someone can point the way.
> >
> > BUG=281689
> > R=dmichael@chromium.org, fischman@chromium.org, sievers@chromium.org, tsepez@chromium.org
> >
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277012
>
> TBR=dmichael@chromium.org,fischman@chromium.org,igorc@chromium.org,piman@chromium.org,sievers@chromium.org,tsepez@chromium.org,bbudge@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=281689
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277015
TBR=dmichael@chromium.org,fischman@chromium.org,igorc@chromium.org,piman@chromium.org,sievers@chromium.org,tsepez@chromium.org,bbudge@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=281689
Review URL: https://codereview.chromium.org/333903002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/311853005/)
Reason for revert:
Broke blink Linux tests compile.http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/37259
Original issue's description:
> Implement software fallback for PPB_VideoDecoder.
> This modifies the proxy to implement software fallback mode.
> The main change is to the host, which now can work with
> media::VideoDecoders.
>
> media::VideoDecoder works differently from media::VideoDecodeAccelerator
> so an adapter object, content::VideoDecoderShim is defined. It lives on the main thread and drives the actual decoder on the media thread via a child DecoderImpl class, which sends back frames of video. VideoDecoderShim receives those and converts frames to GL textures.
>
> gpu::Mailboxes are used so the host can create textures that are aliased
> to the plugin's textures.
>
> The test plugin has been changed to include bitstream data for VP8 in order to
> test the software decoder. The data is in ppapi/examples/video_decode/testdata.h
> alongside the H264 data. The file diff is too large for this site but is structured
> something like this:
>
> const unsigned char kData[] = {
> #if defined USE_VP8_TESTDATA_INSTEAD_OF_H264
> ... lots of VP8 data
>
> #else // !USE_VP8_TESTDATA_INSTEAD_OF_H264
> ... lots of H264 data
>
> #endif // USE_VP8_TESTDATA_INSTEAD_OF_H264
> };
>
>
> There is a TODO to convert the example to load a file. I'm not sure how to go
> about that but am willing to do the work if someone can point the way.
>
> BUG=281689
> R=dmichael@chromium.org, fischman@chromium.org, sievers@chromium.org, tsepez@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277012
TBR=dmichael@chromium.org,fischman@chromium.org,igorc@chromium.org,piman@chromium.org,sievers@chromium.org,tsepez@chromium.org,bbudge@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=281689
Review URL: https://codereview.chromium.org/337683002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dmichael@chromium.org
BUG=281689
Review URL: https://codereview.chromium.org/334883002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This modifies the proxy to implement software fallback mode.
The main change is to the host, which now can work with
media::VideoDecoders.
media::VideoDecoder works differently from media::VideoDecodeAccelerator
so an adapter object, content::VideoDecoderShim is defined. It lives on the main thread and drives the actual decoder on the media thread via a child DecoderImpl class, which sends back frames of video. VideoDecoderShim receives those and converts frames to GL textures.
gpu::Mailboxes are used so the host can create textures that are aliased
to the plugin's textures.
The test plugin has been changed to include bitstream data for VP8 in order to
test the software decoder. The data is in ppapi/examples/video_decode/testdata.h
alongside the H264 data. The file diff is too large for this site but is structured
something like this:
const unsigned char kData[] = {
#if defined USE_VP8_TESTDATA_INSTEAD_OF_H264
... lots of VP8 data
#else // !USE_VP8_TESTDATA_INSTEAD_OF_H264
... lots of H264 data
#endif // USE_VP8_TESTDATA_INSTEAD_OF_H264
};
There is a TODO to convert the example to load a file. I'm not sure how to go
about that but am willing to do the work if someone can point the way.
BUG=281689
R=dmichael@chromium.org, fischman@chromium.org, sievers@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/311853005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Au revoir.
TBR=vrk@chromium.org, posciak@chromium.org
Review URL: https://codereview.chromium.org/322483006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds resource and host, unit test for the resource, and an example plugin.
Implements only the hardware accelerated case. Software fallback will be
in a follow-on CL.
Adds two new PP_Error codes:
PP_ERROR_UNREADABLE_INPUT
PP_ERROR_PLATFORM_FAILED
BUG=281689
R=dmichael@chromium.org, fischman@chromium.org, jar@chromium.org, piman@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/270213004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=281689
R=fischman@chromium.org, teravest@chromium.org
Review URL: https://codereview.chromium.org/269283002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=366304,244653,312916,314899
TEST=None
Review URL: https://codereview.chromium.org/252923005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=penghuang@chromium.org, yzshen@chromium.org
TBR=penghuang@chromium.org, yzshen@chromium.org
NOTRY=true
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/227063002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It also fixes a bug in release build.
BUG=330851
Review URL: https://codereview.chromium.org/212533007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
those APIs that needed by it.
BUG=None
TEST=None
Review URL: https://codereview.chromium.org/178953003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Fix references to it to be 'text/plain'. Also one instance of 'plain/html'.
BUG=none
Review URL: https://codereview.chromium.org/178153002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Support configuring frame format and size for video input.
BUG=330851
Review URL: https://codereview.chromium.org/150403006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This API allows pp::Resource objects to be read and written to pp::Vars.
Moved the methods of PPB_VarResource_Dev (C API) to PPB_Var version 1.2.
Moved the methods of pp::VarResource_Dev (C++ API) to pp::Var.
Code written against the dev API will no longer compile, as references
to the API need to be updated to use Var instead of VarResource_Dev.
Binaries compiled against the dev API will now experience run-time
errors loading the old interface.
BUG=177017
Review URL: https://codereview.chromium.org/148213016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
For audio, a frame usually has the same meaning as sample,
so AudioFrame is not a good name for a bunch of audio
samples. Change it to AudioBuffer.
BUG=330851
Review URL: https://codereview.chromium.org/156863005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For audio, a frame usually has the same meaning as sample,
so AudioFrame is not a good name for a bunch of audio
samples. Change it to AudioBuffer.
This CL only changes the name in base classes. The API
interface will be changed in a separate CL.
BUG=330851
Review URL: https://codereview.chromium.org/142023008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jamesr@chromium.org
BUG=330851
Review URL: https://codereview.chromium.org/140783004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=330851
Review URL: https://codereview.chromium.org/141993002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=330851
Review URL: https://codereview.chromium.org/134643002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It was unprefixed back in Chrome 23.
BUG=330691
TEST=no behavior change
Review URL: https://codereview.chromium.org/121203002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=318303
Review URL: https://codereview.chromium.org/69883006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change generalizes PPB_Ext_CrxFileSystem_Private, built on the isolated
filesystem, so that we can easily reuse its components when introducing new
isolated filesystem in PPAPI.
This adds PPB_IsolatedFileSystem_Private API and enum indicating isolated
filesystem type. PPB_Ext_CrxFileSystem_Private API is still remaining since
some plugins may use the API. Both API share pepper resource and host
implementations.
BUG=286242
TEST=manual (see [1] and [2])
TBR=cpu@chromium.org
[1] https://code.google.com/p/chromium/issues/detail?id=271126#c7
[2] https://codereview.chromium.org/59203002/
Review URL: https://codereview.chromium.org/51653004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Required when building on VS2013.
TBR=dmichael@chromium.org
BUG=288948
Review URL: https://codereview.chromium.org/32343005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm leaving usb_keycodes_map in ui/base for now.
BUG=none
TEST=none
R=ben@chromium.org, benm@chromium.org, scherkus@chromium.org
TBR=benm@chromium.org, brettw@chromium.org, scherkus@chromium.org
Review URL: https://codereview.chromium.org/23480084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This issue was found by a linter.
R=raymes@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/22950013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This issue was found by a linter.
R=fischman@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/23157006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218675 0039d316-1c4b-4281-b951-d872f2087c98
|