| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) use SkPictureRecorder::finishRecordingAsPicture() over
endRecordingAsPicture()
2) convert to sk_sp<SkPicture> fields/params where feasible
BUG=skia:5077
R=reed@google.com,danakj@chromium.org,enne@chromium.org
TBR=pdr@chromium.org,alekseys@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1819683002
Cr-Commit-Position: refs/heads/master@{#382563}
|
|
|
|
|
|
|
|
|
| |
Motivation: while experimenting with serializing images immediately,
we would like to keep serializing metadata first.
Review URL: https://codereview.chromium.org/1778133005
Cr-Commit-Position: refs/heads/master@{#381959}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1693883004
Cr-Commit-Position: refs/heads/master@{#375346}
|
|
|
|
|
|
|
|
|
|
| |
SkDocument::setMetadata
depends on https://crrev.com/1689683002
Review URL: https://codereview.chromium.org/1690093002
Cr-Commit-Position: refs/heads/master@{#375057}
|
|
|
|
|
|
|
|
|
|
|
| |
common for functions to be declared as returning SkCanvas* but defined as returning skia::PlatformCanvas*, so it's also not future-proof.
R=fmalita@chromium.org,reed@chromium.org
TBR=danakj@chromium.org,piman@chromium.org,thestig@chromium.org
Review URL: https://codereview.chromium.org/1618703006
Cr-Commit-Position: refs/heads/master@{#372084}
|
|
|
|
|
|
|
|
|
|
|
|
| |
❆(੭ु ◜◡‾)੭ु⁾☃❆
BUG=557422
R=avi@chromium.org
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/1550693002
Cr-Commit-Position: refs/heads/master@{#366956}
|
|
|
|
|
|
|
|
|
| |
BUG=138542
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1544623002
Cr-Commit-Position: refs/heads/master@{#366463}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1397333003
Cr-Commit-Position: refs/heads/master@{#358186}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1367713002
Cr-Commit-Position: refs/heads/master@{#351011}
|
|
|
|
|
|
|
|
|
| |
- Use stdint.h types.
- Fix lint errors.
Review URL: https://codereview.chromium.org/1343593002
Cr-Commit-Position: refs/heads/master@{#348660}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1232783007
Cr-Commit-Position: refs/heads/master@{#339101}
|
|
|
|
|
|
|
|
| |
endRecording() is deprecated.
Review URL: https://codereview.chromium.org/1066273002
Cr-Commit-Position: refs/heads/master@{#324260}
|
|
|
|
|
|
|
|
|
|
|
| |
Scale the recording canvas's page size, not it's canvas matrix. This
allows getTotalMatrix() to return the identity matrix.
BUG=469656
Review URL: https://codereview.chromium.org/1060603003
Cr-Commit-Position: refs/heads/master@{#323820}
|
|
|
|
|
|
|
|
| |
Code is not used after we Chrome stopped generation of EMF inside render.
Review URL: https://codereview.chromium.org/900683004
Cr-Commit-Position: refs/heads/master@{#315076}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This relands http://crrev.com/694213002
In the PdfMetafileSkia class, Instead of storing a
SkPDFDocument, store a vector of pages as
SkPictures. This allows access to individual at any
time. When FinishDocument() is called, use the
SkDocument API to print all pages to PDF.
In PrintWebViewHelper::RenderPageContent, skip clipping
content to content area, since Windows printing prints
content just outside of the content area, as noted in
http://crbug.com/434079 .
BUG=278148
Committed: https://crrev.com/18387e7ebb0eae6e4944e841d63ea058adab6e11
Cr-Commit-Position: refs/heads/master@{#310032}
Review URL: https://codereview.chromium.org/821703005
Cr-Commit-Position: refs/heads/master@{#312672}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #6 id:140001 of https://codereview.chromium.org/821703005/)
Reason for revert:
A bisect proved that this change caused
https://code.google.com/p/chromium/issues/detail?id=446729
Original issue's description:
> Remove calls to deprecated SkPDFDevice and SkPDFDocuemnt.
>
> This relands http://crrev.com/694213002
>
> In the PdfMetafileSkia class, Instead of storing a
> SkPDFDocument, store a vector of pages as
> SkPictures. This allows access to individual at any
> time. When FinishDocument() is called, use the
> SkDocument API to print all pages to PDF.
>
> In PrintWebViewHelper::RenderPageContent, skip clipping
> content to content area, since Windows printing prints
> content just outside of the content area, as noted in
> http://crbug.com/434079 .
>
> BUG=278148
>
> Committed: https://crrev.com/18387e7ebb0eae6e4944e841d63ea058adab6e11
> Cr-Commit-Position: refs/heads/master@{#310032}
TBR=vitalybuka@chromium.org,reed@google.com,danakj@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=278148
BUG=446729
Review URL: https://codereview.chromium.org/788053006
Cr-Commit-Position: refs/heads/master@{#310517}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This relands http://crrev.com/694213002
In the PdfMetafileSkia class, Instead of storing a
SkPDFDocument, store a vector of pages as
SkPictures. This allows access to individual at any
time. When FinishDocument() is called, use the
SkDocument API to print all pages to PDF.
In PrintWebViewHelper::RenderPageContent, skip clipping
content to content area, since Windows printing prints
content just outside of the content area, as noted in
http://crbug.com/434079 .
BUG=278148
Review URL: https://codereview.chromium.org/821703005
Cr-Commit-Position: refs/heads/master@{#310032}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The geometry headers were moved from /ui/gfx/ to ui/gfx/geometry, so
we are updating the include paths to fix this.
BUG=395370
TEST=compiles
TBR=sky@chromium.org,danakj@chromium.org
Review URL: https://codereview.chromium.org/832953002
Cr-Commit-Position: refs/heads/master@{#309873}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The geometry headers were moved from /ui/gfx/ to ui/gfx/geometry, so
we are updating the include paths to fix this.
BUG=395370
TEST=compiles
TBR=sky@chromium.org,danakj@chromium.org
Review URL: https://codereview.chromium.org/823133004
Cr-Commit-Position: refs/heads/master@{#309814}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The geometry headers were moved from /ui/gfx/ to ui/gfx/geometry, so
we are updating the include paths to fix this.
BUG=395370
TEST=unit_tests, content_unittests, extensions_unittests ...
TBR=sky@chromium.org,danakj@chromium.org
Review URL: https://codereview.chromium.org/823703003
Cr-Commit-Position: refs/heads/master@{#309523}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #4 id:370001 of https://codereview.chromium.org/694213002/)
Reason for revert:
Breaks printing.
BUG=434079
Original issue's description:
> Remove calls to deprecated SkPDFDevice and SkPDFDocuemnt.
>
> In the PdfMetafileSkia class, Instead of storing a
> SkPDFDocument, store a vector of pages as
> SkPictures. This allows access to individual at any
> time. When FinishDocument() is called, use the
> SkDocument API to print all pages to PDF.
>
> BUG=278148
>
> Committed: https://crrev.com/816b7105b078f7300f825cd81f379e312efdb821
> Cr-Commit-Position: refs/heads/master@{#304379}
TBR=robertphillips@google.com,reed@google.com,halcanary@google.com
BUG=278148
Review URL: https://codereview.chromium.org/731143004
Cr-Commit-Position: refs/heads/master@{#304536}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the PdfMetafileSkia class, Instead of storing a
SkPDFDocument, store a vector of pages as
SkPictures. This allows access to individual at any
time. When FinishDocument() is called, use the
SkDocument API to print all pages to PDF.
BUG=278148
Review URL: https://codereview.chromium.org/694213002
Cr-Commit-Position: refs/heads/master@{#304379}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Motivation: hide SkPDFDevice and SkPDFDocument behind PdfMetafileSkia class.
pdf_metafile_skia.cc:
Implement GetVectorCanvasForNewPage.
Remove StartPageForVectorCanvas.
Own the SkCanvas pointer (current_page_canvas_).
Replace page_outstanding_ field with a method that checks to see
if current_page_canvas_ is NULL.
Implement SaveTo.
skia::VectorPlatformDeviceSkia
remove class
print_web_view_helper.cc
Remove calls to canvas->getTopDevice()->setDrawingArea(...); (SkDFDevice)
This API is no longer effective.
print_web_view_helper_linux.cc,
print_web_view_helper_mac.mm,
print_web_view_helper_pdf_win.cc:
call GetVectorCanvasForNewPage rather than StartPageForVectorCanvas
BUG=278148
Review URL: https://codereview.chromium.org/704813002
Cr-Commit-Position: refs/heads/master@{#303522}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed some unused code.
Updated interfaces from plain pointers to scoped_ptr<>
SaveTo(base::FilePath) replaced with SaveTo(base::File).
BUG=408184
TBR=sgurun@chromium.org
Review URL: https://codereview.chromium.org/568633002
Cr-Commit-Position: refs/heads/master@{#294556}
|
|
|
|
|
|
|
|
|
|
| |
google_apis, printing, sql, ui, and webkit.
TBR=jochen@chromium.org,rogerta@chromium.org,shess@chromium.org,ben@chromium.org,jamesr@chromium.org
Review URL: https://codereview.chromium.org/529273002
Cr-Commit-Position: refs/heads/master@{#293479}
|
|
|
|
|
|
|
|
| |
BUG=322664
Review URL: https://codereview.chromium.org/184003002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=viettrungluu@chromium.org
TBR=viettrungluu
Review URL: https://codereview.chromium.org/184563006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Move into base/numerics subdirectory.
* Rename files for clarity.
* Add owners.
* Rename checked_numeric_cast to checked_cast.
* Fixup callsites and include paths.
BUG=332611
R=brettw@chromium.org, jam@chromium.org
Review URL: https://codereview.chromium.org/141113003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
First part of a two sided change. kNotEmbeddable_Font is going away in favor of an explicit flag to represent it. This change preserves existing functionality/operation and just changes the constant being used.
BUG=NONE
Review URL: https://codereview.chromium.org/105433003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It is incorrect to wrap close in HANDLE_EINTR on Linux. Correctness is
generally undefined on Mac, but as of r223369, it is incorrect in Chrome on
Mac.
To avoid new offenders, a PRESUBMIT check ensures that HANDLE_EINTR is not
used with close, and that IGNORE_EINTR is only used with close. Unnecessary
#includes of eintr_wrapper.h are also removed.
base/posix/einter_wrapper.h, PRESUBMIT.py, and ppapi/tests/test_broker.cc
contain non-mechanical changes. Variable naming within the latter is updated
per r178174. Missing #includes for <errno.h> in
content/zygote/zygote_main_linux.cc and tools/android/common/daemon.cc were
manually added. Mechanical changes were generated by running:
sed -E -i '' \
-e 's/((=|if|return|CHECK|EXPECT|ASSERT).*)HANDLE(_EINTR\(.*close)/\1IGNORE\3/' \
-e 's/(ignore_result|void ?)\(HANDLE_EINTR\((.*close\(.*)\)\)/\2/' \
-e 's/(\(void\) ?)?HANDLE_EINTR\((.*close\(.*)\)/\2/' \
$(git grep -El 'HANDLE_EINTR.*close')
sed -E -i '' -e '/#include.*eintr_wrapper\.h"/d' \
$(grep -EL '(HANDLE|IGNORE)_EINTR' \
$(git grep -El '#include.*eintr_wrapper\.h"'))
BUG=269623
R=agl@chromium.org, jln@chromium.org
TBR=OWNERS
Review URL: https://codereview.chromium.org/100253002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
SkBitmapDevice. Right now Skia has typedefs redirecting SkBaseDevice and SkBitmapDevice to SkDevice. This CL begins the Chromium-side renaming process in preparation for the real change (https://codereview.chromium.org/22978012/)
BUG=278148
Review URL: https://chromiumcodereview.appspot.com/22796028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Adds PrintingContext implementation stub for Android.
BUG=147070
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/22999026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Remove forwarding header
BUG=
R=avi@chromium.org
Review URL: https://codereview.chromium.org/16667019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For consistency and sanity in Chromium, only use skia::RefPtr in Chromium to
ref count skia classes. SkRefPtr is unsafe to use for newly created objects
because it refs the object that is passed to its constructor. skia::RefPtr
makes this adoption explicit it via skia::AdoptRef and so is much clearer.
This patch also adds a skia::ShareRef function which makes it explicit that the
callsite is adopting a ref which is already owned somewhere else. Using
AdoptRef vs. ShareRef seems much clearer than using SkRefPtr vs. skia::RefPtr.
These are the remaining code sites that use internal Skia reference counted
classes. Once these have been removed, then we can use a PRESUBMIT rule to
prevent new uses from being added.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/15004024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/12217101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Just adds some safe casts for the integer conversions.
BUG=166496
TBR=thestig@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11953003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/11366229
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10702144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the destination page.
BUG=93303,132922
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/10560021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
No intended behavior change.
BUG=none
TEST=none
TBR=hans
Review URL: https://chromiumcodereview.appspot.com/10383207
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bug was fixed in skia r3499, which we've now rolled past.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/9858031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/9834048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
private."
This reverts r128408
tbr=thakis@chromium.org
BUG=NONE
TEST=NONE
Review URL: https://chromiumcodereview.appspot.com/9835042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=thakis
BUG=NONE
TEST=NONE
Review URL: https://chromiumcodereview.appspot.com/9792001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8334007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PlatformDevice is now a base interface, which is implemented by the various flavours of BitmapPlatformDevice, and VectorPlatformDevice. The BitmapPlatformDevice and VectorPlatformDevice classes now inherit directly from SkDevice, or SkPDFDevice, as appropriate.
PlatformDevice helper functions access the PlatformDevice interface attached to a SkDevice via meta-data on the SkDevice.
BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98230
Review URL: http://codereview.chromium.org/7633040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PlatformDevice is now a base interface, which is implemented by the various flavours of BitmapPlatformDevice, and VectorPlatformDevice. The BitmapPlatformDevice and VectorPlatformDevice classes now inherit directly from SkDevice, or SkPDFDevice, as appropriate.
PlatformDevice helper functions access the PlatformDevice interface attached to a SkDevice via meta-data on the SkDevice.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7633040
TBR=twiz@chromium.org,jbates@chromium.org, dpolukhin@chromium.org, sanjeevr@chromium.org
Review URL: http://codereview.chromium.org/7754001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
PlatformDevice is now a base interface, which is implemented by the various flavours of BitmapPlatformDevice, and VectorPlatformDevice. The BitmapPlatformDevice and VectorPlatformDevice classes now inherit directly from SkDevice, or SkPDFDevice, as appropriate.
PlatformDevice helper functions access the PlatformDevice interface attached to a SkDevice via meta-data on the SkDevice.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7633040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and |page_slot| from PrintMsg_PrintPage_Params.
We will not add preview pages to the complete metafile in out of order fashion.
BUG=none
TEST=print preview works after code changes.
Review URL: http://codereview.chromium.org/7549001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will let us add pages to a metafile out of order for print preview.
Also, make PdfMetafileSkia::GetMetafileForCurrentPage use draft mode, now that it's available.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/7481019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93763 0039d316-1c4b-4281-b951-d872f2087c98
|