| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:1 of https://codereview.chromium.org/1697183002/ )
Reason for revert:
Unreverting since this patch turned out to be innocent.
Original issue's description:
> Revert of Cleanup: Remove unused PrintSettings shrink factors. (patchset #1 id:1 of https://codereview.chromium.org/1676953003/ )
>
> Reason for revert:
> Seems to break printing WebKit Linux MSAN (test times out): https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/8511
>
> Original issue's description:
> > Cleanup: Remove unused PrintSettings shrink factors.
> >
> > - They have been unused for 7 years.
> > - The copy that is being used eventually moved to
> > third_party/WebKit/Source/core/page/PrintContext.cpp.
> >
> > Committed: https://crrev.com/5e8544fc5972711c5237e3bcd8c018a0b439f4f1
> > Cr-Commit-Position: refs/heads/master@{#374553}
>
> TBR=vitalybuka@chromium.org,tsepez@chromium.org,thestig@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
TBR=vitalybuka@chromium.org,tsepez@chromium.org,thestig@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1701703003
Cr-Commit-Position: refs/heads/master@{#375543}
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:1 of https://codereview.chromium.org/1676953003/ )
Reason for revert:
Seems to break printing WebKit Linux MSAN (test times out): https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/8511
Original issue's description:
> Cleanup: Remove unused PrintSettings shrink factors.
>
> - They have been unused for 7 years.
> - The copy that is being used eventually moved to
> third_party/WebKit/Source/core/page/PrintContext.cpp.
>
> Committed: https://crrev.com/5e8544fc5972711c5237e3bcd8c018a0b439f4f1
> Cr-Commit-Position: refs/heads/master@{#374553}
TBR=vitalybuka@chromium.org,tsepez@chromium.org,thestig@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
Review URL: https://codereview.chromium.org/1697183002
Cr-Commit-Position: refs/heads/master@{#375464}
|
| |
|
|
|
|
|
|
|
|
| |
- They have been unused for 7 years.
- The copy that is being used eventually moved to
third_party/WebKit/Source/core/page/PrintContext.cpp.
Review URL: https://codereview.chromium.org/1676953003
Cr-Commit-Position: refs/heads/master@{#374553}
|
| |
|
|
|
|
|
|
|
| |
BUG=138542
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1544623002
Cr-Commit-Position: refs/heads/master@{#366463}
|
|
|
* Renamed print_settings_initializer.* into print_settings_conversion.*
* Dump on FILE thread.
* Added PrintSettingsToJobSettingsDebug to dump PrintSettings.
* Added PrintedDocument::CreateDebugDumpPath for consistent dump file naming.
* Dump PDFs received from renderer process.
* Moved GetCustomMarginsFromJobSettings into print_settings_conversion.cc.
* Moved Parsing PageRanges into print_settings_conversion.*
BUG=379961
Review URL: https://codereview.chromium.org/329683002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276716 0039d316-1c4b-4281-b951-d872f2087c98
|
