summaryrefslogtreecommitdiffstats
path: root/remoting/base
Commit message (Collapse)AuthorAgeFilesLines
* Wait for all writes to complete before starting TLS in XmppSignalStrategysergeyu2015-06-122-20/+3
| | | | | | | | | | | | | | | | When connecting XMPP socket the client sends <starttls> to the server, waits for <proceed> response and starts TLS after that. In some cases the first write for <starttls> may complete asynchronously, while the <proceed> is received sychronously, which results in SSL initialization on a socket with a pending write request. XmppSignalStrategy wasn't handling that case correctly. Fixed it to keep track of pending write requests and start TLS only after all write requests are finished. BUG=499019 Review URL: https://codereview.chromium.org/1177323003 Cr-Commit-Position: refs/heads/master@{#334246}
* remoting: Migrate callers of message_loop_proxy() to task_runner()skyostil2015-06-123-4/+4
| | | | | | | | | | | | Migrate callers of {MessageLoop,Thread}::message_loop_proxy() to {MessageLoop,Thread}::task_runner(). Since the types at the call sites have already been updated, this is just a bulk rename. BUG=465354 Review URL: https://codereview.chromium.org/1181213004 Cr-Commit-Position: refs/heads/master@{#334212}
* Chromium changes to statically link ffmpeg.chcunningham2015-06-091-2/+2
| | | | | | | | | | | | | | | | | | | | Motivations: 1. Eliminates a large number of windows crashes hit while loading the DLL (see bugs) 2. Reducing the size of binary (about 400KB on linux, about 265KB on 32bit windows) due to dead-code elimination 3. Simplifying media library initialization (Remove bool-ness, it just works) Licensing: We've audited all the licenses for the files we actually use and have the green light from legal as long as we include the license text in the credits. BUG=435455, 429131, 441908 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/bfef6d6ba82b172ac0e48c80d9ccf1a1ca0ea5c5 Cr-Commit-Position: refs/heads/master@{#332891} Review URL: https://codereview.chromium.org/1141703002 Cr-Commit-Position: refs/heads/master@{#333423}
* Revert "Chromium changes to statically link ffmpeg."chcunningham2015-06-051-2/+2
| | | | | | | | | | | | | | | | Reverting because of component test failures around isolate expectations. This change may not actually be directly responsible, but I'm out of time to investigate for the day. Will re-land it soon. BUG=496975 TBR=enne@chromium.org, gunsch@chromium.org, jochen@chromium.org, isherman@chromium.org, thomasvl@chromium.org, phajdan@chromium.org, grt@chromium.org, mmoss@chromium.org, sergeyu@chromium.org, sky@chromium.org, dalecurtis@chromium.org This reverts commit bfef6d6ba82b172ac0e48c80d9ccf1a1ca0ea5c5. NOPRESUBMIT=true NOTRY=true Review URL: https://codereview.chromium.org/1161183003 Cr-Commit-Position: refs/heads/master@{#332994}
* Chromium changes to statically link ffmpeg.chcunningham2015-06-041-2/+2
| | | | | | | | | | | | | | | | | Motivations: 1. Eliminates a large number of windows crashes hit while loading the DLL (see bugs) 2. Reducing the size of binary (about 400KB on linux, about 265KB on 32bit windows) due to dead-code elimination 3. Simplifying media library initialization (Remove bool-ness, it just works) Licensing: We've audited all the licenses for the files we actually use and have the green light from legal as long as we include the license text in the credits. BUG=435455, 429131, 441908 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1141703002 Cr-Commit-Position: refs/heads/master@{#332891}
* Convert JsonWriter::Write to taking a const ref for the in-paramestade2015-05-161-1/+1
| | | | | | | | | | | | Clearer API; flushes out a lot of unnecessary heap allocations. depends on https://codereview.chromium.org/1129083003/ BUG=none Review URL: https://codereview.chromium.org/1131113004 Cr-Commit-Position: refs/heads/master@{#330255}
* Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProviderrch2015-05-151-0/+8
| | | | | | | | | | | | | | | | | | | | so that all provider subclasses can have their state verified. Committed: https://crrev.com/bce10d97d6fc5233071427cf622aaad7abde9e19 Cr-Commit-Position: refs/heads/master@{#328154} Committed: https://crrev.com/269875cf0d23881a7ad119bae730ff54fdd4dd0b Cr-Commit-Position: refs/heads/master@{#328351} Committed: https://crrev.com/d833a674a5e4f3b4e47f229b3d5411a8d509c2c0 Cr-Commit-Position: refs/heads/master@{#328909} Committed: https://crrev.com/1d6f67fe72b4a9ae94fcb0a6e051d803a180bde1 Cr-Commit-Position: refs/heads/master@{#329003} Review URL: https://codereview.chromium.org/1114383003 Cr-Commit-Position: refs/heads/master@{#330139}
* Revert of Add AllReadDataConsumed and AllWriteDataConsumed methods to ↵rch2015-05-081-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | SocketDataProvider (patchset #6 id:100001 of https://codereview.chromium.org/1114383003/) Reason for revert: Even adding methods which are not called breaks this bot. How in the hell is this possible? http://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/builds/26579 http://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/builds/26579/steps/net_unittests%20%28iPhone%205%20iOS%208.1%29/logs/stdio Original issue's description: > Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider > so that all provider subclasses can have their state verified. > > Committed: https://crrev.com/bce10d97d6fc5233071427cf622aaad7abde9e19 > Cr-Commit-Position: refs/heads/master@{#328154} > > Committed: https://crrev.com/269875cf0d23881a7ad119bae730ff54fdd4dd0b > Cr-Commit-Position: refs/heads/master@{#328351} > > Committed: https://crrev.com/d833a674a5e4f3b4e47f229b3d5411a8d509c2c0 > Cr-Commit-Position: refs/heads/master@{#328909} > > Committed: https://crrev.com/1d6f67fe72b4a9ae94fcb0a6e051d803a180bde1 > Cr-Commit-Position: refs/heads/master@{#329003} TBR=rtenneti@chromium.org,sergeyu@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1126113003 Cr-Commit-Position: refs/heads/master@{#329015}
* Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProviderrch2015-05-081-0/+8
| | | | | | | | | | | | | | | | | so that all provider subclasses can have their state verified. Committed: https://crrev.com/bce10d97d6fc5233071427cf622aaad7abde9e19 Cr-Commit-Position: refs/heads/master@{#328154} Committed: https://crrev.com/269875cf0d23881a7ad119bae730ff54fdd4dd0b Cr-Commit-Position: refs/heads/master@{#328351} Committed: https://crrev.com/d833a674a5e4f3b4e47f229b3d5411a8d509c2c0 Cr-Commit-Position: refs/heads/master@{#328909} Review URL: https://codereview.chromium.org/1114383003 Cr-Commit-Position: refs/heads/master@{#329003}
* Revert of Add AllReadDataConsumed and AllWriteDataConsumed methods to ↵rch2015-05-081-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | SocketDataProvider (patchset #5 id:80001 of https://codereview.chromium.org/1114383003/) Reason for revert: Even this revised patch seems to break on iOS. http://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/builds/26548/steps/net_unittests%20%28iPhone%205%20iOS%208.1%29/logs/stdio WTF!?!?!?!!? Original issue's description: > Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider > so that all provider subclasses can have their state verified. > > Committed: https://crrev.com/bce10d97d6fc5233071427cf622aaad7abde9e19 > Cr-Commit-Position: refs/heads/master@{#328154} > > Committed: https://crrev.com/269875cf0d23881a7ad119bae730ff54fdd4dd0b > Cr-Commit-Position: refs/heads/master@{#328351} > > Committed: https://crrev.com/d833a674a5e4f3b4e47f229b3d5411a8d509c2c0 > Cr-Commit-Position: refs/heads/master@{#328909} TBR=rtenneti@chromium.org,sergeyu@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1123383004 Cr-Commit-Position: refs/heads/master@{#328922}
* Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProviderrch2015-05-081-0/+8
| | | | | | | | | | | | | | so that all provider subclasses can have their state verified. Committed: https://crrev.com/bce10d97d6fc5233071427cf622aaad7abde9e19 Cr-Commit-Position: refs/heads/master@{#328154} Committed: https://crrev.com/269875cf0d23881a7ad119bae730ff54fdd4dd0b Cr-Commit-Position: refs/heads/master@{#328351} Review URL: https://codereview.chromium.org/1114383003 Cr-Commit-Position: refs/heads/master@{#328909}
* Added GCD-related information to ServiceUrls.jrw2015-05-072-1/+27
| | | | | | | | BUG=471928 Review URL: https://codereview.chromium.org/1128753002 Cr-Commit-Position: refs/heads/master@{#328867}
* GN Windows component build fixesbrettw2015-05-051-0/+4
| | | | | | | | | | | | | The main thing this fixes is the midi component. Previously midi_unittests was never compiled on any Windows component bot and the component build was all messed up. This patch makes the component build work correctly for this component. Remove installer_util_unittests.rc and its header. These seem to be autogenerated Visual Studio files. They just include the strings resource file, but GN includes the strings resource file itself by nature of the dependencies (GYP doesn't do this). CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg BUG=470212 Review URL: https://codereview.chromium.org/1121363002 Cr-Commit-Position: refs/heads/master@{#328383}
* Revert of Add AllReadDataConsumed and AllWriteDataConsumed methods to ↵piman2015-05-051-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | SocketDataProvider (patchset #4 id:60001 of https://codereview.chromium.org/1114383003/) Reason for revert: Suspected cause of IOS failure https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/builds/26420/steps/net_unittests%20%28iPhone%205%20iOS%208.1%29/logs/crash%20report%20%282015-05-05-113310%29 Original issue's description: > Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider > so that all provider subclasses can have their state verified. > > Committed: https://crrev.com/bce10d97d6fc5233071427cf622aaad7abde9e19 > Cr-Commit-Position: refs/heads/master@{#328154} > > Committed: https://crrev.com/269875cf0d23881a7ad119bae730ff54fdd4dd0b > Cr-Commit-Position: refs/heads/master@{#328351} TBR=rtenneti@chromium.org,sergeyu@chromium.org,rch@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1114353005 Cr-Commit-Position: refs/heads/master@{#328375}
* Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProviderrch2015-05-051-0/+8
| | | | | | | | | | | so that all provider subclasses can have their state verified. Committed: https://crrev.com/bce10d97d6fc5233071427cf622aaad7abde9e19 Cr-Commit-Position: refs/heads/master@{#328154} Review URL: https://codereview.chromium.org/1114383003 Cr-Commit-Position: refs/heads/master@{#328351}
* Revert of Add AllReadDataConsumed and AllWriteDataConsumed methods to ↵dbeam2015-05-051-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | SocketDataProvider (patchset #3 id:40001 of https://codereview.chromium.org/1114383003/) Reason for revert: Final stop on the revert train! net_unittests on iOS Simulator (dbg) (iPhone 5 ios 8.1) should be fixed after this? https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_(dbg) Here's a log of the break: https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/builds/26378/steps/net_unittests%20%28iPhone%205%20iOS%208.1%29/logs/crash%20report%20%282015-05-04-164655%29 Original issue's description: > Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider > so that all provider subclasses can have their state verified. > > Committed: https://crrev.com/bce10d97d6fc5233071427cf622aaad7abde9e19 > Cr-Commit-Position: refs/heads/master@{#328154} TBR=rtenneti@chromium.org,sergeyu@chromium.org,rch@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1119803006 Cr-Commit-Position: refs/heads/master@{#328271}
* Revert of Revert some other possible suspects of a 0.43% size increase of ↵dbeam2015-05-042-1/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | setup.exe: https://build.chromium.o… (patchset #1 id:1 of https://codereview.chromium.org/1124563003/) Reason for revert: Broke the compile because one of these CLs is already depended on (rch@'s bce10d97d6fc5233071427cf622aaad7abde9e19). Original issue's description: > Revert some other possible suspects of a 0.43% size increase of setup.exe: https://build.chromium.org/p/chromium/builders/Win/builds/31562 > > Revert "Add granular base::File tracing." > > This reverts commit a6e05c977096a03774e5406d63ad80c0166f9adc. > > Revert "Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider" > > This reverts commit bce10d97d6fc5233071427cf622aaad7abde9e19. > > Revert "Avoid unnecessary memory allocations at PlatformThread::SetName()" > > This reverts commit 4839a142bf95776323647c82ca9dc0725f7c4f15. > > TBR=tdresser@chromium.org > BUG=none > TEST=green sizes > > Committed: https://chromium.googlesource.com/chromium/src/+/c41830d6f55f85e2f5c8841db4b6ed81239b671d TBR=tdresser@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Review URL: https://codereview.chromium.org/1123833003 Cr-Commit-Position: refs/heads/master@{#328207}
* Revert of Add AllReadDataConsumed and AllWriteDataConsumed methods to ↵dbeam2015-05-041-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | SocketDataProvider so that all provider… (patchset #1 id:1 of https://codereview.chromium.org/1127623003/) Reason for revert: Still not compiling. Order-dependent revert fun to ensue. End result: this CL and any dependent CL will be re-instated. Original issue's description: > Re-instating r328154 because it's depended on to compile. > > Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider so that all provider subclasses can have their state verified. > > Review URL: https://codereview.chromium.org/1114383003 > > Cr-Commit-Position: refs/heads/master@{#328154} > > TBR=rch@chromium.org > BUG= > > Committed: https://chromium.googlesource.com/chromium/src/+/2b2149aa9dfc5fbbb4ef0df2b89b5f392383f41a TBR=rch@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1123643006 Cr-Commit-Position: refs/heads/master@{#328206}
* Re-instating r328154 because it's depended on to compile.Dan Beam2015-05-041-0/+8
| | | | | | | | | | | | | | | Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider so that all provider subclasses can have their state verified. Review URL: https://codereview.chromium.org/1114383003 Cr-Commit-Position: refs/heads/master@{#328154} TBR=rch@chromium.org BUG= Review URL: https://codereview.chromium.org/1127623003 Cr-Commit-Position: refs/heads/master@{#328205}
* Revert some other possible suspects of a 0.43% size increase of setup.exe: ↵Dan Beam2015-05-042-9/+1
| | | | | | | | | | | | | | | | | | | | | | | | https://build.chromium.org/p/chromium/builders/Win/builds/31562 Revert "Add granular base::File tracing." This reverts commit a6e05c977096a03774e5406d63ad80c0166f9adc. Revert "Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider" This reverts commit bce10d97d6fc5233071427cf622aaad7abde9e19. Revert "Avoid unnecessary memory allocations at PlatformThread::SetName()" This reverts commit 4839a142bf95776323647c82ca9dc0725f7c4f15. TBR=tdresser@chromium.org BUG=none TEST=green sizes Review URL: https://codereview.chromium.org/1124563003 Cr-Commit-Position: refs/heads/master@{#328199}
* Avoid unnecessary memory allocations at PlatformThread::SetName()mikhail.pozdnyakov2015-05-041-1/+1
| | | | | | | | | | | | | | The PlatformThread::SetName() method used to accept 'name' parameter as 'const char*' even though all the clients stored as 'std::string' and thus had to convert, further inside PlatformThread::SetName() it was converted back to 'std::string' (when passing to ThreadIdNameManager::SetName()) leading to unnecessary memory allocations. See also: https://groups.google.com/a/chromium.org/forum/#!msg/chromium-dev/EUqoIz2iFU4/kPZ5ZK0K3gEJ Review URL: https://codereview.chromium.org/1093223007 Cr-Commit-Position: refs/heads/master@{#328157}
* Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProviderrch2015-05-041-0/+8
| | | | | | | | so that all provider subclasses can have their state verified. Review URL: https://codereview.chromium.org/1114383003 Cr-Commit-Position: refs/heads/master@{#328154}
* Pass file task runner to net::URLRequestContextBuildersergeyu2015-04-272-1/+4
| | | | | | | | | | | This avoids creation of an extra file thread in BasicURLRequestContext and fixes linked bug BUG=475213 Review URL: https://codereview.chromium.org/1082803004 Cr-Commit-Position: refs/heads/master@{#327082}
* Update {virtual,override} to follow C++11 style in remoting.nick2015-04-231-2/+2
| | | | | | | | | | | | The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was manually generated using a regex and a text editor. BUG=417463 Review URL: https://codereview.chromium.org/1101033002 Cr-Commit-Position: refs/heads/master@{#326582}
* Refactor NetLog::LogLevel --> NetLogCaptureMode.eroman2015-04-231-1/+2
| | | | | | | | | | | | | This is both a rename, and a functional change. Before LogLevel was an enum, and consumers would compare its numeric value, or use it for serialization purposes. Whereas NetLogCaptureMode is a class that encapsulates the various capabilities for a logging level. BUG=472710 TBR=asanka@chromium.org,sergeyu@chromium.org,yurys@chromium.org,bengr@chromium.org,asargent@chromium.org,zea@chromium.org,scherkus@chromium.org Review URL: https://codereview.chromium.org/1059843002 Cr-Commit-Position: refs/heads/master@{#326440}
* Windows GN tests, webcrypto warningsbrettw2015-04-211-1/+22
| | | | | | | | | | | | | | Enables many GN Windows tests. The GN build wasn't disabling the size_t to int warning in webcrypto. I decided to fix the warnings rather than disable them. This code is a random mishmash of size_t, int, unsigned, and long (partially due to third party code). In this change, I tried to do something minimal and clear: some variables were changed to size_t, while some were converted to casts. CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg TBR=dpranke Review URL: https://codereview.chromium.org/1091293003 Cr-Commit-Position: refs/heads/master@{#326046}
* Rename SocketDataProvider::GetNextRead() to OnRead()rch2015-04-141-1/+1
| | | | | | | | | which makes it parallel to OnWrite(). It also makes it clear that it is handling the read and not simply returning the next available read. Review URL: https://codereview.chromium.org/1081713002 Cr-Commit-Position: refs/heads/master@{#325095}
* Rename NetLog's Add/Remove observer methods to indicate they are deprecated.eroman2015-04-031-2/+2
| | | | | | | | | BUG=472693 TBR=kalman@chromium.org,yurys@chromium.org, scherkus@chromium.org,sergeyu@chromium.org Review URL: https://codereview.chromium.org/1052993008 Cr-Commit-Position: refs/heads/master@{#323762}
* Update remaining code to include NetLog files from net/log directory rather ↵eroman2015-04-021-1/+1
| | | | | | | | | | | | | than net/base. (Some files in net/base got moved to net/log) BUG=434856 TBR=armansito@chromium.org,jam@chromium.org Review URL: https://codereview.chromium.org/1050923005 Cr-Commit-Position: refs/heads/master@{#323525}
* Use port 5222 for XMPP connection from Me2Me host.sergeyu2015-03-182-4/+13
| | | | | | | | | | | | Connection on port 443 may be redirected through proxy. Proxied connections do not work in the service process (see bug 467960). This is a temporary workaround for that issue. BUG=464044,467960 Review URL: https://codereview.chromium.org/1015853002 Cr-Commit-Position: refs/heads/master@{#321042}
* Add remoting and PPAPI tests to GN buildbrettw2015-03-041-9/+41
| | | | | | | | | Reland of https://codereview.chromium.org/961323004 TBR=dpranke Review URL: https://codereview.chromium.org/969173002 Cr-Commit-Position: refs/heads/master@{#319080}
* Revert of Add remoting and PPAPI tests to GN build (patchset #6 id:100001 of ↵cpu2015-03-021-39/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/961323004/) Reason for revert: broke windows GN builds as seen in http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/5206/steps/compile/logs/stdio Original issue's description: > Add remoting and PPAPI tests to GN build > > Reland of https://codereview.chromium.org/965633002/ > > TBR=dpranke > > Committed: https://crrev.com/66c53eef76f7dff97b1bc76d51740c3a9c07844f > Cr-Commit-Position: refs/heads/master@{#318756} TBR=dpranke@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/968243004 Cr-Commit-Position: refs/heads/master@{#318772}
* Add remoting and PPAPI tests to GN buildbrettw2015-03-021-9/+39
| | | | | | | | | | Reland of https://codereview.chromium.org/965633002/ TBR=dpranke Review URL: https://codereview.chromium.org/961323004 Cr-Commit-Position: refs/heads/master@{#318756}
* Remove ClientLogin support from remoting hostsergeyu2015-03-025-97/+0
| | | | | | | | | | | All hosts should be using OAuth2 now, so ClientLogin support can be removed. BUG=446646,83897 Review URL: https://codereview.chromium.org/959033004 Cr-Commit-Position: refs/heads/master@{#318716}
* Revert of Add remoting and PPAPI tests to GN build (patchset #7 id:120001 of ↵eroman2015-02-271-40/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/965633002/) Reason for revert: http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%20GN&number=4498 ERROR at //remoting/host/BUILD.gn:56:7: Item not found "linux/x_server_clipboard.cc", ^---------------------------- You were trying to remove "linux/x_server_clipboard.cc" Original issue's description: > Add remoting and PPAPI tests to GN build > > BUG= > > Committed: https://crrev.com/d0437210926b14b1b7e06b2b56174fc92ade9c37 > Cr-Commit-Position: refs/heads/master@{#318539} TBR=kelvinp@chromium.org,dpranke@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/970443002 Cr-Commit-Position: refs/heads/master@{#318545}
* Add remoting and PPAPI tests to GN buildbrettw2015-02-271-9/+40
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/965633002 Cr-Commit-Position: refs/heads/master@{#318539}
* Move BufferedSocketWriter from remoting/protocol to remoting/basesergeyu2015-02-263-0/+590
| | | | | | | | | | Currently BufferedSocketWriter is in remoting/protocol and cannot be used in remoting/signaling. Also cleaned up the tests to remove dependency on remoting/protocol. Review URL: https://codereview.chromium.org/954973004 Cr-Commit-Position: refs/heads/master@{#318256}
* replace COMPILE_ASSERT with static_assert in remoting/mostynb2015-01-052-4/+4
| | | | | | | | BUG=442514 Review URL: https://codereview.chromium.org/824383002 Cr-Commit-Position: refs/heads/master@{#309982}
* Use port 443 for XMPP connections in remoting hostsergeyu2014-12-181-1/+1
| | | | | | | | | | | | | | | 1. Updated XmppSignalStrategy to handle the case when connecting over https port. 2. Changed default port used by the host to 443. 3. For It2Me host added code that switches to port 443 even when 5222 is requested. Webapp cannot be updated for compatibility with older hosts that don't have (1). BUG=443384 Review URL: https://codereview.chromium.org/797843004 Cr-Commit-Position: refs/heads/master@{#309043}
* gn format // (the rest, except mojo)scottmg2014-12-031-8/+5
| | | | | | | | | | | | | | Excluded mojo because I think that needs to happen on the other side. At gn --version = 306668 for which roll is in CQ. R=brettw@chromium.org TBR=scherkus@chromium.org BUG=348474 Review URL: https://codereview.chromium.org/774353003 Cr-Commit-Position: refs/heads/master@{#306708}
* Share sources between GYP and GN in remotingkelvinp2014-11-131-61/+8
| | | | | | | | | | | | | | | | This CL modifies the BUILD.gn files under remoting/base, remoting/protocol, remoting/client and remoting/plugin to read their sources from remoting_srcs.gypi, which is shared with GYP. This cleanup is necessary to keep the two projection generation paradigms in sync. Review URL: https://codereview.chromium.org/721073002 Cr-Commit-Position: refs/heads/master@{#304057}
* Remove implicit conversions from scoped_refptr to T* in remoting/dcheng2014-11-131-2/+2
| | | | | | | | | | | This patch was generated by running the rewrite_scoped_refptr clang tool on a Windows build. BUG=110610 Review URL: https://codereview.chromium.org/719353002 Cr-Commit-Position: refs/heads/master@{#303951}
* Standardize usage of virtual/override/final specifiers.dcheng2014-10-283-9/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=dcaiafa@chromium.org Review URL: https://codereview.chromium.org/660803004 Cr-Commit-Position: refs/heads/master@{#301539}
* Standardize usage of virtual/override/final in remoting/dcheng2014-10-217-34/+30
| | | | | | | | | | | | This patch was automatically generated by applying clang fixit hints generated by the plugin to the source tree. BUG=417463 TBR=jamiewalch@chromium.org Review URL: https://codereview.chromium.org/667123002 Cr-Commit-Position: refs/heads/master@{#300472}
* replace OVERRIDE and FINAL with override and final in remoting/mostynb2014-10-089-19/+19
| | | | | | | | BUG=417463 Review URL: https://codereview.chromium.org/628753002 Cr-Commit-Position: refs/heads/master@{#298734}
* Link VPX into GN build more.Brett Wilson2014-09-261-2/+1
| | | | | | | | | | These cases were commented out (VPX used to not work). They should now match the GYP build. I think these deps aren't strictly necessary because dependent targets link vpx in, but it's a good idea to match GYP, and I think this will make the header checker happier. R=jamesr@chromium.org Review URL: https://codereview.chromium.org/610703002 Cr-Commit-Position: refs/heads/master@{#297039}
* Replace forward_dependent_configs with public_depsBrett Wilson2014-09-231-10/+6
| | | | | | | | | | | | This is the new name. It has the same meaning but additionally with a "you can use the headers" permission. Rename direct_dependent_configs to public_configs. This is the new name with identical meaning. TBR=jamesr Review URL: https://codereview.chromium.org/595073002 Cr-Commit-Position: refs/heads/master@{#296302}
* Generalize crypto::SignatureCreator to allow choice of hash function, so as ↵dougsteed2014-09-191-1/+2
| | | | | | | | | | | | | | to support SHA256 (not just SHA1). BUG=412531 R=rsleevi@chromium.org,davidben@chromium.org TBR=pfeldman@chromium.org Review URL: https://codereview.chromium.org/560583002 Cr-Commit-Position: refs/heads/master@{#295747}
* Remove some rtc hacks in the GN build.Brett Wilson2014-09-111-5/+0
| | | | | | | | | | | Remove explicitly depending on a webrtc config now that it is correctly exported from webrtc. R=kjellander@chromium.org Review URL: https://codereview.chromium.org/534813002 Cr-Commit-Position: refs/heads/master@{#294424}
* Use ProxyConfigServiceLinux in the chromoting host to configure proxy.Sergey Ulanov2014-09-062-70/+13
| | | | | | | | | | | | | Previously chromoting host wasn't using proxies on linux because ProxyConfigServiceLinux doesn't work in NPAPI plugins. Now it's not a problem because we no longer support NPAPI. BUG=410521,125104 R=jamiewalch@chromium.org, mmenke@chromium.org Review URL: https://codereview.chromium.org/542473002 Cr-Commit-Position: refs/heads/master@{#293602}
generated by cgit v1.1 at 2025-01-30 19:37:42 +0000