summaryrefslogtreecommitdiffstats
path: root/remoting/base
Commit message (Collapse)AuthorAgeFilesLines
* Add explicit dependency on //url in remoting/baseSergey Ulanov2016-03-241-0/+1
| | | | | | | | | | | remoting_base uses GURL, but didn't have explicit dependency on //url. BUG=597559 TBR=lambroslambrou@chromium.org Review URL: https://codereview.chromium.org/1833733002 . Cr-Commit-Position: refs/heads/master@{#383114}
* Move ServiceUrls to remoting/hostsergeyu2016-03-243-158/+0
| | | | | | | | | | | | ServiceUrls was used only in one place in android client and it's not really useful there. Moved it to the host directory. Committed: https://crrev.com/2a2656a67bd2ce190df4d918f609bdb4449a64fe Cr-Commit-Position: refs/heads/master@{#382939} Review URL: https://codereview.chromium.org/1817573003 Cr-Commit-Position: refs/heads/master@{#383105}
* Revert of Move ServiceUrls to remoting/host (patchset #4 id:80001 of ↵aberent2016-03-243-0/+158
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1817573003/ ) Reason for revert: Breaks downstream Android ToT builds, and hence prevents Chromium changes rolling into downstream Android builds. BUG= 597559 Original issue's description: > Move ServiceUrls to remoting/host > > ServiceUrls was used only in one place in android client and it's > not really useful there. Moved it to the host directory. > > TBR=rogerta@chromium.org > > Committed: https://crrev.com/2a2656a67bd2ce190df4d918f609bdb4449a64fe > Cr-Commit-Position: refs/heads/master@{#382939} TBR=lambroslambrou@chromium.org,rogerta@chromium.org,sergeyu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1830993002 Cr-Commit-Position: refs/heads/master@{#383060}
* Show max latency on client's status baryuweih2016-03-235-81/+129
| | | | | | | | | | | | | Will later also consider storing max latency data in server BUG=560950 Committed: https://crrev.com/e37a467453f3814a9ecb0eb6769bd7c58b61cbae Cr-Commit-Position: refs/heads/master@{#382663} Review URL: https://codereview.chromium.org/1811833002 Cr-Commit-Position: refs/heads/master@{#382957}
* Move ServiceUrls to remoting/hostsergeyu2016-03-233-158/+0
| | | | | | | | | | | ServiceUrls was used only in one place in android client and it's not really useful there. Moved it to the host directory. TBR=rogerta@chromium.org Review URL: https://codereview.chromium.org/1817573003 Cr-Commit-Position: refs/heads/master@{#382939}
* Revert of Show max latency on client's status bar (patchset #8 id:140001 of ↵newt2016-03-235-129/+81
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1811833002/ ) Reason for revert: Caused compile failure on 64-bit Android bots. See crbug.com/597155 Original issue's description: > Show max latency on client's status bar > > Will later also consider storing max latency data in server > > BUG=560950 > > Committed: https://crrev.com/e37a467453f3814a9ecb0eb6769bd7c58b61cbae > Cr-Commit-Position: refs/heads/master@{#382663} TBR=sergeyu@chromium.org,kelvinp@chromium.org,dbeam@chromium.org,yuweih@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=560950 Review URL: https://codereview.chromium.org/1817093005 Cr-Commit-Position: refs/heads/master@{#382777}
* Show max latency on client's status baryuweih2016-03-225-81/+129
| | | | | | | | | | Will later also consider storing max latency data in server BUG=560950 Review URL: https://codereview.chromium.org/1811833002 Cr-Commit-Position: refs/heads/master@{#382663}
* Enable TURN on the host when using WebRTC.sergeyu2016-03-163-43/+30
| | | | | | | | BUG=577954 Review URL: https://codereview.chromium.org/1800893002 Cr-Commit-Position: refs/heads/master@{#381520}
* Move libvpx_new to libvpxjohannkoenig2016-03-021-1/+1
| | | | | | | | | | | | | | | | The move to libvpx_new happened before M47 (landed in 2524, M47 branch was 2526): crbug.com/481034 https://codereview.chromium.org/1323333002 Clients which try to transition directly between the tree after this change and before the previous move will end up in a very broken state. Now it is 6 months later and M48 is stable so is unlikely that a client would check out the old code at all, much less try to transition directly between the two versions. Leave a compatibility layer for targets which need to be updated out of band (webrtc, libyuv) Review URL: https://codereview.chromium.org/1734613003 Cr-Commit-Position: refs/heads/master@{#378739}
* remoting: Add out-of-line copy ctors for complex classes.vmpstr2016-02-262-0/+3
| | | | | | | | | | | | | This patch adds out of line copy constructors for classes that our clang-plugin considers heavy. This is an effort to enable copy constructor checks by default. BUG=436357 R=garykac@chromium.org, dcheng@chromium.org, thakis@chromium.org Review URL: https://codereview.chromium.org/1736633002 Cr-Commit-Position: refs/heads/master@{#377988}
* Add support for POST requests in UrlRequest interfacesergeyu2016-02-183-4/+34
| | | | | | | | | | | Previously UrlRequest supported only GET request. Now it also supports POST. BUG=577954 Review URL: https://codereview.chromium.org/1710723002 Cr-Commit-Position: refs/heads/master@{#376247}
* Add remoting::UrlRequest interface with 2 implementationssergeyu2016-02-114-1/+177
| | | | | | | | | | | | | | | | | PepperPortAllocator and ChromiumPortAllocator are largely the same but use different APIs to sent HTTP requests to allocate relay session. Specifically they use pp::URLLoader and net::URLFetcher respectively. This CL adds an abstract interface for URL request with two implementations: - PepperUrlRequest - to be used in the plugin, - ChromiumUrlRequest - to be used everywhere else. BUG=577954 Review URL: https://codereview.chromium.org/1679023009 Cr-Commit-Position: refs/heads/master@{#374975}
* update obsolete code.google.com documentation linksmostynb2016-02-081-1/+1
| | | | | | | | | | | | | | | | This is a documentation-only change. Disabling presubmit checks, due to "noparent" settings for the following files: components/policy/resources/policy_templates.json content/common/font_config_ipc_linux.h BUG=567488 NOPRESUBMIT=true TBR=atwilson,dcheng Review URL: https://codereview.chromium.org/1592403002 Cr-Commit-Position: refs/heads/master@{#374213}
* Fix BufferedSocketWriter to buffer everything before it starts writing.sergeyu2016-01-143-37/+59
| | | | | | | | | | Previously BufferedSocketWriter was ignoring Write() calls before Init(). Fixed it to buffer all data in that scenario. Also renamed Init() to Start(). Review URL: https://codereview.chromium.org/1582583003 Cr-Commit-Position: refs/heads/master@{#369355}
* Use std::move() instead of .Pass() in remoting/*sergeyu2015-12-245-10/+15
| | | | | | | | | | Now there is a presubmit check that doesn't allow Pass() anymore. See https://www.chromium.org/rvalue-references for information about std::move in chromium. Review URL: https://codereview.chromium.org/1545723002 Cr-Commit-Position: refs/heads/master@{#366778}
* Switch to standard integer types in remoting/.avi2015-12-2229-32/+70
| | | | | | | | | BUG=138542 TBR=wez@chromium.org Review URL: https://codereview.chromium.org/1542203002 Cr-Commit-Position: refs/heads/master@{#366684}
* Remove QUIC support from remoting host and client.sergeyu2015-12-032-2/+0
| | | | | | Review URL: https://codereview.chromium.org/1493083002 Cr-Commit-Position: refs/heads/master@{#363013}
* Remove old C++03 move emulation code.dcheng2015-12-011-14/+6
| | | | | | | | | | | Chrome allows the use of C++11 features now, so just use rvalue references directly. BUG=543901 Review URL: https://codereview.chromium.org/1407443002 Cr-Commit-Position: refs/heads/master@{#362394}
* Use std::default_delete as the default deleter for scoped_ptr.dcheng2015-11-191-1/+3
| | | | | | | | | | | The aim is to make scoped_ptr and std::unique_ptr functionally identical so scoped_ptr can simply be a typedef. BUG=554298 Review URL: https://codereview.chromium.org/1445003002 Cr-Commit-Position: refs/heads/master@{#360539}
* Replace PluginThreadTaskRunner with a simpler MainPluginThreadTaskRunner.sergeyu2015-10-212-373/+0
| | | | | | | | | | | | PluginThreadTaskRunner was designed to work with NPAPI and PPAPI, but it's no longer necessary. Replacing it with MainPluginThreadTaskRunner that's Pepper-specific and is much simpler. BUG=544275 Review URL: https://codereview.chromium.org/1410923004 Cr-Commit-Position: refs/heads/master@{#355200}
* Don't use base::MessageLoop::{Quit,QuitClosure} in remoting/ki.stfu2015-10-124-6/+6
| | | | | | | | | | | | | This patch renames base::MessageLoop::{Quit,QuitClosure} to base::MessageLoop::{QuitWhenIdle,QuitWhenIdleClosure}. BUG=131220 TEST= R=joedow@chromium.org Review URL: https://codereview.chromium.org/1394803004 Cr-Commit-Position: refs/heads/master@{#353583}
* make ProxyService::CreateSystemProxyConfigService return scoped_ptrscsharrison2015-09-221-4/+4
| | | | | | | | | | | | | This change is fairly straightforward. I ended up refactoring ProxyServiceFactory too because it makes the resulting code much easier to reason about, so we are only making scoped pointers out of raw pointers in as few places as possible new CL to reflect Randy and Pauls changes in master BUG=523075 TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/1356933002 Cr-Commit-Position: refs/heads/master@{#350207}
* Copy libvpx from DEPS to srcjohannkoenig2015-09-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Leaves the previous version in place but updates BUILD.gn and libvpx.gn to point to the new version. This allows decoupling the WebRTC update which is also in DEPS. libvpx DEPS changes ac1772e:0d6551 https://codereview.chromium.org/1339033002 https://chromium-review.googlesource.com/299759 https://codereview.chromium.org/1350853003 https://codereview.chromium.org/1353433003 Copy directory to libvpx_new to avoid breaking bisecting. This allows the user to move between and older and newer revision. A followup to rename libvpx_new to libvpx will come in some ~months because there are additional complications if one tries to sync directly from pre-move to post-rename or the other way around. Remove WATCHLISTS and codereview.settings from _new and use the parent versions. Add DEPS file to enumerate the #include paths. Check out third_party/libvpx_new/source/libvpx directly from upstream project Update all the easy clients of libvpx to depend on the new tree directly. https://chromium.googlesource.com/chromium/deps/libvpx/+/ac1772e3db5c885b554f6a72ca9dbac4245cb0e2 BUG=481034 R=tomfinegan@chromium.org,brettw@chromium.org,phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/1323333002 Cr-Commit-Position: refs/heads/master@{#349789}
* Remove lock from remoting::RunningAveragesergeyu2015-09-182-12/+10
| | | | | | | | | The class is always used on the same thread, so it doesn't need to be thread-safe. Review URL: https://codereview.chromium.org/1351253002 Cr-Commit-Position: refs/heads/master@{#349746}
* Turn components/crash into a layered component.sdefresne2015-09-181-1/+1
| | | | | | | | | | | | | | | The crash component cannot be used on iOS (as it depends on //content). Turn it into a layered component so that it is possible to put shared code related to crash there (components/crash_keys and objc_zombie.{h,mm}). BUG=522955 TBR=sky@chromium.org TBR=jschuh@chromium.org NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1315303004 Cr-Commit-Position: refs/heads/master@{#349643}
* Revert of Turn components/crash into a layered component. (patchset #6 ↵sdefresne2015-09-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:100001 of https://codereview.chromium.org/1315303004/ ) Reason for revert: This breaks Webkit layout tests. Original issue's description: > Turn components/crash into a layered component. > > The crash component cannot be used on iOS (as it depends on //content). > Turn it into a layered component so that it is possible to put shared > code related to crash there (components/crash_keys and objc_zombie.{h,mm}). > > BUG=522955 > TBR=sky@chromium.org > TBR=jschuh@chromium.org > NOPRESUBMIT=true > > Committed: https://crrev.com/4e483c64be5136b785e92c5baa971baca7eea2bc > Cr-Commit-Position: refs/heads/master@{#349384} TBR=blundell@chromium.org,jam@chromium.org,jschuh@chromium.org,mark@chromium.org,rsesek@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=522955 Review URL: https://codereview.chromium.org/1351923002 Cr-Commit-Position: refs/heads/master@{#349417}
* Turn components/crash into a layered component.sdefresne2015-09-171-1/+1
| | | | | | | | | | | | | | | The crash component cannot be used on iOS (as it depends on //content). Turn it into a layered component so that it is possible to put shared code related to crash there (components/crash_keys and objc_zombie.{h,mm}). BUG=522955 TBR=sky@chromium.org TBR=jschuh@chromium.org NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1315303004 Cr-Commit-Position: refs/heads/master@{#349384}
* Compile remoting client plugin with GNsergeyu2015-09-141-6/+5
| | | | | | | | BUG=512899 Review URL: https://codereview.chromium.org/1312463005 Cr-Commit-Position: refs/heads/master@{#348752}
* Move Singleton and related structs to namespace baseolli.raula2015-09-102-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Public APIs from base should live inside base:: so moved Singleton class and structs to base{} and fixed consumers. also fixed: ** Presubmit ERRORS ** Found Singleton<T> in the following header files. Please move them to an appropriate source file so that the template gets instantiated in a single compilation unit. chrome/browser/plugins/plugin_finder.h \ chromecast/media/base/media_message_loop.h \ content/browser/media/android/media_drm_credential_manager.h Presubmit warnings: src/chrome/browser/extensions/warning_badge_service_factory.h:5: #ifndef header guard has wrong style, please use: CHROME_BROWSER_EXTENSIONS_WARNING_BADGE_SERVICE_FACTORY_H_ [build/header_guard] [5] src/chrome/browser/extensions/warning_badge_service_factory.h:39: #endif line should be "#endif // CHROME_BROWSER_EXTENSIONS_WARNING_BADGE_SERVICE_FACTORY_H_" [build/header_guard] [5] TBR=jam@chromium.org Review URL: https://codereview.chromium.org/1308823002 Cr-Commit-Position: refs/heads/master@{#348136}
* Make UrlRequestContextBuilder take scoped_ptr's when it takes ownershippauljensen2015-09-012-3/+6
| | | | | | | | | | | | | | | | | | UrlRequestContextBuilder was already taking ownership in most cases, so it should be taking scoped_ptr's instead of raw pointers. This change should help enforce proper ownership and has already identified two ownership bugs. I'm fixing the ownership bugs (a double-free of ProxyConfigService in Cronet and of NetLog in AwURLRequestContextGetter) in this change also. I'm changing UrlRequestContextBuilder to not take ownership of NetLog however as this conflicts with some other uses of NetLog, like how it's exposed via ContentBrowserClient. BUG=508553 TBR=jam Review URL: https://codereview.chromium.org/1303493002 Cr-Commit-Position: refs/heads/master@{#346637}
* Move remoting/base/resources* to remoting/hostsergeyu2015-08-266-179/+0
| | | | | | | | base/resources.h is used only in host, so it doesn't need to be in base. Review URL: https://codereview.chromium.org/1318773003 Cr-Commit-Position: refs/heads/master@{#345719}
* remoting: Remove dependency on YUV code in src/mediasergeyu2015-08-214-370/+9
| | | | | | | | | | libyuv is now used for YUV conversions on both ends. BUG=256850 Review URL: https://codereview.chromium.org/1290273004 Cr-Commit-Position: refs/heads/master@{#344905}
* Implement QuicChannel and QuicChannelFactorysergeyu2015-08-143-9/+7
| | | | | | | | | | | | QuicChannelFactory implements StreamChannelFactory to create channels over a QUIC connection. The new code will be hooked up in a separate CL. BUG=448838 Review URL: https://codereview.chromium.org/1273233002 Cr-Commit-Position: refs/heads/master@{#343447}
* Fix BufferedSocketWriter not to return any results from Write().sergeyu2015-07-302-7/+4
| | | | | | | | | | | | | | | | Previously BufferedSocketWriter was returning false from Write() if the write fails synchronously. That's redundant because BufferedSocketWriter also calls a callback after the failed write. This also fixes a bug in Write() - it was using is_closed() method after calling the callback, which is not allowed because the object may be deleted by the callback. That problem was found by tests added in https://codereview.chromium.org/1258323003 . The bug was introduced recently in https://codereview.chromium.org/1197853003 . Review URL: https://codereview.chromium.org/1250403003 Cr-Commit-Position: refs/heads/master@{#341229}
* Make use of '// static' consistent.ajose2015-07-281-2/+2
| | | | | | Review URL: https://codereview.chromium.org/1211973011 Cr-Commit-Position: refs/heads/master@{#340807}
* Add P2PDatagramSocket and P2PStreamSocket interfaces.sergeyu2015-07-203-250/+116
| | | | | | | | | | | | | | | | Previously remoting code was using net::Socket and net::StreamSocket for datagram and stream socket. Problem is that net::StreamSocket interface contains a lot of methods that are not relevant for peer-to-peer connections in remoting. Added P2PDatagramSocket and P2PStreamSocket interfaces independent of net::Socket. This allowed to remove a lot of the redundant code needed for net::StreamSocket implementations. There are two new adapters required in SslHmacChannelAuthenticator for the SSL layer, but these won't be necessary after we migrate to QUIC. Review URL: https://codereview.chromium.org/1197853003 Cr-Commit-Position: refs/heads/master@{#339489}
* Pull buildtools to get GN 338735.brettw2015-07-171-1/+0
| | | | | | | | | | Fix duplicate source file in removing/base/BUILD.gn TBR=dpranke@chromium.org Review URL: https://codereview.chromium.org/1242523003 Cr-Commit-Position: refs/heads/master@{#339182}
* Cleanup inconsistencies between GN and GYP in //remotingsergeyu2015-07-161-0/+1
| | | | | | | | | | | | | 1. GN builds were not including some tests included in GYP. 2. Replaced test_common target in gyp with test_support. 3. Removed extra *_common targets for test_driver and moved everything to test_support. 4. test_driver can be compiled using GN now. 5. Various other small cleanups. Review URL: https://codereview.chromium.org/1228283004 Cr-Commit-Position: refs/heads/master@{#339119}
* Move JoinString to the base namespace.brettw2015-07-152-3/+4
| | | | | | | | | | | | | | | | | | | | | Change "Separator" from string to StringPIece (most are constants). Remove char versions for symmetry with SplitString. Update callers who pass empty separators to use a base::StringPiece() Change chromecast/base/metrics/cast_metrics_helper.cc to not use JoinString at all and just append to the output (code is simpler and faster). TBR=zelidrag@chromium.org for chromeos Committed: https://crrev.com/0eabfa001ba06d3c66992b95b69a988ef0633992 Cr-Commit-Position: refs/heads/master@{#338762} patch from issue 1223153003 at patchset 160001 (http://crrev.com/1223153003#ps160001) BUG= Review URL: https://codereview.chromium.org/1230243005 Cr-Commit-Position: refs/heads/master@{#338819}
* Revert of Move JoinString to the base namespace (patchset #9 id:160001 of ↵hongchan2015-07-142-4/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1223153003/) Reason for revert: The compilation failure with the following error message: FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/chrome/common/common.chrome_content_client.o.d -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DGOOGLE_CHROME_BUILD -DCR_CLANG_REVISION=241602-3 -DENABLE_RLZ -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DIMAGE_LOADER_EXTENSION=1 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DENABLE_TOPCHROME_MD=1 -DUSE_UDEV -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_PROD_WALLET_SERVICE=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_HANGOUT_SERVICES_EXTENSION=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DSAFE_BROWSING_SERVICE -DGL_GLEXT_PROTOTYPES -DMOJO_USE_SYSTEM_IMPL -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DSK_SUPPORT_GPU=1 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_LEGACY_SKPOINT3_CTORS -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DLIBXML_STATIC -DUSE_LIBPCI=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DOS_CHROMEOS=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNO_UNWIND_TABLES -DOFFICIAL_BUILD -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -Igen -I../.. -I../../skia/config -I../../third_party/khronos -I../../gpu -I../../third_party/WebKit/Source -Igen/protoc_out -I../../third_party/protobuf -I../../third_party/protobuf/src -Igen/chrome -I../../third_party/WebKit -I../../third_party/mojo/src -Igen/third_party/mojo/src -I../../net/third_party/nss/ssl -I../../skia/ext -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -I../../third_party/libxml/linux/include -I../../third_party/libxml/src/include -Igen/ui/resources -Igen/extensions -Igen/extensions/strings -I../../third_party/re2 -Igen/policy -Werror -pthread -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -Wno-reserved-user-defined-literal -Xclang -load -Xclang /b/build/slave/google-chrome-rel-chromeos/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -fcolor-diagnostics -g -B/b/build/slave/google-chrome-rel-chromeos/build/src/third_party/binutils/Linux_x64/Release/bin -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -Wno-inconsistent-missing-override -Wexit-time-destructors -Wno-shift-negative-value -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/nss -I/usr/include/nspr -Wno-header-guard -m64 -march=x86-64 -O2 -fno-ident -fdata-sections -ffunction-sections -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-exceptions -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -std=gnu++11 -c ../../chrome/common/chrome_content_client.cc -o obj/chrome/common/common.chrome_content_client.o ../../chrome/common/chrome_content_client.cc:193:34: error: no matching function for call to 'JoinString' std::string codec_string = base::JoinString( ^~~~~~~~~~~~~~~~ Original issue's description: > Move JoinString to the base namespace. > > Change "Separator" from string to StringPIece (most are constants). Remove char versions for symmetry with SplitString. > > Update callers who pass empty separators to use a base::StringPiece() > > Change chromecast/base/metrics/cast_metrics_helper.cc to not use JoinString at all and just append to the output (code is simpler and faster). > > TBR=zelidrag@chromium.org for chromeos > > Committed: https://crrev.com/0eabfa001ba06d3c66992b95b69a988ef0633992 > Cr-Commit-Position: refs/heads/master@{#338762} TBR=jam@chromium.org,zelidrag@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1237873004 Cr-Commit-Position: refs/heads/master@{#338770}
* Move JoinString to the base namespace.brettw2015-07-142-3/+4
| | | | | | | | | | | | | | Change "Separator" from string to StringPIece (most are constants). Remove char versions for symmetry with SplitString. Update callers who pass empty separators to use a base::StringPiece() Change chromecast/base/metrics/cast_metrics_helper.cc to not use JoinString at all and just append to the output (code is simpler and faster). TBR=zelidrag@chromium.org for chromeos Review URL: https://codereview.chromium.org/1223153003 Cr-Commit-Position: refs/heads/master@{#338762}
* Replace remaining Tokenize calls to SplitStringbrettw2015-07-062-13/+17
| | | | | | | | | | | | | | SplitString is now more general and does the job of Tokenize with specific parameters. The biggest change is in time_util.cc where the old return pattern better matched how the code was structured. With the new style the conditionals are more nested. Some simple cases were changed to StringPieces when copies were not required. BUG=506920, 506255 Review URL: https://codereview.chromium.org/1219263002 Cr-Commit-Position: refs/heads/master@{#337520}
* clang/win: Build without -Wno-null-dereference.sammc2015-06-301-1/+1
| | | | | | | | BUG=505300 Review URL: https://codereview.chromium.org/1216903002 Cr-Commit-Position: refs/heads/master@{#336717}
* Wait for all writes to complete before starting TLS in XmppSignalStrategysergeyu2015-06-122-20/+3
| | | | | | | | | | | | | | | | When connecting XMPP socket the client sends <starttls> to the server, waits for <proceed> response and starts TLS after that. In some cases the first write for <starttls> may complete asynchronously, while the <proceed> is received sychronously, which results in SSL initialization on a socket with a pending write request. XmppSignalStrategy wasn't handling that case correctly. Fixed it to keep track of pending write requests and start TLS only after all write requests are finished. BUG=499019 Review URL: https://codereview.chromium.org/1177323003 Cr-Commit-Position: refs/heads/master@{#334246}
* remoting: Migrate callers of message_loop_proxy() to task_runner()skyostil2015-06-123-4/+4
| | | | | | | | | | | | Migrate callers of {MessageLoop,Thread}::message_loop_proxy() to {MessageLoop,Thread}::task_runner(). Since the types at the call sites have already been updated, this is just a bulk rename. BUG=465354 Review URL: https://codereview.chromium.org/1181213004 Cr-Commit-Position: refs/heads/master@{#334212}
* Chromium changes to statically link ffmpeg.chcunningham2015-06-091-2/+2
| | | | | | | | | | | | | | | | | | | | Motivations: 1. Eliminates a large number of windows crashes hit while loading the DLL (see bugs) 2. Reducing the size of binary (about 400KB on linux, about 265KB on 32bit windows) due to dead-code elimination 3. Simplifying media library initialization (Remove bool-ness, it just works) Licensing: We've audited all the licenses for the files we actually use and have the green light from legal as long as we include the license text in the credits. BUG=435455, 429131, 441908 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/bfef6d6ba82b172ac0e48c80d9ccf1a1ca0ea5c5 Cr-Commit-Position: refs/heads/master@{#332891} Review URL: https://codereview.chromium.org/1141703002 Cr-Commit-Position: refs/heads/master@{#333423}
* Revert "Chromium changes to statically link ffmpeg."chcunningham2015-06-051-2/+2
| | | | | | | | | | | | | | | | Reverting because of component test failures around isolate expectations. This change may not actually be directly responsible, but I'm out of time to investigate for the day. Will re-land it soon. BUG=496975 TBR=enne@chromium.org, gunsch@chromium.org, jochen@chromium.org, isherman@chromium.org, thomasvl@chromium.org, phajdan@chromium.org, grt@chromium.org, mmoss@chromium.org, sergeyu@chromium.org, sky@chromium.org, dalecurtis@chromium.org This reverts commit bfef6d6ba82b172ac0e48c80d9ccf1a1ca0ea5c5. NOPRESUBMIT=true NOTRY=true Review URL: https://codereview.chromium.org/1161183003 Cr-Commit-Position: refs/heads/master@{#332994}
* Chromium changes to statically link ffmpeg.chcunningham2015-06-041-2/+2
| | | | | | | | | | | | | | | | | Motivations: 1. Eliminates a large number of windows crashes hit while loading the DLL (see bugs) 2. Reducing the size of binary (about 400KB on linux, about 265KB on 32bit windows) due to dead-code elimination 3. Simplifying media library initialization (Remove bool-ness, it just works) Licensing: We've audited all the licenses for the files we actually use and have the green light from legal as long as we include the license text in the credits. BUG=435455, 429131, 441908 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1141703002 Cr-Commit-Position: refs/heads/master@{#332891}
* Convert JsonWriter::Write to taking a const ref for the in-paramestade2015-05-161-1/+1
| | | | | | | | | | | | Clearer API; flushes out a lot of unnecessary heap allocations. depends on https://codereview.chromium.org/1129083003/ BUG=none Review URL: https://codereview.chromium.org/1131113004 Cr-Commit-Position: refs/heads/master@{#330255}
* Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProviderrch2015-05-151-0/+8
| | | | | | | | | | | | | | | | | | | | so that all provider subclasses can have their state verified. Committed: https://crrev.com/bce10d97d6fc5233071427cf622aaad7abde9e19 Cr-Commit-Position: refs/heads/master@{#328154} Committed: https://crrev.com/269875cf0d23881a7ad119bae730ff54fdd4dd0b Cr-Commit-Position: refs/heads/master@{#328351} Committed: https://crrev.com/d833a674a5e4f3b4e47f229b3d5411a8d509c2c0 Cr-Commit-Position: refs/heads/master@{#328909} Committed: https://crrev.com/1d6f67fe72b4a9ae94fcb0a6e051d803a180bde1 Cr-Commit-Position: refs/heads/master@{#329003} Review URL: https://codereview.chromium.org/1114383003 Cr-Commit-Position: refs/heads/master@{#330139}
generated by cgit v1.1 at 2024-05-17 13:53:18 +0000