| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
We no longer need to support shaped desktop, so the corresponding
code can be removed.
Review URL: https://codereview.chromium.org/1827043004
Cr-Commit-Position: refs/heads/master@{#383340}
|
|
|
|
|
|
|
|
| |
BUG=554298
Review URL: https://codereview.chromium.org/1828923004
Cr-Commit-Position: refs/heads/master@{#383315}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Trying to build this causes out-of-memory issues with the pnacl
linker, likely because it's a 32-bit tool and the GN builds are
using source_sets instead of static_libraries, causing us to
link in a lot more code before it can get gc'ed.
Disabling temporarily until I have cycles to look at this, because
it keeps `gn_all` from building.
R=brucedawson@chromium.org, mcgrathr@chromium.org, sergeyu@chromium.org
BUG=584516
Review URL: https://codereview.chromium.org/1830113004
Cr-Commit-Position: refs/heads/master@{#383191}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1827153002
Cr-Commit-Position: refs/heads/master@{#383155}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds the remaining copy constructors for complex classes.
After this patch, it should be possible to enable the heavy class copy
constructor checks by default.
R=thakis@chromium.org, dcheng@chromium.org
TBR=jam@chromium.org
BUG=436357
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1825273002
Cr-Commit-Position: refs/heads/master@{#383131}
|
|
|
|
|
|
|
|
|
|
|
| |
remoting_base uses GURL, but didn't have explicit dependency on //url.
BUG=597559
TBR=lambroslambrou@chromium.org
Review URL: https://codereview.chromium.org/1833733002 .
Cr-Commit-Position: refs/heads/master@{#383114}
|
|
|
|
|
|
|
|
|
|
|
|
| |
ServiceUrls was used only in one place in android client and it's
not really useful there. Moved it to the host directory.
Committed: https://crrev.com/2a2656a67bd2ce190df4d918f609bdb4449a64fe
Cr-Commit-Position: refs/heads/master@{#382939}
Review URL: https://codereview.chromium.org/1817573003
Cr-Commit-Position: refs/heads/master@{#383105}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1817573003/ )
Reason for revert:
Breaks downstream Android ToT builds, and hence prevents Chromium changes rolling into downstream Android builds.
BUG= 597559
Original issue's description:
> Move ServiceUrls to remoting/host
>
> ServiceUrls was used only in one place in android client and it's
> not really useful there. Moved it to the host directory.
>
> TBR=rogerta@chromium.org
>
> Committed: https://crrev.com/2a2656a67bd2ce190df4d918f609bdb4449a64fe
> Cr-Commit-Position: refs/heads/master@{#382939}
TBR=lambroslambrou@chromium.org,rogerta@chromium.org,sergeyu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1830993002
Cr-Commit-Position: refs/heads/master@{#383060}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebrtcVideoCapturerAdapter
VideoCapturer::Pause is never used in the webrtc code base.
SignalgVideoFrame should also be removed and replaced with normal method call to VideoCapturer::OnFrame.
BUG=webrtc:5426
Review URL: https://codereview.chromium.org/1745923002
Cr-Commit-Position: refs/heads/master@{#383040}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1830013002
Cr-Commit-Position: refs/heads/master@{#383022}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Will later also consider storing max latency data in server
BUG=560950
Committed: https://crrev.com/e37a467453f3814a9ecb0eb6769bd7c58b61cbae
Cr-Commit-Position: refs/heads/master@{#382663}
Review URL: https://codereview.chromium.org/1811833002
Cr-Commit-Position: refs/heads/master@{#382957}
|
|
|
|
|
|
|
|
|
|
|
| |
ServiceUrls was used only in one place in android client and it's
not really useful there. Moved it to the host directory.
TBR=rogerta@chromium.org
Review URL: https://codereview.chromium.org/1817573003
Cr-Commit-Position: refs/heads/master@{#382939}
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the Cardboard SDK shared library, reducing the size of the
APK, if remoting_enable_cardboard build flag is not set.
BUG=595027
Review URL: https://codereview.chromium.org/1829543002
Cr-Commit-Position: refs/heads/master@{#382904}
|
|
|
|
|
|
|
|
|
|
|
| |
It now wraps the last two words of the text instead of the last word
(at least on the device I tested it on).
BUG=593845
Review URL: https://codereview.chromium.org/1827713002
Cr-Commit-Position: refs/heads/master@{#382873}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1811833002/ )
Reason for revert:
Caused compile failure on 64-bit Android bots. See crbug.com/597155
Original issue's description:
> Show max latency on client's status bar
>
> Will later also consider storing max latency data in server
>
> BUG=560950
>
> Committed: https://crrev.com/e37a467453f3814a9ecb0eb6769bd7c58b61cbae
> Cr-Commit-Position: refs/heads/master@{#382663}
TBR=sergeyu@chromium.org,kelvinp@chromium.org,dbeam@chromium.org,yuweih@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=560950
Review URL: https://codereview.chromium.org/1817093005
Cr-Commit-Position: refs/heads/master@{#382777}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1826603002/ )
Reason for revert:
Caused compile failure on 64-bit Android bots. See crbug.com/597155
Original issue's description:
> Quick fix for broken JS notation
>
> Fix for issue: https://codereview.chromium.org/1811833002
>
> TBR=sergeyu@chromium.org
> BUG=
>
> Committed: https://crrev.com/bd12932cbd6656a2de7ff0a639b01364dddac013
> Cr-Commit-Position: refs/heads/master@{#382714}
TBR=sergeyu@chromium.org,lambroslambrou@chromium.org,yuweih@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/1830483002
Cr-Commit-Position: refs/heads/master@{#382776}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reland http://crrev.com/1764503002 with fixes for the Android app and
tests:
* Initialize ChromotingClientRuntime::ui_task_runner_
* Add new unittest to GN build.
* Don't call MessageLoopForUI::Start() in Android test.
TBR=nicholss
Review URL: https://codereview.chromium.org/1827573002
Cr-Commit-Position: refs/heads/master@{#382757}
|
|
|
|
|
|
|
|
|
|
|
| |
Fix for issue: https://codereview.chromium.org/1811833002
TBR=sergeyu@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1826603002
Cr-Commit-Position: refs/heads/master@{#382714}
|
|
|
|
|
|
|
|
|
|
| |
Will later also consider storing max latency data in server
BUG=560950
Review URL: https://codereview.chromium.org/1811833002
Cr-Commit-Position: refs/heads/master@{#382663}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Commit c4699f6 ("net: add IsUsingTCPFastOpen() method to SequencedSocketData
test class") removed the usage of UsingTCPFastOpen(), so now it can be
removed safely.
BUG=488598
TEST=net_unittests
R=mmenke@chromium.org
TBR=dgozman@chromium.org,sergeyu@chromium.org
Review URL: https://codereview.chromium.org/1821633003
Cr-Commit-Position: refs/heads/master@{#382604}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Attachment brokering makes the assumption that there's a single thread
on which IO related to IPC::Channels occurs. This assumption is violated
when the flag --single-process is set.
BUG=590213
Review URL: https://codereview.chromium.org/1739203004
Cr-Commit-Position: refs/heads/master@{#382431}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
#23 id:440001 of https://codereview.chromium.org/1764503002/ )
Reason for revert:
Broke Android client and tests - see bug 596240.
Original issue's description:
> Adding container class for chromoting client runtimes.
>
> R=lambroslambrou@chromium.org
>
> Committed: https://crrev.com/b34c0f6877af54e8bdd6052bf8934dd46a3b5899
> Cr-Commit-Position: refs/heads/master@{#380979}
TBR=sergeyu@chromium.org,nicholss@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
Review URL: https://codereview.chromium.org/1821623003
Cr-Commit-Position: refs/heads/master@{#382411}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebRTC 12049:12058
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/957d599..0912ecc
Libjingle 12042:12058
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/8bc093b..35814a7
TBR=jbauch@webrtc.org
BUG=
Review URL: https://codereview.chromium.org/1822473002
Cr-Commit-Position: refs/heads/master@{#382204}
|
|
|
|
|
|
|
|
|
| |
These are no longer needed, now that we are using device-based
authentication via GoogleAuthUtil from Google Play Services.
Review URL: https://codereview.chromium.org/1818673002
Cr-Commit-Position: refs/heads/master@{#382158}
|
|
|
|
|
|
|
|
|
| |
Removed all files used to build app_remoting webapp and cleaned up
build files.
Review URL: https://codereview.chromium.org/1816653002
Cr-Commit-Position: refs/heads/master@{#382147}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now the session-description messages are signed with the key generated
by the authenticators and the signature is verified by the receiver.
Verification can be disabled using --disable-authentication flag.
BUG=547158
Review URL: https://codereview.chromium.org/1815043002
Cr-Commit-Position: refs/heads/master@{#382120}
|
|
|
|
|
|
|
|
|
|
| |
third_party/webrtc/api/videosourceinterface.h has been merged with mediastreaminterface.h and will be removed.
BUG=webrtc:5426
Review URL: https://codereview.chromium.org/1810273003
Cr-Commit-Position: refs/heads/master@{#381998}
|
|
|
|
|
|
|
|
|
|
| |
It2me host can use spake2_hmac authentication method and it works
properly with the current client, so there is no reason to keep
spake2_plain for It2Me.
Review URL: https://codereview.chromium.org/1799293002
Cr-Commit-Position: refs/heads/master@{#381744}
|
|
|
|
|
|
|
|
| |
BUG=webrtc:5426
Review URL: https://codereview.chromium.org/1809623002
Cr-Commit-Position: refs/heads/master@{#381678}
|
|
|
|
|
|
|
|
| |
BUG=589698
Review URL: https://codereview.chromium.org/1800823002
Cr-Commit-Position: refs/heads/master@{#381664}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1813613002
Cr-Commit-Position: refs/heads/master@{#381637}
|
|
|
|
|
|
|
|
|
|
| |
Reduced official build size from 7.9MB to 6.4MB. Can reenable WebRTC by changing the BUILD.gn file.
BUG=595038
Review URL: https://codereview.chromium.org/1806963002
Cr-Commit-Position: refs/heads/master@{#381636}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously PairingAuthenticator classes were responsible for handling
client ID. This meant that in case there are multiple pairing
authentication methods the client would have to resend the client_id
if the host chooses different authentication method. Now the client
ID is handled by the negotiating layer, so client_id needs to be sent
only once.
Also now NegotiatingAuthenticators create PairingAuthenticators even
when falling back to PIN. This ensures that <pairing-failed> tag is
always present when falling back to PIN.
BUG=593123
Review URL: https://codereview.chromium.org/1781173005
Cr-Commit-Position: refs/heads/master@{#381633}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Spake2Authenticator requires that local_id and remote_id are the same
on both ends of the connection, so JIDs need to be normalized to avoid
issues when one of the ends gets JID in a different case.
BUG=589698
Review URL: https://codereview.chromium.org/1803893002
Cr-Commit-Position: refs/heads/master@{#381559}
|
|
|
|
|
|
|
|
| |
BUG=577954
Review URL: https://codereview.chromium.org/1800893002
Cr-Commit-Position: refs/heads/master@{#381520}
|
|
|
|
|
|
|
|
|
|
| |
This sets contentInsetStart to 72dp on phones and 80dp on tablets.
BUG=593844
Review URL: https://codereview.chromium.org/1800963002
Cr-Commit-Position: refs/heads/master@{#381324}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change introduces the IPC client class used to communicate with the
Chromoting host's network process to allow for forwarding security key
requests.
BUG=584463
Review URL: https://codereview.chromium.org/1767763002
Cr-Commit-Position: refs/heads/master@{#381117}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change adds the GnubbyAuthHandlerWin class which services IPC clients that
want to forward security key messages to the remote client. This class creates
a new RemoteSecurityKeyIpcServer instance for each client so that multiple
security key requests can be serviced simultaneously.
BUG=584463
Review URL: https://codereview.chromium.org/1765743002
Cr-Commit-Position: refs/heads/master@{#381077}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change introduces the IPC Server class used to communicate with the
remote_security_key process for SK forwarding. It also includes unit
tests and some facilities that will be used in the subsequent change
which will implement the GnubbyAuthHandlerWin class.
BUG=584463
Review URL: https://codereview.chromium.org/1757873003
Cr-Commit-Position: refs/heads/master@{#381054}
|
|
|
|
|
|
|
|
| |
R=lambroslambrou@chromium.org
Review URL: https://codereview.chromium.org/1764503002
Cr-Commit-Position: refs/heads/master@{#380979}
|
|
|
|
|
|
|
|
|
|
|
| |
Moved ClientAuthenticationConfig to a separate file and now it's used
in PairingClientAuthenticator.
BUG=593123
Review URL: https://codereview.chromium.org/1794433002
Cr-Commit-Position: refs/heads/master@{#380872}
|
|
|
|
|
|
|
|
|
| |
This makes TokeValidatorFactory consistent with PairingRegistry and now
it can be shared between multiple authenticator objects.
Review URL: https://codereview.chromium.org/1788443005
Cr-Commit-Position: refs/heads/master@{#380871}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now client and host can use Spake2Authenticator instead of
V2Authenticator for both PIN-based auth and third-party auth. The plan
is to use cleanup It2Me to use hashed ID, so it will be possible to
remove spake2_plain method completely, so I'm not adding Curve25519
version.
Also pairing authentication needs move work to enable Curve25519 (see
crbug.com/593123), so it's going to be done separately.
Spake2Authenticor implements SPAKE2 over Curve25519, which is defined
in https://tools.ietf.org/html/draft-irtf-cfrg-spake2-03 .
BUG=589698
Review URL: https://codereview.chromium.org/1780403002
Cr-Commit-Position: refs/heads/master@{#380869}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For the new SPAKE2 authenticator we need to pass client_jid
to the authenticator. This wasn't possible previously because
NegotiatingClientAuthenticator was created before signaling is
connected. Moved NegotiatingClientAuthentication creation to
ChromotingClient.
BUG=589698
Committed: https://crrev.com/279bf7c76a3e0bfbbd28748d0d02fcead88f4436
Cr-Commit-Position: refs/heads/master@{#380779}
Review URL: https://codereview.chromium.org/1778023002
Cr-Commit-Position: refs/heads/master@{#380831}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #2 id:40001 of https://codereview.chromium.org/1778023002/ )
Reason for revert:
Appears to be breaking compile on Linux and Mac:
https://build.chromium.org/p/chromium/builders/Linux/builds/72875
https://build.chromium.org/p/chromium/builders/Mac/builds/13060
Output:
FAILED: /b/build/slave/Linux/build/src/build/goma/client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ ... -c ../../remoting/test/chromoting_test_fixture.cc -o obj/remoting/test/chromoting_test_driver.chromoting_test_fixture.o
In file included from ../../remoting/test/chromoting_test_fixture.cc:14:
In file included from ../../remoting/test/test_chromoting_client.h:14:
In file included from ../../remoting/client/chromoting_client.h:19:
In file included from ../../remoting/protocol/negotiating_client_authenticator.h:15:
In file included from ../../remoting/protocol/negotiating_authenticator_base.h:16:
../../third_party/webrtc/libjingle/xmllite/xmlelement.h:17:10: fatal error: 'webrtc/libjingle/xmllite/qname.h' file not found
#include "webrtc/libjingle/xmllite/qname.h"
^
1 error generated.
ninja: build stopped: subcommand failed.
Original issue's description:
> Move NegotiatingClientAuthentication creation to ChromotingClient.
>
> For the new SPAKE2 authenticator we need to pass client_jid
> to the authenticator. This wasn't possible previously because
> NegotiatingClientAuthenticator was created before signaling is
> connected. Moved NegotiatingClientAuthentication creation to
> ChromotingClient.
>
> BUG=589698
>
> Committed: https://crrev.com/279bf7c76a3e0bfbbd28748d0d02fcead88f4436
> Cr-Commit-Position: refs/heads/master@{#380779}
TBR=jamiewalch@chromium.org,sergeyu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=589698
Review URL: https://codereview.chromium.org/1788943002
Cr-Commit-Position: refs/heads/master@{#380785}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For the new SPAKE2 authenticator we need to pass client_jid
to the authenticator. This wasn't possible previously because
NegotiatingClientAuthenticator was created before signaling is
connected. Moved NegotiatingClientAuthentication creation to
ChromotingClient.
BUG=589698
Review URL: https://codereview.chromium.org/1778023002
Cr-Commit-Position: refs/heads/master@{#380779}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new authenticator uses SPAKE2 over Curve25519. It will
be enabled in host and client in a separate CL.
BUG=589698
Committed: https://crrev.com/bf336334ba59ae7cd150e9cb36a9b248d174a4eb
Cr-Commit-Position: refs/heads/master@{#379972}
Review URL: https://codereview.chromium.org/1759313002
Cr-Commit-Position: refs/heads/master@{#380674}
|
|
|
|
|
|
|
|
| |
BUG=276753
Review URL: https://codereview.chromium.org/1753663002
Cr-Commit-Position: refs/heads/master@{#380458}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:120001 of https://codereview.chromium.org/1749053002/ )
Reason for revert:
Seems to have broken compile on Win8 GN: https://build.chromium.org/p/chromium.win/builders/Win8%20GN%20%28dbg%29/builds/22702
Original issue's description:
> Move //remoting/remoting_host_win.gypi:* to GN
>
> BUG=512899
>
> Committed: https://crrev.com/ed559bd1594477689d0de32f660e0e37d62a5247
> Cr-Commit-Position: refs/heads/master@{#380425}
TBR=sergeyu@chromium.org,jamiewalch@chromium.org,zijiehe@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=512899
Review URL: https://codereview.chromium.org/1778313003
Cr-Commit-Position: refs/heads/master@{#380429}
|
|
|
|
|
|
|
|
| |
BUG=512899
Review URL: https://codereview.chromium.org/1749053002
Cr-Commit-Position: refs/heads/master@{#380425}
|