| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
policy.
Collateral changes:
- The username matching policy is ignored for RDP sessions.
BUG=137696
Review URL: https://codereview.chromium.org/14234012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
by adding new check in linux non chromeos case
BUG=None
TEST=None
Review URL: https://codereview.chromium.org/14024004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This creates a TokenFetcher implementation that on the client that uses the webapp to direct the user to fetch a token and secret from the given token URL. If the URL requires interactive authentication, the webapp will open a tab/window for the user to authenticate. Once the webapp has a token and shared secret, it uses the callback to send it back to the authentication layer.
This also glues the third party authentication method to the NegotiatingAuthenticator.
BUG=115899
Review URL: https://chromiumcodereview.appspot.com/12475020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This creates a TokenValidator implementation on the host, that upon receiving a token:
Signs the token with its private key.
Uses URLFetcher to request the exchange of the token for a secret from the Token Validation URL.
On receiving a reply, checks that the scope in the reply matches the one required for this connection.
Uses the callback to send the shared_token back to the authentication layer.
(The server will authenticate the host by checking that the token signature matches the host public key that the client included in the token request)
BUG=115899
Review URL: https://chromiumcodereview.appspot.com/12313085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
environment.
This CL adds two new classes: HostWindow and HostWindowProxy. HostWindow is a non thread-safe base class for platform-specific implementations of the disconnect and continue windows. HostWindowProxy implements thread switching logic (using a ref-counted HostWindowProxy::Core).
The combination of HostWindow and HostWindowProxy allows DesktopEnvironment to create the disconnect window on the network thread and run it on the UI thread.
This is the 1st CL (out of 2) that deprecates the HostUserInterface class and moves responsibility to create the local UI to the corresponding DesktopEnvironment instances. The follow up CL will migrate the continue window logic.
BUG=104544
Review URL: https://chromiumcodereview.appspot.com/13212009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
protocol stricter:
* Client sends a first message with supported methods (and optionally the first message for a method*).
* Host picks a method among those, and sends the first message (or reply).
* Client and host are now required to keep using the method selected by the host.
Now only the client has the possibility of creating more than one authenticator for the same negotiation (although it's not used now), and, even then, these are two necessarily different authenticators, so there's no chance of NegotiatingAuthenticator having to create the same type of authenticator twice.
* I'm keeping this because: (1) we did this before, up to M26, so we have to deal with this case anyway, and (2) it'll be useful for the pinless auth mechanism.
BUG=115899
Review URL: https://chromiumcodereview.appspot.com/13368002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds GetState() to the JS Native Messaging interface,
and refactors the HostController to use it instead of the
NPAPI plugin's "State" field member. The NPAPI plugin is
supported via a new wrapper class.
BUG=173509
Review URL: https://chromiumcodereview.appspot.com/13323009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
only).
This CL merges three implementations of message-only windows that we have in remoting into one class remoting::win::MessageWindow.
Collateral changes:
- The local input monitor now closes the connection if it cannot subscribe to the raw mouse input. Without this the remote user could potentially prevent the local user from closing the connection.
- The clipboard window can be started only once, just like its owner.
TEST=remoting_unittests.MessageWindowTest
Review URL: https://chromiumcodereview.appspot.com/13142002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
LocalInputMonitor instances use the ClientSessionControl interface to pass notification about local mouse movements and to disconnect the client session when the disconnect shortcut (Ctrl+Alt+Esc) is pressed.
This CL also completely removes the MouseMoveObserver interface (along with its implementation in ChromotingHost) since it is not used any more.
BUG=104544
Review URL: https://chromiumcodereview.appspot.com/12594009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ScreenControls/ClientSessionControl interfaces.
This CL removes all task runners that used to be passed to methods of DesktopEnviroment and DesktopEnviromentFactory interfaces. Instead each object implementing these interfaces receives the set of task runners it needs in the constructor. This change makes DesktopEnviroment and DesktopEnviromentFactory interfaces cleaner and easier to implement.
Added the ScreenControls interface used by the client session to change the screen resolution. Objects implementing ScreenControls are created by DesktopEnvironment::CreateScreenControls() method.
DesktopEnviromentFactory::Create() now receives a pointer to the ClientSessionControl interface providing a way to pause, resume, and disconnect the client session. It also receives notifications about the local mouse movements to temporarily block the remote input. The ClientSessionControl interface will be hooked up to the local impit monitor and the host UI once they will be moved to DesktopEnvironment.
BUG=104544
Review URL: https://chromiumcodereview.appspot.com/12879006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Unit tests are added for RateCounter, RunningAverage and CaptureScheduler.
BUG=166275
Review URL: https://chromiumcodereview.appspot.com/12803008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is part of general naming clean-up under remoting/ and will help
keep lambroslambrou@ happy.
Review URL: https://chromiumcodereview.appspot.com/12760012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a new Authenticator, that uses a third-party token service to authenticate clients and hosts and negotiate a shared secret.
The client authenticates with the third-party service, and obtains a token and a shared secret. The token is sent directly to the host, the shared secret is used to initiate a SPAKE authentication.
The host receives the token, and asks the third-party server to exchange it for the shared secret (authenticating itself by signing the request with the host private key). Once it gets the shared secret, client and host are able to finish the SPAKE negotiation.
BUG=115899
Review URL: https://chromiumcodereview.appspot.com/12326090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The butter-bar is shown until the user either closes it with the X icon or begins the survey. Once dismissed, a cookie is stored in sync storage to prevent it showing up again for that user on another computer (note that this uses Chrome Sync, so it relies on them being signed in to Chrome).
BUG=191368
Review URL: https://codereview.chromium.org/12566035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is just the webapp part of the implementation. A followup CL will
build a Native Messaging executable, which will allow end-to-end
testing.
BUG=173509
TEST=Manual, using a simple Python script based on the Native Messaging example code.
Review URL: https://chromiumcodereview.appspot.com/12248011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
resizer.
This is mostly a renaming CL:
- DesktopSessionParams -> ScreenResolution
- OnClientResolutionChanged() -> SetScreenResolution().
Also added validation of ScreenResolution before passing it to session controllers.
BUG=196316
Review URL: https://codereview.chromium.org/12678008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=190051
Review URL: https://codereview.chromium.org/12774009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
running the backend on the proper UI/input thread.
This will eventually allow to wrap LocalInputMonitor into a SessionController object.
Collateral changes:
- Eliminated the dedicated local input monitor thread on LInux, replacing it with a file descriptor watcher.
- LocalInputMonitor::Create() now receives all task runners it needs.
- Mac version does not use locks anymore, since all UI code is runing on the UI thread.
BUG=104544
Review URL: https://chromiumcodereview.appspot.com/12623020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
address (and vice versa) to WtsTerminalMonitor.
This makes GetEndpointForSessionId() and GetSessionIdForEndpoint() reusable.
BUG=137696
TEST=remoting_unittests.RdpClientTest.*
Review URL: https://chromiumcodereview.appspot.com/12632011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
other stubs.
ResizingHostObserver is responsible to resizing the host desktop so that it matches the client resolution. This CL makes the desktop environment responsible for creation of ResizingHostObserver object along with other stubs.
Related changes:
- Added a new interface: SessionController. Objects implementing it will be responsible for handling control events. The client resolution change is the only supported event at the moment.
- Removed OnClientResolutionChanged() from the host status observer.
- The multi-process host does not handle OnClientResolutionChanged() notifications at the moment.
BUG=137696
Review URL: https://chromiumcodereview.appspot.com/12545026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://codereview.chromium.org/12563002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186816 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This makes the RSAPrivateKey dependency encapsulated inside KeyPair, and makes it a refcounted object, rather than copying the private key on every authenticator constructor. It also allows authenticators to use the KeyPair methods (such as GetSignature() or GetPublicKey()).
BUG=115899
Review URL: https://chromiumcodereview.appspot.com/12316083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The LNK1104 error was probably a flake. The next build cycled green before the 1st revert was picked up.
> Revert 186522
> > Build src/remoting/remoting.gyp:remoting_host_installation on the main waterfall.
> >
> > remoting_host_installation uses lots of non-trivial GYP that tend to break because of differences between ninja and msbuild. Building it on the main waterfall gives us an early warning if something goes wrong.
> >
> > BUG=180600
> >
> > Review URL: https://codereview.chromium.org/12543006
>
> TBR=alexeypa@chromium.org
> Review URL: https://codereview.chromium.org/12545010
TBR=miu@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Build src/remoting/remoting.gyp:remoting_host_installation on the main waterfall.
>
> remoting_host_installation uses lots of non-trivial GYP that tend to break because of differences between ninja and msbuild. Building it on the main waterfall gives us an early warning if something goes wrong.
>
> BUG=180600
>
> Review URL: https://codereview.chromium.org/12543006
TBR=alexeypa@chromium.org
Review URL: https://codereview.chromium.org/12545010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The daemon has to provide an implementation of IRdpDesktopSessionEventHandler interface in order to receive events from RdpDesktopSession. It is currently a dual interface (inherited from IDispatch) which either makes the implementation more complex than necessary or makes the daemon to depend on ATL. Switching to raw interfaces allows to both simplify the implementation and avoid ATL dependency.
This CL makes remoting_core.dll a proxy/stub DLL used to marshall the raw interfaces that the host defines.
BUG=137696
Review URL: https://codereview.chromium.org/12440003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
waterfall.
remoting_host_installation uses lots of non-trivial GYP that tend to break because of differences between ninja and msbuild. Building it on the main waterfall gives us an early warning if something goes wrong.
BUG=180600
Review URL: https://codereview.chromium.org/12543006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> RdpDesktopSession COM class should only use raw interfaces.
>
> The daemon has to provide an implementation of IRdpDesktopSessionEventHandler interface in order to receive events from RdpDesktopSession. It is currently a dual interface (inherited from IDispatch) which either makes the implementation more complex than necessary or makes the daemon to depend on ATL. Switching to raw interfaces allows to both simplify the implementation and avoid ATL dependency.
>
> This CL makes remoting_core.dll a proxy/stub DLL used to marshall the raw interfaces that the host defines.
>
> BUG=137696
>
> Review URL: https://codereview.chromium.org/12390060
TBR=alexeypa@chromium.org
Review URL: https://codereview.chromium.org/12473005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The daemon has to provide an implementation of IRdpDesktopSessionEventHandler interface in order to receive events from RdpDesktopSession. It is currently a dual interface (inherited from IDispatch) which either makes the implementation more complex than necessary or makes the daemon to depend on ATL. Switching to raw interfaces allows to both simplify the implementation and avoid ATL dependency.
This CL makes remoting_core.dll a proxy/stub DLL used to marshall the raw interfaces that the host defines.
BUG=137696
Review URL: https://codereview.chromium.org/12390060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Move code out of libjingle_p2p and libjingle_peerconnection into the libjingle lib.
* Update gyp files that previously depended on libjingle_p2p to depend on libjingle.
* Only the constant files are left in the extra libs (which is why they exist).
* Move the webrtc code out into a separate target.
Review URL: https://codereview.chromium.org/12465002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the case of the multi-process host the ability to support curtain mode is a property of the desktop environment representing the screen. This CL hooks up IpcDesktopEnvironmentFactory to receive the request to activate the curtain. This way the factory class will be able to create a different kind of the desktop environment if the curtain was requested.
Other changes:
- Added remoting_rdp_session% GYP flag that enables RDP integration on Windows.
BUG=137696
Review URL: https://chromiumcodereview.appspot.com/12379084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
When multi-process host is used the host/network process runs with low privileges (for example at low integrity level on Windows), so it might not have access to the system event log. This CL makes the network process to send host status notifications to the daemon, which in its turn can write them to the system event log.
BUG=178873
Review URL: https://chromiumcodereview.appspot.com/12378032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(HostStatusMonitor).
This CL unbinds the host status event observers from ChromotingHost. This is useful when, for instance, an observer resides in a different process where ChromotingHost is not available. Additionally, observers get HostStatusMonitor as a weak pointer, making sure that they do not need to worry about HostStatusMonitor's life time.
BUG=178873
Review URL: https://chromiumcodereview.appspot.com/12386035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
RdpClient takes dependency on mstscax.dll that pulls a lot of code to the process. This CL allows RdpClient objects to be hosted in a separate process running at medium integrity level under LocalService account.
BUG=137696
Review URL: https://chromiumcodereview.appspot.com/12330178
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes in this CL:
- The list of COM classes served by the process explicitly specified. This way a different set of classes can be served depending on the entry point used.
- Renamed the type library to ChromotingLib as it will contain other classes as well.
- The ATL module class runs Chromium message loop allowing tasks to be posted to it.
- The main mesage loop is wrapped into AutoThreadTaskRunner as an aid to implementing asynchronous shutdown code.
- The COM process exits as soon as the last COM object it serves released.
BUG=137696
Review URL: https://chromiumcodereview.appspot.com/12326164
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
.TLB is updated.
Also cleaned up an unnecessary use of Cygwin while generating elevated_controller.idl.
BUG=178633
Review URL: https://codereview.chromium.org/12378014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
connection.
BUG=137696
Review URL: https://codereview.chromium.org/12342046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Out-of-date hosts can be identified from the hostVersion field in the directory.
They are identified in the host-list using the existing "warning" icon overlaid
on the host icon. Off-line hosts are never flagged as out-of-date, as this may
not indicate a problem (if they have been off-line for a long time). Attempting
to connect to an out-of-date host shows a warning interstitial explaining that
a manual update is required (and can be done while connected).
The CL also cleans up the HostTableEntry class, better separating the duties of
the ctor, create (now createDom) and init methods.
BUG=177122
Review URL: https://chromiumcodereview.appspot.com/12342024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Make sure .RC file including elevated_controller.tlb is rebuilt every time .TLB is updated.
>
> Also cleaned up an unnecessary use of Cygwin while generating elevated_controller.idl.
>
> BUG=178633
>
> Review URL: https://chromiumcodereview.appspot.com/12315122
TBR=alexeypa@chromium.org
Review URL: https://codereview.chromium.org/12382010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
.TLB is updated.
Also cleaned up an unnecessary use of Cygwin while generating elevated_controller.idl.
BUG=178633
Review URL: https://chromiumcodereview.appspot.com/12315122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
a Windows session.
BUG=137696,177832
TEST=remoting_unittests.RdpConsoleTest
Review URL: https://chromiumcodereview.appspot.com/12320045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL combines entry points for four different kinds of Chromoting processes into a single shared entry point routine. The "--type" command line parameter is used to determine the type of the processes to be launched.
This effectively makes all the executabes interchangable, reducing the number of EXE binaries to two: remoting_host.exe and remoting_desktop.exe. The latter is needed because of level="requireAdministrator" and uiAccess="true" settings in its manifest.
Collateral changes:
- Added a debug only remoting_console.exe binary that can run in the console.
- dpiAware=true is set via the manifest instead of calling SetProcessDPIAware().
- A cross-platform define REMOTING_ENABLE_BREAKPAD is now used to enable Breakpad integration code.
- The "--host-config" command line switch is not passed to the network process by the multi-process daemon.
- The "--elevate" and "--version" command line switches are processed by the shared entry point now.
- The usage message has been updated.
BUG=170200
Review URL: https://chromiumcodereview.appspot.com/12328040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://chromiumcodereview.appspot.com/12326021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=134694
Review URL: https://chromiumcodereview.appspot.com/12316017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes:
- Remoting DLLs are built with the -DISOLATION_AWARE_ENABLED=1 flag. This allows them to specify the version of comctl32.dll to link against independently from the hosting EXE.
- A manifest specifying dependency on v6 of comctl32.dll was added to remoting_host_plugin.dll.
BUG=176460
Review URL: https://codereview.chromium.org/12296030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> 562>host/win/remoting_host.manifest : manifest authoring error c1010001: Values of attribute "level" not equal in different manifest snippets.
> Make remoting DLLs isolation aware.
>
> This CL enables the ISOLATION_AWARE_ENABLED flag when building remoting DLLs. This allows them to specify the version of comctl32.dll to link agains independently from the hosting EXE.
>
> Collateral changes:
> - The manifests are specified via 'AdditionalManifestFiles' instead of having a separate action that embeds a manifest into a binary. This simplifies GYP a lot at the cost of not having manifests embedded when building with ninja. The official builders use msbuild at the moment. Ability to embed manifest should be added to ninja, if the official builders were switched to ninja (if ever).
> - A manifest specifying dependency on comctl32.dll v6 was added to remoting_host_plugin.dll.
>
> BUG=176460
>
>
> Review URL: https://chromiumcodereview.appspot.com/12283006
TBR=alexeypa@chromium.org
Review URL: https://codereview.chromium.org/12297003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Windows.
Review URL: https://chromiumcodereview.appspot.com/12288014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL enables the ISOLATION_AWARE_ENABLED flag when building remoting DLLs. This allows them to specify the version of comctl32.dll to link agains independently from the hosting EXE.
Collateral changes:
- The manifests are specified via 'AdditionalManifestFiles' instead of having a separate action that embeds a manifest into a binary. This simplifies GYP a lot at the cost of not having manifests embedded when building with ninja. The official builders use msbuild at the moment. Ability to embed manifest should be added to ninja, if the official builders were switched to ninja (if ever).
- A manifest specifying dependency on comctl32.dll v6 was added to remoting_host_plugin.dll.
BUG=176460
Review URL: https://chromiumcodereview.appspot.com/12283006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The is the simplest way of loading the font for Apps v2, and will improve the
start-up time for the app.
BUG=134213
Review URL: https://codereview.chromium.org/12261039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=lambroslambrou@google.com
Review URL: https://codereview.chromium.org/12226106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=lambroslambrou@google.com
Review URL: https://codereview.chromium.org/12216006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181773 0039d316-1c4b-4281-b951-d872f2087c98
|