| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
remoting_base uses GURL, but didn't have explicit dependency on //url.
BUG=597559
TBR=lambroslambrou@chromium.org
Review URL: https://codereview.chromium.org/1833733002 .
Cr-Commit-Position: refs/heads/master@{#383114}
|
|
|
|
|
|
|
|
|
| |
Removed all files used to build app_remoting webapp and cleaned up
build files.
Review URL: https://codereview.chromium.org/1816653002
Cr-Commit-Position: refs/heads/master@{#382147}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new authenticator uses SPAKE2 over Curve25519. It will
be enabled in host and client in a separate CL.
BUG=589698
Committed: https://crrev.com/bf336334ba59ae7cd150e9cb36a9b248d174a4eb
Cr-Commit-Position: refs/heads/master@{#379972}
Review URL: https://codereview.chromium.org/1759313002
Cr-Commit-Position: refs/heads/master@{#380674}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
boringssl. (patchset #5 id:140001 of https://codereview.chromium.org/1759313002/ )
Reason for revert:
This patch added 2 more tests which are now failing on Linux MSan Tests as of build #14316
https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/14316
Spake2AuthenticatorTest.InvalidSecret (run #1):
[ RUN ] Spake2AuthenticatorTest.InvalidSecret
==10538==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x14bb0fd in ?? third_party/modp_b64/modp_b64.cc:91:20
#1 0xdcf2f6 in Base64Encode base/base64.cc:18:24
#2 0x12d6e6c in EncodeBinaryValueToXml remoting/protocol/spake2_authenticator.cc:47:3
and
Spake2AuthenticatorTest.SuccessfulAuth (run #1):
[ RUN ] Spake2AuthenticatorTest.SuccessfulAuth
==10537==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x14bb0fd in ?? third_party/modp_b64/modp_b64.cc:91:20
#1 0xdcf2f6 in Base64Encode base/base64.cc:18:24
#2 0x12d6e6c in EncodeBinaryValueToXml remoting/protocol/spake2_authenticator.cc:47:3
Original issue's description:
> Implement authenticator based on SPAKE2 implementation in boringssl.
>
> The new authenticator uses SPAKE2 over Curve25519. It will
> be enabled in host and client in a separate CL.
>
> BUG=589698
>
> Committed: https://crrev.com/bf336334ba59ae7cd150e9cb36a9b248d174a4eb
> Cr-Commit-Position: refs/heads/master@{#379972}
TBR=kelvinp@chromium.org,davidben@chromium.org,arnarb@chromium.org,sergeyu@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=589698
Review URL: https://codereview.chromium.org/1778223003
Cr-Commit-Position: refs/heads/master@{#380365}
|
|
|
|
|
|
|
|
|
|
|
| |
The new authenticator uses SPAKE2 over Curve25519. It will
be enabled in host and client in a separate CL.
BUG=589698
Review URL: https://codereview.chromium.org/1759313002
Cr-Commit-Position: refs/heads/master@{#379972}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The move to libvpx_new happened before M47 (landed in 2524, M47 branch was 2526):
crbug.com/481034
https://codereview.chromium.org/1323333002
Clients which try to transition directly between the tree after this change and before the previous move will end up in a very broken state.
Now it is 6 months later and M48 is stable so is unlikely that a client would check out the old code at all, much less try to transition directly between the two versions.
Leave a compatibility layer for targets which need to be updated out of band (webrtc, libyuv)
Review URL: https://codereview.chromium.org/1734613003
Cr-Commit-Position: refs/heads/master@{#378739}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, creating a place to land iOS app in remoting.
R=joedow@chromium.org
BUG=499478
Review URL: https://codereview.chromium.org/1752983002
Cr-Commit-Position: refs/heads/master@{#378634}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebrtcVideoCapturerAdapter was previously relying on
cricket::VideoCapturer for YUV conversion, which was also resizing the
frames, but that's not desired. Now it's responsible for YUV conversion,
which also allows to optimize it by coverting only parts of the screen
that are changing.
Also fixed WebrtcVideoCapturerAdapter to avoid multiple simultaneous capture
requests, which was causing assert failure in DesktopCapturer.
BUG=547158
Review URL: https://codereview.chromium.org/1574543002
Cr-Commit-Position: refs/heads/master@{#368508}
|
|
|
|
|
|
|
|
|
|
|
| |
This problem was already fixed in r360646, but was broken again due
incorrect merge in r361205.
TBR=kelvinp@chromium.org
Review URL: https://codereview.chromium.org/1468283002
Cr-Commit-Position: refs/heads/master@{#361219}
|
|
|
|
|
|
|
|
|
|
|
| |
VideoFramePump will not be used for WebRTC-based connection. In a separate
change I plan to move creation of the VideoFramePump to IceConnectionToHost
so the host layer will not need to know when VideoFramePump needs to be
used.
Review URL: https://codereview.chromium.org/1462063004
Cr-Commit-Position: refs/heads/master@{#361205}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Followup to https://codereview.chromium.org/1427003009
The third_party/libjingle/libjingle.gyp:libjingle_webrtc target is defined
inside an enable_webrtc==1 condition, so it can only be depended on inside
a similar condition.
BUG=547158
Review URL: https://codereview.chromium.org/1457793004
Cr-Commit-Position: refs/heads/master@{#360646}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is an initial portion of the new WebRTC-based protocol. The
new Transport implementation can establish connection but doesn't
send any data yet.
BUG=547158
Review URL: https://codereview.chromium.org/1427003009
Cr-Commit-Position: refs/heads/master@{#360491}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Leaves the previous version in place but updates BUILD.gn and libvpx.gn to point to the new version. This allows decoupling the WebRTC update which is also in DEPS.
libvpx DEPS changes ac1772e:0d6551
https://codereview.chromium.org/1339033002
https://chromium-review.googlesource.com/299759
https://codereview.chromium.org/1350853003
https://codereview.chromium.org/1353433003
Copy directory to libvpx_new to avoid breaking bisecting. This allows the user to move between and older and newer revision. A followup to rename libvpx_new to libvpx will come in some ~months because there are additional complications if one tries to sync directly from pre-move to post-rename or the other way around.
Remove WATCHLISTS and codereview.settings from _new and use the parent versions.
Add DEPS file to enumerate the #include paths.
Check out third_party/libvpx_new/source/libvpx directly from upstream project
Update all the easy clients of libvpx to depend on the new tree directly.
https://chromium.googlesource.com/chromium/deps/libvpx/+/ac1772e3db5c885b554f6a72ca9dbac4245cb0e2
BUG=481034
R=tomfinegan@chromium.org,brettw@chromium.org,phajdan.jr@chromium.org
Review URL: https://codereview.chromium.org/1323333002
Cr-Commit-Position: refs/heads/master@{#349789}
|
|
|
|
|
|
|
|
| |
base/resources.h is used only in host, so it doesn't need to be in base.
Review URL: https://codereview.chromium.org/1318773003
Cr-Commit-Position: refs/heads/master@{#345719}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. GN builds were not including some tests included in GYP.
2. Replaced test_common target in gyp with test_support.
3. Removed extra *_common targets for test_driver and moved everything
to test_support.
4. test_driver can be compiled using GN now.
5. Various other small cleanups.
Review URL: https://codereview.chromium.org/1228283004
Cr-Commit-Position: refs/heads/master@{#339119}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enables many GN Windows tests.
The GN build wasn't disabling the size_t to int warning in webcrypto. I decided to fix the warnings rather than disable them. This code is a random mishmash of size_t, int, unsigned, and long (partially due to third party code). In this change, I tried to do something minimal and clear: some variables were changed to size_t, while some were converted to casts.
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg
TBR=dpranke
Review URL: https://codereview.chromium.org/1091293003
Cr-Commit-Position: refs/heads/master@{#326046}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now XMPP is implemented directly in remoting/signaling instead of
relying on WebRTC. The new code is mostly just a translation of
the XMPP implementation we use in the webapp from JavaScript to
C++ and uses the same layout and class names, except that the main
class is called XmppSignalStrategy instead of XmppConnection.
BUG=459756, 443806, 417336
Review URL: https://codereview.chromium.org/958703003
Cr-Commit-Position: refs/heads/master@{#319712}
|
|
|
|
|
|
|
|
|
| |
Reland of https://codereview.chromium.org/961323004
TBR=dpranke
Review URL: https://codereview.chromium.org/969173002
Cr-Commit-Position: refs/heads/master@{#319080}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Default vars (like run_jscompile) should only be defined in one place.
This cl adds remoting_options.gypi so that the variables can be used
by both DesktopRemoting and AppRemoting gyp files.
BUG=
Review URL: https://codereview.chromium.org/974673002
Cr-Commit-Position: refs/heads/master@{#318838}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/961323004/)
Reason for revert:
broke windows GN builds as seen in
http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/5206/steps/compile/logs/stdio
Original issue's description:
> Add remoting and PPAPI tests to GN build
>
> Reland of https://codereview.chromium.org/965633002/
>
> TBR=dpranke
>
> Committed: https://crrev.com/66c53eef76f7dff97b1bc76d51740c3a9c07844f
> Cr-Commit-Position: refs/heads/master@{#318756}
TBR=dpranke@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/968243004
Cr-Commit-Position: refs/heads/master@{#318772}
|
|
|
|
|
|
|
|
|
|
| |
Reland of https://codereview.chromium.org/965633002/
TBR=dpranke
Review URL: https://codereview.chromium.org/961323004
Cr-Commit-Position: refs/heads/master@{#318756}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/965633002/)
Reason for revert:
http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%20GN&number=4498
ERROR at //remoting/host/BUILD.gn:56:7: Item not found
"linux/x_server_clipboard.cc",
^----------------------------
You were trying to remove "linux/x_server_clipboard.cc"
Original issue's description:
> Add remoting and PPAPI tests to GN build
>
> BUG=
>
> Committed: https://crrev.com/d0437210926b14b1b7e06b2b56174fc92ade9c37
> Cr-Commit-Position: refs/heads/master@{#318539}
TBR=kelvinp@chromium.org,dpranke@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/970443002
Cr-Commit-Position: refs/heads/master@{#318545}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/965633002
Cr-Commit-Position: refs/heads/master@{#318539}
|
|
|
|
|
|
|
|
| |
BUG=407778
Review URL: https://codereview.chromium.org/884703006
Cr-Commit-Position: refs/heads/master@{#314424}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move duplicate locale-related gyp vars into a separate .gypi.
Add gyp vars that contain the set of localizable html/js files.
Remove remoting_host_locale_files since it is not used anywhere.
BUG=
Review URL: https://codereview.chromium.org/875083004
Cr-Commit-Position: refs/heads/master@{#313284}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/858633002
Cr-Commit-Position: refs/heads/master@{#312006}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds support for a native confirmation dialog shown after the
user presses "Share" on the webapp but before an access code is
generated. It also includes a ChromeOS (Aura) implementation.
Implementation for other platforms will soon follow.
More details
============
It2MeConfirmationDialog is an interface for the confirmation dialog.
Implementations can assume they will be called only on the UI thread.
It2MeConfirmationDialogFactory is used to create platform specific
implementations of the dialog.
It2MeConfirmationDialogChromeOS is the dialog's ChromeOS implementation.
It2MeConfirmationDialogProxy is a helper class that allows the caller
(in this case, It2MeHost) to use the dialog outside of the UI thread.
BUG=444216
Review URL: https://codereview.chromium.org/816903002
Cr-Commit-Position: refs/heads/master@{#310149}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/742473002
Cr-Commit-Position: refs/heads/master@{#306336}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GN builds are enabled by default on buildbots for Chrome OS with Ozone.
Since remote assistance is part of the Chrome binary on Chrome OS, it needs
to be migrated to GN.
This CL migrates the target remoting_it2me_host_static and its dependencies to GN
on Chrome OS. Specifically this CL:
1. Pulls out the sources from remoting_host.gypi into remoting_host_srcs.gypi,
which is shared by both GYP and GN.
2. Creates a BUILD.gn file for remoting/host and remoting/host/it2me
3. Makes //chrome/browser/extensions depends on //remoting/host/it2me:common
4. Modifies remoting_versions.gni to handle branding.
BUG=432358
Review URL: https://codereview.chromium.org/719603002
Cr-Commit-Position: refs/heads/master@{#303897}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/684373002
Cr-Commit-Position: refs/heads/master@{#302515}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Continue Dialog (along with a few other dialogs) in Remote Assistance references
localized strings defined in rmeoting_strings.grd. To make Remote Assistance work
on Chrome OS, we need to get those resources into Chrome.
This CL
1. Modifies repack_locales.py to merge the generated strings from remoting_strings.grd
into the merged resource packs (e.g. merge remoting/resource/en.pak -> en-US.pak).
2. Chrome currently supports more languages than remoting. This CL adds the missing
languages into remoting_strings.grd. This is required to avoid compilation failures.
The list of added locales are based-on on referencing other chrome grd files (e.g.
generated_resources.grd).
3. remoting_strings.grds currently uses an overlapping resource ID range with chrome.
To avoid conflicts, this CL reserves ids [29550-30000) for strings in remoting
(see the changes in remoting/resources/resource_ids and tools/gritsettings/resource_ids).
Review URL: https://codereview.chromium.org/682863002
Cr-Commit-Position: refs/heads/master@{#301566}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
remoting/webapp/crd/html -- CRD-specific HTML/CSS
remoting/webapp/crd/js -- CRD-specific JS
remoting/webapp/crd/resources -- CRD-specific resources
remoting/webapp/base/html -- common HTML/CSS
remoting/webapp/base/js -- common JS
remoting/webapp/base/resources -- common resources
The only content changes are in the GYP/GYPI files and in template_main.html. These files needed to be updated to use the new file paths.
BUG=
R=jamiewalch@chromium.org
Review URL: https://codereview.chromium.org/671513008
Cr-Commit-Position: refs/heads/master@{#300806}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
access code
This dialog explains the implications of accepting remote
assistance and provides a way for the user to decline
assistance.
This ensures that even if the caller (Hangouts) is compromised,
it won't be able to control the user's desktop without user
interaction.
BUG=405139
Review URL: https://codereview.chromium.org/503063004
Cr-Commit-Position: refs/heads/master@{#293200}
|
|
|
|
|
|
|
|
| |
BUG=406055
Review URL: https://codereview.chromium.org/497333002
Cr-Commit-Position: refs/heads/master@{#291743}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since GN runs its scripts in a different current directory than GYP, I had to update the remoting html template script to be able to handle this situation.
Also includes many misc linking fixes:
- Sets enable_nacl to false.
- Add renderer context menu component
- Adds many missing files
R=sergeyu@chromium.org
Review URL: https://codereview.chromium.org/498773005
Cr-Commit-Position: refs/heads/master@{#291731}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Support for:
1. Capability enumeration, negotiation and managment.
2. Generic client-side extensions, similar to HostExtension model in Chromoting host.
3. Interaction with Chromoting host's CastExtension and support for Cast Sender API
(prototype for Cast support).
Note:
The android app has four new dependencies: v4 support, v7 appcompat, v7 mediarouter,
google play services. The first three are in third_party/android_tools/,
but the last isn't. See crbug.com/403948. This CL will not break any builds
since the code is behind a gyp flag in remoting.gyp.
Review URL: https://codereview.chromium.org/451973002
Cr-Commit-Position: refs/heads/master@{#289897}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL:
- Moves background.js to background.html
- Introduces remoting.appLauncher that allows the caller to launch and close the webapp without knowing the implementation difference between a v1 app and a v2 app.
NOTRY=true
R=jamiewalch@chromium.org
Review URL: https://codereview.chromium.org/450383003
Cr-Commit-Position: refs/heads/master@{#289096}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=134215
R=weitaosu@chromium.org, wez@chromium.org
Review URL: https://codereview.chromium.org/342583002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The default apps v2 container is pretty basic. We want to provide something that looks prettier and also implements some functionality specific to our use-case:
* When connected to a host, a disconnect icon is added to the window controls (it's therefore no longer needed in the tool-bar).
* When connected to a host, maximize == full-screen.
* In full-screen mode, the window controls are still accessible, but are auto-hidden near the top-left corner (but not obscuring it, since it's often a hot-spot on the server).
* For touch-screen devices with no concept of hover, clicking the "stub" will also reveal the controls.
There should be no change to the v1 UX, but I don't plan on landing this CL before the M36 branch point, just in case.
BUG=134213
Review URL: https://codereview.chromium.org/265393005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add arm64 target to GYP files.
This is for getting a build of content shell for ARM64.
BUG=354405
R=garykac@chromium.org
Review URL: https://codereview.chromium.org/243163002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=jamiewalch@chromium.org
Review URL: https://codereview.chromium.org/211573008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This follows the rule we setup for //ui which states that each subdir
should be its own component with its own gyp file that lives in its
subdir.
The 'ui' target was renamed to ui_base to match the convention.
BUG=299841
TEST=gyp files.
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/198333004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The warning about unused PRODUCT_DESCRIPTION resource
was introduced in r254355.
R=jamiewalch@chromium.org
Review URL: https://codereview.chromium.org/184823010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=276739
Review URL: https://codereview.chromium.org/185163002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added two new targets remoting_webapp_v1 and remoting_webapp_v2. Both
include the new remoting_webapp.gypi. remoting_webapp target
depends on both. Also moved these targets to remoting_client.gypi.
remoting_webapp.gypi will also be reused for webapp version that
uses PNaCl plugin.
BUG=276739
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253800
R=jamiewalch@chromium.org
Review URL: https://codereview.chromium.org/181473008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/181473008/)
Reason for revert:
Appears to have broken the build:
http://build.chromium.org/p/chromium/builders/Linux/builds/47807
...
adding: chrome-linux/chrome (deflated 58%)
Traceback (most recent call last):
File "../../../scripts/slave/chromium/archive_build.py", line 760, in <module>
chromium_utils.CopyFileToDir(src/out/Release/remoting-webapp.v2.zip, /b/build/slave/Linux/chrome_staging/, dest_fn=remoting-webapp.v2.zip)
sys.exit(main(None))
File "../../../scripts/slave/chromium/archive_build.py", line 756, in main
return s.ArchiveBuild()
File "../../../scripts/slave/chromium/archive_build.py", line 571, in ArchiveBuild
os.path.join(self._staging_dir, stage_subdir), dest_fn=stage_fn)
File "/b/build/scripts/common/chromium_utils.py", line 485, in CopyFileToDir
raise PathNotFound('Unable to find file %s' % src_path)
common.chromium_utils.PathNotFound: Unable to find file src/out/Release/remoting-webapp.v2.zip
Original issue's description:
> Cleanup remoting.gyp around the remoting_webapp target
>
> Added two new targets remoting_webapp_v1 and remoting_webapp_v2. Both
> include the new remoting_webapp.gypi. remoting_webapp target
> depends on both. Also moved these targets to remoting_client.gypi.
> remoting_webapp.gypi will also be reused for webapp version that
> uses PNaCl plugin.
>
> BUG=276739
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253800
TBR=jamiewalch@chromium.org,garykac@chromium.org,sergeyu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=276739
Review URL: https://codereview.chromium.org/180783007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added two new targets remoting_webapp_v1 and remoting_webapp_v2. Both
include the new remoting_webapp.gypi. remoting_webapp target
depends on both. Also moved these targets to remoting_client.gypi.
remoting_webapp.gypi will also be reused for webapp version that
uses PNaCl plugin.
BUG=276739
Review URL: https://codereview.chromium.org/181473008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
dialog_client.html was missing from the template list and the old build did not report an error. This change requires that he expected list of templates be passed to the HTML generator script so that it can be verified that all the dependencies are specified.
This also moves the dialog_client template into the main template so that we include everything directly from template_main.html.
This also removes some end-tag comments that are no longer needed since the structure can be more easily seen.
BUG=
Review URL: https://codereview.chromium.org/176013002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
PNaCl plugin will need to share lists of sources with the existing
targets. Moved these lists to remoting_srcs.gypy to avoid duplicating
them.
BUG=276739
Review URL: https://codereview.chromium.org/172873007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this change, it will be much easier to make changes to the UX (since
the dialogs will be easier to manage) and the set of JavaScript includes
will be guaranteed to match the gyp target.
This change also auto-generates the wcs_sandbox.html file.
BUG=
R=jamiewalch@chromium.org
Review URL: https://codereview.chromium.org/146903006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252135 0039d316-1c4b-4281-b951-d872f2087c98
|