| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a reland of r284079 which was reverted in r284248 for components build
issues. That, in turn, was a reland of r283813 which was reverted in r283845
because it broke WebRTC tests on Android. That, in turn, was a reland of
r283542 which was reverted in r283591 because it broke the WebView build.
This is a much larger change than its diff suggests. If it breaks
something, please revert first and ask questions later.
BUG=393317
R=agl@chromium.org, jam@chromium.org
Review URL: https://codereview.chromium.org/401153002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ensure that the members are fully cleaned up during disconnection,
before the object gets destroyed (which can happen on a random thread).
Otherwise the members may be destroyed on the wrong thread, triggering
DCHECKs.
BUG=395312
Review URL: https://codereview.chromium.org/406123002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This CL contains the implementation of PortAllocatorFactoryInterface in peerconnectioninterface.h.
It bridges the gap in port allocation objects between WebRTC and Chromium. The factory produces a
ChromiumPortAllocator that can successfully be used by the PeerConnection API.
Review URL: https://codereview.chromium.org/398813003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The old method of using a timer to set the closeHandler was messy and harder
to unit-test. The new method uses stopPropagation, which is cleaner and makes
the unit-tests simpler.
Review URL: https://codereview.chromium.org/401623004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL addresses some feedback from Jamie regarding unit test naming conventions and organizations.
1. Renames test_eventSource.js to base_unittest.js.
2. Groups the modules by class instead of by function.
3. Adds extra test cases for base.js
Review URL: https://codereview.chromium.org/403663002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit r284079.
BUG=395271
Review URL: https://codereview.chromium.org/406693004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(This is a reland of r283813 which was reverted in r283845 because it broke
WebRTC tests on Android. That, in turn, was a reland of of r283542 which was
reverted in r283591 because it broke the WebView build.)
This is a much larger change than its diff suggests. If it breaks
something, please revert first and ask questions later.
BUG=none
Review URL: https://codereview.chromium.org/401613008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
N.B. I had to move the sawbuck_provider in the .wxs out of the
installation directory. Even though it only contains registry changes,
candle will complain if it is not inside a directory, but the
application directory is platform specific, whereas sawbuck_provider is
always 32-bit.
BUG=394467
Review URL: https://codereview.chromium.org/398173002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also fixes a related bug involving exiting full-screen. If the window was previously maximized when it is full-screened, then ChromeOS sometimes generates an onMaximized event when exiting full-screen, which triggers the app to re-enter full-screen mode. The fix is to explicitly unmaximize the window before going full-screen (which also has the nice benefit of making the double restore() calls unnecessary).
BUG=384678
Review URL: https://codereview.chromium.org/398403002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=393019
Review URL: https://codereview.chromium.org/404573002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that the QUnit-based unit tests are running on the bots, we can retire gtestjs unit tests.
This CL
1. Modifies remoting_webapp_unittest to include all files that are formerly covered by all_js_load.gtestjs.
2. Removes all the gtestjs files under remoting.
3. Moves run_all_remoting_unittests.cc back into the remoting directory as we no longer depends on chrome_paths.h.
Review URL: https://codereview.chromium.org/394023002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Normally fake interface implementations use Fake prefix, but there
were some with Fake suffix, namely SignalStrategyFake and
HostStatusMonitorFake. Renamed them to use Fake prefix.
R=rmsousa@chromium.org
Review URL: https://codereview.chromium.org/393703002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Failed WebRtcBrowserTest on android_dbg_triggered_tests.
> Switch to BoringSSL.
>
> (This is a reland of r283542 which was reverted in r283591 because it
> broke the WebView build. The android_aosp trybots are broken[1] so this
> based on hope.)
>
> This is a much larger change than its diff suggests. If it breaks
> something, please revert first and ask questions later.
>
> [1] http://code.google.com/p/chromium/issues/detail?id=394597
>
> BUG=none
>
> Review URL: https://codereview.chromium.org/399993002
TBR=agl@chromium.org
Review URL: https://codereview.chromium.org/405503002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(This is a reland of r283542 which was reverted in r283591 because it
broke the WebView build. The android_aosp trybots are broken[1] so this
based on hope.)
This is a much larger change than its diff suggests. If it breaks
something, please revert first and ask questions later.
[1] http://code.google.com/p/chromium/issues/detail?id=394597
BUG=none
Review URL: https://codereview.chromium.org/399993002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moved all files from remoting/jingle_glue to remoting/signaling and
remoting/protocol.
The new remoting/signaling directory contains signaling layer implementation
for remoting that can be used independently of remoting/protocol.
TBR=rch@chromium.org
Review URL: https://codereview.chromium.org/390983003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This CL handles create a helper method in browser_tests to dismiss the host-out-of-date warning if it is displayed.
BUG=393072
Review URL: https://codereview.chromium.org/389673003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Some files were compiled for both remoting_host and remoting_core. Also
moved some files to remoting_host so that they don't need to be listed
multiple times for different platforms
Review URL: https://codereview.chromium.org/393073002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=393388
R=jamiewalch@chromium.org
Review URL: https://codereview.chromium.org/396063003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit 283542.
This broke the WebView Android build.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283591 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(This is a much larger change than its diff suggests. If it breaks something, please revert first and ask questions later.)
R=davidben@chromium.org, eroman@chromium.org, rsleevi@chromium.org
Review URL: https://codereview.chromium.org/345063006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=329109
Review URL: https://codereview.chromium.org/395003002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cliecked
This was a regression caused by crrev.com/279513
BUG=393388
R=jamiewalch@chromium.org
Review URL: https://codereview.chromium.org/394093002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is a regression of change r278331. We should let the default dispatchKeyEvent handler to handle KEYCODE_BACK instead of forwarding it to the host.
BUG=393055
Review URL: https://codereview.chromium.org/390983008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also fixes two issues in OSExchangeDataProviderWin:
- It used a disjoint set of clipboard formats when handling
GetUrl(..., true /* filename conversion */) vs GetFilenames(...), so the
actual returned results would vary depending on which one was called.
- It incorrectly used ::DragFinish() instead of ::ReleaseStgMedium().
::DragFinish() is only meant to be used in conjunction with WM_DROPFILES.
BUG=346135
Review URL: https://codereview.chromium.org/380553002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Even reinterpret_cast'ing this isn't well-defined apparently, but it
should compile and work in practice, at least on win/x86.)
BUG=82385
NOTRY=true
Review URL: https://codereview.chromium.org/392813002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
The PIN browser tests relies on versioned JavaScript test resources that needs to be archived in official builds.
Review URL: https://codereview.chromium.org/388903004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
The callback was not used
Review URL: https://codereview.chromium.org/387123003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Moved creation of ConnectionToHost to ChromotingClient. Previously
ConnectionToHost had to be passed in the constructor.
2. Authentication now is created outside of ChromotingClient. This
allowed to remove ClientConfig struct (it was used mostly to
pass authentication parameters). This will also allow passing
a fake authenticator for tests.
3. Removed ClientConfig.
Review URL: https://codereview.chromium.org/384523003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
> Updating XTBs based on .GRDs from branch 1985_103
TBR=matthewyuan@chromium.org
Review URL: https://codereview.chromium.org/386893002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is a typo in the output element of the "Build Remoting Webapp unittest.html" action. The current output element refers to a non-existent location. As a result, ninja invoke the action on every build run.
I also removes exclude-js from the input element, as there is no need to re-invoke the action if the content of an excluded script is modified.
BUG=392834
Review URL: https://codereview.chromium.org/385713003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Previously setClientSession was trying to call clientSession when it's
null.
BUG=392345
Review URL: https://codereview.chromium.org/380053002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also added unittests for client code.
TEST=unittests
Review URL: https://codereview.chromium.org/320403002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We would like single-line messages to center align with the icon and multi-line messages to top align with the icon.
In the existing implementation, we use a different CSS rule for multi-line messages to adjust the padding. This is undesirable as we can't predetermine whether a message would fit in one line before actually laying it out.
This change simplifies the CSS by vertical aligning text for error messages, which can achieve the desired behavior for both single and multi line messages.
Review URL: https://codereview.chromium.org/317013009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=wez@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/373213002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change enables running the JavaScript unit test on try bots and build bots using the browser test infrastructure.
To run a QUnit test suite as a browser test.
1. include third_party/qunit/src/browser_test_harness.js in your qunit test suite.
2. Derive your browser test from QUnitBrowserTestRunner, and call RunTest with the URL of the test suite.
3. modify chrome_tests.gypi to add the c++ source of your browser test and add your test suite as a run time dependency of the browser_tests executable
Summary of changes:
1. QUnit_browser_test_runner.h serves as a base class for a QUnit browser test. It navigates the browser to the QUnit test suite, calls browserTestHarness.run() and listens for the test results.
2. browser_test_harness.js serves as a test took on the QUnit test suite. Using the window.domAutomationController, browser_test_harness.js detects whether it is running under the browser test infrastructure to auto-enable itself and report results back to the browser test.
3. Updates browser_tests.isolate so that the test can run in an isolated test environment. See http://www.chromium.org/developers/testing/isolated-testing.
Review URL: https://codereview.chromium.org/376803005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Keep-alive above 250ms causes PseudoTCP to reset congestion window
between messages, making connection much less responsive.
BUG=391991
Review URL: https://codereview.chromium.org/376763002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also add missing functionality to URLRequestContextBuilder to fit
their needs. This is intended to simplify code to initialize the
network stack, and make it easier to refactor network stack
initialization.
BUG=388836
Review URL: https://codereview.chromium.org/354693004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This allows ScreenCapturer and VideoEncoder implementations to assume
that instances will always be deleted on the same thread from which they
are used (though they may still be created on a different thread).
Review URL: https://codereview.chromium.org/362063004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/351933003/)
Reason for revert:
Appears to have broken http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/12029/steps/browser_tests/logs/stdio
"isolate" in the error message is suspicious: http://www.chromium.org/developers/testing/isolated-testing
[ RUN ] QUnitBrowserTestRunner.Remoting_Webapp_Js_Unittest
Xlib: extension "RANDR" missing on display ":9".
Xlib: extension "RANDR" missing on display ":9".
[12246:12246:0704/181239:WARNING:password_store_factory.cc(213)] Using basic (unencrypted) store for password storage. See http://code.google.com/p/chromium/wiki/LinuxPasswordStorage for more information about password storage options.
../../chrome/test/remoting/qunit_browser_test_runner.cc:43: Failure
Value of: PathExists(file)
Actual: false
Expected: true
Error: The QUnit test suite </mnt/data/b/build/slave/Linux_Tests/isolate-2014-07-043CUE8r/out/Release/remoting/unittests/unittest.html> does not exist.
[12246:12310:0704/181239:WARNING:raw_channel_posix.cc(214)] recvmsg: Connection reset by peer
[ FAILED ] QUnitBrowserTestRunner.Remoting_Webapp_Js_Unittest, where TypeParam = and GetParam() = (329 ms)
Original issue's description:
> JavaScript unit test framework - Part II
>
> This change enables running the JavaScript unit test on try bots using the browser test infrastructure.
>
> To run a QUnit test suite as a browser test.
> 1. include third_party/qunit/src/browser_test_harness.js in your qunit test suite.
> 2. Derive your browser test from QUnitBrowserTestRunner, and call RunTest with the URL of the test suite.
> 3. modify chrome_tests.gypi to add the c++ source of your browser test and add your test suite as a run time dependency of the browser_tests executable
>
> Summary of changes:
> 1. QUnit_browser_test_runner.h serves as a base class for a QUnit browser test. It navigates the browser to the QUnit test suite, calls browserTestHarness.run() and listens for the test results.
>
> 2. browser_test_harness.js serves as a test took on the QUnit test suite. Using the window.domAutomationController, browser_test_harness.js detects whether it is running under the browser test infrastructure to auto-enable itself and report results back to the browser test.
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281451
TBR=sergeyu@chromium.org,rmsousa@chromium.org,jamiewalch@chromium.org,anandc@chromium.org,kelvinp@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/372563002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change enables running the JavaScript unit test on try bots using the browser test infrastructure.
To run a QUnit test suite as a browser test.
1. include third_party/qunit/src/browser_test_harness.js in your qunit test suite.
2. Derive your browser test from QUnitBrowserTestRunner, and call RunTest with the URL of the test suite.
3. modify chrome_tests.gypi to add the c++ source of your browser test and add your test suite as a run time dependency of the browser_tests executable
Summary of changes:
1. QUnit_browser_test_runner.h serves as a base class for a QUnit browser test. It navigates the browser to the QUnit test suite, calls browserTestHarness.run() and listens for the test results.
2. browser_test_harness.js serves as a test took on the QUnit test suite. Using the window.domAutomationController, browser_test_harness.js detects whether it is running under the browser test infrastructure to auto-enable itself and report results back to the browser test.
Review URL: https://codereview.chromium.org/351933003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=82385
TBR=awong@chromium.org
R=joaodasilva@chromium.org,sergeyu@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/367403002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This CL changes the redirect URI to use the intent scheme specified in https://developer.chrome.com/multidevice/android/intents.
The intent scheme can restrict a specific package to handle the intent and prevent a malicious app on the phone to intercept the access token.
Review URL: https://codereview.chromium.org/361053003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=garykac@chromium.org
BUG=390814
TEST=remoting_unittests
Review URL: https://codereview.chromium.org/362893005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=260879
Review URL: https://codereview.chromium.org/349223007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ServiceUrls is also usable on the client side, particularly to get bot
jid for logs. Moved to remoting/base where it can be reused by the
client.
Review URL: https://codereview.chromium.org/357503003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
VP9's CPUUSED settings go to 6, but 5 appears to provide the best
balance of quality vs performance right now.
BUG=260879
Review URL: https://codereview.chromium.org/354943003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280498 0039d316-1c4b-4281-b951-d872f2087c98
|