summaryrefslogtreecommitdiffstats
path: root/remoting
Commit message (Collapse)AuthorAgeFilesLines
* Revert of [Chromoting] Add GN build support for ar_sample_app target. ↵ksakamoto2015-05-088-450/+137
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #3 id:40001 of https://codereview.chromium.org/1126393002/) Reason for revert: Broke Linux GN Clobber build. http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20Clobber/builds/49/steps/compile/logs/stdio Original issue's description: > [Chromoting] Add GN build support for ar_sample_app target. > > This adds GN build rules for the AppRemoting sample app. > Some DesktopRemoting build rules were prettified as part of this > process (to make the App- and Desktop- remoting build rules more > similar). > > BUG=471916 > > Committed: https://crrev.com/13a3ca1f8053b1b2d195b8f5f52b90e184287ea8 > Cr-Commit-Position: refs/heads/master@{#328871} TBR=jamiewalch@chromium.org,garykac@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=471916 Review URL: https://codereview.chromium.org/1135603003 Cr-Commit-Position: refs/heads/master@{#328902}
* Changes to support GCD hosts:jrw2015-05-0810-30/+59
| | | | | | | | | | | | | - Added GCD device ID to host config. - Disabled email verification for GCD devices. Disabling email verification is necessary because it is apparently not possible to retrieve an email address for a device registered through GCD. BUG=471928 Review URL: https://codereview.chromium.org/1108203003 Cr-Commit-Position: refs/heads/master@{#328891}
* [Chromoting] Add GN build support for ar_sample_app target.garykac2015-05-078-137/+450
| | | | | | | | | | | | | This adds GN build rules for the AppRemoting sample app. Some DesktopRemoting build rules were prettified as part of this process (to make the App- and Desktop- remoting build rules more similar). BUG=471916 Review URL: https://codereview.chromium.org/1126393002 Cr-Commit-Position: refs/heads/master@{#328871}
* Moved It2Me host lookup into host_list_api_impl.js.jrw2015-05-075-68/+61
| | | | | | | | BUG=471928 Review URL: https://codereview.chromium.org/1124313002 Cr-Commit-Position: refs/heads/master@{#328868}
* Added GCD-related information to ServiceUrls.jrw2015-05-072-1/+27
| | | | | | | | BUG=471928 Review URL: https://codereview.chromium.org/1128753002 Cr-Commit-Position: refs/heads/master@{#328867}
* Updating XTBs based on .GRDs from branch masterPenny MacNeil2015-05-071-1/+1
| | | | Cr-Commit-Position: refs/heads/master@{#328844}
* remoting: Remove last X11 dependency from ozone buildspang2015-05-074-16/+79
| | | | | | | | | | | | | | | It's not possible to use Xrandr to configure the display in ozone builds. This code does not work anyway, so replace it with a stub so that we can actually compile without putting X into the build environment. BUG=484324 TEST=build for chromebook pixel with https://chromium-review.googlesource.com/#/c/269135/ Review URL: https://codereview.chromium.org/1120753009 Cr-Commit-Position: refs/heads/master@{#328813}
* Switch Me2Me BrowserTest to JavaScript.kelvinp2015-05-071-0/+53
| | | | | | | | | | | This CL switches the MANUAL_Me2Me_Connect_Local_Host and MANUAL_Me2Me_v2_Alive_OnLostFocus to JavaScript. BUG=480028 Review URL: https://codereview.chromium.org/1126363002 Cr-Commit-Position: refs/heads/master@{#328804}
* Normalize JIDs when comparing them in IqSender.sergeyu2015-05-072-23/+40
| | | | | | | | | | IqSender was using non-normalized JIDs when comparin from field in the response. This is not a problem at the moment, but it's still good to have this fixed to prevent problems like crbug.com/485134 in the future. Review URL: https://codereview.chromium.org/1131823002 Cr-Commit-Position: refs/heads/master@{#328789}
* Implement browser test for Me2Me retry logic when a host's JID is stale.kelvinp2015-05-074-5/+61
| | | | | | | | BUG=478331 Review URL: https://codereview.chromium.org/1126543007 Cr-Commit-Position: refs/heads/master@{#328682}
* Submission for C++ Readabilityjoedow2015-05-066-344/+187
| | | | | | | | | | | Files have had an extra newline appended to them so git will allow me to create a changelist to review. BUG= Review URL: https://codereview.chromium.org/1035903004 Cr-Commit-Position: refs/heads/master@{#328653}
* Normalize JIDs when generating signatures for messages sent to CRD bot.sergeyu2015-05-069-8/+75
| | | | | | | | | | | | | | When generating signatures for the messages sent to the bot the JID must be normalized, i.e. node and domain parts must be in lower-case. XmppSignalStrategy::GetLocalJid() was previously returning normalized value, but it was changed recently, which broke hosts that use account with upper-case characters in the name. BUG=485134 Review URL: https://codereview.chromium.org/1131653002 Cr-Commit-Position: refs/heads/master@{#328646}
* Remove HostSignalingManagersergeyu2015-05-064-217/+52
| | | | | | | | | | HostSignalingManager was added so the signaling connection outlive HostProcess object. That's no longer necessary and so this class can be removed as it wasn't doing anything useful anyway. Review URL: https://codereview.chromium.org/1123973002 Cr-Commit-Position: refs/heads/master@{#328632}
* Fix CandidateSessionConfig copy constructor to copy all fields.sergeyu2015-05-061-8/+1
| | | | | | | | | | | The constructor wasn't copying standard_ice field which breaks the case when older client connects to newer host. BUG=483325 Review URL: https://codereview.chromium.org/1125213003 Cr-Commit-Position: refs/heads/master@{#328631}
* Make setRemapKeys user-invokable and save the value per-host.jamiewalch2015-05-053-4/+33
| | | | | | | | | This was broken by a recent refactoring. Exposing the function via remoting.experimental provides a stable interface against future refactorings. Review URL: https://codereview.chromium.org/1121343002 Cr-Commit-Position: refs/heads/master@{#328434}
* Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in remoting module.anujk.sharma2015-05-056-17/+7
| | | | | | | | | | | | | MessageLoopProxy is deprecated. This basically does a search and replace: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). BUG=391045 Review URL: https://codereview.chromium.org/1113493005 Cr-Commit-Position: refs/heads/master@{#328413}
* GN Windows component build fixesbrettw2015-05-051-0/+4
| | | | | | | | | | | | | The main thing this fixes is the midi component. Previously midi_unittests was never compiled on any Windows component bot and the component build was all messed up. This patch makes the component build work correctly for this component. Remove installer_util_unittests.rc and its header. These seem to be autogenerated Visual Studio files. They just include the strings resource file, but GN includes the strings resource file itself by nature of the dependencies (GYP doesn't do this). CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg BUG=470212 Review URL: https://codereview.chromium.org/1121363002 Cr-Commit-Position: refs/heads/master@{#328383}
* Revert of Add AllReadDataConsumed and AllWriteDataConsumed methods to ↵piman2015-05-052-16/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | SocketDataProvider (patchset #4 id:60001 of https://codereview.chromium.org/1114383003/) Reason for revert: Suspected cause of IOS failure https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/builds/26420/steps/net_unittests%20%28iPhone%205%20iOS%208.1%29/logs/crash%20report%20%282015-05-05-113310%29 Original issue's description: > Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider > so that all provider subclasses can have their state verified. > > Committed: https://crrev.com/bce10d97d6fc5233071427cf622aaad7abde9e19 > Cr-Commit-Position: refs/heads/master@{#328154} > > Committed: https://crrev.com/269875cf0d23881a7ad119bae730ff54fdd4dd0b > Cr-Commit-Position: refs/heads/master@{#328351} TBR=rtenneti@chromium.org,sergeyu@chromium.org,rch@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1114353005 Cr-Commit-Position: refs/heads/master@{#328375}
* Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProviderrch2015-05-052-0/+16
| | | | | | | | | | | so that all provider subclasses can have their state verified. Committed: https://crrev.com/bce10d97d6fc5233071427cf622aaad7abde9e19 Cr-Commit-Position: refs/heads/master@{#328154} Review URL: https://codereview.chromium.org/1114383003 Cr-Commit-Position: refs/heads/master@{#328351}
* Revert of Add AllReadDataConsumed and AllWriteDataConsumed methods to ↵dbeam2015-05-052-16/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | SocketDataProvider (patchset #3 id:40001 of https://codereview.chromium.org/1114383003/) Reason for revert: Final stop on the revert train! net_unittests on iOS Simulator (dbg) (iPhone 5 ios 8.1) should be fixed after this? https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_(dbg) Here's a log of the break: https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/builds/26378/steps/net_unittests%20%28iPhone%205%20iOS%208.1%29/logs/crash%20report%20%282015-05-04-164655%29 Original issue's description: > Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider > so that all provider subclasses can have their state verified. > > Committed: https://crrev.com/bce10d97d6fc5233071427cf622aaad7abde9e19 > Cr-Commit-Position: refs/heads/master@{#328154} TBR=rtenneti@chromium.org,sergeyu@chromium.org,rch@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1119803006 Cr-Commit-Position: refs/heads/master@{#328271}
* [Chromoting] Update list of webapp locales to match Chrome's locales.dcaiafa2015-05-052-6/+6
| | | | | | | | | | | | | | With this change the GN and GYP webapp builds will once again produce identical results. The remoting_localize.py change is necessary to avoid having Fake-bidi conflict with Hebrew. BUG= Review URL: https://codereview.chromium.org/1126683003 Cr-Commit-Position: refs/heads/master@{#328259}
* win: Add an "override" I forgot in https://codereview.chromium.org/1126643002/.thakis2015-05-051-1/+1
| | | | | | | | | | | | | Fixes ..\..\remoting/host/win/rdp_desktop_session.h(40,23) : warning(clang): [chromium-style] Overriding method must be marked with 'override' or 'final'. BUG=467287 TBR=sergeyu@chromium.org Review URL: https://codereview.chromium.org/1122143002 Cr-Commit-Position: refs/heads/master@{#328251}
* Revert of Revert some other possible suspects of a 0.43% size increase of ↵dbeam2015-05-043-1/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | setup.exe: https://build.chromium.o… (patchset #1 id:1 of https://codereview.chromium.org/1124563003/) Reason for revert: Broke the compile because one of these CLs is already depended on (rch@'s bce10d97d6fc5233071427cf622aaad7abde9e19). Original issue's description: > Revert some other possible suspects of a 0.43% size increase of setup.exe: https://build.chromium.org/p/chromium/builders/Win/builds/31562 > > Revert "Add granular base::File tracing." > > This reverts commit a6e05c977096a03774e5406d63ad80c0166f9adc. > > Revert "Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider" > > This reverts commit bce10d97d6fc5233071427cf622aaad7abde9e19. > > Revert "Avoid unnecessary memory allocations at PlatformThread::SetName()" > > This reverts commit 4839a142bf95776323647c82ca9dc0725f7c4f15. > > TBR=tdresser@chromium.org > BUG=none > TEST=green sizes > > Committed: https://chromium.googlesource.com/chromium/src/+/c41830d6f55f85e2f5c8841db4b6ed81239b671d TBR=tdresser@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Review URL: https://codereview.chromium.org/1123833003 Cr-Commit-Position: refs/heads/master@{#328207}
* Revert of Add AllReadDataConsumed and AllWriteDataConsumed methods to ↵dbeam2015-05-042-16/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | SocketDataProvider so that all provider… (patchset #1 id:1 of https://codereview.chromium.org/1127623003/) Reason for revert: Still not compiling. Order-dependent revert fun to ensue. End result: this CL and any dependent CL will be re-instated. Original issue's description: > Re-instating r328154 because it's depended on to compile. > > Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider so that all provider subclasses can have their state verified. > > Review URL: https://codereview.chromium.org/1114383003 > > Cr-Commit-Position: refs/heads/master@{#328154} > > TBR=rch@chromium.org > BUG= > > Committed: https://chromium.googlesource.com/chromium/src/+/2b2149aa9dfc5fbbb4ef0df2b89b5f392383f41a TBR=rch@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1123643006 Cr-Commit-Position: refs/heads/master@{#328206}
* Re-instating r328154 because it's depended on to compile.Dan Beam2015-05-042-0/+16
| | | | | | | | | | | | | | | Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider so that all provider subclasses can have their state verified. Review URL: https://codereview.chromium.org/1114383003 Cr-Commit-Position: refs/heads/master@{#328154} TBR=rch@chromium.org BUG= Review URL: https://codereview.chromium.org/1127623003 Cr-Commit-Position: refs/heads/master@{#328205}
* Revert some other possible suspects of a 0.43% size increase of setup.exe: ↵Dan Beam2015-05-043-17/+1
| | | | | | | | | | | | | | | | | | | | | | | | https://build.chromium.org/p/chromium/builders/Win/builds/31562 Revert "Add granular base::File tracing." This reverts commit a6e05c977096a03774e5406d63ad80c0166f9adc. Revert "Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider" This reverts commit bce10d97d6fc5233071427cf622aaad7abde9e19. Revert "Avoid unnecessary memory allocations at PlatformThread::SetName()" This reverts commit 4839a142bf95776323647c82ca9dc0725f7c4f15. TBR=tdresser@chromium.org BUG=none TEST=green sizes Review URL: https://codereview.chromium.org/1124563003 Cr-Commit-Position: refs/heads/master@{#328199}
* [Chromoting] Remove Application.Modegarykac2015-05-0414-96/+97
| | | | | | | | | | | | | | | | | | | Application.Mode was effectively a global variable that kept track of which app was running (DesktopRemoting vs. AppRemoting) and which mode (It2ME or Me2Me). This cl removes Application.Mode and moves the Mode tracking into the DesktopRemoting app. There are only a few remaining places in the code that care about the It2Me vs Me2Me distinction (testing, menu enabling, logging, ...). Requires that crrev.com/1095203010 land first. BUG= Review URL: https://codereview.chromium.org/1105853004 Cr-Commit-Position: refs/heads/master@{#328179}
* win: Give RdpDesktopSession an explicit out-of-line destructor.thakis2015-05-042-0/+4
| | | | | | | | | | | | Fixes: ..\..\remoting/host/win/rdp_desktop_session.h(22,1) : warning(clang): [chromium-style] Complex class/struct needs an explicit out-of-line destructor. BUG=467287 Review URL: https://codereview.chromium.org/1126643002 Cr-Commit-Position: refs/heads/master@{#328169}
* Avoid unnecessary memory allocations at PlatformThread::SetName()mikhail.pozdnyakov2015-05-041-1/+1
| | | | | | | | | | | | | | The PlatformThread::SetName() method used to accept 'name' parameter as 'const char*' even though all the clients stored as 'std::string' and thus had to convert, further inside PlatformThread::SetName() it was converted back to 'std::string' (when passing to ThreadIdNameManager::SetName()) leading to unnecessary memory allocations. See also: https://groups.google.com/a/chromium.org/forum/#!msg/chromium-dev/EUqoIz2iFU4/kPZ5ZK0K3gEJ Review URL: https://codereview.chromium.org/1093223007 Cr-Commit-Position: refs/heads/master@{#328157}
* Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProviderrch2015-05-042-0/+16
| | | | | | | | so that all provider subclasses can have their state verified. Review URL: https://codereview.chromium.org/1114383003 Cr-Commit-Position: refs/heads/master@{#328154}
* Making AppCompat happy with explicit windowNoTitle attribute.lukasza2015-05-021-0/+1
| | | | | | | | BUG=483669 Review URL: https://codereview.chromium.org/1120223002 Cr-Commit-Position: refs/heads/master@{#328030}
* Add a GN flag for the Windows multi-dll build.brettw2015-05-012-0/+3
| | | | | | | | | | | | | The first pass of moving the other Chrome-specific build flags out of the root build config file and into the new one. This requires both ffmpeg and Blink changes to finish landing. Originally landed as https://codereview.chromium.org/1120803003/ TBR=scottmg@chromium.org TBR=ddorwin@chromium.org (widevine) CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Review URL: https://codereview.chromium.org/1123433002 Cr-Commit-Position: refs/heads/master@{#327998}
* Updating XTBs based on .GRDs from branch masterPenny MacNeil2015-05-0141-1/+370
| | | | Cr-Commit-Position: refs/heads/master@{#327972}
* Adjust URLFetcher::Create API so that object is returned as scoped_ptr.dtapuska2015-05-014-8/+8
| | | | | | | | | | | | | | | | | | | | Most interfaces were storing the object in a scoped_ptr already. This adjusts the API so that it is a little clearer of the ownership transfer. A number of clients put the URLFetcher in a table and do memory management on it themselves; this is likely templatable code for a future CL. The scope of this CL was to change the API but no control flow changes. Making this change found one memory leak; (http://crbug.com/482459) has been addressed separately. BUG=371201 TESTS=net_unittests google_api_unittests TBR=jochen@chromium.org, thakis@chromium.org, oshima@chromium.org, armansito@chromium.org, reillyg@chromium.org, rogerta@chromium.org, stuartmorgan@chromium.org, wez@chromium.org, pavely@chromium.org, rouslan@chromium.org Review URL: https://codereview.chromium.org/1117703002 Cr-Commit-Position: refs/heads/master@{#327901}
* Revert of Add a GN flag for the Windows multi-dll build. (patchset #3 ↵rickyz2015-05-012-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | id:40001 of https://codereview.chromium.org/1120803003/) Reason for revert: May have caused some link errors on windows: https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/814 Original issue's description: > Add a GN flag for the Windows multi-dll build. > > The first pass of moving the other Chrome-specific build flags out of the root build config file and into the new one. This requires both ffmpeg and Blink changes to finish landing. > > R=scottmg@chromium.org > TBR=ddorwin@chromium.org (widevine) > > Committed: https://crrev.com/edff53a35780ba2f515c7e8d4f7131c91151e1a3 > Cr-Commit-Position: refs/heads/master@{#327854} TBR=scottmg@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1117063004 Cr-Commit-Position: refs/heads/master@{#327861}
* Turn off remoting on the Mac GN build to avoid confusion for now.dpranke2015-05-011-1/+2
| | | | | | | | | | | | | | | Since it doesn't really work yet, things are slightly cleaner if we don't try to build anything we don't yet need. I will reenable what I can once the rest of the port is caught up. TBR=garykac@chromium.org BUG=431177 CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Review URL: https://codereview.chromium.org/1121623004 Cr-Commit-Position: refs/heads/master@{#327858}
* Add a GN flag for the Windows multi-dll build.brettw2015-05-012-0/+3
| | | | | | | | | | | The first pass of moving the other Chrome-specific build flags out of the root build config file and into the new one. This requires both ffmpeg and Blink changes to finish landing. R=scottmg@chromium.org TBR=ddorwin@chromium.org (widevine) Review URL: https://codereview.chromium.org/1120803003 Cr-Commit-Position: refs/heads/master@{#327854}
* Logging client disconnected events (incl. the error code)lukasza2015-04-301-1/+2
| | | | | | | | | | | | | | to help diagnose stale access token in some app remoting scenarios (tracked internally at b/20662147) The new log entry complements an existing one that logs client connected events in ChromotingHost::OnIncomingSession (chromoting_host.cc:302). BUG= Review URL: https://codereview.chromium.org/1117043002 Cr-Commit-Position: refs/heads/master@{#327822}
* Apply automated fixits for Chrome clang plugin to remoting.dcheng2015-04-295-11/+13
| | | | | | | | | | | Working on trimming down plugin warnings on the Windows clang build. BUG=467287 TBR=jamiewalch@chromium.org Review URL: https://codereview.chromium.org/1115773002 Cr-Commit-Position: refs/heads/master@{#327548}
* [Chromoting] Build webapp package with browser test JavaScript files loaded.kelvinp2015-04-295-18/+74
| | | | | | | | | | | | This CL creates a new target webapp with browser test JavaScript files loaded. This will enable us to run a JavaScript browser test using a regular chrome binary to speed up development and debugging. BUG= Review URL: https://codereview.chromium.org/1091293004 Cr-Commit-Position: refs/heads/master@{#327438}
* Added ability to register new hosts using GCD.jrw2015-04-297-141/+81
| | | | | | | | | | | Hosts registered through GCD can't be brought online yet, because the host doesn't know how to use the XMPP credentials it gets from GCD. BUG=471928 Review URL: https://codereview.chromium.org/1111603002 Cr-Commit-Position: refs/heads/master@{#327427}
* [Chromoting] Add missing file to webapp's GN build.garykac2015-04-282-2/+19
| | | | | | | | | | | This also makes the Note at the top of the files (to keep the GYP and GN files in sync) a bit more noticeable. BUG= Review URL: https://codereview.chromium.org/1116463002 Cr-Commit-Position: refs/heads/master@{#327378}
* Include application ID in log entries.anandc2015-04-282-0/+13
| | | | | | | | BUG=b/19609728 Review URL: https://codereview.chromium.org/1066003007 Cr-Commit-Position: refs/heads/master@{#327338}
* Added ability to list and delete hosts with GCD.jrw2015-04-282-8/+68
| | | | | | | | BUG=471928 Review URL: https://codereview.chromium.org/1104383002 Cr-Commit-Position: refs/heads/master@{#327219}
* [Chromoting] Remove CRD-specific JS files from AppRemoting build.garykac2015-04-283-30/+51
| | | | | | | | | | | | | | | Recent refactoring allows us to remove many CRD-specific files from the set of "common" JS files. This cl moves the CRD UI JS files out of the AppRemoting build. This is in preparation for removing Application.Mode in a follow-up cl. Requires that crrev.com/1109453005 land first. BUG= Review URL: https://codereview.chromium.org/1095203010 Cr-Commit-Position: refs/heads/master@{#327205}
* Uncomment missing GN resource dependencies in remoting.dpranke2015-04-271-14/+14
| | | | | | | | | | | | Without these, a GN clobber build fails, and we get warnings during the non-compile builds. R=garykac@chromium.org BUG= Review URL: https://codereview.chromium.org/1108953002 Cr-Commit-Position: refs/heads/master@{#327165}
* Make the ChromeOS GN debug component build work.dpranke2015-04-271-0/+10
| | | | | | | | | | | | This CL contains several fixes needed to make the ChromeOS GN debug component build link. R=brettw@chromium.org, erg@chromium.org, garykac@chromium.org, kjellander@chromium.org BUG=433082 CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_gn_chromeos_dbg;tryserver.chromium.mac:mac_chromium_gn_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg Review URL: https://codereview.chromium.org/1054963007 Cr-Commit-Position: refs/heads/master@{#327164}
* Make loading dialog prettier.jamiewalch2015-04-2710-49/+139
| | | | | | | | | | Since the width of this dialog is no longer fixed, this CL also updates base.resizeWindowToContent to set the width as well as the height, and adds support for centering. BUG=b/19796166 Review URL: https://codereview.chromium.org/1081813007 Cr-Commit-Position: refs/heads/master@{#327160}
* base: Remove using declaration from test_suite.h header.tfarina2015-04-271-1/+1
| | | | | | | | | | | | | | WebKit has been fixed in https://src.chromium.org/viewvc/blink?revision=193998&view=revision BUG=None TEST=trybots R=thestig@chromium.org TBR=sergeyu@chromium.org,cpu@chromium.org Review URL: https://codereview.chromium.org/1053123010 Cr-Commit-Position: refs/heads/master@{#327147}
* Added unit tests for getCredentialsFromAuthCode.jrw2015-04-2710-91/+216
| | | | | | | | BUG=471928 Review URL: https://codereview.chromium.org/1099553003 Cr-Commit-Position: refs/heads/master@{#327144}
generated by cgit v1.1 at 2025-03-17 15:31:58 +0000