| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
Use StringPiece for IsStringUTF8.
TBR=sky
Review URL: https://codereview.chromium.org/196793010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix all forward-declares and header files referencing CommandLine.
This keeps a "using base::CommandLine" in the command line header file so that the rest of the source files can be changes in a follow-up.
TBR=sky
Review URL: https://codereview.chromium.org/196413016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These inputs are not necessary because RULE_INPUT_PATH is always
an input of a rule. And the .gyp spec doesn't guarantee that the
RULE_INPUT_* variables exist for the inputs list.
BUG=
R=sergeyu@chromium.org
Review URL: https://codereview.chromium.org/197233010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The directory server omits the host "items" list entirely, instead of
sending an empty list.
BUG=352398,333131
NOTRY=true
Review URL: https://codereview.chromium.org/197313008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes WideToASCII and changes all callers to use UTF16ToASCII instead.
Moves UTF16ToASCII from base/strings/string_util.h to base/strings/utf_string_conversions.h and into the base namespace.
Convert a few related string_util functions to take a StringPiece16 instead of a string16. Remove IsStringASCII(std::wstring) which was unused.
Updates callers' includes and namespace usage accordingly.
TBR=sky
Review URL: https://codereview.chromium.org/176843022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This follows the rule we setup for //ui which states that each subdir
should be its own component with its own gyp file that lives in its
subdir.
The 'ui' target was renamed to ui_base to match the convention.
BUG=299841
TEST=gyp files.
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/198333004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
used for a given render process id. This special cookie store will then
be used for renderer messages pertaining to cookies, url fetches in net,
and websockets. If the special cookie store is NULL, a default cookie store
will be used.
Re-submit of https://codereview.chromium.org/188693003
See https://codereview.chromium.org/188693003 for reviewers/lgtm's.
Review URL: https://codereview.chromium.org/197043005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This broke the Android builders. The try-bots on the CL did point
out the compile errors, but it was committed manually anyway. Logs:
http://build.chromium.org/p/chromium.linux/builders/Android%20Clang%20Builder%20%28dbg%29/builds/30977/steps/compile/logs/stdio
> Allow the content browser client to specify a special cookie store to be
> used for a given render process id. This special cookie store will then
> be used for renderer messages pertaining to cookies, url fetches in net,
> and websockets. If the special cookie store is NULL, a default cookie store
> will be used.
>
> R=erikwright@chromium.org, jam@chromium.org, lambroslambrou@chromium.org, mmenke@chromium.org, tyoshino@chromium.org
>
> Review URL: https://codereview.chromium.org/188693003
TBR=tburkard@chromium.org
Review URL: https://codereview.chromium.org/197463003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
used for a given render process id. This special cookie store will then
be used for renderer messages pertaining to cookies, url fetches in net,
and websockets. If the special cookie store is NULL, a default cookie store
will be used.
R=erikwright@chromium.org, jam@chromium.org, lambroslambrou@chromium.org, mmenke@chromium.org, tyoshino@chromium.org
Review URL: https://codereview.chromium.org/188693003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
After the native messaging channel starts the native messaging reader will keep doing blocking read operations on the input named pipe. If any other thread tries to perform any operation on STDIN, it will also block because the input named pipe is synchronous (non-overlapped).
It is pretty common for a DLL to query the device info (GetFileType) of the STD* handles at startup. So any LoadLibrary request can potentially be blocked. To prevent that from happening we close STDIN and STDOUT handles as soon as we retrieve the corresponding file handles.
BUG=350071
Review URL: https://codereview.chromium.org/194913004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When host installation is cancelled HostSetupDialog dialog is supposed
to hide the installation prompt, but previously it only updated
internal state, but not webapp UI state.
BUG=350211
R=jamiewalch@chromium.org
Review URL: https://codereview.chromium.org/196313002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to the base namespace
This function is only used in a few places and can trivially be implemented by passing the whitespace constant to the existing ContainsOnlyChars function.
This changes the ContainsOnlyChars function signature to take a StringPiece to avoid a copy from a literal to a standard string in the above-mentioned use-base.
Re-implement ContainsOnlyChars to use the find_first_not_of function on StringPiece.
BUG=
R=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/183683024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=270362
R=lambroslambrou@chromium.org
Review URL: https://codereview.chromium.org/187313007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=333129
Review URL: https://codereview.chromium.org/187663005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=349781
NOTRY=true
Review URL: https://codereview.chromium.org/177923009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=viettrungluu@chromium.org
TBR=viettrungluu
Review URL: https://codereview.chromium.org/184563006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Add VP9 encode support to the remoting host.
>
> BUG=260879,349862
>
> Review URL: https://codereview.chromium.org/28183002
TBR=wez@chromium.org
Review URL: https://codereview.chromium.org/188563002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=260879
Review URL: https://codereview.chromium.org/28183002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change is to add a new build option 'use_allocator' which will
replace 'linux_use_tcmalloc' in the future. It doesn't change the
behavior immediately. The migration plan is as follows:
1) (this change)
... Add 'use_allocator' and set its default to "see_use_tcmalloc".
... Change allocator conditions to check use_allocator firstly.
... Use linux_use_tcmalloc if use_allocator=="see_use_tcmalloc".
... NO IMPACT without specifying use_allocator explicitly.
2) Change Blink to accept use_allocator. http://crrev.com/177053003/
3) Change gyp to accept use_allocator. http://crrev.com/178643004/
4) PSA the transition period to chromium-dev@.
5) (after the PSA-ed transition period)
... Make 'use_allocator' to "tcmalloc" or "none" (it depends) by default.
... Remove all linux_use_tcmalloc.
... Assert in gyp_chromium to check if linux_use_tcmalloc is not specified.
At the point of this change (1), linux_use_tcmalloc is still used by default
because 'use_allocator%': "see_use_tcmalloc".
As written in http://crbug.com/345554, linux_use_tcmalloc would
be confusing to have more options about allocators. We plan to:
A) enable gperftools' heap-profiler with non-tcmalloc allocator,
B) add a new memory allocator instead of tcmalloc.
BUG=345554, 339604, 341349
R=agl@chromium.org, brettw@chromium.org, dgarrett@chromium.org, jam@chromium.org, jamesr@chromium.org, joi@chromium.org, miket@chromium.org, nick@chromium.org, rsleevi@chromium.org, scherkus@chromium.org, sergeyu@chromium.org, shess@chromium.org, sievers@chromium.org, sky@chromium.org, vitalybuka@chromium.org, willchan@chromium.org
Review URL: https://codereview.chromium.org/177353002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=270362
NOTRY=true
Review URL: https://codereview.chromium.org/185853005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=316522
NOTRY=true
Review URL: https://codereview.chromium.org/187023003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The warning about unused PRODUCT_DESCRIPTION resource
was introduced in r254355.
R=jamiewalch@chromium.org
Review URL: https://codereview.chromium.org/184823010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
host to ensure the UAC prompt has focus.
BUG=347776
Review URL: https://codereview.chromium.org/183513006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=347784
Review URL: https://codereview.chromium.org/184893004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This replaces the hard-coded "Android" string with a more descriptive
identifier such as "Nexus 7".
BUG=330899
Review URL: https://codereview.chromium.org/177313007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Since the Chromoting app is unusable without a Google account, show a
dialog in this case, with an option to add a Google account.
R=jamiewalch@chromium.org
Review URL: https://codereview.chromium.org/178583011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=viettrungluu@chromium.org, viettrungluu
Review URL: https://codereview.chromium.org/183853011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=276739
Review URL: https://codereview.chromium.org/185163002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These copies are no longer required, since the Android resources now
follow the correct directory layout. More importantly, this prevents
build failures resulting from stale copies of resources, which can
happen if an xml resource file is deleted (for example, if a CL that
adds a new XML file gets reverted).
This also moves the README file up a level, since the android resources
directory cannot contain any non-resource files.
NOTRY=true
Review URL: https://codereview.chromium.org/183863003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
is started.
BUG=347763
Review URL: https://codereview.chromium.org/181773009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
For consistency with Mac and Linux
Review URL: https://codereview.chromium.org/181433018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=340312
Review URL: https://codereview.chromium.org/178613006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=347356
NOTRY=true
Review URL: https://codereview.chromium.org/182533003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added two new targets remoting_webapp_v1 and remoting_webapp_v2. Both
include the new remoting_webapp.gypi. remoting_webapp target
depends on both. Also moved these targets to remoting_client.gypi.
remoting_webapp.gypi will also be reused for webapp version that
uses PNaCl plugin.
BUG=276739
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253800
R=jamiewalch@chromium.org
Review URL: https://codereview.chromium.org/181473008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/181473008/)
Reason for revert:
Appears to have broken the build:
http://build.chromium.org/p/chromium/builders/Linux/builds/47807
...
adding: chrome-linux/chrome (deflated 58%)
Traceback (most recent call last):
File "../../../scripts/slave/chromium/archive_build.py", line 760, in <module>
chromium_utils.CopyFileToDir(src/out/Release/remoting-webapp.v2.zip, /b/build/slave/Linux/chrome_staging/, dest_fn=remoting-webapp.v2.zip)
sys.exit(main(None))
File "../../../scripts/slave/chromium/archive_build.py", line 756, in main
return s.ArchiveBuild()
File "../../../scripts/slave/chromium/archive_build.py", line 571, in ArchiveBuild
os.path.join(self._staging_dir, stage_subdir), dest_fn=stage_fn)
File "/b/build/scripts/common/chromium_utils.py", line 485, in CopyFileToDir
raise PathNotFound('Unable to find file %s' % src_path)
common.chromium_utils.PathNotFound: Unable to find file src/out/Release/remoting-webapp.v2.zip
Original issue's description:
> Cleanup remoting.gyp around the remoting_webapp target
>
> Added two new targets remoting_webapp_v1 and remoting_webapp_v2. Both
> include the new remoting_webapp.gypi. remoting_webapp target
> depends on both. Also moved these targets to remoting_client.gypi.
> remoting_webapp.gypi will also be reused for webapp version that
> uses PNaCl plugin.
>
> BUG=276739
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253800
TBR=jamiewalch@chromium.org,garykac@chromium.org,sergeyu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=276739
Review URL: https://codereview.chromium.org/180783007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/181653007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added two new targets remoting_webapp_v1 and remoting_webapp_v2. Both
include the new remoting_webapp.gypi. remoting_webapp target
depends on both. Also moved these targets to remoting_client.gypi.
remoting_webapp.gypi will also be reused for webapp version that
uses PNaCl plugin.
BUG=276739
Review URL: https://codereview.chromium.org/181473008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=134250
Review URL: https://codereview.chromium.org/166273022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous fix in r252903 (--deep parameter for codesign) didn't help
presumably because the signing bot uses an older version of the
codesign tool that doesn't support --deep. Updated do_signing.sh script
to sign the binaries explicitly.
BUG=345967
R=jamiewalch@chromium.org
Review URL: https://codereview.chromium.org/181673004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a Help & feedback menu-item for each screen of the app. The
Help screen embeds a WebView, which shows a URL dependent on
which screen the Help was launched from.
There is also a Feedback menu-item, which is currently hidden, pending
implementation of this feature (only the Official build will have it).
A menu-item is provided for showing the Play Store entry for the
application. More menu-items can be added (such as Copyright,
Privacy policy, Open source licences) if they are required in the app.
BUG=333129
NOTRY=true
Review URL: https://codereview.chromium.org/179003006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
R=jamiewalch@chromium.org
Review URL: https://codereview.chromium.org/181473004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
No intended behaviour change.
TBR=owners
BUG=none
Review URL: https://codereview.chromium.org/180873004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
HostController always reports local host state as NOT_INSTALLED when
host is not installed, while HostList expected it to be reported as
NOT_IMPLEMENTED when the current platform is not supported. Fixed
HostList to call remoting.isMe2MeInstallable() to decide if host
controls must be shown when host state is reported as NOT_INSTALLED.
BUG=346528
Review URL: https://codereview.chromium.org/180783002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
On connection failure (when the host appears to be offline), the
Android Chromoting client will reload the host list and re-attempt the
connection automatically.
BUG=304719
Review URL: https://codereview.chromium.org/179063004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This will reduce the size of remote_assistance_host.exe and thus the host download.
The size of the debug binary went down from 22MB to 440KB.
BUG=309844
Review URL: https://codereview.chromium.org/178473002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Most of the common logic and response handling code are moved into a base class, and the implementation contains just the logic to prepare the validation request (which is where the actual keypair-based authentication happens). This makes it easier to implement different, non-keypair-based host authentication mechanisms.
BUG=
Review URL: https://codereview.chromium.org/165293004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since the icon does not work well with light themes, this CL specifies
Holo Dark theme for the app, instead of the device default.
Also removed text next to icons, as the keyboard icon does not have
sufficient padding. The icon is descriptive enough in itself, and the
text appears anyway if you long-press the buttons.
BUG=338773
NOTRY=true
Review URL: https://codereview.chromium.org/180703002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This significantly reduces the size of remoting_native_messaging_host.exe and thus the download size of the Windows host package. The size of the debug binary was reduced to 440k from 17M.
BUG=325567
Review URL: https://codereview.chromium.org/166203003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
dialog_client.html was missing from the template list and the old build did not report an error. This change requires that he expected list of templates be passed to the HTML generator script so that it can be verified that all the dependencies are specified.
This also moves the dialog_client template into the main template so that we include everything directly from template_main.html.
This also removes some end-tag comments that are no longer needed since the structure can be more easily seen.
BUG=
Review URL: https://codereview.chromium.org/176013002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/166263003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253152 0039d316-1c4b-4281-b951-d872f2087c98
|