| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
The newer python psutil-2.x release has reworked the API in backwards
incompatible ways. Add some glue to handle both series.
BUG=None
TEST=ran script w/psutil-2.1.x and it worked again
Review URL: https://codereview.chromium.org/235883005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Play Store imposes a stricter length limit (30-char) than Chrome Web
Store, so apply a 'meaning' attribute to the Play Store title, so its
translation is handled separately.
TEST=remoting_resources target builds successfully.
Review URL: https://codereview.chromium.org/228663011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In some cases the host may get invalid mouse-move events, so it
thinks that local user is moving the mouse, and as result it
starts dropping all input events. Now LocalInputMonitorMac ignores
mouse-move event when mouse position isn't changing.
BUG=360912
R=jamiewalch@chromium.org
Review URL: https://codereview.chromium.org/233083005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Translation console uses 'iw' and 'no' language codes for Hebrew and
Norwegian Bokmål instead of 'he' and 'nb' used for the same languages
in Chrome. Previously the xtb files for chromoting were using he and nb
codes, and as result these files were not updated.
BUG=362338
R=lambroslambrou@chromium.org
Review URL: https://codereview.chromium.org/233293006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This only adds it to the home screen. I will follow up with a CL that refactors
the in-session tool-bar to allow us to add it there as well.
BUG=343773
NOTRY=true
R=garykac@chromium.org
Review URL: https://codereview.chromium.org/233973004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Both base and protocol directories had util.cc files, which confuses
the linker when compiling them into a single static .a lib.
BUG=276739
Review URL: https://codereview.chromium.org/231943005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(instead of bools)
Previously committed as https://src.chromium.org/viewvc/chrome?view=rev&revision=261966 but then reverted when it broke the Mac 10.6 build.
TBR=sergeyu,yzshen,yurys,zea
R=wtc
BUG=355222
Review URL: https://codereview.chromium.org/227473008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=360114
Review URL: https://codereview.chromium.org/229643002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
neither the host nor the plugin is present.
The reason we didn't catch this earlier is that chrome throws different errors upon native messaging connection request when the NM host manifest is not present vs. when the manifest is present but not the host binary. We now show the host setup dialog when the native messaging connection fails for any reason before it is initialized. It is not reliable to depend on exact error message string match anyway.
BUG=360678
Review URL: https://codereview.chromium.org/227903002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To prevent a malicious client from guessing the PIN by spamming the host with bogus logins, the chromoting host can throttle incoming requests after too many unsuccessful login attempts. In the current implementation, every time when there is an incoming request, we start incrementing the bad login counter, regardless of whether the host has actually starts authenticating.
Fix:
This change adds an extra flag on the authenticator to indicate whether authentication has started.
The JingleSession checks the flag and progagates the message back all the way up to the host through the callback Session::OnSessionAuthenticationBegin
BUG=350208
Review URL: https://codereview.chromium.org/205583011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
FileStream will drop support of synchronous methods.
Use base::File instead.
BUG=351823
TEST=remoting_unittests
Review URL: https://codereview.chromium.org/225553003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Appears to have broken the following gcm_unit_tests on Mac:
DeviceCredentials
AckOnLogin
AckWhenLimitReachedWithHeartbeat
ExpiredTTLOnRestart
InitializeExisting
SendMessageRMQAckOnReconnect
SendMessageRMQOnRestart
SendMessageRMQPartialAckOnReconnect
SendMessageRMQWithStreamAck
http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%284%29/builds/39860
> make SetReceiveBufferSize and SetSendBufferSize return net error codes (instead of bools)
>
> TBR=sergeyu,yzshen
> R=wtc
> BUG=355222
>
> Review URL: https://codereview.chromium.org/217573002
TBR=jar@chromium.org
Review URL: https://codereview.chromium.org/227083002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The bump scrolling issue is a regression of the change below
https://codereview.chromium.org/134163005
In the change, the plugin is resized using plugin.style.height and the bump scrolling code is using plugin.height to determine its min scrolling position. As a result, the element is often reported as non-scrollable.
The fix is to use clientHeight to determine the size of the plugin instead.
To improve the reliability of the display of the scroll-bars. We subscribed to the full-screen event and adjust the visibility scroll-bar accordingly.
Review URL: https://codereview.chromium.org/222003009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(instead of bools)
TBR=sergeyu,yzshen
R=wtc
BUG=355222
Review URL: https://codereview.chromium.org/217573002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update the host icons to the new style which includes the Chrome logo.
This affects all chromoting components, including the Android app and
the webapp.
All icons are based off the 512x512 PNG in the linked bug.
The smaller sizes were generated with ImageMagick, for example:
convert chromoting512.png -resize 48x48 chromoting48.png
ICO file was generated with:
convert chromoting16.png chromoting32.png chromoting48.png chromoting.ico
WebP versions were generated using cwebp:
for i in chromoting*.png; do \
cwebp -lossless -q 100 -m 6 $i -o ${i%.png}.webp; done
Android empty_host_list icon was made by cropping 512x512 to 510x510,
then shrinking by a factor of 3, then converting to grayscale, then
darkening the image using GIMP and cropping to a few-pixels-wide
margin.
All PNGs were optimized by running:
tools/resources/optimize-png-files.sh -o2 remoting/resources
BUG=334830
R=jamiewalch@chromium.org
Review URL: https://codereview.chromium.org/222673002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Cause and Fix:
Setting flex-shrink=0 to the plugin to make it non re-sizable
BUG=358139
Review URL: https://codereview.chromium.org/217713004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/210093006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=260879
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255208
Review URL: https://codereview.chromium.org/28183002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=357715
TEST=none
Review URL: https://codereview.chromium.org/217133007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Cause:
This bug only repro on chrome v33 and v34
<div class="vertically-centered">
<div class="horizontally-centered">
<div id="video-container">
<video id="mediasource-video-output"></video>
<div id="client-plugin-container"></div>
</div>
</div>
</div>
Due to a chrome layout bug, the width of video-container collapses to 0 when the zoom level is greater than 100%. As a result, the flexbox defined in horizonally-centered fails to center the element.
Fix:
Set width=100% on video-container so that its width remains valid. Since video-container now sizes to the parent, we need to move the horizontal-centered flexbox to the children of video-container.
BUG=357114
Review URL: https://codereview.chromium.org/217363002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Click-to-play was broken when the plugin resizing code was
changed to update plugin style instead of width/height fields
directly. Problem is that
remoting.ClientPlugin.showPluginForClickToPlay() was still using
trying to set width/height which are overridden by the CSS size.
NOTRY=true
Review URL: https://codereview.chromium.org/217353002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=357593
NOTRY=true
Review URL: https://codereview.chromium.org/216693005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=270356,265945
R=lambroslambrou@chromium.org
Review URL: https://codereview.chromium.org/214193002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new message is currently used only for keys for which Android
generates ACTION_MULTIPLE events.
BUG=265945,270356
R=lambroslambrou@chromium.org
Review URL: https://codereview.chromium.org/214173002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes in this CL include:
1. Initialize breakpad in it2me native messaging host
2. Create bundles for it2me and me2me native messaging hosts and move them out of the me2me host bundle (and update the manifests accordingly).
3. Dump symbols of the it2me and me2me native messaging hosts
4. Sign the me2me and it2me native messaging hosts
4. Rename the me2me host bundle and the prefPane bundle to get rid of the internal chromium/chromoting names and to conform to Mac convention
5. Refactor GYP, build-installer-archive.py, and do_signing.sh, etc to use name constants from branding_chrome and branding_chromium instead of hard coded names. This ensures that all the name constants are defined in a central location and reduces duplicate name definitions.
Here are the names of the host bundles:
me2me host:
old name: org.chromium.chromoting.me2me_host
new name: ChromeRemoteDesktop.Host
Pref pane:
old name: org.chromium.chromoting.prefPane
new name: ChromeRemoteDesktop.prefPane
it2me nm host:
name: NativeMessagingHost
Full Path: /Library/Google/ChromeRemoteDesktop/NativeMessagingHost.app
me2me nm host:
name: RemoteAssistanceHost
Full path: /Library/Google/ChromeRemoteDesktop/RemoteAssistanceHost.app
BUG=
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259287
Review URL: https://codereview.chromium.org/186763004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes both the title and spinner being shown if you add a second
account to the device, then switch back to the Chromoting app.
NOTRY=true
R=jamiewalch@chromium.org
Review URL: https://codereview.chromium.org/214683006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new message will be used for non-keyboard input methods
and software keyboards.
BUG=270356
R=lambroslambrou@chromium.org, nasko@chromium.org
Review URL: https://codereview.chromium.org/197613004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This uses a different method of reloading the accounts spinner if the
device is rotated.
R=jamiewalch@chromium.org
Review URL: https://codereview.chromium.org/213823003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=351526
R=jamiewalch@chromium.org
Review URL: https://codereview.chromium.org/213653003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reloads the system's accounts list whenever the app is started
(so if the user adds an account, then switches back to the app, the
change will be reflected).
This also reloads the host list, which will alleviate many of the
problems with stale OAuth tokens such as in bug 304719.
BUG=304719
NOTRY=true
Review URL: https://codereview.chromium.org/212673010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=jamiewalch@chromium.org
Review URL: https://codereview.chromium.org/211573008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the non-localized ONLINE/OFFLINE text, and adds new
styling to distinguish offline hosts.
This also adds toast to indicate a host is offline.
BUG=331103,355868
Review URL: https://codereview.chromium.org/211953002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This shows a nicer-looking screen with an icon, some text, and some
hyperlink text. The hyperlink opens the Help activity with a web-site
that helps the user set up their hosts for remote access.
NOTRY=true
Review URL: https://codereview.chromium.org/210223008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This adds some binary resources needed by followup CLs.
R=jamiewalch@chromium.org
Review URL: https://codereview.chromium.org/207543007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Breaks Google Chrome build:
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/49089/steps/compile/logs/stdio
> Add breakpad support for me2me and it2me native messaging host on Mac.
>
> Changes in this CL include:
> 1. Initialize breakpad in it2me native messaging host
> 2. Create bundles for it2me and me2me native messaging hosts and move them out of the me2me host bundle (and update the manifests accordingly).
> 3. Dump symbols of the it2me and me2me native messaging hosts
> 4. Sign the me2me and it2me native messaging hosts
> 4. Rename the me2me host bundle and the prefPane bundle to get rid of the internal chromium/chromoting names and to conform to Mac convention
> 5. Refactor GYP, build-installer-archive.py, and do_signing.sh, etc to use name constants from branding_chrome and branding_chromium instead of hard coded names. This ensures that all the name constants are defined in a central location and reduces duplicate name definitions.
>
> Here are the names of the host bundles:
>
> me2me host:
> old name: org.chromium.chromoting.me2me_host
> new name: ChromeRemoteDesktop.Host
>
> Pref pane:
> old name: org.chromium.chromoting.prefPane
> new name: ChromeRemoteDesktop.prefPane
>
> it2me nm host:
> name: NativeMessagingHost
> Full Path: /Library/Google/ChromeRemoteDesktop/NativeMessagingHost.app
>
> me2me nm host:
> name: RemoteAssistanceHost
> Full path: /Library/Google/ChromeRemoteDesktop/RemoteAssistanceHost.app
>
> BUG=
>
> Review URL: https://codereview.chromium.org/186763004
TBR=weitaosu@chromium.org
Review URL: https://codereview.chromium.org/209043004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes in this CL include:
1. Initialize breakpad in it2me native messaging host
2. Create bundles for it2me and me2me native messaging hosts and move them out of the me2me host bundle (and update the manifests accordingly).
3. Dump symbols of the it2me and me2me native messaging hosts
4. Sign the me2me and it2me native messaging hosts
4. Rename the me2me host bundle and the prefPane bundle to get rid of the internal chromium/chromoting names and to conform to Mac convention
5. Refactor GYP, build-installer-archive.py, and do_signing.sh, etc to use name constants from branding_chrome and branding_chromium instead of hard coded names. This ensures that all the name constants are defined in a central location and reduces duplicate name definitions.
Here are the names of the host bundles:
me2me host:
old name: org.chromium.chromoting.me2me_host
new name: ChromeRemoteDesktop.Host
Pref pane:
old name: org.chromium.chromoting.prefPane
new name: ChromeRemoteDesktop.prefPane
it2me nm host:
name: NativeMessagingHost
Full Path: /Library/Google/ChromeRemoteDesktop/NativeMessagingHost.app
me2me nm host:
name: RemoteAssistanceHost
Full path: /Library/Google/ChromeRemoteDesktop/RemoteAssistanceHost.app
BUG=
Review URL: https://codereview.chromium.org/186763004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=655355
R=lambroslambrou@chromium.org
Review URL: https://codereview.chromium.org/210053006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
responses as necessary.
Requires gnubbyd 0.8.37 or later.
BUG=134250
Review URL: https://codereview.chromium.org/205493005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also refactored to use ListView.setEmptyView() to show
the empty state when there are no hosts.
NOTRY=true
Review URL: https://codereview.chromium.org/207543002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=290169
Review URL: https://codereview.chromium.org/195893041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
remoting_host_executable
NOTRY=true
Review URL: https://codereview.chromium.org/203683003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the chromoting app, dialogues boxes are centered using flexbox. There is a recent regression in blink that causes flexbox to stop resizing when the content of its children get smaller. Bug 353216 is filed to track the issue.
https://code.google.com/p/chromium/issues/detail?id=353216
Fix:
There are simpler alternatives to horizontally center DOM elements without using complex layouts like flexbox. This change removes the flex box and sets margin to auto on the dialogs.
BUG=341976
Review URL: https://codereview.chromium.org/201293009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Given that hosts don't always resize the desktop particularly cleanly, we should avoid unnecessary resizes, even if they should theoretically be no-ops. Specifically, if the client has not requested resizing, we should not attempt to restore the size on disconnect.
BUG=226232
Review URL: https://codereview.chromium.org/148113008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
When loading the host list, this replaces the main view with a spinning
progress indicator similar to the GMail example at
http://developer.android.com/design/building-blocks/progress.html#activity
BUG=351523
Review URL: https://codereview.chromium.org/200963002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Move IsStringASCII/UTF8 to base namespace.
>
> Use StringPiece for IsStringUTF8.
>
> TBR=sky
>
> Review URL: https://codereview.chromium.org/196793010
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/198163004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Use StringPiece for IsStringUTF8.
TBR=sky
Review URL: https://codereview.chromium.org/196793010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix all forward-declares and header files referencing CommandLine.
This keeps a "using base::CommandLine" in the command line header file so that the rest of the source files can be changes in a follow-up.
TBR=sky
Review URL: https://codereview.chromium.org/196413016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257514 0039d316-1c4b-4281-b951-d872f2087c98
|