| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
printing/, remoting/, rlz/, sync/, ui/ to use the base:: namespace.
BUG=88666
TEST=no change
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/116433007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=251320
Review URL: https://codereview.chromium.org/108853008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a new GYP target for building Java unittests for Chromoting,
including a simple unittest example.
BUG=322095
Review URL: https://codereview.chromium.org/115953003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Converts creation of MessageLoopForUI from MessageLoop(TYPE_UI) to
MessageLoopForUI.
This is a step in the direction of moving type out of MessageLoop.
BUG=none
TEST=none
R=darin@chromium.org
Review URL: https://codereview.chromium.org/108713004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/98923003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
It isn't needed, since it always matches the size of the allocated Java
bitmap.
Review URL: https://codereview.chromium.org/93873016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ShapedScreenCapturer is a layer on top regular screen capturer that captures
desktop shape and attaches it to the generated frames.
R=wez@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241614
Review URL: https://codereview.chromium.org/93973006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
http://crbug.com/327489
Review URL: https://codereview.chromium.org/109433013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[Reason for revert: failed compile on Linux ASAN Builder.]
> Add ShapedScreenCapturer
>
> ShapedScreenCapturer is a layer on top regular screen capturer that captures
> desktop shape and attaches it to the generated frames.
>
> R=wez@chromium.org
>
> Review URL: https://codereview.chromium.org/93973006
TBR=sergeyu@chromium.org
Review URL: https://codereview.chromium.org/103743005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241617 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ShapedScreenCapturer is a layer on top regular screen capturer that captures
desktop shape and attaches it to the generated frames.
R=wez@chromium.org
Review URL: https://codereview.chromium.org/93973006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=mark@chromium.org
TBR=wez@chromium.org
Review URL: https://codereview.chromium.org/99523009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously the test was always failing, which meant that ApplyBuffer()
always treated the passed-in buffer as the current one, and always asked
the FrameProducer to draw into it, instead of freeing it. Eventually,
the app would run out of memory.
BUG=325590
Review URL: https://codereview.chromium.org/116873004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead we add a gyp file in third_party/google_toolbox_for_mac to build
the sources from third_party/GTM. This is the third and last patch in
this series.
BUG=299841
TEST=None
R=mark@chromium.org,ben@chromium.org
TBR=ben
Review URL: https://codereview.chromium.org/107933006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows us to use CSS instead of JS to do the centering, and means that
there's no need for "position: absolute", and so will which make measuring the
DOM easier when we come to implement scrolling for apps v2.
NOTRY=true
Review URL: https://codereview.chromium.org/114473003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rather than each dependent target of a target that generates jni headers having
to specify the appropriate include_dir manually, jni_generator.gypi can do it
via direct_dependent_settings.
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/111493006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also excluded remoting/host from the _checkSpamLogging PRESUBMIT check.
BUG=
TBR=joi@chromium.org
Review URL: https://codereview.chromium.org/103053006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=grunell@chromium.org, mallinath@chromium.org, sergeyu@chromium.org, wjia@chromium.org
Review URL: https://codereview.chromium.org/103143004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously chromoting host would get relay info only when started. Relay
token expires within several hours, which means relay session creation would
always fail from the host running for longer than several hours, and that
makes connection impossible in some configurations. Moved code that
gets Jingle info to LibjingleTransportFactory and it's responsible for
refreshing relay token every hour.
BUG=318897
R=rmsousa@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240926
Review URL: https://codereview.chromium.org/98173006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Fix LibjingleTransportFactory to refresh STUN/Relay.
>
> Previously chromoting host would get relay info only when started. Relay
> token expires within several hours, which means relay session creation would
> always fail from the host running for longer than several hours, and that
> makes connection impossible in some configurations. Moved code that
> gets Jingle info to LibjingleTransportFactory and it's responsible for
> refreshing relay token every hour.
>
> BUG=318897
> R=rmsousa@chromium.org
>
> Review URL: https://codereview.chromium.org/98173006
TBR=sergeyu@chromium.org
Review URL: https://codereview.chromium.org/116123003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously chromoting host would get relay info only when started. Relay
token expires within several hours, which means relay session creation would
always fail from the host running for longer than several hours, and that
makes connection impossible in some configurations. Moved code that
gets Jingle info to LibjingleTransportFactory and it's responsible for
refreshing relay token every hour.
BUG=318897
R=rmsousa@chromium.org
Review URL: https://codereview.chromium.org/98173006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remoting uses types in webrtc/modules/desktop_capture to represent
rectangles, vectors and regions. This CL removes a few places left where
we were still using Skia types and removes Skia from DEPS.
Also removed leftover InvalidateRegion() declaration from
desktop_session_proxy.h .
R=jamiewalch@chromium.org
Review URL: https://codereview.chromium.org/112453002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
These tests are disabled since they require certificates to be copied
to the device, and net::SSLServerSocket is not implemented for OpenSSL.
BUG=326702
Review URL: https://codereview.chromium.org/112983006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
1. host_starter is only referenced in two rarely used binaries and shouldn't belong in setup_base.
2. setup_base is not needed by it2me.
BUG=
Review URL: https://codereview.chromium.org/114393002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NativeMessagingChannel.
1. Reverse the ownership relation between NativeMessagingHost and NativeMessagingChannel.
a. The host now owns the channel. This gets us ready for the next change in which the host will own an addition channel to communicate with the elevated host. I believe the code is also simpler and cleaner after this change.
b. Removed NativeMessagingChannel::Delegate.
c. The host object, instead of the host process's main method, is now responsible for setting up and starting the channel.
2. Reimplement the threading logic of and re-enable the NativeMessagingHost unit tests.
3. Add ThreadChecker asserts in NativeMessagingHost methods.
BUG=325567,323306
Review URL: https://codereview.chromium.org/103693006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=piman@chromium.org, scherkus@chromium.org, sergeyu@chromium.org
TBR=piman, scherkus, wez
Review URL: https://codereview.chromium.org/114613002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a remoting_unittests_apk target, and enables the tests to
build and run on an Android device.
Followup CLs will fix/disable the failing tests. Once the test-run is
clean, we can add this target to build/all_android.gyp.
BUG=326702
Review URL: https://codereview.chromium.org/111643004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Removed dependency on ChromiumSocketFactory and ChromiumNetworkManager in
LibjingleTransportFactory. It's necessary to compile this code for NaCl.
BUG=276739
Review URL: https://codereview.chromium.org/109393004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I plan (https://codereview.chromium.org/111373002/) to make manifest
handling simpler in gyp. In particular, doing the manifest embedding
in one pass to avoid the need to invoke the linker twice.
In order to do this /manifestdependency on the linker command line needs
to be removed as it creates dependencies that are only made clear by
having the linker generate a manifest. In this case it's simple enough
to simply use a .manifest file with the same dependency information that
can be merged beforehand.
So, move from .gyp linker flags to a file in AdditionalManifestFiles.
R=sergeyu@chromium.org
BUG=324863
Review URL: https://codereview.chromium.org/108303004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=327872,306876
TEST=valgrind out/Debug/remoting_unittests --single-process-tests --gtest_filter=*Rgb*
R=sergeyu@chromium.org
Review URL: https://codereview.chromium.org/103533005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
GetUsername() doesn't belong to remoting/base because it's not used by
the client.
BUG=276739
Review URL: https://codereview.chromium.org/112353002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*****************
Reverting the revert. Congrats, the original CL wasn't the cause for the failure; sorry for the mess.
*****************
> Revert 239759 "The comment in base64.h implies that base::Base64..."
>
> > The comment in base64.h implies that base::Base64Encode() can return false, but
> > this cannot happen in practice. Fix the comment.
> >
> > The implementation of Base64Encode() attempts to check for the return value
> > MODP_B64_ERROR as a failure, but modp_b64_encode() cannot return this
> > value. Remove the check.
> >
> > Remove unneeded integer cast.
> >
> > Change the return type to void.
> >
> > BUG=323357
> > TEST=base_unittests, compile all
> > TBR=jochen@chromium.org,miket@chromium.org,joi@chromium.org,akalin@chromium.org,sergeyu@chromium.org
> >
> > Review URL: https://codereview.chromium.org/86913002
>
> TBR=ricea@chromium.org
>
> Review URL: https://codereview.chromium.org/101113004
TBR=vadimt@chromium.org
Review URL: https://codereview.chromium.org/111883004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> The comment in base64.h implies that base::Base64Encode() can return false, but
> this cannot happen in practice. Fix the comment.
>
> The implementation of Base64Encode() attempts to check for the return value
> MODP_B64_ERROR as a failure, but modp_b64_encode() cannot return this
> value. Remove the check.
>
> Remove unneeded integer cast.
>
> Change the return type to void.
>
> BUG=323357
> TEST=base_unittests, compile all
> TBR=jochen@chromium.org,miket@chromium.org,joi@chromium.org,akalin@chromium.org,sergeyu@chromium.org
>
> Review URL: https://codereview.chromium.org/86913002
TBR=ricea@chromium.org
Review URL: https://codereview.chromium.org/101113004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes base/resources_unittest.cc from Android build, since the
functions in resources.h are not implemented for Android.
BUG=326702
TEST=Target remoting_unittests builds without error.
Review URL: https://codereview.chromium.org/103863006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=320711
TBR=isherman@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/110963003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
this cannot happen in practice. Fix the comment.
The implementation of Base64Encode() attempts to check for the return value
MODP_B64_ERROR as a failure, but modp_b64_encode() cannot return this
value. Remove the check.
Remove unneeded integer cast.
Change the return type to void.
BUG=323357
TEST=base_unittests, compile all
TBR=jochen@chromium.org,miket@chromium.org,joi@chromium.org,akalin@chromium.org,sergeyu@chromium.org
Review URL: https://codereview.chromium.org/86913002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
NOTRY=true
Review URL: https://codereview.chromium.org/111153002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Updated comments in JniInterface.java to document which threads are
used to access fields and methods. Also added synchronization where it's
needed and removed it where it isn't.
A private lock is used instead of synchronizing on JniInterface.class.
BUG=305770
Review URL: https://codereview.chromium.org/90443002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves DevicePathToDriveLetterPath, NormalizeToNativeFilePath, IsLink, and GetFileInfo.
This also removes some explicit "base::" usage in base files I touched.
TBR=jam
Review URL: https://codereview.chromium.org/105293002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The plan is to implement a DelegatingPairingRegistryDelegate class and use it in the normal (unelevated) native messaging host process. But before I work on that I want to do this small cleanup first.
BUG=325567
Review URL: https://codereview.chromium.org/100333003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/92693005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/100573002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/99923002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It is incorrect to wrap close in HANDLE_EINTR on Linux. Correctness is
generally undefined on Mac, but as of r223369, it is incorrect in Chrome on
Mac.
To avoid new offenders, a PRESUBMIT check ensures that HANDLE_EINTR is not
used with close, and that IGNORE_EINTR is only used with close. Unnecessary
#includes of eintr_wrapper.h are also removed.
base/posix/einter_wrapper.h, PRESUBMIT.py, and ppapi/tests/test_broker.cc
contain non-mechanical changes. Variable naming within the latter is updated
per r178174. Missing #includes for <errno.h> in
content/zygote/zygote_main_linux.cc and tools/android/common/daemon.cc were
manually added. Mechanical changes were generated by running:
sed -E -i '' \
-e 's/((=|if|return|CHECK|EXPECT|ASSERT).*)HANDLE(_EINTR\(.*close)/\1IGNORE\3/' \
-e 's/(ignore_result|void ?)\(HANDLE_EINTR\((.*close\(.*)\)\)/\2/' \
-e 's/(\(void\) ?)?HANDLE_EINTR\((.*close\(.*)\)/\2/' \
$(git grep -El 'HANDLE_EINTR.*close')
sed -E -i '' -e '/#include.*eintr_wrapper\.h"/d' \
$(grep -EL '(HANDLE|IGNORE)_EINTR' \
$(git grep -El '#include.*eintr_wrapper\.h"'))
BUG=269623
R=agl@chromium.org, jln@chromium.org
TBR=OWNERS
Review URL: https://codereview.chromium.org/100253002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This also swaps the order of the parameters to GetShmemTempDir so the out
parameter is last, and enhances some documentation.
Review URL: https://codereview.chromium.org/93263002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/92823003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In general, the OS API contract doesn't guarantee that output variables are
not modified on failure, so a Reeceive pattern is fundamentally insecure.
BUG=318531
TEST=current tests
tbr'ing owners for the consumers.
TBR=jvoung@chromium.org, thakis@chromium.org, sergeyu@chromium.org, grt@chromium.org, gene@chromium.org, youngki@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237459
Review URL: https://codereview.chromium.org/71013004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Implemented It2MeNativeMessagingHost and its unit test.
2. It2MeHost now stores only a raw pointer to the host context object whose lifetime is managed by the creator of the it2me host (NPAPI plugin or it2me native messaging host).
3. The native messaging channel now stores the send_message callback instead of getting it from the caller every time a message is received.
4. The native messaging channel no longer tracks the number of pending requests.
BUG=309844
Review URL: https://codereview.chromium.org/61973004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Since a two-finger gesture is also used for scaling, this adds some code
to disambiguate the two gestures.
R=jamiewalch@chromium.org
Review URL: https://codereview.chromium.org/89553002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will cause all rules that do not have msvs_cygwin_shell: 1 to run
using cmd.exe.
R=iannucci@chromium.org
TBR=wez@chromium.org
BUG=123026
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237623
Review URL: https://codereview.chromium.org/86703002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason for revert: Causing compile failure in chrome_util.cc on "Google Chrome Win" http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/21803
TBR=cpu@chromium.org,jvoung@chromium.org,thakis@chromium.org,sergeyu@chromium.org,grt@chromium.org,gene@chromium.org,youngki@chromium.org,rvargas@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/90963002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237541 0039d316-1c4b-4281-b951-d872f2087c98
|