| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure that:
- shebang is only present for executable files
- shebang is #!/usr/bin/env python
- __main__ is only present for executable files
- file's executable bit is coherent
Also fix EOF LF to be only one.
* Do not fix them all at once otherwise the CL would be too large.
TBR=jamiewalch@chromium.org
BUG=105108
TEST=
Review URL: http://codereview.chromium.org/8665013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104314
TEST=no change
Review URL: http://codereview.chromium.org/8662023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The new SimpleClientAuthenticator and SimpleHostAuthenticator implement
the current IT2Me authentication mechanism.
Review URL: http://codereview.chromium.org/8647001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=101178
TEST=Manual
Review URL: http://codereview.chromium.org/8623006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also separate client and host authenticators into separate files.
Review URL: http://codereview.chromium.org/8604001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=sergeyu
CC=chromoting,dhollowa
Review URL: http://codereview.chromium.org/8669007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/8624006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/8468015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8618003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Now all channels are created using CreateStreamChannel() as they should be!
Review URL: http://codereview.chromium.org/8587053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/8573024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
currying, and use less types.
The main API change IgnoreResult() and fully currying. See unittest for what the new API looks like. The rest of the changes are done to support that.
Previously, IgnoreReturn could not be used with WeakPtr<> Bind()s as it was applied after the fact to the Callback object. Now, IgnoreResult() wraps the function like Unretained().
As an incidental benefit, the new implementation gave us fully currying for free.
Also, the new implementation scales better when supporting higher arities of functions. The new type growth is:
(n^2 + 20n) / 2
as opposed to
(3n^2 + 17n) / 2
where n == arity.
For n = 6 and n=10, the new implementation has 81 and 155 templates respectively.
The old implementation had 105 and 235 templates respectively.
BUG=35233,98919,98542
TEST=existing unittests
Review URL: http://codereview.chromium.org/8483003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/8587050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=jamiewalch@chromium.org
Review URL: http://codereview.chromium.org/8558034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8568031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=104314
TEST=no change
Review URL: http://codereview.chromium.org/8601011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8549007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/8528048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The new ClientControlDispatcher and ClientEventDispatcher manage control
and event channels.
Review URL: http://codereview.chromium.org/8574025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8567022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The new HostControlDispatcher manages reading and writing to and from control
channel on the host side. Similarly HostEventDispatcher is responsible for
reading and, in future, writing to and from the event channel.
Review URL: http://codereview.chromium.org/8468022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL includes a Python script, remoting.py, that sets up and runs a virtual X session and host process. It also includes a remoting_me2me_host executable target, which is a simplified version of remoting_simple_host, using the config files that remoting.py sets up.
remoting.py uses Xvfb which needs to be installed (sudo apt-get install xvfb).
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8511029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The new method cancels channel creation for pending channel. This
prevents some potential crashes.
Review URL: http://codereview.chromium.org/8573013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/8568038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/8568023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8520021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/8564037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using the initializer list construct = {0} allows the object to be linker initialized.
Modify the LazyInstance class design to make it a pod aggregate type that can be linker initialized this way. Also combines the instance and state members, in line with the Singleton<> class design.
Introduces a new LAZY_INSTANCE_INITIALIZER macro specifically for using to init all lazy instances + modify all existing callsites to use it. (Old code would no longer compile)
BUG=94925
TEST=existing tests pass. http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=150&header=chrome-si&graph=chrome-si&rev=-1 should step downward.
TBR=jam@chromium.org,rvargas@chromium.org,darin@chromium.org,ben@chromium.org,apatrick@chromium.org,akalin@chromium.org
Review URL: http://codereview.chromium.org/8491043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8527018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8537020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8508036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/8511077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=103937
TEST=see the bug
Review URL: http://codereview.chromium.org/8536032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=98751
Review URL: http://codereview.chromium.org/8511068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8527011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8536002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also made then NonThreadSafe.
BUG=96325
TEST=Chromoting works.
Review URL: http://codereview.chromium.org/8495035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously ChromotingHost was doing some work on the main thread and
some on the network thread. |clients_| and some other members were
accessed without lock on both of these threads. Moved most of the
ChromotingHost activity to the network thread to avoid possible
race conditions.
BUG=96325
TEST=Chromoting works
Review URL: http://codereview.chromium.org/8495024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=103813
TEST=Manual
Review URL: http://codereview.chromium.org/8524013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=Run Chromoting web-app under an account that is not enabled for Me2Me. Web-app should still allow IT2Me functions to be accessed.
Review URL: http://codereview.chromium.org/8509028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8476018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also remove 1 exit time destructor and 2 static initializers.
BUG=101600,94925
TEST=none
Review URL: http://codereview.chromium.org/8509026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Remoting still works.
Review URL: http://codereview.chromium.org/8493020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
MessageReader::~MessageReader() may CHECK because ChromotingClient
may be destroyed without destroying all pending video packets.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8507025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=jscompile runs without errors.
Review URL: http://codereview.chromium.org/8497047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109275 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=Remoting JavaScript should "compile" cleanly with jscompile.
Review URL: http://codereview.chromium.org/8499001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=Run CRD and press D to enable debug logging, then connect to host. Frame Rate should display a value, rather than 'n/a'.
Review URL: http://codereview.chromium.org/8492020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=No "Uncaught Access Token expired" errors logged in JavaScript console if CRD app is opened with a refresh token stored, but no access token cached.
Review URL: http://codereview.chromium.org/8493021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8330004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=100887
TEST=Manual
Review URL: http://codereview.chromium.org/8455003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108891 0039d316-1c4b-4281-b951-d872f2087c98
|