summaryrefslogtreecommitdiffstats
path: root/rlz
Commit message (Collapse)AuthorAgeFilesLines
* [iOS] //rlz:rlz_id should not be build on iOS.sdefresne2016-03-181-8/+10
| | | | | | | | | | | There is no point building this on iOS (if it needs to be build, it probably should be build on the "host" not the "target"). BUG=459705 Review URL: https://codereview.chromium.org/1801043002 Cr-Commit-Position: refs/heads/master@{#381928}
* Fix new -Wconstant-conversion versions after clang r259271thakis2016-02-011-1/+1
| | | | | | | | | | | | | | | http://llvm.org/viewvc/llvm-project?view=revision&revision=259271 made clang's -Wconversion stricter. This (together with https://chromium-review.googlesource.com/#/c/324860/) fixes all new instances in a chromium/mac build. No behavior change. BUG=none Review URL: https://codereview.chromium.org/1650843002 Cr-Commit-Position: refs/heads/master@{#372689}
* Update GN build files for new prefs location.brettw2016-01-301-1/+0
| | | | | | | | | | Updates references from //base:prefs to //components/prefs/ TBR=jam@chromium.org Review URL: https://codereview.chromium.org/1652573002 Cr-Commit-Position: refs/heads/master@{#372540}
* Move base/prefs to components/prefsbrettw2016-01-301-1/+0
| | | | | | | | | | | | | | | | | This change is the minimal move change. It does not update namespaces or includes. Forwarding headers and targets exist to map to the new location. The namespaces, include guards, and references to these files will be updated in follow-ups. The GYP build has been updated to point to the new location because the forwarding headers generated a .gyp file cycle. Avoiding a cycle with libaddressinput is why prefs is a separate .gyp from most of the rest of the components. The GN build uses forwarding targets to keep the change smaller. The json pref store unit tests had to be updated because of the way that they used histograms conflicted with the hsitogram setup of the components unittests. Fortunately, there's a HistogramTester helper for this case, so this patch uses it in for the moved test in place of manually checking histogram counts. json_pref_store_unittests.cc also depended on the files il base/test/data/prefs. Rather than worry about updating all the isolates and such, this just adds the data inline and avoids having separate test files. Reland of http://crrev.com/1648403002 with iOS fix TBR=jam@chromium.org Review URL: https://codereview.chromium.org/1653693002 Cr-Commit-Position: refs/heads/master@{#372536}
* Revert of Move base/prefs to components/prefs (patchset #7 id:120001 of ↵joedow2016-01-301-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1648403002/ ) Reason for revert: Reverting due to failure on iOS builder: https://build.chromium.org/p/chromium.mac/builders/iOS_Device_%28ninja%29/builds/38425/steps/steps/logs/stdio Original issue's description: > Move base/prefs to components/prefs > > This change is the minimal move change. It does not update namespaces or includes. Forwarding headers and targets exist to map to the new location. The namespaces, include guards, and references to these files will be updated in follow-ups. > > The GYP build has been updated to point to the new location because the forwarding headers generated a .gyp file cycle. Avoiding a cycle with libaddressinput is why prefs is a separate .gyp from most of the rest of the components. The GN build uses forwarding targets to keep the change smaller. > > The json pref store unit tests had to be updated because of the way that they used histograms conflicted with the hsitogram setup of the components unittests. Fortunately, there's a HistogramTester helper for this case, so this patch uses it in for the moved test in place of manually checking histogram counts. > > json_pref_store_unittests.cc also depended on the files il base/test/data/prefs. Rather than worry about updating all the isolates and such, this just adds the data inline and avoids having separate test files. > > BUG= > > Committed: https://crrev.com/deb824cd36c02a93854537d70e1853cb9f1c55b9 > Cr-Commit-Position: refs/heads/master@{#372494} TBR=jam@chromium.org,brettw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1645073005 Cr-Commit-Position: refs/heads/master@{#372499}
* Move base/prefs to components/prefsbrettw2016-01-301-1/+0
| | | | | | | | | | | | | | | | This change is the minimal move change. It does not update namespaces or includes. Forwarding headers and targets exist to map to the new location. The namespaces, include guards, and references to these files will be updated in follow-ups. The GYP build has been updated to point to the new location because the forwarding headers generated a .gyp file cycle. Avoiding a cycle with libaddressinput is why prefs is a separate .gyp from most of the rest of the components. The GN build uses forwarding targets to keep the change smaller. The json pref store unit tests had to be updated because of the way that they used histograms conflicted with the hsitogram setup of the components unittests. Fortunately, there's a HistogramTester helper for this case, so this patch uses it in for the moved test in place of manually checking histogram counts. json_pref_store_unittests.cc also depended on the files il base/test/data/prefs. Rather than worry about updating all the isolates and such, this just adds the data inline and avoids having separate test files. BUG= Review URL: https://codereview.chromium.org/1648403002 Cr-Commit-Position: refs/heads/master@{#372494}
* Switch to standard integer types in rlz/.avi2015-12-2228-51/+100
| | | | | | | | | BUG=138542 TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/1547683004 Cr-Commit-Position: refs/heads/master@{#366614}
* clang/win: Let remaining chromium_code targets build with -Wextra.thakis2015-12-103-3/+3
| | | | | | | | | | | | | | | This is a follow-up to https://codereview.chromium.org/1507413003/ and lets all translation units in a release build build if -Wextra is enabled for chromium_code targets. (This CL does not contain the change to actually turn on -Wextra, only cleanups.) BUG=567877 Review URL: https://codereview.chromium.org/1513043002 Cr-Commit-Position: refs/heads/master@{#364425}
* Cleanup: Correctly spell success(ful).thestig2015-11-231-2/+2
| | | | | | | | | TBR=brettw@chromium.org NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1469783002 Cr-Commit-Position: refs/heads/master@{#361166}
* Use std::default_delete as the default deleter for scoped_ptr.dcheng2015-11-191-0/+2
| | | | | | | | | | | The aim is to make scoped_ptr and std::unique_ptr functionally identical so scoped_ptr can simply be a typedef. BUG=554298 Review URL: https://codereview.chromium.org/1445003002 Cr-Commit-Position: refs/heads/master@{#360539}
* Make ValueDeserializer::Deserialize return scoped_ptrolli.raula2015-10-161-2/+2
| | | | | | | | | | | | Make ValueDeserializer::Deserialize return scoped_ptr as almost all consumers already use scoped_ptr and it is also better way to do it. TBR=jam@chromium.org Review URL: https://codereview.chromium.org/1394993004 Cr-Commit-Position: refs/heads/master@{#354458}
* Cleanup: Pass std::string as const reference from rlz/ki.stfu2015-09-202-6/+7
| | | | | | | | | | | | Passing std::string by reference can prevent extra copying of object. BUG=367418 TEST= R=rogerta@chromium.org,thakis@chromium.org Review URL: https://codereview.chromium.org/1353323003 Cr-Commit-Position: refs/heads/master@{#349885}
* Remove a block of rlz code for when _WIN32_WINNT < 0x500.thestig2015-09-181-24/+0
| | | | | | Review URL: https://codereview.chromium.org/1352973002 Cr-Commit-Position: refs/heads/master@{#349707}
* Annotate GN executables and shared_libraries with sanitizer deps.brettw2015-08-311-0/+2
| | | | | | | | | | | | | | | | | These are needed to link in asan/lsan/etc. mode. GYP injects these automatically but GN doesn't have automatic dependency injection. All tests and components (which cover the vast majority of such targets in actual use) are templates which add these dependencies already, so most of the time it never comes up. Only a few of these changes are actually necessary to link all tests run on the asan bot (which is also what engineers will typically build, since almost nobody will build all in asan mode). But to reduce confusion from linker errors in asan mode, I annotated all executables and shared libraries I could find with the sanitizer dependency. I moved a config out of a target in yasm, and sorted a fews deps on other targets. TBR=xhwang@chromium.org (widevine) TBR=achuith@chromium.org (tools/perf, tools/telemetry) Review URL: https://codereview.chromium.org/1318343003 Cr-Commit-Position: refs/heads/master@{#346490}
* Remove remaining legacy SplitString calls.brettw2015-08-121-2/+2
| | | | | | | | TBR=zelidrag@chromium.org (chromeos) Review URL: https://codereview.chromium.org/1284833004 Cr-Commit-Position: refs/heads/master@{#342983}
* Remove legacy StartsWithASCII function.brettw2015-07-162-7/+10
| | | | | | | | | | | This replaces it with base::StartsWith and the appropriate case flag. Since the existing version only ever did case-insensitive tests in ASCII, there should be no behavior change. BUG=506255 TBR=jam Review URL: https://codereview.chromium.org/1242023005 Cr-Commit-Position: refs/heads/master@{#339175}
* Componentize chrome/browser/rlzsdefresne2015-07-161-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add new class RLZTrackerDelegate that abstract access to embedder specific singletons and informations and provide an implementation for Chrome based on the previous implementation. Split rlz_unittest.cc in tests of the RLZTracker and Chrome implementation of the RLZTrackerDelegate interface and move the RLZTracker tests into the component. Add a new gyp/gn variable "enable_rlz_support". This variable is true on the platforms that support RLZ (currently Windows, Mac, iOS and ChromeOS). Use it to build library and unit tests even when the RLZ support is not enabled in the Chrome binary (this is still controlled by "enable_rlz" and depends on the branding). Enable the tests on iOS and convert rlz_tracker_ios.mm to a C++ file. TEST=Run unit_tests and components_unittests on a platform that supports RLZ (Windows, Mac, iOS or ChromeOS) and check that they pass. Then build Chrome with "enable_rlz" and manually checks that RLZ are sent with searches as expected. BUG=504841,508148 Review URL: https://codereview.chromium.org/1212163011 Cr-Commit-Position: refs/heads/master@{#339002}
* Revert "Componentize chrome/browser/rlz"Nico Weber2015-07-091-1/+1
| | | | | | | | | | | | | | | | This reverts commit 311a46585ee5b77486ef42d947bc7cc7566558b1 / #338040, https://codereview.chromium.org/1212163011/. The change broke tests in official builds (http://crbug.com/508659). BUG=504841, 508148, 508659 TBR=sdefresne@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1229933005 . Cr-Commit-Position: refs/heads/master@{#338150}
* Componentize chrome/browser/rlzsdefresne2015-07-091-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add new class RLZTrackerDelegate that abstract access to embedder specific singletons and informations and provide an implementation for Chrome based on the previous implementation. Split rlz_unittest.cc in tests of the RLZTracker and Chrome implementation of the RLZTrackerDelegate interface and move the RLZTracker tests into the component. Add a new gyp/gn variable "enable_rlz_support". This variable is true on the platforms that support RLZ (currently Windows, Mac, iOS and ChromeOS). Use it to build library and unit tests even when the RLZ support is not enabled in the Chrome binary (this is still controlled by "enable_rlz" and depends on the branding). Enable the tests on iOS and convert rlz_tracker_ios.mm to a C++ file. TEST=Run unit_tests and components_unittests on a platform that supports RLZ (Windows, Mac, iOS or ChromeOS) and check that they pass. Then build Chrome with "enable_rlz" and manually checks that RLZ are sent with searches as expected. BUG=504841,508148 Review URL: https://codereview.chromium.org/1212163011 Cr-Commit-Position: refs/heads/master@{#338040}
* Fix some clang warnings with -Wmissing-braces in rlz.dcheng2015-07-011-1/+1
| | | | | | | | | | | Clang warns if there are missing braces around a subobject initializer. BUG=505297 Review URL: https://codereview.chromium.org/1215533005 Cr-Commit-Position: refs/heads/master@{#337085}
* Move more string_util functions to base namespace.brettw2015-06-242-2/+2
| | | | | | | | | | | | | | Rename IsWhitespace to IsUnicodeWhitespace (to contrast it to the already-existing IsAsciiWhitespace). De-inline HexDigitToInt. This is only used in a few places and I don't think it's necessary to inline. Remove some redundant base:: qualifications in base. TBR=sky Review URL: https://codereview.chromium.org/1200053004 Cr-Commit-Position: refs/heads/master@{#335827}
* Migrate callers of message_loop_proxy() to task_runner()skyostil2015-06-171-2/+2
| | | | | | | | | | | | | Migrate callers of {MessageLoop,Thread}::message_loop_proxy() to {MessageLoop,Thread}::task_runner(). Since the types at the call sites have already been updated, this is just a bulk rename. BUG=465354 TBR=armansito@chromium.org Review URL: https://codereview.chromium.org/1179163002 Cr-Commit-Position: refs/heads/master@{#334840}
* Move StartsWith[ASCII] to base namespace.brettw2015-06-122-5/+7
| | | | | | | | | NOPRESUBMIT=true (no presubmit due to removing base:: from a ScopedAllowIO) Review URL: https://codereview.chromium.org/1172183002 Cr-Commit-Position: refs/heads/master@{#334108}
* Make DictionaryValue::DeepCopyWithoutEmptyChildren return a scoped_ptrestade2015-05-231-2/+2
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/1150863002 Cr-Commit-Position: refs/heads/master@{#331223}
* Adjust URLFetcher::Create API so that object is returned as scoped_ptr.dtapuska2015-05-011-2/+2
| | | | | | | | | | | | | | | | | | | | Most interfaces were storing the object in a scoped_ptr already. This adjusts the API so that it is a little clearer of the ownership transfer. A number of clients put the URLFetcher in a table and do memory management on it themselves; this is likely templatable code for a future CL. The scope of this CL was to change the API but no control flow changes. Making this change found one memory leak; (http://crbug.com/482459) has been addressed separately. BUG=371201 TESTS=net_unittests google_api_unittests TBR=jochen@chromium.org, thakis@chromium.org, oshima@chromium.org, armansito@chromium.org, reillyg@chromium.org, rogerta@chromium.org, stuartmorgan@chromium.org, wez@chromium.org, pavely@chromium.org, rouslan@chromium.org Review URL: https://codereview.chromium.org/1117703002 Cr-Commit-Position: refs/heads/master@{#327901}
* rlz: Silence spam from RecursiveCrossProcessLockspang2015-04-231-2/+2
| | | | | | | | | | | | Change perror() to VPLOG() to avoid spamming the console with these errors (they reliably occur on the login screen). BUG=463306 TEST=build, boot, & login to pixel Review URL: https://codereview.chromium.org/1096203003 Cr-Commit-Position: refs/heads/master@{#326621}
* Update {virtual,override} to follow C++11 style in rlz.nick2015-04-231-15/+15
| | | | | | | | | | | | The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was manually generated using a regex and a text editor. BUG=417463 Review URL: https://codereview.chromium.org/1097393008 Cr-Commit-Position: refs/heads/master@{#326517}
* Split ValueSerializer into separate Serializer and Deserializer classes.prashhir2015-03-051-4/+4
| | | | | | | | | | | | | This CL removes the Deserializer functionality from ValueSerializer, and puts into separate class ValueDeserializer, so that class responsibility is maintained. BUG=455453 TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/925783002 Cr-Commit-Position: refs/heads/master@{#319239}
* Apply gn format with 'sources' sorting to src/scottmg2015-02-281-4/+4
| | | | | | | | | | | | Application of https://codereview.chromium.org/962003002/. TBR=keybuk@chromium.org R=brettw@chromium.org BUG=456014 Review URL: https://codereview.chromium.org/960413003 Cr-Commit-Position: refs/heads/master@{#318574}
* Update existing uses of /wd4267 to use the GN configbrettw2015-02-191-8/+6
| | | | | | | | | | This is the size_t to integer conversion warning. Using the config prevents flag duplication and is clearer to read. Minor updates to Win64 build, including some fixes for size_t to int conversions. Review URL: https://codereview.chromium.org/929793006 Cr-Commit-Position: refs/heads/master@{#317162}
* Move GetProcessIntegrityLevel to file_info.h and remove the handle argument.rvargas2015-02-132-16/+12
| | | | | | | | BUG=417532 Review URL: https://codereview.chromium.org/921913002 Cr-Commit-Position: refs/heads/master@{#316242}
* Fix {virtual,override,final} build failures on official CrOS build.Daniel Cheng2015-01-241-28/+25
| | | | | | | | | BUG=417463 TBR=gwilson@chromium.org Review URL: https://codereview.chromium.org/871123002 Cr-Commit-Position: refs/heads/master@{#313000}
* Only send C2F ping for a search through homepage.yiyaoliu2015-01-213-7/+29
| | | | | | | | BUG=8424708 Review URL: https://codereview.chromium.org/591483002 Cr-Commit-Position: refs/heads/master@{#312421}
* Move the test template to //testing/test.gni (part 2)qsr2015-01-211-0/+2
| | | | | | | | | | | | This CL move the test target from build/config/BUILDCONFIG.gn to testing/test.gni It also update the test template to automatically build an apk on Android. R=cjhopman@chromium.org,brettw@chromium.org Review URL: https://codereview.chromium.org/824263004 Cr-Commit-Position: refs/heads/master@{#312396}
* Get rid of net::DO_NOT_PROMPT_FOR_LOGINbaranovich2015-01-151-1/+0
| | | | | | | | | | Used only in content layer BUG=426442 Review URL: https://codereview.chromium.org/786423002 Cr-Commit-Position: refs/heads/master@{#311665}
* Update {virtual,override,final} for rlz/ to follow C++11 style.dcheng2015-01-094-33/+30
| | | | | | | | | | | This patch was automatically generated using a variation of https://codereview.chromium.org/598073004 on a Mac build. BUG=417463 Review URL: https://codereview.chromium.org/828243003 Cr-Commit-Position: refs/heads/master@{#310833}
* Make callers of CommandLine use it via the base:: namespace.avi2014-12-231-1/+1
| | | | | | | | | | | | Covers jingle/, media/, ppapi/, remoting/, rlz/, skia/, and sync/. BUG=422426 TEST=none TBR=ben@chromium.org Review URL: https://codereview.chromium.org/819203002 Cr-Commit-Position: refs/heads/master@{#309502}
* Cleanup: Get rid of base::ASCIIToWide().thestig2014-12-084-51/+44
| | | | | | | | BUG=23581 Review URL: https://codereview.chromium.org/768973003 Cr-Commit-Position: refs/heads/master@{#307333}
* Fix various flags in the Win64 GN builddpranke2014-11-181-0/+5
| | | | | | | | | | | | | | | | | -disable chromium_code for third_party/zlib - suppress a few size_t -> int conversion warnings - suppress /wd4121 (structure padding) by default; was suppressed in GYP but not GN. Also disable ffmpeg, which doesn't work in the 64-bit build yet. R=scottmg@chromium.org TBR=brettw@chromium.org BUG=432375, 167187 Review URL: https://codereview.chromium.org/737633002 Cr-Commit-Position: refs/heads/master@{#304542}
* fix RLZ crasher in process_info.cccpu2014-11-051-75/+8
| | | | | | | | | | | | | | | RLZ is using a very convoluted and fragile way to check for code running as NT/SYSTEM. - It can fail, which causes a crash - It is quite slow on domains - It is incorrect because "SYSTEM" is not the string in some locales. BUG=428944 Review URL: https://codereview.chromium.org/691913003 Cr-Commit-Position: refs/heads/master@{#302741}
* Add some missing deps of rlz.mukai2014-10-291-0/+2
| | | | | | | | | | BUG=None R=rogerta@chromium.org TEST=manually Review URL: https://codereview.chromium.org/678043004 Cr-Commit-Position: refs/heads/master@{#301754}
* Fixing rlz mutexcpu2014-10-292-48/+11
| | | | | | | | | | | | | | | | 0 - Remove special case for Vista. 1- Remove the low integrity logic, broken, wether or not to wait has nothing to do with setting the low integrity label, which was racy and (sometimes) broken. 2- Cleanup of style. BUG=426573 Review URL: https://codereview.chromium.org/686733003 Cr-Commit-Position: refs/heads/master@{#301748}
* Replace OVERRIDE with its C++11 counterparts in src/rlzr.nagaraj2014-10-096-50/+50
| | | | | | | | | | | This step is a giant search for OVERRIDE to replace it with its lowercase versions. BUG=417463 Review URL: https://codereview.chromium.org/633353002 Cr-Commit-Position: refs/heads/master@{#298863}
* Replace forward_dependent_configs with public_depsBrett Wilson2014-09-231-1/+1
| | | | | | | | | | | | This is the new name. It has the same meaning but additionally with a "you can use the headers" permission. Rename direct_dependent_configs to public_configs. This is the new name with identical meaning. TBR=jamesr Review URL: https://codereview.chromium.org/595073002 Cr-Commit-Position: refs/heads/master@{#296302}
* Clean up unused param in RegistryOverrideManagergab2014-09-181-2/+2
| | | | | | | | | | This param has been unused since http://crrev.com/234367 and makes the method confusing. BUG=314800 Review URL: https://codereview.chromium.org/575253002 Cr-Commit-Position: refs/heads/master@{#295400}
* Cleanup: Use base/files/file_util.h instead of base/file_util.h in [r-t]*/thestig2014-09-121-1/+1
| | | | | | | | TBR=sergeyu@chromium.org,cpu@chromium.org,thakis@chromium.org,jamesr@chromium.org,zea@chromium.org,nduca@chromium.org Review URL: https://codereview.chromium.org/560883003 Cr-Commit-Position: refs/heads/master@{#294543}
* Add lots of testonly annotations to the GN build.Brett Wilson2014-09-081-0/+1
| | | | | | | | | BUG= R=hclam@chromium.org Review URL: https://codereview.chromium.org/547793002 Cr-Commit-Position: refs/heads/master@{#293774}
* Revert of Revert of clang/win: Fix a few warnings in targets not in ↵thakis2014-08-311-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | chromium_builder_tests. (patchset #1 id:1 of https://codereview.chromium.org/519463003/) Reason for revert: Reland, wasn't the reason for the redness. (https://codereview.chromium.org/521703002/ was.) Original issue's description: > Revert of clang/win: Fix a few warnings in targets not in chromium_builder_tests. (patchset #3 id:40001 of https://codereview.chromium.org/526513002/) > > Reason for revert: > Speculative, might have broken InstallerStateTest.InitializeTwice on XP: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32481 > > InstallerStateTest.InitializeTwice (run #1): > [ RUN ] InstallerStateTest.InitializeTwice > c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str()) > Actual: false > Expected: true > [ FAILED ] InstallerStateTest.InitializeTwice (219 ms) > > InstallerStateTest.InitializeTwice (run #2): > [ RUN ] InstallerStateTest.InitializeTwice > c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str()) > Actual: false > Expected: true > [ FAILED ] InstallerStateTest.InitializeTwice (109 ms) > > > Original issue's description: > > clang/win: Fix a few warnings in targets not in chromium_builder_tests. > > > > Also don't use "default" as a variable name, as it's a keyword. > > Also fix a bug where a wstring was passed to %ls. > > > > No real behavior change. > > > > BUG=82385 > > R=hans@chromium.org > > TBR=cpu, vitalybuka > > > > Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/d7efa09 > > TBR=hans@chromium.org,robertshield@chromium.org,gab@chromium.org,vitalybuka@chromium.org,cpu@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=82385 > > Committed: https://chromium.googlesource.com/chromium/src/+/dae20dafcfd3ccc439ccc5b3d5e21ad611d13c23 TBR=hans@chromium.org,robertshield@chromium.org,gab@chromium.org,vitalybuka@chromium.org,cpu@chromium.org NOTREECHECKS=true NOTRY=true BUG=82385 Review URL: https://codereview.chromium.org/525013003 Cr-Commit-Position: refs/heads/master@{#292818}
* Revert of clang/win: Fix a few warnings in targets not in ↵thakis2014-08-301-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | chromium_builder_tests. (patchset #3 id:40001 of https://codereview.chromium.org/526513002/) Reason for revert: Speculative, might have broken InstallerStateTest.InitializeTwice on XP: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32481 InstallerStateTest.InitializeTwice (run #1): [ RUN ] InstallerStateTest.InitializeTwice c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str()) Actual: false Expected: true [ FAILED ] InstallerStateTest.InitializeTwice (219 ms) InstallerStateTest.InitializeTwice (run #2): [ RUN ] InstallerStateTest.InitializeTwice c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str()) Actual: false Expected: true [ FAILED ] InstallerStateTest.InitializeTwice (109 ms) Original issue's description: > clang/win: Fix a few warnings in targets not in chromium_builder_tests. > > Also don't use "default" as a variable name, as it's a keyword. > Also fix a bug where a wstring was passed to %ls. > > No real behavior change. > > BUG=82385 > R=hans@chromium.org > TBR=cpu, vitalybuka > > Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/d7efa09 TBR=hans@chromium.org,robertshield@chromium.org,gab@chromium.org,vitalybuka@chromium.org,cpu@chromium.org NOTREECHECKS=true NOTRY=true BUG=82385 Review URL: https://codereview.chromium.org/519463003 Cr-Commit-Position: refs/heads/master@{#292809}
* clang/win: Fix a few warnings in targets not in chromium_builder_tests.Nico Weber2014-08-291-7/+7
| | | | | | | | | | | | | | | Also don't use "default" as a variable name, as it's a keyword. Also fix a bug where a wstring was passed to %ls. No real behavior change. BUG=82385 R=hans@chromium.org TBR=cpu, vitalybuka Review URL: https://codereview.chromium.org/526513002 Cr-Commit-Position: refs/heads/master@{#292699}
generated by cgit v1.1 at 2024-05-04 07:01:50 +0000